Log in

View Full Version : madVR - high quality video renderer (GPU assisted)


Pages : 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 [510] 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329

yok833
30th March 2014, 18:16
Fantastic news!!!
Madshi, have you also noticed an improvement of the performance as reported by qduaty (around 20%)?

Envoyé de mon GT-I9300 en utilisant Tapatalk

TheShadowRunner
30th March 2014, 18:33
That's probably the "show black screen when playback is stopped" change. Seems that the VSFilter type subtitle renderers stop the graph when the user changes the subtitle tracks. I'm not sure if there's anything I can do about that without removing the "show black screen when playback is stopped" feature - which I think is useful. But I'll see if I can detect the situation somehow...
Yes, that has to be "show black screen when playback is stopped".. thanks for looking into it.

kalston
30th March 2014, 18:34
I follow a rigorous testing protocol. All my results are based on the madVR dropped frames counter, not from watching the video.


I only gave that example to illustrate how much I care and worry about the issue. But I saw this phenomenon AFTER reading your posts and for a second I was just worried I might be having the same issue (but thankfully it's unrelated) :)

Anyway good luck on your bug hunting but even though I'm unaffected this really puzzles me. I even occasionally watch high fps files (50-60) and I've yet to encounter any issue with those. Although that's usually videos and not full length films...

madshi
30th March 2014, 20:11
Thank you. Quite frankly, I've been doing tests for days on multiple hardware and software platforms and "bug in madVR" is the only reasonable explanation I can come up with. Problems with hardware or the OS have been ruled out so many times I lost count.

I came to the same conclusion as you while examining the log (with my limited understanding of it) - it looks like madVR just decides to drop a frame for no reason, while the underlying hardware is doing just fine.
Ok, I completed the analyzation of the situation and found a bug. It should (hopefully) be fixed in the next build.

Fantastic news!!!
Madshi, have you also noticed an improvement of the performance as reported by qduaty (around 20%)?
I've not done any performance tests. It will run as fast as it will. Nothing I can do about that, anyway.

madshi
30th March 2014, 20:29
madVR v0.87.8 released

http://madshi.net/madVR.zip

* added workaround for NVidia OpenCL <-> D3D9 interop driver bug
* fixed: #158: NNEDI3 chroma upscaling + DXVA deint + NVidia -> green image
* fixed: DirectCompute rendering resources weren't properly released
* fixed: some multi monitor problems introduced in v0.87.7
* fixed: smooth motion frc sometimes incorrectly dropped frames
* fixed: toggling subtitle "trade quality" option required restart
* some DirectCompute stability improvements
* added vendor based OpenCL device filtering
* non-DX11-GPUs: error diffusion now falls back to ordered dithering
* improved Windows 8.1 FSE mode refresh rate hack
Extra thanks to qduaty for providing the workaround for the NVidia OpenCL driver bug.

e-t172
30th March 2014, 20:36
Wow, that was fast, thanks! I'll get on testing right away to verify the bug fix.

GCRaistlin
30th March 2014, 20:40
added workaround for NVidia OpenCL <-> D3D9 interop driver bug

Does it mean that we can use GeForce drivers newer than 327.23?

nevcairiel
30th March 2014, 20:41
Does it mean that we can use GeForce drivers newer than 327.23?

Yes, I verified it works on 335.23
GTX 660 in my HTPC can only do 32 neurons for 720 -> 1080, and only at 24/25p (32ms rendering with OD, 37ms with ED1), but hey, the 660 isn't the most glamorous card under the sun. ;)

Should performance test my GTX 780. :)

madshi
30th March 2014, 21:41
GTX 660 in my HTPC can only do 32 neurons for 720 -> 1080, and only at 24/25p (32ms rendering with OD, 37ms with ED1), but hey, the 660 isn't the most glamorous card under the sun. ;)
D'ya still have a Maxwell? Would be interesting to hear how that fares compared to the 660, considering that Maxwell seems to have noticeably improved compute performance over Kepler.

nevcairiel
30th March 2014, 22:01
D'ya still have a Maxwell? Would be interesting to hear how that fares compared to the 660, considering that Maxwell seems to have noticeably improved compute performance over Kepler.

Yeah, i bought the 750 for testing the new architecture, its still around.

Important to note is that the 750 is like 30% slower than the 660 in raw performance, but it might still give a bit of insight for the compute side. I'll try to do it tomorrow.

leeperry
30th March 2014, 22:12
Mucho Thanks for the new build but I don't get any picture in FS(whatever FSE or FSW), all I get is a black screen. Windowed mode works fine. Previous builds work fine in FS, I'll happily provide logs if you can't reproduce the problem.

I run W7SP1/HD7850 with the latest WHQL drivers/A4 mono-static/64x NNEDI for 720p@1080p/low debanding/gamut rolling PS script.

cca
30th March 2014, 22:19
Testing with my AMD Radeon 5850 gives weird results with the latest build. NEEDI rendering times seem lower for some reason, but scaling 720p to 1080p produces a very dark image, video is unwatchable. 480p to 1080p works though.

EDIT: Actually the rendering times are way too low, I doubt it even works properly anymore.

EDIT2: Even weirder, if I close MPC-HC and reopen the video, NEEDI works for a few secs then turns dark and rendering times fall. Something is clearly failing.

seiyafan
30th March 2014, 22:22
Could someone with 770/780 test to see how much improvement there is with the latest driver?

madshi
30th March 2014, 22:33
Mucho Thanks for the new build but I don't get any picture in FS(whatever FSE or FSW), all I get is a black screen. Windowed mode works fine. Previous builds work fine in FS, I'll happily provide logs if you can't reproduce the problem.

I run W7SP1/HD8750 with the latest WHQL drivers/A4 mono-static/64x NNEDI for 720p@1080p/low debanding/gamut rolling PS script.
Testing with my AMD Radeon 5850 gives weird results with the latest build. NEEDI rendering times seem lower for some reason, but scaling 720p to 1080p produces a very dark image, video is unwatchable. 480p to 1080p works though.

EDIT: Actually the rendering times are way too low, I doubt it even works properly anymore.

EDIT2: Even weirder, if I close MPC-HC and reopen the video, NEEDI works for a few secs then turns dark and rendering times fall. Something is clearly failing.
Argh. Seems the NVidia fix partially broke NNEDI for AMD and Intel users. Does this build fix the problem?

http://madshi.net/madVR878b.rar

noee
30th March 2014, 22:50
Yup, that fixed it here (HD6570)

Asmodian
31st March 2014, 00:46
I can confirm NNEDI3 in madVR 87.8b works on Nvidia 335.23, nice job on the workaround madshi & qduaty. :)

biggerpapi
31st March 2014, 00:57
Has anybody with an optimus laptop gotten any nnedi3 features to work? Even after the 0.87.8 update and clean installs of my drivers and forcing my 640m to be used with mpc-hc I still get a green screen on the chroma upscaler and a black/red screen with image doubling.

leeperry
31st March 2014, 01:22
Yup, that fixed it here (HD6570)
Same here :)

JonnyRedHed
31st March 2014, 02:08
Having now just experienced image doubling for the first time with my NV GTX670, I must say I'm pretty impressed. Set just luma NNEDI3 to 32neruons with Lanczos3 AR, it doesn't tax the GPU and set the fans off too high. But 64/128 neruons does set the card right off, making too much noise.


Any advice would be good for working with image doubling.



i5 2500k@4.8
16GB Muskin 2133 DDR3
Nvidia GTX 670 PE/OC (MSI) driver 331.82 will try a newer one soon on the next branch from current.
HDMI>50inch LG Plasma@71.928xx custom res.

Fadeout
31st March 2014, 02:54
Have you disabled Desktop Composition (Aero) or made a global change to your driver's V-Sync settings? (such as using adaptive v-sync)

Yeah, I was able to fix the problem by enabling the vsynch in the program settings within Nvidia control panel.

Asmodian
31st March 2014, 03:04
@madshi would it be possible to blank/standby all other screens when madvr goes into FSE mode? For dark room viewing experience.

Or is that something the player should do?

IMO This is something the player should do. I know Zoom Player, for example, has this option.

Farfie
31st March 2014, 03:05
Oh man, this is so exciting! With all the new stuff, and using newest WHQL nvidia drivers in sig, my 680 is just so close to being able to do 720->1440 at 64 neurons + ED2 while changing dither every frame. But it's just a TAD BIT too slow! Argh! I'm talking 1 frame drop per 30-60 seconds close.

One thing about that though, which I had realized in this past but it did not bother me, but now it is because it is affecting whether or not I can use these high end functions...
http://puu.sh/7QgEo.jpg
Why is a 720p video being upscaled to 2560x1520 on my 1600p monitor instead of 1440p? Is there something I don't know about? I have video frame set to "Touch Window From Inside," and I just don't see why it wouldn't go to 2560x1440? This is making it so that after the image doubling, it is using Jinc3 for these few extra (seemingly useless) vertical pixels, which is making me unable to use the aforementioned settings. By switching image upscaling to Lanczos4 though, it becomes doable. But isn't this wrong, or am I missing something?

Either way, this is exciting as hell. Great work to madshi and qduaty!

kasper93
31st March 2014, 05:16
1080p WEB-DL being my preferred TV format

You should go for 720p. 1080p WEB-DL lacks details. They have little bit too low bitrate. Many people were comparing this and 720p with proper upscaling looks just better.


Tapatalk 4 @ GT-I9300

huhn
31st March 2014, 06:08
Oh man, this is so exciting! With all the new stuff, and using newest WHQL nvidia drivers in sig, my 680 is just so close to being able to do 720->1440 at 64 neurons + ED2 while changing dither every frame. But it's just a TAD BIT too slow! Argh! I'm talking 1 frame drop per 30-60 seconds close.

One thing about that though, which I had realized in this past but it did not bother me, but now it is because it is affecting whether or not I can use these high end functions...
http://puu.sh/7QgEo.jpg
Why is a 720p video being upscaled to 2560x1520 on my 1600p monitor instead of 1440p? Is there something I don't know about? I have video frame set to "Touch Window From Inside," and I just don't see why it wouldn't go to 2560x1440? This is making it so that after the image doubling, it is using Jinc3 for these few extra (seemingly useless) vertical pixels, which is making me unable to use the aforementioned settings. By switching image upscaling to Lanczos4 though, it becomes doable. But isn't this wrong, or am I missing something?

Either way, this is exciting as hell. Great work to madshi and qduaty!
just take a closer look:
target, rectangle 0, 80, 2560, 1520

it is 1440 but just moved in the middle of the screen.
if nnedi3 is used for 720 -> 1440 image scaling is only used to to the last part of chroma scaling i guess. that's why lanczos and jinc make the difference it is not used for luma in this case

cca
31st March 2014, 06:29
Argh. Seems the NVidia fix partially broke NNEDI for AMD and Intel users. Does this build fix the problem?

http://madshi.net/madVR878b.rar

Sorry for the late reply, went to sleep last night. Yes, it works perfectly fine now.

StinDaWg
31st March 2014, 06:30
You should go for 720p. 1080p WEB-DL lacks details. They have little bit too low bitrate. Many people were comparing this and 720p with proper upscaling looks just better.
With the exception that 1080p is usually better for animated shows/cartoons.

Farfie
31st March 2014, 08:05
just take a closer look:
target, rectangle 0, 80, 2560, 1520

it is 1440 but just moved in the middle of the screen.
if nnedi3 is used for 720 -> 1440 image scaling is only used to to the last part of chroma scaling i guess. that's why lanczos and jinc make the difference it is not used for luma in this case

No see, the rendering time still goes down when I change the Luma(image) upscaling from Jinc to Lanczos even though it should be a perfect doubling from 720 to 1440 with nnedi3... at least, that's how I understand it.

Also, I thought those numbers meant:
0 (position from left side (x)), 80 (position from top (y)), 2560 (size of video (x)), 1520 (size of video(y))

vivan
31st March 2014, 08:36
Also, I thought those numbers meant:
0 (position from left side (x)), 80 (position from top (y)), 2560 (size of video (x)), 1520 (size of video(y))Those are coordinates of target (output) rectangle.
First 2 are right, while last two are coordinates too, not size. If you want to calculate size you need to subtract them. 2560 - 0 = 2560, 1520 - 80 = 1440.

Asmodian
31st March 2014, 08:37
No see, the rendering time still goes down when I change the Luma(image) upscaling from Jinc to Lanczos even though it should be a perfect doubling from 720 to 1440 with nnedi3... at least, that's how I understand it.

"Image Scaling" is used to scale the chroma if needed. In your case the luma is doubled to 1440 and the chroma needs some way to get to 1440 too. "Chroma Scaling" is only used to take the chroma to 4:4:4 (640x360 -> 1280x720 in your case).

This is not obvious but it makes sense once you understand the steps that need to happen.

Do you dislike ordered dither? If you can almost do NNEDI3 64 luma doubling with ED2 switching to ordered dither seems like a good idea.

Also, I thought those numbers meant:
0 (position from left side (x)), 80 (position from top (y)), 2560 (size of video (x)), 1520 (size of video(y))

1520 - 80 = 1440 ;)

They really mean:
0 (position from left side (x)), 80 (position from top (y)), 2560 (position from left side (x)), 1520 (position from top (y))

Think of them as coordinates for the top left corner and the bottom right corner.

edit: yes, as vivan said. :)

truexfan81
31st March 2014, 08:39
Wow man I'm shocked, i would not have believed that my gtx650 could use nnedi3 at all, but i have it doing the chroma upscailing with 32neurons, using spline36 for everything else, works quite well. Depending on the content gpu usage is anywhere from 45% to 80%. If it gets above 80% the render queue empties and starts dropping tons of frames. if not for that i would push it a little harder.

QBhd
31st March 2014, 08:41
No see, the rendering time still goes down when I change the Luma(image) upscaling from Jinc to Lanczos even though it should be a perfect doubling from 720 to 1440 with nnedi3... at least, that's how I understand it.

Also, I thought those numbers meant:
0 (position from left side (x)), 80 (position from top (y)), 2560 (size of video (x)), 1520 (size of video(y))

If you are not image doubling chroma, Jinc/Lanczos will be used... that is why they are affecting your times as well.

QB

madshi
31st March 2014, 08:41
Yup, that fixed it here (HD6570)
Same here :)
Sorry for the late reply, went to sleep last night. Yes, it works perfectly fine now.
I can confirm NNEDI3 in madVR 87.8b works on Nvidia 335.23, nice job on the workaround madshi & qduaty. :)
Good to hear, thanks.

Has anybody with an optimus laptop gotten any nnedi3 features to work? Even after the 0.87.8 update and clean installs of my drivers and forcing my 640m to be used with mpc-hc I still get a green screen on the chroma upscaler and a black/red screen with image doubling.
Hmmmm... Optimus seems to always be a bit troublesome for some reason. Could you upload a (zipped) debug log?

Also, I thought those numbers meant:
0 (position from left side (x)), 80 (position from top (y)), 2560 (size of video (x)), 1520 (size of video(y))
No, the definition of a rectangle in Windows is usually "left, top, right, bottom".

omarank
31st March 2014, 09:02
Yes I have a DCP sample, but the problem with playing the real DCI-P3 video is that LAV video decoder converts it from XYZ space to sRGB, which madVR receives as content with BT.709 primaries. In this case whether or not I force DCI-P3 primaries, colour cast is there.

Ouch, I don't like that!! @nevcairiel, you there? Why is LAV doing that? FWIW, madVR interprets VIDEOINFOHEADER2 primary index 9 as BT.2020 and index 10 as DCI-P3. So there's really no reason to convert the gamut when sending data to madVR.

I think if LAV does the conversion to DCI-P3 RGB, colours will not look correct with most other renderers. So in my opinion, LAV should provide an option to output XYZ (for madVR) and madVR should do all the conversions. If this can't be done for technical reasons, LAV should provide an option to output DCI-P3 RGB (but then gamma conversion from 2.6 to 2.2 should be done by LAV decoder).

@ Nevcairiel: What do you suggest?



So, in order to check whether madVR is doing the gamut conversion correctly, I used a 100% white pattern clip (BT.709) and forced the primaries as DCI-P3. If the gamut conversion is done correctly with white point matching, 100% white should appear the same for any primaries being forced.

I'm confused. If the white point is different and DCI-P3 is encoded with R=235, G=235, B=235, then after gamut conversion to BT.709, the data can't be 235/235/235, anymore, or am I wrong?

If the gamut conversion is done with white point matching, the data should be 235/235/235 in that case. My understanding of colorimetry is limited though, so maybe someone else can correct me here. Anyway, the point is that if the white point matching is done, there should not be any colour cast with any content being played and this can be best seen with a 100% white pattern.



From what I've read, the conversion from DCI-P3 XYZ to Rec709 RGB should be done using a LUT as this is not a simple colour space conversion. The LUT should take input as XYZ content encoded with gamma 2.6 with DCI white point and peak white at 48 cd/m2, and output Rec709 RGB encoded with gamma 2.2 with D65 white point and peak white at 120 cd/m2.

Is that so? Where did you read that? I'm not really an expert on this, and I'm getting headaches every time I work on this stuff...

I have been reading about this stuff on several forums. I have shared with you the collated information. It will be difficult to provide all the links, but on a quick search I could find these:

See Table 11 in page 67 here -
http://www.dcimovies.com/archives/spec_v1_1/DCI_DCinema_System_Spec_v1_1.pdf

Other links:
http://forum.blackmagicdesign.com/viewtopic.php?f=3&t=18465
http://www.knuterikevensen.com/

(I will share more when I come across the good ones.)

The info which I assimilated was:

1. As DCI-P3 gamut is bigger than Rec709 RGB gamut, outside gamut colours are clipped in the conversion and may lead to artifacts. So a LUT should be used as it gently handles this conversion, as compared to a matrix conversion.
2. In DCI specification, gamma, white point and target peak white luminance are different from the standard Rec709 calibration targets.
3. The DCI white point appears slightly greenish on a D65 monitor. Therefore, relative colorimetric rendering should be used for gamut conversion so that the white point of the source is matched to the target.

Farfie
31st March 2014, 09:04
Those are coordinates of target (output) rectangle.
First 2 are right, while last two are coordinates too, not size. If you want to calculate size you need to subtract them. 2560 - 0 = 2560, 1520 - 80 = 1440.

"Image Scaling" is used to scale the chroma if needed. In your case the luma is doubled to 1440 and the chroma needs some way to get to 1440 too. "Chroma Scaling" is only used to take the chroma to 4:4:4 (640x360 -> 1280x720 in your case).

This is not obvious but it makes sense once you understand the steps that need to happen.

Do you dislike ordered dither? If you can almost do NNEDI3 64 luma doubling with ED2 switching to ordered dither seems like a good idea.



1520 - 80 = 1440 ;)

They really mean:
0 (position from left side (x)), 80 (position from top (y)), 2560 (position from left side (x)), 1520 (position from top (y))

Think of them as coordinates for the top left corner and the bottom right corner.

edit: yes, as vivan said. :)

Ooookay I see now. You guys are great, :thanks:


So what I think the best way to do this would be: nnedi3 luma doubling at 64 neurons, ed2 with option 2, and putting lanczos 4 for image upscaling, so that gets used for the chroma. I was so close to being able to use nnedi3 @64 with ED2 that just switching the image scaling from Jinc3 to Lanczos 4 did the trick :eek: (720p is virtually all I watch, so I won't have to worry about 1080p not being Jinc'd, OR I could just make a profile for >720 srcHeight to use Jinc3)

I chose these, because I think what I've learned from the thread is that for best image quality, computing resources should be spent like so: luma>dithering>chroma. So I figured I would choose ed2 over Jinc3 in image scaling, for 720p video.

Anyway, thanks again!

andybkma
31st March 2014, 09:06
Has anybody with an optimus laptop gotten any nnedi3 features to work? Even after the 0.87.8 update and clean installs of my drivers and forcing my 640m to be used with mpc-hc I still get a green screen on the chroma upscaler and a black/red screen with image doubling.

Ya same, mVR 87.8b still doesn't work with Optimus laptops and I have my media player (Zoom Player) forced to use Nvidia instead of Intel.

With a video paused, as soon as I select use NNEDI3 to double Luma the video turns black

Asmodian
31st March 2014, 09:30
I chose these, because I think what I've learned from the thread is that for best image quality, computing resources should be spent like so: luma>dithering>chroma. So I figured I would choose ed2 over Jinc3 in image scaling, for 720p video.

Anyway, thanks again!

Well those two tradeoffs are both very minor IMO. Chroma doesn't need Jinc3 and ordered dithering looks very good. I would probably switch to ordered dithering myself but it is close. :)

nevcairiel
31st March 2014, 10:16
Ouch, I don't like that!! @nevcairiel, you there? Why is LAV doing that? FWIW, madVR interprets VIDEOINFOHEADER2 primary index 9 as BT.2020 and index 10 as DCI-P3. So there's really no reason to convert the gamut when sending data to madVR.


We've been over this topic before, and back then you even agreed that this is the best course of action to take for compatibility with other renderers.
XYZ will be converted to RGB BT.709 with 2.2 gamma, and even explicitly flagged BT.709 in the media type to stop madVR from assuming wrong things.

The conversion to RGB is implemented by ffmpeg, and if its doing the conversion "wrong" for the defined output of RGB BT.709, we should report it to the ffmpeg developers.
FWIW, ffmpeg does generate a LUT for this conversion.

I do not plan to implemented any special conversions for madVR and for a fringe format like XYZ. If you want, you can get the raw XYZ data, because thats easy, but thats about it.

aufkrawall
31st March 2014, 10:37
Ha, now .8, GPU usage is only at ~50% when playing 4k with Error Diffusion on GK110.
Seems it's not that slow with Compute afterall. :D

madshi
31st March 2014, 10:42
We've been over this topic before, and back then you even agreed that this is the best course of action to take for compatibility with other renderers.
XYZ will be converted to RGB BT.709 with 2.2 gamma, and even explicitly flagged BT.709 in the media type to stop madVR from assuming wrong things.

The conversion to RGB is implemented by ffmpeg, and if its doing the conversion "wrong" for the defined output of RGB BT.709, we should report it to the ffmpeg developers.
FWIW, ffmpeg does generate a LUT for this conversion.

I do not plan to implemented any special conversions for madVR and for a fringe format like XYZ. If you want, you can get the raw XYZ data, because thats easy, but thats about it.
To be honest, I don't remember our past discussion about this, but I'm sure you're right. Is DCI-P3 content decoded to XYZ? I wasn't aware of that (or forgot about it). Which bitdepth/format does the XYZ data have?

In any case, if the DCI-P3 output is BT.709 and there's a color cast, it can't be madVR's fault. So maybe it's a good solution because it's not my responsibility to fix. Haha... :devil:

madshi
31st March 2014, 10:45
If the gamut conversion is done with white point matching, the data should be 235/235/235 in that case. My understanding of colorimetry is limited though, so maybe someone else can correct me here. Anyway, the point is that if the white point matching is done, there should not be any colour cast with any content being played and this can be best seen with a 100% white pattern.
I'm not sure if that's correct. And I'm not sure if white point matching should be done. I simply don't know...

jmone
31st March 2014, 10:57
Great that it is now working with NVidia with NNEDI3! Q though on any suggestions on settings to try for a native 1920x1080p display for maximising quality for:
1) 1920x1080 AVC/264 @ 23.976p/50i/50p/60i Material (have been very happy with Jinc3+AR) then a long second
2) SD 576 PAL Material

Thanks
Nathan

nevcairiel
31st March 2014, 11:01
Is DCI-P3 content decoded to XYZ?

DCP uses JPEG2000 in XYZ at least, not sure if there are any other common sources of DCI-P3.

Which bitdepth/format does the XYZ data have?

XYZ is 12-bit data, not sure what "format" you mean, its in XYZ format of course! :)

nevcairiel
31st March 2014, 11:04
1) 1920x1080 AVC/264 @ 23.976p/50i/50p/60i Material (have been very happy with Jinc3+AR) then a long second
2) SD 576 PAL Material


Native 1080p content doesn't benefit from any of the new settings really, short of the dithering improvements.
Just stick to what you know, and try the error diffusion dithering modes - or stick to ordered dithering.

SD could use NNEDI image doubling for sharper images, if your GPU is up for it.
Try with 32 neurons, or maybe even 64 if your GPU has the power for it.

DragonQ
31st March 2014, 11:12
Yeah, i bought the 750 for testing the new architecture, its still around.

Important to note is that the 750 is like 30% slower than the 660 in raw performance, but it might still give a bit of insight for the compute side. I'll try to do it tomorrow.
Would be nice to see this! I'm pretty sure my desktop GPU is dying (caused PC to freeze 4 times last night; 3 whilst watching video for about a minute, 1 during gaming) and I'm considering a 750 Ti to replace it.

e-t172
31st March 2014, 11:14
I'm not sure if that's correct. And I'm not sure if white point matching should be done. I simply don't know...

I know I've been saying this for a while and at some point you'll probably start ignoring me each time I repeat this, but CMSes (e.g. LittleCMS, Argyll) *do* know how to handle the minute details of gamut mapping, rendering intent, and white point matching. Sorry to be blunt, but you're reinventing the wheel, and it's a *very* complicated wheel to reinvent in an area in which, by your own words, you seem to have limited expertise. Let CMS libraries take that burden off your chest. It would also take the burden of generating 3DLUTs off the chest of your users (since you would be able to support ICC quite easily).

I know you said you don't want to use CMSes or ICC because you find them confusing. I would be happy to answer any questions you might have to clear up any confusion (to the best of my knowledge, of course - in any case we can still ask Graeme). I guarantee you, no matter how confusing these might look to you, they are still way, way easier to understand than the complex color conversion challenges you're facing.

I'm sorry to always bring up this topic again, but it's frustrating to see that this technically superior solution is systematically dismissed with no reasonable explanation. It's your software though, and I know how to use 3DLUTs so it's not that big of a deal for me personally, but still.

Incriminated
31st March 2014, 11:29
* fixed: #158: NNEDI3 chroma upscaling + DXVA deint + NVidia -> green image

I still have this bug:
http://imageshack.com/a/img834/4126/zgr2.jpg

jmone
31st March 2014, 11:51
Thanks Nev

biggerpapi
31st March 2014, 12:25
Well hopefully i did this right and hopefully it helps.

Damien147
31st March 2014, 12:36
Do I still have image doubling working if I set lav video to dxva2(native)??? (got a hd4850)

Incriminated
31st March 2014, 12:41
Yeah doubling/quadrupling with NNEDID3 works for me both qrchoma and luma with 335.23 on gtx 670.

But that was working before already. :)

But chroma upsampling still does not work on Nvidia with LAV dxva-native, unlike the changelog of 0.87.8 tells. :(