Log in

View Full Version : madVR - high quality video renderer (GPU assisted)


Pages : 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 [417] 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329

madshi
10th November 2013, 00:45
Any chances of a deband on/off toggle?
What for? Do you really plan to disable/enable debanding all the time? Isn't a toggle to run through the various options good enough? Normally I'd guess that you just set it to a default value for all movies and just increase the strength for bad files. The current toggle should work fine for that purpose, no?

Just want to run this one by you, one other filter I've often used in Avisynth is Psharpen, IMO it does a fantastic job of sharpening in a natural fashion.
Having come from sharpeners like LSFmod, Seesaw and Finesharp amongst many others over the years I've settled on Psharpen, would you take a look and see if you feel it's worthy for entry into MadVR?
Sorry, no feature requests.

i'm going to get an colorimeter but it is very hard to get information for that at the moment i like to go with the X-Rite EODIS3 i1Display Pro. my aim is to create 3d lut for madvr but is this even the right device or i'm on the wrong path with this ?
There are different names for the meter I'd recommend. The name I remember is "i1 Display 3 Pro". Not sure if that's the one you have in mind.

I notice that the default Zoom Player key mappings conflict with the way you set custom deband values. The arrow keys (all four of them) and F2 are all bound to particular Zoom Player functions, and when you try and set a custom value in madVR, the keys activate Zoom Player functions as soon as you press them. You can of course de-map all of those keys, set the custom values and then re-map those keys back to the original functions, but that is cumbersome. So, I was wondering if you could offer a way for Zoom Player to interact with the custom deband setting without having to de-map the hotkeys first?
Weird. In MPC-HC madVR's keyboard functionality actually "overwrites" the MPC-HC keyboard mapping. So if madVR is in a situation where it accepts arrow key presses, MPC-HC doesn't even see them. Not sure why it's different with ZP. Probably ZP uses a different method to get key presses.

In any case, if Blight wants to make the debanding customization accessible inside of ZP, he can directly edit the registry values. Changes there will only affect the next madVR instance, though, not the current. I don't think it's worth it, though. 99% of all users will probably just use the default presets, and for those arrow keys are not needed. You can also use Ctrl+ArrowKey btw, madVR will still accept that. Maybe that's a solution for you? Not sure if ZP has events registered for that, too?

BTW, I've been meaning to ask you for a while but would you consider keeping all the sub-sections in mVR's config panel permanently open?
Not sure if that's a good idea. Yes, currently all settings fit on one screen, but that might change sooner or later. At least when I implement profiles, users with many profiles will have a long list on the left side and it will not fit on the screen, anymore.

Remembering which sections are open would be a nice feature, but that's not something I can implement in a couple of minutes work, so I consider that a feature request and I don't accept feature requests at the moment (at least not any which cost me more than a couple of minutes of programming work).

I haven't had a chance to try out the presets in these latest builds yet, though the removal of NonGradientPenalty is somewhat concerning, as I found it to do a good job preserving details near black without artifacting as much as LocalContrast, or having as much of a performance hit.
This is going to take a few sentences to explain, but I'll try: The original intention of the NonGradientPenalty was to separate gradient pixels from non-gradient pixels, and to apply a stronger debanding to the gradient pixels. However, the implementation I chose was not really good for testing, because it practically lowered the "midDif" (formerly called "gradient") threshold for almost all pixels in the video, and only left it at the chosen value for very few pixels. So basically if you chose a NonGradientPenalty higher than neutral 1.0, this effectively reduced the midDif/gradient threshold for almost everything. In order to test the real benefit of NonGradientPenalty you had to dial midDif/gradient up the same amount as NonGradientPenalty, to counter this effect.

So recently I decided to change the implemention of NonGradientPenalty to no longer punish the majority of the pixels (namely the non-gradient pixels) and to instead boost the minority of the pixels (namely the gradient pixels). Practically I modified the NonGradientPenalty into a GradientBoost. After I did this I played with high GradientBoost values to see which effect it would have. I even went as high as a 40.0 boost (= 40x factor), but I couldn't really see much (if any) difference. So my final judgement was that the only positive effect of the original NonGradientPenalty was that it turned the midDif/gradient threshold knob down again. Or in other words: Instead of increasing NonGradientPenalty you could also have simply decreased midDif/gradient. So that's what I've done now. Instead of the original "Low" preset of gradient=1.4,nonGradientPenalty=1.2 I'm now simply using gradient=1.2, which produces pretty much the same results.

Of course there's a chance I did something wrong in my testing and nonGradientPenalty actually worked better than I think it did. But my tests with the reversed nonGradientPenalty / gradientBoost were pretty conclusive...

It's not specific to this build, but I've noticed that there are often "outlines" around objects when switching from fullscreen to windowed mode: [...]

This is with debanding disabled, but I'm guessing it's a bug introduced by AngleBoost. They disappear after a few seconds of playback.
I'm not sure what I'm supposed to see in that image?

Something unrelated to that however, is that I was wondering about seeking performance.
I was having to seek through a couple of videos quite a lot the other day, which got me to change my settings to try and improve it.
To give you an idea of what was happening, it was seeking 10s at a time, with the button repeating every 0.1s

The way I had madVR set up before, seeking was very slow and uneven.
Switching to CPU decoding rather than GPU accelerated decoding helped, and of course I unchecked the "disable playback start until render queue is full" option.
After making those changes, it would seek smoothly, but then ever 6-8 seeks, it would freeze up for a second.

The only way I was able to get completely smooth seeking without it pausing was to use Fullscreen Exclusive mode, Windowed Overlay did not seem to help at all.

Is this simply due to the fact that you get better performance in FSE mode, or could it be something else to do with how frames are presented?
I've been avoiding FSE mode ever since installing Windows 8 last year, as madVR keeps switching my display to the wrong refresh rates (23/59 rather than 24/60) but maybe I'll just have to stick with it until that is resolved.

---

And now that I'm using FSE mode again, I'm getting serious problems switching between FSE and Windowed mode when there is a refresh rate change involved. With the maximum queue sizes, I get about 1fps displayed for the first 20s when switching to FSE mode. Reducing the queue sizes to 4 brings that down to about 5 seconds.

This only affects Fullscreen Exclusive and not Fullscreen Windowed mode, and only when there's a refresh rate change involved.
I don't know what to say about this. These are problems I do not experience on my PC. Do many other users have the same problems? I'd have to be able to reproduce this on my PC to be able to do something about it.

I've noticed that it doesn't happen with all files. Try with this one https://dl.dropboxusercontent.com/u/16282309/madVR/sample_002.mkv Doesn't matter which MPC-HC version you use.

It crashes always at the same point. Watch from the beginning its around 0:01 :rolleyes:

And crash is somewhere in "fading" code. When I disable debanding or set settings to (medium/medium) there is no crash. (medium/high) crash always... I think madVR crash internally and then when it is poked by mpc-hc everything crashes.
The sample doesn't crash for me. But the hint with the "fading" code was very helpful - thanks! I've found a bug in that code and hope that the crashes are fixed in build 14 (see below)?

It basically stopped working after replacing with the latest deband build. But since then I've tried replacing it back with the latest official build, resetting to default settings, updating to the latest MPC-HC, updating to the latest stable nvidia drivers, and it's still the same problem. I'm not exactly sure what caused the problem which is why I don't know where to begin.
According to your log switching to exclusive mode worked just fine. Can you clarify "stopped working"? Some more details might help. And please quote my post, that way I can directly click/link through our old communication. Otherwise I have to search through the thread to find your previous posts about this topic.

madshi
10th November 2013, 00:46
Test build 14, hopefully fixing the last crashes?

http://madshi.net/madVRdeband14.rar

kasper93
10th November 2013, 01:29
The sample doesn't crash for me. But the hint with the "fading" code was very helpful - thanks! I've found a bug in that code and hope that the crashes are fixed in build 14 (see below)?

Good work! Everything is fine now. Thanks.

Demonik
10th November 2013, 01:43
Hello, i've found a problem with brightness (too high) while playing a file, problem which i traced back to build 0.85.4, 0.85.3 seems fine. attached a sample here: http://www.sendspace.com/file/dfuqnc
Thank you!

romulous
10th November 2013, 02:40
Weird. In MPC-HC madVR's keyboard functionality actually "overwrites" the MPC-HC keyboard mapping. So if madVR is in a situation where it accepts arrow key presses, MPC-HC doesn't even see them. Not sure why it's different with ZP. Probably ZP uses a different method to get key presses.

In any case, if Blight wants to make the debanding customization accessible inside of ZP, he can directly edit the registry values. Changes there will only affect the next madVR instance, though, not the current. I don't think it's worth it, though. 99% of all users will probably just use the default presets, and for those arrow keys are not needed. You can also use Ctrl+ArrowKey btw, madVR will still accept that. Maybe that's a solution for you? Not sure if ZP has events registered for that, too?


Thanks, I've let bLight know. I also did some quick checking with Ctrl+Arrows, and that does seem to work...the first time. Something seems to be going wrong somewhere. This is what I did.

1. Mapped hotkey to deband custom settings toggle.
2. Hit that hotkey, Low displays on madVR OSD. Hit it again - this time Low displays, but also then lists the values you can change after it.
3. Use the Ctrl+Arrows to move along, change some values. Then hit F2 to save. All seemed to work fine.
4. Hit custom hotkey again, used arrows to move along, change some values - then when I hit F2, Zoom changed to audio mode.

I do note that only the first time I try and change some values, the 'F2' in the madVR OSD displays. Second and subsequent times, it does not (which is why Zoom enters audio mode, madVR is not attempting to intercept that F2 key). I don't know why madVR does not show the F2 prompt the second and subsequent times.

One other thing I noticed - this may be because it is a beta build, but when you select madVR from Zoom's filter properties, a box usually pops up (MadVR Video Renderer Properties). It gives the text madVR, and then the version number - the version number text is totally cut off with this version of madVR (it is fine with the last stable 0.86.11).

ryrynz
10th November 2013, 03:00
What for? Do you really plan to disable/enable debanding all the time? Isn't a toggle to run through the various options good enough? Normally I'd guess that you just set it to a default value for all movies and just increase the strength for bad files. The current toggle should work fine for that purpose, no?



Just useful for quick comparisons. It's a lot easier spotting changes when you can enable and disable rather than running through all presets.


Sorry, no feature requests.


All good.

Ap3 n1nja
10th November 2013, 03:22
I can't reproduce issue with your sample. Are you sure you are using http://madshi.net/madVRdeband13.rar ?
I got crashes for 0.86.10, 0.86.11, deband13, as well as deband14.

Anyway if madVR catch the crash just send report to madshi and he will fix it.
Okay, I sent a report. Can't confirm if it went through or not, however.

Ap3 n1nja,
it's probably this issue http://code.google.com/p/xy-vsfilter/issues/detail?id=153
There's a test build up for XySubFilter which should include such old fixes:
https://dl.dropboxusercontent.com/u/10853398/XySubFilter.7z
Unfortunately, the crashes still happen with version 3.1.0.640...

Thanks for the help though, guys. :D

rack04
10th November 2013, 04:09
Does debanding only work when using the internal decoding? Also, I noticed in Test build 14 the version field in the filter properties isn't viewable.

kasper93
10th November 2013, 04:37
@madshi: There is one minor problem with subtitles in MPC-HC related to this "fading" feature. Basically subtitle blinks. I'm not sure this can be fixed easily fixed. Probably it would need changes in mpc. Anyway I wanted to say that in case you don't know it. Disabling ISR queue fix this glitch.

Does debanding only work when using the internal decoding?
No, it works with every decoder. Anyone is using internal filters? I don't think they are particularity useful.

Also, I noticed in Test build 14 the version field in the filter properties isn't viewable.
Version number is too long probably... But well it's test release, stable will have "normal" number ;p

Okay, I sent a report. Can't confirm if it went through or not, however.
Well, if you send report you need to wait. I'm sure madshi will look at it in the right time :)

Razoola
10th November 2013, 08:57
I was wondering, is there some way to disable the 'EXCLUSIVE' message that appears in the top left corner then a video starts? This never used to happen but I recently updated my GFX card drivers and MPC-HC and after that the issue started happening (I don't know which update caused it to start). I have madVR set up to open video in full screen exclusive mode instantly and I'm not delaying the change by three seconds.

ryrynz
10th November 2013, 09:23
I was wondering, is there some way to disable the 'EXCLUSIVE' message

Not yet.

Incriminated
10th November 2013, 13:16
I really like to have a "toggle exlusive fullscreen mode on/off" in the madVR-trayicon right-click-context-menu, because most of the times I would not like having it enabled for multi-monitor video processing capability, but sometimes i like to have it on for some high-bitrate h264-content to avoid frame-dropps. Actually from this point on i have to click on "edit madvr settings", "rendering", "general settings", switch the "enable automatic fullscreen exclusive mode", click "apply", click "ok". Same for undo/reverting. Thats pretty annoying task, after you did this about 50 times xD.

With a context-menu shortcut it would be possible to reduce it to 1-click (2 click overall). Can you please integrate such function, madshi?

michkrol
10th November 2013, 13:36
With a context-menu shortcut it would be possible to reduce it to 1-click (2 click overall). Can you please integrate such function, madshi?

Try the "automatic fullscreen exclusive mode - enable (disable)" keyboard shortcuts? Every other user would like something in the context menu and it would get cluttered quite fast with options ;)

Incriminated
10th November 2013, 14:19
I wasn't awre of that, but thanks for you noting it. Sadly there is only a shortcut for "on" and one for "off". This way it at least works with two keys. Thanks.

6233638
10th November 2013, 16:19
In order to test the real benefit of NonGradientPenalty you had to dial midDif/gradient up the same amount as NonGradientPenalty, to counter this effect.Ah, I see.

I'm not sure what I'm supposed to see in that image?How it should look:
http://www.abload.de/thumb/roadmrin5.jpg (http://www.abload.de/img/roadmrin5.jpg)

What often happens when switching between fullscreen and windowed mode:
http://www.abload.de/thumb/outlinesfvkns.jpg (http://www.abload.de/img/outlinesfvkns.jpg)

Probably not the exact frame as I just hit pause, but you get the idea.
It doesn't happen every time, but does happen often, and disappears after a few seconds. (I guess once the queues are full again?)

I don't know what to say about this. These are problems I do not experience on my PC. Do many other users have the same problems? I'd have to be able to reproduce this on my PC to be able to do something about it.Well that's concerning, it's 100% reproducible herre. I'm not sure when this change happened either, as I've not used FSE mode for more than a year at this point - it used to work fine for me.

I've tried MPC-HC as well as JRiver now, and it's happening there too.



Is there any way to customize the debanding settings in the newer builds, without editing the registry? I've had a couple of videos now that needed high/high debanding settings to produce smooth gradients, but they were losing far too much detail.

stasjok
10th November 2013, 17:15
The way the new subtitle interface works, madVR needs the GPU to perform subtitle alpha blending - and in 16bit. Unfortunately some older GPUs only support alpha blending in 8bit. For such GPUs you're likely to see an opaque black box instead of smoothly blended subtitles. I'm sorry, but at this point I don't see how I could fix it. It's a hardware limitation of your GPU and the only solution will probably be to upgrade your GPU to a newer model. I believe all newer GPUs can do alpha blending in 16bit without any problems. At least my HD4000 can.


madVR v0.86.10 released


* fixed: #115: XySubFilter: opaque black box on older GPUs


I'm sorry. I didn't get it. I still get this "opaque black box" when smooth motion is enabled. Is it possible to fix this? Or is this "alpha blending in 16bit" required for smooth motion and there is nothing you can do? My GPU is GeForce 9600GT.

Smooth motion disabled
http://s22.postimg.org/8s9povxfx/without.png (http://postimg.org/image/8s9povxfx/)
Smooth motion enabled
http://s22.postimg.org/h997zt24t/with.png (http://postimg.org/image/h997zt24t/)

Ver Greeneyes
10th November 2013, 17:35
What often happens when switching between fullscreen and windowed mode:
http://www.abload.de/thumb/outlinesfvkns.jpg (http://www.abload.de/img/outlinesfvkns.jpg)
I've seen this effect as well, but usually after leaving a video paused and going to bed instead. I don't use FSE mode that much because I'm used to multitasking. My GPU is a GeForce GTX 580 and I'm using the 331.65 drivers.

iSunrise
10th November 2013, 19:13
Ah, I see.

How it should look:
http://www.abload.de/thumb/roadmrin5.jpg (http://www.abload.de/img/roadmrin5.jpg)

What often happens when switching between fullscreen and windowed mode:
http://www.abload.de/thumb/outlinesfvkns.jpg (http://www.abload.de/img/outlinesfvkns.jpg)

Probably not the exact frame as I just hit pause, but you get the idea.
It doesn't happen every time, but does happen often, and disappears after a few seconds. (I guess once the queues are full again?)

Well that's concerning, it's 100% reproducible herre. I'm not sure when this change happened either, as I've not used FSE mode for more than a year at this point - it used to work fine for me.

I've tried MPC-HC as well as JRiver now, and it's happening there too.
Do you have a small sample for that so we can verify? I also am using an Nvidia GPU. Because I have never encountered such a thing and I am using fullscreen exclusive almost exclusively.

I am using a GTX 580 and 331.65 WHQL drivers.

huhn
10th November 2013, 20:26
i can still reproduce this bug: http://abload.de/img/resizingbug0fsot.png

and i completely reinstalled the pc since the last time i posted about this.

it only happens with an nvdia card (an 760) with lanczos 8 ar the hd 4000 is not affected

madshi
10th November 2013, 21:11
Good work! Everything is fine now. Thanks.
Thanks for your help in locating the bug!

Hello, i've found a problem with brightness (too high) while playing a file, problem which i traced back to build 0.85.4, 0.85.3 seems fine. attached a sample here: http://www.sendspace.com/file/dfuqnc
Thank you!
Thanks for figuring out which version introduced the problem. That might be helpful, but first I need more information. On a quick check the sample seems to play fine here. Are you using software or hardware decoding? If you're using hardware decoding, please check whether the same problem also occurs with software decoding. Can you please post a screenshot of the "too high brightness" with the sample you've uploaded?

4. Hit custom hotkey again, used arrows to move along, change some values - then when I hit F2, Zoom changed to audio mode.

I do note that only the first time I try and change some values, the 'F2' in the madVR OSD displays. Second and subsequent times, it does not (which is why Zoom enters audio mode, madVR is not attempting to intercept that F2 key). I don't know why madVR does not show the F2 prompt the second and subsequent times.
The F2 key only works (and only has any purpose) if madVR displays it in the OSD. If madVR doesn't display it, it is also not accepted. The F2 is only accepted if you changed something which is worth saving. The custom debanding settings work differently than everything else. They're always automatically saved, and to a different place than all other settings. So F2 will not be shown if you change custom debanding settings. Really, the custom debanding settings are a hack I implemented because several people asked for it, but I think it will not be used by the majority of users in the future, that's why I didn't invest the time to implement a "nicely", with F2 etc.[/QUOTE]

It's a lot easier spotting changes when you can enable and disable rather than running through all presets.
That may be true, but adding a further toggle would make the settings dialog more complicated, and I don't like to do that, unless there's a very good reason for it. Turning debanding on/off all the time to try spotting changes doesn't sound like something a typical user would do.

I got crashes for 0.86.10, 0.86.11, deband13, as well as deband14.

Okay, I sent a report. Can't confirm if it went through or not, however.
Is your report the one with the text "opening mp4 file, does this every time but other files seems to work ok"? If so, the crash is somehow related to DXVA. Probably turning DXVA off will fix the crash. Not sure why the crash occurs, though. Maybe updating or reinstalling the drivers, or reinstalling D3D9 would help?

Does debanding only work when using the internal decoding?
There is no madVR feature that is limited to only work when using the internal decoders. Except of course decoding.

@madshi: There is one minor problem with subtitles in MPC-HC related to this "fading" feature. Basically subtitle blinks.
Oh yeah, I understand the problem. If a fade in/out is detected, madVR has to go back 5 frames and rerender them, which also means the ISR has to go back in time 5 frames in rerender them, too. The ISR doesn't like that, it usually stutters for a bit when doing such a thing. This problem does not occur with any other subtitle renderer. I don't think there's anything I can do about it, except add an option to not go back those 5 frames. In that case the higher debanding strength would affect the whole fade in/out - with the exception of the first 5 frames. But I'm somewhat reluctant to add an option for a misbehaviour of the ISR.

How it should look:
http://www.abload.de/thumb/roadmrin5.jpg (http://www.abload.de/img/roadmrin5.jpg)

What often happens when switching between fullscreen and windowed mode:
http://www.abload.de/thumb/outlinesfvkns.jpg (http://www.abload.de/img/outlinesfvkns.jpg)

Probably not the exact frame as I just hit pause, but you get the idea.
It doesn't happen every time, but does happen often, and disappears after a few seconds. (I guess once the queues are full again?)
Is this a new problem only occuring with the latest test builds? Or does this occur with the current official release, too? I've never seen anything like that on my PC. I somehow doubt it's my fault, but what do I know. The problem is: Without being able to reproduce the problem, there's probably not much I can do about it.

Well that's concerning, it's 100% reproducible herre. I'm not sure when this change happened either, as I've not used FSE mode for more than a year at this point - it used to work fine for me.

I've tried MPC-HC as well as JRiver now, and it's happening there too.
Do you have another PC you could double check this on? Maybe I didn't do exactly what you did. Maybe if I knew the exact steps you're taking and the exact settings you're using, maybe I could reproduce it, too? If you think there's a good chance of that, please feel free to create a bug entry in the madVR bug tracker.

Is there any way to customize the debanding settings in the newer builds, without editing the registry?
Yes, define a custom keyboard shortcut for "debanding custom settings", press it, then use the arrow keys to modify the parameters.

I'm sorry. I didn't get it. I still get this "opaque black box" when smooth motion is enabled. Is it possible to fix this? Or is this "alpha blending in 16bit" required for smooth motion and there is nothing you can do? My GPU is GeForce 9600GT.
If this only happens with smooth motion enabled then it might be a bug which I could maybe fix. Or not. I don't know. Please report it to the madVR bug tracker.

I've seen this effect as well, but usually after leaving a video paused and going to bed instead. I don't use FSE mode that much because I'm used to multitasking. My GPU is a GeForce GTX 580 and I'm using the 331.65 drivers.
Did this also happen with older drivers?

i can still reproduce this bug: http://abload.de/img/resizingbug0fsot.png
And I've not seen anyone else reporting this. Still not sure if it might be a hardware issue. Or a driver issue. In any case, Lanczos 8 is not recommended, anyway. I'll probably remove non-recommended scaling algorithm in the final v1.0 build. That's still quite some time away, though.

6233638
10th November 2013, 21:24
Is this a new problem only occuring with the latest test builds? Or does this occur with the current official release, too? I've never seen anything like that on my PC. I somehow doubt it's my fault, but what do I know. The problem is: Without being able to reproduce the problem, there's probably not much I can do about it.I thought it was related to the debanding test builds, but it seems that is not the case. I'll post a bug on the tracker - I think I've found a way to reproduce it.

Yes, define a custom keyboard shortcut for "debanding custom settings", press it, then use the arrow keys to modify the parameters.Thanks, I missed that.

Ver Greeneyes
10th November 2013, 21:27
Did this also happen with older drivers?
Not sure - I do know it only started 'recently', but I don't really have a reliable way to reproduce it except 'pause the video for a few hours', which doesn't make for easy testing. The only reason I mentioned it is that the effect I see does look more or less identical to 6233638's screenshot.

Demonik
10th November 2013, 22:05
Ok, did some more tests, it's the same with hardware and software decoding. But while i was testing the madvrdeband version i noticed something else, if i put madVRdeband14 files in a clean install of 0.86.3 it works ok, but if i put them in a clean install of 0.86.4 the brightness issue occurs. here's a screenshot: http://i.imgur.com/talHMqm.jpg

turbojet
10th November 2013, 22:31
i can still reproduce this bug: http://abload.de/img/resizingbug0fsot.png

and i completely reinstalled the pc since the last time i posted about this.

it only happens with an nvdia card (an 760) with lanczos 8 ar the hd 4000 is not affected

I get the same sort of artifacts with ivtc on 2 nvidia cards but it's fine on HD3000, wonder if they are related.

madshi
10th November 2013, 23:19
Ok, did some more tests, it's the same with hardware and software decoding. But while i was testing the madvrdeband version i noticed something else, if i put madVRdeband14 files in a clean install of 0.86.3 it works ok, but if i put them in a clean install of 0.86.4 the brightness issue occurs.
Weird. Can you try to find out which one of the 0.86.4 files is responsible?

Demonik
10th November 2013, 23:32
my bad on the last one, madvrdeband doesn't load with the files from 0.86.3 or before cuz of the renamed madHcNet.dll that's why it 'looked' ok but i was switching them so fast i didn't even notice it's not loading and defaulted to other renderer. back to the previous report of 0.85.3 as beeing the last working one

madshi
10th November 2013, 23:40
Please double check the input levels (Ctrl+Alt+Shift+i). Are they set correctly? And this problem only occurs with this one video? Which decoder are you using? DXVA deinterlacing is turned off, correct? Also double check that the Media Player and madVR brightness and levels controls are all set to neutral values.

Demonik
11th November 2013, 00:03
It's beeing detected as TV, all controls are neutral, deinterlace is off, i'm using lav filters and mpc-hc, tried it in potplayer with same results. yes i've only seen it with this file happening so far.

XeoneR
11th November 2013, 00:38
How to completely disable those blasted popups
about timestamps or filenames in the left upper corner?

Can mad resemble the same behavior as haali?
Halve the initial frame size if the source res is higher than the display.

Ap3 n1nja
11th November 2013, 02:41
Is your report the one with the text "opening mp4 file, does this every time but other files seems to work ok"? If so, the crash is somehow related to DXVA. Probably turning DXVA off will fix the crash. Not sure why the crash occurs, though. Maybe updating or reinstalling the drivers, or reinstalling D3D9 would help?
Nope. The report I sent should have text along the lines of "Simply trying to play the file." I should have been more descriptive. :(

It's the mkv file in my prior post, if you happen to have missed it: http://forum.doom9.org/showthread.php?p=1652373#post1652373

omarank
11th November 2013, 06:17
Hi Madshi, the debanding feature of madVR looks really very impressive. I was trying the latest test build for debanding (madVRdeband14) and encountered a bug. I get a dropped frame for every fade in/ out while using low as default strength and high as strength during fading. This happens only when smooth motion FRC is also active. When I see the frame drops, all the queues look just fine and I don't see anything suspicious. My queues are set as: CPU - 24, GPU - 16 and frames in advance - 12. If I keep the fading strength same as default debanding strength, there are no dropped frames.

MistahBonzai
11th November 2013, 07:58
If I keep the fading strength same as default debanding strength, there are no dropped frames.

Same Here. Was using a local copy of an Emily Shephard video (https://vimeo.com/64036522) (monochrome with lotsa fading) and noted the frame drops. It drove me crazy 'til I disabled debanding. Then narrowed it down to using medium for both settings.

madshi
11th November 2013, 10:05
It's beeing detected as TV, all controls are neutral, deinterlace is off, i'm using lav filters and mpc-hc, tried it in potplayer with same results. yes i've only seen it with this file happening so far.
Very weird. I don't see anything wrong with this file and it plays with correct brightness on my PC. Do you have any other video related DShow filters in the chain except LAV Video Decoder and madVR? Do you have LAV set to default options? Can I get a screenshot with the madVR debug OSD (Ctrl+J) on? Right now I've no idea what's going on there...

How to completely disable those blasted popups about timestamps or filenames in the left upper corner?
These are from MPC-HC. Maybe there's an option in MPC-HC to disable those? I don't know.

Can mad resemble the same behavior as haali?
Halve the initial frame size if the source res is higher than the display.
It's technically possible, but I don't like it, so no, sorry. This is really a feature the media player should offer. It's not the video renderer's job. Haali implements this by lying to the media player. Basically Haali tells the media player that the video really only has half the resolution, which is not true. That's the wrong approach, IMHO. Ask the MPC-HC developers to offer this feature. If MPC-HC asks madVR to display the video in half the size, madVR will obey.

Nope. The report I sent should have text along the lines of "Simply trying to play the file." I should have been more descriptive. :(

It's the mkv file in my prior post, if you happen to have missed it: http://forum.doom9.org/showthread.php?p=1652373#post1652373
Unfortunately that sample plays fine on my PC. Can't reproduce any crashes here. I can't find your bug report. Got a couple of reports in the recent days, but none with such a description. Maybe it would be best to PM the bug report to me.

I get a dropped frame for every fade in/ out while using low as default strength and high as strength during fading. This happens only when smooth motion FRC is also active. When I see the frame drops, all the queues look just fine and I don't see anything suspicious. My queues are set as: CPU - 24, GPU - 16 and frames in advance - 12. If I keep the fading strength same as default debanding strength, there are no dropped frames.
Same Here.
I can reproduce the problem. However, playback still seems perfectly smooth on my PC. It's possible that this is a false alarm in the debug OSD. I'll investigate.

JEEB
11th November 2013, 10:50
It's technically possible, but I don't like it, so no, sorry. This is really a feature the media player should offer. It's not the video renderer's job. Haali implements this by lying to the media player. Basically Haali tells the media player that the video really only has half the resolution, which is not true. That's the wrong approach, IMHO. Ask the MPC-HC developers to offer this feature. If MPC-HC asks madVR to display the video in half the size, madVR will obey.
Just for general information, MPC-HC (and most probably -BE) has this already. View→Options→Playback→Auto-zoom, and the fitting (if larger) setting most probably does what one wants.

And yes, this most definitely is not something a renderer should implement :) .

Demonik
11th November 2013, 10:51
Nope, nothing else in the chain, lav splitter > lav video decoder, default settings.
0.85.3: http://i.imgur.com/U8VW4Hy.png and 0.85.4: http://i.imgur.com/HSKyHD8.png

madshi
11th November 2013, 11:13
Just for general information, MPC-HC (and most probably -BE) has this already.
Oh, cool.

Nope, nothing else in the chain, lav splitter > lav video decoder, default settings.
0.85.3: http://i.imgur.com/U8VW4Hy.png and 0.85.4: http://i.imgur.com/HSKyHD8.png
Ok, I've compared the 0.85.3 and 0.85.4 source code and the only things that changed that I could imagine making a difference are the following:

(1) DXVA related stuff. You don't use DXVA scaling, do you?
(2) File name tags. Do you use those?
(3) Custom pixel shader stuff. Do you use those? Try switching the pixel shader related "trade quality for performance" options. Does that make a difference?

Other than that I don't know what could be going on here...

XeoneR
11th November 2013, 12:47
How to completely disable those blasted popups
about timestamps or filenames in the left upper corner?


These are from MPC-HC. Maybe there's an option in MPC-HC to disable those? I don't know.

Hmm indeed, though i haven't seen them for ages. Haali never renders these.


Can mad resemble the same behavior as haali?


It's technically possible, but I don't like it, so no, sorry. This is really a feature the media player should offer.

Ok that's clear.

I'm switching haali to mad. The cpu load is pretty high.
Almost can't handle rendering of a full bd. What would be the most perf optimized settings?
Scaling algos should be the most demanding? Right? But even switching these to gpu
and applying video frame normal (w/o scaling?) i still get the same high cpu load.

Demonik
11th November 2013, 13:05
Tried switching scaling and performance options, the same. but i did find one option that makes a difference. If i set RGB output level to TV in both versions, it looks the same in both.
screens: http://i.imgur.com/TRZDWbI.png and http://i.imgur.com/zIll0XB.png

madshi
11th November 2013, 13:29
I'm switching haali to mad. The cpu load is pretty high.
Almost can't handle rendering of a full bd. What would be the most perf optimized settings?
Scaling algos should be the most demanding? Right? But even switching these to gpu
and applying video frame normal (w/o scaling?) i still get the same high cpu load.
Most stuff is performed on the GPU by madVR. So switching most of the options doesn't make any difference to CPU performance. Forced film mode is pretty much the only madVR algorithm that runs on the CPU at the moment. So I fear unless you're using Forced film mode, there's not much you can do to lower CPU consumption when using madVR. Have you tried the different rendering modes (windowed, overlay, fullscreen exclusive mode)? Is the CPU consumption equally high in all of them? Maybe in the long run I can lower CPU consumption a bit. I don't know. But at the moment my priority is on other things...

Tried switching scaling and performance options, the same. but i did find one option that makes a difference. If i set RGB output level to TV in both versions, it looks the same in both.
RGB output levels in the GPU? In the decoder? In madVR? Why did you have them set to different levels?

Demonik
11th November 2013, 13:42
In madVR. They were both running with PC levels (0.85.3 and 0.85.4) when i switched them to TV i've noticed the issue doesn't occur. So versions starting from 0.85.4 behave badly only if the output is set to PC. Starting with 0.86.4 TV levels are also affected. Hope this helps?

madshi
11th November 2013, 13:55
This just confuses me even more. So running both with TV output levels the image looks the same with 0.85.3 and 0.85.4? But running both with PC output levels, you get different brightness? This doesn't make any sense to me at all. Can you please make screenshots with 0.85.3, 0.85.4 and 0.86.4, each with both TV and PC levels? So 6 screenshots overall? To be honest, I'm near to giving up on this, because it doesn't make ANY sense to me whatsoever, from a technical point of view. Especially since you say it only occurs with one specific video, which makes it even more weird.

andybkma
11th November 2013, 14:48
Win7 SP1, Zoom Player Max, mVR Deband 14, OPtimus Graphics HD4000 with Nvidia 650M

Been using mVR Deband 14 since yesterday and I have noticed now that about 50% of the time when coming out of FSE back into windowed mode I get the following error code displayed in the top left corner of ZP:

"madVR reports: resetting Direct3D device failed 8876017c"

I press stop on ZP and the error resets itself (error dialogue disappears) and ZP (and mVR) can be used again. How can I get you an error report? It doesn't duplicate all the time...

Werewolfy
11th November 2013, 15:34
@madshi
I did some tests with your latested build. The low preset is fine. nonGradientPenalty removal concerned me a little at first but since you decreased Gradient (or MidDif now), it seems we have the same result here. Anyway, after you created AngleBoost I didn't really feel that nonGradientPenalty was very useful.

I have one little complain about the medium preset. MaxAngle at 0.22 is a little too high for me. Did you find a video where MaxAngle at 0.18 or even 0.20 was too low? It's true that I had set MaxAngle at 0.25 for the high preset but it was only useful for bad videos. I don't think the medium preset needs this because we lose some details sometimes and this preset is too weak to make a difference for bad videos, MaxAngle at 0.22 doesn't seem to change anything for debanding here.

The high preset seems fine to me. I was a little surprised you desactivated AngelBoost here but after making some tests, it makes sense.

I think "Artifact removal" is not a really good name for this function. I understand why you don't call it "debanding" but I don't know... "Postprocessing", "Filter" or even "Postprocessing filter" or "Smoothing" doesn't fit more than "Artifact removal"?

I also tested your new feature called "strength during fade in/out" . If you set it on high, when you have a fade in/out your lose a lot of details during this short period of time. The fade in/out seems to last a little bit longer because details make more time to appear. IMHO, medium seems a better choice by default.

madshi
11th November 2013, 15:59
Been using mVR Deband 14 since yesterday and I have noticed now that about 50% of the time when coming out of FSE back into windowed mode I get the following error code displayed in the top left corner of ZP:

"madVR reports: resetting Direct3D device failed 8876017c"
And this does not happen with the official release build?

I have one little complain about the medium preset. MaxAngle at 0.22 is a little too high for me. Did you find a video where MaxAngle at 0.18 or even 0.20 was too low? It's true that I had set MaxAngle at 0.25 for the high preset but it was only useful for bad videos. I don't think the medium preset needs this because we lose some details sometimes and this preset is too weak to make a difference for bad videos, MaxAngle at 0.22 doesn't seem to change anything for debanding here.
I've no problem at all lowering the MaxAngle for the medium preset. Which value would you prefer?

I think "Artifact removal" is not a really good name for this function. I understand why you don't call it "debanding" but I don't know... "Postprocessing", "Filter" or even "Postprocessing filter" or "Smoothing" doesn't fit more than "Artifact removal"?
I don't want to use one separate settings page for every algorithm. Otherwise I would have chosen "debanding" as the page name. Some day I might add other algorithms, e.g. deblocking or deringing, or things like that. Or even noise reduction, as suggested by some. I don't know if and when I might add those algorithms. But if I do, all of them fit nicely under the name "artifact removal", because all of those algorithms try to fix/repair/improve a bad source or a bad encoding. On the other hand, sharpening is something completely different. And if I ever add sharpening or detail enhancement processing, that would get its own page in the settings dialog. All the algorithms on the "artifact removal" page will be performed *before* scaling. Sharpening and detail enhancement will probably be performed *after* scaling. It's simply something completely different. If you have a better suggestion for the artifact removal settings page name, let me know. But "post processing" doesn't fit, because that would apply to sharpening, too. And "smoothing" is specific to debanding, so it's a bad name, too.

I also tested your new feature called "strength during fade in/out" . If you set it on high, when you have a fade in/out your lose a lot of details during this short period of time. The fade in/out seems to last a little bit longer because details make more time to appear. IMHO, medium seems a better choice by default.
The fade in/out detection should not last a single frame too long. I'm pretty sure it works correctly. Please double check.

I would be ok with choosing medium as default, if the majority of "expert users" here agree on that. Personally, I think "high" is the better choice, because IMHO during fade ins/outs lack of banding artifacts is more important than losing a tiny bit of detail, but that's just my personal opinion, of course. I'll bow to the majority vote.

andybkma
11th November 2013, 16:28
And this does not happen with the official release build?


Nope, never got that error till yesterday when started using the deband version, 13 then 14. Hopefully I can get the problem to duplicate more frequently...

madshi
11th November 2013, 16:32
Does reducing the number of windowed mode backbuffers and/or the number of exclusive mode prepresented frames help in any way?

Werewolfy
11th November 2013, 17:35
I've no problem at all lowering the MaxAngle for the medium preset. Which value would you prefer?


I would set it at 0.18.



I don't want to use one separate settings page for every algorithm. Otherwise I would have chosen "debanding" as the page name. Some day I might add other algorithms, e.g. deblocking or deringing, or things like that. Or even noise reduction, as suggested by some. I don't know if and when I might add those algorithms. But if I do, all of them fit nicely under the name "artifact removal", because all of those algorithms try to fix/repair/improve a bad source or a bad encoding. On the other hand, sharpening is something completely different. And if I ever add sharpening or detail enhancement processing, that would get its own page in the settings dialog. All the algorithms on the "artifact removal" page will be performed *before* scaling. Sharpening and detail enhancement will probably be performed *after* scaling. It's simply something completely different. If you have a better suggestion for the artifact removal settings page name, let me know. But "post processing" doesn't fit, because that would apply to sharpening, too. And "smoothing" is specific to debanding, so it's a bad name, too.


Ok I understand why you've chosen this name. I don't have a suggestion right now but I will think about it. Anyway it's not very important.


The fade in/out detection should not last a single frame too long. I'm pretty sure it works correctly. Please double check.

I would be ok with choosing medium as default, if the majority of "expert users" here agree on that. Personally, I think "high" is the better choice, because IMHO during fade ins/outs lack of banding artifacts is more important than losing a tiny bit of detail, but that's just my personal opinion, of course. I'll bow to the majority vote.

On this sample posted earlier, I find the face takes longer to appear when high is selected. Maybe it's a too extreme example? https://dl.dropboxusercontent.com/u/16254258/test/bandingfest/Rurouni_Kenshin_-_01.mkv

Demonik
11th November 2013, 17:53
This just confuses me even more. So running both with TV output levels the image looks the same with 0.85.3 and 0.85.4? But running both with PC output levels, you get different brightness? This doesn't make any sense to me at all. Can you please make screenshots with 0.85.3, 0.85.4 and 0.86.4, each with both TV and PC levels? So 6 screenshots overall? To be honest, I'm near to giving up on this, because it doesn't make ANY sense to me whatsoever, from a technical point of view. Especially since you say it only occurs with one specific video, which makes it even more weird.

That is correct. screens here:

0.85.3PC (http://i.imgur.com/yrBMxjA.jpg) 0.85.4PC (http://i.imgur.com/7SttAhu.jpg) 0.86.4PC (http://i.imgur.com/QHp41W0.jpg)
0.85.3TV (http://i.imgur.com/ZPx7Ldq.jpg) 0.85.4TV (http://i.imgur.com/NaSK5Fw.jpg) 0.86.4TV (http://i.imgur.com/aqfYMAF.jpg)

madshi
11th November 2013, 18:16
And 0.86.3 behaves like 0.85.4? The only way that makes sense is if the "source black level" and/or "source white level" controls would be set to some unexpected values. These controls can be modified by defining custom key shortcuts in the madVR settings dialog. Or by using file name tagging. I can't imagine you accidently modified the controls, and the file name "sample002.mkv" doesn't contain any file name tags. So it all still makes no sense to me. Try assigning a keyboard shortcut "source color controls - reset" and press that. Does that change anything?

What is the full file name and file path of this video file on your PC?

Are you using any custom pixel shaders?

madshi
11th November 2013, 18:31
I would set it at 0.18.
Ok.

On this sample posted earlier, I find the face takes longer to appear when high is selected. Maybe it's a too extreme example? https://dl.dropboxusercontent.com/u/16254258/test/bandingfest/Rurouni_Kenshin_-_01.mkv
It's a pretty mean example, but I can see what you mean. When frame stepping through the fade in, the first few frames are quite washed out with the "high" setting. The remaining frames of the fade in show little difference between "low" and "high", though. And in motion I'm not sure I see much of a difference, either. There's probably always a sample which works bad with a different setting. I could probably find a sample which with "medium" setting would still show banding during a fade in/out while it wouldn't show banding with "high". With such a sample "high" would look better. So which is the better overall setting? I'm not really sure.

Opinions from other users welcome, as well.