Log in

View Full Version : madVR - high quality video renderer (GPU assisted)


Pages : 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 [284] 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329

cyberbeing
25th September 2012, 12:18
I'll take your word for it then, since I've only tested between 48Hz-120Hz where Overlay > Windowed > FSE in terms of speed.

I'm still a bit curious as to how it's possible that you measured Overlay be slower than FSE @24hz? Shouldn't Overlay be doing the least work out of all the rendering modes?

CiNcH
25th September 2012, 12:50
Technically, with Overlay, I can present one frame in advance. So if there's some timing glitch (maybe the CPU is busy doing something else), a frame drop could occur. With FSE mode, if you prepresent multiple frames in advance, there should be no frame drop, even if the CPU is busy for a relatively long time.
How about using FlipEx (http://msdn.microsoft.com/en-us/library/windows/desktop/ee890072%28v=vs.85%29.aspx#flip_model)? Isn't it similar?

madshi
25th September 2012, 13:23
I'll take your word for it then, since I've only tested between 48Hz-120Hz where Overlay > Windowed > FSE in terms of speed.

I'm still a bit curious as to how it's possible that you measured Overlay be slower than FSE @24hz? Shouldn't Overlay be doing the least work out of all the rendering modes?
I haven't actually tested Overlay speed yet. I was mostly talking about FSE <-> windowed. From a purely technical point of view, Overlay and FSE should be comparable in speed, if the movie frame rate matches the display refresh rate.

How about using FlipEx (http://msdn.microsoft.com/en-us/library/windows/desktop/ee890072%28v=vs.85%29.aspx#flip_model)? Isn't it similar?
I can only use FlipEx or Overlay, but not both at the same time.

oddball
25th September 2012, 14:00
I am having problems playing a test clip. http://hdcam.web-pda.info/

birds - 18514072.mp4

MadVR says the source filter is reporting it as 1.000FPS and playing it at 23.976Hz using MadVR auto-switching which is obviously incorrect as the video is 59.940FPS. Using EVR instead of MadVR and it plays at the correct refresh rate.

Using latest LAV filters for splitting and decoding.

Also if I add the line 1080p60 and play the 4.Girls.YoonYoon-1080p60fpsRef5-21Mbps.mkv test clip it plays at 60Hz when the source filter says 59.940FPS.

Any ideas?

naoan
25th September 2012, 14:12
Yes.

Thanks. IMO You might as well hide it for ATi users to prevent user confusion then, though is there any chance to have it available on ATi card? or is it completely unusable due to their bad driver?

cyberbeing
25th September 2012, 14:24
When you get around to updating 'madVR [benchmark]', will it be possible to add a modes for benchmarking the maximum achievable fps with each (Overlay/Windowed/FSE) rendering method?

Also semi-related, have you had any further thoughts about allowing high framerate (i.e. 60fps+) video to have it's own section so lighter weight settings could be specified? Or maybe add something like a temporary emergency fallback, when madVR detects performance is below a certain threshold at the beginning of playback?

Prinz
25th September 2012, 14:29
bLight the Zoomplayer Developer asked me to post my madvr/Zoomplayer Error here.

I get an "Unbekannter Fehler" after switching the display mode between 1080p24, 1080p50, 1080p59.

This only happens with newer Zoomplayer Versions 8.5 pre and rc1. Zoomplayer 8.16 and also MPC-HC is not affected.

madvr 0.82.5 , 0.83.1 and 0.83.4 tested. All give this Error with the newer Zoomplayer Versions. The second Error (Application Error) only happens with the newer Versions 0.83.* and only sometimes.

http://i46.tinypic.com/t8u69e.jpg

Zoomplayer Bugtracker (http://bugs.zoomplayer.com/bug.php?op=show&bugid=312)

Link to a Debug-Log while the Error was displayed:
Log (https://www.dropbox.com/s/7nhxd9kp6ao1r66/madVR%20-%20log.zip)

madshi
25th September 2012, 14:42
Thanks. IMO You might as well hide it for ATi users to prevent user confusion then, though is there any chance to have it available on ATi card? or is it completely unusable due to their bad driver?
Some users might have a dual Intel/ATI setup, sometimes using the Intel GPU, sometimes the ATI GPU. So hiding this setting isn't a good idea because they might want to use overlay for the Intel GPU. Also, maybe some future AMD driver will enable overlay. So I prefer to keep the checkbox.

When you get around to updating 'madVR [benchmark]', will it be possible to add a modes for benchmarking the maximum achievable fps with each (Overlay/Windowed/FSE) rendering method?

Also semi-related, have you had any further thoughts about allowing high framerate (i.e. 60fps+) video to have it's own section so lighter weight settings could be specified? Or maybe add something like a temporary emergency fallback, when madVR detects performance is below a certain threshold at the beginning of playback?
These are all things I'll eventually implement, when I find the time.

bLight the Zoomplayer Developer asked me to post my madvr/Zoomplayer Error here.
I'm sorry to do this to you, but I don't think there's much I can do about the problem without futher information. I simply don't have enough information to locate the problem. For all I know, it could be in ZoomPlayer just as much as it could be in madVR. What would really help would be if Blight could compile a Zoomplayer test build with "madExcept" enabled. That way we would get more useful crash information. If you tell him that, he'll know what to do.

I am having problems playing a test clip. http://hdcam.web-pda.info/

birds - 18514072.mp4

MadVR says the source filter is reporting it as 1.000FPS
And madVR is correct about that. It seems to be a bug in LAV, so please report it to Nev in the LAV thread.

Also if I add the line 1080p60 and play the 4.Girls.YoonYoon-1080p60fpsRef5-21Mbps.mkv test clip it plays at 60Hz when the source filter says 59.940FPS.
If you add such a tag to a file name, madVR thinks that you want to overwrite the frame rate to 60.000Hz. That's not a bug but intended behaviour. Change it to 1080p59 and the problem should go away.

oddball
25th September 2012, 15:01
Thanks. I will report that bug to Nev. Also when playing back a 29.970FPS file that uses frame decimation to achieve 23.976fps MadVR will switch to 59.940Hz if the switch 1080p59 is used alongside any others. However if I don't use that switch in MadVR and use MPC-HC auto-switching instead (still using MadVR as the renderer) then it is decimated to the correct 23.976 (MadVR shows lots of dropped frames which I assume is correct as the video playback is smooth as silk). I tried adding 1080i29 to see if it helped but MadVR insists on switching to 59.940Hz when it should be 23.967Hz for frame decimation to work???

Or am I doing something wrong and the dropped frames are not due to frame decimation?

Pat357
25th September 2012, 15:02
Mock up of FSE mode seekbar with filename displayed on the left. Some comments on this please.

http://imageshack.us/a/img577/793/newyg.th.jpg (http://imageshack.us/photo/my-images/577/newyg.jpg/)

I like this !
It looks clean and "almost" professional :D

SamKook
25th September 2012, 15:31
Can I have a debug log with v0.83.4, please?

It took me a while to figure out that it was created on the desktop instead of the video folder or MadVR install folder(a message that say's where the log is created when you activate debug mode would be nice) but here it is: http://www.mediafire.com/file/6pe56fufjr6i2c6/madVR_log_SamKook_2012-09-25.rar

cyberbeing
25th September 2012, 16:05
Crash when activating FFDShow's resize filter during playback with horizontal size set to 4096.

Crash & Debug logs (http://www.mediafire.com/?mpn5dsu1k3yxme3)

oddball
25th September 2012, 16:23
I think I figured it out. Needed to add 1080p29

CiNcH
25th September 2012, 16:37
I just checked clock deviation with my newly built HTPC which is based on a Core i3-3225 with HD 4000 graphics. HDMI Audio is supplied by the OnBoard RealTek ALC898 (MSI Z77A-GD65). I tried 576i25 (deinterlaced to 50fps @ 50Hz) and 1080p (@23Hz) source material.

Here is what madVR displayed after about 1 hour of playback...

576i25:
display 50.00090Hz [diff: +0.0009]
clock deviation 0.00180%
A frame drop is supposed to occur every few days, number heavily fluctuates

1080p:
display 23.97227 [diff: -0,00373]
clock deviation 0.00090%
1 frame drop every 4.18 minutes


At 50Hz, the actual refresh rate is much closer to the target. Still the calculated clock deviation is higher compared to the 23Hz mode. The clock deviation should be much smaller for the more accurate 50Hz mode, shouldn't it? Don't you derive the VSync clock from the D3D raster status? Drop rate seems to more closely reflect the refresh rate accuracy.

cyberbeing
25th September 2012, 16:56
576i25:
display 50.00090Hz [diff: +0.0009]
clock deviation 0.00180%
A frame drop is supposed to occur every few days, number heavily fluctuates
Optimal Refresh rate: 50.00090Hz (diff: 0.00000)

1080p:
display 23.97227 [diff: -0,00373]
clock deviation 0.00090%
1 frame drop every 4.18 minutes
Optimal Refresh rate: 23.97624Hz (diff: 0.00397)

The clock deviation should be much smaller for the more accurate 50Hz mode, shouldn't it?
Not necessarily, since that's not what clock deviation represents.

CiNcH
25th September 2012, 17:11
Not necessarily, since that's not what clock deviation represents.
But a higher clock deviation should result in a higher drop rate. Above it is the other way around. Maybe madVR does not handle a negative deviation properly? In this case, no frame should be dropped but repeated..

cyberbeing
25th September 2012, 17:16
But a higher clock deviation should result in a higher drop rate.
That's absolutely false. You could theoretically have a massive clock deviation with a dropped frame interval in days.

In simple terms, you could probably think of clock deviation as a representation of how much faster or slower your actual playback rate is compared to your video framerate.

CiNcH
25th September 2012, 17:21
In simple terms, you could probably think of clock deviation as a representation of how much faster or slower your actual playback rate is compared to your video framerate.
I actually think of it as the speed difference between video playback (based on graph reference clock which is the audio clock) and video output (VSync based on GPU clock). To compensate for the two rates, frames have to either be dropped or repeated, depending on the drift direction. The higher the deviation between the two, the more frames have to be repeated/dropped.

cyberbeing
25th September 2012, 17:35
I actually think of it as the speed difference between video playback (based on graph reference clock which is the audio clock) and video output (VSync based on GPU clock). To compensate for the two rates, frames have to either be dropped or repeated, depending on the drift direction. The higher the deviation between the two, the more frames have to be repeated/dropped.

That's all well and good, but that's completely different from what madVR's clock deviation calculation represents.

fairchild
25th September 2012, 18:21
I just watched The Avenger's Blu-ray with v0.83.4 and not a single drop frame or glitch while using FSE (while using Lav filters + reclock), great job madshi!

mark0077
25th September 2012, 18:52
Ok, sorry, please try with v0.83.4.


Debug log attached from 0.83.4 after seeing the Direct3D error. With mpc-hc closed, I opened a file directly in FSE, and then double clicked mpc-hc's window to get to overlay mode and saw the Direct3D error appear, mpc-hc also paused itself after the error.

http://www.sendspace.com/file/ojmmei

I also have an issue, I'm not sure if its expected. Resizing the windowed overlay mode shows strange looking effects inside the window, like a stair step scaling effect, with a dark red background.

Pat357
25th September 2012, 20:45
Debug log attached from 0.83.4 after seeing the Direct3D error. With mpc-hc closed, I opened a file directly in FSE, and then double clicked mpc-hc's window to get to overlay mode and saw the Direct3D error appear, mpc-hc also paused itself after the error.
I had the same error a few times : always when switching from FSE to overlay.
I think madshi could try to speed up the destruction from the D3D-surface that is left from FSE on the moment you switch to overlay.
Because FSE "holds" the D3D until it's destructed, Overlay can't create a new one.
Another option could be not to destroy the D3D from FSE, but.., if this is somehow feasible, re-use it instead for Overlay . The minimum time gain would be the time needed for destruction + creation from a new D3D-surface.

I also have an issue, I'm not sure if its expected. Resizing the windowed overlay mode shows strange looking effects inside the window, like a stair step scaling effect, with a dark red background.
Are you resizing using the mouse ?
For me, If I use the keyboard (ctrl +1, ...) to resize to a predefined size, the process is smooth.
But if I use the mouse to resize, I see indeed strange things, because I'm in fact resizing to a changing target-size in every step, until I finally have the size that I wanted.

yok833
25th September 2012, 22:04
I run the last version of Madvr + AMD 6850.
When I use FSE, I have dropped frame but if I stay in FS, everything is very smooth...??? Before it was completely the opposite???
Have I made something bad with MPCHC??? I have tried many times but I cannot fix this issue :5

TheShadowRunner
25th September 2012, 23:46
Hi madshi, could you possibly make the new "slower/delay stopping playback" optional ?
Here it's significantly slower (than 0.82.5) and brings absolutely nothing (madVR has _never_ crashed on stopping playback/exiting player). On XP SP3/ ZoomPlayer..

Blight
25th September 2012, 23:58
Prinz:
Here's a MadExcept enabled version of ZP's latest MAX build:
https://dl.dropbox.com/u/104094858/zplayer_madExcept.rar

Blight
26th September 2012, 00:03
Madshi:
Yes, enabling overlay showing up a black screen until a new graph is loaded was with Aero Enabled.
I'll do more tests and provide logs once I can free up more time :/

andybkma
26th September 2012, 04:12
Hi madshi, could you possibly make the new "slower/delay stopping playback" optional ?
Here it's significantly slower (than 0.82.5) and brings absolutely nothing (madVR has _never_ crashed on stopping playback/exiting player). On XP SP3/ ZoomPlayer..

I second this request. Have never experienced an mVR crashing problem upon stopping or exiting player.

Prinz
26th September 2012, 09:22
Prinz:
Here's a MadExcept enabled version of ZP's latest MAX build:
https://dl.dropbox.com/u/104094858/zplayer_madExcept.rar

Bugreport (https://www.dropbox.com/s/b659j3u7nyzi053/bugreport.zip)

madshi
26th September 2012, 09:34
It took me a while to figure out that it was created on the desktop instead of the video folder or MadVR install folder(a message that say's where the log is created when you activate debug mode would be nice) but here it is: http://www.mediafire.com/file/6pe56fufjr6i2c6/madVR_log_SamKook_2012-09-25.rar
Debug log attached from 0.83.4 after seeing the Direct3D error. With mpc-hc closed, I opened a file directly in FSE, and then double clicked mpc-hc's window to get to overlay mode and saw the Direct3D error appear, mpc-hc also paused itself after the error.

http://www.sendspace.com/file/ojmmei
Thanks, I'll have a look at those logs.

I also have an issue, I'm not sure if its expected. Resizing the windowed overlay mode shows strange looking effects inside the window, like a stair step scaling effect, with a dark red background.
I fear there's not much I can do about it. It seems this effect is caused by the Overlay color key not being update quickly enough.

Crash when activating FFDShow's resize filter during playback with horizontal size set to 4096.

Crash & Debug logs (http://www.mediafire.com/?mpn5dsu1k3yxme3)
This looks like a bug in ffdshow to me. Basically ffdshow is sending a buffer which is too small to actually contain a frame in the size it says it's sending.

Another option could be not to destroy the D3D from FSE, but.., if this is somehow feasible, re-use it instead for Overlay .
But that's what I'm already doing!!

I run the last version of Madvr + AMD 6850.
When I use FSE, I have dropped frame but if I stay in FS, everything is very smooth...??? Before it was completely the opposite???
Have I made something bad with MPCHC??? I have tried many times but I cannot fix this issue :5
That is weird. In FSE mode, in the madVR debug OSD (Ctrl+J) are all queues full? Or are some of them empty or near empty? Which ones? Maybe you can make a screenshot of the debug OSD in the moment when you get frame drops?

Hi madshi, could you possibly make the new "slower/delay stopping playback" optional ?
Here it's significantly slower (than 0.82.5) and brings absolutely nothing (madVR has _never_ crashed on stopping playback/exiting player). On XP SP3/ ZoomPlayer..
I second this request. Have never experienced an mVR crashing problem upon stopping or exiting player.
Oh well, I can try, but it will be difficult. I can't simply go back to the old solution, that's impossible due to some other changes I've done (allowing multiple madVR instances at the same time).

Yes, enabling overlay showing up a black screen until a new graph is loaded was with Aero Enabled.
I'll do more tests and provide logs once I can free up more time :/
Thanks, but more tests and logs are not necessary for this specific problem. I can reproduce it, and I've found no way to fix it. It seems to be an NVidia driver bug. It would be interesting whether the same problem occurs with Intel, too, though. Maybe it's a bug in D3D and not in the GPU driver? In any case, I don't think I can fix it. I've really tried, even totally destroyed and recreated the D3D devices, but it doesn't help.

Bugreport (https://www.dropbox.com/s/b659j3u7nyzi053/bugreport.zip)
@Blight, what does ZP do here:

> dwTaskbarThumbnails 331 +7 TdwTaskbarThumbnails.DoUpdate

Could that code line result in an EOleException exception somehow?

cyberbeing
26th September 2012, 10:07
This looks like a bug in ffdshow to me. Basically ffdshow is sending a buffer which is too small to actually contain a frame in the size it says it's sending.

Is there nothing you can do about it then? It seems every video renderer in MPC-HC except madVR is able to handle that case fine.

Blight
26th September 2012, 12:20
Madshi:
I believe (not sure) that most (all?) of the MadVR freezes when switching to a next track or when closing a player was due to FSE being active while terminating D3D.
As you know, I wrote a work-around for this issue by instructing MadVR to exit FSE before I cleared the graph.
The question is, do you really need to wait until D3D is fully cleared as you do in 0.83.x or is exiting FSE enough to maintain the same level of stability...
If just existing FSE is enough, you may want to consider returning to the 0.82.5 exit function as it was much faster.
If you don't feel comfortable with that, I'm sure some users would appreciate a 'Fast D3D Close' checkbox.

'dwTaskbarThumbnails 331 +7 TdwTaskbarThumbnails.DoUpdate' is updating the windows taskbar thumbnail buttons (the buttons that appear under the task bar thumbnail).
I have no idea why it would trigger on a refresh rate change, I don't specifically call it in my code as far as I can tell... I only create the icons once and only update their image index depending on events such as play/pause and mute on/off.

Prinz
26th September 2012, 12:57
depending on events such as play/pause

And that event is properly triggered by the madvr option:

delay playback until render queue is full

If I deactivate that option, the error doesn't happen anymore and vice versa.

leeperry
26th September 2012, 13:35
I second this request. Have never experienced an mVR crashing problem upon stopping or exiting player.
Same here, but it's only taking like an extra quarter of a second compared to older builds.......I think we tend to abuse madshi's kindness :sly:

Take a look at what the coder of foobar2000 tells to his users: http://www.hydrogenaudio.org/forums/index.php?showtopic=21512&view=findpost&p=427970
To start with, foobar2000 was never meant to be usable for everyone.
We simply don't care whether specific userbase finds it useful or not. We would probably care if we earned money from it, but we don't [..] There's plenty of other players around.

His forum is full of feature requests(and very simple ones, such as getting rid of the horrid alien face icons that are being forced at every lauch), HE DOESN'T CARE because he works for free. He wrote foobar for his own use(much like madshi does) and he couldn't care less about end-(l)users needs.

Haali is the same, he only cares about bug reports when BetaBoy shows the green.

It's taking 250ms to close now, big deal :D

madshi
26th September 2012, 14:36
Is there nothing you can do about it then? It seems every video renderer in MPC-HC except madVR is able to handle that case fine.
From the log I've seen it was clearly a bug in ffdshow. I've tried to reproduce it on my XPSP3 machine and the problem doesn't seem to occur here. Maybe it depends on the ffdshow, the decoder, the OS, the GPU, whatever. Anyway, I'm not feeling like sinking a couple of hours of my time into trying to find a workaround for what seems like an ffdshow bug to me, which I can't even reproduce on my dev PC.

I believe (not sure) that most (all?) of the MadVR freezes when switching to a next track or when closing a player was due to FSE being active while terminating D3D.
As you know, I wrote a work-around for this issue by instructing MadVR to exit FSE before I cleared the graph.
The question is, do you really need to wait until D3D is fully cleared as you do in 0.83.x or is exiting FSE enough to maintain the same level of stability...
If just existing FSE is enough, you may want to consider returning to the 0.82.5 exit function as it was much faster.
If you don't feel comfortable with that, I'm sure some users would appreciate a 'Fast D3D Close' checkbox.
Ok, I've added some extra code to do D3D finalization in a background thread. I *think* speed should be back up to v0.82 levels. I hope that all the changes I've done improved stability a bit, at least, and that the new changes won't bring stability down again...

'dwTaskbarThumbnails 331 +7 TdwTaskbarThumbnails.DoUpdate' is updating the windows taskbar thumbnail buttons (the buttons that appear under the task bar thumbnail).
I have no idea why it would trigger on a refresh rate change, I don't specifically call it in my code as far as I can tell... I only create the icons once and only update their image index depending on events such as play/pause and mute on/off.
I don't know why it triggers, but does that matter? It seems that it does trigger, for some reason, so the bigger question is why that code would crash when it is triggered. How are you updating the thumbnail buttons? Does updating those buttons involve OLE stuff? Maybe you could show me TdwTaskbarThumbnails.DoUpdate code?

madshi
26th September 2012, 14:37
madVR v0.82.5 released

http://madshi.net/madVR.zip

* fixed: starting in exclusive mode, then switching to Overlay -> error
* modified exclusive mode seekbar design slightly
* madVR doesn't wait for full direct3d finalization, anymore
* improved crash reporting reliability

cyberbeing
26th September 2012, 15:22
From the log I've seen it was clearly a bug in ffdshow. I've tried to reproduce it on my XPSP3 machine and the problem doesn't seem to occur here. Maybe it depends on the ffdshow, the decoder, the OS, the GPU, whatever. Anyway, I'm not feeling like sinking a couple of hours of my time into trying to find a workaround for what seems like an ffdshow bug to me, which I can't even reproduce on my dev PC.
Okay, no problem. For reference, this was on Win7 SP1 x64 with my GT440 DDR5 (306.23 WHQL driver) and FFDShow r4486 (http://sourceforge.net/projects/ffdshow-tryout/files/SVN%20builds%20by%20clsid/generic%20builds/ffdshow_rev4486_20120825_clsid.exe/download). It only crashes madVR when I resize to 4096 width, but not any width above or below like 4094 or 4098.

Pat357
26th September 2012, 16:42
Madshi,

After disabling Aero when in full screen (checkbox checked), I ended up with a complete black screen when in FSE, while the sound kept playing.
I if switched out off FSE, I got images again and they were "in sync" with the sound.

So,
- in overlay (windowed + full-screen) : image + sound OK
- in FSE : black screen + sound kept playing.

I didn't see any error messages (behind FSE ??).
This bug was also there in 0.82.4.

Here is the DEBUG LOG :

http://www.mediafire.com/?npc9yieiv6d8u93

Update:
It seems I can easily reproduce this.
Even after complete quit and restarting the player, the problem is still there.
Images in FSE can be restored by unchecking the "disable Aero ...." in Madvr settings.

-
MadVR v0.82.5 / Win7 SP1 auto update / i7-970 hexacore @3.9 / 24GB RAM 2000 Mhz / Nvidia GTX-570 / latest WHQL drivers (306.27)

madshi
26th September 2012, 17:04
I don't think there's much I can do about this. I've mentioned this problem before. You can also work around it by pausing the video before entering FSE mode.

SamKook
26th September 2012, 17:38
With v83.5, it doesn't show the D3D error and pause the video anymore from FSE to Overlay the first time, but now it fails to go back to FSE.

When I go in fullscreen again, I get "exclusive mode failed" in the OSD and when I check with ctrl+j, it says "fullscreen overlay mode". The madVR custom seekbar is there though.

When it first launch directly in fullscreen, it says "fullscreen exclusive mode" like usual.

Here's a debug log: http://www.mediafire.com/file/aqrdgcrw2n2l8df/madVR_log_SamKook_2012-09-26.rar

blackjack12
26th September 2012, 17:52
Wanted to provide a little more detail to some performance issues I have seen with Windows 8.

Windows 8 RTM (64)
Nvidia 560Ti
Nvidia driver ver. 306.23
MPC-HC 1.6.4.6011
LAV Filters 0.51.3-53
madVR - Comparing 0.82.5 (with antiringing 6 updates) - 0.83.5
MKV Blu-Ray direct rip files tested - VC-1, VC-1i, H264, H264i material

Problem:
With 0.83.5 files begin and play correctly, but if you jump ahead or back a number of times all of a sudden frames start dropping, stuttering and it does not stop or correct after pausing. It is consistent. Go back to 0.82.5 and there are no problems. ... :confused:

Cannot forward a log file or video sample because there is no crash or error indicated and have to move around a very large (20-40GB) file to see the issue. But it is consistent and always seen on this system and changing back to 0.82.5 always corrects the issue.

JarrettH
26th September 2012, 18:06
This sample is field blended. Meaning that it's not suitable for IVTC. The only way to achieve output without combing is to use video mode deinterlacing.


Thanks, but the MPC-HC debug information is missing. Did you have the *.pdb files in the right folder? You might have to unzip them, or something.

changing source to video mode helped with smoothness

might just watch it on the TV downstairs, I just like to solve problems

thanks for downloading my sample :D

mark0077
26th September 2012, 18:41
With v83.5, it doesn't show the D3D error and pause the video anymore from FSE to Overlay the first time, but now it fails to go back to FSE.

When I go in fullscreen again, I get "exclusive mode failed" in the OSD and when I check with ctrl+j, it says "fullscreen overlay mode". The madVR custom seekbar is there though.

When it first launch directly in fullscreen, it says "fullscreen exclusive mode" like usual.

Here's a debug log: http://www.mediafire.com/file/aqrdgcrw2n2l8df/madVR_log_SamKook_2012-09-26.rar
For me too, I no longer get the D3D error, thanks madshi! But as SamKook says it fails to go back to FSE giving the failed message. The first switch from FSE to Overlay for me pauses playback for maybe 0.5 - 1.0 seconds

omarank
26th September 2012, 19:50
Ok, but what is the source filter? In MPC-HC right click on the video, click on "Filters", then click on the source filter. That's usually the one which shows the source file name. Then copy the text from the "Pin Info" tab and post it here.


Sorry, I couldn't check this forum in the last few days and so, couldn't reply.

It's strange that when I click on Filters while viewing a still image, I see no source filter. However, in that filters list, there is an option which allows me to view Properties of the file (I am not sure if you referred to this filter). I have attached a file having the text from the Pin Info tab of that Properties window.

Normally, when I play a video, I can see Lav Splitter Source as the Source Splitter. Please let me know if you need any more information.

yok833
26th September 2012, 20:19
Here is a picture during a big drop frame in FSE... no problem if I stay just in FS.
https://www.dropbox.com/s/ko26zqvp8ct0f0h/FSE.jpg
I have also noticed that sometimes after few minutes in FSE it switch itself in FS

Pat357
26th September 2012, 21:55
Madshi,

When I try to past my yCMS settings in the foreseen "text-box", upon pressing the "Apply" or "OK" button, I get crash and an exception message like this :
'0.42140' is not a valid floating point value.
How is that ? Does the tool maybe expect a format with a mantissa and an exponent ? ;-)
This makes that I can't make the calibration work atm : I'm forced to select another method to be able to press OK.

The dissam looks like :
005a9368 call -$199775 ($40fbf8) ; madStrings.RetTrimStr
005a936d mov eax, [ebp-$558]
005a9373 mov [ebp-$7c], eax
005a9376 mov edx, [$5c80e8]
005a937c mov eax, [ebp-$7c]
005a937f > call -$10ca5c ($49c928) ; SysUtils.StrToFloat
005a9384 fstp tbyte ptr [ebp-$90]
005a938a wait
005a938b fld tbyte ptr [ebp-$90]
005a9391 fstp qword ptr [ebp-$58]
005a9394 wait

Complete crash-report :
http://www.mediafire.com/?ow4p36klr55dxgt

nuhi
26th September 2012, 22:59
madshi, when you get to it please check if it's possible to make madvr work with the native Nvidia Rotation from the driver.
Basically how to reproduce the issue is to right-click Desktop, go to Nvidia Control Panel, Rotate Display, and pick e.g. Portrait (flipped).
Then when playing with madvr the picture is just black, sound is ok.
Thanks.

ajp_anton
27th September 2012, 01:10
Just letting you guys know...
Samsung S27A850T supports both 48Hz and 50Hz through Displayport at full 2560x1440.
I'm on an Intel HD3000 BTW, surprised Intel actually allows custom refresh rates.

leeperry
27th September 2012, 01:43
Just letting you guys know...
Samsung S27A850T supports both 48Hz and 50Hz through Displayport at full 2560x1440.
for the price, it'd better :D

it'd be great if someone created a thread for the mVR-related chit-chat coz I'm still in the market for a good bang/bucks flat screen myself....apparently to get killer native CR, the current market leader is Philips w/ the >5K:1 Philips 40PFL5507H (http://translate.google.com/translate?sl=fr&tl=en&u=http%3A%2F%2Fwww.lesnumeriques.com%2Ftv-televiseur%2Fphilips-40pfl5507h-p12906%2Ftest.html) for less than 600€.

The firmware seems a far cry from what SONY offers(random black screens via HDMI), but the native CR kills and it does native 24p of course. I'm currently trying to resist really really hard :scared:

Ideally I'd want something 27"-ish but these are usually PC monitors with sloppy onboard electronics and/or poor native CR, duh.

dansrfe
27th September 2012, 03:15
Everyone using madVR needs to buy one of the 27" Korean monitors. I've been reading quite a bit about them and it seems like they really do what they say they do.

I'm about to buy this monitor:

27" S-IPS LED 2560 x 1440 Glossy LG Panel, overclockable up to 120Hz

http://120hz.net/showthread.php?629-Catleap-2B-Extreme-120hz-Sale-Information

dansrfe
27th September 2012, 06:54
@madshi

Can you please add the checkbox to turn off the wallpaper changer or it would be even beter if you could add a textbox which takes in any command line and executes it before and another textbox that executes a command line before exiting.

Thanks! You are very appreciated madshi :)