Log in

View Full Version : madVR - high quality video renderer (GPU assisted)


Pages : 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 [450] 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329

madshi
4th February 2014, 13:15
Sorry.

http://madshi.net/madVRdirectCompute3.rar

James Freeman
4th February 2014, 13:22
Here is the perfect example:
http://www.mediafire.com/convkey/2251/ol84x98d9rtwbbgfg.jpg

Download and zoom with a viewer (disable smoothing or Billinear filtering) or Paint.

Shiandow, thanks for the picture and explanation.

Here's test build 3 with lowered GPU RAM usage, hopefully faster initialization, and maybe slightly lower rendering times:

All of them Correct. Thank You !!

Shiandow
4th February 2014, 13:25
FWIW, I've tested doing the error distribution in RGB linear light. There was a 10-20% drop in performance, and to be honest, in 8bit I did not see any improvement in image quality. The pattern was ever so slightly different, but even when zooming in 800% I could not say which one was better. So I think I might drop the linear light idea and stick to simple gamma corrected error diffusion. There's simply no point spending more processing time if there's no visible image quality benefit at 8bit. It seems to me that the higher the bitdepth is, the lower the benefit of using linear light is, for error diffusion... :(


I'm not exactly sure what the difference is between linear light and gamma correction, but it might indeed not be worth the trouble. Some kind of gamma correction should be used, but a small difference will almost completely vanish, especially when you use 8 bits. I also suspect that the difference between LL RGB and LL YCbCr will be so small that it's only detectable on very extreme cases, possibly only when dithering gray levels on a monitor with extremely vivid colours.

By the way do you also use some kind of gamma correction for normal dithering?

burfadel
4th February 2014, 13:27
I tried madVRdirectCompute2 and it came up with an error box titled 'Error Diffusion', and inside the box it said 'creating shader file failed'. It resulted in a black play window (using mpc-hc).

madVRdirectCompute1 worked fine! At least there was no errors and the display was fine, haven't checked to see whether it actually 'works'.

This is on Windows 8.1 x64, MPC-HC 1.7.3.4, and on a Radeon R9-280x running the Catalyst 14.1 beta drivers.

nevcairiel
4th February 2014, 13:28
I tried madVRdirectCompute2 and it came up with an error box titled 'Error Diffusion', and inside the box it said 'creating shader file failed'. It resulted in a black play window (using mpc-hc).

There is already a third version which fixes this.

Don't take this the wrong way, but tt would be beneficial to everyone if you read at least the last 5 posts before posting about already fixed errors. :)

madshi
4th February 2014, 13:32
I'm not exactly sure what the difference is between linear light and gamma correction, but it might indeed not be worth the trouble. Some kind of gamma correction should be used, but a small difference will almost completely vanish, especially when you use 8 bits. I also suspect that the difference between LL RGB and LL YCbCr will be so small that it's only detectable on very extreme cases, possibly only when dithering gray levels on a monitor with extremely vivid colours.

By the way do you also use some kind of gamma correction for normal dithering?
I'm sorry, "gamma corrected error diffusion" was an incorrect term. I meant simple error diffusion in gamma light. Meaning error diffusion in R'G'B', not in linear light RGB. As much as I'd love to improve image quality further by using linear light instead of gamma light, I just cannot see a difference, when using 8bit. And no, I don't do any gamma correction for normal dithering.

Can you see a difference betweem gamma and linear light if you use 8bit dithering with your test images instead of 2bit dithering?

burfadel
4th February 2014, 13:35
There is already a third version which fixes this.

Don't take this the wrong way, but tt would be beneficial to everyone if you read at least the last 5 posts before posting about already fixed errors. :)

I missed the fact there was a new version... I downloaded it, went and made a cup of coffee, came back, tried it, and reported it without realising it had been 15 minutes since I downloaded it and that the error was a common one!

noee
4th February 2014, 13:39
madshi, fwiw, some quick #s with Compute2, 1080p24 material, 60Hz playback

I can now run with SM on, before I could not.

With RandDither
Render: ~12ms
GPU: 28%
Mem: 529MB

With ErrDiff
Render: ~38ms
GPU: 88%
Mem: 520MB

No frame drops with either option. Compute1 would not do this.

Also, FSE mode with frames in advance = 10. Render/present queues do not max, but they avg ~7 out of 10....

leeperry
4th February 2014, 13:46
yesterday's DC build with extreme NNEDI chroma+luma upscaling & ED on 720p24@1080p that would take a few secs to fill the queues: http://thumbnails110.imagebam.com/30589/9e1158305880023.jpg (http://www.imagebam.com/image/9e1158305880023)

and with the new build, queues fill up instantly: http://thumbnails111.imagebam.com/30589/a55412305880024.jpg (http://www.imagebam.com/image/a55412305880024)

at this rate, I'll be able to go 128 neurons by the end of the week :D

DragonQ
4th February 2014, 13:48
There is already a third version which fixes this.

Don't take this the wrong way, but tt would be beneficial to everyone if you read at least the last 5 posts before posting about already fixed errors. :)
This thread moves fast sometimes. Very possible that the third version was posted whilst he was writing his post!

cyberbeing
4th February 2014, 13:49
That's a smaller performance increase as most other NVidia users seem to report. That's a bit strange.

Which results are you looking at? The following where the only NVIDIA users reporting render times differences with OpenCL vs DirectCompute build 1:

Asmodian's Titan = 1.3ms improvement
Ver's GTX 580 = 1ms & 2ms improvement
Kalanoch's GTX 670 = 3ms & 5ms improvement
Myself GTX 770 = 3ms improvement

Average: 2.55ms improvement for NVIDIA users with DirectCompute build 1.

iSunrise
4th February 2014, 13:53
Wow!

OpenCL vs. DirectCompute1 vs. DirectCompute3

432p 50fps - no smooth motion

http://abload.de/thumb/errordiffusion_openclfsfdj.png (http://abload.de/image.php?img=errordiffusion_openclfsfdj.png)http://abload.de/thumb/errordiffusion_directgxf77.png (http://abload.de/image.php?img=errordiffusion_directgxf77.png)http://abload.de/thumb/errordiffusion_directx0xm1.png (http://abload.de/image.php?img=errordiffusion_directx0xm1.png)

432p 50fps - smooth motion

http://abload.de/thumb/errordiffusion_openclamdmj.png (http://abload.de/image.php?img=errordiffusion_openclamdmj.png)http://abload.de/thumb/errordiffusion_direct2iimp.png (http://abload.de/image.php?img=errordiffusion_direct2iimp.png)http://abload.de/thumb/errordiffusion_directg1b6h.png (http://abload.de/image.php?img=errordiffusion_directg1b6h.png)

1080p 23.976fps - no smooth motion

http://abload.de/thumb/errordiffusion_openclhvdin.png (http://abload.de/image.php?img=errordiffusion_openclhvdin.png)http://abload.de/thumb/errordiffusion_directxxfg0.png (http://abload.de/image.php?img=errordiffusion_directxxfg0.png)http://abload.de/thumb/errordiffusion_directxxzv9.png (http://abload.de/image.php?img=errordiffusion_directxxzv9.png)

1080p 23.976fps - smooth motion

http://abload.de/thumb/errordiffusion_openclb0f9s.png (http://abload.de/image.php?img=errordiffusion_openclb0f9s.png)http://abload.de/thumb/errordiffusion_directtzewg.png (http://abload.de/image.php?img=errordiffusion_directtzewg.png)http://abload.de/thumb/errordiffusion_direct3glsb.png (http://abload.de/image.php?img=errordiffusion_direct3glsb.png)

1080p 60fps - no smooth motion

http://abload.de/thumb/errordiffusion_openclyzis0.png (http://abload.de/image.php?img=errordiffusion_openclyzis0.png)http://abload.de/thumb/errordiffusion_directgmdk4.png (http://abload.de/image.php?img=errordiffusion_directgmdk4.png)http://abload.de/thumb/errordiffusion_directvwz9z.png (http://abload.de/image.php?img=errordiffusion_directvwz9z.png)

Compared to DirectCompute1, thereīs (depends on your settings, smooth motion and source->target resolution) lower VRAM usage, lower GPU load and lower memory controller load across the board.

Especially compared to OpenCL, this is a HUGE improvement now.

OpenCL vs. DirectCompute3
On the 50fps clip I posted above, itīs lower than half of the memory used (427MB vs. 191MB), about 12% lower GPU load (35% vs. 23%) and only half the memory controller load (15% vs. 8%).

Great work madshi!

*Touche*
4th February 2014, 13:53
Which results are you looking at? The following where the only NVIDIA users reporting render times differences with OpenCL vs DirectCompute build 1:

Asmodian's Titan = 1.3ms improvement
Ver's GTX 580 = 1ms & 2ms improvement
Kalanoch's GTX 670 = 3ms & 5ms improvement
Myself GTX 770 = 3ms improvement

Average: 2.55ms improvement for NVIDIA users with DirectCompute build 1.

I think it would be better to look at the percentages. One man's 50% is 3 ms, other one's is 30 ms.

pie1394
4th February 2014, 14:05
Sorry.

http://madshi.net/madVRdirectCompute3.rar

Did a quick test of DC version build of Error Diffusion on the HD7970.

- 1920x1080p24 H.264 Hi10 contents to 1080p24 output mode.
- NNEDI3 32 for Chroma 2x upscaling
- Debanding with angle detection

No dithering with 0.87.4: 15.2 ~ 15.3 ms
No dithering with DC3 : 15.1 ~ 15.2 ms
Random dithering with DC3: 15.2 ~ 15.3ms
ED with 0.87.4 OpenCL: 26ms (39ms**)
ED with DC1: 17.2ms
ED with DC3: 17.0ms


** This is the timing number when the GPU-z runs at the background, the playback is also unstable. So I recommend those people who have measured strange timing numbers should be careful about this.

Ver Greeneyes
4th February 2014, 14:10
Ver's GTX 580 = 1ms & 2ms improvement
I think it would be better to look at the percentages.
Indeed - using random dithering as a baseline, DirectCompute from the first test build seemed 57-59% faster than OpenCL:
(7.80 - 5.26) / (6.88 - 5.26) - 1 = 56.8%
(13.80 - 8.54) / (11.84 - 8.54) - 1 = 59.4%I haven't compared the new build, but it should be the same or better :) (completely disabling dithering would also give a better baseline, but I think this is good enough)

madshi
4th February 2014, 14:30
Some great results, I'm pretty happy with DirectCompute atm! Will go work on NNEDI3 now...

*Touche*
4th February 2014, 14:35
Some great results, I'm pretty happy with DirectCompute atm! Will go work on NNEDI3 now...

If you manage similar improvements, my A10-5800K will be able to pull some impressive settings. NNEDI is the only thing it isn't able to do atm. Great work and thank you so much for madVR!

cyberbeing
4th February 2014, 14:41
Did a quick test, and there is a small performance improvement with DirectCompute Build 3, and GPU ram usage is back down to madVR 0.87.4 levels.

GTX 770 2GB
VS. Random Dither

1920x1080p60 -> 2560x1440@60hz FSE
OpenCL Dither = +10.7ms ~1GB
DirectCompute Build 1 = +8.7ms ~1.4GB
DirectCompute Build 3 = +8.0ms ~1GB

1280x720p24 -> 1920x1080@60hz FSE w/ Smooth Motion
OpenCL Dither = +11.8ms ~1GB
DirectCompute Build 1 = +8.7ms ~1.3GB
DirectCompute Build 3 = +8.0ms ~1GB

640x360p24 -> 2560x1440@60hz FSE w/ Smooth Motion
OpenCL Dither = +20.8ms ~1.8GB
DirectCompute Build 1 = +18.5ms (w/ queues reduced from 16 to 8)
DirectCompute Build 3 = +16.2ms ~1.8GB

1920x1080p24 -> 1920x1080@120hz FSE
OpenCL Dither = +6.1ms
DirectCompute Build 1 = +4.4ms
DirectCompute Build 3 = +4.0ms

1280x720p24 -> 1920x1080@120hz FSE
OpenCL Dither = +5.8ms
DirectCompute Build 1 = +4.2ms
DirectCompute Build 3 = +3.7ms

1280x720p24 -> 1280x720@120hz FSE
OpenCL Dither = +2.5ms
DirectCompute Build 1 = +1.7ms
DirectCompute Build 3 = +1.5ms

Neet009
4th February 2014, 14:47
but i still run into a problem, when testing directcompute error diffusion build, one of my test files dropped frames in some scenes. I test it more than 10 times, and it dropped frames in the same scene. It doesn't happen with the random dithering and the opencl error diffusion build. I don't know if it is a bug or not, all queues is full and gpu loading is lower than 50%. When drop frame occuring, the queues down to zero suddenly, and i noticed that gpu memory usage increase about 20mb after the frames dropped.
Trying to change the setting value of the queue, it doesn't make any help.


this might have to do with high ram usage. Does the problem still occur in test build 2?



Trying the test build 3, all the problems was gone, playback without any dropped frames, perfectly.
In addition, the rendering time was slightly lower compared to the test build 1.That's awesome!
Thank you for the work on new build!

kasper93
4th February 2014, 14:51
Some great results, I'm pretty happy with DirectCompute atm! Will go work on NNEDI3 now...

Yeah, it depends on architecture, but on my gpu it's ~10x faster ;p I knew that my HD5870 can do better and it's bottlenecking somewhere... This gpu is not quite new, but it's still powerful. I'm very exited to see how NNEDI3 will work. Good luck :)

trip_let
4th February 2014, 16:21
Oh yeah, Intel.

I opened 720p file, no scaling except chroma Bicubic 60 AR, windowed mode. Using HD 4000 (1150 MHz clock speed cap version).

Dithering: 3 ms
Error diffusion OpenCL: 30 ms
Error diffusion DirectCompute: 33 ms

Maybe different if fullscreen mode. I don't really have more time to test today. Maybe way slower if pre-Ivy Bridge Intel? Or if more RAM is being used? Those are just guesses and I'm not going to find out now.

Quoting self, still a bit busy; took 1 min to test. Same scenario on HD 4000.

Dithering: 3 ms
Error diffusion OpenCL: 30 ms
Error diffusion DirectCompute v1: 33 ms
Error diffusion DirectCompute v3: 26 ms

edit: off the top of my head, on 1080p24 playback on 1080p (60 fps smooth motion), on Optimus using GT 650M, dynamic memory usage was 1050MB with DirectCompute v1 error diffusion, now down to 850MB on v3. Nice improvement all around.

DragonQ
4th February 2014, 17:12
I was hoping that I could use MadVR on my Arrandale IGP with the new profiles but apparently not. The problem is that MadVR cannot use DXVA deinterlacing or scaling on this GPU ("DXVA processing failed"), so I have no way of deinterlacing except using YADIF in LAV Video Decoder. However, I can't get MadVR to recognise this formerly-interlaced material. If (srcInterlaced = true) doesn't work, presumably because the video isn't interlaced any more once MadVR gets hold of it. If (deintFps > 31) doesn't work because MadVR reports the fps as 25 rather than 50.

Is there any way to get this to work?

Thunderbolt8
4th February 2014, 18:58
not sure what to compare DirectCompute rendering times to since OpenCL didnt work for me. v3 rendering times are about the same as v1 which means still too slow in case of 1080p60 with dropping frames.

James Freeman
4th February 2014, 19:12
1080p60 with DirectComputeV3 works perfectly here. V1 worked just as good but used more memory.
With DirectComputeV3 I can actually leave Error Diffusion On permanently with any type of video and setting.
Even 4Kp60 woks flawlessly.


Bug Report:

Downscaling with DXVA freezes image when changing windows size or going fullscreen.

Soukyuu
4th February 2014, 19:24
madshi, what's the reason you restricted DirectCompute to newer GPUs? Do 2xx and 4xx nVidia chips lack hardware capabilities or was it for performance reasons?
*continues to silently envy everyone with a newer GPU*

omarank
4th February 2014, 19:36
*continues to silently envy everyone with a newer GPU*

Me too... :(

Asmodian
4th February 2014, 19:42
I think it would be better to look at the percentages. One man's 50% is 3 ms, other one's is 30 ms.

Percentages mean nothing in this context, I was running NNEDI3 32 chroma upscaling, NNEDI3 64 luma doubling, and smooth motion.

The fact that I was at 36ms per frame and only got 3.6% improvement doesn't mean I had less improvement than cyberbeing's (http://forum.doom9.org/showthread.php?p=1666058#post1666058) 26.3% on 11.8 ms. The ms cost is what matters, add up the time for all the options you want and hope it is under the time per frame.

I did get less improvement but not one seventh of the improvement, one half.

Qotscha
4th February 2014, 19:42
I think the performance of error diffusion is quite poor on my computer (Radeon HD 6850 with Catalyst 13.12). Here is a little comparison:

720p50 to 1080p50:

Jinc 4 + AR (Image + chroma), medium deband, random dithering: 91% GPU load, no dropped frames
Bilinear (Image + chroma), no deband, error diffusion: ~90% GPU load, a lot of dropped frames (result is about the same with any scaling algorithm)


With DirectCompute (v3):

Bilinear (Image + chroma), no deband, error diffusion: 24% GPU load, no dropped frames
Jinc 3 + AR (Image + chroma), medium deband, random dithering: 55% GPU load, no dropped frames
Jinc 3 + AR (Image + chroma), medium deband, error diffusion: 73% GPU load, no dropped frames


Nice :D

sexus
4th February 2014, 19:47
ok so from what ive understood the only difference between directcompute error diffusion and opencl error diffusion is the support for nv12 dxva surfaces , but shouldnt this be irrelevant to the cuvid users ?

its funny how i come around every so often and have the perfect timing on new exciting developments,lols

madshi
4th February 2014, 19:55
If you manage similar improvements, my A10-5800K will be able to pull some impressive settings. NNEDI is the only thing it isn't able to do atm.
Don't expect too much from NNEDI/DirectCompute. I'm not even sure yet if it will be faster at all. I hope so, but I don't know...

Did a quick test, and there is a small performance improvement with DirectCompute Build 3, and GPU ram usage is back down to madVR 0.87.4 levels.

GTX 770 2GB
VS. Random Dither

1920x1080p60 -> 2560x1440@60hz FSE
OpenCL Dither = +10.7ms ~1GB
DirectCompute Build 1 = +8.7ms ~1.4GB
DirectCompute Build 3 = +8.0ms ~1GB

1280x720p24 -> 1920x1080@60hz FSE w/ Smooth Motion
OpenCL Dither = +11.8ms ~1GB
DirectCompute Build 1 = +8.7ms ~1.3GB
DirectCompute Build 3 = +8.0ms ~1GB

640x360p24 -> 2560x1440@60hz FSE w/ Smooth Motion
OpenCL Dither = +20.8ms ~1.8GB
DirectCompute Build 1 = +18.5ms (w/ queues reduced from 16 to 8)
DirectCompute Build 3 = +16.2ms ~1.8GB

1920x1080p24 -> 1920x1080@120hz FSE
OpenCL Dither = +6.1ms
DirectCompute Build 1 = +4.4ms
DirectCompute Build 3 = +4.0ms

1280x720p24 -> 1920x1080@120hz FSE
OpenCL Dither = +5.8ms
DirectCompute Build 1 = +4.2ms
DirectCompute Build 3 = +3.7ms

1280x720p24 -> 1280x720@120hz FSE
OpenCL Dither = +2.5ms
DirectCompute Build 1 = +1.7ms
DirectCompute Build 3 = +1.5ms
The cost should depend on the output resolution, nothing else. Looking at your results that seems to be mostly true. Error Diffusion for 2560x1440 costs about 8ms with your GPU. 1080p costs about 4ms. 720p 1.5ms. The only result not fitting in here is the Smooth Motion FRC result. But that can be easily explained: SM FRC increases the output framerate, but calculates the overall rendering cost per *source* frame. So with 24fps @ 60Hz, SM FRC outputs something like 48fps, and has to apply Error Diffusion to every of those output frames - while the scaling etc algorithms are only applied on the source frames. So that means e.g. Jinc3AR is only done 24 times per second. But Error Diffusion is done smoething like 48 times per second. So the cost of Error Diffusion appears to be twice as high with SM FRC turned on. If you had a true 48fps video with SM FRC turned off, the Error Diffusion cost would seem only half as much (per source frame), although in reality it's really the same. Makes sense?

Trying the test build 3, all the problems was gone, playback without any dropped frames, perfectly.
In addition, the rendering time was slightly lower compared to the test build 1.
Great!

Yeah, it depends on architecture, but on my gpu it's ~10x faster ;p
Yeah, that was the main thing bothering me: The OpenCL interop cost was so high - and it was not scaling with GPU power! So a cheap budget GPU had the same interop cost as the fastest GPU available. This problem is gone now, so finally Error Diffusion should scale nicely with the GPU power.

HD 4000.

Dithering: 3 ms
Error diffusion OpenCL: 30 ms
Error diffusion DirectCompute v1: 33 ms
Error diffusion DirectCompute v3: 26 ms
Cool. So Error Diffusion with DirectCompute seems to be faster now with all 3 GPU manufacturers. No reason to use OpenCL for Error Diffusion, anymore. Yey!

I was hoping that I could use MadVR on my Arrandale IGP with the new profiles but apparently not. The problem is that MadVR cannot use DXVA deinterlacing or scaling on this GPU ("DXVA processing failed"), so I have no way of deinterlacing except using YADIF in LAV Video Decoder. However, I can't get MadVR to recognise this formerly-interlaced material. If (srcInterlaced = true) doesn't work, presumably because the video isn't interlaced any more once MadVR gets hold of it. If (deintFps > 31) doesn't work because MadVR reports the fps as 25 rather than 50.

Is there any way to get this to work?
Why do you need it to be recognised as being formerly interlaced? After YADIF it should truely be progressive. Although normally video mode deinterlacing produces double frame rate. But I guess that depends on your LAV settings?

not sure what to compare DirectCompute rendering times to since OpenCL didnt work for me. v3 rendering times are about the same as v1 which means still too slow in case of 1080p60 with dropping frames.
Is that with your 760M or with your HD4600? I think it's probably the HD4600? The 760M should be able to 1080p60 with Error Diffusion, I think. Of course it depends on your other settings. Error Diffusion *does* cost additional performance, so if you want to use it you may have to dial down some of the other settings.

1080p60 with DirectComputeV3 works perfectly here. V1 worked just as good but used more memory.

With DirectComputeV3 I can actually leave Error Diffusion On permanently with any type of video and setting.

Even 4Kp60 woks flawlessly.
4Kp60? Great!

madshi, what's the reason you restricted DirectCompute to newer GPUs? Do 2xx and 4xx nVidia chips lack hardware capabilities or was it for performance reasons?
*continues to silently envy everyone with a newer GPU*
NVidia 4xx should work. NVidia 2xx does not and AMD 4xxx does not. The reason for that is that although DirectCompute in theory supports DX10 GPUs, too, it does so only with a very limited feature set. I'd have to use totally different code to make it all work on DX10 GPUs, and honestly, I think NVidia 2xx and AMD 4xxx users probably don't have the raw speed to make use of the new features, anyway, so I don't feel like spending a lot of additional development resources just to support DX10 GPUs. So I've limited support to native DX11 GPUs.

With DirectCompute (v3):

Bilinear (Image + chroma), no deband, error diffusion: 24% GPU load, no dropped frames
Jinc 3 + AR (Image + chroma), medium deband, random dithering: 55% GPU load, no dropped frames
Jinc 3 + AR (Image + chroma), medium deband, error diffusion: 73% GPU load, no dropped frames

Looks good! Not being able to use Jinc4AR is not a big loss, IMHO.

ok so from what ive understood the only difference between directcompute error diffusion and opencl error diffusion is the support for nv12 dxva surfaces
No. The lack of nv12 DXVA surface support has nothing to do with Error Diffusion. There is no downside to using DirectCompute for Error Diffusion. The only "problem" is that I can't use DirectCompute for one other feature where I'd like to use it. But I can use it just fine for Error Diffusion, and probably also for NNEDI3.

Mangix
4th February 2014, 20:01
madshi, what's the reason you restricted DirectCompute to newer GPUs? Do 2xx and 4xx nVidia chips lack hardware capabilities or was it for performance reasons?
*continues to silently envy everyone with a newer GPU*

Needs to be a DX11 capable GPU, so yes. Hardware reasons.

edit: was not fast enough.

DragonQ
4th February 2014, 20:09
Why do you need it to be recognised as being formerly interlaced? After YADIF it should truely be progressive. Although normally video mode deinterlacing produces double frame rate. But I guess that depends on your LAV settings?
Because the Arrandale IGP is a pile of crap and can only handle anything above Bilinear for <30 fps videos. I wanted to create profiles so I could set this up, but can't see a way of MadVR recognising that the videos are 50 fps when YADIF is used, even though they clearly are.

It doesn't necessarily need to notice that the video used to be interlaced, just that it's now 50 fps rather than 25 fps.

THX-UltraII
4th February 2014, 20:16
It might be a bug with memory usage, triggered only sometimes or rather if some conditions are met. Also most of us (probably) haven't jumped the 4K displays bandwagon yet ;)
When you get to testing maybe try lowering the queues and see if the crashes persist, since you might be running out of system RAM or GPU VRAM.

which settings do i have to change exactly? and to what test values do i change them you think?

huhn
4th February 2014, 20:58
i know madshi is not really interested in new bugs but it's a pretty huge one

huge resize "error"

when i use a 1440x1080i60 (ar 16/9) source and resize it to 1724x950 image quality gets really bad (like point or even worse...) if upscale is bilinear and downscaling is "mitchell-netravali" - "spline" (all pixelshader resizer) blinear up and down is fine even bilinear up and nearest neighbor down is way better or even the same like bilinear down?

screen: bilinear/bilinear fine (http://abload.de/img/resizeerrorbilbilptb76.png) bilinear/catmull-rom pure quality (http://abload.de/img/resizeerrorbilcatytlhh.png)

NicolasRobidoux
4th February 2014, 21:01
Here is an example of why I thought Jinc4 (and, actually, I believe I prefer Jinc 5) would work better than Jin3 for pixel art: http://forum.doom9.org/showthread.php?p=1595556#post1595556

madshi
4th February 2014, 21:10
Because the Arrandale IGP is a pile of crap and can only handle anything above Bilinear for <30 fps videos. I wanted to create profiles so I could set this up, but can't see a way of MadVR recognising that the videos are 50 fps when YADIF is used, even though they clearly are.

It doesn't necessarily need to notice that the video used to be interlaced, just that it's now 50 fps rather than 25 fps.
I think you need to talk to nevcairiel. According to what you're saying it doesn't seem to report 50fps to madVR. I think it should do that if it doubles the framerate with YADIF.

i know madshi is not really interested in new bugs but it's a pretty huge one

huge resize "error"

when i use a 1440x1080i60 (ar 16/9) source and resize it to 1724x950 image quality gets really bad (like point or even worse...) if upscale is bilinear and downscaling is "mitchell-netravali" - "spline" (all pixelshader resizer) blinear up and down is fine even bilinear up and nearest neighbor down is way better or even the same like bilinear down?

screen: bilinear/bilinear fine (http://abload.de/img/resizeerrorbilbilptb76.png) bilinear/catmull-rom pure quality (http://abload.de/img/resizeerrorbilcatytlhh.png)
Can I have a small sample of this, please?

Here is an example of why I thought Jinc4 (and, actually, I believe I prefer Jinc 5) would work better than Jin3 for pixel art: http://forum.doom9.org/showthread.php?p=1595556#post1595556
Yes. Jinc3AR or Jinc4AR (not much difference, I think) are both quite fine for pixel art - quite a bit better than Lanczos. But NNEDI3 really is in another league for heavily aliased pixel art. I was surprised myself how big the difference was.

michkrol
4th February 2014, 21:13
which settings do i have to change exactly? and to what test values do i change them you think?

Rendering -> general settings -> CPU/GPU queue size. Not sure what you have them at right now, so I can't tell you exact values, you can even lower them to minimum. Also it's just a wild guess that you might be running out of memory, based on your mention of 4K screen.
Checking playback with another player (or player's version) should probably come first.

Thunderbolt8
4th February 2014, 21:19
Is that with your 760M or with your HD4600? I think it's probably the HD4600? The 760M should be able to 1080p60 with Error Diffusion, I think. Of course it depends on your other settings. Error Diffusion *does* cost additional performance, so if you want to use it you may have to dial down some of the other settings.the 760M, its always the non integrated card unless I say so. unfortunately with 60p its a little too slow for the 760M as it seems :(

which other settings are there I could dial down in order to have the slightly better PQ with error difusion all in all? Im not using anything like deinterlacing, smooth motion or deband for that test file, so I could only dial down settings in the trade quality for performance tab and there I wouldnt know which would be the better tradeoff PQ-wise.

DragonQ
4th February 2014, 22:29
Just got around to trying DirectCompute v3 on my desktop (GTS 250). Ticking/unticking "use random dithering instead of OpenCL error diffusion" does nothing to visuals, rendering times, or GPU usage. :scared:

nevcairiel
4th February 2014, 22:36
Just got around to trying DirectCompute v3 on my desktop (GTS 250). Ticking/unticking "use random dithering instead of OpenCL error diffusion" does nothing to visuals, rendering times, or GPU usage. :scared:

DirectCompute requires a DX11 compatible GPU, which the 200 series is not.

DragonQ
4th February 2014, 22:40
Oh yeah I was meant to try on my HD4000. I'm retarded ignore me.

The 8472
4th February 2014, 23:11
Even 4Kp60 woks flawlessly. Do you have a 4k screen? Otherwise the source resolution does not matter as far as dithering goes, output resolution does. Source resolution/framerate matters for the scalers and nnedi.

1440p60 output (i.e. 1440p screen + smooth motion on) eats about 40% GPU load for me, NNEDI another 45% at 720p24->1440p24 so it's pretty close. Downscaling from 4k would actually be cheaper since it wouldn't use nnedi but simply one of the downscaling algorithms.

Just got around to trying DirectCompute v3 on my desktop (GTS 250). Ticking/unticking "use random dithering instead of OpenCL error diffusion" does nothing to visuals, rendering times, or GPU usage. :scared:

It would probably be good if madVR complained loudly if you're using settings that don't actually work. Silent failures might lead to users misinterpreting things.

XMonarchY
4th February 2014, 23:16
So error diffusion dithering is now done through DirectCompute in these test builds, but NNEDI3 is still using using OpenCL, right?

DragonQ
4th February 2014, 23:19
So error diffusion dithering is now done through DirectCompute in these test builds, but NNEDI3 is still using using OpenCL, right?
Correct.

Mangix
4th February 2014, 23:24
It would probably be good if madVR complained loudly if you're using settings that don't actually work. Silent failures might lead to users misinterpreting things.
This is currently the case with windowed overlay mode. Complaining happens when the OSD is enabled. Not hard to implement.

Thunderbolt8
4th February 2014, 23:29
might have missed something, but on my other laptop with a Radeon HD 76X0M I get a black picture when choosing OpenCL/DirectCompute with testversion 3 (CCC 13.12). whys that?

cyberbeing
4th February 2014, 23:50
The cost should depend on the output resolution, nothing else.
Yes, I already mentioned last week that performance cost scaled with output resolution only, and doubled on my GPU with Smooth Motion. I decided to show such results with numbers this time, so you'd get a bit better perspective how performance was scaling on my GPU. It's still the second slowest function in madVR behind NNEDI3 on this GPU, and cannot be enabled full-time without reduced quality settings in many cases.

I'm remaining hopeful that DirectCompute NNEDI3 vs OpenCL NNEDI3 will reduce absolute render times enough to leave room for DirectCompute Dither.

Soukyuu
4th February 2014, 23:53
Oh yeah I was meant to try on my HD4000. I'm retarded ignore me.Uhm, according to madshi's post back here (http://forum.doom9.org/showthread.php?p=1665894#post1665894), it won't work on either nVidia 2xx nor ati 4xxx
I'm a bit sad about it, my 260GTX is still fully sufficient for my needs otherwise... but oh well.

It would probably be good if madVR complained loudly if you're using settings that don't actually work. Silent failures might lead to users misinterpreting things.I'm all for visible error messages, but not popups you have to close. Maybe displaying a message on the OSD along the lines of "DirectCompute not supported - falling back to random dither"

Audionut
5th February 2014, 00:25
I'm all for visible error messages, but not popups you have to close. Maybe displaying a message on the OSD along the lines of "DirectCompute not supported - falling back to random dither"

Agreed. For anything that otherwise silently fails.

Just having more information in the debug OSD sounds fine also.

cyberbeing
5th February 2014, 00:51
DirectCompute requires a DX11 compatible GPU, which the 200 series is not.

Do the limitations of DirectCompute Compute Shader 4.0/4.1 for DX10 & 10.1 make it relatively useless compared to Compute Shader 5.0 for DX11?