Media Player Classic Home Cinema (MPC-HC) - DXVA!

[SamuriHL]

I'm having some compile issues. If anyone knows what kind of moron I'm being I'd appreciate being knocked over the head with it. I'm pulling from GIT.


..\thirdparty\mfc\afxglobals.cpp(50): error C2039: 'm_hinstD2DDLL' : is not a m
ember of 'AFX_GLOBAL_DATA' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\atlmfc\include
\afxglobals.h(111) : see declaration of 'AFX_GLOBAL_DATA'
..\thirdparty\mfc\afxglobals.cpp(51): error C2039: 'm_hinstDWriteDLL' : is not
a member of 'AFX_GLOBAL_DATA' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj
]
C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\atlmfc\include
\afxglobals.h(111) : see declaration of 'AFX_GLOBAL_DATA'
..\thirdparty\mfc\afxglobals.cpp(53): error C2143: syntax error : missing ';' b
efore '*' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(53): error C4430: missing type specifier - int
assumed. Note: C++ does not support default-int [c:\dev\projects\mpc-hc\src\mp
c-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(53): error C2039: 'm_pDirect2dFactory' : is no
t a member of 'AFX_GLOBAL_DATA' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxpr
oj]
C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\atlmfc\include
\afxglobals.h(111) : see declaration of 'AFX_GLOBAL_DATA'
..\thirdparty\mfc\afxglobals.cpp(53): error C4430: missing type specifier - int
assumed. Note: C++ does not support default-int [c:\dev\projects\mpc-hc\src\mp
c-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(54): error C2143: syntax error : missing ';' b
efore '*' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(54): error C4430: missing type specifier - int
assumed. Note: C++ does not support default-int [c:\dev\projects\mpc-hc\src\mp
c-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(54): error C2039: 'm_pWriteFactory' : is not a
member of 'AFX_GLOBAL_DATA' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\atlmfc\include
\afxglobals.h(111) : see declaration of 'AFX_GLOBAL_DATA'
..\thirdparty\mfc\afxglobals.cpp(54): error C4430: missing type specifier - int
assumed. Note: C++ does not support default-int [c:\dev\projects\mpc-hc\src\mp
c-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(55): error C2143: syntax error : missing ';' b
efore '*' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(55): error C4430: missing type specifier - int
assumed. Note: C++ does not support default-int [c:\dev\projects\mpc-hc\src\mp
c-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(55): error C2039: 'm_pWicFactory' : is not a m
ember of 'AFX_GLOBAL_DATA' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\atlmfc\include
\afxglobals.h(111) : see declaration of 'AFX_GLOBAL_DATA'
..\thirdparty\mfc\afxglobals.cpp(55): error C4430: missing type specifier - int
assumed. Note: C++ does not support default-int [c:\dev\projects\mpc-hc\src\mp
c-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(57): error C2039: 'm_pfD2D1MakeRotateMatrix' :
is not a member of 'AFX_GLOBAL_DATA' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc
.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\atlmfc\include
\afxglobals.h(111) : see declaration of 'AFX_GLOBAL_DATA'
..\thirdparty\mfc\afxglobals.cpp(57): error C2146: syntax error : missing ';' b
efore identifier 'm_pfD2D1MakeRotateMatrix' [c:\dev\projects\mpc-hc\src\mpc-hc\
mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(57): error C4430: missing type specifier - int
assumed. Note: C++ does not support default-int [c:\dev\projects\mpc-hc\src\mp
c-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(57): error C4430: missing type specifier - int
assumed. Note: C++ does not support default-int [c:\dev\projects\mpc-hc\src\mp
c-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(59): error C2039: 'm_bD2DInitialized' : is not
a member of 'AFX_GLOBAL_DATA' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxpro
j]
C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\atlmfc\include
\afxglobals.h(111) : see declaration of 'AFX_GLOBAL_DATA'
..\thirdparty\mfc\afxglobals.cpp(921): error C3861: 'ReleaseD2DRefs': identifie
r not found [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(1469): error C2039: 'InitD2D' : is not a membe
r of 'AFX_GLOBAL_DATA' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\atlmfc\include
\afxglobals.h(111) : see declaration of 'AFX_GLOBAL_DATA'
..\thirdparty\mfc\afxglobals.cpp(1469): error C2065: 'D2D1_FACTORY_TYPE' : unde
clared identifier [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(1469): error C2146: syntax error : missing ')'
before identifier 'd2dFactoryType' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.v
cxproj]
..\thirdparty\mfc\afxglobals.cpp(1469): error C2059: syntax error : ')' [c:\dev
\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(1470): error C2143: syntax error : missing ';'
before '{' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(1470): error C2447: '{' : missing function hea
der (old-style formal list?) [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj]
..\thirdparty\mfc\afxglobals.cpp(1527): error C2039: 'ReleaseD2DRefs' : is not
a member of 'AFX_GLOBAL_DATA' [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-hc.vcxproj
]
C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\atlmfc\include
\afxglobals.h(111) : see declaration of 'AFX_GLOBAL_DATA'
..\thirdparty\mfc\afxglobals.cpp(1536): error C2227: left of '->Release' must p
oint to class/struct/union/generic type [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-
hc.vcxproj]
type is 'int *'
..\thirdparty\mfc\afxglobals.cpp(1542): error C2227: left of '->Release' must p
oint to class/struct/union/generic type [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-
hc.vcxproj]
type is 'int *'
..\thirdparty\mfc\afxglobals.cpp(1548): error C2227: left of '->Release' must p
oint to class/struct/union/generic type [c:\dev\projects\mpc-hc\src\mpc-hc\mpc-
hc.vcxproj]

[ikarad]

Sub is flashed only in full screen, in window - all ok.

In window, sub is flashed also on my computer.

[vBm]

I'm having some compile issues. If anyone knows what kind of moron I'm being I'd appreciate being knocked over the head with it. I'm pulling from GIT.

Are you following https://sourceforge.net/apps/trac/mpc-hc/wiki/How_to_compile_the_MPC ?

[SamuriHL]

Are you following https://sourceforge.net/apps/trac/mpc-hc/wiki/How_to_compile_the_MPC ?

Woa, they changed it. Ok, thanks so much! I'm sure I can get it working now.

[vBm]

NP. Wiki page always contain the newest info. Always refer to it in future.

[SamuriHL]

Yea, call it a memory lapse. I have it bookmarked and didn't really think of it tbh. I've been sick for the past few days so my brain is fried. Thanks again.

[Aleksoid1978]

About PGS subtitle - in this file at the begin PGS draw with incorrect color, like there is no Palette set for this segment
http://aleksoid.tosei.ru/Test/Sample/PGS/PGS_StartBroken.m2ts

[JEEB]

About PGS subtitle - in this file at the begin PGS draw with incorrect color, like there is no Palette set for this segment
http://aleksoid.tosei.ru/Test/Sample/PGS/PGS_StartBroken.m2ts
If that is the sample that Underground was working on yesterday, it really doesn't have a palette set there (because of how the sample was cut). The specification seems to say that in such cases a fully transparent palette should be used, so I think that's how it was decided to be fixed (it will of course lead to this kind of subpictures not showing, but I think following the specification is better than showing possibly broken subpictures with some cached/default palette) :)

[ikarad]

I find a problem with sub.


problem:
At the beginning of this video (beginnning credits), subs flash. With directvobsub, subs are displayed without flash
https://sourceforge.net/apps/trac/mpc-hc/ticket/2617

It works with xy-vsfilter but I must switch and it's not a native solution.

Are there any plans to merge xyvsfilter with mpc-hc?


CLSID asked some months ago the same thing
Are there any plans to merge changes from xy-vsfilter project? The performance gains are significant.

[vivan]

ikarad,
Custom interface for rendering subtitles on an RGBA texture(s) (http://code.google.com/p/xy-vsfilter/issues/detail?id=40).

[Aleksoid1978]

If that is the sample that Underground was working on yesterday, it really doesn't have a palette set there (because of how the sample was cut). The specification seems to say that in such cases a fully transparent palette should be used, so I think that's how it was decided to be fixed (it will of course lead to this kind of subpictures not showing, but I think following the specification is better than showing possibly broken subpictures with some cached/default palette) :)

ffdshow & mpc-be show normal. if no pallete - i think must do:
or do not show this segment, or use default palette;

P.S. What about his file - http://aleksoid.tosei.ru/Test/Sample/Blind_Fury.m2ts. After latest change broken subtitle render. in this sample.

[ikarad]

ikarad,
Custom interface for rendering subtitles on an RGBA texture(s) (http://code.google.com/p/xy-vsfilter/issues/detail?id=40).

Thanks but I don't understand why you have posted this link because the problem arrive with or without madvr.

[Keiyakusha]

ikarad
this link means xy-vsfilter won't be merged. xy is already better than any external renderer and once thing by that link is finished it will be better than any internal one. Integrating it will means completely removing what its there now and then updating each time. But that's pointless as you can just download new version and don't need to maintain the code. By being external library it will be able to do anything that internal renderer capable of. It doesn't restricted to madvr, any software will be able to use it. Of course support for that needs to be added.

[ikarad]

ikarad
this link means xy-vsfilter won't be merged. xy it is already better than any external renderer and once thing by that link is finished it will be better than any internal one. Integrating it will means completely removing what its there now and then updating each time. But that's pointless as you can just download new version and don't need to maintain the code. By being external library it will be able to do anything that internal renderer capable of.

The problem is that xy vsfilter doesn't work well with pgs subs (there is the problem with multiple sub displayed in the same time that aleksoid have corrected some days ago) and I must swith between internal sub renderer and xy vsfilter. It's not very user friendly.


If xy vsfilter is the better, why mpc-hc don't intergrate xy vsfllter because I don't understand the interest to keep internal sub renderer if it's less good. A merger could permit to have the better of the two worlds.

An interest of mpc-hc is to have all in internal renderer.

[Keiyakusha]

The problem is that xy vsfilter doesn't work well with pgs subs (there is the problem with multiple sub displayed in the same time that aleksoid have corrected some days ago) and I must swith between internal sub renderer and xy vsfilter. It's not very user friendly.

I wasn't aware of pgs problems, then maybe bugreport should be filled. Edit: yet this is not a big problem that will make someone to completely integrate something.
As for integrating I explained already. It is pointless to integrate as xy-vsfilter will have complete replacement for built-in renderer's functionality. Replacement will means deleting all current vsfilter internal and external stuff in mpc-hc and adding all things from xy

[ikarad]

If xy vsfilter is better than interal sub renderer of mp-hc like you said, why keep a sub renderer that is less good?

mpc-hc team update ffmpeg each time ti's necessary. It would be the same thing for xy vsfilter.

[Keiyakusha]

If xy vsfilter is better than interal sub renderer of mp-hc like you said, why keep a sub renderer that is less good?
xy is not finished yet. read stuff more carefully. I never said it is better than internal, I said it will be.

mpc-hc team update ffmpeg each time ti's necessary. It would be the same thing for xy vsfilter.
you don't seem to understand what you asking for. complete replacing means that among other things you'll have pgs bug from xy ported too. Internal mpc renderer will be no more! Also i believe mpc-hc doesn't uses the whole ffmpeg, just needed parts of it.
If you want some specific part of the xy merged, that's different story. Good luck finding someone who will dig into its code and extract that part.

[ikarad]

xy is not finished yet. read stuff more carefully. I never said it is better than internal, I said it will be.


you don't seem to understand what you asking for. complete replacing means that among other things you'll have pgs bug from xy ported too. Internal mpc renderer will be no more! Also i believe mpc-hc doesn't uses the whole ffmpeg, just needed parts of it.
If you want some specific part of the xy merged, that's different story. Good luck finding someone who will dig into its code and extract that part.
I speak about merge instead of replace.

i think it would be possible because it seems that xy vsfilter is based upon vsfilter which is the same in mpc-hc.

It's just one question that I ask. CLsid have asked the same question like I mentionned above.

If clsid have asked the question, I think, there is one reason.

[Keiyakusha]

well, you whatever merge only needed parts, or throw away the whole thing and replace it. If second, it doesn't need to be merged cause it works as separate library just good. when xy will be finished I'd like to see that. Just as much as I'd like to see internal filters completely removed without trace of them left and external LAV used in package. And if first, you should be more specific about what exactly from xy you want to merge. Merging the whole xy will be the same as replacing. Unless, as you say someone will want to keep "renderer that is less good"

[JEEB]

ffdshow & mpc-be show normal. if no pallete - i think must do:
or do not show this segment, or use default palette;
Yup, the fix is in Underground's tree and should get merged soon'ish into master, I think he was also wanting to work on forced subpictures too, which could be related why it's not yet in the main master. Anyways, as I said, the fix was to use the specified-by-spec default palette (all transparent it seems).

I have no idea about the other sample to be honest, as I just voiced my opinion that the specification should be honored instead of just giving it some random cached/default palette with regards to the no-palette sample when Underground was fixing that :)

[73ChargerFan]

... I'd like to see internal filters completely removed without trace of them left and external LAV used in package.
I like mpc-hc as an all-in-one player, and only having one file to download.

I'm not looking forward to having to check bi-weekly for LAV, xy vsfilter, madVR, and who knows what else.

The only thing left will be window frame and toolbar, which are not the best things about this player.

[Keiyakusha]

I like mpc-hc as an all-in-one player, and only having one file to download.

I didn't meant you'll have to download several files. That was poor explanation. Everything can be included in one package. Current internal filters are crap. Sub renderer, excluding some features that don't have replacement yet - crap too.
Edit: window and toolbar, location of menus and options, translations, is the only good things about this player, you didn't know? evr renderer too if not comparing it to madvr. there is places where madvr can lose, like x64 support, custom shaders...

[73ChargerFan]

UI is personal, and I'm not into retro. I delete the huge icons package because mpc-hc plays all my videos, and I don't care what the format is.

Internal filters work great, imho - I don't need haali, ac3filter, ffdshow to fill in the gaps anymore. VC1 support could be improved upon I guess. And I watch anime, never a problem with subs myself. Just lucky I guess.

I really only encounter a glitch once every other month, at which time I update then use VLC if it still doesn't work.

Back on topic, I'm fine with DLLs in the directory.

[betaking]

S.Chinese update
http://www.mediafire.com/?qrmesy7snm23ksg

[cyberbeing]

The problem is that xy vsfilter doesn't work well with pgs subs
MPC-HC's recent fixes for multiple PGS subtitles and parsing improvements are planned to be included in the next xy-VSFilter release. There is a bit of a delay, since the palette changes will require some additional modifications to xy-VSFilter's colorspace handling, and our fix for flickering PGS subtitles without pre-buffering (an issue which still exists in MPC-HC) was broken by these new MPC-HC commits and will need to be re-created.

On that note, our previous PGS/DVB flickering without pre-buffering fixes are here (http://repo.or.cz/w/xy_vsfilter.git/commit/7fcda23f5729bda59cef74ca3e536629f47ff282), if Underground78 or someone else would instead like to make it compatible with the recent PGS 'parsing improvement' commits by themselves, and merge it into MPC-HC in the meantime.

[Aleksoid1978]

Another 2 BIG BUGS with PGS on resize:
1 - Incorrect size/proportions
2 - Sometimes sub is hide/missing until seek, although they should still show up.
:)

[Dstruct]

I like mpc-hc as an all-in-one player, and only having one file to download.

Same here.

[vBm]

v1.6.4 is released.

After almost 6 weeks after the previous stable release, we decided to release 1.6.4.

It’s a maintenance release with a couple of UI improvements, few bugfixes and better API.

Highlights of this release:


Better UTF8 support for webui
Chapter indicators on seekbar
Improved DVD and PSG (BD) sub handling
Changed default maximum subtitle resolution to “Desktop”


You can download the new version here (http://mpc-hc.sourceforge.net/downloads/). For the complete changes see the changelog (http://mpc-hc.sourceforge.net/changelog/)

[Aleksoid1978]

On release - you have some memory leak, one it's in AudioDecoder, in Mixer

Detected memory leaks!
Dumping objects ->
{819618} normal block at 0x17DC0FD0, 12288 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
Object dump complete.

another i think as that associated with the PGS subtitles, test 2 different files with multiple PGS subtitle render at one time:

Detected memory leaks!
Dumping objects ->
{18092} normal block at 0x08C2B380, 1572 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
{18091} normal block at 0x00A50A28, 84 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
{18079} normal block at 0x009DC680, 104 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
{18078} normal block at 0x009DC5D8, 104 bytes long.
Data: < > CD CD CD CD D8 C5 9D 00 C0 95 A6 00 02 00 00 00
{18077} normal block at 0x00A5C778, 8228 bytes long.
Data: < x > CD CD CD CD 78 C7 A5 00 CD CD CD CD CD CD CD CD
{18076} normal block at 0x00A57378, 60 bytes long.
Data: < xs > CD CD CD CD 78 73 A5 00 80 C7 A5 00 80 C7 A5 00
{18075} normal block at 0x00A4E020, 40 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
{18074} normal block at 0x00A57278, 64 bytes long.
Data: < xr @ > CD CD CD CD 78 72 A5 00 40 E0 A4 00 01 00 00 00
{18073} normal block at 0x009E13F8, 232 bytes long.
Data: < 9 > CD CD CD CD F8 13 9E 00 C0 96 39 03 00 00 00 00
{18072} normal block at 0x00A631E0, 232 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
{18071} normal block at 0x00A54748, 492 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
{18070} normal block at 0x00A695B8, 220 bytes long.
Data: < 9 > CD CD CD CD B8 95 A6 00 80 8A 39 03 00 00 00 00
Object dump complete.

---
Detected memory leaks!
Dumping objects ->
{43174} normal block at 0x15FD1028, 36900 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
{43173} normal block at 0x1620BD18, 84 bytes long.
Data: < ? > CD CD CD CD 18 BD 20 16 00 00 80 3F 00 00 00 00
{43145} normal block at 0x060207C8, 104 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
{43142} normal block at 0x0BA73C68, 104 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
{43141} normal block at 0x16209CB8, 8228 bytes long.
Data: < > CD CD CD CD B8 9C 20 16 CD CD CD CD CD CD CD CD
{43140} normal block at 0x06088E20, 60 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
{43139} normal block at 0x0B9D8D68, 40 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
{43138} normal block at 0x06088DA0, 64 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD CD
{43137} normal block at 0x0BA73F58, 232 bytes long.
Data: < X? > CD CD CD CD 58 3F A7 0B C0 96 A6 02 00 00 00 00
{43136} normal block at 0x0B9ABBD8, 232 bytes long.
Data: < @ > CD CD CD CD D8 BB 9A 0B C0 96 A6 02 40 10 FD 15
{43135} normal block at 0x0B9AB9B0, 492 bytes long.
Data: < > CD CD CD CD CD CD CD CD CD CD CD CD B0 B9 9A 0B
{43132} normal block at 0x0BA74150, 220 bytes long.
Data: < PA > CD CD CD CD CD CD CD CD CD CD CD CD 50 41 A7 0B
Object dump complete.


if need - i upload this files;

Another bug - incorrect work with icon in AboutDlg.
First - there is never call DestroyIcon, simple like that

if (m_hIcon) {
DestroyIcon(m_hIcon);
}


and second - in Debug build Exception while open AboutDlg:
http://s019.radikal.ru/i621/1210/bc/9ad5e1065f41t.jpg (http://radikal.ru/F/s019.radikal.ru/i621/1210/bc/9ad5e1065f41.png.html)
http://i017.radikal.ru/1210/f8/763db336d1fbt.jpg (http://radikal.ru/F/i017.radikal.ru/1210/f8/763db336d1fb.png.html)

something not very good for the release :)

[v0lt]

you have some memory leak, one it's in AudioDecoder, in Mixer
Perhaps I solved this problem in 88f078a405 (https://github.com/mpc-hc/mpc-hc/commit/88f078a4058401bae43552bc8edb0bdf1426d73b)

[Pulstar]

When can we have FFmpeg 1.0 in a stable release kindly?

[Amour]

Thank you vBm for the release. I hope next one will focus on maximum Windows 8 / Windows Phone compatibility. :)

[kopija]

Greetings,
I am having trouble playing multi-channel sources using Reclock combined with MPCHC internal audio renderer.
MPCHC audio renderer output is recognized by Reclock, but there is no sound output. Stereo sources work fine, though. When using ffdshow or LAV audio everything works fine.
Has anybody else noticed this?
Using Windows 7, with Reclock configured to output AC3 via optical to my receiver.
Thanks for any suggestions!

[pirlouy]

Thank you vBm for the release. I hope next one will focus on maximum Windows 8 / Windows Phone compatibility. :)
I wonder where you read MPC will be compatible with Windows Phone.
From what I've read, applications for Windows Phone 8 don't necessarily use the same language (except some Microsoft applications).

[madshi]

@developers,

the latest madVR build v0.84.0 now supports screenshots. Would you mind updating your video renderer configuration panel to reflect this change? Currently MPC-HC claims madVR can't do screenshots (which was correct until today).

Thanks!

[Snowknight26]

It claims it and it still seems it can't. You get the usual dialog box about Save Image function not working with madVR.

[Superb]

https://github.com/mpc-hc/mpc-hc/blob/master/src/mpc-hc/MainFrm.cpp
In CMainFrame::IsRendererCompatibleWithSaveImage
Remove:
else if (s.iDSVideoRendererType == VIDRNDT_DS_MADVR) {
AfxMessageBox(IDS_SCREENSHOT_ERROR_MADVR, MB_ICONEXCLAMATION | MB_OK, 0);
result = FALSE;
}

EDIT: And for the Output page in Settings...
https://github.com/mpc-hc/mpc-hc/blob/master/src/mpc-hc/PPageOutput.cpp
In CPPageOutput::OnDSRendererChange
Under:
case VIDRNDT_DS_MADVR:
Add:
m_iDSSaveImageSupport.SetIcon(tick);
(preferably, under m_iDSSubtitleSupport.SetIcon(tick); )

[Armada]

@developers,

the latest madVR build v0.84.0 now supports screenshots. Would you mind updating your video renderer configuration panel to reflect this change? Currently MPC-HC claims madVR can't do screenshots (which was correct until today).

Thanks!
Is there any way to detect which version the user is using? So we don't give users with an old version the option to make a screenshot.

It claims it and it still seems it can't. You get the usual dialog box about Save Image function not working with madVR.
That dialog is part of MPC-HC, it still thinks it's unsupported while in reality it is.

[madshi]

Something must have changed in MPC-HC because the (relatively old) MPC-HC build I'm still using (1.5.3.3760) allows doing screenshots with madVR.

@Armada, you could find out the video renderer file path and then use win32 APIs to find out the file version, but that's rather complicated. I think the best and easiest solution would be what old MPC-HC builds did: Namely trying to make a screenshot and complaining if it fails. That should handle all cases just fine. Ok, maybe the user will see a "file save" dialog and then get a complaint afterwards, when using an old madVR build. But all newer madVR builds will support screenshots, so it's only a matter of time when everybody has a madVR build with screenshot support. So I would simply try to make a screenshot and complain if it fails.

[sneaker_ger]

Something must have changed in MPC-HC because the (relatively old) MPC-HC build I'm still using (1.5.3.3760) allows doing screenshots with madVR.

Revision 4585, Fri May 4 20:19:52 2012

Disable saving images/thumbnails if using madVR as video renderer

patch by demi_alucard
This commit fixes ticket #2261.

[Blitzker]

For thoses interested, i've build the lastest MPC-HC git with Superb's modifs to be able to take screenshots with MadVR 0.84.

You can grab it here: http://www.mediafire.com/download.php?dj7b3fq8n8k5rtj

Have fun!

[Sylt]

@Blitzker: Can you please push this changes/patch to the GitHub Repository of MPC-HC (you can create a Pull Request for this).

[Armada]

I pushed the necessary changes to the GitHub repo now and I'll see if I can improve the error handling later.

The changes should be available as a nightly build in a few hours.

[kasper93]

With all due respect downloading random build from random people is not good idea :)

It's easy change, only few lines and I'm sure someone from the team will change it ASAP.

Is there any way to detect which version the user is using? So we don't give users with an old version the option to make a screenshot.
I think it's fine to remove that check completely. Most of madVR user know what they are doing. And most likely everyone uses newest version of it so there is not big problem here :)

If doing screenshot with older madVR would crash mpc then it would be worth to do check, but there is error, which everyone can search for and find that they need to update madVR :)

[Sylt]

@Armada: Any news about the memory leaks with icon handling, reported by aleksoid? I found already a patch in the trac.

[Armada]

@Armada: Any news about the memory leaks with icon handling, reported by aleksoid? I found already a patch in the trac.
The AboutDlg bug is already on my To-Do list, I'll keep an eye out for memory leaks also. The AboutDlg memory leak is unlikely to cause issues though, unless you regularly opens thousands of about dialogs. But it is still a memory leak and will be fixed.

As for other memory leaks, I'll try and address most of them before the next stable. Latest report indicated 34 leaks during playback, so there's quite some work to do to find them all.

[Sylt]

Sounds very good. Thank you! Here I found a fix: http://sourceforge.net/apps/trac/mpc-hc/ticket/2641

I've a feature request: Can you improve the seekbar, like android:
http://i.techrepublic.com.com/blogs/seekbar_2.png

[Armada]

I have other improvements planned for the interface (classic will stay available), but I can't fix leaks and work on the interface at the same time.

[Aleksoid1978]

The AboutDlg bug is already on my To-Do list, I'll keep an eye out for memory leaks also. The AboutDlg memory leak is unlikely to cause issues though, unless you regularly opens thousands of about dialogs. But it is still a memory leak and will be fixed.

As for other memory leaks, I'll try and address most of them before the next stable. Latest report indicated 34 leaks during playback, so there's quite some work to do to find them all.

To easy find memory leak - try Visual Leak Detector (http://vld.codeplex.com/)

P.S. - But I can tell - a lot of leaks in the new mechanism/parser PGS subtitles.

[Armada]

To easy find memory leak - try Visual Leak Detector (http://vld.codeplex.com/)

P.S. - But I can tell - a lot of leaks in the new mechanism/parser PGS subtitles.
Thanks, vBm also recommended that leak detector.

I'll pay especially close attention to the PGS parser. But the internal filters seem to contain the most leaks, even before the changes to the PGS parser.