Media Player Classic Home Cinema (MPC-HC) - DXVA!

[vBm]

I don't think there are many if any differences at all between the builds, Blitzker just filled in while Alexins was away which was nice.

Could I get a developer add a couple of rather trivial things to be displayed via the OSD via hotkey please?

The OSD displays the audio properties When the audio is changed which is great but I'd like to just be able to display the properties without changing the audio. Also the filename for the currently playing file displays for a couple of seconds on initial playback, I'd like the OSD to be able to display this via hotkey as well.

Functionality for both is obviously already there, they just require the ability to link to hotkeys, thanks.

Open new ticket (http://sourceforge.net/apps/trac/mpc-hc/newticket) please and they will try to do their best.

[oddball]

I experienced issues with DTS playback in MPC-HC so I uninstalled everything including all my filters but now it refuses to playback ANY MKV files with DTS. I used RevoUninstaller to clear out everything I could think of and installed the MPC-HC version on the official site. Still no go. It loads the MKV's but they stop at 0 on playback. No amount of pausing/unpausing or moving the slider makes them play.

So out of interest I installed the 64 bit version. It plays them fine! But I need access to my 32 external filters which will not work with the 64 bit version from what I know.

Any ideas?

MKV's with AC3 playback fine BTW.

[namaiki]

Since you are using external filters, when you open the DTS file in MPC-HC what items are listed in the Play-> Filters menu?

[oddball]

Since you are using external filters, when you open the DTS file in MPC-HC what items are listed in the Play-> Filters menu?


I am not using ANY external filters at present. I cleared them all out (Uninstalled them with RevoUninstaller to clear anything left in the registry etc). The filters listed are Null Renderer, Default DirectSound Device, Enhanced Video Renderer (Custom Preset), MPC Video Decoder, MPC Audio Decoder and MPC Matroska Source.

EDIT: OK I installed Haali Matroska splitter to see what is going on in a Graphedit and video is going to File Writer audio to File Writer 0001 and Subtitles to File Writer 0006. What the heck?

[ryrynz]

Open new ticket (http://sourceforge.net/apps/trac/mpc-hc/newticket) please and they will try to do their best.

Done, I've updated my feature request a little also.

https://sourceforge.net/apps/trac/mpc-hc/ticket/2053
It's a simple but I feel useful addition which I hope other users would find useful also. Basically it's being able to see simple file info (filename, audio and video) on initial playback or displayed via hotkey. :thanks:

[oddball]

OK it looks like my issue is/was with me messing about in DSFMgr. A very dangerous tool in the wrong hands (Like mine). I found a DShow reset thingie that seems to have put things back as they were. Hopefully a clean slate to install on.

[ryrynz]

See Madshi's post below.

[madshi]

@MPC-HC devs / aleksoid:

I've recently been receiving complaints about madVR freezes when using MPC-HC. After having added the new freeze reporting feature in madVR v0.81, I've now received 2 freeze reports from 2 different users. The freeze reports indicate that the freeze occurs when madVR leaves exclusive mode. In that moment a display mode change is sometimes triggered. This results in madVR trying to release its Direct3D object from within the secondary rendering thread. It appears that when the freeze occurs, MPC-HC is trying to create its own Direct3D object, in the context of the main thread, as a reaction to the display mode change, while madVR is still busy releasing its Direct3D object. It appears that the freeze occurs inside of Direct3D in this situation (let's just blame MS).

From what I can see, the problem was introduced in MPC-HC revision 3619 by aleksoid's changes in "MainFrm.cpp". I understand why you're doing what you're doing there, but it does cause the freeze. Could you maybe limit this code to situations when it's really needed? It seems to me its needed only when using the MPC-HC internal DXVA decoders? Currently the new code in "MainFrm.cpp" seems to be always executed, regardless of which renderer and which decoder is active. That shouldn't be necessary, I think.

One other thing: The quality of the madVR freeze reports would increase if madVR could get access to the MPC-HC debug information. Those of you who provide MPC-HC builds, would you consider using my tool "madExceptPatch" to add a subset of the debug information into the MPC-HC exe file? It would increase the exe file size by maybe 5-10%. The benefit would be that madVR's freeze reports would include full callstacks for the MPC-HC source code, too. More details on how to do this see the bottom of this post:

http://forum.doom9.org/showthread.php?p=1561246#post1561246

[crewxp]

I have a few questions hopefully you can help me out with:

1.) I have the MadVR version of MPCHC and it looks fine. But subtitles do NOT show up. If I click the MadVR Tray Icon and select 'English' under subtitle track, instead of No subtitle, it works! I was wondering if I can set madVR to do this automatically so I don't have to choose a subtitle each time I play a video.
2.) There seems to be a menu I can't get rid of on top of my videos. (Display, Composition Rate, Windowed Mode, etc). It shows up on the top left of my video and is transparent. I think it has something to do with madVR also. Any way to get it off?

[madshi]

I have a few questions hopefully you can help me out with:

1.) I have the MadVR version of MPCHC and it looks fine. But subtitles do NOT show up. If I click the MadVR Tray Icon and select 'English' under subtitle track, instead of No subtitle, it works! I was wondering if I can set madVR to do this automatically so I don't have to choose a subtitle each time I play a video.
2.) There seems to be a menu I can't get rid of on top of my videos. (Display, Composition Rate, Windowed Mode, etc). It shows up on the top left of my video and is transparent. I think it has something to do with madVR also. Any way to get it off?
These questions are more madVR related so they should probably go into the madVR thread. Anyway:

1.) This is a job for the splitter. Check if your splitter allows you to define which subtitle track should be displayed by default. I think (but I'm not 100% sure) both LAV Splitter and Haali have options for that.
2.) Press Ctrl+J to activate/deactivate that menu.

[Aleksoid1978]

@MPC-HC devs / aleksoid:

I've recently been receiving complaints about madVR freezes when using MPC-HC. After having added the new freeze reporting feature in madVR v0.81, I've now received 2 freeze reports from 2 different users. The freeze reports indicate that the freeze occurs when madVR leaves exclusive mode. In that moment a display mode change is sometimes triggered. This results in madVR trying to release its Direct3D object from within the secondary rendering thread. It appears that when the freeze occurs, MPC-HC is trying to create its own Direct3D object, in the context of the main thread, as a reaction to the display mode change, while madVR is still busy releasing its Direct3D object. It appears that the freeze occurs inside of Direct3D in this situation (let's just blame MS).

From what I can see, the problem was introduced in MPC-HC revision 3619 by aleksoid's changes in "MainFrm.cpp". I understand why you're doing what you're doing there, but it does cause the freeze. Could you maybe limit this code to situations when it's really needed? It seems to me its needed only when using the MPC-HC internal DXVA decoders? Currently the new code in "MainFrm.cpp" seems to be always executed, regardless of which renderer and which decoder is active. That shouldn't be necessary, I think.

One other thing: The quality of the madVR freeze reports would increase if madVR could get access to the MPC-HC debug information. Those of you who provide MPC-HC builds, would you consider using my tool "madExceptPatch" to add a subset of the debug information into the MPC-HC exe file? It would increase the exe file size by maybe 5-10%. The benefit would be that madVR's freeze reports would include full callstacks for the MPC-HC source code, too. More details on how to do this see the bottom of this post:

http://forum.doom9.org/showthread.php?p=1561246#post1561246

It's code need for internal render. I disable event Display change on Intel Adapter.
You received freeze reports - what adapter this people use.
I think - need add check for madVR. If render is madVR - then do DisplayChange event.

Or - always don't send event DisplayChange with madVR render ???

[madshi]

It's code need for internal render. I disable event Display change on Intel Adapter.
I think - need add check for madVR. If render is madVR - then do DisplayChange event.

Or - always don't send event DisplayChange with madVR render ???
If you need this for internal renderers then it would probably make sense to only call that code when internal renderers are used. So if you could just disable that "Direct3DCreate9" code when external renderers (madVR + Haali) are used, that would be great! It should fix the freeze users have with MPC-HC + madVR.

You received freeze reports - what adapter this people use.
I've received 3 freeze reports now. The GPUs in those 3 reports are:

(1) NVIDIA GeForce GTX 570 (driver 8.17.12.9573)
(2) ATI Radeon HD 5700 Series (driver 8.930.0.0)
(3) Intel(R) HD Graphics Family (driver 8.15.10.2622)

Funny, exactly one freeze report per GPU manufacturer... :D

[Aleksoid1978]

If you need this for internal renderers then it would probably make sense to only call that code when internal renderers are used. So if you could just disable that "Direct3DCreate9" code when external renderers (madVR + Haali) are used, that would be great! It should fix the freeze users have with MPC-HC + madVR.


I've received 3 freeze reports now. The GPUs in those 3 reports are:

(1) NVIDIA GeForce GTX 570 (driver 8.17.12.9573)
(2) ATI Radeon HD 5700 Series (driver 8.930.0.0)
(3) Intel(R) HD Graphics Family (driver 8.15.10.2622)

Funny, exactly one freeze report per GPU manufacturer... :D

Try - http://rghost.ru/36842812

[madshi]

Try - http://rghost.ru/36842812
Thx, I'll post this in the madVR thread and ask for feedback. I didn't have the freezes myself, so I can only forward to those users who had the problem.

[DzigiBau]

I cannot remember exactly if I read about this one somewhere.

Every time I start playing movie in MP-HC fro the first time, does not matter what version, newest or some older, it played it with a huge ammount of lags or jitter. After I closed MPC-HC, opened it again and start playing movie, everything is all right.

This is annoying but I used to live with it. Do you have some quick solution for this one.

Using MPC-HC, Win 7 32-bit, ATI HD5770, 4Gb RAM. MPC-HC is with FFDshow external decoder, EVR-CP, the issue remains with internal one, too.

[ryrynz]

Try using LAV filters and see what happens.

http://lavfilters.googlecode.com/files/LAVFilters-0.48.exe

[CruNcher]

Anyone a idea why this simple chain fails with MPC-HC (using preferred custom loading) WMV Asf Reader->Cyberlink->EVR ? http://img62.imageshack.us/img62/4116/failsmpchc.png

[Dstruct]

MPC-HC 1.6.0.4014

Crash on incomplete AVI:

crash-mpc-hc-4014.avi (4096 Bytes - extracted with Hex editor)


Tracker: https://sourceforge.net/apps/trac/mpc-hc/ticket/2057


FIXED (4125)

[Hera]

And all version on W8 and W7, get stuck, fast forward, etc.

[madshi]

Try - http://rghost.ru/36842812
The issue still seems to be there. Here are some extracts from a new freeze report which the user claims is created with your test build:

main thread ($bf4):
77658cd3 +16a33 ntdll.dll RtlEnterCriticalSection
73030a8e +0002c d3d9.dll Direct3DCreate9
77630107 +0002b ntdll.dll KiUserCallbackDispatcher
761c074c +00192 USER32.dll PeekMessageW

thread $86c:
7763f8aa +0000e ntdll.dll NtWaitForSingleObject
77658cd3 +16a33 ntdll.dll RtlEnterCriticalSection
73030a8e +0002c d3d9.dll Direct3DCreate9
73311912 +00012 IntelQuickSyncDecoder.dll createQuickSync

Queue_RenderThread ($cf4): <priority:2>
761c6c6a +003a USER32.dll SystemParametersInfoA
4a4089ba +017a madVR.ax direct3d.cpp 1503 +43 Direct3D_Final
4a41d2fe +178e madVR.ax framequeue.cpp 7103 +609 Queue_RenderThread
As you can see, there are now 2 threads (!!) in MPC-HC which are calling Direct3DCreate() at the same time, while madVR is stuck in Direct3DDevice9->Release().

[Aleksoid1978]

The issue still seems to be there. Here are some extracts from a new freeze report which the user claims is created with your test build:

main thread ($bf4):
77658cd3 +16a33 ntdll.dll RtlEnterCriticalSection
73030a8e +0002c d3d9.dll Direct3DCreate9
77630107 +0002b ntdll.dll KiUserCallbackDispatcher
761c074c +00192 USER32.dll PeekMessageW

thread $86c:
7763f8aa +0000e ntdll.dll NtWaitForSingleObject
77658cd3 +16a33 ntdll.dll RtlEnterCriticalSection
73030a8e +0002c d3d9.dll Direct3DCreate9
73311912 +00012 IntelQuickSyncDecoder.dll createQuickSync

Queue_RenderThread ($cf4): <priority:2>
761c6c6a +003a USER32.dll SystemParametersInfoA
4a4089ba +017a madVR.ax direct3d.cpp 1503 +43 Direct3D_Final
4a41d2fe +178e madVR.ax framequeue.cpp 7103 +609 Queue_RenderThread
As you can see, there are now 2 threads (!!) in MPC-HC which are calling Direct3DCreate() at the same time, while madVR is stuck in Direct3DDevice9->Release().


Ok - i see. I try to test on my machine and then give build for you.

[madshi]

Great - thanks!

[Aleksoid1978]

Great - thanks!

Try this :
http://aleksoid.tosei.ru/Test/mpc-hc.madVR_1.7z
http://aleksoid.tosei.ru/Test/mpc-hc.madVR_2.7z

if first - I add a check for the presence of madVR renderer in the graph;
if two - i completely removed the call Direct3DCreate9();

[madshi]

Try this :
http://aleksoid.tosei.ru/Test/mpc-hc.madVR_1.7z
http://aleksoid.tosei.ru/Test/mpc-hc.madVR_2.7z

if first - I add a check for the presence of madVR renderer in the graph;
if two - i completely removed the call Direct3DCreate9();
Thanks for your help.

My users report that build 2 fixes the problem, but build 1 does not. I think the reason why build 1 doesn't help is probably that MPC-HC is already closing madVR down. So probably your check "if madVR renderer present in the graph" returns false. Maybe you could turn the check around, and check whether any internal renderer is present in the graph?

[Aleksoid1978]

Thanks for your help.

My users report that build 2 fixes the problem, but build 1 does not. I think the reason why build 1 doesn't help is probably that MPC-HC is already closing madVR down. So probably your check "if madVR renderer present in the graph" returns false. Maybe you could turn the check around, and check whether any internal renderer is present in the graph?

I make different - i do check for internal settings, if select madVR - then do not call :)

[madshi]

Sounds good to me, too.

[v_spec]

I've search the entire forum and a few others and still couldn't find a answer.

Can someone explain to me what "set interlace flag in output media type" does under Transform Filters > MPEG-2 Video? It is unchecked by default.

From what I understand it enables hardware deinterlacing?

I have MPEG-2 Video Deinterlacing set on Automatic but I noticed when I play .ts files the filter fails to automatically detect and detinerlace video. I currently have it set to "Blend" as any other setting has no effect or makes the video quality worse. If I leave it on "Blend" will it also deinterlace progressive videos as well? Wouldn't that ruin video quality?

[Aleksoid1978]

Sounds good to me, too.

Try - rev.4128

[madshi]

Try - rev.4128
I've confirmation that 4128 fixed the freeze. Thanks!! :)

[Andy o]

Thanks from me too for fixing this guys.

[xiulet]

sorry error!

[xiulet]

Try - rev.4128
don't work for me, the 4128 is still freezing when i try to go out from excusive full screen mode using madvr.

thanks, ad1

[madshi]

don't work for me, the 4128 is still freezing when i try to go out from excusive full screen mode using madvr.
With which madVR version? I'm currently working on stability. It's quite possible that the freeze you're experiencing has a different cause. Please post a freeze report in the madVR thread, then I can say for sure.

[xiulet]

With which madVR version? I'm currently working on stability. It's quite possible that the freeze you're experiencing has a different cause. Please post a freeze report in the madVR thread, then I can say for sure.
i answer in your post!

:) ad1

[Plutotype]

Thanks to Aleksoid for the madVR freeze fix in the player code.

[THX-UltraII]

My DirectX 11 renderer prototype has an option to display 3D graphics. It's an imported module (just like most of the renderer itself) and I can't test it myself. The code will need a lot of editing before it will 'fit' properly in the profile of MPC-HC. I'm not even going to try to integrate 3D support into one of the current renderers. The renderer prototype can't even render from (2D) MediaFoundation or DirectShow video sources at the moment. I'm prioritizing the final integration of my edited internal renderers for now, I can't afford to work on new prototypes.
In short, I'm sorry. I can add the renderer part of the support, but I'm too busy with other things for now.
And is it also not possible to use the Nvidia renderer as output renderer in MPC-HC so 3D will work?

[madshi]

@Aleksoid, bad news. I've got a new freeze report, this time from MPC-HC revision 4130. Here's what it says:

main thread ($1ae4):
7701f8aa +0000e ntdll.dll NtWaitForSingleObject
77038cd3 +16a33 ntdll.dll RtlEnterCriticalSection
6ba80a8e +0002c d3d9.dll Direct3DCreate9
77010107 +0002b ntdll.dll KiUserCallbackDispatcher
74c97945 +00016 USER32.dll CallWindowProcA

Queue_RenderThread ($1648): <priority:2>
74c96c6a +003a USER32.dll SystemParametersInfoA
4a40c6e1 +02f1 madVR.ax direct3d.cpp 1596 +66 Direct3D_Final
4a434a84 +1af4 madVR.ax framequeue.cpp 7135 +633 Queue_RenderThread

modules:
01380000 mpc-hc.exe 1.6.1.4130 K:\programs\MPC-Homecinema.1.6.1.4130\x86
4a400000 madVR.ax 0.82.4.0 K:\programs\madVR v0.82.4
So basically the main thread is once again trying to create a Direct3D9 device while madVR is trying to release its own. To be honest, I'm not sure why this still happens. Your fix looks alright to me. But I'm pretty sure the freeze report doesn't lie. Do you have any idea why this could still happen?

[madshi]

P.S: Hmmmm... Are there maybe other places in the MPC-HC source code where it tries to create a Direct3D device in the main thread? I mean other than the internal renderers, of course? Unfortunately madVR had no access to MPC-HC debug information when it created that freeze report, so we don't know for sure which part of MPC-HC exactly called Direct3D9Create...

[mark0077]

Guys is anyone having an issue with recent mpc-hc builds (I don't know when it came in to be honest), where the external filter list will empty itself out from time to time. I have had this happen about 3 times in the past month, opening a video file, I'll notice somethings not right with playback, and the external filter list will be empty (or more precisely, only contain the LAV Splitter)

[oddball]

Guys is anyone having an issue with recent mpc-hc builds (I don't know when it came in to be honest), where the external filter list will empty itself out from time to time. I have had this happen about 3 times in the past month, opening a video file, I'll notice somethings not right with playback, and the external filter list will be empty (or more precisely, only contain the LAV Splitter)

Had similar issue usually when MPC had crashed. Not experienced it since using newer xvidvideo.ru builds though.

[73ChargerFan]

Guys is anyone having an issue with recent mpc-hc builds (I don't know when it came in to be honest), where the external filter list will empty itself out from time to time. I have had this happen about 3 times in the past month
No, but when it happens again, delete the settings from the registry before resetting them. Weird behavior for me is often fixed by doing this.
HKEY_CURRENT_USER\Software\Gabest

[v0lt]

Guys is anyone having an issue with recent mpc-hc builds (I don't know when it came in to be honest), where the external filter list will empty itself out from time to time.
This problem is old.
You open the video, a little looking, closed the player and quickly opened a new video again. So?

[chros]

This problem is old.
You open the video, a little looking, closed the player and quickly opened a new video again. So?
Exactly! (at least for me :) )

[CruNcher]

the whole config saving into registry is also a problem since dawn of time it stalls the whole player not really optimal (as soon as you close the config window it stalls), also not being able to open more windows on top but limited to 1 extra window is imho not flexible ;) though ok for a player it's not really needed but would be neat to be able to interact with more then 1 window @ a time ;) typical scenario would be opening the properties (mediainfo details) and filter properties @ the same time ;)

[wanezhiling]

WIN7 x64
NVIDIA GTS450
295.73WHQL
MPC-HC 1.6.1.4137,default setting


Here is some VC1 clips:

http://www.gokuai.com/f/9JeeFL9wy19st7q3

http://i.imgur.com/ShsKx.png
http://i.imgur.com/VTQNV.jpg
http://i.imgur.com/b646F.jpg
http://i.imgur.com/avNgE.png
http://i.imgur.com/pKk6S.jpg
http://i.imgur.com/caEJc.png
http://i.imgur.com/yqGUn.jpg


http://uk1-dl.techpowerup.com/Misc/hddvd_demo_1080p.mkv

http://i.imgur.com/EFv45.png
http://i.imgur.com/XkVWJ.jpg
http://i.imgur.com/KP7Oq.jpg
http://i.imgur.com/7GUG9.png
http://i.imgur.com/vS2JP.jpg
http://i.imgur.com/sJowz.jpg
http://i.imgur.com/Z5i4G.jpg
http://i.imgur.com/3HIB0.jpg
http://i.imgur.com/1ssF9.png


http://www.gokuai.com/f/mc0120724y329lwg

http://i.imgur.com/lJFz0.png


PS1: Only MPC-HC DXVA and ffdshow DXVA have the issue on my NVIDIA system,other native DXVA decoders work well.
PS2: No problem on my ATI system.

[CruNcher]

Different Hardware needs different implementation ways (code paths) the main dev on the DXVA part i guess is a ATI user ;)
i didn't looked into it but last time even the Mpeg-2 Part on many bitstreams for Intel HD Graphics was very unstable (Sandy Bridge,Ivy Bridge DXVA) in that case they could borrow Nevs DXVA2 it's pretty stable (some issues here and their, but nothing really bad) @ least for Mpeg-2 i guess on pretty every GPU (Asic).

[mcr]

I've been having a curious issue with mp4 files where the audio is constantly ~200ms ahead of the video. Once the same video is put into a mkv container, audio/video will be in sync.

It's the same with the internal audio decoder or external ffdshow.

Other than remuxing all videos into mkv or using another player I haven't been able to find a solution.

[Dstruct]

Feature request:

Could you make MPC-HC to allow opening File Properties even if the file can't be played (because of missing splitter for example)? This way we could check the file details (Media Info)! Thanks!


https://sourceforge.net/apps/trac/mpc-hc/ticket/2062

[CruNcher]

Dstruct i try to understand this case but what for do you want that you can still multitasking wise use explorer right click to check the file it would though make sense in the playlist if you meant that so if it errors out on the file you check the properties right via the playlist link instead of needing to switch to the explorer that would be a usability improvement :)

[LigH]

I believe his point is:

1) Load media file in MPC-HC
2) MPC-HC can't play the file
3) Check the media file type without leaving MPC-HC