Media Player Classic Home Cinema (MPC-HC) - DXVA!

[sneaker_ger]

I have a problem with subtitles, some characters are not displayed correctly... Can anyone help me?
http://i42.tinypic.com/334kok1.jpg

Did you save the file using the wrong character encoding? Please upload your subtitle file.

[smok3]

japa: with mpc you would press o, then see the subtitle section and check if your font is related to your location, probably 'central european'.

http://somestuff.org/subtitlesMpc.png

[daMaster]

I've discovered a memory leak in the MPC Video Decoder v1.2.908.0 (DirectShow filter MPCVideoDec.ax) when using DXVA for H.264/AVC/VC1 with the following set up:
- OS: Vista
- GPU: ATI Radeon HD 3470, Catalyst 9.1 drivers
- DirectShow media player: MediaPortal
- Renderer: EVR

When I play a 720p/1080p H.264 video and then stop it, there's some residual memory that doesn't get cleaned up. After playing and stopping 12-15 such HD videos, that accumulation of residual memory gets up to 800-900 MB!

If I disable DXVA decoding in the MPC Video Decoder's property page, then this memory leak does not occur, so it would seem it only happens with hardware acceleration.

Here is a ProcessExplorer (http://download.sysinternals.com/Files/ProcessExplorer.zip) performance graph of the MediaPortal.exe process comparing the private bytes usage with the PowerDVD 8 H.264/AVC/VC1 decoder (LEFT) and the MPC Video Decoder (RIGHT). Each private bytes spike is when a video is playing and the following dip is when a video is stopped. As you can see, with the PowerDVD 8 decoder the private bytes usage returns pretty much to the amount it was before the video was played. On the right hand with MPC Video Decoder, the private bytes usage is slightly higher after each video is stopped than what it was before the video was started.

http://img21.imageshack.us/img21/4913/mpcmemoryleakhd0.png


Can other folks that use the MPC Video Decoder with DXVA test this out to help validate the issue? I am hoping users with different video cards (NVidia vs. ATI) and different DirectShow media players can test this out to see if they have the same issue.

I've already reported this issue on the MPC SourceForge open discussion forum: Memory leak in DirectShow filter MPCVideoDec (https://sourceforge.net/forum/forum.php?thread_id=2994581&forum_id=583789). I am really hoping the MPC devs will be able to fix this since MPC Video Decoder is my preferred decoder. It is more lenient than the PowerDVD 8 decoder and I find the picture quality is slightly better (smoother motion), but I can't use it with this memory leak since after a while I have to restart MediaPortal once it starts crashing.

[Amour]

Worked out that the best MPC-HC results are achieved by (for Radeon 4870x2 at 1920x1080x23.976):
* Disabling desktop composition (right click on mplayerc.exe and check "Disable desktop composition" in Compatibility tab).
* EVR Custom with: D3D Fullscreen[ ] Alternate VSync[X] Lock backbuffer[X] EVR Buffers 20
* Select accurate VSync in Renderer Settings

While disabling desktop composition is absolutly ugly, I'd like to know your advices for a "best results" configuration using any non-problematic video card under Vista/Seven. Thanks

MPC-HC 989 32bit (from xvidvideo.ru):
http://netload.in/dateiMHY5LJKKvv/mpc-homecinema.989.7z.htm
Thanks. I hope http://www.xvidvideo.ru/ will be back soon.

I have a problem with subtitles, some characters are not displayed correctly... Can anyone help me?

Are you using Haali Media Splitter?
Because there is an issue related to subtitles encodings with Haali.

[ADude]

CoreAVC 1.9.0 distribution includes new release of Haali Splitter dated 11/01/09, v 1.9.42.1

[Px]

CoreAVC 1.9.0 distribution includes new release of Haali Splitter dated 11/01/09, v 1.9.42.1
Also available on his website - http://haali.cs.msu.ru/mkv/

[whurlston]

Patch for the "MPC - MPA Decoder Filter" so that all property options can be seen when viewing the properties.

Index: MpaDecSettingsWnd.h
===================================================================
--- src/filters/transform/mpadecfilter/MpaDecSettingsWnd.h (revision 991)
+++ src/filters/transform/mpadecfilter/MpaDecSettingsWnd.h (working copy)
@@ -80,7 +80,7 @@
LPCTSTR GetDolbyMode (DolbyDigitalMode ddmode);

static LPCTSTR GetWindowTitle() {return _T("Settings");}
- static CSize GetWindowSize() {return CSize(320, 240);}
+ static CSize GetWindowSize() {return CSize(320, 320);}

DECLARE_MESSAGE_MAP()
};
\ No newline at end of file

[daMaster]

I've discovered a memory leak in the MPC Video Decoder v1.2.908.0 (DirectShow filter MPCVideoDec.ax) when using DXVA for H.264/AVC/VC1 with the following set up:
- OS: Vista
- GPU: ATI Radeon HD 3470, Catalyst 9.1 drivers
- DirectShow media player: MediaPortal
- Renderer: EVR

When I play a 720p/1080p H.264 video and then stop it, there's some residual memory that doesn't get cleaned up. After playing and stopping 12-15 such HD videos, that accumulation of residual memory gets up to 800-900 MB!

If I disable DXVA decoding in the MPC Video Decoder's property page, then this memory leak does not occur, so it would seem it only happens with hardware acceleration.

Here is a ProcessExplorer (http://download.sysinternals.com/Files/ProcessExplorer.zip) performance graph of the MediaPortal.exe process comparing the private bytes usage with the PowerDVD 8 H.264/AVC/VC1 decoder (LEFT) and the MPC Video Decoder (RIGHT). Each private bytes spike is when a video is playing and the following dip is when a video is stopped. As you can see, with the PowerDVD 8 decoder the private bytes usage returns pretty much to the amount it was before the video was played. On the right hand with MPC Video Decoder, the private bytes usage is slightly higher after each video is stopped than what it was before the video was started.

http://img21.imageshack.us/img21/4913/mpcmemoryleakhd0.png


Can other folks that use the MPC Video Decoder with DXVA test this out to help validate the issue? I am hoping users with different video cards (NVidia vs. ATI) and different DirectShow media players can test this out to see if they have the same issue.

I've already reported this issue on the MPC SourceForge open discussion forum: Memory leak in DirectShow filter MPCVideoDec (https://sourceforge.net/forum/forum.php?thread_id=2994581&forum_id=583789). I am really hoping the MPC devs will be able to fix this since MPC Video Decoder is my preferred decoder. It is more lenient than the PowerDVD 8 decoder and I find the picture quality is slightly better (smoother motion), but I can't use it with this memory leak since after a while I have to restart MediaPortal once it starts crashing.

So I also managed to reproduce this in mplayerc.exe. I set it up to use MPC Video Decoder as an external DirectShow filter and just kept playing and re-opening the same 1080p MKV file.

Here is the ProcessExplorer performance graph showing the private bytes usage of mplayerc.exe:

http://img11.imageshack.us/img11/128/croppercapture22da1.png

[japa]

Did you save the file using the wrong character encoding? Please upload your subtitle file.

Not sure what u mean exactly. I just download subs from internet and they display correctly in other programs and using filters like ffdshow or vobsub just not with MPCHC built in subtitle support. Anyway here is the subtitle file http://www.box.net/shared/g0hhmz62nd.


japa: with mpc you would press o, then see the subtitle section and check if your font is related to your location, probably 'central european'.

It is set as central european just like on your screenshot.


Are you using Haali Media Splitter?
Because there is an issue related to subtitles encodings with Haali.

No, I dont have it installed so i guess its using the internal Matroska splitter?

[Casimir666]

Patch for the "MPC - MPA Decoder Filter" so that all property options can be seen when viewing the properties.

Index: MpaDecSettingsWnd.h
===================================================================
--- src/filters/transform/mpadecfilter/MpaDecSettingsWnd.h (revision 991)
+++ src/filters/transform/mpadecfilter/MpaDecSettingsWnd.h (working copy)
@@ -80,7 +80,7 @@
LPCTSTR GetDolbyMode (DolbyDigitalMode ddmode);

static LPCTSTR GetWindowTitle() {return _T("Settings");}
- static CSize GetWindowSize() {return CSize(320, 240);}
+ static CSize GetWindowSize() {return CSize(320, 320);}

DECLARE_MESSAGE_MAP()
};
\ No newline at end of file


Commited

[whurlston]

Commited

Thanks Casimir666.

[THX-UltraII]

Casimir, any idea when you will release a new build after the 29th nov08 one?

[daMaster]

Casimir, any comments regarding the memory leak I reported above? Do you think this could be bug #1962448 cropping back up?

Thanks

[Dibbler]

Hello

Just to confirm the findings of damaster...

Running Vista 32 (SP1) and using a NVidia 9400 IGP whilst using MPCVideoDec DirectShow filter to decode a 1080p mkv file I find the following memory retention problem arises...

http://www.freeimagehosting.net/uploads/th.51f8a59c7d.jpg (http://www.freeimagehosting.net/image.php?51f8a59c7d.jpg)

as you can note the retention of the memory increase after the file is played back and then replayed again.

Using the PowerDVD 8 filter I get the following...

http://www.freeimagehosting.net/uploads/th.926834f4ca.jpg (http://www.freeimagehosting.net/image.php?926834f4ca.jpg)

...the memory retention does not happen and the usage remains constant regardless of how often the file is played.

The above is repeatable each and every time when using the noted filters.

[sneaker_ger]

Not sure what u mean exactly. I just download subs from internet and they display correctly in other programs and using filters like ffdshow or vobsub just not with MPCHC built in subtitle support. Anyway here is the subtitle file http://www.box.net/shared/g0hhmz62nd.




It is set as central european just like on your screenshot.



No, I dont have it installed so i guess its using the internal Matroska splitter?

Make sure you have set the following option accordingly:
http://www.abload.de/img/mpcaec1.png

[japa]

Make sure you have set the following option accordingly:

Yep, it is set correctly, I also tried all the other options none helped. Funny thing is that it works in old MPC, but not here in MPCHC.

I think something is wrong with Unicode support because strangely if I open the subtitle file in notepad and save as Unicode instead ANSI it displays properly here (MPCHC), but not in other programs. :confused:

P.S. Sorry for my bad English, I can send pictures if u don't understand me.

[sneaker_ger]

Yep, it is set correctly, I also tried all the other options none helped. Funny thing is that it works in old MPC, but not here in MPCHC.

I think something is wrong with Unicode support because strangely if I open the subtitle file in notepad and save as Unicode instead ANSI it displays properly here (MPCHC), but not in other programs. :confused:

P.S. Sorry for my bad English, I can send pictures if u don't understand me.

I've tested your file here (Windows XP and MPC-HC 989 32Bit) and it displays the same way as your screenshot of KMPLayer when I set the option above to "EASTEUROPE". :confused:
I've got to pass on this one ...

[Rectal Prolapse]

Having an issue with the Beliyaal versions of MPC-HC (it might affect regular MPC-HC too):

VMR9 procamp controls are not present when I go into the VMR9 filter page - they aren't there. Even enabling the procamp shader doesn't make it work. Also, adjusting the settings in the MPC-HC Options page has no effect.

Any ideas? Thanks! (This is with a default NVIDIA 182.05 driver install - so the video image settings are set to application controlled in the NV control panel).

[stax76]

I noticed it's not possible to assign different commands to the same key, enabling this would for instance allow to use the arrow keys for DVD menu navigation and while playback to jump for instance.

[Px]

About "Private bytes" - http://blogs.technet.com/markrussinovich/archive/2008/11/17/3155406.aspx

[daMaster]

About "Private bytes" - http://blogs.technet.com/markrussinovich/archive/2008/11/17/3155406.aspx

How does this explain the memory leak? And why would the behavior be different in DXVA mode vs. software mode?

[Px]

How does this explain the memory leak?
Read the article carefully, this can be not a real leak ^)

[daMaster]

Read the article carefully, this can be not a real leak ^)

I did read the article and I already clearly understand memory usage (I'm a software engineer as well).

This is indeed a memory leak if I've ever seen one. With every invocation and usage of the MPC Video Decoder in DXVA mode to play a video it uses up a certain amount of memory, let's say X bytes. When the video is stopped, it should release those X bytes that were previously allocated, however it does not. It only releases Y bytes where Y < X. As a result, you have a leak of X - Y bytes. As one continues to play N movies, that leak grows, such that the process now uses N * (X - Y) bytes which are wasted because they were never properly de-allocated. The problem here is that the value of (X - Y) is rather large and so after playing about 16 1080p videos in DXVA mode, N * (X - Y) reaches nearly 1GB! How you can say this is not a memory leak is beyond me.

Note that in software decoding mode this is not a problem at all and (X - Y) is so tiny it is negligible or Y = ~X.

If you understand mem allocation, then I don't need to explain to you that somewhere in the code some memory is not being de-allocated correctly in DXVA mode or some object is not being de-referenced or cleaned up.

[shaolin95]

Guys I got a quick Q.
What is the recommended DTS and DTS-HD (core I know) choice....libdts or libavcodec?

[Aleksoid1978]

Guys I got a quick Q.
What is the recommended DTS and DTS-HD (core I know) choice....libdts or libavcodec?

libavcodec.

[Mercury_22]

Since http://xvidvideo.ru/ it's still down can somebody compile the latest SVN, x64 too PLEASE ? :helpful:

@ Beliyaal
Any news about VC-1 Fix or your MPC-HC version ? :confused:

[THX-UltraII]

Since http://xvidvideo.ru/ it's still down can somebody compile the latest SVN, x64 too PLEASE ? :helpful:

@ Beliyaal
Any news about VC-1 Fix or your MPC-HC version ? :confused:

2x +1 :)

[Beliyaal]

Since http://xvidvideo.ru/ it's still down can somebody compile the latest SVN, x64 too PLEASE ? :helpful:

@ Beliyaal
Any news about VC-1 Fix or your MPC-HC version ? :confused:

Are you talking about submitting VC-1 fix to SVN? I haven't really fixed the VC-1 issue, rather worked around it by correcting incorrect frame times. This is an integral part of my new renderer code and I can't submit it until I can submit the whole patch.

I haven't been able to compile the x64 build either yet and rather put my time into something else.

[Beliyaal]

Having an issue with the Beliyaal versions of MPC-HC (it might affect regular MPC-HC too):

VMR9 procamp controls are not present when I go into the VMR9 filter page - they aren't there. Even enabling the procamp shader doesn't make it work. Also, adjusting the settings in the MPC-HC Options page has no effect.

Any ideas? Thanks! (This is with a default NVIDIA 182.05 driver install - so the video image settings are set to application controlled in the NV control panel).

Try installing this:
http://www.microsoft.com/downloads/details.aspx?familyid=886ACB56-C91A-4A8E-8BB8-9F20F1244A8E&displaylang=en

[Beliyaal]

Any ideas? Problem doesn't occour with first testbuild you made (the one that had lots of tearing).

I'll be working on judder issues this weekend, hopefully the next build will be better.

[Mercury_22]

Are you talking about submitting VC-1 fix to SVN? I haven't really fixed the VC-1 issue, rather worked around it by correcting incorrect frame times. This is an integral part of my new renderer code and I can't submit it until I can submit the whole patch.

I haven't been able to compile the x64 build either yet and rather put my time into something else.

Abot: VC-1 I was afraid of that, anyway :thanks: for your effort !

It's there any chance for you to update your version with latest updates from the SVN ? PLEASE !:helpful:

[menlvd]

Abot: VC-1 I was afraid of that, anyway :thanks: for your effort !

It's there any chance for you to update your version with latest updates from the SVN ? PLEASE !:helpful:

+1 i'll forgot dl x64 ver before install W7_x64, and thats very bad :(

[Beliyaal]

New version available at link in signature:

* Updated to latest SVN.
* Animated subtitles now works with buffering.

[BatKnight]

New version available at link in signature:

* Updated to latest SVN.
* Animated subtitles now works with buffering.
In this 944 Ver9 version I get a lot of jitter/skipping after a few seconds of start playing. This doesn't happen on your 988 ver8 version.

I also listen to a lot of HDD reading when playing the file (could be the cause of the jitter). When playing the same file with 988 ver8 I can hardly hear it and the video plays smooth, almost 0 jitter.

Bat

[Kado]

New version available at link in signature:

* Updated to latest SVN.
* Animated subtitles now works with buffering.

Thank you very much for that added feature! Now I get no dropped frames and proper ASS/SSA subtitle effects!

I've found some adverse effects with this build if using the new build with buffering, some subtitles don't show up. I'll report properly tomorrow.

[thuan]

@Beliyaal:

Thank you for your new build, finally animated buffered subtitles. I have some troubles with it though:

- Karaoke feels not as smooth as without buffering (this is subjective).
- Have problem with this karaoke ass (http://www.mediafire.com/download.php?jlyetejadyw), flashing sub at around 2 mins.

Other than that I have generally random stutters that has been happening to me from build1, but you said that your renderer patch does not work well with nvidia hardware yet so I haven't posted any bug report. Do u need the graph then?

I have a Core 2 Duo E4300 @1.8GHz, 945 chipset, 8600GT GFX card with 182.05 driver, Vista x64 SP1 up to date. MPC-HC Beliyaal b9, EVR Custom, 5 frame buffer.

EDIT: The stutters seem to happen when in high motion scenes and/or with sub in any configuration: with/without alternate Vsync combined with/without Accurate Vsync or without activating any option that will activate your new renderer features.

[STaRGaZeR]

Thanks Beliyaal! I don't have any problems so far except the subtitle desync I've reported in previous posts that happens in all your builds. This could also benefit the VSFilter guys.

Thank you for your new build, finally animated buffered subtitles. I have some troubles with it though:

- Karaoke feels not as smooth as without buffering (this is subjective).
- Have problem with this karaoke ass (http://www.mediafire.com/download.php?jlyetejadyw), flashing sub at around 2 mins.

- It looks exactly the same for me, the transitions and fades have the exact same duration in Beliyaal's build and SVN builds.
- Are you sure those effects are not supposed to be like that? Looking at your script they look right.

[daMaster]

New version available at link in signature:

* Updated to latest SVN.
* Animated subtitles now works with buffering.

Hi Beliyaal, any chance to look into the memory leak problem?

Thanks

[thuan]

- It looks exactly the same for me, the transitions and fades have the exact same duration in Beliyaal's build and SVN builds.
- Are you sure those effects are not supposed to be like that? Looking at your script they look right.

The duration for transition and fads are indeed the same but the sub flashes with Beliyaal's build with bufferred animated sub. To be exact, it starts from "hiru wo" at 2:01 to "sora wo" at 2:20.

@daMaster: it does look that way to me, too from as long as I can remember with any DXVA decoder not just MPC DXVA one including CoreAVC with CUDA decoder used in vanilla MPC by clsid. So It might not be MPC-HC fault.

[Beliyaal]

The duration for transition and fads are indeed the same but the sub flashes with Beliyaal's build with bufferred animated sub. To be exact, it starts from "hiru wo" at 2:01 to "sora wo" at 2:20.

It might be that your computer cannot keep up with the subs. Try changing the buffering to 10 instead of 5 and if that doesn't work try changing the resolution to a lower one.

Also the thread that renders subtitles is of low priority, maybe I should change it to a higher priority. Next build will have above normal instead of low priority.

Also I think I need to add an option for supporting animated subtitles so those with low specs can turn it off. Edit: Or maybe just display the last available subtitle when it can't keep up.

[ikarad]

Where can we download beta version of MPC-HC because xvidvideo.ru is down?

[Kado]

@Ikarad
Here. (http://forum.doom9.org/showpost.php?p=1238556&postcount=5934)

@Beliyaal
Try this subtitles (http://www.mediafire.com/download.php?zgzydrzmv4d).
Its right at the start. Using SNV, patch 8 or earlier with buffering 0 the mpc loads 1 core away and with buffering they play without effects (normal cpu load).
With patch 9 , 0 buffering makes the same as svn but using buffering they just don't show up (1 core loaded away) unless you pause the video.

@thuan
I can't replicate your problem.

[thuan]

@Beliyaal: You're right about subtitle flashing, my computer indeed can't keep up. So what about the micro stutters then? Is it because of not enough CPU power, too?
http://xs136.xs.to/xs136/09070/untitled567.jpg.xs.jpg (http://xs.to/xs.php?h=xs136&d=09070&f=untitled567.jpg)

EDIT: @Kado: yeah, you have a monstrous PC compared to mine IIRC. Do you have the stutters then? You're also on nvidia right, 9800GTX IIRC?

[TherapyClown]

@Beliyaal:
can you please upload your files to a different host, or someone here can supply a mirror?
I'm facing difficulties downloading your version.

Thanks...

[Beliyaal]

@Beliyaal: You're right about subtitle flashing, my computer indeed can't keep up. So what about the micro stutters then? Is it because of not enough CPU power, too?
http://xs136.xs.to/xs136/09070/untitled567.jpg.xs.jpg (http://xs.to/xs.php?h=xs136&d=09070&f=untitled567.jpg)

EDIT: @Kado: yeah, you have a monstrous PC compared to mine IIRC. Do you have the stutters then? You're also on nvidia right, 9800GTX IIRC?

Does the stuttering disappear if you enable Accurate VSync?

[thuan]

EDIT: The stutters seem to happen when in high motion scenes and/or with sub in any configuration: with/without alternate Vsync combined with/without Accurate Vsync or without activating any option that will activate your new renderer features.

As I said before, in any configuration.

[ikarad]

@Ikarad
Here. (http://forum.doom9.org/showpost.php?p=1238556&postcount=5934)

@Beliyaal
Try this subtitles (http://www.mediafire.com/download.php?zgzydrzmv4d).
Its right at the start. Using SNV, patch 8 or earlier with buffering 0 the mpc loads 1 core away and with buffering they play without effects (normal cpu load).
With patch 9 , 0 buffering makes the same as svn but using buffering they just don't show up (1 core loaded away) unless you pause the video.

@thuan
I can't replicate your problem.

thank you but I speak about standard beta version of MPC-HC and not beliyaal beta version.

[Beliyaal]

As I said before, in any configuration.

Sorry missed that. If you pause and unpause until the audio sync line is between the upper and lower bounds of the vsync jitter, does it play correctly?

[thuan]

Yes, if I pause then play or do a seek, it plays correctly again.

EDIT: You are right that it happens when the audio sync line is out of vsync jitter bounds.

[clsid]

The speedup function in MPC-HC does not work very well. Can anyone confirm that? All I gets is stutters and an instable frame-rate. It works better with the old MPC.