Media Player Classic Home Cinema (MPC-HC) - DXVA!

[Snowknight26]

Using that build still shows corruption:
http://i27.tinypic.com/bfowbc.png

Seems to happen after every I frame, but I can't say for sure.

[Jong]

Using that build still shows corruption:
http://i27.tinypic.com/bfowbc.pngYeah that's the corruption I see with your sample too.

[Jong]

I only see wrong frame order in Hoborg sample. Could you try with this build to see if it change something :

http://www.zshare.net/download/630697539d1a1dbe/, .Sorry, nothing has changed.

[Pellaeon]

New CAT 9.7 completely broke DXVA playback: MPC crashes when trying to open video file encoded in VC1 or H.264.

Radeon 4850 + Vista x64 + CAT 9.7

[Snowknight26]

New CAT 9.7 completely broke DXVA playback: MPC crashes when trying to open video file encoded in VC1 or H.264.

Radeon 4850 + Vista x64 + CAT 9.7

Working here, same specs.

[Pellaeon]

Just discovered reason: disabling 10bit RGB output solved problem.

[hoborg]

I can confirm, that:
- i have wrong frame order and blockong on "mpc-hc.dxva.corruption.sample.mkv" sample - this sample have blocking problem even with Cyberlink PDVD8 PDVD8 h.264 decoder
- i have wrong frame order but no blocking on "sample-001.mkv" sample - working fine with PDVD8 h.264 decoder

I tryed "mplayerc_test.rar" but no change.

Updated to cat. 9.7 - no change

Casimir666, can i ask what GPU and OS do you have?

[Xorp]

Might want to improve DTS Express detection, here an example: http://www.sendspace.com/file/keswl8

MPC-HC 1.2.1179 says its "Secondary DTS HD High Resolution Audio, 48.0kHz, 3chn, 576kbps" when it's actually "DTS Express, 2.0 channels, 16 bits, 192kbps, 48khz" (eac3to). DTS Express is a different format from DTS and DTS-HD.

[BatKnight]

Since xvidvideo.ru is not going to be updated until 23 August, where can we get the latest compiled MPC-HC releases?

Bat

[Spec-Chum]

I don't have my own web space but I'm more than happy to build a normal version (I use a custom build for core2) and upload to a public site. IA32 and X64 builds are fine.

Sendspace seems OK, anyone know a better one (must be free).

cheers

[St Devious]

I don't have my own web space but I'm more than happy to build a normal version (I use a custom build for core2) and upload to a public site. IA32 and X64 builds are fine.

Sendspace seems OK, anyone know a better one (must be free).



mediafire, sendspace limits download speed.

[Spec-Chum]

mediafire, sendspace limits download speed.

mediafire it is then, just building 1182 now...

Having an issue with x64 builds, so will just be x86 for now. I'll fix it tomorrow...

edit: OK fixed. Devs, you need to remove d2vsource from mplayerc Project Dependencies on x64 build...

Links:
x64 (http://www.mediafire.com/?sharekey=f23b64e279fec79ea0f2f20c509059d9d8060856ca4d2a3a5be6ba49b5870170)
x86 (http://www.mediafire.com/?sharekey=f23b64e279fec79ea0f2f20c509059d944fe6769e7319381c95965eaa7bc68bc)

[Mangix]

i did something to my computer and now EVR custom refuses to work. everytime i set it to EVR custom, MPC exits randomly...

regular EVR and all the other renderers work fine. I think MPC actually crashes since Haali's icon is still in the taskbar after MPC exits...

using Windows XP btw.

edit: tested with builds 1179 and 1180. not sure when it started since i use Haali mostly.

edit2: uninstalled and reinstalled the framework. same result.

[St Devious]

mediafire it is then, just building 1182 now...

Having an issue with x64 builds, so will just be x86 for now. I'll fix it tomorrow...

edit: OK fixed. Devs, you need to remove d2vsource from mplayerc Project Dependencies on x64 build...

Links:
x64 (http://www.mediafire.com/?sharekey=f23b64e279fec79ea0f2f20c509059d9d8060856ca4d2a3a5be6ba49b5870170)
x86 (http://www.mediafire.com/?sharekey=f23b64e279fec79ea0f2f20c509059d944fe6769e7319381c95965eaa7bc68bc)

so are these builds any different from those on xvidvid.ru ?

[bobdynlan]

in future version i would like to see a CLI Switch for loading a "Pan&Scan Presets" because when i watch 2.35:1/2.40:1 movies i move the image to the top and have my masking at the bottom of my 16:9 screen.
or am i asking for too much? (pretty please :) )
Second that.
I like what you can do with the shaders, you can have two different presets using combine, and have two keyboard shorcuts to toggle them, the last state is remembered after closing.
Would be nice to have the option to setup custom keyboard shortcuts for Pan&Scan individual presets, and have the last state remembered, too.
And speaking of remembering the last state, how about making that After Playback defaults to Exit? Would help alot as the current Do Nothing option prevents stand-by most of the time (Always On Top does not matter).
Really like the minimalistic looks, but it needs some improvement, from those nine buttons (and two sliders), three of them are unused most of the time or generating issues (Decrease speed, Increase speed, Step). How about having some Pan&Scan, Shaders, Stream Switcher etc.? Well, I guess the option to have user skins is not a priority right now.
Do the shaders work in latest x64 version now?

[neoufo51]

Is it just me or are iPhone 3GS videos not working well with MPC-HC?

Build 1179, Win7, Latest Nvidia drivers.

I'm seeing problems with every renderer, even with Quicktime installed.

1) System Default, VMR9, and Haali all play the video 90 degrees counterclockwise and with an incorrect 4:3 ratio.

2) EVR CP doesn't play AT ALL and says at the bottom that DXVA is running.

Here's a sample video from a friend's iPhone. Please confirm my findings.

http://www.mediafire.com/?djogghzjv1z

[s174955]

Hi, love the progress on MPC-HC!

Have a short question though about the current state of DXVA support with MPH-HC i.c.w. differerent GPU's
- ATI: support for H264 (not e.g. L5.1 though or too many ref frames) + VC1
- NVidia: support for H264 (also L5.1 and 16 ref frames), no VC1
- Intel: ? (if I'm corrent it is supported now, but i have no idea to what extend)

Note:
for Nvidia I mean the newer onces (i know that since somewhere around the new version of the 8800 GTS their cards support VC1, but it does not i.c.w. MPC-HC)?

Is this list correct? And what about Intel?

[Spec-Chum]

so are these builds any different from those on xvidvid.ru ?

Nope, well apart from I use GCC 4.3.3 and not 4.4.1 (although I'd be very surprised if that made a difference. I use a custom build myself (nothing major, just built specificly for Core2 arch) but these are built with all defaults.

Hope this helps :)

Spec

[tetsuo55]

Anyone with compiling capabilities,

Does MPC-HC still function(or even fully compile) if you compile with these settings:

x86: "/SAFESEH /O2 /GS /arch:SSE2 /EHa"
x64 AMD: "/favor:AMD64 /O2 /GS /EHa"
x64 INTEL: "/favor:INTEL64 /O2 /GS /EHa"
x64 universal(SLOW): "/favor:blend /O2 /GS /EHa"

[Casimir666]

@hoborg, @Jong
Your problem happen only with ATI board, and I find the issue for corruption at least. Hoborg I still have little trouble with your file, some of the frame are not display in correct order.

@Snowknight26
Your file didn't play on ATI board (test with Cyberlink + Microsoft Win7 decoder). No problem on my nVidia, maybe a problem with ATI driver?

@Trahald
Custom MMCO is now supported, and you file play fine

@The1n
Could you try again with new test build (if not ok would you post your screenshot on imageshark or something your previous attachement is still waiting validation)?

New test build with all this changes available from here : http://www.zshare.net/download/6313488079dc9738/

To all : I'm looking for H264 samples with long reference frames inside, ans if possible MMCO commands

[ar-jar]

Anyone with compiling capabilities,

Does MPC-HC still function(or even fully compile) if you compile with these settings:

x86: "/SAFESEH /O2 /GS /arch:SSE2 /EHa"
x64 AMD: "/favor:AMD64 /O2 /GS /EHa"
x64 INTEL: "/favor:INTEL64 /O2 /GS /EHa"
x64 universal(SLOW): "/favor:blend /O2 /GS /EHa"

This is what I get when plugging in the options from the first line (x86):

3>Linking...
3>dsutilRU.lib(a_yuv2rgb.obj) : error LNK2026: module unsafe for SAFESEH image.
3>dsutilRU.lib(convert_a.obj) : error LNK2026: module unsafe for SAFESEH image.
3>d2vsourceRU.lib(idctmmx.obj) : error LNK2026: module unsafe for SAFESEH image.
3>Mpeg2DecFilterRU.lib(motion_comp_mmx.obj) : error LNK2026: module unsafe for SAFESEH image.
3>Mpeg2DecFilterRU.lib(idct_mmx.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MpaDecFilterRU.lib(lpc_asm.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MpaDecFilterRU.lib(bitreader_asm.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MpaDecFilterRU.lib(cpu_asm.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MPCVideoDecRU.lib(CompilatorVersion.o) : error LNK2026: module unsafe for SAFESEH image.
3>MPCVideoDecRU.lib(mpc_helper.o) : error LNK2026: module unsafe for SAFESEH image.
3>MPCVideoDecRU.lib(parser.o) : error LNK2026: module unsafe for SAFESEH image.

... and so on with a whole bunch of other .o files in MPCVideoDecRU.lib.

Without the /SAFESEH option to the linker, everything seems to work ok.
-A

[gngn]

New test build with all this changes available from here : http://www.zshare.net/download/6313488079dc9738/


the problems with XP+nvidia+DXVA introduced in r1141 ( post #8320 (http://forum.doom9.org/showthread.php?p=1294591#post1294591)) are now fixed.
only that the max ReFrames for XP seems to be now 14. videos with ReFrames=15 or above wont play.

[The1n]

@The1n
Could you try again with new test build (if not ok would you post your screenshot on imageshark or something your previous attachement is still waiting validation)?

New test build with all this changes available from here : http://www.zshare.net/download/6313488079dc9738/

Hi Casimir666 , when trying out your latest test build it looked a little better but still error frames with original bluray films, here is a zshare link for you.

http://www.zshare.net/download/63146496f464ec2b/

The1n

[Casimir666]

@ Mercury
I fixed the True HD and LPCM mapping. The Eac3 is still 5.1 instead of 7.1 because ffmpeg return only 6 channels! Back and side surround channel are out on back.
Cannot fix the DTS, because it's decoded by libdts that didn't support 7.1.

I didn't understand for the AC3 sample : are you sure it's wrong? Can you try with original mpc because the original mapping is used in this case and i would be surprise if it's wrong. Your file is 5.1 and not 7.1?


@ All
I fixed other small issues on DXVA, and if no major bugs are detected this build will became next stable release :
http://www.zshare.net/download/6314672884c0d9d9/

[tetsuo55]

This is what I get when plugging in the options from the first line (x86):

3>Linking...
3>dsutilRU.lib(a_yuv2rgb.obj) : error LNK2026: module unsafe for SAFESEH image.
3>dsutilRU.lib(convert_a.obj) : error LNK2026: module unsafe for SAFESEH image.
3>d2vsourceRU.lib(idctmmx.obj) : error LNK2026: module unsafe for SAFESEH image.
3>Mpeg2DecFilterRU.lib(motion_comp_mmx.obj) : error LNK2026: module unsafe for SAFESEH image.
3>Mpeg2DecFilterRU.lib(idct_mmx.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MpaDecFilterRU.lib(lpc_asm.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MpaDecFilterRU.lib(bitreader_asm.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MpaDecFilterRU.lib(cpu_asm.obj) : error LNK2026: module unsafe for SAFESEH image.
3>MPCVideoDecRU.lib(CompilatorVersion.o) : error LNK2026: module unsafe for SAFESEH image.
3>MPCVideoDecRU.lib(mpc_helper.o) : error LNK2026: module unsafe for SAFESEH image.
3>MPCVideoDecRU.lib(parser.o) : error LNK2026: module unsafe for SAFESEH image.

... and so on with a whole bunch of other .o files in MPCVideoDecRU.lib.

Without the /SAFESEH option to the linker, everything seems to work ok.
-AThose command tell the compiler to : Prefer speed over size, and security over both.
Those erroring files need to be recompiled with this setting enabled using VS2008SP1

[hoborg]

@ All
I fixed other small issues on DXVA, and if no major bugs are detected this build will became next stable release :
http://www.zshare.net/download/6314672884c0d9d9/

Casimit, just tryed and bad news - no changes at all :( Still get wrong frames order on all h.264 MKV i have :/

[Mercury_22]

@ Mercury
I fixed the True HD and LPCM mapping. The Eac3 is still 5.1 instead of 7.1 because ffmpeg return only 6 channels! Back and side surround channel are out on back.
Cannot fix the DTS, because it's decoded by libdts that didn't support 7.1.

I didn't understand for the AC3 sample : are you sure it's wrong? Can you try with original mpc because the original mapping is used in this case and i would be surprise if it's wrong. Your file is 5.1 and not 7.1?


@ All
I fixed other small issues on DXVA, and if no major bugs are detected this build will became next stable release :
http://www.zshare.net/download/6314672884c0d9d9/

Yes I'm sure about AC3 ! Also MPC 6.4.9.0 (original mpc) has the same WRONG mapping ! If it helps FFDShow has the correct mapping for Ac3 (Dolby Digital)
Yes the TEST file is 5.1 ! AFAIK AC3 (Dolby Digital) has MAX 6 channels http://en.wikipedia.org/wiki/Ac3 or http://www.dolby.com/consumer/technology/dolby_digital.html

Ac3 (Dolby Digital) wrong mapped channels:
1 - REAR RIGHT wrong mapped to FRONT RIGHT
2 - REAR LEFT wrong mapped to FRONT LEFT
= No rear channels!

Test 5.1 AC3 (Dolby Digital) (http://www.lynnepublishing.com/surround/www_lynnemusic_com_surround_test.ac3)


I can confirm TrueHD and LPCM (and E-AC3 since "ffmpeg return only 6 channels" ) now are working correct ! :thanks:

About DTS, please can't you at least make it like E-AC3 : "Back and side surround channels are out on back." ?

DTS (-HD HR MA) wrong mapped channels:
1 - SIDE RIGHT wrong mapped to FRONT RIGHT
2 - REAR RIGHT wrong mapped to FRONT RIGHT
3 - SIDE LEFT wrong mapped to FRONT LEFT
4 - REAR LEFT wrong mapped to FRONT LEFT

Test 7.1 DTS-HD HR (http://sharebee.com/abf92989)

P.S. PLEASE can you compile a x64 version too ?

[73ChargerFan]

Sorry for OT, but my HTPC is getting old, and I'm tired of tearing with my BD rips. This is the only application I run on it, except for Opera.

Current: AMD 4600X2, 2gb DDR memory, ATI 4850, Windows XP MCE 2005.

I purchased a Athlon 2 X2 250 to upgrade, with 4gb DDR2, re-use my ATI 4850, Windows 7 (x86 or 64). $185.

Will this be blazing fast, enough that I can ignore DXVA? Or should I return it and upgrade to the AMD max, a Phenom 945? This would be $300. Money is a consideration...

[_xxl]

Those command tell the compiler to : Prefer speed over size, and security over both.
Those erroring files need to be recompiled with this setting enabled using VS2008SP1
What part of mpc-hc could benefit from those compiler optimizations?

[tetsuo55]

What part of mpc-hc could benefit from those compiler optimizations?Overall optimization could mean the difference between jittering and stable playback on slower systems.

some parts are very system intensive like the internal subtitle renderer, this can use any optimization it can get.

Mostly it's for security though, to prevent any exploits from things like malformed avi/wmv/mkv files or http links.

[_xxl]

I get some crashes with internal avi spitter and xvid avi files. If avi spitter is disabled no crash. This is happening also with Haali's avi splitter, but not with MS one.

[_xxl]

Overall optimization could mean the difference between jittering and stable playback on slower systems.
Maybe I should add a vc project file that uses all optimizations?

[tetsuo55]

Yes the project file should be updated, but only after we confirm no new problems arise, and any new warnings have to be fixed too.

these warnings point to possible exploitable security problems.

Also if you use the ARCH:SSE2 by default anyone with a CPU that does not have SSE2 will not be able to use MPC-HC

[Casimir666]

Maybe I should add a vc project file that uses all optimizations?

Be careful playing with optimisation, it's really hard to know if it improve things or not and could have side effect. I prefer not to commit theses tests in SVN

[_xxl]

Be careful playing with optimization, it's really hard to know if it improve things or not and could have side effect. I prefer not to commit theses tests in SVN
True, stability is more important than speed.

[thuan]

@73ChargerFan:
If you don't want to rely on DXVA then that CPU will not be enough in some cases, as mine, a Xeon E3110 (equal the Core 2 Duo E8400), isn't enough in some cases either, with libavcodec from ffdshow or MPC-HC internal. I mostly use DXVA now with my nvidia card (9500GT), and it works nearly perfect with MPC-HC. DXVA from ATI card I owned previously (HD2400XT) was really erratic, not to mention the chroma upsampling problem. I wonder if the latter problem is fixed now?

[Snowknight26]

r1179 doesn't downmix AC3 or DTS anymore. Even though I have both filters set to decode to stereo, the audio renderer shows 6 channels.

And on a separate note, I've noticed that several Blu-rays of mine show subtitles only in the MPEG PS splitter but not in the Subtitles menu, so subsequently they can't be enabled.

Samples on request.

[73ChargerFan]

Thanks thuan, hc & tetsuo55 - I decided to exchange the Athlon II X2 250 for a Phenom II X3 720 BE.

[tetsuo55]

Be careful playing with optimisation, it's really hard to know if it improve things or not and could have side effect. I prefer not to commit theses tests in SVNTrue, stability is more important than speed.Yes we have to be absolutely sure first.

Please not that:
/arch:[SSE|SSE2] Without this command SSE and other features of chips supporting this are completely unused (unless hand coded into the source). Also for the X64 builds the SSE2 option is enabled by default. (so we can be relatively sure that this works)

/favor (Optimize for x64) This option should provide an increase in speed by dropping backwards compatibility with x86 (this should have been enabled by default :rolleyes:)

/GS This is purely a security feature, buffer protection, it can be and should be enabled by default.

/EHa this is a security feature too, exeption handling, this actually changes code and could lead to breaks.

/O2, enabled by default on release builds, slightly different meanings between x86 and x64, could break things.

/SAFESEH security feature that is enabled by default on x64

As you can see, almost all of it should be safe, and a lot of it has been tested on the x64 builds (or has been causing some of the x64 build bugs!)

[Spec-Chum]

Revision: 1188

Fixed : support for custom mmco, improved ATI multislice (this rev is broken on ATI+XP)

Links:
x64 (http://www.mediafire.com/?jijol2dykan)
x86 (http://www.mediafire.com/?adzgtjywknz)

[Casimir666]

Revision: 1188

Fixed : support for custom mmco, improved ATI multislice (this rev is broken on ATI+XP)

Links:
x64 (http://www.mediafire.com/?jijol2dykan)
x86 (http://www.mediafire.com/?adzgtjywknz)

It's better to use those one that fix the invalid frame order for ATI board on Windows XP :

x86 (http://www.zshare.net/download/631737834c0d90ae/)
x64 (http://www.zshare.net/download/63173825255460e2/)

[Spec-Chum]

It's better to use those one that fix the invalid frame order for ATI board on Windows XP :

x86 (http://www.zshare.net/download/631737834c0d90ae/)
x64 (http://www.zshare.net/download/63173825255460e2/)

d'oh *shakes head*

[_xxl]

$ make 64BIT=yes
x86_64-pc-mingw32-gcc -c -I. -I.. -Ilibavcodec -Ilibavutil -I../codecs -I../imgFilters -I../../../../zlib -I../../../../libpng -DHAVE_AV_CONFIG_H -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 -std=gnu99 -DARCH_X86_64 -DWIN64 -D_WIN64 -mno-cygwin -mdll -mthreads -pipe -DNDEBUG -UDEBUG -O2 -m64 -fno-leading-underscore -fno-common -fno-tree-vectorize -fomit-frame-pointer -fno-math-errno -MMD -o libavcodec/aac_ac3_parser.o libavcodec/aac_ac3_parser.c
make: x86_64-pc-mingw32-gcc: Command not found
make: *** [libavcodec/aac_ac3_parser.o] Error 127

Anybody knows the latest working MinGW64 for Win32? 21.07.2009 seems to be broken.

[shambles]

where can i get recent standalone filters? (xvidvideo.ru is down)

[Casimir666]

Anybody knows the latest working MinGW64 for Win32? 21.07.2009 seems to be broken.

I have same problem, but seems they rename the compiler name : now it's x86_64-w64-mingw32-gcc instead of x86_64-pc-mingw32-gcc no?

[Aleksoid1978]

Anybody knows the latest working MinGW64 for Win32? 21.07.2009 seems to be broken.

Set %PATH% to x86_64-pc-mingw32-gcc.exe, usuali it \mingw\bin

[The1n]

@Casimir666

Could you use the sample file i uploaded ?

The1n

[Casimir666]

@Casimir666

Could you use the sample file i uploaded ?

The1n

Yes i have it, thanks

[STaRGaZeR]

Casimir, it's possible to speed up seeking when using DXVA? Seeking to B-frames can be a royal pain sometimes.

[Mercury_22]

I've found the problem for the wrong mapped channels for Ac3 (Dolby Digital) and DTS !
It's a design problem ! MPC-HC's internal filters does NOT have 7.1 channel setting or "Same as input" (like FFDShow) or the option to disable internal mixer / matrix ! max setting it's "3 Front + 2 Rear" and although this gets ignored for LPCM, DolbyTrueHD and E-AC3 (Dolby Digital Plus) for DTS and AC3 it's NOT ignored!

So even if you have 7.1 speakers you need to set internal filters to 5.1 aka "3 Front + 2 Rear" for ac3 and DTS to work

I think we really need to have 7.1 added and like in FFDShow the options "Same as input" and to be able to disable internal mixer / matrix