Media Player Classic Home Cinema (MPC-HC) - DXVA!

[donaldtone]

Since the new suggestion link does not work, I have to post here.

The free container OGV includes Theora video, Vorbis audio and Kate subtitle.

Is there any plan to support this format, especially Kate subtitle.

mpc-hc with haali can decode theora video and vorbis audio, but it can not render Kate subtitle.
Right now the only software player which supports Kate subtitle is VLC (1.0.3 version).

[Gamezcdr]

Practical question: how to resume a DVD ???

[bur]

Regarding the Goto command not working, should I file a bug or is it a known issue?

[pirlouy]

In any case its clear that we desperately need someone to join mpc-hc and work on the subtitle renderer.
But... Displaying subtitles... I thought it was something done by video renderer.
Is subtitle renderer another renderer or it just works thanks to renderer job ?

In fact, you mean MPC-HC needs someone to create subtitle support for EVR renderer, no ?

[clsid]

The video renderer only does the last step in the whole process: adding a subtitle image on top of the video.

The conversion from text to an image, using the right font, size and color, is done by the subtitle renderer. And that is just the 'easy' stuff. There is animation, positioning, line breaking, and other complex stuff to take care of as well.

But all that code is already in place. The problem is that it is inefficient and often does unnecessary calculations.

[tetsuo55]

Yes clsid is right

On top of that there are some behavioural differences between internal/external renderer and some missing features here in there.

Mostly its the performance that needs some help

[boiled_sugar]

I'm sorry. The corruption turned out to be x264 bug. Now it's fixed.

Hi

I tried weightp, the new feature of x264, but MPC-HC can't decode the encoded video correctly with DXVA. ffdshow decodes the video correctly.

ffdshow
http://forum.doom9.org/attachment.php?attachmentid=10485&stc=1&d=1258197505
PNG (http://www.mediafire.com/imageview.php?quickkey=ccymjwnmgrt)

DXVA
http://forum.doom9.org/attachment.php?attachmentid=10486&stc=1&d=1258197537
PNG (http://www.mediafire.com/imageview.php?quickkey=qnymytm2yoi)

My environment
* Windows XP SP3
* MPC-HC r1335
* Renderer is VMR9 Renderless
* Radeon HD 4670 + Catalyst 9.10

the encoded video and the source (http://www.mediafire.com/?ghgohoywhdx)
the encoded video only (http://www.mediafire.com/?ymrogz3laq2)

[avivahl]

boiled_sugar: Your sample actually works fine here. Both the internal H.264 DXVA decoder and Windows 7's built-in H.264 DXVA decoder show the video fine.
EVR-CP.
Windows 7.
Haali Media Splitter OR Windows 7's built-in mp4 splitter.
Geforce 8800GT (ForceWare 190.62).

[Snowknight26]

Might be an ATI only issue. I get corruption in that sample but not in a dozen encodes that I've personally done.

[tetsuo55]

i tested several samples succesfully but boiled_sugar's breaks for me too when the cat scene begins

i used 1337 on win7 x64

[Egh]

Hi

I tried weightp, the new feature of x264, but MPC-HC can't decode the encoded video correctly with DXVA. ffdshow decodes the video correctly.


Works here on 1337 build and XP x64. Obviously on VMR9 only, as mpchc doesn't really support EVR on my system....

BTW guys, congratulations on releasing a leet build 1337 :)

[Px]

Ok, got some free time to make bugreport
MPC HC doesn't show subtitles on some BD (Ip Man in my case)
File info
General
ID : 1
Complete name : H:\New\Ip.Man.2008.1080p.H264.Remux\BDMV\STREAM\00001.m2ts
Format : BDAV
Format/Info : Blu-ray Video
File size : 22.0 GiB
Duration : 1h 46mn
Overall bit rate : 29.6 Mbps
Maximum Overall bit rate : 35.5 Mbps

Video
ID : 4113 (0x1011)
Menu ID : 1 (0x1)
Format : AVC
Format/Info : Advanced Video Codec
Format profile : High@L4.1
Format settings, CABAC : Yes
Format settings, ReFrames : 4 frames
Duration : 1h 46mn
Width : 1 920 pixels
Height : 1 080 pixels
Display aspect ratio : 16:9
Frame rate : 24.000 fps
Resolution : 24 bits
Colorimetry : 4:2:0
Scan type : Progressive
Color primaries : BT.709-5, BT.1361, IEC 61966-2-4, SMPTE RP177
Transfer characteristics : BT.709-5, BT.1361
Matrix coefficients : BT.709-5, BT.1361, IEC 61966-2-4 709, SMPTE RP177

Audio #1
ID : 4352 (0x1100)
Menu ID : 1 (0x1)
Format : AC-3
Format/Info : Audio Coding 3
Duration : 1h 46mn
Bit rate mode : Constant
Bit rate : 384 Kbps
Channel(s) : 6 channels
Channel positions : Front: L C R, Surround: L R, LFE
Sampling rate : 48.0 KHz
Stream size : 292 MiB (1%)
Language : Russian / /

Audio #2
ID : 4353 (0x1101)
Menu ID : 1 (0x1)
Format : DTS
Format/Info : Digital Theater Systems
Format profile : MA
Duration : 1h 46mn
Bit rate mode : Variable
Channel(s) : 8 channels
Channel positions : Front: L C R, Surround: L C C R, LFE
Sampling rate : 48.0 KHz
Resolution : 16 bits
Language : Chinese / /

Text #1
ID : 4608 (0x1200)
Menu ID : 1 (0x1)
Format : PGS
Language : English / /

Text #2
ID : 4609 (0x1201)
Menu ID : 1 (0x1)
Format : PGS
Language : Chinese / /

OS - Win XP x64, Video - ATI with latest drivers, DX up to date. Haali media splitter detects subtitle streams, but when I select one of them, produces error:
http://img694.imageshack.us/img694/9238/20091114160842.png
Internal splitter also doesn't help and it's behavior depends on revision:
1) b1249 detects all subtitle streams right, but doesn't show
http://img517.imageshack.us/img517/5286/20091114162928.th.png (http://img517.imageshack.us/i/20091114162928.png/)
2) b1326 incorrectly detects language of secondary stream
http://img248.imageshack.us/img248/3352/20091103200357.th.jpg (http://img248.imageshack.us/i/20091103200357.jpg/)
3) b1337 doesn't detect subtitle streams at all
http://img132.imageshack.us/img132/6176/20091114162654.th.png (http://img132.imageshack.us/i/20091114162654.png/)
Bug exists independent on opening m2ts file, index.bdmv or "Open DVD"
With PowerDVD subtitles shows fine

[Opuz Klass]

Hi there guys!

MPC-HC is crashing with Intel GMA500 graphics chipset when trying to play any video using EVR-CP in Windows 7. I would like to help you by providing you with minidumps but I'm not finding them. I've confirmed this behavior in several laptops using this chipset with Windows 7 (latest drivers).

[therealjoeblow]

Would it be possible to add a shader that "smart-stretches" 4:3 media content to 16:9 similar to the way that PowerDVD does for DVD material, ie, where the center 1/3 of the image remains mostly undistorted, and the bulk of the stretching is done in the outer thirds, more towards the edges of the video frame? Kind of like projecting the image onto a cylinder...

[Snowknight26]

http://mpc-hc.svn.sourceforge.net/viewvc/mpc-hc/trunk/src/dsutil/DSUtil.cpp?r1=1338&r2=1337&pathrev=1338

Wouldn't it be more appropriate if the stream names were "MPEG-2" instead of "MPEG 2", "H.264" instead of "H264", "Secondary DTS-HD High Resolution Audio" instead of "Secondary DTS HD High Resolution Audio", and "VC-1" instead of "VC1?"

[tetsuo55]

http://mpc-hc.svn.sourceforge.net/viewvc/mpc-hc/trunk/src/dsutil/DSUtil.cpp?r1=1338&r2=1337&pathrev=1338

Wouldn't it be more appropriate if the stream names were "MPEG-2" instead of "MPEG 2", "H.264" instead of "H264", "Secondary DTS-HD High Resolution Audio" instead of "Secondary DTS HD High Resolution Audio", and "VC-1" instead of "VC1?"should be easy to fix, please open a ticket on trac so it can be discussed and done

https://sourceforge.net/apps/trac/mpc-hc/newticket

[Mangix]

boiled_sugar's sample works on my computer. using XP 32-bit, VMR9, DXVA, 195.39 GeForce drivers

[kieranrk]

Would it be possible to add a shader that "smart-stretches" 4:3 media content to 16:9 similar to the way that PowerDVD does for DVD material, ie, where the center 1/3 of the image remains mostly undistorted, and the bulk of the stretching is done in the outer thirds, more towards the edges of the video frame? Kind of like projecting the image onto a cylinder...

Please watch your DVDs in their correct aspect ratios.

[Egh]

tetsuo55:

do you think it would be a worthy feature is there was a method to override a sub style with default?

I know the styles can be edited on-the-fly, but if you want to revert a style to one's default choice, you have to adjust font, scaling, several colours, outline/shadow size etc. An "override" button in that tabsheet would be handy, imo. I'm so annoyed by some "creativity" styles that I quite so often just override them manually.

[tetsuo55]

tetsuo55:

do you think it would be a worthy feature is there was a method to override a sub style with default?

I know the styles can be edited on-the-fly, but if you want to revert a style to one's default choice, you have to adjust font, scaling, several colours, outline/shadow size etc. An "override" button in that tabsheet would be handy, imo. I'm so annoyed by some "creativity" styles that I quite so often just override them manually.yeah a "display all text based subtitles as standard SRT" would probably be a good feature.

You can add it to the tracker, but we have no coders who want to work on adding this right now.

[easyfab]

@boiled_sugar : I've the same problem on my Ati HD 2600 with mpc dxva and pdvd dxva : so it's an Ati bug, I hope it's only a driver problem and not hardware.

[littleD]

I have ati and have corruption too.
BTw whats that anime?

[donaldtone]

wishilist:
1. update ogglib in ogg Directshow splitter to support more formats: like Kate stream.
2. add Kate format subtitle support to subtitle render engine.

Then mpc-hc can completely support new version of ogv format. This format is totally free and theora, vorbis and kate are patent free codecs. Right now only VLC can support its subtitle.

[tetsuo55]

i have run mpc-hc through the microsoft application verifier and it fails quite a few tests.

This is a call to all coders, please help us fix the crashes and memory leaks.

the verifier can be downloaded here:
http://www.microsoft.com/downloads/details.aspx?FamilyID=c4a25ab9-649d-4a1b-b4a7-c9d8b095df18&DisplayLang=en

The tests that give errors and cause crashes are:
Handles, Heaps, locks, low resource, LuaPriv and DangerousAPi

the goal should be to have an error free (and warning free) result with all tests enabled.

---------------

EDIT:

Also /SAFESEH fails to complete, some precompiled parts need to be recompiled with vs2008 with the /SAFESEH switch before MPC-HC itself can be compiled with it

---------------

EDIT2:

/DYNAMICBASE, /NXCOMPAT should be added by default (and /SAFESEH once that has been fixed)

Also /RTC1, /Od can be used to find out more about the memory leaks/crashes and if you happen to have a enterprise version of vs2008 /analyse will give even more info

-----------

EDIT3:

Some data:
On my systems:
about 80% of allocated ram is unused/leaked by mpc-hc
mpc-hc leaks 4kb/s during playback
during playback 200MB+ of pagefile is allocated and heavily used (many pagefaults)

Cleaned with no movie mpc-hc only uses 700kb of ram, uncleaned it uses 13MB and with a movie the lowest i've seen is 40MB(18MB cleaned)

[boiled_sugar]

I'm sorry. The corruption turned out to be x264 bug. Now it's fixed.

BTw whats that anime?
Tegami Bachi

[Opuz Klass]

tetsuo55,

Have you read my report in post 10489 (http://forum.doom9.org/showpost.php?p=1343840&postcount=10489) of this thread? Please let me know how I can help you solving this problem.

Thanks

[betaking]

Hi,why Complete Last mpc-hc give me error:
MEDIASUBTYPE_DVB_SUBTITLES not defined.

[nuhkka]

why does my mpc-hc freeze when the windows uac thing comes up?

[tetsuo55]

Hi there guys!

MPC-HC is crashing with Intel GMA500 graphics chipset when trying to play any video using EVR-CP in Windows 7. I would like to help you by providing you with minidumps but I'm not finding them. I've confirmed this behavior in several laptops using this chipset with Windows 7 (latest drivers).have a look here: http://sourceforge.net/apps/trac/mpc-hc/wiki/Troubleshooting_guidelineswhy does my mpc-hc freeze when the windows uac thing comes up?see here http://forum.doom9.org/showthread.php?p=1344275#post1344275

[STaRGaZeR]

Hi,why Complete Last mpc-hc give me error:
MEDIASUBTYPE_DVB_SUBTITLES not defined.

Same question:

Error 2 error C2065: 'MEDIASUBTYPE_DVB_SUBTITLES' : undeclared identifier SubtitleInputPin.cpp 68

[tetsuo55]

Same question:

Error 2 error C2065: 'MEDIASUBTYPE_DVB_SUBTITLES' : undeclared identifier SubtitleInputPin.cpp 68This happened with rev 1335, please add a bug to the tracker https://sourceforge.net/apps/trac/mpc-hc/newticket

@Everyone, i've added all the security/memory leak basics to the bug tracker as the following bugs:
126 [Security] /SAFESEH compilation fails (http://sourceforge.net/apps/trac/mpc-hc/ticket/126)
127 [Security] Enable the following switches by default in all vsproj files. (http://sourceforge.net/apps/trac/mpc-hc/ticket/127)
128 [Security] Add Heap Corruption Detection (http://sourceforge.net/apps/trac/mpc-hc/ticket/128)
129 [Security][Stability] Pass all the Microsoft Application Verifier tests (http://sourceforge.net/apps/trac/mpc-hc/ticket/129)
130 [Logo] MPC-HC should pass all the windows 7 logo tests/requirements (http://sourceforge.net/apps/trac/mpc-hc/ticket/130)
131 [Certificate], try to get a code signing certificate from thawte in january (http://sourceforge.net/apps/trac/mpc-hc/ticket/131)

[Mercury_22]

Since If there is no Pixel Shader 2.0 support, simple bilinear is used automatically it's there any reason why not make "Bilinear (PS 2.0)" the default resizer instead of Bilinear ?

P.S. AFAIK aren't many (if any) cards without PS 2.0 support out there anymore
Also what's "Nearest neighbor" for then ? maybe the code can get "slimmer"

[clsid]

Because it will most likely cause problems on low-end cards/IGPs.

[bur]

The Goto command (Ctrl + G) seems to be broken in the x64 builds.

When I enter any time it gives the error: Error parsing entered time!

When I just edit the preset values it works. But as soon as I have used my own numbers even once it stops working.

It won't even work for the preset values from that point on.


Goto works just fine in the 32bit builds.


My system:
Windows 7 x64
8800GT

(the bug report section on sourceforge seems to have been closed? so I report it here)


Could anyone with a x64 build please check if this applies to others as well? Just open the Goto windows by pressing Ctrl + G and then enter something like 2.8.0 - it should go to 2 mins 8 secs 0 ms then.

[Astrophizz]

Also what's "Nearest neighbor" for then ? maybe the code can get "slimmer"

Nearest neighbor is (I believe) where pixels in a scaled image simply duplicate the value of the nearest original pixel. So, you get blocks of pixels. For an example when scaling x3 a single pixel would have its value mapped to a 3x3 set of pixels.

[tetsuo55]

Since it's there any reason why not make "Bilinear (PS 2.0)" the default resizer instead of Bilinear ?

P.S. AFAIK aren't many (if any) cards without PS 2.0 support out there anymore
Also what's "Nearest neighbor" for then ? maybe the code can get "slimmer"PS resizers causes tearing/jitter/judder for many users, so its definately not ready for default enabled yet.

the rest was answered i think.

[therealjoeblow]

Please watch your DVDs in their correct aspect ratios.

...The point of the request wasn't to obtain a critical (and useless) response...

[Mixer73]

Wtih 1337 x86 the bug still exists where if you are playing a video and drag'n'drop another video into the window, MPC-HC will try to play both at the same time, I can't find a way to search the bug tracker to see if this one is in the tracker, but it has been reported before.

[Polcius]

2 questions:

- What's the difference between "Bilinear" and "Bicubic" resizing?

- In wich way is the EVR-CP renderer different from VLC Media Player's? Wich one is better?

[tetsuo55]

Wtih 1337 x86 the bug still exists where if you are playing a video and drag'n'drop another video into the window, MPC-HC will try to play both at the same time, I can't find a way to search the bug tracker to see if this one is in the tracker, but it has been reported before.please add it to trac, its not on there

[clsid]

Also include as much information in your bug report as possible, because this is not a common problem, therefore hard to reproduce.

[Mercury_22]

One more question about the default resizer, from all your answers I understand that the automatic fall to simple Bilinerar it's not working. Is it true ? AKA the statement If there is no Pixel Shader 2.0 support, simple bilinear is used automatically from MPC-HC's tooltip it's not true ? Or I misunderstood everything ?

@tetsuo is your answer based on reports with recent builds after Beliyaal changes in REV 1312 or on reports with older builds ?

[snyders6dogrecipe]

First off, thanks a lot for this great player that I've been using for 6 years!

For some reason, in the new build, the video feels like it is cutting into my eyes when I watch it. The version before it didn't have this painful effect at the same settings. However, the DXVA, which I always use, looks MUCH better in v1.3.1249.

Could you please make a build that is the same as v1.2.908.0, only with the newer dxva code, so I could get the best of both worlds? (Or instructions that would let me compile it. I don't have any experience with C++ or SDK's or DirectX, though...) That'd make things just about perfect for me.

My specs: Nvidia 8700M gt, Intel duo 2.0 ghz, Windows XP Media Center 32-bit

Thank you very much

[tetsuo55]

@tetsuo is your answer based on reports with recent builds after Beliyaal changes in REV 1312 or on reports with older builds ?It has always been that way, but obviously bicubic(PS2) never worked before beliyaal fixed itFirst off, thanks a lot for this great player that I've been using for 6 years!

For some reason, in the new build, the video feels like it is cutting into my eyes when I watch it. The version before it didn't have this painful effect at the same settings. However, the DXVA, which I always use, looks MUCH better in v1.3.1249.

Could you please make a build that is the same as v1.2.908.0, only with the newer dxva code, so I could get the best of both worlds? (Or instructions that would let me compile it. I don't have any experience with C++ or SDK's or DirectX, though...) That'd make things just about perfect for me.

My specs: Nvidia 8700M gt, Intel duo 2.0 ghz, Windows XP Media Center 32-bit

Thank you very muchThere is something wrong with your settings, the image should be (near) perfect, please follow the checklist in my signature

[Mixer73]

Hey guys I am wondering if you can help me troubleshoot a little problem.

I am watching DVB-T recordings with the Microsoft Decoder but they don't seem to deinterlace. I'm using EVR-CP on Vista, what settings should I change in order to get deinterlacing to work?

Could anybody give some quick advice on this?

Wtih 1337 x86 the bug still exists where if you are playing a video and drag'n'drop another video into the window, MPC-HC will try to play both at the same time, I can't find a way to search the bug tracker to see if this one is in the tracker, but it has been reported before.

I have submitted a bug to the tracker for this one.

[snyders6dogrecipe]

It has always been that way, but obviously bicubic(PS2) never worked before beliyaal fixed itThere is something wrong with your settings, the image should be (near) perfect, please follow the checklist in my signature

Thanks for the faq. My hardware (nvidia geforces 8700m) and everything else matches up, and I tried all of the settings listed there.

But I would imagine the settings would be exactly the same between players, since every time I change a setting in one version of MPC-HC it carries over to any others.

If I could get a compile of v1.2.908.0 with the DXVA carried over from v1.3.1249, I would be complaint-free...:thanks:

[tetsuo55]

Thanks for the faq. My hardware (nvidia geforces 8700m) and everything else matches up, and I tried all of the settings listed there.

But I would imagine the settings would be exactly the same between players, since every time I change a setting in one version of MPC-HC it carries over to any others.

If I could get a compile of v1.2.908.0 with the DXVA carried over from v1.3.1249, I would be complaint-free...:thanks:Can you post screenshots etc.. like requested in that link i gave you.
The problem is related to one of the many new settings that where introduced since 908

[snyders6dogrecipe]

Can you post screenshots etc.. like requested in that link i gave you.
The problem is related to one of the many new settings that where introduced since 908

Well here are screenshots of the 1080p Avatar trailer using v1.2.908.0 and v1.3.1249.0, respectively.

http://a.imagehost.org/0177/ava2.jpg
http://i.imagehost.org/0470/ava3.jpg


It's hard to really pinpoint what exactly is wrong with the image, other than the feeling of strain on my eyes that it induces if I stare at it for a few seconds. The 1.2.908.0 one doesn't do that.

Thank you for your time.

[Steveo08]

i have a question for using pixel shader at mpc-hc, what is the different between using "combine shaders" & "combine screen space shaders" when i use the shader "sharpen complex 2" ?

[Keiyakusha]

i have a question for using pixel shader at mpc-hc, what is the different between using "combine shaders" & "combine screen space shaders" when i use the shader "sharpen complex 2" ?
The function of these "combiners" remains the same independently on chosen shader. They just allows you to use more than one shader or screen space shader at time.