Media Player Classic Home Cinema (MPC-HC) - DXVA!

[Steveo08]

i have a question to the function autochange, it won't work for me on win7 x64 at a nvidia gt220, windows ignores all modes autochange. and i am running mph-hc as a admin.




no one else with the problem?

[Linus82]

Hi, i have a weird problem, i've tried searching but can't find the solution.
I have a Ati 3650 card, win7, i've been using MPC-HC for 2 years or something and never had this problem.
When i play up dxva videos i get artifacts, like the renderer can't render fast enough.
I tought it might be something wrong with drivers or something, so i formated the htpc and did a clean install of win 7 and newest drivers for the card.
I get the same problem again, tried both stable version and latest build, and both x86 and x64.
The weird thing is that dxva with ffdshow works like a charm.
Is it my graphic card or something else thats wrong?
Using EVR btw.

[Alexander01]

To the coders of Media Player Classic - Home Cinema:

Can you please add an option to disable 'embedded subtitles'.

Everytime when I open a mkv file with embedded subtitles I need to switch to my external .srt manually
And sometimes I just don't want to use subtitles, but MPC-HC always loads the embedded subtitles. I can disable them manually, but i'd like to see an option to permantly disable embedded subtitles.

*bump*

Please, anyone can add this option to disable loading of subtitle streams inside video files?

[Dreamhacker]

Which is the last stable revision at the SVN?

[MPC-HTPC]

Please, anyone can add this option to disable loading of subtitle streams inside video files?

As long as there is no such feature added, you can use woXXoM's workaround to prioritize your external subtitles over internal ones:

I just set subs priority (Options->playback) to ENG and rename extsubs as VidFileName.LANG.ext, e.g. SomeVideoFile.ENG.ass. Of course it doesn't have to be ENG only. You can choose whatever letters you like.

[MPC-HTPC]

Which is the last stable revision at the SVN?

I refer here to a previously made statment from XhmikosR:
Stable is what you call stable.

and also a quote from a post of ADude:
In the case of MPC-HC, I would say that "stable" is a version where two or more people do not report the same major problem. (In other words, any report of a major problem is not confirmed by any other person.)

So you can grab the latest SVN-Version most of the time and have a fully functional media player. Or you take the compiled versions from alexins site: http://www.xvidvideo.ru/media-player-classic-home-cinema-x86-x64/ or one of XhmikosR builds: http://xhmikosr.1f0.de/index.php?folder=bXBjLWhjX21zdmMyMDA4


If your question refers to your previously made post
Would it be possible to add an option in MPC-HC to specify what folder to auto-load subtitles from? Or if I were to do it myself, in what part of the code would I have to look for the auto-load functionality?

then maybe one of the developers can hopefully point you in the right direction.

[XhmikosR]

About madflac, using the latest rev:

Unhandled exception at 0x77572913 in mpc-hc.exe: 0xC0000374: A heap has been corrupted.

atlcomcli.h

inline CComBSTR::~CComBSTR() throw()
{
--> ::SysFreeString(m_str);
}
If I choose continue then it starts playback.

[madshi]

@XhmikosR,

thanks for looking into this. I guess MPC HC is here trying to free a string which was fetched from madFlac's "IAMMediaContent" interface before? Can you say which string/property is being freed when the exception occurs? As far as I can see, the madFlac code looks ok to me. I'm using CoTaskMemAlloc to allocate the memory for those strings.

[XhmikosR]

I have no idea, so it should be easier if you just debugged this thing yourself :) Here (http://xhmikosr.1f0.de/mpc-hc_msvc2008/mpc-hc_x86_Debug.7z) is a Debug build for your to test.

[madshi]

I have no idea, so it should be easier if you just debugged this thing yourself :) Here (http://xhmikosr.1f0.de/mpc-hc_msvc2008/mpc-hc_x86_Debug.7z) is a Debug build for your to test.
I've just tried, and I can't even reproduce a crash on my XPSP3 dev machine. Does the crash only occur on other OSs? Anyway, I don't really think it's my job to debug this problem, because as far as I can see, MPC HC is the guilty one here. If madFlac would be responsible for the crash, then why has this crash not occured in the last 2.5 years, with *any* media player? Makes no sense to me.

[XhmikosR]

I only have Windows 7 so I cannot test other OS. I agree with you but since I'm not the one who can fix this we'll have to wait.

[madshi]

Ok, thanks.

[yesgrey]

I only have Windows 7 so I cannot test other OS.
I also have W7 but I'm not getting any crash when using madFlac... I've tried both your debug build and last xvideo.ru 2225 build, with both movie and music flac files.

[Dreamhacker]

I refer here to a previously made statment from XhmikosR:


and also a quote from a post of ADude:


So you can grab the latest SVN-Version most of the time and have a fully functional media player. Or you take the compiled versions from alexins site: http://www.xvidvideo.ru/media-player-classic-home-cinema-x86-x64/ or one of XhmikosR builds: http://xhmikosr.1f0.de/index.php?folder=bXBjLWhjX21zdmMyMDA4


If your question refers to your previously made post


then maybe one of the developers can hopefully point you in the right direction.
Alright, I'll just use the latest SVN-build in that case. I found where in the code to edit the auto-load locations, gonna see if I can change the code to enable users to set the folders.

Also, I'll look into the possibility of prioritizing external subtitles, that also shouldn't be too impossible to fix. :p

[oddball]

XhmikosR I installed build 2225 from xvidvideo.ru and it defaults to English. If I install your build 2229 it defaults to French. If I copy over your build 2225 files it stays on French. If I install xvidvideo.ru again it defaults back to English again but NOW if I copy over your build 2225 files it STAYS on English.

I think it's your installer is the problem that is setting the default language to French somehow. But I don't know why it's staying on French when I set it to English and restart MPC. Hmmm.

If you had your build 2225 with installer I'd be interested to see if it goes back to French after install.

EDIT: Oh well I installed 2232 and it is fine so it got fixed along the line somewhere.

[XhmikosR]

Well, don't think. My builds are vanilla builds and are fine. If something is broken in the svn, then it will be broken in my builds and in xvidvideo.ru builds so please cut the BS.

[MPC-HTPC]

I found where in the code to edit the auto-load locations, gonna see if I can change the code to enable users to set the folders.

Also, I'll look into the possibility of prioritizing external subtitles, that also shouldn't be too impossible to fix. :p

That is good news! I hope you manage to include these two features and the developers decide to add them to the trunk. Until then I keep my fingers crossed. ;)

[oddball]

Well, don't think. My builds are vanilla builds and are fine. If something is broken in the svn, then it will be broken in my builds and in xvidvideo.ru builds so please cut the BS.

Thanks.

[hissatsu]

I have one issue with MPC-HC concerning blu-ray playback. If there is a known fix or it's a problem with my setup I apologize, but after trying just about everything I can think of I've been unable to fix it.

I can play individual m2ts files just fine. I can play using Open DVD or by directly opening an mpls playlist on the blu-ray just fine and as long as the mpls itself contains just one m2ts file, all is fine. But if the it's made up of multiple m2ts files, when it switches from one to another during seamless playback, that's where there's an issue.

At the point where it switches from one m2ts file to the next, I can see the timer pause for about 1 second, maybe a little more. The audio plays, but the video doesn't start until the timer starts moving again. Once the video starts, it goes fast until it resyncs with the audio, which takes less than a second. But that second or so during which timer wasn't moving is "lost", so the timer is now behind by second or so after that point. It no longer matches the time it should be if I played it using a Blu-ray player or something like PowerDVD (which is mostly useless to me otherwise). If there are multiple switches between m2ts files, then the timer falls further and further behind. This isn't much of an issue for normal playback, but it means if I load a subtitle script, I have to retime it after that point, and if I time a script to it, it's wrong for anything but MPC-HC.

Any help in solving this would really be appreciated. That is, if there is a solution. If it's a known issue then I'll just have to wait until it's fixed. Running on Windows 7 x64, DXVA, using internal filters only. Thanks again for a great program.

[alexins]

Media Player Classic HomeCinema (x86/x64), svn 2235 (http://www.xvidvideo.ru/media-player-classic-home-cinema-x86-x64/media-player-classic-homecinema-x86-x64-svn-2235.html)

Changes (2226-2235):

mpciconlib: renamed PLS to PLC plus some cosmetic changes;
Filters: applied astyle formatting, updated copyright notice. VSFilter, VSRip: updated copyright notice. Renamed renaming "subtitles" instances to "Subtitles";
Add : detect system UI language and set interface language at first run;
Fix : issue some MPEG(mono) audio playback; ticket #116;
Updated Portuguese translation;
Fix : MPEGSplitter - could not read some MPEG files;
Add : some PCM RAW GUID;
Fix : rev. 2228;
removed DSUtil directory from common.vsprops and common.props;
renamed "toolbar1.bmp" to "toolbar.bmp";
clean up libavcodec project files.

[Alexander01]

As long as there is no such feature added, you can use woXXoM's workaround to prioritize your external subtitles over internal ones:

Yes, but with that workaround I have to rename all my subtitle files and if no external srt file exists (because I want to watch without subtitles), it still loads the embedded subtitles. I just need a checkbox to disable embedded subtitles (just like ffdshow has).


For now, I used a hexeditor to overwrite the following strings in mpc-hc.exe with hex00:

S_VOBSUB
S_HDMV/PGS
S_USF
S_TEXT/USF
S_SSF
S_TEXT/SSF
S_ASS
S_TEXT/ASS
S_SSA
S_TEXT/SSA
S_TEXT/UTF8
S_TEXT/ASCII

Now it won't load any embedded subtitles anymore. Only external subtitles :)

[Dreamhacker]

Yes, but with that workaround I have to rename all my subtitle files and if no external srt file exists (because I want to watch without subtitles), it still loads the embedded subtitles. I just need a checkbox to disable embedded subtitles (just like ffdshow has).


For now, I used a hexeditor to overwrite the following strings in mpc-hc.exe with hex00:

S_VOBSUB
S_HDMV/PGS
S_USF
S_TEXT/USF
S_SSF
S_TEXT/SSF
S_ASS
S_TEXT/ASS
S_SSA
S_TEXT/SSA
S_TEXT/UTF8
S_TEXT/ASCII

Now it won't load any embedded subtitles anymore. Only external subtitles :)
So you basically butchered the poor file. :P

I'm working on a better solution at the moment, have some ideas but need to make sure I don't screw anything up by the code changes I'm thinking of doing. And I won't have any files to test it on before Monday in any case.

[MPC-HTPC]

Yes, but with that workaround I have to rename all my subtitle files and if no external srt file exists (because I want to watch without subtitles), it still loads the embedded subtitles.

Yeah, I was aware that my hint just fits your needs partly, but it is good to hear that you found some workaround yourself. :)

But to have a clean solution for the whole internal/external subtitle case I am eager to see with what Dreamhacker will come up!

[Sebastiii]

I have one issue with MPC-HC concerning blu-ray playback. If there is a known fix or it's a problem with my setup I apologize, but after trying just about everything I can think of I've been unable to fix it.

I can play individual m2ts files just fine. I can play using Open DVD or by directly opening an mpls playlist on the blu-ray just fine and as long as the mpls itself contains just one m2ts file, all is fine. But if the it's made up of multiple m2ts files, when it switches from one to another during seamless playback, that's where there's an issue.

At the point where it switches from one m2ts file to the next, I can see the timer pause for about 1 second, maybe a little more. The audio plays, but the video doesn't start until the timer starts moving again. Once the video starts, it goes fast until it resyncs with the audio, which takes less than a second. But that second or so during which timer wasn't moving is "lost", so the timer is now behind by second or so after that point. It no longer matches the time it should be if I played it using a Blu-ray player or something like PowerDVD (which is mostly useless to me otherwise). If there are multiple switches between m2ts files, then the timer falls further and further behind. This isn't much of an issue for normal playback, but it means if I load a subtitle script, I have to retime it after that point, and if I time a script to it, it's wrong for anything but MPC-HC.

Any help in solving this would really be appreciated. That is, if there is a solution. If it's a known issue then I'll just have to wait until it's fixed. Running on Windows 7 x64, DXVA, using internal filters only. Thanks again for a great program.

Hi, i need to test if i can see this too, but i'm not @ home, could you give us what kind of video codec is on your BD ?
VC-1 or H264, or maybe you have this on 2 type of BD codec ?
Thanks.

[3ngel]

Hi,

i've just downloaded the latest builds 1.3.2235.0.

The bob deinterlace doesn't work anymore.

The video remains untouched (interlacing jaggies completely visible on interlaced ntsc material)

My chain filter

Mpeg-2 Video Decoder-> Overlay Mixer -> Video Renderer

(Same results with any other renderer, using it because faster on the netbook)

Can this be fixed soon?

Thanks

[DMD]

Good morning.

After several attempts I was able to test and do the shrink of the Blu-ray HDD, only forced subtitles and audio in my language.

For this reason I ask if you can, in general settings, set the player that always starts with the first track of subtitles activated.

This is to avoid that whenever I play a movie I must act in the selection menu or press the button corresponding to the subtitles.

http://www.allfreeportal.com/imghost2/images/12244Screenshot 003.png (http://allfreeportal.com)


THANKS

[hissatsu]

Hi, i need to test if i can see this too, but i'm not @ home, could you give us what kind of video codec is on your BD ?
VC-1 or H264, or maybe you have this on 2 type of BD codec ?
Thanks.

All the BDs I have like this are H264, so I don't know if it happens with VC-1. I should have thought to mention that.

[jeremy33]

About the madFalc problem why you don't revert the 2123 modification ? At least temporarily.

[tetsuo55]

About the madFalc problem why you don't revert the 2123 modification ? At least temporarily.There error you are getting is very dangerous, in theory your whole computer could crash as a result. We definately won't be reverting.

[Sebastiii]

All the BDs I have like this are H264, so I don't know if it happens with VC-1. I should have thought to mention that.

It happen on recent rev or you always have that ?

[madshi]

There error you are getting is very dangerous, in theory your whole computer could crash as a result.
What!? :confused:

As a project manager you should care about practical consequences, not about theoretical stuff. Let's look at the practical consequences of activating that Heap Corruption Detection feature:

- no practical improvements I can see
- madFlac stops working, maybe some other filters, too

IMHO you should activate a feature like Heap Corruption Detection only *after* all negative side effects are solved. So if you insist of using that feature, first make sure that it works alright. Only then activate it. Doing it the other way round is a bad choice for your users.

[tetsuo55]

Let me put it this way.

1. I am convinced other filters should be caught by this too, and I do think the heap corruption should not be ignored.

2. There are actually several filters that fail under different circumstances since we enabled all the security features, madflac is just the latest victim. (before you ask, yes there are known exploits for mpc-hc)

3. This feature is only enabled in the nightly/wip builds, the stable build works just fine apart from the crash now and then when the heap corrupts in a bad way(now and then is an understatement, think more in the lines of 1000's of reported crashes per day).

I hope this makes our decision a bit more clear.
Apart from that i have given this crash a very high priority with the few devs we have.

EDIT: Breaking news, one of the devs has reproduced the madflac crash in build without heap corruption, it seems then the catch is correct and the code should be blocked from executing.

[madshi]

1. I am convinced other filters should be caught by this too, and I do think the heap corruption should not be ignored.
I'm all for finding bugs. As long as end users are not negatively affected.

3. This feature is only enabled in the nightly/wip builds, the stable build works just fine
You mean the stone age stable builds which nobody is using? Or which stable builds do you mean? I think most people are using the nightly builds.

Apart from that i have given this crash a very high priority with the few devs we have.
Thanks, I'm glad to hear that. FWIW, I'm very willing to help, especially if there are signs that it could be a bug in madFlac (which I'm not convinced of yet).

EDIT: Breaking news, one of the devs has reproduced the madflac crash in build without heap corruption, it seems then the catch is correct and the code should be blocked from executing.
The big question is if it's a bug in MPC HC or a bug in madFlac. Even if the crash only occurs with madFlac in the graph, it could still be a bug in MPC HC. E.g. let's just say it could be quite possible that MPC HC is fetching a description string from madFlac and then freeing it twice. That would probably result in heap corruption and would be a bug in MPC HC and not in madFlac. Of course it's also possible that there's a real bug in madFlac. But I've heard no stability complaints about madFlac from any users of any media players in the last 2.5 years, which makes me somehow doubt it. But of course you can never be sure...

[arty]

Alright, I'll just use the latest SVN-build in that case. I found where in the code to edit the auto-load locations, gonna see if I can change the code to enable users to set the folders.

Also, I'll look into the possibility of prioritizing external subtitles, that also shouldn't be too impossible to fix. :p

I have been waiting for this feature for years, really!!! :D Thank you sooo much!

[tetsuo55]

@madshi, it would be a great help if you could join us online, we have a few people trying to fix it right now. http://webchat.freenode.net channel #mpc-hc

[sneaker_ger]

I have been waiting for this feature for years, really!!! :D Thank you sooo much!

Using only external subtitles is already possible using DirectVobSub (if you can't wait for a modded version):
http://www.abload.de/img/vsfilterfprt.png

[arty]

Using only external subtitles is already possible using DirectVobSub (if you can't wait for a modded version):


but not with dxva :)

[sneaker_ger]

True. It's only a suggestion - a new feature for the internal renderer shouldn't hurt. (I'm also using the internal one)

[Dreamhacker]

Build 2235 seems to crash for me at exit. An access violation within MFC it looks like. Though, I skipped compiling the resource dlls, should that matter in any way?

And it seems my current code changes makes it load the first external subtitle rather than the first internal subtitle. Just need to add an option to turn the feature on/off. Along with an option to specify the paths where it should look.

[tetsuo55]

Build 2235 seems to crash for me at exit. An access violation within MFC it looks like. Though, I skipped compiling the resource dlls, should that matter in any way?

And it seems my current code changes makes it load the first external subtitle rather than the first internal subtitle. Just need to add an option to turn the feature on/off. Along with an option to specify the paths where it should look.did you use vs2010? crash on exit is an age old bug since the first release of mpc, but its more noticable in vs2010 compiled builds

[Dreamhacker]

did you use vs2010? crash on exit is an age old bug since the first release of mpc, but its more noticable in vs2010 compiled builds

Yes, I use Visual Studio 2010. Though, shouldn't someone track down that bug and find what is being done in wrong order?

[tetsuo55]

Yes, I use Visual Studio 2010. Though, shouldn't someone track down that bug and find what is being done in wrong order? we tried and got stuck on one of the 3rd party libraries, maybe you can try and have more luck?

[Dreamhacker]

we tried and got stuck on one of the 3rd party libraries, maybe you can try and have more luck?

I could always try, could be a nice challenge to work at. ;)

Does it always happen when it's compiled with Visual Studio 2010? Or have people succeeded in compiling with Visual Studio 2010 and without this bug present?

[Hypernova]

I spent the extra tests and was proved right - in 2010 build errors due to sizecbar component.
I disable code with create control based on sizecbar ... and MPC-HC not crash on exit;

Here the listing of control:



This means that the error is not in the code of MPC-HC

P.S. sizecbar don't work in VS2010 build, need rewrite or change to another component.

Can you try with the latest update? Right now 2.43 (from August 2000) is in trunk, 2.45 (April 2010) is the latest:
http://www.datamekanix.com/sizecbar/
The homepage says that VS2010 is supported...

Changes since 2.43:

Try - nothing don't change, don't work with VS2010 build.

I could always try, could be a nice challenge to work at. ;)

Does it always happen when it's compiled with Visual Studio 2010? Or have people succeeded in compiling with Visual Studio 2010 and without this bug present?

Put it together for your convinent. Hopefully I will be able to use vs2010 ver soon. :)

[omri09]

Where can I see what's the updates in every release?
I already checked here: http://xhmikosr.1f0.de/index.php
and in the "changelog" file of the 7z.

BTW, I just love this software!

[Alexander01]

Build 2235 seems to crash for me at exit. An access violation within MFC it looks like. Though, I skipped compiling the resource dlls, should that matter in any way?

And it seems my current code changes makes it load the first external subtitle rather than the first internal subtitle. Just need to add an option to turn the feature on/off. Along with an option to specify the paths where it should look.


Great! Can you also make an option to disable embedded subtitles completely?

[Dreamhacker]

Great! Can you also make an option to disable embedded subtitles completely?

What do you mean by that? Do you want it to not load the embedded subtitle at all, or just make it so it never defaults to an embedded subtitle even if there are no externals available?

[Alexander01]

Both options are fine for me. As long it does not display the embedded subtitles when I open the video file it's fine! But it should display external subtitles by default if they exists.

[sneaker_ger]

Where can I see what's the updates in every release?

Link taken from the start post of this thread:
changelog (http://mpc-hc.svn.sourceforge.net/viewvc/mpc-hc/?view=log)

[omri09]

Link taken from the start post of this thread:
changelog (http://mpc-hc.svn.sourceforge.net/viewvc/mpc-hc/?view=log)

Thanks dude!
Missed it somehow :)