Log in

View Full Version : Media Player Classic - BE Win32/x64


Pages : 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 [203] 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235

v0lt
12th July 2023, 04:41
It is completely up to an application to perform any sort of correction to its output. So an application needs to read in the profile, and based on that profile data, needs to alter its output so that its output displays correctly on that display.

Put more simply, display profiles only do things for software that uses it.
This is wrong.
I have a display profile and night view works globally for all desktop and application windows. It also works for D3D11 exclusive full screen (MPC VR).
Display profile and night view does not work for D3D9 exclusive full screen.

kirakami
12th July 2023, 11:25
Would like to see option to choose using Vulkan instead of Direct3D 11 in MPC Video Renderer if possible.

https://i.imgur.com/hGnIFl1.png

huhn
12th July 2023, 13:00
This is wrong.
I have a display profile and night view works globally for all desktop and application windows. It also works for D3D11 exclusive full screen (MPC VR).
Display profile and night view does not work for D3D9 exclusive full screen.

it's sadly more complicated.
the majority of programs don't use them.
i know one computer game that has an option to not unload the ICM profile. and know no other game that will make use of it. i even made a bug report for Minecraft so it stops unloading ICM profiles even after application shutdown...

but yes you don't have to do the correction yourself you can just ask windows to do it.

not work in d3d9 shows already the issue with windows colour management it's inconsistent.
that's one reason it's not that popular in the video space and 3D LUT are the way to go or where at least.
in the past windows colour management didn't do gamut correction...
only d3d9 overlay(rip the greatest rendering mode in history) in madVR did because it wasn't using the windows correct but took the profile and did it itself.

Sunspark
12th July 2023, 16:03
I wish to suggest something in terms of colour profiles on Windows, which I have been doing since W7.

1) Open the colour management control panel.
2) You should have your monitor's icc/icm profile(s) listed there, with one of them set as default and "use my settings for this device" checked.

Not finished!

3) Advanced tab, click on "change system defaults".
4) Same screen as 1-2 appears but not quite. Again make sure your profile is there and marked as default.
5) Advanced tab selected again on this one, this time check ON "Use Windows display calibration".
6) Close and reboot.

That item 5 should make the profile apply to the entire system not just applications that natively know how to work with profiles.

shaolin95
18th July 2023, 01:37
Guys!
For an Nvidia 3070, which drivers can be patched for 3D and which option are you using to do such patching?
I want to try 3D again from my HTPC with MPC
Thanks

SirMaster
18th July 2023, 15:46
This is wrong.
I have a display profile and night view works globally for all desktop and application windows. It also works for D3D11 exclusive full screen (MPC VR).
Display profile and night view does not work for D3D9 exclusive full screen.

It isn't wrong.

You are getting only a vcgt (3x1dlut) which is normally embedded in a display profile. This works in most places because it's loaded into the video card gamma table and applies outside applications.

But you are not getting color correction (the 3dlut part) unless the application you are using is reading the profile data and adjusting its output to match the profile.

But then as you have seen, even some applications over-ride or reset the vcgt and you don't even get that part in some cases.


But a 3x1dlut is only correcting gamma and grayscale balance. It is not correcting colors like a 3dlut does.

v0lt
19th July 2023, 04:34
But a 3x1dlut is only correcting gamma and grayscale balance. It is not correcting colors like a 3dlut does.
In Windows, it is possible to control each channel individually. See DrvIcmSetDeviceGammaRamp (https://learn.microsoft.com/en-us/windows/win32/api/winddi/nf-winddi-drvicmsetdevicegammaramp) function and GAMMARAMP (https://learn.microsoft.com/en-us/windows/win32/api/winddi/ns-winddi-gammaramp) structure. Therefore, colors can be changed. Maybe not in the way you want, but it's more than "only correcting gamma and grayscale balance".

Similar functionality exists in IDirect3DDevice9::SetGammaRamp (https://learn.microsoft.com/en-us/windows/win32/api/d3d9/nf-d3d9-idirect3ddevice9-setgammaramp) method and IDXGIOutput::SetGammaControl (https://learn.microsoft.com/ru-ru/windows/win32/api/dxgi/nf-dxgi-idxgioutput-setgammacontrol) method.

Always remember that you or other people can create a fork (https://github.com/Aleksoid1978/VideoRenderer/forks) and add the functionality you need.

Aleksoid1978
19th July 2023, 10:16
If someone wants to add functionality - please write code, create a pull request, we'll see :)

SirMaster
19th July 2023, 15:04
In Windows, it is possible to control each channel individually. See DrvIcmSetDeviceGammaRamp (https://learn.microsoft.com/en-us/windows/win32/api/winddi/nf-winddi-drvicmsetdevicegammaramp) function and GAMMARAMP (https://learn.microsoft.com/en-us/windows/win32/api/winddi/ns-winddi-gammaramp) structure. Therefore, colors can be changed. Maybe not in the way you want, but it's more than "only correcting gamma and grayscale balance".

Similar functionality exists in IDirect3DDevice9::SetGammaRamp (https://learn.microsoft.com/en-us/windows/win32/api/d3d9/nf-d3d9-idirect3ddevice9-setgammaramp) method and IDXGIOutput::SetGammaControl (https://learn.microsoft.com/ru-ru/windows/win32/api/dxgi/nf-dxgi-idxgioutput-setgammacontrol) method.

Always remember that you or other people can create a fork (https://github.com/Aleksoid1978/VideoRenderer/forks) and add the functionality you need.


Everything you linked is only gamma and grayscale adjustment via 3-color gamma ramps.

Explain how you can adjust a small, specific area of a shade of red in either hue, saturation, or lightness for example without it affecting your grayscale balance with any of those gamma ramp functions.

Again, we are talking about an .icc profile. The only data used widely from an .icc profile is the 3x1dlut (3 gamma ramps) which is extremely limited in terms of actual color calibration compared to the rest of the data in the display profile which is only read and used by color-managed applications which then apply a 3dlut based on that profile.

I guess my point is that I can already do a 3x1dlut in vcgt without a .icc profile and have it apply to most things, which is fine. But using a .icc profile doesn't offer any advantages beyond that for apps that are not color managed and actually using that .icc profile.

v0lt
19th July 2023, 18:56
@SirMaster
OK. I've never needed it. I will advise you to use madVR or another suitable tool.

SirMaster
20th July 2023, 14:39
I don't need anything, and I do use madVR.

I was merely trying to clarifying the capabilities and limitations of a .icc profile on Windows.

I commonly see people think it's essentially a 3DLUT (a full color correction) at a whole system level.

butterw2
20th July 2023, 16:18
Shader cache dir ?

1. Does mpc-be save compiled shaders to disk cache ? I know Mpc-hc has an option for this (in portable mode with evr-cp a shadercache folder is created with persistent .cso files).
2. Does mpc-vr cache compiled shaders to disk ?

v0lt
20th July 2023, 17:35
1. Does mpc-be save compiled shaders to disk cache ?
No.
2. Does mpc-vr cache compiled shaders to disk ?
No.

kirakami
22nd July 2023, 23:52
MPC Video Renderer sometimes crashes if you repeatedly go back and forth quickly between windowed mode and full screen mode with Alt + Enter (I have fullscreen w/o res.change hotkey set to F). It only happens sometimes and only crashes when you intentionally quickly switch between windowed mode and full screen mode. Video becomes black screen while audio continues playing, subtitles also stop showing. Happens with any .mkv file with embedded .ass subtitles with AVC encoded video and AAC encoded audio. On latest version of MVR 0.6.7.2013. Restarting MPC-BE 1.6.8.5 fixes it. Its probably a small bug in MVR.

Aleksoid1978
23rd July 2023, 00:44
Why quickly and many times switch to full screen and back ? :)

kirakami
23rd July 2023, 10:51
Not many times, only few times mostly. MVR crash happened when i was checking for video duration at bottom right of MPC-BE and was switching between windowed and full screen mode quickly for few times. I often tend to switch to windowed mode to check video duration before quickly switching back to full screen mode again, which results in me accidentally crashing MVR sometimes, turning video into black screen. Then to induce crash intentionally i switched between windowed and full screen mode even quickly, which didn't crash MVR but after watching video for a while and repeating switching between windowed and full screen mode quickly for few times it crashed.

thrawnrulz68
27th July 2023, 04:36
Does anyone use the "Save As" function in the File menu in order to save YouTube or other online video?

For me, it downloads very slowly. Also, sometimes, it will download separate audio and video files rather than one single file (example: https://www.youtube.com/watch?v=AWRnRXAiHe0). Is it possible to make it download only one file always?

In rare instances, I cannot get it to download the video at all (example: https://vimeo.com/253519132).

I experience these problems whether the built-in web page parser is enabled or if I am exclusively using yt-dlp. Anyone else?

Aleksoid1978
27th July 2023, 06:57
I'm doing great with https://www.youtube.com/watch?v=AWRnRXAiHe0 - both playback and download are fast.
I use the built-in Youtube parser.

https://vimeo.com/253519132 - the same, using yt-dlp.

thrawnrulz68
27th July 2023, 13:47
Is https://www.youtube.com/watch?v=AWRnRXAiHe0 downloading as one file or separate .mp4 and .m4a files? For me, it's still downloading two files. Is there a setting that I may need to change?

v0lt
27th July 2023, 14:50
@thrawnrulz68
Navigate -> Jump to -> select any non dash format

thrawnrulz68
28th July 2023, 05:03
Good trick v0lt! That worked!

Shark007
31st July 2023, 10:35
Dolby Vision support in the MPC Video Renderer is confirmed to be working. Thanks alot!

Aleksoid1978
31st July 2023, 13:27
Dolby Vision support in the MPC Video Renderer is confirmed to be working. Thanks alot!

We know :)

Klaus1189
31st July 2023, 17:10
@devs: Thank you for all your effort :)

ryrynz
31st July 2023, 20:50
Meaning it passes through or it displays the HDR10 base layer?

huhn
31st July 2023, 21:31
as far as i know it converts to HDR10 it's not the base layer. i also know that it was a 3D LUT in the past and is now basic math.

i'm not even sure if there is an API to even send dovi on PC.
the release notes will tell us.

Aleksoid1978
1st August 2023, 00:58
Dolby Vision convert to BT.2020 + PQ.
If display in HDR mode - it passes through as HDR, if SDR mode - convert to SDR.

ryrynz
1st August 2023, 05:40
Would Dolby Vision be preferred over HDR10 after conversion or is it much of a muchness? will probably do my own test..

Might have to wait a year or two for passthrough [emoji30]

Aleksoid1978
1st August 2023, 08:47
Would Dolby Vision be preferred over HDR10 after conversion or is it much of a muchness? will probably do my own test..

Might have to wait a year or two for passthrough [emoji30]

You can compare on any video with HDR+DV - how it looks with Dolby Vision support and without, better test on DX11, DX9 have some limitation about DV support.

Here is some sample - https://disk.yandex.ru/d/KHeXAEn4X6TAuQ
Sample.mp4 - the difference is visible, the second sample - there is no difference at all.

Alexkral
1st August 2023, 12:17
Does MPC Video Renderer support passthrough of the DV metadata?

Does MPC Video Renderer support DV metadata processing for tone mapping?

If not, I'm really confused about the meaning of "support" in this context, and this isn't the only place I've seen it.

Aleksoid1978
1st August 2023, 13:42
MPC Video Renderer use DV metadata processing for tone mapping to convert to BT.2020 + PQ, support Profiles 5 and 8.x
Windows don't support passthrough of the DV metadata.

Alexkral
1st August 2023, 15:17
Ok, I see that mpv also supports profile 5, but the meaning of this is still unclear.

DV profile 5 is already BT.2020 + PQ, so I guess what both programs are doing is somehow converting the DV/SMPTE ST 2094-10 metadata to HDR10+/SMPTE ST 2094-40 metadata, and then maybe doing dynamic tone mapping with it as specified in SMPTE ST 2094-40.

For this, even if it is free, one would still supposedly need an HDR10+ license.

What I would consider as real support, would be to use the DV metadata for tone mapping as specified in SMPTE ST 2094-10.

Correct me if I'm wrong.

SeeMoreDigital
1st August 2023, 17:30
Ok, I see that mpv also supports profile 5, but the meaning of this is still unclear.

DV profile 5 is already BT.2020 + PQ, so I guess what both programs are doing is somehow converting the DV/SMPTE ST 2094-10 metadata to HDR10+/SMPTE ST 2094-40 metadata, and then maybe doing dynamic tone mapping with it as specified in SMPTE ST 2094-40.

For this, even if it is free, one would still supposedly need an HDR10+ license.

What I would consider as real support, would be to use the DV metadata for tone mapping as specified in SMPTE ST 2094-10.

Correct me if I'm wrong.Out of interest... What make and model of monitor/TV are you using to view the Dolby Vision content?

Alexkral
1st August 2023, 18:09
None, my TV doesn't support it and I don't have content either, just trying to understand.

Enet47
1st August 2023, 22:40
MPC Video Renderer use DV metadata processing for tone mapping to convert to BT.2020 + PQ, support Profiles 5 and 8.x
Windows don't support passthrough of the DV metadata.
Great job :) I just had a look at a couple of Dolby Vision movies with mpc-be and compared it to the latest mpv+ffmpeg build and it works quite nicely. Does you implementation hard clip at 1000 nits? Not a criticism, I just noticed a difference and was curious.

Aleksoid1978
1st August 2023, 23:24
Great job :) Does you implementation hard clip at 1000 nits?
If you are talking about HDR Passthrough for DV video - yes.

P.S. Remade, now Mastering display luminance parameters are taken (calculated) from DoVi metadata. As far as I could check it is usually 3999 nits, and 1000 nits on HLG+DV video.

Shark007
2nd August 2023, 03:28
To confirm, it reported 1000 in the past (and to say thanks again)

https://i.postimg.cc/3k9C23Mz/3.jpg (https://postimg.cc/3k9C23Mz)

thrawnrulz68
4th August 2023, 13:00
Does anyone have any suggestions on how to download this video?:

https://vimeo.com/12293575

There are many possible streams listed when using yt-dlp but the player only saves very small unplayable files...

Aleksoid1978
4th August 2023, 13:35
Because there DASH videos are just links to text files with stream descriptions and so on. Built-in filters do not open this - it opens only LAV. This is the file that is saved.

SirMaster
4th August 2023, 15:50
Does anyone have any suggestions on how to download this video?:

https://vimeo.com/12293575

There are many possible streams listed when using yt-dlp but the player only saves very small unplayable files...

I am confused by your question exactly.

yt-dlp downloads this video just fine.

v0lt
4th August 2023, 16:58
Does anyone have any suggestions on how to download this video?:
Try using special tools to download streaming videos.

hajj_3
5th August 2023, 14:14
Does anyone have any suggestions on how to download this video?:

https://vimeo.com/12293575



https://chrome.google.com/webstore/detail/video-downloader-professi/elicpjhcidhpjomhibiffojpinpmmpil

thrawnrulz68
5th August 2023, 22:14
I am confused by your question exactly.

yt-dlp downloads this video just fine.

Yt-dlp within MPC-BE will not download it for me. Oh well

v0lt
7th August 2023, 05:15
MPC Video Renderer 0.6.9.2117 (https://github.com/Aleksoid1978/VideoRenderer/releases/tag/0.6.9)

Changes:
Added partial support for Dolby Vision (Profiles 5, 8.1, 8.4 are supported).
Added "Prefer Dolby Vision over PQ and HLG" option for compatible Dolby Vision formats.
Recommended version of MPC-BE 1.6.8.24 or later.

angmav
8th August 2023, 11:51
MPC Video Renderer 0.6.9.2117 (https://github.com/Aleksoid1978/VideoRenderer/releases/tag/0.6.9)

Changes:
Added partial support for Dolby Vision (Profiles 5, 8.1, 8.4 are supported).
Added "Prefer Dolby Vision over PQ and HLG" option for compatible Dolby Vision formats.
Recommended version of MPC-BE 1.6.8.24 or later.


Can i ask what is meant by dolby vision support?


Sent from my iPhone using Tapatalk

Aleksoid1978
8th August 2023, 12:54
Can i ask what is meant by dolby vision support?


Open any Dolby Vision video, better Profile 5, and see.
Samples:
https://4kmedia.org/lg-amaze-dolby-vision-uhd-4k-demo
https://mega.nz/file/2TYwVSTZ#LBh2CoX3QUfkR_kwey_aim9QWvwk3UpLQozEG9n2ww0

v0lt
8th August 2023, 14:34
Can i ask what is meant by dolby vision support?
Picture for comparison.
https://i.ibb.co/0JDRpbv/dovi-profile5-support.jpg (https://ibb.co/0JDRpbv)

If you need more complete support, then buy Dolby certified devices.

Siso
8th August 2023, 16:02
Is there any way to enable color management for mpc video renderer?

JaylumX
8th August 2023, 16:56
Picture for comparison.
https://i.ibb.co/0JDRpbv/dovi-profile5-support.jpg (https://ibb.co/0JDRpbv)

If you need more complete support, then buy Dolby certified devices.

Funny you should mention that as that video does not initiate HDR processing for me. It recognises the Dolby Vision metadata but does not process it in HDR. Unless I am doing something wrong.

The Dolby Vision videos that worked for me had profile 8.1 in the file name.

v0lt
8th August 2023, 20:25
Is there any way to enable color management for mpc video renderer?
No. This is a feature of the built-in EVR-CP.

The Dolby Vision videos that worked for me had profile 8.1 in the file name.
Dolby Vision Profile 8.1 is an HDR10 compatible format. These formats do not require the mandatory support of Dolby Vision. Such video can be viewed by the EVR-CP renderer built into the MPC-BE.