Media Player Classic - BE Win32/x64

[ryrynz]

One feature request: can you make the OSD white color dimmer (e.g. 50% or even less?) with HDR10 output? (It just burns yours eyes out now :) )


A different transparency setting for HDR would be nice, but you can already change transparency with the OSD so give it a shot.

[Aleksoid1978]

only HLG as sdr has wrong colorspace now.

HLG a little darker then HDR10, compare:
https://i.imgur.com/O4pCNLD.png
This is much better than it was :)

[huhn]

i will check these details later.

i'm talking about rendering bt 20920 as bt 709 the colors are washed out. that'S not a problem with tonemap or passthrough.

[Aleksoid1978]

i will check these details later.

i'm talking about rendering bt 2020 as bt 709 the colors are washed out. that'S not a problem with tonemap or passthrough.

Rendering as bt.709 - rendering as is. I don't know what can do.

[huhn]

it's bt2020
you have to run this filter:
https://github.com/Aleksoid1978/VideoRenderer/blob/master/Shaders/convert/colorspace_gamut_conversion.hlsl#L87

float3 Colorspace_Gamut_Conversion_2020_to_709(const float3 rgb)
{
return mul(convert_matrix_2020_to_709, rgb);
}

[Aleksoid1978]

Ok - i will check later.

[Aleksoid1978]

it's bt2020
you have to run this filter:
https://github.com/Aleksoid1978/VideoRenderer/blob/master/Shaders/convert/colorspace_gamut_conversion.hlsl#L87

float3 Colorspace_Gamut_Conversion_2020_to_709(const float3 rgb)
{
return mul(convert_matrix_2020_to_709, rgb);
}

I do for testing, check and compare:
SDR - https://i.imgur.com/GtYNWzs.png
HDR to SDR - https://i.imgur.com/Y82jKyB.png
HLG to SDR - https://i.imgur.com/IAQqCph.jpg
HLG bt.202 to bt.709 - https://i.imgur.com/l99tCrd.jpg

[huhn]

sorry i don't know what the xbox screenshoot function does so i can't judge screen shoots for HDR.

but i can do this for you
SDR madVR: https://abload.de/img/madvrmsk9y.jpg
SDR mpcVR: https://abload.de/img/mpcvr7hj57.jpg
so your new HLG bt.2020 to bt.709 doesn't seem to work correctly.

the madVR results is AFAIK correct for a SDR display.
SDR is BT709 (sRGB)

what madVR is doing is simple in theory.
it read the primary and then it compares it to the calibration setting.
if no calibration setting is set it defaults to BT 709 for SDR and BT 2020 for HDR passthrough.

if the primary is not matching with the "calibration setting" it will make it match. so in this case it sees BT 2020 from the file and it applies bt 2020 to bt 709 because of SDR.
your HDR -> SDR tonemapping does this too.

BT709 and sRGB are not 100 % the same but you can skip this topic no one really calibrates to sRGB(to those that do don't feel offended plz there are reasons to do that) but to BT709 they are very similar to.
sorry it's calibration is sadly never easy...

BTW. you could force HLG to SDR tonemapping it's "better" anyway.
HLG SDR with bt 2020 to bt 709 is more of compatibility thing it looks bad but that's how it should looks on a SDR screen...

[v0lt]

Expert help required.

MFVideoTransferMatrix (https://docs.microsoft.com/en-us/windows/win32/api/mfobjects/ne-mfobjects-mfvideotransfermatrix)
AVColorSpace (https://github.com/FFmpeg/FFmpeg/blob/release/4.3/libavutil/pixfmt.h#L509)
zimg_matrix_coefficients_e ([url]https://github.com/sekrit-twc/zimg/blob/v3.0/src/zimg/api/zimg.h#L279)
Let's look at the parameters for BT.2020:
MFVideoTransferMatrix_BT2020_10
MFVideoTransferMatrix_BT2020_12

AVCOL_SPC_BT2020_NCL
AVCOL_SPC_BT2020_CL

ZIMG_MATRIX_BT2020_NCL
ZIMG_MATRIX_BT2020_CL
How do I correctly map MFVideoTransferMatrix to AVColorSpace (or zimg_matrix_coefficients_e)?

MFVideoTransferFunction (https://docs.microsoft.com/en-us/windows/win32/api/mfobjects/ne-mfobjects-mfvideotransferfunction)
AVColorTransferCharacteristic (https://github.com/FFmpeg/FFmpeg/blob/release/4.3/libavutil/pixfmt.h#L480)
zimg_transfer_characteristics_e (https://github.com/sekrit-twc/zimg/blob/v3.0/src/zimg/api/zimg.h#L302)
Let's look at the parameters for BT.2020:
MFVideoTransFunc_2020_const
MFVideoTransFunc_2020

AVCOL_TRC_BT2020_10
AVCOL_TRC_BT2020_12

ZIMG_TRANSFER_BT2020_10
ZIMG_TRANSFER_BT2020_12
How do I correctly map MFVideoTransferFunction to AVColorTransferCharacteristic (or zimg_transfer_characteristics_e)?

MicroSoft confused TransferMatrix and TransferFunction?

[Aleksoid1978]

sorry i don't know what the xbox screenshoot function does so i can't judge screen shoots for HDR.

but i can do this for you
SDR madVR: https://abload.de/img/madvrmsk9y.jpg
SDR mpcVR: https://abload.de/img/mpcvr7hj57.jpg
so your new HLG bt.2020 to bt.709 doesn't seem to work correctly.

the madVR results is AFAIK correct for a SDR display.
SDR is BT709 (sRGB)

what madVR is doing is simple in theory.
it read the primary and then it compares it to the calibration setting.
if no calibration setting is set it defaults to BT 709 for SDR and BT 2020 for HDR passthrough.

if the primary is not matching with the "calibration setting" it will make it match. so in this case it sees BT 2020 from the file and it applies bt 2020 to bt 709 because of SDR.
your HDR -> SDR tonemapping does this too.

BT709 and sRGB are not 100 % the same but you can skip this topic no one really calibrates to sRGB(to those that do don't feel offended plz there are reasons to do that) but to BT709 they are very similar to.
sorry it's calibration is sadly never easy...

BTW. you could force HLG to SDR tonemapping it's "better" anyway.
HLG SDR with bt 2020 to bt 709 is more of compatibility thing it looks bad but that's how it should looks on a SDR screen...
You need compare with my screenshot, in current version of MPC VR no bt.2020 to bt.709 conversion.

[huhn]

this https://i.imgur.com/l99tCrd.jpg is not correct sdr bt 709. it should look like this: https://abload.de/img/madvrmsk9y.jpg

just take the red in the top left corner.
for HDR -> SDR tone mapping there is a lot of freedom i can't 100 % say it wrong or right.
even the source doesn't seem to be mastered in a way that they should look alike:
it say in HDR10 M03 750 nits
it says in HLG M03 75% grey.
i don't know what 75% grey means is it a linear image that would be 750 nits.
HLG 75% of 1024 range ~767 that's not 750 nits.

HLG as HDR seems fine
HDR passthrough seems fine
both tone mapping of HLG and HDR 10 seems fine
but HLG SDR bt2020 to bt709 is obviously wrong even in your new screenshoot.

@volt they all 3 seem to be the same.
and that'S all i can provide i don't know the difference between bt2020_10 and bt2020_12 same for MFVideoTransFunc_2020_const MFVideoTransFunc_2020.

[chros]

And doesn't mpc-be internal video decoder support d3d11-native using hevc? Only dxva2-copyback?

Only DXVA2 Native :)
I just noticed that I have brutal :) tearing with:
- LAV Video set to d3d11-native
- mpcVR set to "Use Derect3D 11" and Swap effect is set to "Flip" (there's with "Discard" as well, but not that brutal)

Now, if I set one of the following the tearing goes away:
- LAV Video set to d3d11-copyback
- uncheck "Use Derect3D 11" in mpcVR (LAV Video falls back to d3d11-copyback)

Does it mean that mpcVR doesn't support d3d11-native at all? I haven't noticed this before ...

[Klaus1189]

I just tried EVR CP Renderer again after long time and I don't know which settings I need to get rid of these stutters, which are also protocolled by EVR stats graph. I does't matter if I use internal filters or LAV Filters. Tried to disable DXVA2 and tried various DXVA2 settings of LAV. I also tried different renderer settings and VSync options. But no luck.
https://drive.google.com/file/d/1hec2gGxTSbgfVhSUxQ8_9LGOa8wSv31H/view?usp=sharing

I did some more testing and I have created a videofile without audio, so copyright should not be an issue.

Just play this 60p file with CVR custom and stock settings and you will get this jerky playback. I checkd EVR cutom statictics in Filters menu and it reports a lot of dropped frames. If I did something wrong, please let me know what settings I need to tweak.
I must add I am on a Nvidia RTX30 card now. But AMD RX 5700XT is still here.

https://drive.google.com/file/d/1pDjxPlJi95wn8tUm9loldiymjh6tnn6A/view?usp=sharing

[v0lt]

I just noticed that I have brutal :) tearing with:
- LAV Video set to d3d11-native
- mpcVR set to "Use Derect3D 11" and Swap effect is set to "Flip" (there's with "Discard" as well, but not that brutal)

Now, if I set one of the following the tearing goes away:
- LAV Video set to d3d11-copyback
- uncheck "Use Derect3D 11" in mpcVR (LAV Video falls back to d3d11-copyback)
Tearing (https://commons.wikimedia.org/wiki/File:Tearing_(simulated).jpg)?

[v0lt]

Just play this 60p file with CVR custom and stock settings and you will get this jerky playback. I checkd EVR cutom statictics in Filters menu and it reports a lot of dropped frames. If I did something wrong, please let me know what settings I need to tweak.
I must add I am on a Nvidia RTX30 card now. But AMD RX 5700XT is still here.
I did not notice any major problems with this video (although it seemed to me that the graph is moving smoothly). Perhaps a larger display is needed.

I can advise you to check the "Video" and "Frame synchronization" settings, as well as make a frame with active statistics (Ctrl+J). You can also try turning VSync (V) on/off and using the exclusive full screen.

[Klaus1189]

Statistics (Ctrl+J) show that frames are dropped. I also tried all possible combinations of VSync options built into MPC-BE. While playing back the file I rightclick menu and open filter list and click on CVR CP and then on the second it lists the dropped frames which grow fast.

If I turn on Tearing Test and use it for "smooth test" and you can clearly see that I get dropped frames because the double red line jumps during that drop.

I tried madVR and also MPC Video Renderer. Both are fine to my eyes and also no dropped frames are reported. So I encounter that issue only on EVR CP. I want that basic renderer be also fine.

I created a second sample file, which is now AVC, but also 60p. Also here Audio removed for copyright issues:
https://drive.google.com/file/d/1orp4XopuYyjrkNTfzfSUfYNFsyBCaNq-/view?usp=sharing

[Klaus1189]

Updated german translation (https://drive.google.com/file/d/1NwBzp70DqbsN-NeKUsrorOgUedPyb_nu/view?usp=sharing) - little cosmetic change: more consistent

[chros]

Tearing (https://commons.wikimedia.org/wiki/File:Tearing_(simulated).jpg)?
Yes, and brutal stuttering as well even with SDR (1080p/2160p) content :)

Here's the interesting part: it works fine at 59Hz!!! (even with 23p/25p videos)
Issue happens if I set the TV (in Windows adapter settings) to:
- 23Hz with 23p video
- 25Hz with 25p video

I have 2 displays connected to the HTPC:
- monitor via DVI (only supports 60Hz, so I can't try it on this)
- TV via HDMI (supports 23/24/25/29/30/50/59/60Hz)

Something is not right. And as I said this only happens when Lav Video is set to d3d11-native and d3d11 output is enabled in mpcVR (more visible with "Flip" presentation).

[Aleksoid1978]

Yes, and brutal stuttering as well even with SDR (1080p/2160p) content :)

Here's the interesting part: it works fine at 59Hz!!! (even with 23p/25p videos)
Issue happens if I set the TV (in Windows adapter settings) to:
- 23Hz with 23p video
- 25Hz with 25p video

I have 2 displays connected to the HTPC:
- monitor via DVI (only supports 60Hz, so I can't try it on this)
- TV via HDMI (supports 23/24/25/29/30/50/59/60Hz)

Something is not right. And as I said this only happens when Lav Video is set to d3d11-native and d3d11 output is enabled in mpcVR (more visible with "Flip" presentation).

Can you record video with statistics ?
Do you try in fullscreen exclusive ?

[Aleksoid1978]

Statistics (Ctrl+J) show that frames are dropped. I also tried all possible combinations of VSync options built into MPC-BE. While playing back the file I rightclick menu and open filter list and click on CVR CP and then on the second it lists the dropped frames which grow fast.

If I turn on Tearing Test and use it for "smooth test" and you can clearly see that I get dropped frames because the double red line jumps during that drop.

I tried madVR and also MPC Video Renderer. Both are fine to my eyes and also no dropped frames are reported. So I encounter that issue only on EVR CP. I want that basic renderer be also fine.

I created a second sample file, which is now AVC, but also 60p. Also here Audio removed for copyright issues:
https://drive.google.com/file/d/1orp4XopuYyjrkNTfzfSUfYNFsyBCaNq-/view?usp=sharing

Check you video - perfect playback(test in window and fullscreen exclusive).

P.S. Try reset settings, try in fullscreen exclusive.

[Aleksoid1978]

this https://i.imgur.com/l99tCrd.jpg is not correct sdr bt 709. it should look like this: https://abload.de/img/madvrmsk9y.jpg

just take the red in the top left corner.
for HDR -> SDR tone mapping there is a lot of freedom i can't 100 % say it wrong or right.
even the source doesn't seem to be mastered in a way that they should look alike:
it say in HDR10 M03 750 nits
it says in HLG M03 75% grey.
i don't know what 75% grey means is it a linear image that would be 750 nits.
HLG 75% of 1024 range ~767 that's not 750 nits.

HLG as HDR seems fine
HDR passthrough seems fine
both tone mapping of HLG and HDR 10 seems fine
but HLG SDR bt2020 to bt709 is obviously wrong even in your new screenshoot.


Ok, so my algorithm is inaccurate or incomplete.

[v0lt]

MPCVideoRenderer-v0.4.10.1553_git2020.12.18-73a6d82 (https://yadi.sk/d/X0EVMKP4TcmnHQ)

I am thinking of removing the "Convert to SDR" feature for HLG. It gives practically nothing. HLG is compatible with SDR displays.

added:
mpcvr_1553_hdr_stats_1 (https://yadi.sk/d/s6NBGGdFiSm_3A?w=1)
Test build with dimmed statistics for displays in HDR mode.

[VictorLS]

I am thinking of removing the "Convert to SDR" feature for HLG. It gives practically nothing. HLG is compatible with SDR displays.
I like to switch off "Convert to SDR" to test how looks HLG video on my SDR monitor without any processing with MPC Video Renderer avoiding switching to i.e. ordinary EVR.

[huhn]

MPCVideoRenderer-v0.4.10.1553_git2020.12.18-73a6d82 (https://yadi.sk/d/X0EVMKP4TcmnHQ)

I am thinking of removing the "Convert to SDR" feature for HLG. It gives practically nothing. HLG is compatible with SDR displays.

added:
mpcvr_1553_hdr_stats_1 (https://yadi.sk/d/s6NBGGdFiSm_3A?w=1)
Test build with dimmed statistics for displays in HDR mode.

while you are 100 % correct that HLG can be watched with SDR but is not really correct it's just a fallback with tone mapping more of the HLG range can be shown accurately just like HDR. the problem is currently there is no selection for the peak brightness.
the calibrated peak brightness for SDR is 100/120 depending on who you ask while screens in SDR mode are often far over that that's why madVR has a control over the brightness you define that here (i guess):
#define DISPLAY_LUMINANCE_PEAK 125.0
https://github.com/Aleksoid1978/VideoRenderer/blob/master/Shaders/convert/convert_pq_to_sdr.hlsl

i have no clue if your algorithm is able to deal correctly with higher peak brightness but madVR defaults to 200 and it's worth a try.

[clsid]

If you do allow a higher target nit value, then please make it an configurable option.
There are a lot of people who have set their screen to a much lower brightness that its maximum. In that case 200 nits gives a too dark result.
It could be a simple dropdown with values 100/125/150/175/200.

[huhn]

leave it at 100/120 or make it an option.

the usually user has a guessed brightness range of 100-400. the 400 nits user should be pretty rare in comparison to a 200 nits user.

[chros]

Can you record video with statistics ?
Do you try in fullscreen exclusive ?
Same with fullscreen exclusive. There's nothing on the stats screen.
But I could recreate it on my monitor as well:
it seems the problem only occurs when fps = display Hz or really close to it (59p on 60Hz)!
So, to try to reproduce it, play back:
- 1080p/2160p 59p SDR video on monitor @ 60Hz
- set LAV Video to d3d11 native (not copyback)
- set mpcVR to d3d11 and set Flip presentation
- it happens in window or fullscreen too

Can anyone reproduce this crazy stutter?

[chros]

If I set Vertical Sync only to "Fast" in nvidia control panel the problem seems to go away and it works on TV and monitor as well. (None of the other vsync values help.)
- nvidia says about Fast: "GPU renders unconstrained similar to VSYNC OFF, but does not tear since frames in excess of the refresh rate of the monitor are dropped. Delivers latency that is very close to VSYNC off with no tearing"
- from this reddit post (https://www.reddit.com/r/nvidia/comments/4jsj9j/so_what_is_the_difference_between_fast_sync_and/): "FAST-SYNC - De-coupled rendering and monitor refresh. VSYNC OFF but the monitor will only render completely rendered frames, thus eliminating tearing (MINOR input lag but NO TEARING! ) also it is monitor agnostic so it will work with any screen. It is analogous to hardware triple buffering but does not back-pressure the render pipeline."

I have never used this option, it was always on "Use the 3D application setting", so I don't know what affect it has with e.g. madvr.
But from this it's clear that it's some kind of timing issue with those settings.

Edit: yep, Fast vsync produces tearing with madvr, so it's not a solution :)

[chros]

added:
mpcvr_1553_hdr_stats_1 (https://yadi.sk/d/s6NBGGdFiSm_3A?w=1)
Test build with dimmed statistics for displays in HDR mode.
Thanks, if it's dimmer then only a bit, we need more :) (with >=700 nits).

About HLG2HDR10: there's something weird with near black colors, can you test with these (https://bbs.io-tech.fi/attachments/blackpluge-test-patterns-zip.406872/)?
- BlackPLUGE-U4K_HDR10.mp4 : this one looks allright
- BlackPLUGE-U4K_HLG10.mp4 : the vertical bars are greenish

What do you think?

[P.J]

The aspect ratio of this 16:9 video is wrong in MPC-BE: :confused:
https://drive.google.com/file/d/1fYOOlXUJUprLzOTyUTfrkTPDPL0p6zHW/view?usp=sharing

[v0lt]

About HLG2HDR10: there's something weird with near black colors, can you test with these (https://bbs.io-tech.fi/attachments/blackpluge-test-patterns-zip.406872/)?
- BlackPLUGE-U4K_HDR10.mp4 : this one looks allright
- BlackPLUGE-U4K_HLG10.mp4 : the vertical bars are greenish

What do you think?
Disable NV12 and P010 for DXVA and D3D11 VP.
DXVA and D3D11 VP do not work properly with full range in input. Only driver settings work and application settings can be ignored. And this behavior can be different for different vendors and driver versions.

@P.J
Does QuickTime play correctly?
Fixed in r5827.

[Klaus1189]

I think it would be better to swap increase and decrease. Normally increase is on position 1 and decrease is in position 2. See here:
https://drive.google.com/file/d/121GrI1cltoAxk4bs0d-tjZpyKHiKz6kn/view?usp=sharing
Like Pan&Scan options, see here:
https://drive.google.com/file/d/1YyhW-m7tv6n07IsbcRQ_Naw_MXHsk_GI/view?usp=sharing

[P.J]

@P.J
Does QuickTime play correctly?
Fixed in r5827.

Yes, it's 16:9 in QuickTime.
:thanks:

[v0lt]

MPC Video Renderer 0.5.0.1567 (https://github.com/Aleksoid1978/VideoRenderer/releases/tag/0.5.0)
Description (https://github.com/Aleksoid1978/VideoRenderer/blob/0.5.0/Readme.md)

[P.J]

Sometimes when I check different videos quickly, I get this error:

[Klaus1189]

Please upload to google drive or similar, we cannot open the file

[s0meone_new]

The width is not good
1136 STRING IDS_AG_FULLSCREEN_2 "Teljes képernyő (felbontás módosítása nélkül)"

The width of the visible text must be changed. Only this is visible: Teljes képernyő (felbontás módosítása n

left button - click:
727 101 "&Lejátszás/Szünet"
and the other setting? no text, you don't have to be there ---?

double click, it is empty here too

[Klaus1189]

Updated german translation (https://drive.google.com/file/d/1NwBzp70DqbsN-NeKUsrorOgUedPyb_nu/view?usp=sharing) based on r5846 :)

I can confirm @s0meone_new that r5843 leads to cut off text also in german translation:
STRING IDS_AG_FULLSCREEN_2 "Vollbild (ohne Änderung des Anzeigemodus)"
"modus)" is cut off from it
I made a screenshot:
https://drive.google.com/file/d/1bgft4BETXWTibSXjnAGMyFaeIkgbuu69/view?usp=sharing

I beg to increase this dropdown list, probably also the other dropdown lists of the mouse page, so it looks good overall.

@s0meone_new:
The devs changed it from "---" to "" in a recent commit. I like it better now.

@devs:
Huge THANK YOU for all your work in your projects, I really appreciate it ;)

[s0meone_new]

Hungarian translation updated (Pan&Scan):
https://www22.zippyshare.com/v/iwIJOtV6/file.html


Klaus1189:
@s0meone_new:
The devs changed it from "---" to "" in a recent commit. I like it better now.


Some text there would be good:
eg: none or whatever. That would be better than nothing: ---

[Klaus1189]

Some text there would be good:
eg: none or whatever

It is already none here (-> no text) therefore you don't see it. Joke aside, I think it is fine. If the user wants to disable a specific button, (s)he just selects the one with no text.
I think it looks very clean. I like it that way.

[s0meone_new]

It seems to someone that the text was accidentally omitted.

[Klaus1189]

It seems to someone that the text was accidentally omitted.

I don't think so. Just think about it as it were the Keyboard buttons:
https://drive.google.com/file/d/1otw9A8n9xlr37bM9e2v6gU5jC3PC6kwa/view?usp=sharing

If one action isn't assigned to a key, there is also no text there. Same style ... clean style, which I do like very much, but I repeat myself ;)

[s0meone_new]

That style doesn’t fit there (in vain do you like emptiness).

[Klaus1189]

Sure it does. Emptiness looks clean :)

[s0meone_new]

It is not a plate or glass. Many users may not understand. I'm closing the conversation about this.

[v0lt]

s0meone_new, Klaus1189
Thanks. Fixed and updated in r5847+r5848.

[wushantao]

https://fil.email/Omsl8CBO

Simplified Chinese update：）

[cmhrky]

Updated Turkish (https://www107.zippyshare.com/v/8FZjvLmo/file.html) language file basen on r5852.

[P.J]

Sometimes when I check different videos quickly, I get this error:
Please upload to google drive or similar, we cannot open the file

https://i.imgur.com/fxRPfUm.png

[v0lt]

wushantao, cmhrky
Thanks. Updated in r5851 and r5854.

https://i.imgur.com/fxRPfUm.png
This is a known problem (https://mpc-be.org/forum/index.php?topic=599.0), but we have no solution.