Media Player Classic - BE Win32/x64

[nevcairiel]

If it's just a wrapper of RegQueryValueExW, the terminating NULL is not guaranteed (according to the docs), meaning that even if you zero-init the whole buffer and ERROR_SUCCESS is returned, buff might be still not NULL-terminated (in an unlikely situation where the stored string is not NULL-terminated and has exactly 256 characters). In reality, the version string should be much shorter, though.

CRegKey is part of ATL, which does ensure that the returned string is null-terminated, or it'll return with an error code.
It won't fix strings which were not null-terminated, but it won't just return them to you either. But while such registry entries are possible, they don't usually matter in such cases.

[Liisachan]

@nevcairiel
Thanks for clarification. I looked into it, and it returns ERROR_SUCCESS only if the string is null-terminated or empty (0-byte data will be fixed as a null-terminated empty string), so like you said memset is unnecessary (though harmless).

Happy new year everyone :D

[alex1399]

The windows always start with resolution 292x164 at this version 1.5.4 (build 4969). Neither the setting enable or disable can let it always full window.

[Aleksoid1978]

Happy New Year 2020 !!!

[JNW]

Gone forever. Use this https://yadi.sk/d/AjAXDDHtHRIELg

Aha. Just what I was looking for. Thank you.
:thanks:

Happy New Year all! :)

[beter]

Update for translation of Traditional Chinese and Dutch:
https://www.sendspace.com/file/g2a8by

[v0lt]

@cmhrky
Thanks. Updated in r4981.

@beter
Thanks. Updated in r4983.

[mclingo]

ive mentioned this before but there have been a few new version since but it still hasnt been fixed, or i'm doing something wrong. When I play a movie with a non english audio track listed as (01) it always plays this instead of the default i've set, i've tried both "eng" and "english", just doesnt work. Works fine in MPC-HC using LAV

EDIT- I think I might know what is causing this for me but there still might be a bug of sorts.

I recently reinstalled MPC-BE and forgot to set "eng" until today, however all the files i've already played with it blank still ignore this and files i hadnt yet played play fine, so I guess MPC-BE is saving the audio track information somewhere and using this as priority over the default setting.

Thinking about it, this actually makes sense :)

so its not a bug :)

[Liisachan]

ive mentioned this before but there have been a few new version since but it still hasnt been fixed, or i'm doing something wrong. When I play a movie with a non english audio track listed as (01) it always plays this instead of the default i've set, i've tried both "eng" and "english", just doesnt work. Works fine in MPC-HC using LAV
Speaking of which, I've always wanted to say, please support the standard ISO language codes, instead of "Example: eng jap swe". I know these examples are innocent, simply the first 3 letters of the language names, and they're practically fine and easier to understand for most people (so I guess it's fine they are supported). However, the official code for Japanese is jpn, and "jap" is generally considered as a racial slur in Japan for historical reasons, quite a few people feeling uncomfortable or offended to see it.

Also practically, the first-three-letter scheme could be bad for example Malay vs. Malayalam, Sindhi vs. Sinhalese. Not to be picky, just so you know there could be potential problems. Thanks :)

[v0lt]

Liisachan
You do not seem to know the history of this option. There is no code for the track language in the AVI files, not at all. In external srt, mp3 files there is also no code for the language. In many MKVs, the track language is recorded with a name, not a code. In general, your proposal can only complicate everything, we will leave everything as it is.

[Klaus1189]

@Devs: Can you please check this sample file with teletext subtitle here for a buddy of mine?
https://drive.google.com/file/d/13G0dzgvuACEW_epGqeYrm3uOgcw2XEHd/view?usp=sharing
At 00:23 there is I checked displayed, but there should be But he wont say what its on at the very following, but it isn't displayed according to my buddy.
Thanks in advance :)

[Aleksoid1978]

You checked Display at 00:23 ? Sub can store early in file and not parsed if disable output.

[Klaus1189]

I checked the file myself and at 00:23 and there is I checked displayed, but not the following But he wont say what its on which should also be displayed. I don't know anything else about the file. I cannot even check if the text is available in the teletext stream. If you need more info, let me know. I am lost with my knowledge.

[Liisachan]

Liisachan
You do not seem to know the history of this option. There is no code for the track language in the AVI files, not at all. In external srt, mp3 files there is also no code for the language. In many MKVs, the track language is recorded with a name, not a code. In general, your proposal can only complicate everything, we will leave everything as it is.

Imho supporting both "jpn" and "jap" similarly/transparently would be more convenient for everyone, not complicating anything. MPC-HC does support "jpn" in the same edit box and it can auto-select a "jpn" track from MKV, which seems more intuitive. I understand that supporting non-standard language codes is helpful. I'm not saying you should stop that.

If MKV is created properly, each track has a standard language code. If the code is specific (e.g. "rus" or "jpn" instead of "und"), that gives us a simple way to detect the language, more reliable than parsing the track name (which might be something like "ASS" or "Styled"). You're right, I don't know the historical reasons behind this. On the other hand, I've been multisubbing for about 20 years since before MKV was born, and in my experience, decent MKV files (perhaps > 90%) always have "jpn" for Japanese, at least in the anime fandom — partly because it was/is in the predefined list box of MMG/MKVToolnix GUI. I wouldn't insist. If, for some good reason that I don't know, BE doesn't want to support the standard code "jpn" supported by MPC-HC, I'll respect your choice. Thanks!

[Aleksoid1978]

Give a sample with “jpn” that not supported by MPC BE ?

[Liisachan]

sample file with 2 sub tracks (rus = default; jpn): no-audio.mkv (http://faireal.net/image/public_domain/no-audio.mkv)

MPC-HC Options: can handle "jpn"
http://faireal.net/image/public_domain/no-audio-hc.jpg

MPC-BE Options: don't like "jpn"
http://faireal.net/image/public_domain/no-audio-be.jpg

[Aleksoid1978]

sample file with 2 sub tracks (rus = default; jpn): no-audio.mkv (http://faireal.net/image/public_domain/no-audio.mkv)

MPC-HC Options: can handle "jpn"
http://faireal.net/image/public_domain/no-audio-hc.jpg

MPC-BE Options: don't like "jpn"
http://faireal.net/image/public_domain/no-audio-be.jpg

Ok - i see, you mean handle by language code. But - it's not MPC-HC or MPC-BE deal - it's LAV Source/Splitter generate stream's name including language code :)

[v0lt]

@Liisachan
In r4990, a code is added to the name for languages in which the codes and name differ in the first letters.

[Liisachan]

@v0lt
Thanks :D That's great news.

[v0lt]

@Liisachan
This will only work for containers in which there is a language code.

In any case, the double option always works: "jap jpn". Therefore, recent changes may be removed in the future.

[Klaus1189]

You checked Display at 00:23 ? Sub can store early in file and not parsed if disable output.

Do you need any more info?

[flash21]

First, I just want to thank all those that have helped in the development of MPC-BE. I am new to this forum but have been using MPC-BE for many years.

The reason I am posting is that even though I absolutely love the new version (1.5.4) I do have one minor gripe/annoyance. I believe it is related to this change: "At the beginning of playback, the player now sends a command to wake up the display or turn off the screen saver." The problem is when I go to the next or previous file (when in fullscreen) the cursor reappears for roughly three seconds. This did not happen in the previous stable version (1.5.3) nor does this happen in any of the MPC-HC builds.

I would hope there would be a way to fix this or at least have it available in the options to disable it.

Thank you taking the time to read my post about a minor problem and thank you again to all that make MPC-BE so great.

[chros]

I also noticed the same thing, but I thought it was present in 1.5.3 as well.

[hec481]

I updated the french language; please could you integrate it in the next build.
https://www.upload.ee/files/10927229/mpcresources.fr.dll.html

Thanx.

[Klaus1189]

@hec481: Thank you for updating the french translation :)

You need to download the following file. For now it is the number 4990:
https://sourceforge.net/p/mpcbe/code/4990/tree//trunk/src/apps/mpcresources/text/mplayerc.fr.rc.txt

Check https://sourceforge.net/p/mpcbe/code/commit_browser for the latest commit and edit the number in the link above and download the file
Then edit the file and upload again here.

Thank you for joining ;)

[Liisachan]

@Liisachan
This will only work for containers in which there is a language code.

In any case, the double option always works: "jap jpn". Therefore, recent changes may be removed in the future. Yes, I'll respect your choice :)
I'll do some more tests anyway, and tell you guys if I find any possible problems/improvements related to auto track-selection in general (e.g. how to auto-select reliably between simplified Chinese & traditional Chinese).

As for "jap" vs. "jpn":

On the one hand "jap" is used in reality so supporting it is practical.
On the other hand, it's common sense for those who speak Japanese that the abbreviations for Japanese is "ja" or "jpn". They're standard codes used internationally on a daily basis on the Internet, used also in Matroska (and perhaps MP4 etc.). So it's more likely for those people to type "jpn" into that editbox.
So how about making it so that if either "jap" or "jpn" is typed, it is automatically treated internally as if the two options "jap jpn" were specified?

The thing is, "jap" (https://en.wikipedia.org/wiki/List_of_ethnic_slurs#J) is a touchy word like "fag" or "nigger" — I feel slightly awkward every time I see the static text "Examples: eng jap swe" on that Options dialogbox. I know this is not a programming-related issue you're interested in, so I wouldn't insist, but generally, standard abbreviations (ja or jpn) should be recognized/preferred while non-standard language codes like "jap" can be tacitly treated as aliases.
(In reality one common situation may be this: someone plays a multi-audio anime MKV, where the default is a dub+no_sub, while the viewer wants to select the original "jpn" audio+sub.)

As MPC-BE users increase, more and more users from various countries/areas/cultures might start pointing out similar issues (e.g. Is it "Persian" or "Farsi"?). In such a case, supporting both seems an easy solution, as long as the speed penalty is small enough. Anyway that's the background of my original comment.

[Aleksoid1978]

First, I just want to thank all those that have helped in the development of MPC-BE. I am new to this forum but have been using MPC-BE for many years.

The reason I am posting is that even though I absolutely love the new version (1.5.4) I do have one minor gripe/annoyance. I believe it is related to this change: "At the beginning of playback, the player now sends a command to wake up the display or turn off the screen saver." The problem is when I go to the next or previous file (when in fullscreen) the cursor reappears for roughly three seconds. This did not happen in the previous stable version (1.5.3) nor does this happen in any of the MPC-HC builds.

I would hope there would be a way to fix this or at least have it available in the options to disable it.

Thank you taking the time to read my post about a minor problem and thank you again to all that make MPC-BE so great.

Thanks for info - fixed.

[v0lt]

@hec481
Actual text files for translation can be found here (https://sourceforge.net/p/mpcbe/code/HEAD/tree/trunk/src/apps/mpcresources/text/).
From these files are formed resource files, which are located here (https://sourceforge.net/p/mpcbe/code/HEAD/tree/trunk/src/apps/mpcresources/).If necessary, we can generate a text file from resource files, but this is not often required.
Translation DLL files are compiled from actual resource files. Thus, we guarantee the correct functioning of the player.

[Klaus1189]

@Devs: Can you please check this sample file with teletext subtitle here for a buddy of mine?
https://drive.google.com/file/d/13G0dzgvuACEW_epGqeYrm3uOgcw2XEHd/view?usp=sharing
At 00:23 there is I checked displayed, but there should be But he wont say what its on at the very following, but it isn't displayed according to my buddy.
Thanks in advance :)

I checked with CCExtractor 0.88 and the info is definitely there, but I don't know why it doesn't show up:

1
00:00:03,280 --> 00:00:05,919
- SEEMS TO HAVE BEEN A BURGLARY.
- OH? WHAT OF?

2
00:00:06,000 --> 00:00:07,759
WELL, THAT'S JUST IT.
NOTHING MISSING, REALLY.

3
00:00:09,200 --> 00:00:11,559
WHAT'S HE DOING IN MANCHESTER?

4
00:00:11,640 --> 00:00:13,839
SOMETHING WITH MACHINES.

5
00:00:15,040 --> 00:00:16,199
(EXHALES)

6
00:00:21,120 --> 00:00:23,079
THE PROJECT AT THE NPL.

7
00:00:23,160 --> 00:00:25,559
I CHECKED
BUT HE WON'T SAY WHAT IT'S ON.

8
00:00:27,760 --> 00:00:29,119
PROFESSOR TURING?

9
00:00:29,200 --> 00:00:31,159
DETECTIVE NOCK, MANCHESTER POLICE.

10
00:00:35,480 --> 00:00:37,959
SERGEANT STAEHL HERE TELLS ME
YOU HAD A BURGLARY LAST NIGHT.

11
00:00:39,200 --> 00:00:40,239
PROFESSOR TURING?

12
00:00:41,200 --> 00:00:44,319
(ALAN) TAKE A STEP BACK
AND DON'T BREATHE HEAVILY.

13
00:00:44,400 --> 00:00:46,679
- BREATHE?
- (ALAN) UNDILUTED CYANIDE.

14
00:00:46,760 --> 00:00:49,959
IT WOULDN'T TAKE MORE
THAN A THIMBLEFUL TO KILL YOU.

15
00:00:51,000 --> 00:00:51,959
AH.

16
00:00:53,680 --> 00:00:56,379
- DISAPPOINTING.
- PARDON?


I am begging for help ;)

EDIT: Seems like the second line is not displayed, perhaps after a new line is started?

[999999999]

Has anyone noticed worse performance? I was running 1.5.3.4488.x64, just installed 1.5.4.4969 x64 over it.

Playback is noticeably sluggish, dropping frame and loss of audio sync, maybe all the time but most significant using shader filters like sharpen complex 2. That worked fine previously with GTX 750TI GPU acceleration.

I had changed no settings from 1.5.3.x64, but did notice the new "Presentation Mode:" (Copy vs Flip/FlipEx). It defaulted to Copy and changing it to Flip/FlipEX improved performance a bit but still slower than 1.5.3.x64 was. Even the GUI is lagging during playback.

I do not know all the ins and outs of tweaking for performance, but that it did fine with 1080p upscaling, up to 4k windowed until now. I know it would be easy to just tell me "get faster hardware" but I am interested in learning what happened to decrease the performance I already had. Here are the current settings that are much slower than in 1.5.3.x64, is there something I should do? I was happy enough with 1.5.3, but saw this version adds AV1 decoding?

https://i.imgur.com/8slwypq.png

[huhn]

check the CPU usage your GPU will do this while sleeping even an intel iGPU should be able to do such a trivial ask.

[ryrynz]

Has anyone noticed worse performance?

For starters revert to 1.5.3.4488 and see if it does the same thing. You can't assume to know the new build caused this without SOME investigation.
Chances are as huhn said, the content you're trying to play is more demanding than your hardware can handle, you can check utilization and revert to the old build to confirm.

[999999999]

check the CPU usage your GPU will do this while sleeping even an intel iGPU should be able to do such a trivial ask.

Mmm, no I know that isn't true. Once you do the upsampling and complex sharpening 2 on top of that, a GTX 750TI is "just" enough. Remember I am windowed mode approaching a 4K window size.

My CPU usage stays around 20% with no individual cores anywhere near 100%, does not peak when the frames are dropped and sound drops out.

[999999999]

For starters revert to 1.5.3.4488 and see if it does the same thing. You can't assume to know the new build caused this without SOME investigation.
Chances are as huhn said, the content you're trying to play is more demanding than your hardware can handle, you can check utilization and revert to the old build to confirm.

I was mistaken about the old version #s. It was 1.5.2.4488, then 1.5.3.4455 I used successfully, and I tried reverting back to them (still have them in their own folders). The difference is not as large as I saw originally but it is still there. 1.5.4.4969 is still dropping frames and audio dropout.

Chances are not that the content is too demanding. My test files are the same ones I was already playing with no change whatsoever except MPC-BE version #.

It seems as though there is something about this newest version that makes using shaders less efficient, OR the inefficiency is just somewhere else and the additional slowdown from shaders is enough to slow it below the realtime playback rate, and yet my CPU is loafing along, never peaking high even during the issue.


Let me restate since something went wrong in my conveying the info.

1) Play file X.
2) Install new version of MPC-BE.
3) Play file X again.

This is ALL that happened (there are no other variables, this sequence happened within 2 minutes) and playback is skipping.

Perhaps I should have worded my post differently and simply asked "what changes have been made to this new version of MPC-BE that have the potential to cause higher decoding /playback overhead when watching upsampled and with shaders doing complex sharpening?"

[ryrynz]

I was mistaken about the old version #s.

Go here (https://yadi.sk/d/hlf1lfC8mKU58) and download some builds of previous versions, find the one where the performance got worse and report back here with the build number.

[v0lt]

@999999999
Please try version 1.5.4.4850 (SF.net) (https://sourceforge.net/projects/mpcbe/files/MPC-BE/Nightly%20Builds%20%28from%20svn%20trunk%29/1.5.4%20%28build%204850%29%20beta/) first.
I will also ask you to take screenshots of the playback with the included statistics (Ctrl+J).

[JarrettH]

Does anyone here own an RME ADI-2 Pro DAC? Using the MPC Audio Renderer, WASAPI Shared plays fine, but Exclusive results in laggy video. This is with the device in Class Compliant (driverless) mode.

Did you solve this? I had the same problem tonight (Windows 10, BE 1.5.4). WASAPI Exclusive = laggy video, WASAPI Shared = all fine. My DAC wouldn't detect the sample rate in Shared mode, in Exclusive mode it does but that's unusable. Changing the device buffer has no effect.

@Aleksoid1978

[JarrettH]

To troubleshoot, I switched from LAV Audio to the internal one - same problem.

[Aleksoid1978]

Did you solve this? I had the same problem tonight (Windows 10, BE 1.5.4). WASAPI Exclusive = laggy video, WASAPI Shared = all fine. My DAC wouldn't detect the sample rate in Shared mode, in Exclusive mode it does but that's unusable. Changing the device buffer has no effect.

@Aleksoid1978

Try this build - it's create log on Desktop. Upload log for me after.
https://yadi.sk/d/EONq2cmaYADEjQ

[JarrettH]

Thanks!

https://drive.google.com/file/d/1XoWGa_XGd3NfyvVzpRApIi-zMMWUBQ1k/view?usp=sharing

I played the video for about 5 minutes.

Is "DefaultDevicePeriod = 10.00 ms" the default buffer?

[999999999]

Go here (https://yadi.sk/d/hlf1lfC8mKU58) and download some builds of previous versions, find the one where the performance got worse and report back here with the build number.

Thanks but yeah that was an obvious thing to do and yet, doesn't really get me a solution. There probably isn't one, and it's not worth THAT much work, with 100-something releases in that era.

I ended up just accepting that I can't hold onto an old version of MPC-BE forever if I wish to support more/better features so gave up on the prior setup, set the 750TI to max performance instead of power savings (dynamic downclocking like all modern NV cards do) for MPC-BE specifically (per-app), then if I'm going to take that power and heat penalty anyway, gives me more headroom to switch to madvr rendering and that feature set.

Regardless, what testing I did do, did show a clear correlation between this newest version of MPC-BE and loss of performance with nothing else changed. There is no mistaking when the same file starts dropping frames, stuttering with audio out of sync and substantial, simultaneous Windows GUI slowdown. Disable downclocking/Pwr-Mgmt the GPU via the power management setting in Nvidia Control Panel and all that is gone.

[ryrynz]

This could be compiler related or an unexpected and a possibly improved upon side effect. I'd recommend testing, it probably won't take long.

[Klaus1189]

For fast finding the last version behaving what you need, test the middle build between 1.5.3 stable and 1.5.4 stable, if this middle version does work, then try in the new middle between this and 1.5.4.

If that first middle version doesn‘t work, then try the new middle between 1.5.3 stable and the first middle.

And repeat till you found the version. I hope I wrote it understandable ;)

[Aleksoid1978]

Thanks!

https://drive.google.com/file/d/1XoWGa_XGd3NfyvVzpRApIi-zMMWUBQ1k/view?usp=sharing

I played the video for about 5 minutes.

Is "DefaultDevicePeriod = 10.00 ms" the default buffer?

All look's good. Without such device i can't test and say what's wrong.

P.S. Try another app with WASAPI Exclusive Output(need use WASAPI Exclusive Event mode) - foobar, AIMP.

[JarrettH]

I've been using jriver with wasapi exclusive for years, but that's audio only. Oh well, I might even prefer Shared mode for movies, just that I'll have to make a shortcut to sound properties to change the sample rate initially.

[wushantao]

https://send.firefox.com/download/d324b93df1584378/#GZhc6ulUDKdi7REae7hMog

there is no vcd anymore :sly:

[Aleksoid1978]

I checked with CCExtractor 0.88 and the info is definitely there, but I don't know why it doesn't show up:

1
00:00:03,280 --> 00:00:05,919
- SEEMS TO HAVE BEEN A BURGLARY.
- OH? WHAT OF?

2
00:00:06,000 --> 00:00:07,759
WELL, THAT'S JUST IT.
NOTHING MISSING, REALLY.

3
00:00:09,200 --> 00:00:11,559
WHAT'S HE DOING IN MANCHESTER?

4
00:00:11,640 --> 00:00:13,839
SOMETHING WITH MACHINES.

5
00:00:15,040 --> 00:00:16,199
(EXHALES)

6
00:00:21,120 --> 00:00:23,079
THE PROJECT AT THE NPL.

7
00:00:23,160 --> 00:00:25,559
I CHECKED
BUT HE WON'T SAY WHAT IT'S ON.

8
00:00:27,760 --> 00:00:29,119
PROFESSOR TURING?

9
00:00:29,200 --> 00:00:31,159
DETECTIVE NOCK, MANCHESTER POLICE.

10
00:00:35,480 --> 00:00:37,959
SERGEANT STAEHL HERE TELLS ME
YOU HAD A BURGLARY LAST NIGHT.

11
00:00:39,200 --> 00:00:40,239
PROFESSOR TURING?

12
00:00:41,200 --> 00:00:44,319
(ALAN) TAKE A STEP BACK
AND DON'T BREATHE HEAVILY.

13
00:00:44,400 --> 00:00:46,679
- BREATHE?
- (ALAN) UNDILUTED CYANIDE.

14
00:00:46,760 --> 00:00:49,959
IT WOULDN'T TAKE MORE
THAN A THIMBLEFUL TO KILL YOU.

15
00:00:51,000 --> 00:00:51,959
AH.

16
00:00:53,680 --> 00:00:56,379
- DISAPPOINTING.
- PARDON?


I am begging for help ;)

EDIT: Seems like the second line is not displayed, perhaps after a new line is started?

Thanks for info - fixed.

[mogli]

Two minor convenience issues when dowloading youtube videos:

Sometimes the video name has the suffix " - YouTube" added by MPC-BE, sometimes not. Why? (I don't need it and remove it when that happens.)
The dialog shown while downloading the video is at the same postion as the player. However the dialog when downloading the audio always opens in the middle of the screen. The latter is mildly annoying because it usually overlays other stuff I'm currently working on and sometimes I accidently click abort and need to redownload.


Btw thanks for the latest stable version, especially remembering the sounddevice by name.

[Aleksoid1978]

Sometimes Google API block request and app can’t parse metadata and get Title from youtube’s page.

[v0lt]

@wushantao
AviSynth script (http://avisynth.nl/index.php/Main_Page) and AVS (https://wiki.multimedia.cx/index.php/AVS) are two different files, but have the same extension .avs. :(

added:
Do you have an AVS video file that can be opened in MPC-BE or MPC-HC?