Media Player Classic - BE Win32/x64

[Aleksoid1978]

Hi all.
Test version of MPC VR with HDR passthrough - https://yadi.sk/d/eUWssVC_Pa3EeA
Limitation - there is no auto HDR on/off anf currently no metadata passthrough(i think using some standard metadata).
For using - enable HDR in Windows 10 and then open/play any video with HDR in MPC-BE/MPC-HC. In MPC VR using DX11(VP or Shaders).

[huhn]

i can't get it to work.
st 2084 correction either stays in the OSD or the image is washed out.
if the VP is disabled this information is not shown.

are there some specific setting i should test this with like 16 bit d3d9?

[chros]

Hi all.
Test version of MPC VR with HDR passthrough - https://yadi.sk/d/eUWssVC_Pa3EeA
Limitation - there is no auto HDR on/off anf currently no metadata passthrough(i think using some standard metadata).
For using - enable HDR in Windows 10 and then open/play any video with HDR in MPC-BE/MPC-HC. In MPC VR using DX11(VP or Shaders).

Woow, Aleks! What a surprise! I'll try out shortly, thank you, guys!!!

[Aleksoid1978]

i can't get it to work.
st 2084 correction either stays in the OSD or the image is washed out.
if the VP is disabled this information is not shown.

st 2084 correction in OSD show when using HDR -> SDR conversion. If using HDR passthrough - it's show is OSD "Windows HDR passthrough".

Are you sure that enable HDR in Windows ?

[Aleksoid1978]

Update version - https://yadi.sk/d/SJtQ53KTsJS5_w
Add send HDR metadata.

[huhn]

st 2084 correction in OSD show when using HDR -> SDR conversion. If using HDR passthrough - it's show is OSD "Windows HDR passthrough".
it either shows ST 2084 correction dither or just dither.
i'm on windows 19041 madVR works with and without HDR meta data using OS HDR.
is there something i can do/test so i can provide some useful information that isn't "it doesn't work"
Are you sure that enable HDR in Windows ?
yes. same with the new version.

HDR->SDR OSD related problem
if OS HDR is disabled so HDR->SDR is needed when the VP setting are all disabled. the OSD will not show the ST 2084 correction information but use it: https://abload.de/img/hdrsdrs2jlj.png

[Aleksoid1978]

it either shows ST 2084 correction dither or just dither.
i'm on windows 19041 madVR works with and without HDR meta data using OS HDR.
is there something i can do/test so i can provide some useful information that isn't "it doesn't work"

yes. same with the new version.

HDR->SDR OSD related problem
if OS HDR is disabled so HDR->SDR is needed when the VP setting are all disabled. the OSD will not show the ST 2084 correction information but use it: https://abload.de/img/hdrsdrs2jlj.png

When use shader it’s do not show in OSD about HDR->SDR conversion, but you can see it by picture :)

About HDR - I develop on Nvidia 1650 + monitor + DP 1.4 cable, I don’t know what’s wrong on you side.

[Aleksoid1978]

Update version - https://yadi.sk/d/xoaq3zIwoXyopg
Add auto system HDR On/Off.

[v0lt]

@huhn
Shader "ST 2084 correction" is applied only after DXVA VP and D3D11 VP.
If DXVA VP and D3D11 VP are not used, then the "ST 2084 correction" shader is also not used. HDR to SDR conversion is handled by the main color conversion shader (Shader VP).

[huhn]

auto switching works here.

[Aleksoid1978]

auto switching works here.

HDR passthrough also working, what hardware use for it ?

[huhn]

no that didn't change if it does i will clearly say so.

is totally washed out so windows has to think this is SDR instead of HDR and applies it's bad SDR -> HDR conversation on it.

the first line of your OSD clearly states Windows HDR passthrough. 1000 nits.

edit: it's very dumb here...
the solution:
it doesn't work with discard but it works fine with flip presentation.
if discard works with nvidia maybe force flip for AMD user.

your OS HDR implementation works i personally have no tools or OSD information to verify if the meta data is transported correctly so i can't help in checking if it works perfectly.
what so ever it looks different compared to madVR.

[Aleksoid1978]

no that didn't change if it does i will clearly say so.

is totally washed out so windows has to think this is SDR instead of HDR and applies it's bad SDR -> HDR conversation on it.

the first line of your OSD clearly states Windows HDR passthrough. 1000 nits.

Hmm - it’s very strange.

[chros]

Yes, same here: TV auto switches into HDR10 mode, washed out picture and OSD reports HDR passthrough 1000 nits.
Btw, can you make a checkbox for HDR passthrough/HDRtoSDR? Thanks!

[huhn]

you see my flip comment yes? just to be sure.

[chros]

Nice found, setting swap effect to "flip" solved the issue! :)

But HDR metadata is not correct, it always states 1000 and not what the stream has, e.g.:
- The Hunger Games 2 has 1000 MDL, 686 maxCLL, 230 maxFall
- in this case the correct value should be: 686

Maybe you set MDL all the time?

Edit:
Yes, that's the case, MDL is set all the time.
- Mad Max Fury road: 4000 MDL, 9918 maxCLL, 3241 maxFall
-- it reports 4000, but it should be 9918

And there are other HDR10 properties that also need to be set (mastering display gamut coordinates, etc.)

[clsid]

@huhn
Shader "ST 2084 correction" is applied only after DXVA VP and D3D11 VP.
If DXVA VP and D3D11 VP are not used, then the "ST 2084 correction" shader is also not used. HDR to SDR conversion is handled by the main color conversion shader (Shader VP).
Normal users don't understand what this means.

I suggest adding a "HDR processing:" line in the OSD for HDR inputs. Its value could then be "Passthrough" or "Convert to SDR"

[Klaus1189]

What is "swap effect" exactly? And what is "Discard" and "Flip" in that? Presentation mode ...

[huhn]

is a type of presentation it's the way the image is drawn.
madVR has back buffer, present in advanced and overlay which are high level names for these these are "swap chains". flip(2018) is the current recommendation from windows.

for example WFS 10 bit can't be back buffer and has to be present in advanced which model that is exactly is not known to me.
is far more complicated then this you can read more here:
https://docs.microsoft.com/en-us/windows/win32/direct3ddxgi/dxgi-flip-model

[chros]

What is "swap effect" exactly? And what is "Discard" and "Flip" in that? Presentation mode ...
There was a discussion about it previously, search for it in this thread, but I forgot it :) Potplayer's built-in render uses Flip-squential by default.
I suggest adding a "HDR processing:" line in the OSD for HDR inputs. Its value could then be "Passthrough" or "Convert to SDR"
It would be nice to have all the HDR10 metadata displayed on the OSD, no matter what the output is, like in madvr:
- master gamut, master luminance (min/max), maxCLL, maxFall
- if output is HDR: the set value (like now)

[Aleksoid1978]

Nice found, setting swap effect to "flip" solved the issue! :)

But HDR metadata is not correct, it always states 1000 and not what the stream has, e.g.:
- The Hunger Games 2 has 1000 MDL, 686 maxCLL, 230 maxFall
- in this case the correct value should be: 686

Maybe you set MDL all the time?

Edit:
Yes, that's the case, MDL is set all the time.
- Mad Max Fury road: 4000 MDL, 9918 maxCLL, 3241 maxFall
-- it reports 4000, but it should be 9918

And there are other HDR10 properties that also need to be set (mastering display gamut coordinates, etc.)

About swap effect - i fix it, for HDR Passthrough wiil be always use Flip.

About HDR metadata - upload short sample, but i show in OSD like madVR("some" nits, i compare - madVR show Mastering display luminance max).

[Aleksoid1978]

Latest MPC VR - https://yadi.sk/d/ZbMRb5TKUn-00Q

[Aleksoid1978]

Who have HDR TV/Monitor - can you check with DXVAChecker like in screen - https://i.imgur.com/6UvCBD5.png

[v0lt]

MPC-BE 1.5.6 (build 5797) beta (https://sourceforge.net/projects/mpcbe/files/MPC-BE/Nightly%20Builds%20%28from%20svn%20trunk%29/1.5.6%20%28build%205797%29%20beta/) with digital signature (SF.net).

List of changes (https://sourceforge.net/p/mpcbe/code/5797/tree//trunk/docs/Changelog.txt).

MPC-BE Nightly builds: main file store (https://yadi.sk/d/hlf1lfC8mKU58), alternative 1 (https://yadi.sk/d/AjAXDDHtHRIELg), alternative 2 (https://cloud.mail.ru/public/V1rp/2iqNDT5Rx)
Also new and old versions can be found on VideoHelp.com (https://www.videohelp.com/software/MPC-BE).

[ryrynz]

Any chance of having the Help-About text the bottom of the player options in an "About" section?
Also maybe options to allow removal of some things from context menu? It's quite long now, prefer compact.

[Aleksoid1978]

Any chance of having the Help-About text the bottom of the player options in an "About" section?
Also maybe options to allow removal of some things from context menu? It's quite long now, prefer compact.

Help-About - i don't understand what you mean.

Options for customize context menu don't planned.

[ryrynz]

Help-About - i don't understand what you mean.


Build info is only seen in File menu Help-About, could add this into Player options below Miscellaneous an 'About' section so can see build info and player website link there as well.

[Aleksoid1978]

Build info is only seen in File menu Help-About, could add this into Player options below Miscellaneous an 'About' section so can see build info and player website link there as well.

No, not planned.

[huhn]

DXVA checker:
https://abload.de/img/suren6ku1.png

[Aleksoid1978]

DXVA checker:
https://abload.de/img/suren6ku1.png

Good - you device support send hdr10 metadata, my monitor - no and i can't test different hdr10 metadata on screen :)

[chros]

Who have HDR TV/Monitor - can you check with DXVAChecker like in screen - https://i.imgur.com/6UvCBD5.png
It's the same for me as well: HDRMetadata No.

About HDR metadata - upload short sample, but i show in OSD like madVR("some" nits, i compare - madVR show Mastering display luminance max).
Here you can find samples with different metadata (https://mega.nz/folder/n5dzgQbJ#A99MVeafyffB1qK6-ahrTg) (the number in the filename is the mxCLL of the file), e.g. the 2 mentioned one:
- mad max: 08-2160p_23fps_hdr9918-mmfr.mkv
- hunger games: 06-2160p_23fps_hdr0686-thgm.mkv

The set HDR value should be:
- setValue = (isset(maxCLL) && maxCLL != 0) ? maxCLL : ((isset(maxMDL) && maxMDL != 0) ? maxMDL : 0)
- setMaxFall = (isset(maxFALL) && maxFALL!= 0) ? maxFALL: 0
- also the gamut primaries and white point needs to be passed on (I think) along with the mastering display values

Here's a summary (https://www.mysterybox.us/blog/2016/10/19/hdr-video-part-3-hdr-video-terms-explained#block-yui_3_17_2_1_1476829777712_196719) what an HDR10 stream has.

You can see how it looks like on madvr OSD, but you have to create a directory called "ShowHdrMode" in madvr directory to see these advenced options. You can put these info under Input Format on your OSD.

[chros]

DXVA checker:
https://abload.de/img/suren6ku1.png
That's interesting, I have "No" with GTX 1060 Gaming X 6GB, driver v398.18 on Win10 LTSC 1809 :)
I tried to lunch dxvachecker on the TV as well, but it's the same for me.

And the metadata doesn't get to the TV:
- OSD says 4000
- LG states around 1000 (checked with the White balance value)

[Aleksoid1978]

All HDR metadata set to device - RedPrimary/GreenPrimary/BluePrimary/WhitePoint/MaxMasteringLuminance/MinMasteringLuminance/MaxContentLightLevel/MaxFrameAverageLightLevel if it's present in stream/container and video decoder send it.
But - if you device "HDRMetadata No" - it's all no matter, you device don't support/accept different hdr10 medatata :)

[huhn]

here is an example what has to be set in AMD AGS for proper meta data: https://user-images.githubusercontent.com/58528066/75607706-054e3200-5b0b-11ea-925b-6fe3a5cbf86d.png
i'm well aware that you are not using AGS but windows should have the same possible information.

for now the image is not the same as madVR the colors are different and i don't have a tool to check the meta data also seen on the screen.


btw. what do you think about HLG to HDR10?
it "should be" relative simple a HLG to linear filter is needed (the hard part) after that you devided it by 4 (puts the 1000 nits HLG into 4000 nits linear).
linear to PQ filter.
meta data 1000 nits and bt 2020 done.

[Aleksoid1978]

here is an example what has to be set in AMD AGS for proper meta data: https://user-images.githubusercontent.com/58528066/75607706-054e3200-5b0b-11ea-925b-6fe3a5cbf86d.png
i'm well aware that you are not using AGS but windows should have the same possible information.

for now the image is not the same as madVR the colors are different and i don't have a tool to check the meta data also seen on the screen.


btw. what do you think about HLG to HDR10?
it "should be" relative simple a HLG to linear filter is needed (the hard part) after that you devided it by 4 (puts the 1000 nits HLG into 4000 nits linear).
linear to PQ filter.
meta data 1000 nits and bt 2020 done.

For me image 1:1 like in madVR.
About HLG - i add output as HDR10, like it does madVR.

[huhn]

madVR supports HLG?

[chros]

No, madvr doesn't support anything else just HDR10. And that's a big bummer :)

[Aleksoid1978]

Compare screenshot made by xbox game-bar - yes in MPC VR picture a very little brighter. Compare on "Life of Pi" short sample. I don't know what's is different.

[Aleksoid1978]

madVR output HLG as HDR10. Download any HLG HDR clip and test :)

[huhn]

can you share an HLG test sample?

[Aleksoid1978]

Windows 10 can handle only HDR10 metadata.

[Aleksoid1978]

https://4kmedia.org/travelxp-4k-hdr-hlg-sample
https://www.isovideo.com/Sony_SDR_to_HLG10_Up_Conversion.php

[huhn]

aware of that's why i even bring up the idea of turning an HLG image into HDR10. because now we have meta data not good one but better than nothing.
technically there is no real difference only the transfer function and max brightness.

[mikahawkins1]

I think I should give this a try. Will it work well on 4GB and I3?

[beter]

Update translation for Chinese Traditional and Dutch.

https://www.sendspace.com/file/pn87q9

[Aleksoid1978]

for now the image is not the same as madVR the colors are different and i don't have a tool to check the meta data also seen on the screen.

Test build - https://yadi.sk/d/GEHfRmu7Yt9jJQ

[huhn]

there seems to be a difference in tint mpcVR is more greenish while madVR has a red tint in comparison.

i guess the fasting thing to compare them is to render HDR as gamma without HDR->SDR conversation disabling dithering and then run an image comparison. if they are the "same" the difference should be metadata.

about HLG.
at my side madVR is incapable of displaying hlg outside SDR which technical is ok.
mpcVR sends HDR10 data and the image is clearly to bright like my TV things it has 4000 nits or something while the max nits is 1000.

[Aleksoid1978]

At my side - madVR output HLG as HDR10, hdr passthrough.

[huhn]

i tried AMD HDR which doesn't trigger and OS HDR both are not working for OS HDR is technical sending HDR10 but everything is HDR10 with OS HDR the image is not altered and looks like SDR->HDR converted unlike mpcVR.

did you do it with OS HDR or nvidia API?

i'm using madVR 0.92.17 and not the one of the countless beta versions.

[Aleksoid1978]

I enable OS HDR before open file for test. If not - madVR activate NV HDR, but it's working only in exclusive full-screen.