Media Player Classic - BE Win32/x64

[madshi]

I'm not sure exactly where you can insert the call. Maybe you yourself look sources and help with it :)

P.S. Try this build http://aleksoid.voserver.net/MPC-BE/mpc-be.exe_madVR_put_Owner_Test.7z
I can call put_Owner() only after madVR connect to the video decoder. If call before this - no effect, madVR show video in a separate window :)
Hmmmm... This build first connects madVR to the decoder and then calls put_Owner(). That doesn't really help. It needs to be the other way round. It is possible that there is a bug in madVR which doesn't allow the other way round to work properly, I'm not sure. Could you create a test build for me which calls put_Owner() directly after adding madVR to the graph? It doesn't matter if madVR then shows video in a separate window. I can then use your test build to find out why there's a separate window - and maybe fix that in madVR.

Thanks!

[thymej]

Just curious, but I’m corn-fused with the version numbers.

The stable version currently is 1.1.3.0.1737.
The Dev version is currently 1.1.0.1.2028.

Assuming MPC-BE follows this version format: (Major version).(Minor version).(Revision number).(Build number)

Why is the revision number part grater on the stable version then the dev version when the dev version is a newer build number (newer also by date)?

Again, just curious.

[ryrynz]

I’m corn-fused with the version numbers.

They've specified different third and fourth digits to differentiate it from the release build that's all, the four digit build number at the end is comparable between release and development builds and is what you should be primarily concerned with.

[Aleksoid1978]

:sly: Is there a smart solution?

I dont like what MPC-BE did because I have many korean Live files (.tp/.ts, 1080i, no subtitle) which I prefer to using native EVR than EVR-CP for max low power consumption and no-dropped frame, BE forces to load my xy-VSFilter and breaks the native DXVA and the H/W deinterlacing.:scared:

Ok - i do options in MPEGSplitter to enable/disable empty Subtitle output pin.

P.S. hm, i test MPC-HC with M2TS without subtitle ... and VSFilter is auto loading.
http://s017.radikal.ru/i418/1302/63/2164a90e00e0t.jpg (http://radikal.ru/F/s017.radikal.ru/i418/1302/63/2164a90e00e0.png.html)

[wanezhiling]

Ok - i do options in MPEGSplitter to enable/disable empty Subtitle output pin.

:thanks:

P.S. hm, i test MPC-HC with M2TS without subtitle ... and VSFilter is auto loading.

Interesting.

I tested latest mpc-hc 1.6.6.6781, it worked fine, external vsfilter will not be loaded on those non-subtitle MPEG files(.tp .ts .m2ts .mpg...) in native evr mode.
Only one situation where external vsfilter will be loaded: External subtitle(s) exist. http://i.minus.com/iTukAbW5pUuVD.png

[wanezhiling]

http://pan.baidu.com/share/link?shareid=258141&uk=3558042035

BE could not show the DVB subtitle. (http://i.minus.com/i1du7SndMvZwO.png)

PotPlayer is fine. (http://i.minus.com/i34VMPvfdhMxz.png)

[Aleksoid1978]

Hmmmm... This build first connects madVR to the decoder and then calls put_Owner(). That doesn't really help. It needs to be the other way round. It is possible that there is a bug in madVR which doesn't allow the other way round to work properly, I'm not sure. Could you create a test build for me which calls put_Owner() directly after adding madVR to the graph? It doesn't matter if madVR then shows video in a separate window. I can then use your test build to find out why there's a separate window - and maybe fix that in madVR.

Thanks!

Here 2 test build
http://aleksoid.voserver.net/MPC-BE/

in this put_Owner do not work. If i later call get_Owner() - pVW->get_Owner(&Owner) - it's return in Owner is 0.

[Aleksoid1978]

:thanks:

Interesting.

I tested latest mpc-hc 1.6.6.6781, it worked fine, external vsfilter will not be loaded on those non-subtitle MPEG files(.tp .ts .m2ts .mpg...) in native evr mode.
Only one situation where external vsfilter will be loaded: External subtitle(s) exist. http://i.minus.com/iTukAbW5pUuVD.png

I test with xy-vsfilter - it's always loading with MPC-BE and MPC-HC on any video without subtitle - .avi/.m2ts etc.
xy-vsfilter is version 3.0.0.211

[wanezhiling]

I test with xy-vsfilter - it's always loading with MPC-BE and MPC-HC on any video without subtitle - .avi/.m2ts etc.
xy-vsfilter is version 3.0.0.211

Because you select Always load (http://i.imgur.com/jj2FW8d.png)...:p
The default setting is Load when needed.

[Aleksoid1978]

Because you select Alwayes load (http://i.imgur.com/jj2FW8d.png)...:p

i think yes :D

[Aleksoid1978]

http://pan.baidu.com/share/link?shareid=258141&uk=3558042035

BE could not show the DVB subtitle. (http://i.minus.com/i1du7SndMvZwO.png)

PotPlayer is fine. (http://i.minus.com/i34VMPvfdhMxz.png)

Fixed in rev. 2074

[wanezhiling]

:thanks:


PS: Did you notice the different DVB subtitle position between VSFilter and internal sub engine?

VSFilter: http://i.minus.com/iboCSLI8B5Pwu8.png

internal sub engine: http://i.minus.com/ibfQj512qSKvlt.png

[alexins]

MPC-BE v1.1.0.1 -dev build 2075 (Nightly Builds) (http://sourceforge.net/projects/mpcbe/files/MPC-BE/Nightly Builds (from svn trunk)/MPC-BE v1.1.0.1 -dev build 2075/) (sourceforge)
MPC-BE v1.1.0.1 -dev build 2075 (Nightly Builds) (http://dev.mpc-next.ru/index.php/topic,1240.0.html) (Dev. MPC-BE)

Just curious, but I’m corn-fused with the version numbers.

The stable version currently is 1.1.3.0.1737.
The Dev version is currently 1.1.0.1.2028.

Assuming MPC-BE follows this version format: (Major version).(Minor version).(Revision number).(Build number)

Why is the revision number part grater on the stable version then the dev version when the dev version is a newer build number (newer also by date)?

Again, just curious.

In the MPC-BE use the following numbering: (VERSION_MAJOR).(VERSION_MINOR).(VERSION_STATUS).(VERSION_PATCH)

VERSION_STATUS: 0 - alfa; 1 - beta; 2 - RC; 3 - stable

[madshi]

Here 2 test build
http://aleksoid.voserver.net/MPC-BE/

in this put_Owner do not work. If i later call get_Owner() - pVW->get_Owner(&Owner) - it's return in Owner is 0.
Thanks. I've found that the Microsoft base classes (which madVR is built on) internally rejects put_Owner() when the pins are not connected yet. OUCH! I'm sorry for the extra trouble this has caused you. I've now changed madVR to use its own code for put_Owner() instead of the MS base classes code. That fixes the problem and makes both of your test builds work just fine.

However, I've found that your test builds don't work with VMR9 windowed mode. So it seems you can't call put_Owner() so early for all renderers. Also it won't work for older madVR versions, either.

What do you think about the following workaround: You could make two calls to put_Owner(). One directly after creating the renderer instance (maybe only for madVR, if you prefer). And another one after connecting the pins. Calling it twice should not harm. This solution would make everything work for all versions of all renderers. And for the next madVR build it would improve multi monitor behaviour.

What do you think?

[detmek]

:thanks:


PS: Did you notice the different DVB subtitle position between VSFilter and internal sub engine?

VSFilter: http://i.minus.com/iboCSLI8B5Pwu8.png

internal sub engine: http://i.minus.com/ibfQj512qSKvlt.png

Did you enable Play - Subtitles - Default Style?

[Aleksoid1978]

Thanks. I've found that the Microsoft base classes (which madVR is built on) internally rejects put_Owner() when the pins are not connected yet. OUCH! I'm sorry for the extra trouble this has caused you. I've now changed madVR to use its own code for put_Owner() instead of the MS base classes code. That fixes the problem and makes both of your test builds work just fine.

However, I've found that your test builds don't work with VMR9 windowed mode. So it seems you can't call put_Owner() so early for all renderers. Also it won't work for older madVR versions, either.

What do you think about the following workaround: You could make two calls to put_Owner(). One directly after creating the renderer instance (maybe only for madVR, if you prefer). And another one after connecting the pins. Calling it twice should not harm. This solution would make everything work for all versions of all renderers. And for the next madVR build it would improve multi monitor behaviour.

What do you think?

I agree with you. You made new build - i download it's and test. Also i test with any other renderer. And all will be happy :)

[Luyten]

Hi, I noticed that when mpc-be is maximized and playing a video (or an audio file), the player is still draggable in the video area (it shouldn't be). Also the toolbar area is still draggable and restore the window to original dimensions.

http://i.imgur.com/SZWvnGi.png

[madshi]

I agree with you. You made new build - i download it's and test. Also i test with any other renderer. And all will be happy :)
Here's the test build:

http://madshi.net/madVRputOwner.rar

[madshi]

Ooopsi, that test build might have been faulty. But this one should work:

http://madshi.net/madVRputOwner2.rar

[Reino]

Pretty much the first time I've used MPC-BE and I'd like to report my findings:

[Internal Opus Decoder]
- Choppy seekbar advancement. Position gets updated every second or so. And upon playback, corrupted audio the first second.
It only concerns the decoder, because all is fine with MPC Ogg Source + LAV Audio Decoder. With other Opus decoders it's all smooth.

[Internal WavPack Splitter]
- Shows incorrect duration (06:45.48 for various wv-files with various lengths).
- Sometimes it takes 5 seconds before audio is initialized/before you can hear anything.
- The moment I feed it multichannel wv-files MPC-BE freezes!
Only the splitter is to blame, because all is fine with LAV Splitter + internal WavPack Decoder.

[Default interface ("dark" theme unticked)]
Could you please...:
- Allow a bit more room between the Control-bar and the Status-bar (pixels between the buttons and the black bar).
- Finish the border of the buttons (white pixels).
- Remove the bottom row of black pixels of the volume slider.
- Remove the hour time indication when a media file doesn't last an hour (is it really necessary?).
- Replace the "no audio"-icon? (the mono and stereo audio icon are already the original ones)
- Enable chapter markers for the default interface!! And when you're at it, replace the markers (vertical lines) with the "dark" theme markers. They look better if you ask me ;).

http://www.ld-host.de/uploads/images/89795aef3e017e52164d02a039ff5bdd.png

[Aleksoid1978]

Ooopsi, that test build might have been faulty. But this one should work:

http://madshi.net/madVRputOwner2.rar

Test on this build - http://aleksoid.voserver.net/MPC-BE/mpc-be.exe_madVR_test_3.7z

But - get_Owner() still does not return the correct value and put_Owner call twice.

[Aleksoid1978]

Pretty much the first time I've used MPC-BE and I'd like to report my findings:

[Internal Opus Decoder]
- Choppy seekbar advancement. Position gets updated every second or so. And upon playback, corrupted audio the first second.
It only concerns the decoder, because all is fine with MPC Ogg Source + LAV Audio Decoder. With other Opus decoders it's all smooth.

[Internal WavPack Splitter]
- Shows incorrect duration (06:45.48 for various wv-files with various lengths).
- Sometimes it takes 5 seconds before audio is initialized/before you can hear anything.
- The moment I feed it multichannel wv-files MPC-BE freezes!
Only the splitter is to blame, because all is fine with LAV Splitter + internal WavPack Decoder.

[Default interface ("dark" theme unticked)]
Could you please...:
- Allow a bit more room between the Control-bar and the Status-bar (pixels between the buttons and the black bar).
- Finish the border of the buttons (white pixels).
- Remove the bottom row of black pixels of the volume slider.
- Remove the hour time indication when a media file doesn't last an hour (is it really necessary?).
- Replace the "no audio"-icon? (the mono and stereo audio icon are already the original ones)
- Enable chapter markers for the default interface!! And when you're at it, replace the markers (vertical lines) with the "dark" theme markers. They look better if you ask me ;).

http://www.ld-host.de/uploads/images/89795aef3e017e52164d02a039ff5bdd.png

We do not support default(windows) themes.

About WavPack & Opus - sample or link for download.

[Reino]

Then who can I ask instead? It's a port from MPC-HC, so someone must have screwed-up the default interface at some point.

[Internal Opus Decoder]
- ...It only concerns the decoder,...Correction, it only happens when both Opus Splitter AND Decoder are enabled!

Across the River_sample(2ch).wv (http://www.degeelebosch.nl/reino/Across the River_sample(2ch).wv) (2,39MB)
Across the River_sample(2ch).opus (http://www.degeelebosch.nl/reino/Across the River_sample(2ch).opus) (198KB)
Across the River_sample(quad).wv (http://www.degeelebosch.nl/reino/Across the River_sample(quad).wv) (4,75MB)

[detmek]

Opus file seams broken. foobar2000 reports this:
https://dl.dropbox.com/u/19804113/Forumi/Slike/Doom9/ScreenShot00010.png
Even with LAV Filters file continues to play after 26th second.

[wanezhiling]

http://samples.mplayerhq.hu/A-codecs/lossless/luckynight.wv

internal Light Alloy/MPC WavPack Source skipped the prelude and the first word "Hi~".

LAV Splitter is ok.

[Aleksoid1978]

http://samples.mplayerhq.hu/A-codecs/lossless/luckynight.wv

internal Light Alloy/MPC WavPack Source skipped the prelude and the first word "Hi~".

LAV Splitter is ok.

do not agree - all normally starts and plays, the "Hi~" starts closer to 2 seconds. Before it plays music.

[wanezhiling]

What i hear is: music + Hi + nice to meet you... with LAV splitter.

But with internal wavpack splitter, What i hear is: 2sec mute + nice to meet you... :rolleyes:

Tested on build 2075 (http://forum.doom9.org/showpost.php?p=1615725&postcount=763)

[Aleksoid1978]

What i hear is: music + Hi + nice to meet you... with LAV splitter.

But with internal wavpack splitter, What i hear is: 2sec mute + nice to meet you... :rolleyes:

Tested on build 2075 (http://forum.doom9.org/showpost.php?p=1615725&postcount=763)

Yes - it is a floating bug. This happens very rarely - and reopen(Ctrl+E) the file helps. I do not know why this happened.

[wanezhiling]

Not a big deal.:)

PS: how to use mpc-be's special youtube feature? Just copy the normal link (example (http://www.youtube.com/watch?v=fWNaR-rxAic)) and Ctrl+O ? You know youtube is blocked in China so I cant try myself...:o

[madshi]

Test on this build - http://aleksoid.voserver.net/MPC-BE/mpc-be.exe_madVR_test_3.7z

But - get_Owner() still does not return the correct value and put_Owner call twice.
Thanks. Your test build does exactly what I was wishing for.

Argh, the MS base classes also blocked get_Owner() when no pins are connected. I've now also overwritten that. Now both put_Owner() and get_Owner() should work fine in this build:

http://madshi.net/madVRputOwner4.rar

[Aleksoid1978]

Not a big deal.:)

PS: how to use mpc-be's special youtube feature? Just copy the normal link (example (http://www.youtube.com/watch?v=fWNaR-rxAic)) and Ctrl+O ? You know youtube is blocked in China so I cant try myself...:o

Yes - you are right.

[turbojet]

Test on this build - http://aleksoid.voserver.net/MPC-BE/mpc-be.exe_madVR_test_3.7z

But - get_Owner() still does not return the correct value and put_Owner call twice.

Thanks. Your test build does exactly what I was wishing for.

Argh, the MS base classes also blocked get_Owner() when no pins are connected. I've now also overwritten that. Now both put_Owner() and get_Owner() should work fine in this build:

http://madshi.net/madVRputOwner4.rar

These 2 fix the problems I was having, thanks! Will the changes be added to official builds?

[Aleksoid1978]

These 2 fix the problems I was having, thanks! Will the changes be added to official builds?

Yes - after weekend :)

[Lord Maius]

Italian txt language file updated (rev.2070)

http://sdrv.ms/YcEPWN

[turbojet]

Some change between 2050-2063 broke seek preview with madvr.

Also when playing over network preview works in xp but not in win7.

[Reino]

Opus file seams broken. foobar2000 reports this:File is perfectly fine. Must be something on your end.

[Internal WavPack Splitter]
- Sometimes it takes 5 seconds before audio is initialized/before you can hear anything.internal Light Alloy/MPC WavPack Source skipped the prelude and the first word "Hi~".Same thing, waneshiling.

Did you manage to reproduce the WavPack and Opus issues, Aleksoid1978?
Who should I ask for the default interface issues?

[kasper93]

:thanks:


PS: Did you notice the different DVB subtitle position between VSFilter and internal sub engine?

VSFilter: http://i.minus.com/iboCSLI8B5Pwu8.png

internal sub engine: http://i.minus.com/ibfQj512qSKvlt.png

It's known issue. DVBsub are SD and video is HD. VSfilter don't scale subtitles, just put them and this happen. Note that ISR also have bug with DVBsub positioning because they are meant to be rendered onto video frame, but they are scaled to the window rect.

[giannifante]

Hello,
I'm using revision 2075 and I get a "File not found" error if I try to play a m3u playlist containing relative paths like this:

# Playlist
.\media\video1.mts
.\media\video1.mts
.\media\video1.mts

Tried both / and \ as a separator, but no luck;
note that version 1.1.3.0 plays the playlist with no problems.
Thanks for help

[Aleksoid1978]

Hello,
I'm using revision 2075 and I get a "File not found" error if I try to play a m3u playlist containing relative paths like this:

# Playlist
.\media\video1.mts
.\media\video1.mts
.\media\video1.mts

Tried both / and \ as a separator, but no luck;
note that version 1.1.3.0 plays the playlist with no problems.
Thanks for help

Fixed.

[giannifante]

Fixed.

Thank you.
Great player and great developers!!

[judelaw]

Hi, I noticed that when mpc-be is maximized and playing a video (or an audio file), the player is still draggable in the video area (it shouldn't be). Also the toolbar area is still draggable and restore the window to original dimensions.

http://i.imgur.com/SZWvnGi.png

Can you try to test this build? : http://www.mediafire.com/download.php?1hxg6dswx3fk5to
Or r2098

[Aleksoid1978]

Some change between 2050-2063 broke seek preview with madvr.


Fixed at 2097.

[^w^ing]

there seems to be a glitch concerning double clicking the video frame to fullscreen, where the whole "fullscreen" video frame can be dragged off-center and after dropped, it locks in place and cannot be moved.

to reproduce from default settings:
- in options/player/keys, set Play/Pause command's Mouse Windowed key to None (default is LeftDown)
- play a video
- double click the video, but dont release the mouse button on the second click. Now drag your mouse and you should be moving the fullscreen video frame. after you release the mouse button, it locks wherever you dragged it and cant be moved anymore.

[Aleksoid1978]

Pretty much the first time I've used MPC-BE and I'd like to report my findings:

[Internal Opus Decoder]
- Choppy seekbar advancement. Position gets updated every second or so. And upon playback, corrupted audio the first second.
It only concerns the decoder, because all is fine with MPC Ogg Source + LAV Audio Decoder. With other Opus decoders it's all smooth.


Fixed at rev. 2106;

[Luyten]

Can you try to test this build? : http://www.mediafire.com/download.php?1hxg6dswx3fk5to
Or r2098

mmmm now if you drag the video area when the player is maximized, the window is restored to original dimensions, but for someone could be little annoying if accidental

there's still the problem with the toolbar area (it restore to original dimensions in a odd way, the player go in the top part of the monitor and you can drag it around but the mouse cursor is near the Windows taskbar!)

[judelaw]

mmmm now if you drag the video area when the player is maximized, the window is restored to original dimensions, but for someone could be little annoying if accidental


so it should be

[Luyten]

so it should be

Ah, ok!

[judelaw]

there's still the problem with the toolbar area (it restore to original dimensions in a odd way, the player go in the top part of the monitor and you can drag it around but the mouse cursor is near the Windows taskbar!)

Windows allows only drag a window for the title. To trick we send a false message (SendMessage(WM_NCLBUTTONDOWN, HTCAPTION, MAKELPARAM(point.x, point.y))) and Windows thinks that the mouse cursor is over the title bar. Therefore, it is sometimes not very nice, we restored the window to its previous state, the mouse cursor and the window in different parts of the screen. :)
But I don't know how to fix this and is it possible? Move the cursor to the window or the window to the cursor?

[detmek]

MPC-BE (and MPC-HC) internal decoders always output 8-bit NV12, even if the input file is, say, 10-bit or YV24 or RGB. Is there any chance to change that so decoder would always output same colorspace as input file, like FFDShow or LAV Video decoder? Tested with H.264 format.

[l0rdraiden]

It's MPC HC BE always based in the lastest MPC HC? Or how is the development?

Are the settings saved in the registry? how can I save them in a file?