Media Player Classic - Home Cinema (MPC-HC) - v1.7.13

[glorp]

Something in recent builds of MPC-HC has broken the advanced subs handling in LAV splitter. If I have an mkv with eng main audio and eng subs (both flagged default, none forced, subs are srt format) and a lav advanced string of "eng:eng|f;eng:off;*:eng;*:*|f" then MPC will still show eng subs if subs are enabled in MPC. I reverted back to build 1.6.6.6464 and that reverses it so that it works as it used to. something between that and current version changed so that the eng : off match no longer works as it did to turn the subs off even when mpc subs are enabled. using evr-cp and dxva.

[nevcairiel]

Here is the callstack (from 1.6.6.6538) where it happens, if anyone wants to look into it:


LAVSplitter.ax!CLAVSplitter::Enable(long lIndex, unsigned long dwFlags) Line 1250 + 0x5d bytes C++
mpc-hc.exe!CMainFrame::UpdateSubtitle(bool fDisplayMessage, bool fApplyDefStyle) Line 13772 C++
mpc-hc.exe!CMainFrame::OpenMediaPrivate(ATL::CAutoPtr<OpenMediaData> pOMD) Line 12016 C++
mpc-hc.exe!CGraphThread::OnOpen(unsigned int wParam, long lParam) Line 82 C++


Edit:
Underground78 said he wants to look into it on the weekend.

[STaRGaZeR]

After a long time I upgraded today from r3946 to r6366, and inmediately noticed an issue with the autofit option (once again). I always have a fixed window size and position, remembered with the "Remember last window position" and "Remember last window size" options. I also use ffdshow to resize everything to screen resolution, so input video to MPC-HC is always 1680x1050. Thanks to the autofit option, each time I opened a video it was resized to fit that fixed window without issues. However in r6366 when the autofit option is enabled it doesn't matter what window size I choose, as long as I open a video MPC resizes the window(!!!) it to an apparent arbitrary size (it's always the same) and even moves(!!!) the window instead of leaving it alone.

I've tried to find the rev that caused this and it was between r4360 and r4902. I can't find any builds between these, anybody got links so I can point to the exact revision that is causing this?

Thanks in advance!

[Qotscha]

Something in recent builds of MPC-HC has broken the advanced subs handling in LAV splitter. If I have an mkv with eng main audio and eng subs (both flagged default, none forced, subs are srt format) and a lav advanced string of "eng:eng|f;eng:off;*:eng;*:*|f" then MPC will still show eng subs if subs are enabled in MPC. I reverted back to build 1.6.6.6464 and that reverses it so that it works as it used to. something between that and current version changed so that the eng : off match no longer works as it did to turn the subs off even when mpc subs are enabled. using evr-cp and dxva.

For me 1.6.6.6500 is the last build where LAV subtitle selection works correctly.

[kasper93]

For now we can use mpc-hc builds older then r6518 (7035e41). Selection of subtitle track through lav splitter menu or navigate menu in mpc-hc doesn't work too, I've reported this to Underground78 some time ago. We need to wait for the fix. It's funny that everyone discover this bug after new LAVF release ;p while the bug is present for some time. Nightly build can be broken once in a while... :)

[Qotscha]

Well, I think this subtitle selection bug was discovered some time ago:

http://forum.doom9.org/showthread.php?p=1610326#post1610326

http://forum.doom9.org/showthread.php?p=1610712#post1610712

It was just rediscovered now :)

[STaRGaZeR]

After a long time I upgraded today from r3946 to r6366, and inmediately noticed an issue with the autofit option (once again). I always have a fixed window size and position, remembered with the "Remember last window position" and "Remember last window size" options. I also use ffdshow to resize everything to screen resolution, so input video to MPC-HC is always 1680x1050. Thanks to the autofit option, each time I opened a video it was resized to fit that fixed window without issues. However in r6366 when the autofit option is enabled it doesn't matter what window size I choose, as long as I open a video MPC resizes the window(!!!) it to an apparent arbitrary size (it's always the same) and even moves(!!!) the window instead of leaving it alone.

I've tried to find the rev that caused this and it was between r4360 and r4902. I can't find any builds between these, anybody got links so I can point to the exact revision that is causing this?

Thanks in advance!

It seems it's r4858 fault. Reverting the GetZoomAutoFitScale function to r4857 fixes the weirdness. I don't get what's the logic of the new function at all TBH, will stay with a custom build with the function reverted.

[Underground78]

It seems it's r4858 fault. Reverting the GetZoomAutoFitScale function to r4857 fixes the weirdness. I don't get what's the logic of the new function at all TBH, will stay with a custom build with the function reverted.

Hmm I'm not sure what you're expecting exactly from Auto-fit but it doesn't seem to be what it really does (and did before). It always has been auto-fit to X% of the screen. Lately the value of X was changed to 75% and it was made a setting the user can change. My guess is that what you really want is in fact having auto-zoom completely disabled.

About the subtitles selection thing, this is a work in progress that it will be fixed one way or another in the next stable. Note that nightly builds can't be expected to be stable! While we are happy that users test them since it helps us fixing bugs we aren't aware of before a stable version is released, you have to keep in mind that those versions are and always will be considered experimental.

[wanezhiling]

http://www.sendspace.com/file/lc1w3a
MPC-HCs Real Video decoder causes a crash, LAV Video decoder is fine.:)

PS: Tested on MPC-HC.1.6.6.6659 x86

[vBm]

http://www.sendspace.com/file/lc1w3a
MPC-HCs Real Video decoder causes a crash, LAV Video decoder is fine.:)

I've just tried this sample under 1.6.5 stable and git HEAD (https://github.com/mpc-hc/mpc-hc/commit/c261330c8e33039b72f7c7e3dc4dcc0a512ec719) and it works just fine. Filter screenshot is here (http://i.imgur.com/At8NXiy.jpg).
Do you have dump file by any chance ?

[wanezhiling]

Do you have dump file by any chance ?
http://www.sendspace.com/file/3n7ax7

PS: I tested on MPC-HC.1.6.6.6659 x86 (http://xhmikosr.1f0.de/mpc-hc/MPC-HC.1.6.6.6659.x86.exe), default setting.

[vBm]

http://www.sendspace.com/file/3n7ax7

PS: I tested on MPC-HC.1.6.6.6659 x86 (http://xhmikosr.1f0.de/mpc-hc/MPC-HC.1.6.6.6659.x86.exe), default setting.

Problem was at ffmpeg (http://git.videolan.org/?p=ffmpeg.git;a=commit;h=c5c2060cf597c8eb5989ca4ba68a1eaeb59f7cdb) side. By mistake sse3 was used and being that my cpu is sse3 capable i didn't experience the problem.

It will be fixed in our next nightly by updating ffmpeg ofc. Thanks for the report.

[wanezhiling]

Thanks for reply, you are right, I tested on an old machine, my other PCs work fine all.

[RedDwarf1]

For anything but 100%, MPC 6.4.9.1 gives a sharper image than MPC-HC 1.5.2.3456 for me.

Using VMR-9 renderless and Bicubic A=-1.0 rendered as a 3D surface. It's quite noticeable.

Has anyone noticed this? Can anyone explain why?

[GrofLuigi]

About file associations on windows 7: I have eliminated the OS's annoyances by elevating, UACing, taking permissions on HKEY_CLASSES_ROOT (both per machine and per user) and whatnot and I want to use the "old" direct method of file association, for example:

[HKEY_LOCAL_MACHINE\SOFTWARE\Classes\.avi]
@=mplayerc64.AVI

[HKEY_LOCAL_MACHINE\SOFTWARE\Classes\mplayerc64.avi]
blah blah... (whatever MPC puts there)

Now I understand it would be undesirable for some/most users to do it that way and I don't have a problem doing that part myself, but I have a question:

In order to further reduce clutter, would MPC-HC mind if I put all associations in one class (the second part, HKEY_LOCAL_MACHINE\SOFTWARE\Classes\mplayerc64.avi or whatever I call it) and have different dot-extensions (the first part) point to it?

I thought I'd ask before I do it... :)

Edit: in other words, will it be surprised/crash if, for example, MKV arrives through registry extension for .AVI? As far as I can see, all shell entries look the same, and of course, I will preserve mime types and other things in the first part for other programs. Is the grouping in options/file associations done just for convenience?

[Armada]

For anything but 100%, MPC 6.4.9.1 gives a sharper image than MPC-HC 1.5.2.3456 for me.

Using VMR-9 renderless and Bicubic A=-1.0 rendered as a 3D surface. It's quite noticeable.

Has anyone noticed this? Can anyone explain why?
I have not noticed anything, do you have this problem on all video files or just some? Could you make a screenshot comparison (http://screenshotcomparison.com/)?

[v0lt]

Attention!
Versions from 6644 to 6666 and have a bug mixer. For example, when mixing from 5.1 to stereo not mixed center channel (and possibly others). This can result to the fact that when watching a movie you will not hear the characters voices.

In the 6667 version of the bug fixed. Been used patch by Aleksoid.

[clsid]

There is a bug in this commit:
https://github.com/mpc-hc/mpc-hc/commit/b69c83f4e586068dace96ef7bdadf433891ab73c

"File > Open DVD/BD" gives error

To fix it
sl.AddTail(CString(Path + _T("BDMV\\index.bdmv")));
should be changed to
sl.AddTail(CString(Path + _T("\\BDMV\\index.bdmv")));
in mainform.cpp

[vBm]

There is a bug in this commit:
https://github.com/mpc-hc/mpc-hc/commit/b69c83f4e586068dace96ef7bdadf433891ab73c

"File > Open DVD/BD" gives error

To fix it
sl.AddTail(CString(Path + _T("BDMV\\index.bdmv")));
should be changed to
sl.AddTail(CString(Path + _T("\\BDMV\\index.bdmv")));
in mainform.cpp

Fixed at 1bac6ce8 (https://github.com/mpc-hc/mpc-hc/commit/1bac6ce838848b52336a7111949f4293a863a6a1)

[Armada]

Attention!
Versions from 6644 to 6666 and have a bug mixer. For example, when mixing from 5.1 to stereo not mixed center channel (and possibly others). This can result to the fact that when watching a movie you will not hear the characters voices.

In the 6667 version of the bug fixed. Been used patch by Aleksoid.
Unfortunately your commit was reverted, because we wanted the problem to be fixed upstream. They've already prepared a fix.

[cca]

Anyone tested these (http://support.amd.com/us/kbarticles/Pages/AMDCatalyst132BetaDriver.aspx) for the 32bit float textures bug?

[kasper93]

@cca: Works fine with this drivers ;)

[cca]

@cca: Works fine with this drivers ;)

Thank you for the feedback, I'll try to install them now then!

[kasper93]

Don't be too exited, they will break it in next WHQL drivers. :scared:

[ageback]

Update S.Chinese.

https://dl.dropbox.com/u/132862/mplayerc.sc.rc.rar

[cca]

Don't be too exited, they will break it in next WHQL drivers. :scared:

ROFL, I'm sure they will :D . I did install this these drivers, seem to work fine with MPC-HC and 32bit floating processing mode. madVR also seems to work, DXVA also works.

[Dstruct]

With MPC-HC 1.6.5.6366 (WinXP SP3) sometimes movie playback doesn't start properly. Status bar says that playback is active but it just hangs at the start of the file. I have to press Stop and Playback and then the movie playback starts. Weird. Never had this with the last stable version ...

I'm just using MPC's internal filters and decoders ...

[luke823]

By any chance, is there any kind of api to embed mpc into another application?

[betaking]

S.Chinese update
http://www.mediafire.com/?sns9y4tcfl1q9ql

[Px]

Small bug: if using Haali Media Splitter, external TrueHD track and internal TrueHD decoder, there are no sound and video played with minutes "jumps". Switching from Haali to internal splitter or switching decoding from internal to ffdshow decoder removes problem.

[Jacinto]

Hi, 2 questions:
How can I drag the player from the screen? (how potplayer o mpc-be) and how can I use the xy filters?, if I drag sub to player, I watch two sub in the screen (not mark "auto-load subtitles")
Please, forgive my english

[betaking]

last git 036ce33ea169006ffec04eb521cacab59a687142 can not compile mpc-hc.exe!
08:33:50.534 2>mplayerc.rc(3128): error RC2104: undefined keyword or key name: Saturation: [C:\mpc-hc\src\mpc-hc\mpc-hc.vcxproj] windows vista sp2,vs2010sp1!
If i use mplayerc.rc form git 64c65c2a3d2fc384822dd35bfdbaaec965b32d0d compile is ok!

[vBm]

As of last night (https://github.com/mpc-hc/mpc-hc/commit/cd48740354b85e9feedf1b12c69e65e29654135a) MPC-HC is digitally signed.

[Superb]

Is the bug w/ LAV Splitter's advanced subtitle handling fixed?

[STaRGaZeR]

Hmm I'm not sure what you're expecting exactly from Auto-fit but it doesn't seem to be what it really does (and did before). It always has been auto-fit to X% of the screen. Lately the value of X was changed to 75% and it was made a setting the user can change. My guess is that what you really want is in fact having auto-zoom completely disabled.

About the subtitles selection thing, this is a work in progress that it will be fixed one way or another in the next stable. Note that nightly builds can't be expected to be stable! While we are happy that users test them since it helps us fixing bugs we aren't aware of before a stable version is released, you have to keep in mind that those versions are and always will be considered experimental.

Nope, I really want to auto fit, as in when I open the video I want it to be auto fitted to a defined window. The old option did just that. The window adapted to aspect ratio too as it should. You are right regarding the old behavior though, it was just my specific situation that led me to incorrect conclusions. However after testing with the old and new algorithms I still don't see the logic in the new function: the window gets autosized to weird sizes depending on the video's aspect ratio and resolution. Window borders seem to be incorrectly calculated too. Not to mention that it's using work area instead of monitor resolution as base for calculations, which is weird.

Thing is that you're trying to achieve different things with the old and new algos. In this case I would have made both available as different options instead of just replacing the old one, since it's easy to do so.

Here's the patch I'm using that adds the old behavior (improved) as another option in the drop down list, feel free to commit it if you like it, as it doesn't touch current behavior. It also modifies the auto fit factor option to accept floats instead of just integers for more fine grained control over the scale factor. For the auto fit old option to work as before, the auto fit factor should be set to 66.66%, which is the value (2/3) that was hardcoded before.

http://www.mediafire.com/?85ddnqq9jwt6ski

[pureocean]

Firstly, I'm sorry, my bad english.

I always use MPC-HC's all standalone filters, expect MPC Video Decoder.
I did a test with DxVA Checker. MPCVideoDec a little better (GPU using more effective!)
than ArcSoft and Cyberlink. Thanks to developers!

Now, I wanted use MPCVideoDec filter. Playing fine but the picture is tears momentarily
when backward and forward (keyboard: left/right keys or on seeking area
from mouse). I can't read very fast subtitles, therefore I frequently use "left arrow" key.

I tried another AVC videos. Same. And tried with PotPlayer and "Mplayer2.exe". Same.
I changed MPCVidDec's settings. Same. WMR-7 and WMR-9, too.

This instant tear issue not happened ArcSoft or CyberLink 264 Filters.

I can't understand. I am just wondering if is it normal? Is MPC's own style, architecture?

My system info:
CPU: AMD Phenom II X3 710
OS: Win2003 sp2, 32-bit
Display: Radeon HD 3200 - Catalyst 13.1
MPCVideoDec.ax: 1.6.6.6739

[clsid]

Is the bug w/ LAV Splitter's advanced subtitle handling fixed?Not yet.

[nuhkka]

anybody know to fix this driver problem i'm having?

for some reason my h.264 videos decoded with dxva look blocky .. i have an intel i3-2120 with hd 2000 igpu .. i have already updated the drivers and the problem proceeds

http://i.imgur.com/Ik6B2QA.jpg

left is a video that is opened without dxva (if i enable dxva in vlc the videos will look blocky as well)

on the right is how my h.264 videos look

[vivan]

Don't use MPC DXVA decoder, use LAV Decoder (http://forum.doom9.org/showthread.php?t=156191) instead (with Intel QS h/w decoder).

[kasper93]

Don't use MPC DXVA decoder, use LAV Decoder instead (with Intel QS h/w decoder).

Great advice. :eek: really... It didn't change anything.

@nuhkka Looks like sharpening filter to me. Disable all video "enhancement" in video card driver settings.

[vivan]

kasper93,
1) I was responding to nuhkka.
2) that is not "sharpening", lol, this is just broken intel dxva implementation.

[vBm]

Building the latest commit failed:
do
git submodule update --init

and then try again.

[ageback]

do
git submodule update --init

and then try again.

Solved now.Thanks!

[v0lt]

I opened mpc-hc.sln. Chose ffmpeg and ran Rebuild.
Resuilt:
1>------ Rebuild All started: Project: ffmpeg, Configuration: Debug Win32 ------
1>Build started 13.02.2013 19:17:16.
1>PrepareForNMakeBuild:
1> Creating directory "...\mpc-hc\bin\lib\Debug_Win32\".
1>CoreClean:
1> make -j1 DEBUG=yes VS2010=yes clean
1> Cleaning ffmpeg...
1> rm -f ../../../bin/lib/Debug_Win32/ffmpeg.lib
1> rm -rf ../../../bin/obj/Debug_Win32/ffmpeg/
1> rm: cannot remove `../../../bin/obj/Debug_Win32/ffmpeg//ffmpeg.log': Permission denied
1> make.exe: *** [clean] Error 1
1>
1> ------------------------------
1> [ERROR] 'make -j1 DEBUG=yes VS2010=yes clean' - failed!
1> ------------------------------
1>
1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.MakeFile.Targets(33,5): error MSB3073: The command "gccbuild.bat Clean x86 Debug Silent Nocolors" exited with code 1.
1>
1>Build FAILED.
1>
1>Time Elapsed 00:00:04.05
========== Rebuild All: 0 succeeded, 1 failed, 0 skipped ==========
If I run the Build, then no problem.

[kasper93]

1> rm: cannot remove `../../../bin/obj/Debug_Win32/ffmpeg//ffmpeg.log': Permission denied
It is because MSVC write log file and "make" is trying to remove it at the same time. We need to improve cleaning in Makefile.

Before you didn't have this error because errorlevel was not reported by gccbuild.bat, it was fixed recently.

EDIT: This should resolve the problem for now. https://github.com/kasper93/mpc-hc/commit/97d037715cf1bb44ca733cfa9492ba6f014936bb

[cogs]

First post, hope this is the right place and you gurus can help.

Using MPC-HC 1.6.4.6052 (32687bc) on Win7 x64. I use D3D fullscreen on the secondary display (which is my TV) and refresh rate "autochange", so video plays on the TV while the MPC-HC window is visible on the PC monitor. Everything works (almost) perfectly, no tearing, beautiful smooth playback, easy to control.

Problem is, with video files that MPC-HC flags as variable frame rate it doesn't "autochange" even though the "properties" dialog shows the correct frame rate, and playback runs at constant frame rate.

I've looked at MKV header info and cannot see anything that flags as variable frame rate. How does MPC-HC determine this? What can be done to force MPC-HC to "autochange" when it incorrectly (or even correctly?) determines a file is variable frame rate?

I have tried remuxing with MKVMerge - this worked for some files but not all. I am open to suggestions as to how to fix files so that MPC-HC can properly determine constant frame rate if that's the solution.

Finally, please, please, please could the developers re-enable the Options and Open File dialogs when a video is playing in D3D fullscreen. Maybe my MPC-HC implementation is unusual but it's effective and I miss being able to fiddle with options, etc. while the kids are watching a movie!

[betaking]

S.Chinese update for last git
http://www.sendspace.com/file/qb3x4s

[nuhkka]

kasper93,
1) I was responding to nuhkka.
2) that is not "sharpening", lol, this is just broken intel dxva implementation.

is this for all intel hd 2000 computers? or could it be a hardware/software problem on my part?

[vivan]

It's software problem - in dxva decoder. Happens with any Intel QuickSync GPU (HD 2000, HD 3000, HD 4000 and so on). Dunno if it's some problem with documention - but almost all dxva decoders are broken (same corruption if not worse (http://3.firepic.org/3/images/2013-02/15/670pb9ez6yfu.png) on videos with high number of reference frames) and there's nothing to do with this. The only two that are working without any problem are eric's ffdshow Intel QS decoder (http://forum.doom9.org/showthread.php?t=162442) (not pure DXVA, though) and nev's LAV Decoder (http://forum.doom9.org/showthread.php?t=156191) (both QS and DXVA).

[betaking]

S.Chinese update for last git
http://www.sendspace.com/file/2n3zt5
fix some wrong translation!