Log in

View Full Version : ffdshow tryouts project: Discussion & Development


Pages : 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 [223] 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308

djesteban
16th March 2010, 20:46
Use http://www.mediafire.com/

Can I upload a 490Mb file there?

Atak_Snajpera
16th March 2010, 21:08
I found small bug in installer

options untouched
http://img41.imageshack.us/img41/5523/new2s.png

but

isCompMgr=0 is not created in registry [SOFTWARE\GNU\ffdshow] . Result ffdshow shows compatibility manager for any unknown file (for example avs2yuv.exe or x264_x86.exe)

Can I upload a 490Mb file there?
zip your file in 100 mb parts

djesteban
16th March 2010, 21:50
zip your file in 100 mb parts

Yeah, that's what I figured.

@clsid
would it be ok if I upload it on netload instead of mediafire? I have an account there... let me know if that is fine with you, else I'll up it on mediafire...

Atak_Snajpera
16th March 2010, 22:01
It does not matter send your sample wherever you want :)

djesteban
16th March 2010, 22:11
It does not matter send your sample wherever you want :)

ok :)

Uploading now, should be done in an hour or something... my upload speed is... :(

djesteban
16th March 2010, 23:35
@clsid and Atak
Click here to get the files (http://netfolder.in/folder.php?folder_id=RW0b0fZ)
Let me know if there's any problem.

JohnTitor
17th March 2010, 20:00
Hey.
I just tried the same video as djesteban. The latest build (rev3316) really screws the image up - anime movies are basically unwatchable (I also tried build rev 3267, it glitches exactly the same way).

Live action seems ok, tough.

If I revert to build revision 3222, everything is ok.

Let me know if you want screenshots, but it looks exactly the same as what esteban posted.

djesteban
17th March 2010, 22:45
Hey.
I just tried the same video as djesteban. The latest build (rev3316) really screws the image up - anime movies are basically unwatchable (I also tried build rev 3267, it glitches exactly the same way).

Live action seems ok, tough.

If I revert to build revision 3222, everything is ok.

Let me know if you want screenshots, but it looks exactly the same as what esteban posted.

...I have to say, I've looked at 30 min of live action footage and indeed, I was not able to see any image corruption... so for some odd, crazy reason, that seems to affect primarily anime/animation/cartoon footage (?!?) if that makes any sense... it has too, I mean it was working fine before...

@clsid
Have you been able to check my sample I uploaded? Let me know if you have any question.

Cheers

STaRGaZeR
18th March 2010, 01:34
Here is a new build with the fixes (http://damienbt.free.fr/ffdshow_rev3309_20100308_dbt_newlibs_beta5.exe)

Nothing done on subtitles side : still issues with semi-transparent subtitles in YUV mode and sometimes some outline of the subtitle box that appears.

Patch (http://damienbt.free.fr/ffdshow_ffmpeglibs_update7.patch)

Sorry for being so late albain, here are the results of the test with newlibs_beta5:

- Resize with bicubic still produces green video, everything else is fixed.
- Deinterlacing, ffmpeg deinterlacers produce a extremely stuttering image, it doesn't look like a perfomance problem, CPU usage is at ~10% while without deinterlacing is at 20% (1080p H.264 high bitrate). That's with the default YUY2 output, with RGB32 I get a black screen. Yadif and the other deints are good.
- Postprocessing, with mplayer checked and YUY2 output, same behavior as deinterlacing: stuttering. RGB32, black screen. Crashes fixed!
- In Blur, stuttering with YUY2 and black screen with RGB32 again when using mplayer temporal noise reducer, it crashed once with error in libavcodec.
- Luminance level fix, stuttering and black screen with YUY2 and RGB32.

I didn't notice any other problems, all the crashes except that ocasional one are gone. Good work, you're almost there!

clsid
18th March 2010, 13:09
I have pinpointed the h264 problem to revision 3256. I will attempt to fix it later.

albain
18th March 2010, 14:56
Hi,

here is a new development build (http://damienbt.free.fr/ffdshow_rev3319_20100318_dbt_newlibs_beta6.exe)with the new ffmpeg scaling/postprocessing libraries.

Fixes : now the DVD subtitles are okay. The fix (committed in previous revision) as well as the new fixes should resolve the last crashing issues that could occur
Bluray subs may be cleaner too

I have also added new functions to the keyboard control : there is now fast forward/rewind commands, and next subtitle stream & next audio stream commands.


Please report back, thanks !

@Stargazer : I don't reproduce the issues you listed in the last build

hoborg
18th March 2010, 15:02
Hi,

I have also added new functions to the keyboard control : there is now fast forward/rewind commands, and next subtitle stream & next audio stream commands.

Please report back, thanks !

Great work!

BTW, it will be good to be able to setup "prefered" audio/subtitle track language :)

hoborg
18th March 2010, 15:39
@albain:

Some quick test with your test build:
- open any MKV video in grapstudio (using MPC-HC MKV splitter), play and click on FFDShow icons = crash
- it looks like FFDshow now refuse to accept AAC audio streams
- subtitles color are white (in graphstudio) even if i setup to use yellow
- hitting CTRL+ALT+F4 cause graphstudio crash instead of next subtitle stream
- FFMPEG-MT causing h.264 video stuttering, libavcodec play fine here on IntelAtom CPU.

...do not have time for more test, hope my report will help you.
Thanks again for your work.

EDIT:
here is test file (http://hobring.esero.net/saf/ffdshow_test.zip) i am working with:

djesteban
18th March 2010, 16:52
I have pinpointed the h264 problem to revision 3256. I will attempt to fix it later.

Are you talking about the problem I reported? Jut want to make sure cause you didn't quote :P

If yes, that's awesome, hope it won't be too hard to fix

sacharja
18th March 2010, 17:04
#3319 is still crashing while seeking when hardware acceleration is enabled.

clsid
18th March 2010, 17:31
Are you talking about the problem I reported? Jut want to make sure cause you didn't quote :P

If yes, that's awesome, hope it won't be too hard to fix
Yes, it is the problem you reported.
Fixing will require some trial and error, but should be doable.

TFM_TheMask
18th March 2010, 18:47
Thanks for the answer Albain. I will post a bug report about this on the tracker. Can you also answer my other question:

Does this mean that when a movie has DTS-HD Master Audio that I can write it to file when connecting ffdshow audio encoder to the Filewriter filter (with PassthroughDTSHD set to 1 in registry) or do I need special hardware for it to work?

Nobody to answer my question above?

STaRGaZeR
18th March 2010, 19:21
Hi,

here is a new development build (http://damienbt.free.fr/ffdshow_rev3319_20100318_dbt_newlibs_beta6.exe)with the new ffmpeg scaling/postprocessing libraries.

Fixes : now the DVD subtitles are okay. The fix (committed in previous revision) as well as the new fixes should resolve the last crashing issues that could occur
Bluray subs may be cleaner too

I have also added new functions to the keyboard control : there is now fast forward/rewind commands, and next subtitle stream & next audio stream commands.


Please report back, thanks !

@Stargazer : I don't reproduce the issues you listed in the last build

Testing is done as always, clean install of ffdshow with everything default, then activating each filter at a time. The results of beta 6 are the same as beta 5. I can reproduce them with all renderers, codecs, etc. so I don't know why you can't.

BTW, the issue with that white shadow in the DVD subs that I uploaded earlier is still there, but I don't know if that's supposed to be fixed in this beta.

Oh and thanks for the new keyboard control features, they're very useful.

albain
18th March 2010, 19:34
Nobody to answer my question above?

This should work as always : in file mode there is a different behaviour for writing the content of the input stream instead of encapsulating it in bitstream format.

However this does not apply to TrueHD : there is special code for this format. So in the TODO list

TFM_TheMask
18th March 2010, 19:36
Ok, looking forward to it.

albain
18th March 2010, 20:58
Testing is done as always, clean install of ffdshow with everything default, then activating each filter at a time. The results of beta 6 are the same as beta 5. I can reproduce them with all renderers, codecs, etc. so I don't know why you can't.

BTW, the issue with that white shadow in the DVD subs that I uploaded earlier is still there, but I don't know if that's supposed to be fixed in this beta.

Oh and thanks for the new keyboard control features, they're very useful.

I noticed this white shadow but I thought that this was normal. Until now the alpha channel was buggy on DVD subs so I don't know if this is normal or not.

EDIT : ok, I nailed it, this was a bug. This will be fixed in the next release
However I don't understand why I can't reproduce your stutterring and black screen issues...

STaRGaZeR
18th March 2010, 21:53
For example:

Everything default (output is YUY2 when using EVR), deinterlacing checked and using 5-tap lowpass (I forced it because the source is progressive, but it doesn't matter):

http://thumbnails25.imagebam.com/7254/87a21372534035.gif (http://www.imagebam.com/image/87a21372534035)

The same, with RGB32 as output. No stuttering but black screen:

http://thumbnails27.imagebam.com/7254/56c45772534039.gif (http://www.imagebam.com/image/56c45772534039)

The bicubic green screen:

http://thumbnails14.imagebam.com/7254/903af472534414.gif (http://www.imagebam.com/image/903af472534414)

clsid
18th March 2010, 22:04
@Atak_Snajpera
Fixed in 3322

@djesteban
Fixed in 3320

albain
18th March 2010, 22:07
Ok, thanks I reproduce it. Don't know why I didn't before

Except the stutterring in YUY2 mode, don't understand why. I thought that it could come from the cpu optimizations but you have an Intel CPU like me.

Color problems are probably due to missing colorspace conversions that I did not import

RGB32 : I don't know why yet but it should be easy to fix (I can see a few pictures before it becomes black)

Betsy25
18th March 2010, 23:39
Is the MPEG2 decoder (libavcodec) broken in rev 3158 ?

I get broken images like below, or video/audio out of sync.

http://i44.tinypic.com/i23lg1.jpg

50 MB sample of problematic behaviour of MPEG2 decoder (libavcodec) on .VOB files.

http://www.mediafire.com/?yynu455wtkz

NiFa
19th March 2010, 01:47
How can I set wanted audio profile to autoload only when playing files from specified folder? I tried volume name match but it didn't work.

albain
19th March 2010, 11:06
@Betsy25: this problem is indeed annoying
I don't have time to work on it. I hope that clsid or Tal will

@Stargazer : this time I think this is good
The bicubic scaler is fixed
The deinterlacers are fixed.

I don't reproduce the stutterring so I hope that this is fixed too

Here is the link (http://damienbt.free.fr/ffdshow_rev3322_20100318_dbt_newlibs_beta7.exe)

New patch (http://damienbt.free.fr/ffdshow_ffmpeglibs_update8.patch)

@developers
It would be great to release a new beta very soon.
Many things have been fixed since beta7 : DXVA2, HD audio, bluray subtitles support

I have nearly finished my work on libswscale and libpostproc libraries, but the commit should done only after this new beta.
What do you think ?

fastplayer
19th March 2010, 11:46
@developers
It would be great to release a new beta very soon.
Many things have been fixed since beta7 : DXVA2, HD audio, bluray subtitles support

I have nearly finished my work on libswscale and libpostproc libraries, but the commit should done only after this new beta.
What do you think ?
I'm for it if we drop the beta-tag.

clsid
19th March 2010, 15:04
I am currently working on automatically using the SVN revision as part of the ffdshow version, like is done in MPC-HC.

Does anyone know what rebase.exe does? It doesn't seem to actually be used right now. So I am thinking of just removing it.

Blight
19th March 2010, 15:52
Hi,
Did something get changed/broken in the FFDShow API?, trying to set a subtitle file using the "IffDecoder2:putParamStrW" function causes ffdshow to throw an Access Violation error.

Also, how do you get BluRay subtitles to load? I tried feeding a BluRay image '.m2ts' file to the gabest mpeg source filter (from MPC-HC) and connecting the video to video pin and the subtitle to text pin (no errors), connected the audio pin to the ffdshow audio decoder and default directsound audio renderer.

I could get the connections working in graph edit, but no subs were showing in the video renderer (I checked the ffdshow subtitle and bluray subtitle configuration pages and everything was enabled).

I the main movie file from both "SpaceBalls" and "The Fifth Element".

STaRGaZeR
19th March 2010, 18:16
@Betsy25: this problem is indeed annoying
I don't have time to work on it. I hope that clsid or Tal will

@Stargazer : this time I think this is good
The bicubic scaler is fixed
The deinterlacers are fixed.

I don't reproduce the stutterring so I hope that this is fixed too

Here is the link (http://damienbt.free.fr/ffdshow_rev3322_20100318_dbt_newlibs_beta7.exe)

New patch (http://damienbt.free.fr/ffdshow_ffmpeglibs_update8.patch)

@developers
It would be great to release a new beta very soon.
Many things have been fixed since beta7 : DXVA2, HD audio, bluray subtitles support

I have nearly finished my work on libswscale and libpostproc libraries, but the commit should done only after this new beta.
What do you think ?

- Bicubic is fixed, however changing the parameter slider produces green garbage on the screen. Also I didn't notice this earlier, Gauss also produces green vertical lines when the parameter slider is over 5.70, so does 2xSaI.
- Deinterlacing, RGB32 still black screen. With YUY2 they work, but only if the content is interlaced. If you force it with a progressive source ffdshow outputs the correct frame rate, but dropping one of each two frames. The result is double speed but same number of frames. I think I know the reason of the stuttering: resolution. When tested with interlaced SD video they work fine, with interlaced HD video they also work fine but I get that stuttering. CPU usage is normal, actually lower than with deinterlacing disabled.
- Postprocessing looks like it doesn't work anymore, I see no changes whatsoever in the image.
- In Blur, libavcodec crash with YUY2 and black screen with RGB32 when using mplayer temporal noise reducer.
- Luminance level fix, it works now with YUY2, but with the double speed thingy. RGB32 is still black.
- I don't know if this beta includes the fix to the white shadow in DVD subs, but it's still there. I've found that it only happens with RGB32 output, YUV is fine.

- NEW ISSUE: NV12 output, black screen with no filters enabled.

BTW, I posted this in the HD audio thread but got ignored, I sometimes get silence when seeking in m2ts files with TrueHD audio, decoded with libavcodec, no bitstreaming. It didn't happen before, but I don't know the exact revision. Has anyone reproduced this?

albain
19th March 2010, 19:13
Hi,
Did something get changed/broken in the FFDShow API?, trying to set a subtitle file using the "IffDecoder2:putParamStrW" function causes ffdshow to throw an Access Violation error.

Also, how do you get BluRay subtitles to load? I tried feeding a BluRay image '.m2ts' file to the gabest mpeg source filter (from MPC-HC) and connecting the video to video pin and the subtitle to text pin (no errors), connected the audio pin to the ffdshow audio decoder and default directsound audio renderer.

I could get the connections working in graph edit, but no subs were showing in the video renderer (I checked the ffdshow subtitle and bluray subtitle configuration pages and everything was enabled).

I the main movie file from both "SpaceBalls" and "The Fifth Element".

Check out the last version I posted on HD audio thread

FFDShowAPI has not changed since a while. I'll take a look at it sometimes.

@Stargazer : thank you for your big todo list ;-)

_xxl
20th March 2010, 06:22
I have nearly finished my work on libswscale and libpostproc libraries, but the commit should done only after this new beta.
What do you think ?
Yes, we should release a new beta soon.

dann23
20th March 2010, 08:25
will someone add support for mpeg2 in dxva?

tal.aloni
20th March 2010, 14:19
regarding releasing a new beta, I personally think that some of the new features are still a work in progress, and I still want to implement a default white list for DXVA like clsid suggested.
(we have to do this in order to avoid problems with many programs)

I think that the updated swscale library should be included and tested before releasing the next beta, but if you all think differently than it's ok by me.

ikarad
20th March 2010, 22:15
Check out the last version I posted on HD audio thread

FFDShowAPI has not changed since a while. I'll take a look at it sometimes.

@Stargazer : thank you for your big todo list ;-)

I try 3326 (version on xvidvideo.ru) rev and It crash when I select bluray subs with YUY 2.

With 3306 it worked
I tried rev3307 and It crash anew with YUY2.
with rev 3306 there is no crash.

Before 3306 it didn't worked. I don't try ffdshow between 3308 and 3325 included.

EDIT: I try also 3222-dbt-newlibs-beta8 and there is the same problem.
EDIT 2: I try with RGB32 and there is no crash but with YUY2 there is crash.

Jeremy Duncan
21st March 2010, 02:01
ffdshow 3326: http://www.mediafire.com/?lftymn35zy2

patch (http://www.mediafire.com/?hezjwyrniym)

The patch offers frame accurate seeking in ffdshow avisynth when normally it wouldn't be available with some filters and settings.

STaRGaZeR
21st March 2010, 05:45
Albain, after applying your beta 8 patch to a clean svn checkout I get the following two errors when compiling:

Error 40 fatal error C1083: Cannot open include file: 'postproc/postprocFilters.h': No such file or directory e:\ffdshow\src\settings\filters\TpostprocSettings.cpp 21
Error 42 fatal error C1083: Cannot open include file: 'postproc/swscale.h': No such file or directory e:\ffdshow\src\mplayer\Tlibmplayer.cpp 24

These two files were removed by the patch itself, the entire src/mplayer/postproc folder is empty. Maybe that's why I didn't see any effect when enabling postprocessing? Did you do a full rebuild of ffdshow?

Also, after putting these two files in there and compile, if you open ffdshow properties when playing a DVD for example (weird because it happens with some files, not all of them), the whole list of filters is missing and the player hangs:

http://thumbnails6.imagebam.com/7289/fb29f772880265.gif (http://www.imagebam.com/image/fb29f772880265)

Sebastiii
21st March 2010, 09:01
ffdshow 3326: http://www.mediafire.com/?lftymn35zy2

patch (http://www.mediafire.com/?hezjwyrniym)

The patch offers frame accurate seeking in ffdshow avisynth when normally it wouldn't be available with some filters and settings.

Thanks :)

ikarad
21st March 2010, 09:26
With 3326 and rgb32 output I find several problems with blu rays subtitles (I can't test with YUY2 because It crash).
1)first problem: some subs are cut (Same problem with 3306 and other ffdshow version untill 3326)
For example there is this sub at 8min33
"Your back is heavy as I catch up to you"

http://nsa14.casimages.com/img/2010/03/21/mini_100321091909495937.png (http://www.casimages.com/img.php?i=100321091909495937.png)
In the video the "you" is cut
http://nsa15.casimages.com/img/2010/03/21/mini_100321092046662446.jpg (http://www.casimages.com/img.php?i=100321092046662446.jpg)

Same problem with this sub at 8min46
in the video "It feels so great when I run throu"
The original sub is
It feels so great when I run through the wind
http://nsa14.casimages.com/img/2010/03/21/mini_100321092808826318.png (http://www.casimages.com/img.php?i=100321092808826318.png)

2) second problemThere is some problems with the time of displaying of subtitles.
For example in this video (that I also give you) The first sub :
1
00:00:09,050 --> 00:00:12,720
'"2015 A.D. Perseus Arm, Milky Way Galaxy
(12,000 arsecs from Earth)'"

is well displayed.
Although the second sub:
http://nsa14.casimages.com/img/2010/03/21/mini_100321090446191729.png (http://www.casimages.com/img.php?i=100321090446191729.png)
the fourth wave of ennemy photons torpedoes is approching
is displayed and is removed immediately. There is no time to read it and it's not normal.

Same problem with this sub
128
00:08:39,143 --> 00:08:44,272
The heat of your body reaches mine
Directors of Photography: Masahide Okino
In the movie it disappeared at 00:08:41 and not at 00:08:44,272

There many other examples in the sample that I give you.

3) Third problem: If I use resize function (lanczos) of ffdshow: the display of subs is very very bad. All subs are displayed in the high left corner instead of the middle of screen and many subs are cut. Sound is cut at some moments.



I give you subtitle file extracted from bluray with suprip (there isn't all subs because ocr with suprip is not perfect)
http://www.zshare.net/info.html?73050006-7d75d90afaea102f4d92066e73874fde

sup file
http://www.zshare.net/info.html?73352376-976374543601cacbaa498463343cacfe

file containing image of all subs (extracted with suprip)
http://www.zshare.net/info.html?73352325-2a933698e98fb8caad63561bdd298763

example
part 1
http://www.zshare.net/info.html?72194780-3f3de5a523000d960412ca4e70f4959e
part2
http://www.zshare.net/info.html?72228704-870148d21c7371e7a2cb0c45e37239c1
part3
http://www.zshare.net/info.html?72228942-da539adec6856595c9fa215e89fcfdf2

part 4
http://www.zshare.net/info.html?72879609-e7005b47f97bd593cc1fac7d6620cda5

part 5
http://www.zshare.net/info.html?72894035-f4d916b0cbd3fbf999835142beff854c
part 6
http://www.zshare.net/info.html?72901975-036b32dfe47b4378533fe6974fb1237c

partie 7
http://www.zshare.net/info.html?72152693-cff6f6453a85c6f497a94c0fc61987f5

albain
21st March 2010, 10:19
@Stargazer : the patch is buggy indeed, I have to make a new one

I am suffering with this new libs, I have fixed the bicubic and gauss resize issues, but I still don't understand why postprocessing does not work

@Ikarad : ok I'll take a look at it this week, thanks for your reports

STaRGaZeR
21st March 2010, 18:14
clsid, after r3323 the icl10 project file has an error:

http://thumbnails25.imagebam.com/7298/5babdd72979526.gif (http://www.imagebam.com/image/5babdd72979526)

As you can see, ffdshow is configured to x64 when buiding for Win32, plus it's actually skipped because it's not selected.

djesteban
21st March 2010, 19:07
@Atak_Snajpera
Fixed in 3322

@djesteban
Fixed in 3320

Thanks! I tested this thoroughly with build 3326 and it now work as expected... no weird image corruption! Happy you could find the culprit!

Eliminateur
22nd March 2010, 04:43
in the RGB wiki help page: http://ffdshow-tryout.sourceforge.net/wiki/video:rgb_conversion there's a link about dithering for img comparison: http://forum.doom9.org/showthread.php?p=1287242#post1287242 which states it tries to make the same result as with deband.
Unfortunately, dithering does not work as expected and has little to no effect(nowhere near deband which produces a "smooth" transition of colors) and increases CPU load enough for my machine not to be able to smoothly play 1080p H264 (Xeon 3075 @3GHz).

It would be interesting to see if the algorithm needs a revision as deband is quite cpu hungry, żis it multithreaded?, żis there any other filter with the same effect and better performance?.

Here are the screenshots showing the difference very clearly(at least in my monitor which has HC range), aoutput is set to RGB32 HQ conversion:
No deband or dither:
http://img707.imageshack.us/img707/7039/nodebandordither.th.png (http://img707.imageshack.us/i/nodebandordither.png/)

Dither only:
http://img402.imageshack.us/img402/6498/ditheronly.th.png (http://img402.imageshack.us/i/ditheronly.png/)

Deband 1.22 and Dither:
http://img201.imageshack.us/img201/6779/debandanddither.th.png (http://img201.imageshack.us/i/debandanddither.png/)

i haven't included a deband-only image as the difference with deband+dither is negligible(the bands are clearly seen and the number of bands is the same, the difference is that some bands are lighter/darker)

it would be good to update the wiki link or a better explanation to prevent banding

madshi
22nd March 2010, 08:10
in the RGB wiki help page: http://ffdshow-tryout.sourceforge.net/wiki/video:rgb_conversion there's a link about dithering for img comparison: http://forum.doom9.org/showthread.php?p=1287242#post1287242 which states it tries to make the same result as with deband.
Unfortunately, dithering does not work as expected and has little to no effect(nowhere near deband which produces a "smooth" transition of colors)
The purpose of dithering in the YCbCr -> RGB conversion is to not introduce any additional banding, respectively to not make source banding more evident/ugly. Basically using dithering produces a more correct image compared to not using dithering. However, dithering (as implemented in the YCbCr -> RGB conversion) does not in any way reduce banding which is hard coded into the source material. In your images you can see that dithering does not reduce the source's banding. However, in the right top of the images the banding steps are more equally spread when using dithering compared to when not using dithering. So it seems to me that dithering does work as intended.

The "deband" post processing aims at detecting and removing banding which is hard coded into the source material. So "deband" has a different purpose compared to the RGB conversion dithering. "deband" is a more complicated algorithm and is expected to consume more CPU power compared to dithering.

I do think the wiki should be changed to make things less confusing. Currently it reads:

"Dithering is an option to enhance visual quality. It reduces banding that RGB conversion tends to add."

I'd replace that with:

"Dithering is an option to maintain the source's full visual quality when doing YCbCr -> RGB conversion. Without dithering RGB conversion can result in added banding."

fastplayer
22nd March 2010, 08:21
I do think the wiki should be changed to make things less confusing. Currently it reads:

"Dithering is an option to enhance visual quality. It reduces banding that RGB conversion tends to add."

I'd replace that with:

"Dithering is an option to maintain the source's full visual quality when doing YCbCr -> RGB conversion. Without dithering RGB conversion can result in added banding."
Done.

albain
22nd March 2010, 12:17
Is it normal that the postprocessing filter is applicable only to the following codecs :
Raw codecs, then :
case CODEC_ID_MPEG1VIDEO:
case CODEC_ID_MPEG2VIDEO:
case CODEC_ID_LIBMPEG2:
case CODEC_ID_MPEG4:
case CODEC_ID_MSMPEG4V1:
case CODEC_ID_MSMPEG4V2:
case CODEC_ID_MSMPEG4V3:
case CODEC_ID_H263:
case CODEC_ID_SVQ1:
case CODEC_ID_FLV1:
case CODEC_ID_INDEO2:
case CODEC_ID_INDEO3:
case CODEC_ID_XVID4:
case CODEC_ID_MJPEG:
case CODEC_ID_MJPEGB:
case CODEC_ID_MSVIDEO1:
case CODEC_ID_CINEPAK:
case CODEC_ID_VP5:
case CODEC_ID_VP6:
case CODEC_ID_VP6F:


For example it is disabled for H264 formats

STaRGaZeR
22nd March 2010, 13:29
I don't think that's normal, you should be able to apply postprocessing to all sources if you want to.

fastplayer
22nd March 2010, 14:04
For example it is disabled for H264 formats
Yep, doesn't make much sense for it to be enabled for H.264 content.

Snowknight26
22nd March 2010, 17:54
You mean disabled?