ffdshow tryouts project: Discussion & Development

[albain]

Thanks albain. Now subs are shown correctly with ffdshow DXVA (subs are completly white on my sample), but MPC-HC still crash a lot when I select the subtitle of the .m2ts file. (with Haali and with Matroska internal filter)

In DXVA mode only ?

[onomatopellan]

No, it crash with normal ffdshow too. If I pause the video in MPC-HC I can advance some frames with right arrow key but after that always crash. I think it crash in the frame where subtitles should appear.

Also I have no crash using the mpc-hc internal filters instead ffdshow.

[STaRGaZeR]

Albain, I have problems with DVD subs using r3283:

http://thumbnails5.imagebam.com/6925/a2218e69247353.gif (http://www.imagebam.com/image/a2218e69247353)

These are supposed to be yellow without any transparency. Happens with RGB and YUV output.

[ikarad]

Everything should be fixed in revision 3283 :

- DVD menus
- Bluray subs with YUV colorspaces
- MKV support for bluray subtitles

There is a bug in Haali splitter (or rather a support to be added) : the PGS subtitles don't have any media subtype in the output pin of Haali's. Don't tried with MPC matroska splitter

TODO/TOFIX :
- Bilinear scaling in RGB mode (only bluray subs may use this scaler)
- Bluray subtitles support from file (.sup)

With ffdshow 3283 there is many crashs

I give you an example in 7 parts (there are many problems with blu-rays subtitles with rev 3277 and the example that I give you show you the different problems (some subtitles are cut in the middle, some subtitles are not synchronized, some subtitles are not displayed), but with rev 3283 it's impossible to notice if these problems are corrected because there are too crashs)

part 1
http://www.zshare.net/info.html?72194780-3f3de5a523000d960412ca4e70f4959e
part2
http://www.zshare.net/info.html?72228704-870148d21c7371e7a2cb0c45e37239c1
part3
http://www.zshare.net/info.html?72228942-da539adec6856595c9fa215e89fcfdf2

part 4
http://www.zshare.net/info.html?72879609-e7005b47f97bd593cc1fac7d6620cda5

part 5
http://www.zshare.net/info.html?72894035-f4d916b0cbd3fbf999835142beff854c
part 6
http://www.zshare.net/info.html?72901975-036b32dfe47b4378533fe6974fb1237c

partie 7
http://www.zshare.net/info.html?72152693-cff6f6453a85c6f497a94c0fc61987f5

bugtracker
https://sourceforge.net/tracker/?func=detail&aid=2957087&group_id=173941&atid=867360

[onomatopellan]

With ffdshow 3283 there is many crashs

I give you an example in 7 parts (there are many problems with blu-rays subtitles with rev 3277 and the example that I give you show you the different problems (some subtitles are cut in the middle, some subtitles are not synchronized, some subtitles are not displayed), but with rev 3283 it's impossible to notice if these problems are corrected because there are too crashs)

part 1
ikarad, that's not a sample, that's an entire movie! Get rid of those links ASAP or you will be in trouble.
you can make a 50Mb sample with tsMuxeR for example.

[ikarad]

ikarad, that's not a sample, that's an entire movie! Get rid of those links ASAP or you will be in trouble.
you can make a 50Mb sample with tsMuxeR for example.

No it's not an entire movie. It's just a sample. I'm not stupid because I know that upload an entire movie is forbidden.
The movie is a 120 min duration.
The sample is 12 min duration. It's just a sample.

50 mb of the movie is just 20 seconds of the movie. It's just totaly useless. It's a blu-ray not a simple dvd or divx. One minute of blu-ray movie is nearly 300 mb, not 30 mb.

The time of the sample is 12 minutes because problems with subtitles appear between 8 minutes and 11 minutes.
If I use tsremux to cut just between 8 minutes and 11 minutes, subtitles are disappeared. To have subtitles with tsremux I must cut since the start of the movie.

[onomatopellan]

oh, sorry in that case.

[DigitalDeviant]

No it's not an entire movie. It's just a sample. I'm not stupid because I know that upload an entire movie is forbidden.
The movie is a 120 min duration.
The sample is 12 min duration. It's just a sample.

50 mb of the movie is just 20 seconds of the movie. It's just totaly useless. It's a blu-ray not a simple dvd or divx. One minute of blu-ray movie is nearly 300 mb, not 30 mb.

The time of the sample is 12 minutes because problems with subtitles appear between 8 minutes and 11 minutes.
If I use tsremux to cut just between 8 minutes and 11 minutes, subtitles are disappeared. To have subtitles with tsremux I must cut since the start of the movie.

I use Tsmuxer (from my MeGui install w/ a GUI) set for Blu-ray disc output to split BR from the middle of a file and the subs display fine.

[albain]

I am downloading your sample.

Otherwise I have committed fixes today on DVD menus and subs

[STaRGaZeR]

Otherwise I have committed fixes today on DVD menus and subs

Much better. But there's still some crap around the subs:

http://thumbnails6.imagebam.com/6938/cff36569375357.gif (http://www.imagebam.com/image/cff36569375357)

[Kado]

DFX v9.x (http://www.fxsound.com/) for winamp does not appear in the winamp dsp list on ffdshow. DFX v8.5x does. Maybe it's related to the "64bit support" they added?

[Mercury_22]

I have a problem with some files with AC3 which are not playing over HDMI, HDMI set as "Default Device" NOT as Pass-through / Bitstream, tested with x64 and x86 ( both ICL and normal ) versions

The same files are playing well with my Speakers or Headphones set as "Default Device".

Behavior:
When I'm using Windows Media Center or Windows Media Player the player refuse to play the file ( "Windows Media Player encountered a problem while playing the file" ) but when I'm using MPC-HC it takes a few good seconds to start playing or I need to click on the image to start playing
Tested with Haali ( manual registered ) and MPC-HC splitters, also if i use any other filter / decoder for ac3 like MPC-HC's or the one from WMC / WMP the same files are playing OK

Everything with default settings, clean windows install, FFD only audio, FFD video not used, ( do not use merit), VSFilter from http://www.xvidvideo.ru/2009-10-22-10-49-14/doc_download/3163-standalonefilters-svn1694x64.html

Sample (http://sharebee.com/d93dbc05)

EDIT: I've managed to narrow down the "location" of the problem : If I unregister the VSFilter the problem it's solved so now I'm confuse cause for other files also with AC3 the combination VSFilter & FFD audio it's working OK with HDMI set as "Default Device" and as I've said before VSFilter & FFD it's also working OK for this files (those with problems) with Speakers or Headphones set as "Default Device" !

EDIT 2: Same thing it's happening with FFD's internal subtitles but if I enable the subtitles or if I change the "Default Device" from Speakers to HDMI after I start playing everything it's working OK

[hoborg]

Otherwise I have committed fixes today on DVD menus and subs

:thanks:

BTW, do you think it will be possible to use DVD navigation + enabled crop in future?
I am using crop to remove black borders from MPEG-2 stream (analog TV), but if crop is enabled, DVD navigation is broken (wrong higlighted position of buttons).

[Leak]

I am using crop to remove black borders from MPEG-2 stream (analog TV), but if crop is enabled, DVD navigation is broken (wrong higlighted position of buttons).
Make sure the "Subtitle" filter comes before the "Crop" filter in ffdshow's filter list - that way the subtitles are etched into the picture before cropping.

Of course, if your problem are the mouseover areas rather than the highlight - well, that can't be fixed as it's up to the player and the DVD navigator to figure out where the mouse is, and those expect the image to be totally unaltered (at least as far as changing the visible portion of the image is concerned).

You can, however, ditch the mouse for DVD navigation and use the keyboard or a remote - those are of course not affected by this problem.

[hoborg]

Make sure the "Subtitle" filter comes before the "Crop" filter in ffdshow's filter list - that way the subtitles are etched into the picture before cropping.

Of course, if your problem are the mouseover areas rather than the highlight - well, that can't be fixed as it's up to the player and the DVD navigator to figure out where the mouse is, and those expect the image to be totally unaltered (at least as far as changing the visible portion of the image is concerned).

You can, however, ditch the mouse for DVD navigation and use the keyboard or a remote - those are of course not affected by this problem.

Thanks for info!
I didnt known i can move up/down by filters :)
It is working fine now.
I am using remote to navigate so position is no problem too :)

Thanks again.

[albain]

Much better. But there's still some crap around the subs:

http://thumbnails6.imagebam.com/6938/cff36569375357.gif (http://www.imagebam.com/image/cff36569375357)

Ok, I'll fix this

Is there a way you send me those subs (the edges are helpful for testing) ?

[Casshern]

Hi Albain,

Is there any news on this audio bug, which affects almost all criterion blu rays (they mostly use mono):

I made a small 5 sec sample, where you can hear the bug pretty clearly. Interestingly the video ends after 5 seconds and the audio is still playing another 5 seconds with mpc hc + ffdshow(as a audio decoder) at half speed:

http://www.mediafire.com/file/omtnmdnjiyy/sample.m2ts

Thanks very much for looking at this.

[STaRGaZeR]

Those subs come from a series of 10 DVDs, the funny thing is that DVD1 is wrong, while DVD7 is OK for example. There are problems with the menus too, so I'm sending you the whole menu and one minute of actual footage. Select play or episode 1 -- prologue, otherwise MPC-HC will hang because of the missing files. The setup and extras menu are still images, and they're not displayed properly, moving the mouse over the buttons or using the keyboard does nothing. The subtitle track is the one selected here:

http://thumbnails3.imagebam.com/6954/9167eb69531025.gif (http://www.imagebam.com/image/9167eb69531025)

http://www.megaupload.com/?d=P0S0TZN7 (247MB!!)

[tal.aloni]

Casshern,
I've further investigated your mono sample today:
I think this is a MPC-HC Mpeg splitter bug,
I don't have any problem with haali media splitter.

Regards,
Tal

[Casshern]

Casshern,
I've further investigated your mono sample today:
I think this is a MPC-HC Mpeg splitter bug,
I don't have any problem with haali media splitter.

Regards,
Tal
Thanks, i will try my luck the mpc hc forum, then!

[Xorp]

Everything should be fixed in revision 3283 :

- DVD menus
- Bluray subs with YUV colorspaces
- MKV support for bluray subtitles

There is a bug in Haali splitter (or rather a support to be added) : the PGS subtitles don't have any media subtype in the output pin of Haali's. Don't tried with MPC matroska splitter

TODO/TOFIX :
- Bilinear scaling in RGB mode (only bluray subs may use this scaler)
- Bluray subtitles support from file (.sup) How will this work if mkvmerge cannot mux sups into mkvs?

[leeperry]

I see that ffdshow video has hotkeys available....ffdshow audio does not? is there anyway whatsoever to set hotkeys on the volume filter? :(
I use Kernel Streaming in S/PDIF w/ headphones on this thing: http://thumbnails26.imagebam.com/6959/64690369587192.gif (http://www.imagebam.com/image/64690369587192)

I can't control volume at all, and KMixer is unbearable on XP...bummer #_#

I've also looked for winamp/VST plugins that would allow hotkeys for volume control...but no luck.

[tal.aloni]

Hi Xorp, I'm a big fan!

I think MakeMKV can mux .sup into mkvs,

hopefully mkvmerge will add support in the future, now that there is a filter that can play this format properly.

also, albain pointed out that with some development, you could just put the .sup file in the movie directory, without need to mux.

Tal

[tal.aloni]

leeperry,
you should look into automation software like girder.

[leeperry]

leeperry,
you should look into automation software like girder.
and what would that do for me? I would need two hotkeys in ffdshow audio to play w/ the attenuation of the "volume" filter...I think I'm SOL :(

isn't there a way through some DLL call or registry entry to do that? because I'm good w/ assigning hotkeys/actions to my Griffin Powermate http://t2.gstatic.com/images?q=tbn:vfcuznsdCgjjLM

[tal.aloni]

leeperry, it would be smarter to control the master volume.
I'm sure a device that was designed to look like a knob can somehow do that, (and if it doesn't, and you can surely do that with girder's help).

[ikarad]

I try ffdshow rev 3287 and video crash at each time subtitles must be displayed. There is the same problem like with 3285
https://sourceforge.net/tracker/?func=detail&aid=2959481&group_id=173941&atid=867360

[tal.aloni]

yes, the crash happen because YV12 is not supported right now by one of the scaler methods.

albain is working on it.

[ikarad]

yes, the crash happen because YV12 is not supported right now by one of the scaler methods.

albain is working on it.

Although in ffdshow I ony check YUY 2 and not YV12.
Although with RGB 32 it works partially.
If I turn on subtitles from the start of the sample, video crash. If I turn on after the first subtitle, video doesn't crash.

I try with another blu-ray movies and It crash at each time even with rgb32

update: I don't use dxva

[ikarad]

With RGB 32, There are some problems with subtitles.
1) Some subtitles appears with a time delay after the voice.

example, this subtitle appears with 1-2 seconds later
124
00:08:27,381 --> 00:08:28,590
Passing through the scorching sunshine
Storyvoards and Settings vy: Shinji Higuchi

I give you subtitle file extracted from bluray
http://www.zshare.net/info.html?73050006-7d75d90afaea102f4d92066e73874fde

2) some subtitles are cut
example in this screen: the last word is cut
http://nsa13.casimages.com/img/2010/02/26/mini_100226113716480529.jpg (http://www.casimages.com/img.php?i=100226113716480529.jpg)

example of video that I give the page before

part 1
http://www.zshare.net/info.html?72194780-3f3de5a523000d960412ca4e70f4959e
part2
http://www.zshare.net/info.html?72228704-870148d21c7371e7a2cb0c45e37239c1
part3
http://www.zshare.net/info.html?72228942-da539adec6856595c9fa215e89fcfdf2

part 4
http://www.zshare.net/info.html?72879609-e7005b47f97bd593cc1fac7d6620cda5

part 5
http://www.zshare.net/info.html?72894035-f4d916b0cbd3fbf999835142beff854c
part 6
http://www.zshare.net/info.html?72901975-036b32dfe47b4378533fe6974fb1237c

partie 7
http://www.zshare.net/info.html?72152693-cff6f6453a85c6f497a94c0fc61987f5

https://sourceforge.net/tracker/?func=detail&aid=2959562&group_id=173941&atid=867360

[leeperry]

leeperry, it would be smarter to control the master volume.
no windows master volume over S/PDIF.

[tal.aloni]

no windows master volume over S/PDIF.

are you doing realtime encoding to S/PDIF? why can't you use the receiver to control the volume?

[leeperry]

are you doing realtime encoding to S/PDIF? why can't you use the receiver to control the volume?
I've plugged my headphones directly to the 2 boxes you're seeing...besides I don't like analog volume attenuation, as it increases distortion/kills the stereo balance on stepless pots...and stepped pots are just very inaccurate: http://www.bursonaudio.com/hp_volume_control.htm

I'm outputting bit-perfect stereo PCM over KS in S/PDIF...and no windows volume works at all. anyway, I will look for other solutions now ;)

[Shark007]

To control the volume from the PC rather than from the amplifier when using spdif digital output, go to the 'Control Panel | Sound' applet and double click the spdif output device. Go to the Advanced tab and uncheck the two Exclusive Mode boxes.

[fastplayer]

@clsid:
In rev3289 you changed the tool tip text for decoding threads to "Only for ffmpeg-mt H.264 and libavcodec MPEG-1/2 decoder". What does this mean now when using libavcodec for H.264 decoding?

[clsid]

libavcodec will use only 1 thread for H.264. The MT patch that we used for libavcodec no longer works properly and was removed a while ago.

For multi-threaded H.264 decoding you should select ffmpeg-mt.

[jimwhite]

I've plugged my headphones directly to the 2 boxes you're seeing...besides I don't like analog volume attenuation, as it increases distortion/kills the stereo balance on stepless pots...and stepped pots are just very inaccurate: http://www.bursonaudio.com/hp_volume_control.htm

I'm outputting bit-perfect stereo PCM over KS in S/PDIF...and no windows volume works at all. anyway, I will look for other solutions now ;)

:confused::rolleyes: This is funny.... all over the internet audio fanatics are espousing analog volume control over digital for the same reasons !!! :D

so tell me... how does a resistive voltage divider create distortion? Keep it technical now, no hyperbole... I are an engineer !! :p

[fastplayer]

libavcodec will use only 1 thread for H.264. The MT patch that we used for libavcodec no longer works properly and was removed a while ago.

For multi-threaded H.264 decoding you should select ffmpeg-mt.
Bear with me because I don't get it. :o
In MPlayer you can pass "-lavdopts threads=X" as an argument to tell libavcodec how many threads to use for H.264 and MPEG-2 decoding. Has this been removed now in Mplayer or is it because of some limitation in ffdshow? The MT patch was exclusive to ffdshow only, right?

[clsid]

@Albain
I noticed your intention to update libswscale. If you or anyone else is going to attempt that, I have some suggestions:
1) Make it part of libavcodec.dll instead of mplayer.dll. That is more natural since libswscale has become part of FFmpeg. They also share code.
2) Try to migrate Haruhiko's custom multi-threaded resizing code.
3) Wait until the current major changes in ffdshow are stable. (DXVA and HD audio bitstreaming)
4) First update our libavcodec with pixfmt updates from FFmpeg. That has been on my ToDo list for a while now.

[clsid]

Bear with me because I don't get it. :o
In MPlayer you can pass "-lavdopts threads=X" as an argument to tell libavcodec how many threads to use for H.264 and MPEG-2 decoding. Has this been removed now in Mplayer or is it because of some limitation in ffdshow? The MT patch was exclusive to ffdshow only, right?
There are mplayer builds based on ffmpeg-mt too. Plain libavcodec is not multi-threaded for H.264. You can tell it to use X threads, but it won't help increase performance.

[fastplayer]

There are mplayer builds based on ffmpeg-mt too. Plain libavcodec is not multi-threaded for H.264. You can tell it to use X threads, but it won't help increase performance.
Oh, I assumed it was but only for slice-based encodes.
Anyway, let's hope they merge ffmpeg-mt soon with the main branch. :)

[tetsuo55]

@Albain
I noticed your intention to update libswscale. If you or anyone else is going to attempt that, I have some suggestions:
1) Make it part of libavcodec.dll instead of mplayer.dll. That is more natural since libswscale has become part of FFmpeg. They also share code.
2) Try to migrate Haruhiko's custom multi-threaded resizing code.
3) Wait until the current major changes in ffdshow are stable. (DXVA and HD audio bitstreaming)
4) First update our libavcodec with pixfmt updates from FFmpeg. That has been on my ToDo list for a while now.
Additionally, it would be great if ffmpeg updates in the future would be more easy and natural, we should be as close to ffmpeg git as possible.

[tal.aloni]

we should be as close to ffmpeg git as possible.

so say we all!

[fastplayer]

so say we all!
Yeah, let the Cylons do all the code grunt work! :D
I miss BSG... :-(

[leeperry]

how does a resistive voltage divider create distortion? Keep it technical now, no hyperbole... I are an engineer !! :p
yay, we has a technician in teh house! well uLilith does 64bit float volume attenuation...this is the highest quality of volume attenuation you can possibly have(it also decodes lossy audio and applies DSP such as VST plugins in 64fp too http://forum.slysoft.com/images/smilies/agreed.gif).

here's why audioholics ppl prefer stepped attenuators:
http://diyaudio.co.kr/wwwboard1/data/board1/compare.pdf
http://www.dact.com/html/attenuator_data_sheet.html
http://www.bursonaudio.com/hp_volume_control.htm

I know the Burson ppl quite well...when they say that stepless pots are evil, I very much trust them.

and the top of the line ALPS pots cost +$300...a cheapo analog stepless pot is junk...many cheap headphones amps have major stereo imbalance issues at low volume.
To control the volume from the PC rather than from the amplifier when using spdif digital output, go to the 'Control Panel | Sound' applet and double click the spdif output device. Go to the Advanced tab and uncheck the two Exclusive Mode boxes.
thanks! but I'm allergic to anything newer than XP, it makes my eyes bleed for some reason.

[Astrophizz]

If you're worried about the quality of a voltage divider (noise from tiny thermal shifts in resistors and any possible minute non-linearity caused by that) then what's going in the the rest of the circuits in a sound system should give you nightmares.

[albain]

@Albain
I noticed your intention to update libswscale. If you or anyone else is going to attempt that, I have some suggestions:
1) Make it part of libavcodec.dll instead of mplayer.dll. That is more natural since libswscale has become part of FFmpeg. They also share code.
2) Try to migrate Haruhiko's custom multi-threaded resizing code.
3) Wait until the current major changes in ffdshow are stable. (DXVA and HD audio bitstreaming)
4) First update our libavcodec with pixfmt updates from FFmpeg. That has been on my ToDo list for a while now.

Appart Haruhiko's code on multithreaded and that I isolated from the rest, this is very difficult to figure out what code has been added/modified. For example I saw MMX2 optimizations that are not in the current ffmpeg code.
I spent (and lost) a lot of time to merge the old and new sources.
I'd rather think that it is a better idea to take a fresh new start with the last code, and why not from ffmpeg directly.
But this is a big work because :
1/ several filters use mplayer library to do some resize (resize filter, subtitles filter,...) => TODO : replace mplayer by ffmpeg
2/ one defined other pixel formats : FF_CSP* for ffdshow, PIX_FMT* for ffmpeg, and IMG_FMT* for mplayer. So rework is necessary => TODO : replace the colorspace conversions where IMG_FMT* are used with PIX_FMT*
3/ Haruhiko's patch for MT resize

We miss Haruhiko ... :rolleyes:

This was not expected and I am not ready to do this right now, more urgent stuff to do (on Media Control).
If Tal's patch is enough for now, we can carry on with it until some better rework is done on resize libraries.

From my point of view HD audio is tabilized for now, just some special stuff is needed for xonar users.

About DXVA : alpha blending to be done

[dann23]

where is Haruhiko??? :)

[albain]

Also I realized that libswscale (ffmpeg) is not compatible with mingw64 yet, so this is a nogo for now

[Maccara]

Also I realized that libswscale (ffmpeg) is not compatible with mingw64 yet, so this is a nogo for now

"hack" which makes it compilable:

diff --git a/swscale_template.c b/swscale_template.c
index bbd9a1f..45e0ca5 100644
--- a/swscale_template.c
+++ b/swscale_template.c
@@ -2497,7 +2497,7 @@ static inline void RENAME(hcscale_fast)(SwsContext *c, int16_t *dst,
/* GCC 3.3 makes MPlayer crash on IA-32 machines when using "g" operand here,
which is needed to support GCC 4.0. */
#if ARCH_X86_64 && AV_GCC_VERSION_AT_LEAST(3,4)
- :: "m" (src1), "m" (dst), "g" (dstWidth), "m" (xInc_shr16), "m" (xInc_mask),
+ :: "m" (src1), "m" (dst), "g" ((x86_reg)dstWidth), "m" (xInc_shr16), "m" (xInc_mask),
#else
:: "m" (src1), "m" (dst), "m" (dstWidth), "m" (xInc_shr16), "m" (xInc_mask),
#endif


This was posted to ffmpeg devel (don't remember by who) and dismissed promptly (don't care by who). Haven't seen anything else regarding this since, but works for me, so I have no idea why it was not an acceptable patch.

(probably because it will cause problems with some compilers, but works ok with mingw64 4.4.3, though, so I don't give a damn)

I'm not at all familiar with the swscale code, so I'm not sure if that is a completely valid patch, but you might want to evaluate it and try to push it forward if it seems ok. Also, I have no idea if there are other problems still.