ffdshow tryouts project: Discussion & Development

[haruhiko_yamagata]

In all my mpeg1 25 fps 320x240 video files seeking does not work (freeze) when decoding with libMpeg2 (libavcodec is ok)!
Tested on WINXp sp3 x86, MPC and WMP11, ffdshow beta6 and latest build rev2913
CPU core 2 duo 6550, nvidia 630i/7100 motherboard
Can anybody confirm the bug?
I can't reproduce. Could you send us a sample?

[haruhiko_yamagata]

In 2895 huffyuv encoding is broken, in the output vid appears a black bar of 16 pixels on the right


-
downloaded here http://www.free-codecs.com/download/FFDshow.htm
on source forge there is another version, 2527 ,where to dl the right then?
-
same prob also with 2913, dont find the 2914
-
back to the 2527, it is ok
I don't have time to look into this for now. Sorry.

[haruhiko_yamagata]

Why would the thread crash ?
The lock is necessary if the variable may be modifed while another thread is reading it. Is it the case here ?

This problem seems to occur when there are several instances of FFDShow running at the same time to extract a frame and build the thumbnails.
I think that the crash occurs because the threads termination is close to the thread creation (extracting one frame is very fast) and maybe before.
I am trying to output the error code that is generated by the assertion, it will explain the exact cause
I found latter half of TglyphThread is over written by garbage (0xcdcd in debug build) when it crashes. It may or may not be related to subtitles.

[haruhiko_yamagata]

I found I had to protect thread creation by mutex. Is this expected? I suspect a bug of boost.
Boost must start a thread after synchronization of CPU memory cache, mustn't it?

[clsid]

I haven't tested the latest revision yet, I am building as I write this. But the crashes happened with all filters disabled, so no subtitles were involved.

[haruhiko_yamagata]

The thread is created even if there is no subtitles.

[clsid]

I have just completed a quick test on Vista x64 and ffdshow did not cause a crash :) So the problem seems to have been solved. Nice work guys ;)

[albain]

Nice work to Haruhiko who fixed the problem

[rack04]

Have there been any reports of broken LPCM decoding with ffdshow? I converted a truehd audio track from an evo file to w64 using eac3to. I then muxed the w64 audio track to m2ts using tsMuxeR. Here is a sample:

http://www.megaupload.com/?d=QT69TJXU

The audio plays using MPC-HC internal LPCM decoder and LPCM Audio Decoder (low merit) but the volume is very low.

[tetsuo55]

Is this conclusion correct:

When using a 7.1 LPCM 24/192 capable hdmi output:

I can listen to lossless(un-downconverterd 24/192):
*Dolby TrueHD and older versions
*DTS in all flavours except MA? (or is the DTS-HD not supported at all)
*LPCM in all flavours

What combination of settings would i need for this?

[clsid]

I can confirm that LPCM decoding is broken.

[mark0077]

Just posting two bugs, one of which is not really a bug but something haruhiko talked about some time ago that I think should be fixed.

Bug 1) ffdshow not loaded bug when ffdshow allows no output type to be entered. If for example a user has yv12 selected as the only output type (common for me and others) and then goes to enable "Set interlace flag in output media type", then hit save. In this scenario, yv12 would have been darkened out as not usable, but the user can still save and will then be shocked to see ffdshow doesn't load..... This has caught me out a few times over the last few months. A fix would be to popup a dialog saying please select an output type if one either isn't chosen at all, or those that are chosen are not usable due to other output options.

Bug 2) ffdshow resize problem with DVD's. I think haruhiko already knows this one well enough, where DVD's may not look in the right aspect ratio when going through ffdshow's resize. haruhiko proposed enforcing 4:3 or 16:9 as the only possible DVD aspect ratios and converting incorrect ones to one or the other somehow (as far as I know renderers are doing this workaround for us already, but in this case ffdshow would have to do the same workaround). I would love to start using ffdshow's resize but can't because of this.

[clsid]

Please post both on the SourceForge bugtracker, so they won't be forgotten.

[Mercury_22]

have there been any reports of broken lpcm decoding with ffdshow? I converted a truehd audio track from an evo file to w64 using eac3to. I then muxed the w64 audio track to m2ts using tsmuxer. Here is a sample:

http://www.megaupload.com/?d=qt69tjxu

the audio plays using mpc-hc internal lpcm decoder and lpcm audio decoder (low merit) but the volume is very low.

yes !i can't play (some) files with lpcm sound stream(s) although mpc-hc's internal lpcm filter it's playing fine the same file(s). (ffdshow svn 2913 default settings)

is this a known problem (bug) ?

Can this be fixed ?

sample (http://rapidshare.com/files/226414424/lpcm_test.m2ts.html) or mirror (http://www.megaupload.com/?d=ao7343up)

[haruhiko_yamagata]

Just posting two bugs, one of which is not really a bug but something haruhiko talked about some time ago that I think should be fixed.

Bug 1) ffdshow not loaded bug when ffdshow allows no output type to be entered. If for example a user has yv12 selected as the only output type (common for me and others) and then goes to enable "Set interlace flag in output media type", then hit save. In this scenario, yv12 would have been darkened out as not usable, but the user can still save and will then be shocked to see ffdshow doesn't load..... This has caught me out a few times over the last few months. A fix would be to popup a dialog saying please select an output type if one either isn't chosen at all, or those that are chosen are not usable due to other output options.

Bug 2) ffdshow resize problem with DVD's. I think haruhiko already knows this one well enough, where DVD's may not look in the right aspect ratio when going through ffdshow's resize. haruhiko proposed enforcing 4:3 or 16:9 as the only possible DVD aspect ratios and converting incorrect ones to one or the other somehow (as far as I know renderers are doing this workaround for us already, but in this case ffdshow would have to do the same workaround). I would love to start using ffdshow's resize but can't because of this.
OK, I can reproduce.

[ikarad]

I knew it, please add delay (in the dialog 'Delay:' plus 'Keys & remote' numpad + and -) until I have time to fix it.
excuse me to disturb you
I would like to known if you expect to fix this problem soon or later (some months for example)?

[haruhiko_yamagata]

excuse me to disturb you
I would like to known if you expect to fix this problem soon or later (some months for example)?
Sorry, it is technically very difficult. Hopeless for now.

[fastplayer]

Sorry, it is technically very difficult. Hopeless for now.
Is reverting to pre-2833 behavior an option? Or are the changes made in 2833 required for the post-2833 revisions?

[jos99]

I have a problem with ffdshow and MPEG2 TV in DVBViewer- if I have "set interlace flag in output media type" selected (for hardware deinterlacing) and the aspect ratio changes, I get 2 problems-

(i) with libavcodec the video freezes but sound carries on

(ii) with libmpeg2 DVBViewer closes

This does not happen with any other MPEG2 decoder (using XP SP3, 64x2 5000+, 780G, 3200 HD gfx, 8.12 Catalyst, 2GB RAM).

[haruhiko_yamagata]

Is reverting to pre-2833 behavior an option?
Yes, I'll revert it.

[haruhiko_yamagata]

Bug 2) ffdshow resize problem with DVD's. I think haruhiko already knows this one well enough, where DVD's may not look in the right aspect ratio when going through ffdshow's resize. haruhiko proposed enforcing 4:3 or 16:9 as the only possible DVD aspect ratios and converting incorrect ones to one or the other somehow (as far as I know renderers are doing this workaround for us already, but in this case ffdshow would have to do the same workaround). I would love to start using ffdshow's resize but can't because of this.
If you are using Media Player Classic, uncheck “View” → “Video Frame” → “Keep Aspect Ratio”.
http://ffdshow-tryout.sourceforge.net/wiki/video:resize_aspect#example

I've written that long before and forgotten about it.

[haruhiko_yamagata]

I have a problem with ffdshow and MPEG2 TV in DVBViewer- if I have "set interlace flag in output media type" selected (for hardware deinterlacing) and the aspect ratio changes, I get 2 problems-

(i) with libavcodec the video freezes but sound carries on

(ii) with libmpeg2 DVBViewer closes

This does not happen with any other MPEG2 decoder (using XP SP3, 64x2 5000+, 780G, 3200 HD gfx, 8.12 Catalyst, 2GB RAM).
Rev 2394 may fix the issues. Please try when it is available.

[jos99]

Rev 2394 may fix the issues. Please try when it is available.
Thanks- I take it you mean 2934?

[haruhiko_yamagata]

Oops, it's 2934.

[jffulcrum]

Build 2936 on xvidvideo.ru contains broken libmplayer.dll, all players crashes on them if its functions (like post-processing) used in ffdshow. Clisd build from sourceforge.net unaffected.

[haruhiko_yamagata]

Build 2936 on xvidvideo.ru contains broken libmplayer.dll, all players crashes on them if its functions (like post-processing) used in ffdshow. Clisd build from sourceforge.net unaffected.Perhaps it's GCC 4.4.1.
It works for me. What is your CPU? Mine is Core2 Quad Q6600.

[jos99]

Oops, it's 2934.
OK I tried with 2936 (clsid and icl10), and I still get the same issue- sample:

http://rapidshare.com/files/229019781/05-04_12-13-18_ITV3_1__eng__Kojak.ts

with libmpeg2 DVBViewer closes/crashes at about 11 seconds into the clip, with libavcodec the video freezes at about 11 seconds, but sound carries on.

[Rumbah]

I hope this hasn't been posted before so here's a little? feature request:

ffdshow already notices which application called it. So it would be great if you could specify options for a specific application, for example leave it as it is for general purpose and enabling HQ RGB output for the media players. Now I just have to switch between these two options and hope that I do not forget to switch back to YV12 for encoding purposes.

[haruhiko_yamagata]

OK I tried with 2936 (clsid and icl10), and I still get the same issue- sample:

http://rapidshare.com/files/229019781/05-04_12-13-18_ITV3_1__eng__Kojak.ts

with libmpeg2 DVBViewer closes/crashes at about 11 seconds into the clip, with libavcodec the video freezes at about 11 seconds, but sound carries on.
Thanks, I can reproduce now.

[mark0077]

haruhiko, I still get DVD menu freezes with a couple of my DVD's. I can upload a sample of a simple DVD menu that freezes about 75 percent of the time when clicking "English" at the first menu.

mpc-hc shows about 20 frame drops each time this menu is shown so those are the two problems I still see with DVD menu's. Let me know if you need a sample.

EDIT: Wow very strange, i actually clicked "English" a couple of minutes ago and left the dvd menu frozen while I wrote this post, then all of a sudden the second menu of this dvd appeared. The frame drops is still at 20 so its like part of the ffdshow code got stuck / slowed down ALOT when drawing the second menu. 5 minutes to draw a menu is certainly not expected.

[clsid]

I hope this hasn't been posted before so here's a little? feature request:

ffdshow already notices which application called it. So it would be great if you could specify options for a specific application, for example leave it as it is for general purpose and enabling HQ RGB output for the media players. Now I just have to switch between these two options and hope that I do not forget to switch back to YV12 for encoding purposes.
That is already possible. See Profiles/Presets in ffdshow configuration.

[haruhiko_yamagata]

haruhiko, I still get DVD menu freezes with a couple of my DVD's. I can upload a sample of a simple DVD menu that freezes about 75 percent of the time when clicking "English" at the first menu.

mpc-hc shows about 20 frame drops each time this menu is shown so those are the two problems I still see with DVD menu's. Let me know if you need a sample.

EDIT: Wow very strange, i actually clicked "English" a couple of minutes ago and left the dvd menu frozen while I wrote this post, then all of a sudden the second menu of this dvd appeared. The frame drops is still at 20 so its like part of the ffdshow code got stuck / slowed down ALOT when drawing the second menu. 5 minutes to draw a menu is certainly not expected.Thanks for testing. Please send me a sample.

[Rumbah]

That is already possible. See Profiles/Presets in ffdshow configuration.

Ah, great, sorry for requesting then, I never saw the option and even now it took me a minute or two to find it ;) . I hope there comes a day when graphic cards can convert correctly to the right colorspace ;) .

[alter4]

Originally Posted by jos99
OK I tried with 2936 (clsid and icl10), and I still get the same issue- sample:

http://rapidshare.com/files/22901978..._eng__Kojak.ts

with libmpeg2 DVBViewer closes/crashes at about 11 seconds into the clip, with libavcodec the video freezes at about 11 seconds, but sound carries on.

May be this have some clashes with this bug (http://forum.doom9.org/showthread.php?p=1279113#post1279113)
I forgot to tell the video freezes, but sound carries on in my case too.
Also I can't reproduce this bug at my work computer - Core duo 6550, intel G31 motherboad. Very strange.
Are there any problem with CPU type optimization when compilation?

[STaRGaZeR]

haruhiko,

ffmpeg-mt
fix blocky noise (one of some blocky bugs)

Works like a charm with several Blu-ray samples that were corrupted before. Nicely spotted.

[SBeaver]

In case someone missed my post in the mpc-hc thread, here is my sample of mono lpcm in m2ts:
http://www.mediafire.com/?1xvbq0jg2jj

As this fails to decode properly in both mpc and ffdshow, I hope it will intrest you also.

[Mr VacBob]

Sorry for disappearing, I have free time now and will restart ffmpeg-mt work tomorrow.


ffmpeg-mt
fix blocky noise (one of some blocky bugs)


That's of course the right fix (why didn't I notice dequant_coeff pointers weren't constant...) but it should update them to point to h->dequant_buffer instead of the other thread context, otherwise I think there can be a race condition with 2 threads if the other thread changes PPS again. I'll do that one.

[haruhiko_yamagata]

it should update them to point to h->dequant_buffer instead of the other thread context, otherwise I think there can be a race condition with 2 threads if the other thread changes PPS again. I'll do that one.Yeah, I can understand the point though I've never imagined that.

I've been tackling an issue with a file I've sent to you (full_metal_panic_blocky_at_100-105sec_with_ffmpeg-mt.m2ts) for these three days. It's MBAFF, and only B frames (spatial direct) are affected. I have gotten no clue except that it's a race condition. It's really difficult.

[ikarad]

Yeah, I can understand the point though I've never imagined that.

I've been tackling an issue with a file I've sent to you (full_metal_panic_blocky_at_100-105sec_with_ffmpeg-mt.m2ts) for these three days. It's MBAFF, and only B frames (spatial direct) are affected. I have gotten no clue except that it's a race condition. It's really difficult.

Ffdshow 2939 corrects some bugs of my blu-rays. But there is still some bugs of decoding (some blocks appear)
Nevertheless, these bugs don't appeared at the same moment and if I rewind the video and I read anew, sometimes there isn't the problem. It appears at random.

I also notice that when I use Telecide with avisynth (inverse telecine filter), these bugs appear more often.
my parameters with Telecide
http://nsa08.casimages.com/img/2009/05/07/mini_090507063345702457.jpg (http://www.casimages.com/img.php?i=090507063345702457.jpg)

an example
http://www.zshare.net/info.html?59712928-5e4c8510a933ca124bc6be2a49b78b18

video captured by fraps to show the problem
http://www.zshare.net/info.html?59711834-c5dad6225a37f7583d272485d86e8f20

[STaRGaZeR]

I get those Avisynth problems too. They make TIVTC and Decomb pretty useless.

[therealjoeblow]

The "set interlace flag in output media type" (formerly called HW deinterlacing) doesn't appear to be working for me. I tried it in several recent builds from 2880 to the current 2918, and it doesn't seem to do anything (XP32-SP3, VMR7 or VMR9, using ffdshow libmpeg2 to decode DVD's). When enabled, the video is still showing combing just the same as when it's disabled, it doesn't seem to trigger the hardware deinterlacing routines. PDVD and TheaterTek do, when their "use hardware accelerator" tickbox is enabled DVD's get deinterlaced by the video card.

I tried on 2 different machines, one has a gigabyte mb with an AMD 780G chipset (Radeon HD3200) and the other one has an asus mb with an AMD 690 chipset (Radeon X1250). I tried on several different versions of Catalyst, including the latest v-9.4 and it doesn't seem to make any difference, hardware deinterlacing never actually gets invoked with this ffdshow setting.

I did some more testing on this on my Dell Laptop with an Intel Mobile 965 Express IGP, WinXP32 SP3, ZoomPlayer6 (entirely different hardware platform than my other 2 desktop machines) and the following occur:

1) With OUT resize: The hardware deinterlacing DOES get enabled properly with the Overlay Mixer or Haali renderer. It does NOT with VMR7 or VMR9 (windowed, windowless or renderless).

2) With resize enabled: Hardware deinterlacing does not get enabled with any of the renderers. Never.

[edit - just checked when I got home; it does exactly as above with both of the ATI machines too, works with overlay and no resize, not with VMR or resize on]

Any idea if this is a bug that can be fixed? I see this behavior on three different hardware platforms, and can't seem to get it to work as I hoped.

[STaRGaZeR]

Are you trying to resize prior to deinterlacing? Very bad idea.

[khagaroth]

HW deinterlacing only works if the output color space is NV12, YUY2 or UYVY (in order of preference). NV12 is the only color space that supports VectorAdaptive and MotionAdaptive deinterlacing that gives the best results.

[FredThompson]

HuffYUV appears broken in recent builds. When I try to read and write to the HuffYUV format with VirtualDub there is a vertical black stripe down the extreme right edge in the input. This does not happen with the actual HuffYUV filter from Ben.

[clsid]

It helps if you can find the latest build that did work. That makes it easier for us to find when/where the bug was introduced.

[FredThompson]

I'll be quite happy to find the most recent build which works for HuffYUV. How do I see a list of all builds? SourceForge wants to show only the most recent few builds.

[tetsuo55]

How do I see a list of all builds?http://www.xvidvideo.ru/content/category/1/4/5/ (builds are compiled every few revisions, but this at least narrows it down)

[clsid]

If you look closely on the SourceForge page, you'll find hundreds of old builds:
https://sourceforge.net/project/showfiles.php?group_id=173941&package_id=199416&release_id=436746

[avivahl]

Two questions after installing rev. 2941:
1. Which is better for DVD MPEG2 decoding- libmpeg2 or libavcodec? Performance-wise? Speed-wise (on Core 2 Duo E6750)? Any known bugs for any of them? A short answer will be great (not looking into getting to technical stuff).
2. Currently, subtitle rendering seems (as far as I can see) to be aligned in a weird way. Some lines are a bit higher than previous ones. Here are two (http://i40.tinypic.com/r1c2ea.jpg) shots (http://i41.tinypic.com/okonep.jpg) demonstrating the issue (I saved them with low quality to have smaller files; look at the end-of-line dot).

[lych_necross]

@avivahl
1.) On my system, libmpeg2 is better. Its very stable and has decent performance. If you are looking for speed, download ffdshow-mt (might not be very stable).

2.) If you use ffdshow for subtitles, you might need to adjust the alignment of the subtitles on the subtitle tab. Try adjusting the horizontal/vertical positions and the alignment and see if that helps. If that doesn't work, try using directvobsub instead of ffdshow for subtitles.