Log in

View Full Version : ffdshow tryouts project: Discussion & Development


Pages : 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 [133] 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308

Carpo
12th February 2009, 13:44
Update your graphics driver.

it is the latest 181.22

Mercury_22
12th February 2009, 13:52
I have very bad (choppy ?!) video with some AVC files
Can anyone tell me what I'm doing wrong ? (default settings in FFD)
I've tested the same files (same MPC-HC settings too) with other avc filters and even MPC-HC's internal filter (DXVA only) it's better ! :confused: So it's definitely something wrong with FFD or my settings :confused:
:helpful:


Sample (http://rapidshare.com/files/197184924/TestAVC.m2ts.html)

clsid
12th February 2009, 14:16
it is the latest 181.22
I am pretty sure there are newer drivers than that.
A workaround that you could try is this:
Set Edge enhancements and Noise reduction to 20% in the NVIDIA control panel.

This problem is not caused by ffdshow.

Carpo
12th February 2009, 14:18
if you mean beta drivers i guess there is, but im usin latest whql ones, i have seen that fix advised before, i'll give it a try

mark0077
12th February 2009, 16:47
... or keep colors in nv12 all the way up to renderer which will do conversion to rgb in graphic card.

Actually no, on both of my nvidia cards, 7600GT and GTX295, nvidias nv12 to rgb32 conversion is HORRIBLE. yv12 to rgb32 conversion is perfect. I am updating my dvd quality thread at the moment and my findings on nv12 stand, it doesn't always provide the best quality colors, need more nvidia users to confirm this as an nvidia issue.

rt87
13th February 2009, 02:21
just found that when using ffdshow to decode sowt audio, it reduces playback speed alot.

Snowknight26
14th February 2009, 03:12
With r2671, when I have a 24-bit FLAC source connected to ffdshow via madFLAC, ffdshow seems to output '32-bit integer.' Is it upsampling the audio, zeroing the extra 8 bits, or what? Shouldn't it only output '24-bit integer,' assuming I have 16, 24, 32-bit and 32-bit floating point all checked in the Output?

Also, for consistency's sake, shouldn't there be a '-' between ## and bit under Output considering there is one on the tool tip when Extended info is checked?

haruhiko_yamagata
14th February 2009, 04:52
I have very bad (choppy ?!) video with some AVC files
Can anyone tell me what I'm doing wrong ? (default settings in FFD)
I've tested the same files (same MPC-HC settings too) with other avc filters and even MPC-HC's internal filter (DXVA only) it's better ! :confused: So it's definitely something wrong with FFD or my settings :confused:
:helpful:


Sample (http://rapidshare.com/files/197184924/TestAVC.m2ts.html)
It's just performance problem.
ffmpeg-mt + yadif(single) + RGBhq is OK on my Core2 Quad 6600.
libavcodec (normal) + YV12 is not OK.
To enjoy yadif in double frame rate, we need better CPU.

albain
14th February 2009, 13:20
This patch will allow the audio decoder to connect to the ArcSoft Demux and decode EAC3 audio tracks. It also defines the wFormatTag as WAVE_FORMAT_DTS_HD instead of WAVE_FORMAT_DTS_W when the media subtype is MEDIASUBTYPE_ARCSOFT_DTSHD.

Index: src/ffdshow_mediaguids.h
===================================================================
--- src/ffdshow_mediaguids.h (revision 2672)
+++ src/ffdshow_mediaguids.h (working copy)
@@ -394,6 +394,7 @@

DEFINE_GUID(MEDIASUBTYPE_NERO_MLP ,0x1e889be7, 0xb276, 0x4064, 0x9a, 0x39, 0x16, 0x0a, 0x06, 0x89, 0x5b, 0x52);
DEFINE_GUID(MEDIASUBTYPE_ARCSOFT_MLP ,0x4288b843, 0x610b, 0x4e15, 0xa5, 0x3b, 0x43, 0x00, 0x7f, 0xcf, 0xf6, 0x14);
+DEFINE_GUID(MEDIASUBTYPE_ARCSOFT_DDPLUS ,0x71cfa727, 0x37e4, 0x404a, 0xae, 0xc0, 0x34, 0x84, 0x25, 0x32, 0xef, 0xf7);
DEFINE_GUID(MEDIASUBTYPE_SONIC_MLP ,0x4094a857, 0x7891, 0x44ac, 0x92, 0xb5, 0xc1, 0xcf, 0xf3, 0x7a, 0xf2, 0xe7);
DEFINE_GUID(MEDIASUBTYPE_ARCSOFT_DTSHD ,0xf6498f57, 0xb399, 0x4a43, 0xa6, 0xfa, 0xf6, 0x94, 0xad, 0x42, 0xb9, 0xbe);
DEFINE_GUID(MEDIASUBTYPE_DOLBY_DDPLUS ,0xa7fb87af, 0x2d02, 0x42fb, 0xa4, 0xd4, 0x5, 0xcd, 0x93, 0x84, 0x3b, 0xdd);
Index: src/TffDecoder_reg.cpp
===================================================================
--- src/TffDecoder_reg.cpp (revision 2672)
+++ src/TffDecoder_reg.cpp (working copy)
@@ -435,6 +435,7 @@
{ &MEDIATYPE_Audio , &MEDIASUBTYPE_Vorbis2 },
{ &MEDIATYPE_Audio , &MEDIASUBTYPE_VorbisIll },
{ &MEDIATYPE_Audio , &MEDIASUBTYPE_ARCSOFT_MLP },
+ { &MEDIATYPE_Audio , &MEDIASUBTYPE_ARCSOFT_DDPLUS },
{ &MEDIATYPE_Audio , &MEDIASUBTYPE_ARCSOFT_DTSHD },
//{ &MEDIATYPE_Audio , &MEDIASUBTYPE_EAC3 },
{ &MEDIATYPE_Audio , &MEDIASUBTYPE_PCM },
Index: src/TffdshowDecAudio.cpp
===================================================================
--- src/TffdshowDecAudio.cpp (revision 2672)
+++ src/TffdshowDecAudio.cpp (working copy)
@@ -212,7 +212,7 @@
wFormatTag=WAVE_FORMAT_VORBIS;
else if (mt.subtype==MEDIASUBTYPE_DOLBY_AC3)
wFormatTag=WAVE_FORMAT_AC3_W;
- else if (mt.subtype==MEDIASUBTYPE_DTS || mt.subtype==MEDIASUBTYPE_ARCSOFT_DTSHD)
+ else if (mt.subtype==MEDIASUBTYPE_DTS)
wFormatTag=WAVE_FORMAT_DTS_W;
else if (mt.subtype==MEDIASUBTYPE_DVD_LPCM_AUDIO)
wFormatTag=WAVE_FORMAT_LPCM;
@@ -233,9 +233,9 @@
else if (mt.subtype==MEDIASUBTYPE_DOLBY_TRUEHD || mt.subtype==MEDIASUBTYPE_NERO_MLP
|| mt.subtype==MEDIASUBTYPE_ARCSOFT_MLP || mt.subtype==MEDIASUBTYPE_SONIC_MLP)
wFormatTag=WAVE_FORMAT_MLP;
- else if (mt.subtype==MEDIASUBTYPE_DOLBY_DDPLUS)
+ else if (mt.subtype==MEDIASUBTYPE_DOLBY_DDPLUS || mt.subtype==MEDIASUBTYPE_ARCSOFT_DDPLUS)
wFormatTag=WAVE_FORMAT_EAC3;
- else if (mt.subtype==MEDIASUBTYPE_DTS_HD)
+ else if (mt.subtype==MEDIASUBTYPE_DTS_HD || mt.subtype==MEDIASUBTYPE_ARCSOFT_DTSHD)
wFormatTag=WAVE_FORMAT_DTS_HD; // TODO : define a separate codecId for DTSHD when available
else
{


Thank you for your patch. I am testing it and working on bugfixes on this part.

Mercury_22
14th February 2009, 13:31
It's just performance problem.
ffmpeg-mt + yadif(single) + RGBhq is OK on my Core2 Quad 6600.
libavcodec (normal) + YV12 is not OK.
To enjoy yadif in double frame rate, we need better CPU.

So MPC-HD's internal DXVA AVC it's more performant (with my 4670) than FFD's AVC (+ my E8400 )?! :confused: That's strange I've alway thought that MPC's AVC it's slower than FFD !
Anyway :thanks:

P.S. any news about ffmpeg-mt 64-bit ?

mark0077
14th February 2009, 14:54
Now that I see colorspace conversion is looking excellent... I would love to build up a list of benchmarks for improving interlaced vs progressive frames... which has been a plague to dvd quality playback for im sure all of us, certainly me and my friends. Before I go about trying to come up with a list of tests.... I am just wondering does anyone know if I can use hardware deinterlacing as a step before ffdshow... like the following

ffdshow libavcodec mpeg2 decoder -> output in original colorspace with interlace flag -> deinterlaced by hardware -> back to ffdshow for colorspace conversion and other stuff -> output to renderer

Is this possible? I am watching alot of material the last few days and I can say there is that little improvement in deinterlacing when using hardware over yadif... I am just greedy and want the best of both worlds ;) Do you think this could be possible?

Leak
14th February 2009, 15:03
Do you think this could be possible?
Sorry, but I don't think so.

Hardware deinterlacing happens in the video renderer when the image is on the graphics card already; but there's no way to read it back in a graph, filter it then send it to the renderer again - same problem as with DXVA decoded video.

It should, however, be possible to do proper colorspace conversion with the interlaced image before handing it to the renderer, but I'm not sure whether hardware deinterlacing works with/is applied to RGB images - I rather doubt it...

np: Yage - He Laughed Himself To The Centre (The Woodlands Of Old)

mark0077
14th February 2009, 15:14
Thanks Leak. Yeah it seems hardware deinterlacing is dependent upon the colorspace its given, at least on my nvidia cards. Oh well.... trying to familiarize myself with the following dvd player benchmarks http://www.hometheaterhifi.com/volume_10_1/dvd-benchmark-guide-to-progressive-scan-shootout-1-2003.html to see how we could come up with software tests..

Its really the only annoying thing in my setup at the moment, having to manually enable or disable deinterlacing for dvd's. Interesting stuff.... I would love to see ffdshow on that site as no1 for ... well all of the benchmarks they come up with :D:D Its probably completely a libavcodec and libmpeg2 thing.. with the correctly set flags being sent to ffdshow maybe.

albain
14th February 2009, 15:24
Hi,

I think I have fixed the bugs remaining on HD audio formats :

MLP/Dolby True HD sound garbled with heavy jiter
LPCM tracks from blurays : sound was garbled


Fixed in revision 2682.
Please report if there are still issues.

Regards,

Damien BT

ikarad
14th February 2009, 15:47
Hi,

I think I have fixed the bugs remaining on HD audio formats :

MLP/Dolby True HD sound garbled with heavy jiter
LPCM tracks from blurays : sound was garbled


Fixed in revision 2682.
Please report if there are still issues.

Regards,

Damien BT
where can we download this version? Because here
https://sourceforge.net/project/showfiles.php?group_id=173941
the last version is 2676

and www.xvidvideo.ru doesn't work

albain
14th February 2009, 17:05
where can we download this version? Because here
https://sourceforge.net/project/showfiles.php?group_id=173941
the last version is 2676

and www.xvidvideo.ru doesn't work

I am currently building one. Please wait for a while...

ikarad
14th February 2009, 17:14
I am currently building one. Please wait for a while...

thanks

clsid
14th February 2009, 17:38
New build is online.

Brazil2
14th February 2009, 17:55
New build is online.
Does this build include Whurlston's patch (http://forum.doom9.org/showthread.php?p=1247644#post1247644) ?

And if so, is there any chance for an ICL10 build ? Please :)

clsid
14th February 2009, 18:05
The patch was committed to SVN, so yes it is included.

I don't have time right now for an ICL build. Those are available when they are availabe.

Atak_Snajpera
14th February 2009, 18:20
P.S. any news about ffmpeg-mt 64-bit ?
or just -mt 32bit?

ikarad
14th February 2009, 18:21
Hi,

I think I have fixed the bugs remaining on HD audio formats :

MLP/Dolby True HD sound garbled with heavy jiter
LPCM tracks from blurays : sound was garbled


Fixed in revision 2682.
Please report if there are still issues.

Regards,

Damien BT
thanks,
MLP seems to work well with my blu-rays.
But with LPCM there is still problems.
1) If in audio menu of MPC-HC, MLP is the first selected ffdshow is loaded
http://nsa05.casimages.com/img/2009/02/14/mini_090214061811672392.jpg (http://www.casimages.com/img.php?i=090214061811672392.jpg)

and I can select select LPCM soudntrack.
http://nsa05.casimages.com/img/2009/02/14/mini_090214062001829470.jpg (http://www.casimages.com/img.php?i=090214062001829470.jpg)


Now, if in audio menu of MPC-HC there is no MLP soundtrack, FFSDHOW isn't loaded even if LPCM decoder isn't selected in MPC-HC. Although LPCM is selected in codec from ffdshow audio
http://nsa05.casimages.com/img/2009/02/14/mini_090214062154461511.jpg (http://www.casimages.com/img.php?i=090214062154461511.jpg)
http://nsa05.casimages.com/img/2009/02/14/mini_090214062234286479.jpg (http://www.casimages.com/img.php?i=090214062234286479.jpg)
http://nsa05.casimages.com/img/2009/02/14/mini_090214062322248103.jpg (http://www.casimages.com/img.php?i=090214062322248103.jpg)

2) With MLP soundtrack
the current input bitrate line works well
http://nsa05.casimages.com/img/2009/02/14/mini_090214062548411407.jpg (http://www.casimages.com/img.php?i=090214062548411407.jpg)

But with LPCM soudntrack this line is always 0.
http://nsa05.casimages.com/img/2009/02/14/mini_090214062709130792.jpg (http://www.casimages.com/img.php?i=090214062709130792.jpg)


the example with only lpcm tracks
example with lpcm 2.1 and lpcm 6.1 soundtrack
http://www.zshare.net/info.html?55241905-3d52058746470a1fa90c6eed8b81c6ea

bugtracker
https://sourceforge.net/tracker2/?func=detail&aid=2600248&group_id=173941&atid=867360

Leak
14th February 2009, 18:39
or just -mt 32bit?
It's been merged into the trunk - just download clsid's rev. 2684 build and choose "ffmpeg-mt" as the H.264 codec...

np: Humanoid - 3AM And Feeling OK (King Roc Mix) (Your Body Robotic (Disc 1))

fofwp
14th February 2009, 20:28
I am trying to get TrueHD decoding to work with ffdshow. The movie is Tropic Thunder, and I created the m2ts file using Ts4Np v0.8.2.0. I had Bypass audio alignment and Use async I/O unchecked.

When I try to play the file back in MPC-HC, no audio is decoded. I have set ffdshow as preferred in external filters, and have set all stable formats to libavcodec. I am using Haali Media Splitter. Is there something I am doing wrong?

clsid
14th February 2009, 20:46
Try with the internal MPEG splitter of MPC-HC. I don't think Haali Media Splitter recognizes TrueHD yet.

albain
14th February 2009, 20:54
thanks,
MLP seems to work well with my blu-rays.
But with LPCM there is still problems.
1) If in audio menu of MPC-HC, MLP is the first selected ffdshow is loaded
and I can select select LPCM soudntrack.
Now, if in audio menu of MPC-HC there is no MLP soundtrack, FFSDHOW isn't loaded even if LPCM decoder isn't selected in MPC-HC. Although LPCM is selected in codec from ffdshow audio
2) With MLP soundtrack
the current input bitrate line works well

But with LPCM soudntrack this line is always 0.
the example with only lpcm tracks
example with lpcm 2.1 and lpcm 6.1 soundtrack

Ok, I will check after these. I had noticed the 1st problem (FFDShow not loaded for LPCM) and I had to force the submediatype in MPC-HC so that it would load it.
I didn't realized that this was a ffdshow bug too.

Concerning ICL10, my build is also posted and they all are built with ICL 10.1


*EDIT* : problem #1 is fixed in revision 2686. Problem #2 is minor, I will look after it when I will have time

albain
14th February 2009, 21:40
I posted an updated build (this is not a race I know) : build 2686 including LPCM fix (I hope)

Regards,

Damien BT

fofwp
14th February 2009, 21:44
Try with the internal MPEG splitter of MPC-HC. I don't think Haali Media Splitter recognizes TrueHD yet.

Yep that did the trick. Thanks.

Snowknight26
14th February 2009, 21:55
ffdshow's grab function takes screenshots with bad colors:
http://www.stfcc.org/misc/ffdshow.r2686.png
http://www.stfcc.org/misc/mpc-hc.r990.png

The filter chain was something like Haali Media Splitter -> ffdshow (decoding H.264) -> ffdshow (decoding YV12 - took screenshot) -> Renderer (in MPC-HC).

chros
14th February 2009, 22:44
It's been merged into the trunk - just download clsid's rev. 2684 build and choose "ffmpeg-mt" as the H.264 codec...

Woow !!!
But, is it possible that I can't select it in the config panel???
I selected during install, but in the config it shows an empty value, and at the info page it displays: libavcodec h.264 ...

ikarad
14th February 2009, 22:49
I posted an updated build (this is not a race I know) : build 2686 including LPCM fix (I hope)

Regards,

Damien BT

Yes it works.
Thank you very much.

Atak_Snajpera
15th February 2009, 00:32
I selected during install, but in the config it shows an empty value, and at the info page it displays: libavcodec h.264 ...
I have no problems.

whurlston
15th February 2009, 06:38
Thank you for your patch. I am testing it and working on bugfixes on this part.No problem. Thanks for all the hard work on HD audio in general. I was just doing the easy part. I'm new to the whole patching thing and C++ is not one of my strengths so please excuse any newbie errors.

haruhiko_yamagata
15th February 2009, 07:14
Woow !!!
But, is it possible that I can't select it in the config panel???
I selected during install, but in the config it shows an empty value, and at the info page it displays: libavcodec h.264 ...
Can you find pthreadGC2.dll in your system32 directory?

chros
15th February 2009, 11:51
Can you find pthreadGC2.dll in your system32 directory?
and @ Atak_Snajpera: thanks, I just needed a reboot ... :(

Jeremy Duncan
15th February 2009, 14:35
I have a bug report for the developers.

This is the script that causes the player to crash:
________ advanced ffdshow: framerate doubler. For ntsc(60hz) and pal(50hz) monitors. ________ (http://forum.doom9.org/showthread.php?t=115727)
Click link and look for configuration.
All the plugins and sw used is in that thread.
I use media player classic from that thread.
This is on xp pro media center edition, all updated.
A Ati 2600 pcie video card.
A e6600 cpu, not overclocked.
I'm using the dvi/hdmi dongle from the video card and hdmi to the 60hz lcd tv.

I have tried these steps to find the problem:
Different output colorspaces.
Specifying yv12 input colorspace.
Different avisynth configurations.
Not using the queue output samples.
Different rgb conversion tab settings.
Using the newest zoomplayer pro.
Trying the latest avisynth with no mt, and setting the avisynth script to use no mt.
I tried not using the ffdshow mpeg2 decoder and different ffdshow mpeg2 decoder.

I found the last ffdshow version that this configuration can be played on is the "2653" version by clsid.
At 2661 and anything higher the movie crashes at the warning screen.
I tried albains latest one too and that also crashed.

This player does not always cash, ot pnly crashed on one movie out of the three I tried.
Linked to in the link I gave, it did not crash on the progressive TEST DISK (ntsc), or the nsc sddvd Ghost in the Shell Anime.
It does crash on the movie "The Transporter 2" every time.
That anime does not have a root menu and it does not have a warning screen I think, just pop it and the the movie starts after the owners banner.

So I think this has something to do with the warning screen, since the movies that did not crash did not have a warning screen.

I will list the svn updates that may have caused the problem:
Revision 2661 - Directory Listing
Modified Sat Feb 7 14:44:18 2009 UTC (7 days, 22 hours ago) by clsid2

Updated FFmpeg

Revision 2660 - Directory Listing
Modified Sat Feb 7 08:55:27 2009 UTC (8 days, 4 hours ago) by h_yamagata

Use MSVC's STL instead of uClibc++.

Revision 2659 - Directory Listing
Modified Sat Feb 7 08:36:59 2009 UTC (8 days, 4 hours ago) by h_yamagata

ffdshow color space converters: separate some files

Revision 2658 - Directory Listing
Modified Sat Feb 7 07:37:36 2009 UTC (8 days, 5 hours ago) by h_yamagata

Optimize ffdshow color space converters: 6% faster (RGB32)

Revision 2657 - Directory Listing
Modified Fri Feb 6 17:27:33 2009 UTC (8 days, 20 hours ago) by clsid2

Updated FFmpeg

Revision 2656 - Directory Listing
Modified Fri Feb 6 14:24:22 2009 UTC (8 days, 23 hours ago) by h_yamagata

The new ffdshow color space converters:
Improve API and documentation

Revision 2655 - Directory Listing
Modified Fri Feb 6 10:52:25 2009 UTC (9 days, 2 hours ago) by h_yamagata

YCbCr specification: Auto:
width > 1024 or height >=600: BT.709
width <=1024 and height < 600: BT.601

Revision 2654 - Directory Listing
Modified Wed Feb 4 17:50:47 2009 UTC (10 days, 19 hours ago) by clsid2

Removed VS2003 project files


If you want to make this simple. Just make ffdshow version of each update I listed and I will try each one out and tell you when ffdshow begins to crash.

Edit.
I think update 2660 caused the problem.
Maybe make a 2659 version and I will tell you if that's the case. :)

Steveo08
15th February 2009, 15:18
mayby some one can help me, to fix my problem with ffdshow output. i want to use the colorspace "YV12", but i can't, because if i select "YV12" i always get an error message with mpc:

"MPC could not render some of the pins in the graph...etc."

i reinstall ffdshow for a few times, but it doesn't work.

clsid
15th February 2009, 15:53
Some renderers (like Haali) do not support YV12 input.

Steveo08
15th February 2009, 16:25
Some renderers (like Haali) do not support YV12 input.



thank you, because i am using haali video renderer, that would explain why it won't work! :-)

iron2000
15th February 2009, 18:59
I can't play DVDs.
Tried loading with MPCHC but as soon as it loads, an error dialog pops up and on clicking for more information, ffdshow.ax is shown:

AppName: mplayerc.exe AppVer: 1.2.986.0 ModName: ffdshow.ax
ModVer: 1.0.5.2471 Offset: 00201d3b

Does anybody have a clue to this problem?

tal.aloni
15th February 2009, 19:02
ffdshow's grab function takes screenshots with bad colors:
http://www.stfcc.org/misc/ffdshow.r2686.png
http://www.stfcc.org/misc/mpc-hc.r990.png

The filter chain was something like Haali Media Splitter -> ffdshow (decoding H.264) -> ffdshow (decoding YV12 - took screenshot) -> Renderer (in MPC-HC).

Snowknight26,
1. which revision?
2. do you have "High quality yv12 to rgb conversion" turned on?

I can't recreate this with rev. 2644, I'll test later revisions at the weekend (during encode at the moment)

Tal

Leak
15th February 2009, 19:53
I can't play DVDs.
Tried loading with MPCHC but as soon as it loads, an error dialog pops up and on clicking for more information, ffdshow.ax is shown:

AppName: mplayerc.exe AppVer: 1.2.986.0 ModName: ffdshow.ax
ModVer: 1.0.5.2471 Offset: 00201d3b

Does anybody have a clue to this problem?
Does it still crash if you don't use ffdshow's audio decoder, i.e. if you enable MPC-HC's internal audio decoders?

Because if it doesn't I've just fixed that crash in rev. 2691... :)

np: Distance - Radical (Chestplate)

Snowknight26
15th February 2009, 20:20
Snowknight26,
1. which revision?
2. do you have "High quality yv12 to rgb conversion" turned on?

It's in the file name. :P r2686.
Yes, High quality YV12 to RGB was checked.

I also have word that someone else is having this problem too (HQ YV12 -> RGB is on as well).

Jeremy Duncan
16th February 2009, 00:20
Does it still crash if you don't use ffdshow's audio decoder, i.e. if you enable MPC-HC's internal audio decoders?

Because if it doesn't I've just fixed that crash in rev. 2691... :)

np: Distance - Radical (Chestplate)

Was the update you made, 2691, made to the mpeg2 codec "libmpeg2"?

I ask because when the ffdshow developers update that codec again I know what to ask to be fixed. :)

Leak
16th February 2009, 00:35
Was the update you made, 2691, made to the mpeg2 codec "libmpeg2"?
No (http://ffdshow-tryout.svn.sourceforge.net/viewvc/ffdshow-tryout?view=rev&revision=2691) - it was an update to the audio decoder.

np: Distance - Present Day (Chestplate)

iron2000
16th February 2009, 03:18
Does it still crash if you don't use ffdshow's audio decoder, i.e. if you enable MPC-HC's internal audio decoders?

Because if it doesn't I've just fixed that crash in rev. 2691... :)

np: Distance - Radical (Chestplate)

!!
I works!
With MPC-HC's internal audio decoder the DVD plays.

:thanks:

Jeremy Duncan
16th February 2009, 04:26
The bug I wrote about in post 6637 was the audio bug Leak fixed.

When I disable ffdshow audio in mpc the problem goes away.
It is puzzling though, since the svn changelog does not mention ffdshow audio in the updates 2654 to 2661, and it was in one of those updates the audio bug I wrote about appeared. :)

Edit.

When can we expect a new build from clsid or Albain or xxl?

Leak
16th February 2009, 09:23
It is puzzling though, since the svn changelog does not mention ffdshow audio in the updates 2654 to 2661, and it was in one of those updates the audio bug I wrote about appeared. :)
It probably was 2660 - it was an assertion triggered by trying to reference the first byte of a buffer of size zero via an iterator, and while uClibc++ didn't check this MS's library does...

Simply skipping that part of the code if the size is zero does the trick without any ill effects.

clsid
16th February 2009, 19:04
I have added an updated MinGW32 installer to first post.

tal.aloni
16th February 2009, 21:25
It's in the file name. :P r2686.
Yes, High quality YV12 to RGB was checked.

Snowknight26,
I have tested ffdshow_rev2686_20090214_dbt.exe, and also tested rev. 2693 (xvidvideo.ru), both generic & icl10 and could not recreate this. (AFAIK, there are two color conversion functions, one for CPUs with mmx, the other for CPUs without)

1. are you sure the input is YV12? (some decoders output YUY2)

2. please make sure there's no more than one ffdshow instance in the graph. (DirectShow Control)

3. please try to provide more information on the build you're using, and when does it happen / not happen, or which is the first version that triggers it.

Tal