StaxRip

[XP1]

I'm getting a crash on ArgumentOutOfRangeException.

Log: https://pastebin.com/dhS07HZC

ArgumentOutOfRangeException

Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index

System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
at StaxRip.MainForm.ProcessJob() in D:\Projekte\VS\VB\StaxRip\Forms\MainForm.vb:line 2493
at StaxRip.GlobalClass.ProcessJobs() in D:\Projekte\VS\VB\StaxRip\General\GlobalClass.vb:line 37

[craigpro]

It's simple I believe, first you setup your empty project and then you add the source files in file batch mode, it then creates a job for every source file.


sorry just wanted to say a thank you for this - I've always used folders and batch encoded every file in there - adding files is actually much easier (but not obvious).

[stax76]

@XP1

Did that happen once or can you reproduce it? It's a problem with the exception handling of the threads for the new parallel processing. I've made a change but without knowing exactly what went wrong it might not yet be fixed.


@craigpro

You're welcome, glad it works.

[XP1]

@XP1

Did that happen once or can you reproduce it? It's a problem with the exception handling of the threads for the new parallel processing. I've made a change but without knowing exactly what went wrong it might not yet be fixed.Yes, reproducible.

I think the problem has something to do with an empty sub file. When StaxRip is trying to cut a sub for a duration that has no subs (or maybe the sub is corrupt?), it creates an empty "..._cut_.sub" file (0 bytes).

If I disable the sub, it works fine. When I enable the sub again, it causes the crash. Something to do with processing an empty sub file? Crash occurs before mkvmerge stage.

[stax76]

That's it exactly, good catch! I also found out why the exception handling didn't provide better information.

[stax76]

Requirements

.NET 4.7 is required on systems prior Windows 10 Version 1703 (Creators Update)

https://www.microsoft.com/en-us/download/details.aspx?id=55170

Download

https://drive.google.com/open?id=0B-gPKiJYuKuITld4dzhuTC1WWWM

https://onedrive.live.com/redir?resid=604D4754F64B0ABC!4140&authkey=!ANUm9V3vTPmEFNI&ithint=folder%2c7z

1.5.1.9 unstable test build


new: context help is now implemented for all video encoders, a right-click on any label, menu or checkbox will show the help for the option, for nvenc, qsvenc and vceenc a new help browser was developed with powershell look and feel
new: UT Video added for ffmpeg video encoder GUI with options for: -pred (None Left Gradient Median) -pix_fmt (YUV420P YUV422P YUV444P RGB24 RGBA)
new: help improved for Tags in mp4box container options dialog, the help is runtime generated using the output from mp4box -tag-list
new: ffmpeg muxing formats menu and profiles added for: asf avi flv ismv mkv mov mp4 mpg mxf nut ogg ts webm wmv
new: audio target format W64 added with 16/24 bit depth option
new: nvenc options --cuda-schedule, --perf-monitor, --perf-monitor-interval



fix: cmd.exe is now used directly without batch files, this improves foreign/special character support in particular on Windows 7
fix: Jobs Processing window popping up while job processing even when staxrip was previously minimized
fix: tray icons not cleaned up
fix: in a few dialogs the help dialog was shown four times instead once
fix: broken scaling on DPI change using a multi-monitor setup with different DPI values, virtual scaling is used in that case now
fix: crash when cutting empty subtitles



change: all classes made public for powershell usage



update: x264 0.150.2851
update: nvenc 3.14

[burfadel]

I have found the Job processing window disappears when moving on to the next project. I still have it in the memory, it's still processing, but the Staxrip icon isn't showing in the tray or task bar.

[lotnybartek]

Can someone enlighten me the difference between: LA-VBR vs LA-HRD-VBR in terms of picture quality? Form Intel's docs: "With HRD compliance, the Coded Picture Buffer should neither overflow nor underflow. This rate control is recommended in storage transcoding solutions and streaming scenarios, where low latency is not a major requirement." - so in other word, subjective image quality should be better, because encoder is distributing bits more effectively (no buffer overflow nor underflow)? I'm lost.

[stax76]

@burfadel

I had this also but often it appeared after a short time, it's a bit difficult to test because with small files it usually cannot be reproduced and testing large files takes much time, maybe the source filters are sluggish sometimes, one thing that is a issue is that l-smash don't report progress while indexing. I'll run some tests before I upload the next build.

[stax76]

@burfadel

There is a issue with l-smash, it loads slow even if there is already a index file, every time you open the preview it loads slow, it does not happen with ffms2, this causes staxrip to be hidden while l-smash loads, there was some discussion about l-smash a megui thread, I don't know if it relates.

[burfadel]

I am currently using FFMS2. I have seens avs2pipemod and x265 running in the task manager "Details' list, so the encode is running just Staxrip is completely hidden. Maybe if I left it long enough it might appear? I did leave it for quite a while. This is new behaviour in 1.5.1.9, I believe 1.5.0.9 it didn't do it.

[stax76]

It might appear, I'll do more tests, parallel process execution started in build 1.5.1.5.

[burfadel]

It might appear, I'll do more tests, parallel process execution started in build 1.5.1.5.

Sorry! I meant 1.5.1.8 :). I was looking at the previous build still in the test upload location (Google drive), not thinking of the actual previous build number.

The 1.5.1.8 is the one that fixed the issue I reported:
fix: unable to show processing window from tray
which worked well for me. I guess for some people that introduced a new error though, which was fixed in 1.5.1.9. My guess it's related to this:

fix: Jobs Processing window popping up while job processing even when staxrip was previously minimized
fix: tray icons not cleaned up

I did notice the second issue about the tray icons. The dialogue window not accessible in the task tray etc could either be related to the cleanup (cleanup of all icons including active one), or it could be related to the first fix? For me I've only noticed it as an issue when proceeding to the next job.

[stax76]

The tray icon cleanup happens when the app closes so it should be unrelated, the issue with the dialog popping up when it shouldn't was threading related I think, only thing I can do is run tests until I find something that can be reproduced.

[burfadel]

Ah ok! At least knowing it was working in 1.5.1.8 is hopefully beneficial. It seems to only occur at the changeover to a new encode, maybe it simply isn't creating the new tray icon now?

[stax76]

Without being able to reproduce it I can hardly do much, for any problem it's always crucial it can be reproduced, if things happen only arbitrary under special and unknown conditions it's usually gonna be a big drama until a solution is found.

What you can do when it happens again is write down the time to make a guess from the log file what it was doing. If there is a process running like x264 you can check the file properties of the h264/h265 file to see if the file is being written to.

[stax76]

@burfadel

Let's see if this built is more stable.

Requirements

.NET 4.7 is required on systems prior Windows 10 Version 1703 (Creators Update)

https://www.microsoft.com/en-us/download/details.aspx?id=55170

Download

https://drive.google.com/open?id=0B-gPKiJYuKuITld4dzhuTC1WWWM

https://onedrive.live.com/redir?resid=604D4754F64B0ABC!4140&authkey=!ANUm9V3vTPmEFNI&ithint=folder%2c7z

1.5.2.1 unstable test build


new: various new features and improvements in the apps management dialog
new: The jobs dialog will show it's help the first time jobs are started explaining staxrip's parallel processing features



change: tray icon stays visible even when the job processing window is visible
change: mpc replaced with mpv



fix: when automatic demuxing of the video stream is enabled or if demuxing of the video stream was enabled in the demuxing dialog the demuxed video stream wasn't opened afterwards but still the original video was opened

[burfadel]

Thanks, I'll download it now and use it once the current job is finished. I'll run it overnight and see how it turns out tomorrow morning :).

EDIT:
1.5.2.1 seems to be working fine! I retoggled the minimise to tray option since I unchecked it earlier and it seems to be working. I'll find out tomorrow (well, later today now) whether the issue is resolved.

Thanks Stax!

[burfadel]

It seems if you leave the job in the tray and it goes on to the next one, it's like the issue I had recently here: http://forum.doom9.org/showpost.php?p=1810844&postcount=2233

However, it looks a little different:
http://i.imgur.com/ovuVkK7.jpg

The window is completely blank instead of having the Staxrip icon. Unlike before though the current encode progress seems to be showing, the current encode is about half done when I looked at the output files (still progressing properly), hence the half green icon. The window does not show, and if you click on it again it just returns to the system tray.

[stax76]

Looks not good, when the job completes please send me the log via PM in case it's triggered by certain settings. Which process or processes where processing at that time?

[burfadel]

For the first job it's okay, it's when it goes on to subsequent jobs and Staxrip is in the system tray it doesn't restore, it comes up as shown in the screenshot. The window doesn't appear nor does the peek.

I'll send you a log of the previous job and the Staxrip settings.bin file.

EDIT: I saw x265 in the task manager finish, so I clicked on the task tray icon, the window popped up, and as it was changing over with muxing, going to the next job, encoding audio and video it popped up and displayed. If I return it to the task bar and restore it, it works, and will do until the next encode.

However, I stopped that encode, and started it again. This time, I immediately returned it to the system tray before the audio task etc had been done, and it won't restore. So, it will only restore if you already had it open when the last task was listed in the dialogue window, such as the x265 encoding.

It seems the dialogue window isn't created with the new task tabs (audio, video encoding etc) when minimised to the task tray. If you have it open, since it is already created it continues to work from the task tray unless the tabs change.

[stax76]

When it happens how many audio streams to encode has the project and how many processes run in parallel (Settings > General > Number of processes)? I don't have a Ryzen CPU but I can try to setup a similar mt avisynth script, maybe it has something to do with the mt script and thread priorities which might be different when the form is minimized or hidden.

[burfadel]

Just one audio stream, and one process at a time since the script is pretty heavy. If I were doing normal encoding I'd run two in parallel like I have previously (just running Staxrip twice instead of having it combined in the one interface).

Like I said though, it didn't happen in 1.5.1.8, so it's something that was changed between 1.5.1.8 and 1.5.2.1. I would go back to 1.5.1.8 to make sure, but I no longer have the staxrip.exe and .pdb files from that build. Is it possible to have a test build of 1.5.2.1 without the two changes:

fix: Jobs Processing window popping up while job processing even when staxrip was previously minimized
fix: tray icons not cleaned up

As the issue seems to relate directly to the first fix? I presume when it was popping up from being minimised it refreshed the window, which doesn't seem to be happening now. I don't recall actually having the problem it fixed, but maybe I just didn't notice it. If not that's okay! It's just the only change between the builds that I can think it would be related to.

[stax76]

I hope I will be able to reproduce it, git allows me to look at differences between commits so I can check what I've changed after 1.5.1.8, at many commits I rewrote the threading code heavily thought so it will be difficult to spot something specific, unfortunately I only commit when I upload a new build and don't write comments in the commits.

[burfadel]

All good! I thought it would be difficult, but asked just in case. For me some short test clips with basic script worked fine. This is with x265 super fast (just for the test), QAAC 2 channel, subtitles.

They're DVD source.

Now, I encoded a clip h264 video with a subtitle track, basically making a couple of encodes by changing the file name and clicking next, and I could not restore it from the system tray. If I remove the subtitles from the container options, it works! So I proceeded to add some filter back into the encode, and it doesn't work...

So I can see why it is difficult to find. Try a clip with embedded subtitles for use and see if that triggers it for you, keeping in mind it must be in the task tray (not task bar) when the changeover occurs to the next project, and it's the next project that is unable to be shown.

[stax76]

It might be arbitrary, at least I saw it once now, I'll try it with your subtitle setup.

[stax76]

I've tried all day to reproduce it without success, maybe I can see a pattern if somebody else has it also, I've still uploaded a build with minor thread synchronization changes.

What exactly happens when you click on the tray icon? You see the taskbar icon but absolutely no Window?

You said the taskbar icon shows correct progress, this progress is updated in the GUI thread of the job processing window which means it's not deadlocked.

[burfadel]

That's right, the window just won't restore. It seems only when minimised to the task tray and it changes tasks. I notice the old icon is closed at the end of a job and a new icon is created when in the task tray, it might be related. This is why there were numerous old icons that need clearing. Is it possible to have it all self contained with one icon creation, and everything process in that window? This would also resolve the issue with it not showing since it isn't a new icon and associated window.

I'll try the updated build when it's not 1 am :D! In the afternoon.

[stax76]

After every job the instance shuts down and starts a new instance, that was done because I couldn't figure out why memory grows 50 MB after every job without ever being released, tray icon creation and removal should now be once per instance.

If it happens again please examine it with winlister, it shows coordinates and has a restore feature, maybe it's just offscreen for whatever reason, do you use virtual desktops or multiple monitors?

http://www.nirsoft.net/utils/winlister.html

[burfadel]

Still no luck with the 1.5.2.2. Maybe I'll just minimise it to the taskbar from now on since it only happens when it's in the tray, and nobody else seems to have the issue!

[stax76]

Right now you don't have another choice, you could use a virtual desktop dedicated to encoding if a permanent taskbar icon bothers you. I still hope we'll find it soon.

[burfadel]

It's fine! It's not an issue at all, the tray icon is merely a nicety :). It's good that there's the option to have it go the the taskbar instead, which I'm guessing there are probably many people who don't know that there is a toggle setting for it. Thankyou for taking your time looking into it!

[stax76]

I'm rather sure I finally found it. :)

[_Mike_]

Hello, Stax!
I use 1.5.0.3 as stable and try to use last build. New GUI x264 is impressive .. but please help me find option - Aimed quality from old GUI in tab "Compressibility check" :confused:

[burfadel]

I'm rather sure I finally found it. :)

Thanks!

[stax76]

@Mike

It was never added to the new generation encoder dialogs, you can find it in the build below, just enter 'aim' in the search field.


@burfadel

You're welcome, I hope the new build is more stable.


Requirements

.NET 4.7 is required on systems prior Windows 10 Version 1703 (Creators Update)

https://www.microsoft.com/en-us/download/details.aspx?id=55170

Download

https://drive.google.com/open?id=0B-gPKiJYuKuITld4dzhuTC1WWWM

https://onedrive.live.com/redir?resid=604D4754F64B0ABC!4140&authkey=!ANUm9V3vTPmEFNI&ithint=folder%2c7z

1.5.2.3 unstable test build


new: aimed quality feature of the old x264 GUI added to the x264 and x265 GUI



fix: unable to recover processing form from tray
fix: unable to open new files (start new processes) after the process abortion feature was used



update: x265 2.4+99

[burfadel]

I tested it on the short clips that didn't work previously, and it seems to work now! :). I'll see what happes with normal use.

[stax76]

It was fine when a source file was opened and then encoded but not when a project was loaded and a process was never started before in the instance, I have a special mode for debugging so that running a job don't start a new instance and I can inspect the job processing with the debugger, that unfortunately made a difference, the problem was the form constructor was not created on the same thread that started the message pump which caused the notify icon click event not to be raised. When I noticed it I already worked on something else, I could then consistently reproduce it for a couple of minutes but lost it a after I while, I kept looking then until I found that it happens when I load a saved project.

[_Mike_]

new: aimed quality feature of the old x264 GUI added to the x264 and x265 GUI



Thanks a lot! This unique feature "Comp. check /aimed quality " is very useful!

[_Mike_]

Icon from task bar is lost when start or finish comp. check and staxrip i can see only in task manager
Minimize to tray - unticked
test build 1.5.2.3 Win 7

[burfadel]

Icon from task bar is lost when start or finish comp. check and staxrip i can see only in task manager
Minimize to tray - unticked
test build 1.5.2.3 Win 7

I was going to report basically the same thing! However, I thought I'd put it off in case it was just a carry over thing from the maximise issue.

What happens is when you restore the window after encoding only this will show:

http://i.imgur.com/FmMk05z.jpg

It might be hidden somewhere on your screen depending on where you last had it. You can move the cursor to the edge of the title bar, as posted, and expand it so whatever size you want and the information is displayed correctly. I thought it might have been a window size restore thing after the last issue about it not maximising and your too are experiencing it, or it could be a bug.

I notice in the registry key:
Computer\HKEY_CURRENT_USER\Software\StaxRip

It has ProcForm Pos Y and ProcForm Pos Y, but the size of the window is not stated.

[stax76]

I've seen windows os collapsing forms when the user minimizes the form and the form don't has a taskbar button, that would explain it, probably I call minimize somewhere while there is no taskbar button active.

[Natty]

1.5.2.4 unstable test build

new: qaac has a new option to pipe from ffmpeg instead of converting to FLAC/W64/WAV

great :goodpost::thanks:

[stax76]

@burfadel and _Mike_

I hope it's better with 1.5.2.5


@Natty

I hope it gives some performance boost.

[Schattenspieler]

Just updated from 1.5.0.1 to 1.5.2.3 and while my templates are still there, they're all useless now, messed up, and it feels weired, because even the templates for x265 are now using x264 presets and standard bit depth for x265 is 10? Did I do something wrong or do I have to "rebuild" my templates from scratch? (I just extracted the new 7z into my StaxRip folder.) That would be a downer, cuz I don't know that much about videocoding and spent quite some time looking up all the settings and adjusting them.

[stax76]

Just updated from 1.5.0.1 to 1.5.2.3

Why not 1.5.2.5?

[Schattenspieler]

I just downloaded it yesterday and did a test run today, only realising said problem after the first file went through and it was suspiciously bigger than expected. The jobs were created using 1.5.0.1 though. Will try 1.5.2.5. now …
Edit: Sadly, still the same thing. I also have to use the "Version" command (F12) twice, to get it to "ok". Does that sound fishy?

[stax76]

While I replaced the old x264 GUI with the new GUI I also improved all other video encoder GUIs. I found bad design in shared base components, the changes were too big to do without a reset, adding migration code is always possible but when I work on big features it's already a lot stress so I just reset it, that results all projects get the default which is x264. I could probably add a import feature to the video encoders to import from a command line, the code is mostly already there I think.

x265 has now 10 bit as default, I thought it makes sense.

When I update apps I use F12 myself all the time, I never have to use it twice so it could be a bug, does it happen for all apps? Do different staxrip versions use a shared settings dir (bad idea)? Is the startup dir write protected?

[burfadel]

@burfadel and _Mike_

I hope it's better with 1.5.2.5


Sorry Stax! 1.5.2.5 still doesn't restore the window. In 1.5.2.3 when I clicked on it the window appeared as in the screenshot,a and this could be easily expanded. It also appeared in the taskbar as it should. 1.5.2.5 does not restore at all, clicking on the tray icon doesn't (apparently) do anything.

Again, this is only on the change of encodes. If it were maximised like it is when starting a project and you put it to tray, it works until the next job.

[wallander]

Hello,
since some years I use this wonderful software for converting my TV- recordings to h264. Your powerful software offers many many possibilities to convert video and audio content.
Thank you very much for your tireless work.

Can you answer me one question.
How can I update staxrip without loosing my settings and templates?
At the moment I use 1.5.0.0.
Can I copy the new version over the old one?
My settings folder is within the app folder.

:thanks: