View Full Version : Announcing DVDSubEdit Version 1.51
Teebeeke
13th March 2006, 12:06
I have to say it again, but this proggy is a real timesaver for me. Now i don't have to make samples anymore to check if the subtitles are at an acceptable height.
Thx a million jeanl & CoNS
CoNS
13th March 2006, 12:34
It is indeed a truly awesome tool.
However, Teebeeke, as much as I would like to take credit for it, I have to stress that jeanl is the one to thank. He's the sole author of the program, and I haven't contributed with one line of code... (I've only done some testing of alpha and beta versions, analysis of subtitle examples and suggestions for improvements) :)
ladidi21
13th March 2006, 15:31
I use it and it's really an amazing product....
Some add :
- the name of the file before the LBA.
DVDsubEdit display the relative LBA from the beginning of the current file (ie VTS_XX_n.VOB) and not the first VOB (ie VTS_XX_1.VOB). As I think it's better to have the relative LBA and not the absolute LBA, it's better to add the filename
Some bonus :
- possible to change the stream ID for a sub
- possible to export the text info of the subs (stream ID, LBA, ...)
jeanl
14th March 2006, 02:13
Thanks for the feedback guys.
@ladidi21: you're right, the filename would be nice to have. I'll see if I can do that easily.
- What would be a case where you need to change the stream ID of a stream?
- How would you use the text info of the subs?
Jeanl
ladidi21
14th March 2006, 09:03
- What would be a case where you need to change the stream ID of a stream?
Some VTS_xx have subtitles including all : translation of the audio part AND translation of the text included in the video part. I'm talking about DVD having my foreign langage as auio. Moreover, no subtitle exist ONLY for the translation of the text in the video part (ie: "MOSCOW, 1936").
I only want the translation of the text of the video part... because I choose my langage as default langage.
So :
a. I create a new stream for a new subtitle with PGcEdit
b. I set this one as default subtitle
c. With VOBedit, I change the streamID ONLY for the subs which contain the "good" subtitles (translation of the text in the video part)
- How would you use the text info of the subs?
Most of the time, the subs I talk about before are in upper case. So it's easy to find them with a text editor !
Have all the LBA & text in a textfile make my life easier to change the streamID of the subtitle (=>LBA to find where is) with a cut&paste.
Regards.
jeanl
15th March 2006, 18:09
Version 1.2 of DVDSubEdit is now available here (http://www.videohelp.com/~DVDSubEdit/)...
Main new features are the ability to select and erase words or characters in the subtitles, and support for the 3 16:9 display modes (widescreen, pan&scan and letterboxed).
Here's the change log from Version 1.1
Added code to select an area in the OCR output and erase it (both in the OCR output, and the bitmap).
Added option to automatically remove text like "Man:" in subtitles
Added option to adjust word detection in the OCR setup panel.
Added Letterboxed and Pan&Scan video display modes for 16:9 material.
Added text in stream select to indicate which display mode(s) each stream is intended for.
Added option to only show forced subpics.
Added a check box to show the I-frame closest to the selected SPU end time (duration slider).
Added a smarter check for figuring out the video format when loading a .sup file.
Added a warning in the log file if closed-captions are detected in the MPEG stream.
The function to remove hearing-impaired text now runs in its own thread.
Pressing Alt or Ctrl while dragging a subpic allows horizontal-only or vertical-only moves.
Fixed OCR problems. The list is too long to show.
Fixed a crash that could happen in 1.1 if you moved a subpic all the way down.
Fixed a problem with the borders not adapting with PAL/NTSC video format
Fixed a scaling problem that cause the subpics to be slightly cropped in no-video, full-screen mode.
Fixed the safe-area values for the borders. Thanks to r0lZ for the help!
Fixed the "keyboard input problem" (after a threaded operation (OCR for example) the shortcuts didn't work).
Fixed once and for all the progress dialog not disappearing if a threaded operation finishes while the app is minimized.
Thanks to CoNS for many additional tests, and many many suggestions for improvements.
Feedback is most welcome!
Enjoy...
Jeanl
jeanl
15th March 2006, 20:25
- What would be a case where you need to change the stream ID of a stream?
Some VTS_xx have subtitles including all : translation of the audio part AND translation of the text included in the video part. I'm talking about DVD having my foreign langage as auio. Moreover, no subtitle exist ONLY for the translation of the text in the video part (ie: "MOSCOW, 1936").
I only want the translation of the text of the video part... because I choose my langage as default langage.
So :
a. I create a new stream for a new subtitle with PGcEdit
b. I set this one as default subtitle
c. With VOBedit, I change the streamID ONLY for the subs which contain the "good" subtitles (translation of the text in the video part)
I see! Very inventive! It would be somewhat complicated to add that to DVDSubEdit, and I'm not sure many users would benefit from it...
- How would you use the text info of the subs?
Most of the time, the subs I talk about before are in upper case. So it's easy to find them with a text editor !
Have all the LBA & text in a textfile make my life easier to change the streamID of the subtitle (=>LBA to find where is) with a cut&paste.
Regards.
I see. I could add that option to the OCR stuff.
Jeanl
jeanl
15th March 2006, 20:27
Man, if ever a thread deserved a bump this is it. I just tried DVDSubEdit v1.1 on one of my "acid test" DVDs and am delighted by the new features. Removing hearing-impaired subs, including even small snippets thereof, works fantastically well! I love too that you can step-thru the subs and when you get to a thumbnail where nothing is displayed, you can see the removed sub in the text window e.g. [ Faint Applause ].
Unfortunately, I had to remove that from version 1.2 :(. It was causing real problems with the new erase function to have the bitmap and the OCR missynchronized like that... I miss it though...
Jeanl
Mtz
16th March 2006, 03:34
:thanks:
If I select one of the latest 2 options for Vertical Borders in the window will appear Custom Vertical Borders. It is normal?
When erasing some selected text, the subtitle si centered. I saw in some DVDs, subtitles aligned to left. If I erase the first let's say "Oh, " from "Oh, I know it,". And the subtitle was aligned to left, the "I know it" is not moved to the left instead of "Oh".
Can this text recognition to be case sensitive? If I search for "Oh", it will display also "oh".
In hearing-impaired are also words like: whoa, ahem, uh, huh, ha-ha, Ah, aah, etc. Do you have any idea about searching and deleting them? Something like a "data-base". I can create a list on my PC with usual "whoa's" and searching from there for the unwanted texts which can be removed.
If I select one language in "Subpic Selection" and enter in "Go to subpic", for example 300, nothing happen. Because the 300 was in other language, not the selected by me.
I saw that the 4:3 Safe Area was moved up. For me it was better the previous one (Version 1.1). More than that, I used to lower with 2 pixels manually the Version 1.1 borders. Is not really a big problem bacause I will learn again with how many pixels to lower again.
Regarding this: can be added a desired value and stored in DVDSubEdit as preference setting? Something called like: "Personal Vertical Borders"?
After "Saving all Modifications" when closing, DVDSubEdit still tell me that I didn't saved my work.
enjoy,
Mtz
jeanl
16th March 2006, 05:40
Boy oh boy! Many problems still!
:thanks:
If I select one of the latest 2 options for Vertical Borders in the window will appear Custom Vertical Borders. It is normal?
No! I forgot i had added these two last options, they're not really here to stay, I'll just remove them.
When erasing some selected text, the subtitle si centered. I saw in some DVDs, subtitles aligned to left. If I erase the first let's say "Oh, " from "Oh, I know it,". And the subtitle was aligned to left, the "I know it" is not moved to the left instead of "Oh".
You have the option of not recentering. Look in the OCR options, and you'll see a check box for recentering the subtitles after erasing.
Can this text recognition to be case sensitive? If I search for "Oh", it will display also "oh".
I will make that a user-option in the next version.
If I select one language in "Subpic Selection" and enter in "Go to subpic", for example 300, nothing happen. Because the 300 was in other language, not the selected by me.
Yes, what should it do? Switch to the other stream? I could change that I guess, but does it make sense?
I saw that the 4:3 Safe Area was moved up. For me it was better the previous one (Version 1.1). More than that, I used to lower with 2 pixels manually the Version 1.1 borders. Is not really a big problem bacause I will learn again with how many pixels to lower again.
Regarding this: can be added a desired value and stored in DVDSubEdit as preference setting? Something called like: "Personal Vertical Borders"?
I think what I'll do is save them in the .ini file. Then you'll be able to go and edit the .ini file so you can have your own personal values for these borders.
After "Saving all Modifications" when closing, DVDSubEdit still tell me that I didn't saved my work.
Darn! I have to check that!
Thanks for all the bug reports!
Jeanl
CoNS
16th March 2006, 13:09
In hearing-impaired are also words like: whoa, ahem, uh, huh, ha-ha, Ah, aah, etc. Do you have any idea about searching and deleting them?Use the "Find string" function in the lower right corner to search for each of those words. Each time a subpic containing the search string is found you can decide if you want to remove the word by using the "Erase selected text" function.
If I select one language in "Subpic Selection" and enter in "Go to subpic", for example 300, nothing happen. Because the 300 was in other language, not the selected by me.Yes, what should it do? Switch to the other stream? I could change that I guess, but does it make sense?The "problem" also occurs when trying to go to a subpic number which doesn't exist at all (i.e. you try to go to subpic #2000, but in total the loaded VOBs only contain 1587 subpics).
In these cases you could display a small warning dialog saying that the desired subpic number is not in the selected subpic stream. The catch is that it could become an annoying warning for the user.
As an alternative you could go to the nearest available subpic number in the selected subpic stream. But this solution is not real good either, just like forcing the selecting of a subpic in a stream which is not selected.
After "Saving all Modifications" when closing, DVDSubEdit still tell me that I didn't saved my work.I didn't see this bug when testing v1.2 yesterday on a DVD. I loaded a full domain of VOBs, ran OCR and removed hearing impaired text and saved all modifications. When I exited the program I didn't get a warning about saving the changes?!
r0lZ
16th March 2006, 13:21
I think the Saving all Modifications message occurs only when you save your work while a specific stream is selected. Seems that the program saves only the modifications of the current stream.
If you want to get rid of the message, you have to select all streams (and probably also all V/CIDs) and save.
jeanl
16th March 2006, 17:29
I think the Saving all Modifications message occurs only when you save your work while a specific stream is selected. Seems that the program saves only the modifications of the current stream.
If you want to get rid of the message, you have to select all streams (and probably also all V/CIDs) and save.
r0lZ you're right! And I think it's not a good idea. I think all modifications in all streams should be saved when you chose save... What would be a situation when you only want to save some of your modifications?
Or, as an alternative, the warning should say "do you want to save all modifications and exit", but there would need to be 3 buttons, "save and exit", "don't save and exit", "cancel"...
Jeanl
frank
16th March 2006, 18:30
I think all modifications in all streams should be saved when you chose save...
Agree.
ladidi21
17th March 2006, 11:04
In fact, I only want to be able to change the StreamID for some subs I will preview...
So a simple editable box for the streamID of the sub I'm just viewing will be helpful !
Regards.
JFerguson
24th March 2006, 06:41
Hi jeanl,
I haven't checked out your proggie in a while... I see that you let us open read-only sources now.
You rock...nuf said! :)
jeanl
24th March 2006, 17:50
Well, I haven't published the source for the latest version! Laaaame! :)
jeanl
doggersen
28th March 2006, 14:09
As I can understand it should be possible to to open multiple vob files at once (or the entire movie), but no matter what I do, it seems as if it will only open the first of the selected vob-files.
I'm using v.1.2.
I have tried to drag vob-files to the program, select them from the opening menu, and also tried that domain-thing, but in all cases it seems I end up with one vob-file loaded into the program (when I perferm ocr for example, it only does it on that specific single loaded vob-file).
Have I misunderstood it all? :-)
jeanl
28th March 2006, 17:35
You can only drag/drop:
- Files that belong to the same VTS (i.e. don't try to open VTS_01_1.VOB and VTS_03_1.VOB)
- Files that belong to the same domain (i.e., don't try to open VTS_01_0.VOB and VTS_01_1.VOB because one is the menu domain and the other belongs to the title domain).
Normally, you get an error message if you try, so I'm not sure whether that's the problem you're running into.
jeanl
doggersen
29th March 2006, 17:29
Thanks for the answer. As i understand it, you can't open full movies at once then? It seems all the movies I have checked are named after your first example (VTS_01_1.VOB, VTS_02_1.VOB, VTS_03_1.VOB etc.).
In other words, is it normal to open and edit (seperately) like those averagely 4 vob-files that contain subtitles and the movie itself, in order to edit the entire movie?
jeanl
29th March 2006, 17:45
doggersen, it's very rare for a movie to span vts_01_1.vob, then vts_02_1.vob etc. That's more for episodic DVDs, with 1 episode per VTS. That's because you can't do a seamless playback transition from the first vob to the second.
Most movies are put in a single VTS, as in vts_01_1.vob, vts_01_2.vob, vts_01_3.vob etc ...
Are you sure you're actually in that last case?
jeanl
jeanl
29th March 2006, 18:22
Version 1.3 of DVDSubEdit is now available here (http://www.videohelp.com/~DVDSubEdit/)...
Main new features are the ability to modify the CLUT colors, a new zoom window to better see the subpics, and more customizations of default colors and behavior.
Here's the change log from Version 1.2
Added ability to modify the IFO clut directly from DVDSubEdit. Click a pixel tile, then shift-click in the CLUT display.
Added a "zoom" window that can show the useful part of the bitmap with a 1:1 scaling.
Added automatic selection of display mode when the user changes the stream selection. This can be disabled in the .ini file.
Added option to see OCR result on the original subpic (before any modification). That's useful for checking what the Hearing-Impaired removal tool does.
Added checkbox in OCR setup to allow case-sensitive searches on OCR output.
Added possibility to choose the default text and background colors when in "AutoCLUT" mode.
Added Preferences panel that includes general settings, OCR setup, and Hearing-impaired tool setup. The panel now includes options to change background color, alert if closed captions are found, and ask to load IFOs when loading .sup files.
Added OCR code to detect tied 'fl' 'ft' and 'fi'.
The "Save all modifications" menu now also works for .sup files (modifications are written back to the original .sup).
Save all modifications now saves modification in *all* subpics (not just the selected ones).
Border settings are saved in the .ini file (C:\Documents and Settings\YourName\Application Data\DVDSubEdit.ini). You can edit them to change the default values.
Fixed yet another stupid border problem with PAL movies.
Fixed a few problem with the automatic recognition of hearing-impaired text.
Fixed a (rare) problem where the true subtitle bottom line was not detected correctly.
Fixed a display mess-up when fast-reloading a PAL movie.
Fixed an OCR problem that occured when some subpics were moved up.
Fixed a bug that could cause operations on a subset of the SPUs to abort prematurely.
The built-in pdf user manual (F1) is more or less up to date.
Also, don't forget to checkout CoNS's cool guide (http://www.videohelp.com/~DVDSubEdit/Guides/HearingImpaired/guide.htm) for removing hearing-impaired subtitles!
As usual, thanks to CoNS for many additional tests, and many many suggestions for improvements.
Feedback is most welcome!
Enjoy...
Jeanl
dirio49
30th March 2006, 01:50
Nice.
Thanks Jean
blutach
30th March 2006, 02:34
Just a wonderful piece of work. Thanks jean! And thanks to CoNS for the guide.
Regards
doggersen
4th April 2006, 05:06
doggersen, it's very rare for a movie to span vts_01_1.vob, then vts_02_1.vob etc. That's more for episodic DVDs, with 1 episode per VTS. That's because you can't do a seamless playback transition from the first vob to the second.
Most movies are put in a single VTS, as in vts_01_1.vob, vts_01_2.vob, vts_01_3.vob etc ...
Are you sure you're actually in that last case?
jeanl
Sorry Jeanl, I got it all mixed up. You were right, i actually did mix up those numbers, and it perfectly opens multiple files (by just selecting one of the files in the series), so no problem!
doggersen
4th April 2006, 05:24
I tried the new version 1.3 with the guidance of Cons guide on how to do the "hearing-impared"-thing.
And how I missed a guide like that! Perfect guide that finally makes me realize how powerful and nice the program is! so big credit to Jeanl and Cons for that! :)
I noticed a thing though. I seem to be able to reproduce the same error over and over.
If I checkmark "re-center modified subtitles" it seems to crash/exit DVDSubEdit when I select the "hide hearing impaired text in all selected subpics".
And it seems to do it with no matter what DVD i try.
Admittedly none of the dvds to my knowledge really needed any re-centering (all the text was already placed nicely at the bottom in the middle of the screen throughout), but does that play any role?
Do i need some other thing activated before I can use the function? (I just followed the guide in slave-manner).
Would it by the way be possible to make the program remember more stuff till next time you start it? Im thinking of the minor detail, where you in the field "select subpics with these chars" write something like []()#.
Would be nice if I didn't had to write that each time (admittedly absolutely a small detail!).
Last question, would it be out of the way to EVER implement some inbuild wizards? :)
jeanl
4th April 2006, 05:34
doggersen,
The crash you describe is news to me, and not good! Can you do this?
- Save your subtitles as a .sup file (with DVDSubEdit).
- Check that the bug occurs with this .sup file as well.
- Send me the sup to jeanldvd at free dot fr.
Then I can see if that crashes the app for me as well!
Thanks a bunch!
As to remembering what's in the "select subpics with these chars", I think that's simply luxury!!! Not that it's hard to implement, but I'm not even sure it's a good idea? Any opinion, the others?
What kind of wizard did you have in mind? The next version will have a direct link to CoNS's guide so you don't have to go look for it....
Thanks for the kudos!
Jeanl
doggersen
5th April 2006, 22:04
Sorry about the late reply jeanl! My credibility is really at stake here! I tested it with 3 OTHER movies, and I wasn't able to reproduce the error! And the unfortunate thing is that I don't have those movies anymore I the first time around tested it on!
Even though one should think it was me fooling around, I just don't understand it, as i closely followed the guide in ALL cases!
But I will remember to save it as a .sub as soon (if ever!)as I see the problem again.
As it is now it simply works perfectly, perfectly centering all the lines.
Concerning those wizards, I was thinking of them in regards to the OCR/"Hearing impaired" parts of the program.
A lot of my friends who aren't too computer-oriented would never be able to use your program, even with Cons guide!
And I must admit without Cons guide I too was kinda lost.
It's not at all hard to use for me now, but unless you have edited DVD's before I would say it has a pretty steep learning-curve.
And i think that is a shame, since the removal of hearing impaired subs has such a broad appeal!
Also I know that I for sure would have to doublecheck the guide, if I took a break away from the program for a smaller period.
A wizard would eliminate any doubt whatsoever, and even a newbie would be able to use your powerful program instantly!
Some of the parts from Cons guide could even be used in the wizard.
It's not at all anything advanced I have in mind, basically something like this:
(with windows popping up for each step, if you choose the wizard that is!)
1. Point to the directory of the movie, you want to remove hearing impaired text from.
*DVDSubEdit is now processing the movie*
*DVDSubEdit won't be making any changes to your movie unless you confirm at the end of the wizard*
2. Mark which (language) subtitles you want DVDSubEdit to edit.
*doing some OCR-processing*
3. Mark the following boxes, dependent on how much text u want to have removed (boxes from the preferences-window).
4. DVDSubEdit found some characters it didnt recognize (as default it might be searching for []()# ), do you want to manually edit those, or ignore it?
5. you now have the option to preview the changes.
6. do you want to save the changes?
Sorry, it was writtin a bit fast, but I think you at least have a slight idea of what kind of simple-minded wizard I have in mind :)
And should you EVER consider just the slightest to ever implement such a monstrosity or similar, NEVER prioritize it over anything else in the program, - cos i do after all realize, that things such as the OCR-reader etc. are much more important to work on! :)
(even though i must say for me, its close to perfect so far! :))
jeanl
5th April 2006, 22:12
Thanks for the suggestions doggersen... I'm not sure where I'll put this suggestion on my todo list! There are things I want to fix/improve before I do that, but it's true that wizards are good for newbies...
Jeanl
jeanl
13th April 2006, 19:00
Version 1.32 of DVDSubEdit is now available here (http://www.videohelp.com/~DVDSubEdit/)...
This is mainly a bug-fix update, but a few annoying things have been fixed.
Added slider to the retiming dialogs, and the preview shows the I-frame closest to target location for the current subpicture. The slider range can be changed in the preferences.
You can now change the transparency of multipe pixels, and applly-to-all in just one shot (just like with color changes).
Fixed the annoying interactions between "Ignore CLUT" and "Auto CLUT" check boxes.
Cleaned up the way the "ShowVideo" check box behaves when loading VOBs and sups.
The true bottom line detection is more reliable than before (hopefully!). Still not perfect.
Added menu to open CoNS's hearing-impaired guide.
If you cancel after changing the CLUT color, the original CLUT is now restored.
Fixed a bug that was introduced in the previous version in the routine that detects brackets, which could cause good subtitles to be erased!
Added a check to detect NTSC subpics in PAL video (that scenario previously crashed the app).
Added a few error checks when loading subs, to avoid crashing when encountering malformed SPUs.
Also, don't forget to checkout CoNS's cool guide (http://www.videohelp.com/~DVDSubEdit/Guides/ChangingColors/Guide.htm) for changing subtitle colors!
As usual, thanks to CoNS for many additional tests, and many many suggestions for improvements.
Feedback is most welcome!
Enjoy...
Jeanl
dirio49
13th April 2006, 22:47
Thanks. Jean:D :D
blutach
14th April 2006, 10:24
Thanks again Jean for what is a fantastic piece of work.
Regards
doggersen
15th April 2006, 15:50
I would also like to say thank you for the latest version, that I of course had to try out immediately!
It seems though, that I unfortunately stumbled into an error I have mentioned before, where the program crash (but I came to the conclusion it was false alarm from my side back then:)).
The apparant error seems to occur every time I run the "hide hearing impaied text in selected subpics".
But ONLY when I in preferences have "re-center modified subtitles" selected.
It seems to vary from movie to movie (in v.1.32 i've only tested it with one movie though).
As earlier instructed by you Jeanl, I've taken the liberty of e-mailing you the .sub-file. (when I open that sub file alone, the same error occurs).
When the error occurs, it seems to be 10% into the movie/subtitle each time.
jeanl
15th April 2006, 17:12
Great, with the sub file, I'll be able to reproduce and figure out what the problem is! I'll look into it tonight...
Jeanl
jeanl
15th April 2006, 17:48
Thanks doggersen, I was able to reproduce and fix the bug... I might post a quick update on the web, changing the version number and simply adding this bug fix for now...
jeanl
doggersen
15th April 2006, 20:09
Wow! that was fast indeed! Good work :)
Would be very nice to see the fixed version put up!
Just out of curiousity, why did the bug occur? You don't have to bother if it's not for normal human beings to comprehend :D
Thx.
jeanl
16th April 2006, 01:13
I've uploaded version 1.321 here
http://www.videohelp.com/~DVDSubEdit/Downloads/DVDSubEdit1.321.zip
The version is identical to 1.32 except for the bug fix...
The bug was in the code that attempt to find text like:
- MAN: bla bla bla
and one of the subtitles had something like
-: (mis-recognized music note) that caused the crash...
Jeanl
doggersen
16th April 2006, 12:29
Thanks for the mini-update, it naturally works perfectly :)
President
18th April 2006, 08:08
I've uploaded version 1.321
Thanks, Jeanl! But...
Hmmmm. Last working version is 1.2. Versions 1.3, 1.32, 1.321 not even started. Program was encountered problem... bla-bla-bla. Closed. Ok.
Windows 2000 SP3 (Russian). Rights - Administrator.
CoNS
18th April 2006, 08:48
Hmmm, President, that's strange. I'm running the app on a Danish version of Win2000 SP4 without problems.
Anyone else having similar problems?
President
18th April 2006, 09:35
Hmmm, President, that's strange. I'm running the app on a Danish version of Win2000 SP4 without problems.
Anyone else having similar problems?
It amazed me too:-((. What global differences between versions? I try to clean windows registry, but not found any suspicious key. I'm shocked:-(. System events log is also empty. What does it matter? May be new app use microsoft .NET or somewhat else?
jeanl
18th April 2006, 16:13
No no, no .net or anything, but you're not the only one with this problem, unfortunately, and I'm having a hard time figuring out what the heck is going on. Try this however: Remove the DVDSubEdit.ini file (it's in C:\Documents and Settings\YOURNAME\Application Data) and see if the app starts. If it does start, then close it and try to start it again. If it crashes at this point, I think I know what the problem is.
If that's the case edit the .ini file and remove the line
MainWindowPos= x y z o
and try to restart the app. If that does the trick, I'm going to have to look into a way to avoid that pain in the neck annoyance...
jeanl
mpucoder
18th April 2006, 16:35
I had that problem with MuxMan, too - invalid or off-screen coordinates. I added a sanity check (within the bounds of the display).
// create the window
DlgSz.cx = 568;
DlgSz.cy = 326 + 15;
ConvertDialogUnitsToPixels(hDlgFont, &DlgSz);
DlgSz.cx += 2*GetSystemMetrics(SM_CXFRAME) + 2*GetSystemMetrics(SM_CXFIXEDFRAME) ;
DlgSz.cy += 2*GetSystemMetrics(SM_CYFRAME) + 2*GetSystemMetrics(SM_CYFIXEDFRAME)
+ GetSystemMetrics(SM_CYMENU) + GetSystemMetrics(SM_CYSMCAPTION);
x = GetPrivateProfileInt("General","Left", CW_USEDEFAULT, "Muxman.ini");
y = GetPrivateProfileInt("General","Top", CW_USEDEFAULT, "Muxman.ini");
if (y < 0) y = 0;
if ((y+50) > GetSystemMetrics ( SM_CYFULLSCREEN ) ) y = GetSystemMetrics ( SM_CYFULLSCREEN ) - 50;
if ((x+(short)DlgSz.cx-100) < 0) x = (short)(100-DlgSz.cx);
if ((x+100) > GetSystemMetrics ( SM_CXFULLSCREEN ) ) x = GetSystemMetrics ( SM_CXFULLSCREEN ) - 100;
hWnd = CreateWindow( gszMuxmanClass, gszAppName,
WS_OVERLAPPED | WS_CAPTION | WS_SYSMENU | WS_THICKFRAME | WS_MINIMIZEBOX /*| WS_MAXIMIZEBOX*/ ,
x, y, DlgSz.cx, DlgSz.cy, NULL, NULL, hInstance, NULL ) ;
jeanl
18th April 2006, 16:58
Thanks mpucoder. In this case, I'm not sure the problem is invalid or off-screen coordinates. I've seen it happen with perfectly legit values for x y, cx and xy. The crash happens in a call to SetWindowPos (IIRC), and that makes not sense whatsoever...
:(
Jeanl
Mtz
19th April 2006, 07:30
jeanl, can you use the location of the ini file in the same folder as the user have DVDSubedit.exe?
enjoy,
Mtz
jeanl
19th April 2006, 07:32
Mtz, that wouldn't be a bad idea... I'm not sure why I selected that location, probably because most apps use it... But that makes it difficult to find the ini... I will add a shortcut to open the ini file automatically in notepad...
jeanl
President
19th April 2006, 11:15
Try this however: Remove the DVDSubEdit.ini file (it's in C:\Documents and Settings\YOURNAME\Application Data)...
That's right. I deleted both files in this folder. That will do. Thank's.
*************************
Hmmm, sorry, it's me again. Apps start normally one time and crash again at the second start. I deleted "MainWindowPos" line from ini. A situation is repeat. First start nomally, second - crash.
My display resolution is 1280x1024 if it can help you.
President
19th April 2006, 11:50
Mtz, that wouldn't be a bad idea...I will add a shortcut to open the ini file automatically in notepad...
One more idea. You place a first line in ini:
DVDSubEdit version 1.321
Apps check this line from each start and delete old or incorrectly modified file (then create a new ini) if any mismatch detected.
In this case users has not necessary know what is the ini-file in general:-).
jeanl
19th April 2006, 17:02
President, I know the problem. The first time is OK because the value isn't there, but then the second time you open DVDSubEdit, you get the crash. OK. I'm going to post a quick fix which will lookup a value in the .ini file to tell it whether to read the position or not. This will solve your problem, until I can get to the bottom of that stupid crash. Sorry about that...
Jeanl
jeanl
19th April 2006, 17:14
President, go to the home page, and update to version 1.322.
Edit your ini file and at the bottom add the line:
NoSize=1
The app should now start just fine, but it won't remember the last size/position you used. This should fix your problem for now...
Jeanl
vBulletin® v3.8.11, Copyright ©2000-2026, vBulletin Solutions Inc.