Announcing DVDSubEdit Version 1.51

[blutach]

Jean,

Great addition! However, if you press stop, move the slider, and press start again, while the audio is fine, the subs are not appearing.

Note, you can move the slider while playing with no ill effect.

Is it just me or is there a bug?

Regards

[jeanl]

Jean,

Great addition! However, if you press stop, move the slider, and press start again, while the audio is fine, the subs are not appearing.

Note, you can move the slider while playing with no ill effect.

Is it just me or is there a bug?

Regards
OK, here's a few things you need to realize:
- When you start Play, the stream that correspond to the current subpic is selected automatically (because you don't want to play the video and see all the subpics of all the languages!). So, if later on there's no subpics in that stream you might not see anything
- If you start in an area where there's a long gap without subpics, the video will play and no subpics will be shown, of course....

Perhaps that's what you're seeing...
Jeanl

[blutach]

No, there's lots of dialogue and only 1 audio and 1 subpic stream. I am moving quite long distances, too.

Regards

[ericf]

The subs disappeared again. There's no info in the log to indicate a problem.
I just quick opened the subs and used the slider to move the subs down a bit. Applied to all and saved (Very quick save window, almost like nothing happened).
I open the DVD and no subs!

There must be a bug.
This is the only thing I find in the log:

19:09:18 -- 0% done
19:09:18 -- 0% done
19:09:18 -- 2% done
19:09:18 -- 4% done
19:09:19 -- 5% done
19:09:19 -- 7% done
19:09:19 -- 9% done
19:09:19 -- 10% done
19:09:19 -- 12% done
19:09:20 -- 13% done
19:09:20 -- 15% done
19:09:20 -- 17% done
19:09:20 -- 19% done
19:09:20 -- 20% done
19:09:21 -- 22% done
19:09:21 -- 24% done
19:09:21 -- 26% done
19:09:21 -- 27% done
19:09:21 -- 28% done
19:09:22 -- 30% done
19:09:22 -- 31% done
19:09:22 -- 33% done
19:09:22 -- 34% done
19:09:22 -- 35% done
19:09:23 -- 37% done
19:09:23 -- 38% done
19:09:23 -- 39% done
19:09:23 -- 40% done
19:09:24 -- 40% done
19:09:24 -- 41% done
19:09:24 -- 42% done
19:09:24 -- 44% done
19:09:24 -- 46% done
19:09:25 -- 48% done
19:09:25 -- 50% done
19:09:25 -- 52% done
19:09:25 -- 55% done
19:09:25 -- 57% done
19:09:26 -- 59% done
19:09:26 -- 61% done
19:09:26 -- 64% done
19:09:26 -- 66% done
19:09:26 -- 69% done
19:09:27 -- 72% done
19:09:27 -- 74% done
19:09:27 -- 77% done
19:09:27 -- 79% done
19:09:27 -- 83% done
19:09:28 -- 85% done
19:09:28 -- 88% done
19:09:28 -- 90% done
19:09:28 -- 93% done
19:09:28 -- 96% done
19:09:29 -- 99% done
19:09:38 -- 9% done
19:09:38 -- 19% done
19:09:38 -- 29% done
19:09:39 -- 39% done
19:09:39 -- 49% done
19:09:39 -- 59% done
19:09:39 -- 69% done
19:09:39 -- 79% done
19:09:40 -- 89% done
19:09:40 -- 99% done


???????????
ericf

[jeanl]

What does it mean that they disappeared? Are they still visible in DVDSubEdit? Where did they disappear from?
Jeanl

[ericf]

I think you can see subs in DVDSbEdit no matter what you do to them.

I can't see the subtitles in any player on my computer.
That's what happens now and then when I use the slider to re-position the subtitles vertically.

I don't know why, but it's the second time it has happened for me.

I do the work one time with the subtitle colors.
I exit.
Decide I need to lower the subs. Open them in DVDSubEdit again and move them vertically.
Save (doesn't really seem to save) and exit.
Oops, the subs have disappeared.

ericf

[jeanl]

OK I see (of course, this has never happened to me :( ).
Could you send me a snippet? You could cut 5-10MB of the VOB in question, making sure that there are some subs there, then zip that up with the IFOs, and send me that via http://www.mediafire.com/ (a great hosting site btw)...
I'll take a look. I should be able to see why they're not showing.
Jeanl
P.S. use jsoto's cutfile little app to cut the vob. It's on his vobblanker website, in the tools section.

[[Tobi]]

Carefully and friendly questioningly...

Is the used preview in DVDSubEdit identically with the PgcEditPreview? My problem is, the audio stutters after a short time and then it is no more synchronous with the subtitle.
I have this behavior not with the preview in PgcEdit.

Is it maybe possible to change the directory for the DVDSubEdit log?
I would like to be able to see the logs without changing every time the folder options in the control panel.

[jeanl]

Hi Tobi,
It's the same code in both programs, BUT .... the pgcedit preview can use the overlay buffer (which is much faster) while the DVDSubEdit app cannot (because of the need to superimpose the subtitles), which means the preview in DVDSubEdit takes more CPU. If it takes too much, then the audio stutters.
One thing you can do to avoid that is to make the DVDSubEdit window smaller (as small as possible in fact), this helps on my own computer.

You can't change the log folder, but there's a button to open the log in the Help menu...
Jeanl
P.S. If you still get the stutter problem after making the window small, send me an email, and I'll see if I can send you a version that downsamples the video even more (if you don't mind doing a few tests for me).

[[Tobi]]

My cpu uses 47% for the preview in DVDSubEdit and in PgcEdit I really use the overlay. I cannot deactivate the overlay in the control panel of the graphics card. In the current driver of the graphics card, the option exists no more. The window has the smallest size, but the audio still stutters.

I know the button in the help menu, it would be only nicer if the logs were not saved in a hidden folder. However, I accept it...

OK, mail is on the way....

[jeanl]

mmm, if the cpu really is 47%, then the processor isn't running out of cycles. Unless you have a dual-core... Is that the case? (in such cases, the CPU rating shows the overall percentage, usually, which means 47% is 1 core running at near max capacity).
Jeanl

[blutach]

My 3800x2 runs up to 50%, but shares the load. This is on the largest preview screen.

Regards

[jeanl]

It shares the load between the two processors? Amazing...

Jeanl

[blutach]

Looks that way on the graphs in Process Explorer. :)

Regards

[ericf]

It seems like I can't replicate the problem with the disappearing subtitles now.
I'll get back to you on that when it happens again.

ericf

[jeanl]

Please, so. Save the subs as a sup file... Or a tiny sample of the VOB (probably better).
Jeanl

[robsoslz]

Hi Jeanl

Did you manage to do the new program DVDSubEdit?
New version DVDSubEdit?
Exemple:
Optical Character Recognition (OCR)
I'm getting married. --> Erase
What? --> Insert text
(BUTTON)
* Size text
* Fonts
* Erase Text
* New text

Hug

Thanks,

Robson (Brasil)

[jeanl]

No, The "insert text" idea isn't going to work, for reasons I explained to you... That's really not feasible... Same for the fonts, or resize...
Jeanl

[SquallMX]

Hello Jeanl, i too still have the missing subtitles problem, this happen if i change the subtitle(s) position(s) in the frame, after a little research:

PowerDVD 6: Play subtitles just fine
PowerDVD 8: Play subtitles just fine
Intervideo 6: Play subtitles just fine
PlayStation 2: Play subtitles just fine
Standalone DVD: Play subtitles just fine
MPC - Homecinema (Internal MPEG Decoder): Some subtitles appear, some don't.
Nero Showtime: Some subtitles appear Ok, some appear with interlaced like look.

Sample (Original):
http://spanish.doom9.org/Soft4/Original.rar

Sample (Modified with DVDSubEdit 1.4102):
http://spanish.doom9.org/Soft4/Mod.rar

Nero ShowTime Screen Capture:
http://spanish.doom9.org/Soft4/ShowTime.jpg

Greetings :thanks:.

[jeanl]

Thanks for the detailed bug report and the sample, that's really useful. I'm taking a look.
Is MPC mediaplayerclassic?
Jeanl

[kumi]

I'm pretty sure he means http://sourceforge.net/projects/mpc-hc/

[jeanl]

Well mediaplayer classic shows none of the modified subpics!!!!!
But your example is great, it allows me to figure out exactly what is wrong, and I think I have it...
I'll keep you posted.
Jeanl

[SquallMX]

Kumi is right, I was talking about MPC Homecinema, it's a great mod of the original Media Player Classic. But the bug is also present in the original (Media Player Classic 6.4.9.0).

Jeanl, in this particular movie (Hitman Uncut) most of the subtitles are lost in MPC, but in others (Sony Pictures DVD mostly) some subtitles appear, some don't, and in others (Warner) all the subtitles appear correctly.

Probably because diferent studios use diferent authoring programs/tools?

Incidentally i found a workaround that can fix the problem:

1.- Open DVDSubEdit.
2.- Select the the affected VOBs.
3.- Click on "Crop Subpic Background".
4.- "Edit" --> "Apply last modifications to all" --> "DO IT!".
5.- "File" --> "Save All Modifications"
6.- Close DVDSubEdit.
7.- Problem solved!!!

Sample (Workaround):
http://spanish.doom9.org/Soft4/Fixed.rar

Thanks for your help :thanks:.

[jeanl]

SquallMX,
Thanks to your excellent debugging and your perfect sample DVD, I was able to reproduce, and find the source for the problem.
This is a problem that's been plaguing DVDSubEdit since the beginning (well, not quite). When moving subpictures by an odd number of pixels, some players have problem displaying the subpicture. This is the problem you encountered.
Up to now, I hadn't been able to figure out what the real cause for the problem was, but your small example provided the key!

As it turns out, mediaplayerclassic (and other players) don't like it when the offset to the Top Field is larger than the offset to the Bottom Field. Subpictures are organized in two fields, the top and the bottom fields, the top field corresponding to even lines, the bottom field to odd lines. The subpicture data contains two offsets into the binary representation of the bitmap, one offset for the top field, and one offset for the bottom field. The idea behind that was to allow for half-resolution bitmaps (saving only the even lines, and setting the two offsets to the same value, so odd lines would be the exact copies of the even lines, thereby saving half the space).

Up to now, when DVDSubEdit was moving a subpicture by an odd number of lines, for example, by 1 line, it was pointing the top field to the first line of the bottom field, and the bottom field to the second line of the top field, which caused the Top Field Offset to be larger than the Bottom Field Offset (since the top field is usually placed before the bottom field).
Most players don't have a problem with that, but mpc does. :(

This was a known problem, and the .ini file for DVDSubEdit has a hidden variable ForceEvenMoves that's normally set to 0 but could be set to 1 to avoid the problem. If set to 1, only vertical moves by an even number of lines are allowed, which was known to work in all cases.

I have modified the code to detect when the top field offset is larger than the bottom field offset, and swap the two fields in that case before saving. On your sample DVD, this fixes the problem and allows moving subpictures by odd numbers of line.

I will post an update to DVDSubEdit, so you can try it on your full DVD, hopefully this will work just fine.

Jeanl

[r0lZ]

Finally that bug has been trapped! I had the same problem with my Sony, and probably also with a recent cheap Magnum combo. I'm glad it has been fixed! Thanks, Jean and SquallMX!

[SquallMX]

:thanks: Jeanl.

[jeanl]

Thanks guys, but it's mostly SquallMX's very nicely made before/after DVD that pointed me in the right direction.
It's not 100% fixed yet, but it's almost there.
Jeanl

[jeanl]

OK, here's a version (beta 1.4203 EDIT: sorry, that's 1.4103) that fixes this problem.
EDIT: I'm removing this version because of a bad bug. Here's 1.4106 instead.
http://download.videohelp.com/DVDSubEdit/Downloads/DVDSubEdit1.4106.zip
SquallMX, could you possibly test this version on your DVD? I think it will work, it does work on the sample you sent me. Remember to move the subpics by odd numbers, otherwise the old version would work just fine.
Jeanl

[myso]

Thank you jeanl for this useful program. :) I use it very often.
And thanks for the update, as i was suffering from deinterlacedish subtitles.

We can extract existing subtitle stream from a dvd as a *.sup file, is it possible to add a dvd substream from a *.sup file? If yes it would be great. Many people need to subtitles to dvds to watch movies. It's not a difficult job but people are afraid of doing it. If this feature could be implemented, many people can do it easily.

To add a completely new subtitle stream you need to modify .ifo attributes, but many dvds are coming with multiple subtitles and replacing one of them can be easier. We can retime subtitles if we open the dvd fully. And we also can replace subpictures. The only thing left is to add new subpictures to an existing subtitle stream if needed :)
I hope you can do it. :o

anyway thank you again. :thanks:

[blutach]

To add a subpic stream, use muxman.

Regards

[jeanl]

As blu said, it's best to use muxman. The problem is that if you add a stream, you have to add packets here and there to the vob file, making it larger, which means you have to worry about how you multiplex and time everything. It's not very easy, and muxman does a wonderful job, so that's clearly the way to go.
I think subtitle creator has a kind of wizard to do that, which involves calls to muxman (I'm not 100% sure though).
Jeanl

[kumi]

I have modified the code to detect when the top field offset is larger than the bottom field offset, and swap the two fields in that case before saving. On your sample DVD, this fixes the problem and allows moving subpictures by odd numbers of line.
Just curious,

Can the new version of DSE fix a disc that was previously "broken" with an old version of DVDSubEdit?

[jeanl]

yes, but you have to make a change to the subpic for it to be saved (DVDSubEdit only saves the subpics that have been modified).
So for example, you can move all subpics by 2 pixels up, then do that again 2 pixels down, then save.
All the subpics that have the fields in the "wrong" order will have them reversed upon saving.
Jeanl

[SquallMX]

Works Perfectly!!!

No problems or bugs so far.

Again :thanks:.

[jeanl]

Great! Thanks for letting me know, and thanks again for the test DVD, that was invaluable!
Jeanl

[kumi]

Thanks a lot for the clarification jeanl.

By the way, you said the new beta is version 1.4203, but the executable says 1.4103. Mistake?

[jeanl]

Yes, sorry, it's 1.4103, I"ll correct that in the post.
Jeanl

[jeanl]

Hi guys!
Over the week end, I found and solved a bad bug in the latest beta of DVDSubEdit posted above.
Here's a link to the version you should use instead.
http://download.videohelp.com/DVDSubEdit/Downloads/DVDSubEdit1.4106.zip

The bug only occurred if you used the "Add Fade-in" function, after having moved the subtitles by an odd number of pixels. The resulting subpics became completely worthless because the offset to commands was erased.

Please use the version above instead!
Thanks,
Jean
P.S. The format of the MRU files has changed, so when you use this new version, none of your previously opened files will appear in the File menu, sorry about that.

[dirio49]

Are allowed to modify the text, because it seems we are not allowed.
erase selected text does not work if you select the whole subscript and click the button
later

[jeanl]

mmm, I just tried it and everything works normally. Is that on a DVD or a sup file?
Jeanl

[alfixdvd]

With new version 1.41016 when I open a sup file, the DvdSubedit's window is filled with garbagge. If I minimized it and restore all's ok.

[jeanl]

OK, I'll look into that.
Jeanl

[jeanl]

I tried it and it works for me. Can you send me the sup file in question, and I'll see if I can reproduce the problem?
Send it to jeanldvd at free dot fr.
Thanks.
Jeanl

[dirio49]

mmm, I just tried it and everything works normally. Is that on a DVD or a sup file?
Jeanl

DVD, that i have blanked a lot of other stuff in it

ok, multi line erase does work with erase button
as for the edit, in can erase text but not add text or modify it

Example
-ls he here yet?
-No.

[jeanl]

DVDSubEdit has never been able to edit or add text! :D :D
It would be a nice feature but it's extremely hard to implement...
So this isn't a bug. It's a limitation.
Jeanl

[dirio49]

oops, sorry.:D
what about the multi line selecting and click erase button

[jeanl]

OK describe the bug again, because I'm not understanding what the problem is...
Thanks,
Jeanl

[dirio49]

if you select all the text in a multi line subtitle and try to delete it with the erase buttons nothing happens

[jeanl]

OK, I'll check that! :)
Jeanl

[jeanl]

This is a limitation of the erase function that has been here all along.
You can only select characters that are on the same line, the code does not allow you to erase a selection that spans two lines. I'll if I can fix that.
Jeanl
EDIT: I fixed the problem. I'll post an update tonight.