Announcing DVDSubEdit Version 1.51 [Archive] - Page 6

jeanl

13th February 2006, 00:46

mpucoder if you have any info about that, I'm in the business!!! :D
I did check that all the resources were being freed etc... But I could have missed something. There's no memory leak message in the debugger when I exit the program, but a "GDI" leak might go unreported...
The bug is pseudo-random, it can happen after a very small number of clicks/slides, or after quite a while... The error code that I get from the function that fails is completely un-informative ("wrong argument" !!!)... And it's in a function which can't be substituted unfortunately...
jeanl

jeanl

13th February 2006, 01:14

OK guys, IT'S FIXED!!!! I found the bug, and as mpucoder pointed out, it was a brush that was created and not released... I added the code to release it, and it looks (so far) like the bug IS GONE!
Happy camper!
Jeanl

doggersen

15th February 2006, 01:22

I'm not even sure if this is the correct thread to post this question in. And even worse, im not 100% sure it hasn't already been asked/discussed!
(I waited 10 (yes, not five) days to ask this question, so I hope it was worth the wait ;-)).

I'm very interested in the OCR-part of DVDSubEdit, since it now seems I can FINALLY get rid of those subs for the bad of hearing.
It (as others has pointed out too) seems to be very effective at locating the subs im interested in (the ones with [ ] ).

Now my question is:
A lot of the subs in movies consists of both "hearing impared" text as well as normal text.

Example: "[Eric screams] Get out of the car!"

In those cases it seems as if DVDSubEdit only has the option of removing the entire sentence. Is it instead possible to have it ONLY remove the part within the brackets[] ?

A second question, while I'm at it:
Will it be possible in the next beta-version of the program to make it auto-center/adjust the subs in BOTH directions, and not only ONE as it is now?

Thanks a lot in advance.

:cool:

jeanl

15th February 2006, 01:27

doggersen,
The answer is "yes soon" to both questions.
- For now, it's true you can only blank the complete subtitle, so you'll have to live with the brackets if there's something useful. But I know that if I allow you guys to remove part of the subtitle, you'll want to recenter it automatically etc etc etc!
- Horizontal adjustment is being foolproofed. It often requires decoding/recoding the subpics because most of the time, the background takes the entire screen.
Once the decoding/encoding mechanism is solid, it will be easier to remove parts of the subtitles.

I'm open to any input as to how you'd like to do that...
- Erasor?
- Automatic?
etc etc etc.
Jeanl

doggersen

15th February 2006, 02:07

Wow! thanks for the quick response and the good news!
(and i should of course have thought about the NEW problems my question generates (the question of how to then center the subs, after parts of them have been removed)).

I have ONE followup-question though!

you say:
"It often requires decoding/recoding the subpics because most of the time, the background takes the entire screen."

What do you mean with "background" in this regard?
(yes it's a technical thing i don't know much about, but i was just curiuos, since i saw it mentioned some other places too in your program/on this forum).

:thanks:

jeanl

15th February 2006, 02:56

Read up on this thread as this subject has been brought up before. Essentially, the background of the subpic is the rectangle that encloses all pixels. Some subpics are authored with the smallest possible rectangle that encloses all "useful" pixels (used for the characters). But very often, the subpic includes pixels for the entire screen. That's not terribly wasteful because there's a very efficient way to encode an entire line of similar pixels.
However, this prevents moving the subpics left or right by changing their "start x" data, and to move them, you have to decode them, crop the large rectangle to the smallest possible one around the subtitle, then re-encode. Then you can move them.
The latest unofficial version of DVDSubEdit in the Downloads directory includes that possibility (with the Ctrl-E shortcut). If you want to try you can download it from here:
http://www.videohelp.com/~DVDSubEdit/Downloads

load your vob, pick a subpic you want to move, and see if the horizontal moving slider is enabled. If not, press Ctrl-E, which crops the background. Then the slider will be enabled.

The next beta will include that automatically...
jeanl

Sir Didymus

15th February 2006, 10:06

...Once the decoding/encoding mechanism is solid, it will be easier to remove parts of the subtitles.

I'm open to any input as to how you'd like to do that...
- Erasor?
- Automatic?
etc etc etc.
Jeanl

Hi jeanl.

Just want to say A BIG THANK YOU for your excellent work with DVDSubEdit.

I really think you are filling a relevant gap in the DVD backup and personalisation arena.

So, my question is: since you are thinking ( working ? :) ) into the integration of a subpictures decoding --> encoding mechanism, would it be possible to allow - I mean, manually, or off line - the user to modify the decoded subpicture before its re-encoding ?

This would be nice, and would allow to manually recover OCR issues or to "manually repair" typing mistakes in the subtitles [yes sometimes the tranlations suffer from some humoristic mistakes] or to change their graphical layout (spacing, font, boldface, etc...)

jeanl

15th February 2006, 17:39

Yes, I guess I could make that possible, but the editing would have to be done in an external app, and it would only be possible if the new bitmap could fit in the space occupied by the old bitmap, once encoded...
jeanl

frank

15th February 2006, 18:41

jeanl:
OK guys, IT'S FIXED!!!!
http://img320.imageshack.us/img320/7171/verbeugung6jt.gif (http://imageshack.us)

jeanl

16th February 2006, 18:57

People,
There's a new unofficial beta for DVDSubEdit, for those of you who would like to test before I make an official release. It's beta 0.909 and can be found
here (http://www.videohelp.com/~DVDSubEdit/Downloads)...

There's a good number of new features, improvements and bug fixes. Thanks CoNS for all the testing! Please, give it a try and let me know of any problem.

Here's the change log from beta 0.90

Added code to crop subpic to the bare minimum width, allowing horizontal moving. This can be applied to all in the usual manner.
Added option to move subpics flush with the nearest border.
The main window is now resizable. I cleaned up a lot of the display code, in an attempt to make things faster and cleaner.
The main window can also be minimized, or maximized, imagine that!
DVDSubEdit no longer needs the CLUT to identify the pixels used for the characters. Let me know if that fails.
Added a check box to show the main text pixels in white, and all others in black.
Fixed a bug that caused the app to crash if you fast reloaded a vob that was no longer there.
Fixed the infamous "display freezes, app starts writing all over" bug! A brush wasn't being released....
DVDSubEdit no longer crashes if you quite while running the OCR function.
The "save subpic to ppm" option was shrinking the subpicture by a factor 2. This has been fixed.
Removed the trailing '\n' at the end of the last line in the OCR output display.

Jean

jeanl

17th February 2006, 22:55

DVDSubEdit is finally out of beta!
Version 1.0 is now available here (http://www.videohelp.com/~DVDSubEdit/)...

Here's the change log from beta 0.90

Added code to crop subpic to the bare minimum width, allowing horizontal moving. This can be applied to all in the usual manner.
Added option to move subpics flush with the nearest border.
The main window is now resizable. I cleaned up a lot of the display code, in an attempt to make things faster and cleaner.
The main window can also be minimized, or maximized, imagine that! The size and position are saved from session to session.
DVDSubEdit no longer needs the CLUT to identify the pixels used for the characters.
Added a "Auto CLUT" check box to show the main text pixels in white, and all others in black.
Added option to load an IFO file after loading a SUP file (this one just for CoNS!).
Improved the OCR code, especially with regards to identifying word boundaries
Fixed a bug that caused the app to crash if you fast reloaded a vob that was no longer there.
Fixed the infamous "display freezes, app starts writing all over" bug! A brush wasn't being released....
DVDSubEdit no longer crashes if you quit while running the OCR function.
The "save subpic to ppm" option was shrinking the subpicture by a factor 2. This has been fixed.
Removed the trailing '\n' at the end of the last line in the OCR output display.

As usual, feedback is welcome!
jeanl

bourtzovlakas

17th February 2006, 23:59

:thanks: :thanks: :thanks:

blutach

18th February 2006, 00:43

Let me add my thanks for this very wonderful tool Jean.

Regards

dirio49

18th February 2006, 01:29

thanks
jean

r0lZ

18th February 2006, 01:35

Great, Jeanl!

Now, onto the automatic translation of the subpics in any language, for v2.0! :D ;)

jeanl

18th February 2006, 01:38

Yes yes yes, that's in the works!! :D :D Thanks guys!
Next features I'm working on, or will start working on:
- Much improved and faster display code (currently using M$ function for adding the subpics with alpha, and that's horrendously SLOW).
- Editing the decoded subpic... First of, removing parts of the subpic text, then perhaps changing the spacing between lines and these kinds of things...

jeanl

voo_doo99

19th February 2006, 22:47

DVDSubEdit is finally out of beta!
Version 1.0 is now available here (http://www.videohelp.com/~DVDSubEdit/)...

Congratulations on the 1.0 Release. ;)

...
Added option to move subpics flush with the nearest border.

Great option, thanks. :D

Miss them buttons in the early betas. :o I kinda wish for a top menu toolbar, or a bottom buttonbar :)

jeanl

20th February 2006, 00:07

Which buttons? The apply to all (Ctrl-A) or the revert? (Ctrl-Z to reload 1 subpic, no shortcut for reload all, but that could be added). These buttons took a lot of space that I needed!
Jeanl

jsoto

20th February 2006, 01:08

Many thanks for the tool. A great one..

jsoto

voo_doo99

20th February 2006, 03:05

Which buttons? The apply to all (Ctrl-A) or the revert? (Ctrl-Z to reload 1 subpic, no shortcut for reload all, but that could be added). These buttons took a lot of space that I needed!
Jeanl
The area on right side of checkbox "Show Video Frame" seems fitting if there is no plan for it. Most used buttons would be "Apply All" and "Save All". Keyboard shortcuts are OK, just not as friendly nor fluid :D

frank

21st February 2006, 12:55

Cannot find the sources 1.0 for that great tool. :(

jeanl

21st February 2006, 17:37

oh yeah, sorry. I'll post the sources, but they will be for 1.0.1!
jeanl

jeanl

21st February 2006, 22:54

Sources for 1.0.2 are posted...
jeanl

CoNS

22nd February 2006, 09:11

jeanl, could you post a compiled version 1.0.2, too?! Thanks :)

jeanl

22nd February 2006, 09:40

Sure, I'll do that tomorrow...
Jeanl

frank

23rd February 2006, 10:11

Great! :)

CoNS

23rd February 2006, 12:37

DVDSubEdit is finally out of beta!
Version 1.0 is now available here (http://www.videohelp.com/~DVDSubEdit/)......where it says "Current version Beta 1.0"...! :D

jeanl

23rd February 2006, 21:40

...where it says "Current version Beta 1.0"...! :D
OK OK, I fixed it! :D
jeanl

jeanl

23rd February 2006, 21:44

Guys, I've put a new version (1.0.5) of DVDSubEdit for you to test. It's unofficial, so I'm not making a big deal of it.
Find it here:
http://www.videohelp.com/~DVDSubEdit/Downloads/DVDSubEdit1.0.5.zip

Improvements are:
- Added function to hide hearing-impaired text. Subtitles that are completely enclosed between [] or () are hidden. Text enclosed between brackets is erased. This is preliminary, test it and tell me what you think! Run the OCR first, of course!!!
- Changed the display mechanism, it is now much much faster! I'm happy with that!
- Improved the OCR speed (by only passing the useful part of the subpic to the GOCR)
- Fixed the "save as txt" function to save as a proper .srt file.

As usual, let me know what you think!
jeanl

dirio49

24th February 2006, 02:23

thanks Jean.
I like the hide hearing-impaired text function.
The text enclosed between brackets is erased.

What does this mean? that is becomes invisible or you have removed it from the subpic all together?

Thanks again

jeanl

24th February 2006, 02:28

It depends...
If the entire subtitle is between brackets, as in
[mutters]
the the entire subtitle his 'hidden' (via the transparency). The bitmap isn't altered.
However, when parts of the subtitle is useful as in:
- [man] You really think so?
the bitmap is altered: [man] is erased, the text right of it is moved to the left where [man] was, and (optionally, but I don't think that's in this version), the entire line is "recentered" so its center is the same as before.

mp3boy

26th February 2006, 09:37

CoNS

26th February 2006, 10:57

mp3boy, in the latest version you can save OCR output as SubRip .srt format.

You can easily load the entire main movie from the DVD by using one of these methods:

1. Drag and drop all VOB files belonging to the main movie VTS.
2. Choose "Open file(s)" from the File menu and select all VOB files belonging to the main movie VTS.
3. Choose "Open full domain" from the File menu and select one VOB file belonging to the main movie VTS.

Teebeeke

28th February 2006, 11:11

@CoNS , when trying method 2, i allways fail, meaning, i can't select more then 1 file, ever.

mp3boy

28th February 2006, 11:35

@CoNS , when trying method 2, i allways fail, meaning, i can't select more then 1 file, ever.

same here, the diolog has disabled multiple file selection

jeanl

28th February 2006, 16:53

That's correct, and that's a mistake! I'll fix that in the next update.
jeanl

mp3boy

28th February 2006, 17:38

That's correct, and that's a mistake! I'll fix that in the next update.
jeanl

thanks alot, by the way your tool is very cool

jeanl

28th February 2006, 20:01

Thanks mp3boy! You have CoNS to thank for that, in a large part. Lots of testing, bug reports and lots of idea for improvements, especially in the useability area!
Jeanl

jeanl

2nd March 2006, 18:42

Version 1.1 of DVDSubEdit is now available here (http://www.videohelp.com/~DVDSubEdit/)...

Main new feature is the ability to erase parts of subtitles bracketed with '[' or '(' or to detect music notes.

Here's the change log from Version 1.0

Added an OCR setup panel with options for OCR, and hearing-impaired text removal.
Added menus to hide/erase hearing-impaired text in subtitles. The remaining text can be optionally recentered or realigned.
GOCR now recognizes (most?) music notes. They are marked as '#' in the output text.
Added ability to move subpics with the mouse. Just grab and move!
Improved the display mechanism, it is now much much faster.
DVDSubEdit now lets you reload individual (or all) SPUs from a sup file (undo).
The "Open vob file" dialog now allows selecting several vobs.
The various save and open dialogs (vob, sup, ppm and srt) now independently remember their default directories. Very convenient.
When opening a sup file, the dialog to optionally load the IFO now defaults to the same directory the sup file was in.
Added "Go to" field to go to a specific spu (Ctrl-G).
Fixed common 'o'->'Q', 'V'->'Y', 'z'->'_', ':'->'_' OCR mistakes.
Improved the OCR speed when the subpic background occupies the full frame.
The "save as txt" function now saves as a proper .srt file.
Added a couple shortcuts (Home and End now go to first and last SPU in current selection).
Added display of "percent done" in progress dialog.
The built-in pdf doc (shortcut: F1) is (nearly) up-to-date.
Fixed a bug that caused the small progress dialog to not close properly if the main window was minimized.
Last but not least: The file version number now matches the actuall version number :D (this one for blutach!)

Thanks to CoNS for many tests, and many many suggestions for improvements.
Feedback is most welcome!
Enjoy...
Jeanl

dirio49

2nd March 2006, 20:19

Thank Jean.:)
:thanks: :thanks: :thanks: :thanks:

BTW what does open ifo do, how do you activated it.

Love that you are able to drap the subs.:D

r0lZ

2nd March 2006, 23:24

Fixed common 'o'->'Q', 'V'->'Y', 'z'->'_', ':'->'_' OCR mistakes.Seems you have finally understood how the OCR works! Congratulations, jeanl!

dirio49

3rd March 2006, 00:15

jeanl

3rd March 2006, 00:19

Thank Jean.:)
:thanks: :thanks: :thanks: :thanks:
BTW what does open ifo do, how do you activated it.
Love that you are able to drap the subs.:D
Open IFO is only enabled if you load a .sup file (unless there's a bug!). If you drop a .sup file, you can load the corresponding IFO to get the CLUT (but it's not smart, it will select the first PGC it can find).

Yes, you can drag/drop a .sup file, and you can reload a subpic from it (you couldn't before).
Jeanl

jeanl

3rd March 2006, 00:20

Seems you have finally understood how the OCR works! Congratulations, jeanl!
Well, I understand part of it, it's a HUGE program, with thousands of lines of code (I wonder how long it took them to write it!), but I'm able to see where things go wrong, most of the time...
But fixing it is a never ending quest!
jeanl

jeanl

3rd March 2006, 00:21

oops forgot to tell you
it does not seem to find the "x" at all
in non-italic i have seen.
for example
"extra"---> "e_tra"
Take you time
it does not really bother me.
Thank again.
BTW way if you want the .Sup of the film so you can test.
just tell me.
dirio49, can you send me the .sup file at jeanldvd at free dot fr? I'll take a look... Such errors are usually symptomatic of something slightly wrong with the code... CoNS must have sent me about 20 .sup files by now! :D :D :D
jeanl

laserfan

8th March 2006, 21:27

Man, if ever a thread deserved a bump this is it. I just tried DVDSubEdit v1.1 on one of my "acid test" DVDs and am delighted by the new features. Removing hearing-impaired subs, including even small snippets thereof, works fantastically well! I love too that you can step-thru the subs and when you get to a thumbnail where nothing is displayed, you can see the removed sub in the text window e.g. [ Faint Applause ].

There may be an error somewhere in there that I haven't seen, but I can state with certainty that even if there are a few, they'd be many less than I would make myself when I previously used to do this by hand!

It seems like it's been only a month or so since I wandered into this program, and already it's been enhanced to do this thing that we (well, except maybe for CONs) never dreamt it could/would do. Heartfelt thanks to jeanl, great work!!!

Also thanks CONs, for your testing and for pointing me to this in the first place. :) :) :)

jeanl

8th March 2006, 21:33

Thanks for the feedback laserfan! :)
jeanl

CoNS

8th March 2006, 22:09

Yeah, laserfan. jeanl has made this app a real beauty. And in no time, too.

Just like you, I'm truly amazed how well the function to remove hearing impaired text works already. When I first mentioned this as a possible request, I didn't really think it was within reach at all. But now it's a fact! Cool! :)

AFAIK jeanl is currently thinking about expanding the hearing impaired removal code even further, by - in addition to the automatic removal function - letting the user select any part of a subpic (either by marking a part of the OCR text output or by selecting a part of the bitmap) and hit "Remove"!

This would make it possible to remove any other kind of unwanted parts of subpics, but in my oppinion it could be extremely useful for removing hearing impaired text in these cases, which are not caught by the automatic removal function:

1. Remove "MAN: " in the "MAN: Get down here, kids!" type of subpics.
2. Remove lyrics that have the syntax "# lyrics" instead of "# lyrics #" ("#" = music note).
3. Remove hearing impaired text wrapped in brackets, where the OCR function for some reason doesn't recognize both brackets in a line (this occurs in some cases with italic text in the subpics).

In all three examples, if the extended, manual removal function was implemented, you could easily deal with those subpics following this method

A. OCR the selected stream.
B. Run the automatic removal function to get rid of as much of this stuff as possible.
C. Filter subpics/display only subpics with these chars: ":#[]()"
D. Go through each of those subpics (usually not very many) and remove any unwanted part.

Especially between step B and C it would also be nice to have the option to let the changes made to the bitmap subpics reflect in the OCR output. I know that jeanl is thinking about implementing this, too! Darn, that guy is smokin' hot! :D