Media Player .NET (MPDN) - D3D HQ GPU Video Renderer [v2.49.0/v1.31.0 27 Dec 2018] [Archive] - Page 26

ryrynz

11th February 2015, 09:53

I have pushed and implemented pretty much everything except for the docking.

I love it. Would be nice to have a settings cog icon to access the options, just cos going into the extension options feels a bit out of the way. I almost want it to be built in to MPDN rather than an extension..
I've found that ticking 'remember previous played file' is actually automatically making that file be played on start up. I guess that could be another option you could add.. I'd also like to see the ability for the playlist to be visible on start up too, thanks!

Just a heads up. v2.21.1 is now properly released with code paths taken from build 2969.

I could be wrong, but I think it's perfect now. I've never seen video delivered more smoothly, no stutters at all that I can see related to MPDN. MadVR has never been able to achieve that on my 750 Ti without Smooth Motion enabled, and although that works well enough it does add it's own jumpy artifacts visible with scrolling text (Fluid Motion that also.) As a result of having frames delivered so well I can now disable Fluid Motion and use the TVs own FRC instead which now gives me the feeling of watching true 60 fps content from just a 24 fps source, simply the best viewing experience I've had to date on PC.

Now if only it had NNEDI..

Zachs

11th February 2015, 10:46

Thanks ryrynz! You've been a great help in testing and reporting bugs! A software development team is never complete without its testers!

Zachs

11th February 2015, 10:50

Zach ran the test build last night and was floored by the
improvements on my GTX-770. Everything seemed to work and the image was like looking through a picture window.
For me this build is exactly what my projector needed!
I wanted to add I am using Windows 10 latest preview.

Thanks

Was that build 2969?

Blackfyre

12th February 2015, 00:45

Hi everyone,

I have tweaked the presentation algorithm further in v2.21.1 builds 2969, 2970 & 2971.

Can you test on your systems using Direct3D9 presenter only to see if it improves fluidity for fluid motion (state whether you're running windowed/exclusive, low/high GPU load (percentage), AMD/NVIDIA/Intel etc.) vs v2.21.0? Also which is better among the test builds?

Downloaded them yesterday when you posted the link all 3 builds, just done some testing today.

Direct 3D9 Presenter was used, upscaling from 1080p to 1440p, no full-screen-exclusive mode, as for some reason under DX9 when I go full-screen mode my picture freezes and sound keeps going (full-screen exclusive mode works with DX10.1 & 11 just fine)... so just full-screen but not exclusive mode is being used...

Under versions 69, 70, and 71... on my 7970... ALL 3 versions were tested under the same video, for the first 2 minutes and a half... GPU usage is exactly the same at 17% across all 3 versions, GPU Memory usage is also identical across all 3 versions... The only difference was perhaps in the CPU Usage across the 8 CPU cores, barely noticeable difference *(within 1 percentile)* between the 3 versions.

4790K (Hyper-Threading Enabled) running @ 4.2Ghz.

Zachs

12th February 2015, 00:51

Blackfyre

12th February 2015, 02:36

A little late to the party - I've already released 2.21.2 based on build 2969 :)

EDIT: BTW, the test builds were meant to test smoothness of playback with and without fluid motion (without SVP). Did you notice any difference between the builds and vs the proper releases?

Always late to the party :( haha

The stats I provided above are all without SVP (thought you might be interested in them). With Fluid Motion enabled, 69 does "appear" to be smoother than 70 and 71 but this could very well be placebo because I have read the comments and I am assuming prior to doing the tests that 69 is the best version.

ryrynz

12th February 2015, 03:13

I love it. Would be nice to have a settings cog icon to access the options

I've found that ticking 'remember previous played file' is actually automatically making that file be played on start up. I guess that could be another option you could add.. I'd also like to see the ability for the playlist to be visible on start up too, thanks!

Nice to see these added so quickly. Is there any chance the settings icon could strip a couple of cogs? Six would be more fitting with the icon being that size.. But it's up to you.. :)

Oh and please sort the options list alphabetically. :3 'Autoplay' could be renamed to 'Automatically play on startup' it would then match the length of the other options and just sound cooler.

Is it possible to have the playlist background match MPDN's off white context menu? (253,253,253)

Hey Zach, if 'Remember previous played file' is ticked could MPDN then make the Play button active? Cheers!

Zachs

12th February 2015, 04:23

Is it possible to have the playlist background match MPDN's off white context menu? (253,253,253)

Hey Zach, if 'Remember previous played file' is ticked could MPDN then make the Play button active? Cheers!

I wouldn't set the background colour to a specific one as they default to your windows colour scheme. The context menu colour be completely different on different machines / OSes.

Making play button active could be done by calling PlayerControl.OpenMedia() followed by PlayerControl.Pause() and PlayerControl.SeekMedia(0). This essentially loads the media file making it ready for immediate playback once user clicks the Play button, which is a bonus in my opinion.

mrcorbo

12th February 2015, 06:25

There's been some nice progress on the player lately.

I like the new playlist in it's current form quite a bit. I did encounter one small issue with the auto-add of the currently playing item to the playlist, though.

When using the MouseControl extension the forward back behavior is determined by (in order) the presence of chapters in the currently playing file, the presence of multiple items in the playlist and finally the presence of multiple files in the folder of the currently playing file. The issue is: if I play a file in a folder with auto-add to playlist active and then advance to the next file in the folder it adds this file to the playlist creating a multi-file playlist and locking the forward back behavior to navigating the playlist instead of continuing to allow folder navigation.

Would it make sense to, specifically when there is only one item in the playlist, replace the existing playlist item with the newly played item instead of adding to it?

ryrynz

12th February 2015, 07:49

Related to mrcorobo's post above, file -> open and file -> quick open should start a new playlist.

Within MPDN adding file -> 'Add file to playlist' I think would be great for someone not wanting the playlist window open.

A couple more playlist requests, add next file in folder automatically would be great and also when MPDN is resized the playlist is resized automatically with it. Thanks.

Garteal

12th February 2015, 14:21

Looks like I have a lot to do lol.

Nice to see these added so quickly. Is there any chance the settings icon could strip a couple of cogs? Six would be more fitting with the icon being that size.. But it's up to you.. :)

Heh, you´re right. Didn´t pay too much attention to the details. If anyone wants to do it feel free to and PM me it so I can switch it up when I get home.

Oh and please sort the options list alphabetically. :3
Will do!

'Autoplay' could be renamed to 'Automatically play on startup' it would then match the length of the other options and just sound cooler.
¨Automatically play file on startup¨, maybe a bit more descriptive? Was just a temporary name, so will definitely change it.

Is it possible to have the playlist background match MPDN's off white context menu? (253,253,253)
I´ll see what I can do.

Hey Zach, if 'Remember previous played file' is ticked could MPDN then make the Play button active? Cheers!
Hmm must´ve slipped by, I´ll take a look at this!

When using the MouseControl extension the forward back behavior is determined by (in order) the presence of chapters in the currently playing file, the presence of multiple items in the playlist and finally the presence of multiple files in the folder of the currently playing file. The issue is: if I play a file in a folder with auto-add to playlist active and then advance to the next file in the folder it adds this file to the playlist creating a multi-file playlist and locking the forward back behavior to navigating the playlist instead of continuing to allow folder navigation.

Seems like it works as intended at the moment. What is focused when you try to go forward and backwards when you say it is ¨locked¨? The playlist is on-top of the player, so make sure the player has focus.

Would it make sense to, specifically when there is only one item in the playlist, replace the existing playlist item with the newly played item instead of adding to it?
I don´t know. Wouldn´t that defeat the purpose of the option?

Related to mrcorobo's post above, file -> open and file -> quick open should start a new playlist.

So those options shouldn´t add to the playlist, just start a new one?

WIthin MPDN adding file -> 'Add file to playlist' I think would be great for someone not wanting the playlist window open.
A separate option in the menu then. Hmm...

A couple more playlist requests, add next file in folder automatically would be great and also when MPDN is resized the playlist is resized automatically with it. Thanks.
So when you add a file to the playlist, it should automatically grab all files from the directory or just the next file?
Resizing both might be a bit funky, but I´ll see what I can do.

mrcorbo

12th February 2015, 14:52

Seems like it works as intended at the moment. What is focused when you try to go forward and backwards when you say it is ¨locked¨? The playlist is on-top of the player, so make sure the player has focus.

I don´t know. Wouldn´t that defeat the purpose of the option?

Because the mouse only has the two buttons for forward/back, as opposed to the multiple options available with keyboard shortcuts, the forward/back behavior needs to be contextual. You can see an example of the desired behaviors in MPC-HC (you don't even need to use the mouse, just use the forward/back buttons on the player UI) by playing a file that has chapters and using forward/back, creating a multi-file playlist of files that don't have chapters (or navigating back from the first or forward from the last chapters) and using forward/back and then playing a single file from a folder with multiple files in it and using forward/back. Note the contextual behavior and how the playlist behaves in the latter two cases. Really, a lot of what is being requested here is just, "Make MPDN work like MPC-HC does". This, with your improvements, would be ideal.

Garteal

12th February 2015, 18:30

^ alright, I see what you mean now. I've changed it now to your earlier request. I like how it works now. Got to make some more changes and test before I can push.
Thanks for the feedback guys.

ryrynz

12th February 2015, 20:11

So those options shouldn´t add to the playlist, just start a new one?

Yup, just like MPC-HC.

So when you add a file to the playlist, it should automatically grab all files from the directory or just the next file?

Play the next one automatically, I'm thinking once the current file is finished playback only then is the next file added to the playlist (replacing the previous one) and then playback continues automatically.

Dallen

12th February 2015, 20:40

I hate this forum and the question it has me answer before I can post or reset my password, who really knows the answer to some of these things?

I really like MPDN though, and I have to ask, is ReClock needed anymore? Does ReClock only work with the x32 version? Even though I see a green ReClock in my bottom right taskbar I can't right-click the icon as I usually can, is this something you can explain?
Another thing I noticed was that I couldn't bitstream with the x64 version at first, then I downloaded the x32 version and successfully bitstreamed to my home cinema, after that the x64 version would magically work as well. Strange?

I've tried looking through the thread but since I only understand half of everything being said here I also have to ask if there are some simple instructions to follow on how to get the best image quality possible, are there any guides out there?

And yes, MPDN really does look like MPC-HC's more handsome brother, thank you!

ryrynz

12th February 2015, 22:20

Does ReClock only work with the x32 version?

Yes.

I really like MPDN though, and I have to ask, is ReClock needed anymore?

It's not necessary for optimal playback for most users at all. Ditch it and if you can't see a difference then it's one less thing you need to concern yourself with.

Another thing I noticed was that I couldn't bitstream with the x64 version at first, then I downloaded the x32 version and successfully bitstreamed to my home cinema, after that the x64 version would magically work as well. Strange?

Strange indeed.

are some simple instructions to follow on how to get the best image quality possible, are there any guides out there?

No guides yet. Image quality is generally subjective and guides shouldn't cover such things IMO. I always recommend people take screenshots and compare for themselves. That being said the SuperRes algorithms with NEDI would probably be your best bet for improved image quality over the standard resizers.

Zachs

17th February 2015, 12:17

I've implemented madVR 3dlut support as requested with the file format from nev (thanks!) and they're now available on GitHub (or simply download from the link in OP).

Cheers.

p.s. Anyone feel like starting an "MPDN options explained" thread? :p

YxP

17th February 2015, 12:31

Thanks, missing 3dlut support was the only thing for me not to really start getting into this player :)

huhn

17th February 2015, 19:48

I was try out the 3d lut feature but I get a lot of audio drops. fluid motion is active but playback is not smooth. frames are not dropped but rendertimes are jumping around like crazy 8 ms to 14 ms.

edit: the directsound device audio buffer is between 32%-45% I guess that's most of the issue.

edit2: looks like the smoothness issue have something to do with the DWM glitches. DWM is he desktop composition or at least has a lot to do with it and this is used for v sync on windows vista and newer.

iSunrise

17th February 2015, 22:49

Did some testing of this player today, seems very promising!

Some things that I would like to see though:

1) Since LAV now finally supports RTMP (and other protocols that already were supported before), can you implement support for network sources (URL)? E.x. for watching livestreams through the Livestreamer application.

2) When switching to fullscreen or back to windowed (doesn't matter whether fullscreen exclusive is on or off) there's a short audio break and the audio continues when the player has switched states. This doesn't happen with other players (e.x. PotPlayer with LAV filters). Is it possible to fix this?

3) Minimal mode is nice, but I would love to have a completely borderless video only (in PotPlayer you can press H, it hides everything apart from the video area).

4) When playing a video, you can see which LAV filters (splitter, video and audio decoders) are invoked, but you can't actually see what the splittter detected in the source (video, audio and subtitle properties). Is it possible to add that?

5) Live-cropping support would be nice. If I want to display e.x. a 1920x1200 source (video game recording) on a 1920x1080 screen, I just could activate cropping and then MPDN would ignore everything outside of my defined video region (from x to x, from y to y).

Other than that, keep up the good work!

Blackfyre

17th February 2015, 23:00

Since LAV now finally supports RTMP (and other protocols that already were supported before), can you implement support for network sources (URL)? E.x. for watching livestreams through the Livestreamer application.

+1 :cool: I've already requested this ages ago, but Zachs said it couldn't be done. Hopefully since LAV finally supports RTMP (whatever that stands for) he can finally do it.

Would be great if I can run Sopcast links; which use WMP by default, but can run on external players such as MPC+Madvr (which is what I currently use for online streaming).

ryrynz

17th February 2015, 23:01

2) When switching to fullscreen or back to windowed (doesn't matter whether fullscreen exclusive is on or off) there's a short audio break and the audio continues when the player has switched states. This doesn't happen with other players (e.x. PotPlayer with LAV filters). Is it possible to fix this?

MadVR has this same delay and it's AFAIA it's the nature of how the rendering is done with both renderers. There is more of a delay when switching using MPDN over MadVR, maybe this can be improved, I don't believe it's something that can be fixed as such.

*Edit* The delay only applied to using double click to switch modes and is dependent on the media player used not the renderer.

4) When playing a video, you can see which LAV filters (splitter, video and audio decoders) are invoked, but you can't actually see what the splittter detected in the source (video, audio and subtitle properties). Is it possible to add that?

Much of that info can be found under Audio and Subtitle in the context menu. The rest can be found under the View -> Media Info (Ctrl-Shift-I) So having that info show in the splitter menu would be just duplicating it.

iSunrise

17th February 2015, 23:41

MadVR has this same delay and it's AFAIA it's the nature of how the rendering is done with both renderers. There is more of a delay when switching using MPDN over MadVR, maybe this can be improved, I don't believe it's something that can be fixed as such.
With the current state of madVR there's only a "slight" video delay, because the player tells madVR to go into fullscreen/fullscreen exclusive and madVR then invokes Direct3D FSE to switch to fullscreen exclusive (which is fine by me). Again, this change is not what I am talking about.

There is however an audio break, which is happening both with FSE or normal fullscreen (and back to windowed). The audio just suddenly stops playing and after switching states, it will continue again. This does not happen with PotPlayer or other players.

Much of that info can be found under Audio and Subtitle in the context menu. The rest can be found under the View -> Media Info (Ctrl-Shift-I) So having that info show in the splitter menu would be just duplicating it.
I know, but I find that not very user-friendly, therefore I want Zachs to be aware of it. Having to go to several menu options and keycommands to switch audio/video/subtitles is not very convenient to use IMHO.

ryrynz

17th February 2015, 23:54

There is however an audio break, which is happening both with FSE or normal fullscreen (and back to windowed). The audio just suddenly stops playing and after switching states, it will continue again. This does not happen with PotPlayer or other players.

Switching from the view menu or the keyboard shortcuts is seamless for me, FSE or windowed mode. The double click on the video frame could be better registered to switch display modes. I think that's sometimes a problem when you have single clicks pausing the video.

iSunrise

18th February 2015, 00:45

Switching from the view menu or the keyboard shortcuts is seamless for me, FSE or windowed mode. The double click on the video frame could be better registered to switch display modes. I think that's sometimes a problem when you have single clicks pausing the video.
Yes, that's the problem I am experiencing. It seems that a single click pauses, while double-clicking is for changing to FSE and back to windowed, which causes the audio break.

Switching from the view menu or ALT+Enter is also seamless for me.

Garteal

18th February 2015, 00:59

Finally back-ish. Did some work on the requests and they're pretty much done. Well... except for the settings icon. Does anyone have anything to contribute?
Pondering whether I should put ryrynzs' last request behind an option or make it the default behavior. Thoughts?
Play the next one automatically, I'm thinking once the current file is finished playback only then is the next file added to the playlist (replacing the previous one) and then playback continues automatically

Yes, that's the problem I am experiencing. It seems that a single click pauses, while double-clicking is for changing to FSE and back to windowed, which causes the audio break.
Yeah that's normal since MPDN pauses the video when you click in the frame. If you want to use your mouse (by middle clicking) for fullscreen toggling, then simply enable the "windowed / fullscreen toggle with middle click" in Player Extension -> Mouse Control -> Config.

mrcorbo

18th February 2015, 01:38

ryrynz

18th February 2015, 01:41

Pondering whether I should put ryrynzs' last request behind an option or make it the default behavior.

Options are always good.

Yeah that's normal since MPDN pauses the video when you click in the frame. If you want to use your mouse (by middle clicking) for fullscreen toggling, then simply enable the "windowed / fullscreen toggle with middle click" in Player Extension -> Mouse Control -> Config.

I do wonder if a small delay could be used before pausing to determine if there is going to be a double click.. although the middle mouse button option is a great alternative.

Well... except for the settings icon. Does anyone have anything to contribute?

I haven't created an icon file or made a higher resolution version, I simply pixel edited a screenshot of your original. Don't know if that's useful to you or not, do with it as you please.
Still 8 points on it, just looks more cog like.

http://s13.postimg.org/y52akkb0j/cog.png *edited to improve cogness, transpacency, colors*

thogil

18th February 2015, 16:11

3) Minimal mode is nice, but I would love to have a completely borderless video only (in PotPlayer you can press H, it hides everything apart from the video area).

I have a similar request:

Could we have command line toggles for borderless? It would be a bonus if there was also a command line for initial window state, size and position. I can change all of these things from within a player extension, but there is afaik no way for an extension to set these prior to the window opening and the player initializing.

Either command line args, or some way for player extensions to hook into the initial window creation process, would be much appreciated.

Edit After some investigation, perhaps the easiest way to implement what I need is for MPDN to provide a command line arg for specifying an alternate directory to use instead of %AppData%/Local/MediaPlayerDotNet. That would also address a few other issues for me.

Zachs

20th February 2015, 16:09

I'll see what I can do, but I don't like the idea of having an alternate directory though. What exactly are you trying to achieve?

thogil

20th February 2015, 20:19

I am investigating writing a new player plugin for Media Browser (http://mediabrowser.tv/) Theater.

By a large margin, most of the issues our users have stem from our (DirectShow based) internal player implementation. MPDN already appears more stable, and the rate of development is very promising. If MPDN proves to be practical, I may make it the default player, and only fall back onto our own player when we encounter media that MPDN cannot handle (such as streamed content).

In order for playback to appear fairly seamless, I am re-parenting our own window as a child of MPDN, switching MPDN to minimal and borderless, and keeping both windows' state and position in sync - such that MBT's UI appears to draw on top of MPDN. Of course, we cannot enter FSE mode and keep our UI visible.

Currently, I am interacting with MPDN via the remote control extension, which I have modified to add commands to also allow MBT to control MPDN's window. The problem is that MPDN initially pops up in normal windowed mode, and only after loading it's extensions and establishing a connection with MBT does it merge with the MBT window. This can be a little jarring.

If I could configure the initial startup state of the window, then the transition would be much more fluid. Certainly, there are better ways of doing this than re-directing the .config file, but I assumed that would likely involve the least work on your end. In addition, it would allow me to package a copy of MPDN with MBT, and avoid having MBT's configuration customisations conflicting with an MPDN install that the user may already have on their machine (and potentially differences in installed extensions, as they appear to be compiled into the app data folder, too).

Alternatively, MPDN could expose its configuration for extensions to modify. I obviously do not know how difficult this would be to implement, but I assume it could potentially be quite far reaching; .e.g. extensions may need to be loaded earlier in the startup process, or perhaps all of the types serialised into the .config file will need to be public (or expose public interfaces).

Zachs

21st February 2015, 01:58

I'll have a think about it but I like the fact that you're considering MPDN as MBT's default player.

I gave long planned to have extension access and change MPDN's config but haven't gotten around to it yet. It's quite easy to implement actually.

Perhaps you're right in this instance to have a separate config file seeing as norms usage in your case is different enough to warrant such a feature. But I still want to allow extensions access to MPDN's config.

I'll likely do both in the longer term.

Anime Viewer

22nd February 2015, 00:19

ryrynz

22nd February 2015, 00:45

mrcorbo

22nd February 2015, 06:07

Noticed a couple of oddities with drag & drop behavior and with the "Remember previously played file" option.

Drag & dropping folders to either the player or playlist no longer works. I had added this to the old playlist (see Commit#'s 9a2ab4873d0fd22cba9c9cf983053f18f566cf28 (https://github.com/Mercy07/MPDN_Extensions/commit/9a2ab4873d0fd22cba9c9cf983053f18f566cf28) & 603b01d420e4d7b0e287ead25072d4a5e6b2c100 (https://github.com/Mercy07/MPDN_Extensions/commit/603b01d420e4d7b0e287ead25072d4a5e6b2c100)).
The file extension "whitelist" that was expanded in the second commit was added to prevent metadata, coverart, etc. that might be present in the folder from being added to the playlist along with the videos.

When dragging a file onto the player window without "On file open, add to playlist" unchecked, the file automatically plays. When this option is active the file does not automatically play when dropped on the player window, it just gets added to the playlist.

When "Remember previously played file" is checked, the file automatically begins to play on the next startup, even when "Automatically play file on startup" is unchecked.

**Edit** Forgot to add this is all using the latest version of PlaylistForm from Garteal's Github.

ryrynz

22nd February 2015, 09:29

ATM File -> Add file to Playlist does nothing. (Could be renamed Add file(s) to playlist)

I'd like to see Quick Open using the exact same window as the add files icon in the playlist only difference being when Quick Open is used of course the first file is automatically played.

Could you allow the delete key to remove files?

Can you make MPDN's play button active when 'Remember previously played file' is ticked too?

Making play button active could be done by calling PlayerControl.OpenMedia() followed by PlayerControl.Pause() and PlayerControl.SeekMedia(0).

Perhaps Add files and Remove files can also be renamed to Add file(s) and Remove file(s)?

DeadlyEmbrace

22nd February 2015, 15:10

I've finally integrated Playlist control into the Remote Control code.
The new version of the Remote can be grabbed from here: https://github.com/DeadlyEmbrace/MPDN_RemoteControl/releases/download/1.2.0/MPDN_RemoteControl_v1.2.0.zip
Beside playlist integration it includes multiple minor bugfixes.

As soon as Zachs pull in the new Remote Control code into the main extension repository the playlist functionality will work, until then the code can be grabbed from my fork.

Zachs

22nd February 2015, 15:37

Merged. I'll update the OP to the new remote v1.2.0.

Garteal

22nd February 2015, 17:04

Anyone else have a problem with playlist where it will skip the first file you add to the play list?

For example lets say you have videos 1-10. You launch video #1 in MPDN, and then open the playlist and add videos #2-10. When video #1 ends instead of playing video #2 it launches #3 skipping #2.
Ah I see what you mean. I've reproduced it and will roll out a fix.

Noticed a couple of oddities with drag & drop behavior and with the "Remember previously played file" option.

Drag & dropping folders to either the player or playlist no longer works. I had added this to the old playlist (see Commit#'s 9a2ab4873d0fd22cba9c9cf983053f18f566cf28 (https://github.com/Mercy07/MPDN_Extensions/commit/9a2ab4873d0fd22cba9c9cf983053f18f566cf28) & 603b01d420e4d7b0e287ead25072d4a5e6b2c100 (https://github.com/Mercy07/MPDN_Extensions/commit/603b01d420e4d7b0e287ead25072d4a5e6b2c100)).
The file extension "whitelist" that was expanded in the second commit was added to prevent metadata, coverart, etc. that might be present in the folder from being added to the playlist along with the videos.
Ah yes I remember this. This slipped by after changing the listbox to a dgv. Thanks for linking the commits, I put it on the list.

When dragging a file onto the player window without "On file open, add to playlist" unchecked, the file automatically plays. When this option is active the file does not automatically play when dropped on the player window, it just gets added to the playlist.

If you have "Automatically play file on startup" checked, it also plays the file. Do we want the default behavior to automatically play the file that gets dropped into the player?

When "Remember previously played file" is checked, the file automatically begins to play on the next startup, even when "Automatically play file on startup" is unchecked.

About this; I've left it as is for now until Zach gets back to me about the PlayerControl media functions. It will eventually just have the file ready to play (with the play button lit on the MPDN window).

ATM File -> Add file to Playlist does nothing. (Could be renamed Add file(s) to playlist)

It does work? Only I don't see why it's (or it will) be very useful.
Start with an empty playlist (have "On file open, add to playlist" disabled) and press that option and it should get added.

Perhaps elaborate a bit more on what it should do if the above isn't what you had in mind.

I'd like to see Quick Open using the exact same window as the add files icon in the playlist only difference being when Quick Open is used of course the first file is automatically played.
Are you referring to the directory it starts in?

Could you allow the delete key to remove files?

Yep yep, been on my mind but never got around to it.

Can you make MPDN's play button active when 'Remember previously played file' is ticked too?

See the last quote in my reponse to mrcorbo.

Perhaps Add files and Remove files can also be renamed to Add file(s) and Remove file(s)?
Why not.

Thanks for the reports.

mrcorbo

22nd February 2015, 18:14

Ah yes I remember this. This slipped by after changing the listbox to a dgv. Thanks for linking the commits, I put it on the list.

No problem. I hope it saves you some time/effort.

If you have "Automatically play file on startup" checked, it also plays the file. Do we want the default behavior to automatically play the file that gets dropped into the player?

Yes, please. And if a folder gets dropped onto the player window it should add all of the files in the folder to the playlist and start playing the first file. If I am dropping something onto the player window I want it to play right away. If I am dropping something onto the playlist window I am just creating or adding to a playlist.

About this; I've left it as is for now until Zach gets back to me about the PlayerControl media functions. It will eventually just have the file ready to play (with the play button lit on the MPDN window).

Perfect. Thanks.

One other cosmetic thing. Can there be an option to only show the filename in the playlist instead of the whole path? My paths can be quite long and in order to show the whole path in the playlist, the playlist windows ends up having to be much wider than it would be otherwise.

Garteal

22nd February 2015, 18:22

Yes, please. And if a folder gets dropped onto the player window it should add all of the files in the folder to the playlist and start playing the first file. If I am dropping something onto the player window I want it to play right away. If I am dropping something onto the playlist window I am just creating or adding to a playlist.
Makes sense yes, consider it done.

One other cosmetic thing. Can there be an option to only show the filename in the playlist instead of the whole path? My paths can be quite long and in order to show the whole path in the playlist, the playlist windows ends up having to be much wider than it would be otherwise.
This is another thing that I've been meaning to do. You're right of course.

After I've implemented these two as well, I'll push out something for testing.

Edit: Pushed. Check my fork.

Edit 2: Just to relay some of the things that have been done here... (You can always read what I've done in my commit messages)
- New settings icon (thanks ryrynz!)
- Sorted playlist config options
- Opening a file via the menu creates a new playlist and adds that file to the playlist
- "Add file to playlist" option has been added to the menu
- "On file open, add to playlist" doesn't add to the playlist anymore when there's only one file in it (it works similar to MPC-HC now)
- "Play next file in directory after playback" option has been added
- Fixed playing the correct file after playing a file in MPDN and adding to the playlist afterwards
- Added dragging and dropping folders with context. Dropping a folder unto the MPDN video frame will add every file in that directory to the playlist and begin playing the first file. Dropping a folder on the playlist will just add them to the playlist
- Fixed dragging and dropping a file unto the MPDN video frame so that it always plays the dropped file
- You can now press "Delete" on your keyboard to delete items
- You can now choose to display either the full path or just the filenames in the playlist
- Other fixes and cosmetic changes

mrcorbo

23rd February 2015, 03:17

That was quick!

I did find a couple of minor glitches both of which I think can be prevented by not allowing the user to delete an actively playing file from the playlist. **edit** or maybe not see edit below.

Firstly, it's possible to de-sync the file playing in the player from the file(s) in the playlist. To reproduce:

With "Remember previously played file" active, load up two files in the playlist. Start playing one and then delete that file from the playlist. Close the player. On reopening the player, the last played file (which was deleted from the playlist) is queued up to play. The playlist, though, shows the other file of the two that were originally loaded.

Secondly, if the currently playing file is the only file in the playlist an "index is out of range" error is generated if you delete the file from the playlist. **edit** This also happens when the player is started and the last file played is "queued up" in the player. If you delete the file from the playlist the error is also generated and the player is again de-synced from the playlist. Maybe then, a better solution for both scenarios is to stop/de-queue the file from the player when it is deleted from the playlist?

Re-using the file dialog filter list for the playlist allowed files whitelist was pretty slick, BTW.

ryrynz

23rd February 2015, 07:02

Ahh my name in credits!
http://s21.postimg.org/o4btsro0j/500px_Oh_you_show.jpg (http://postimg.org/image/o4btsro0j/)

Looks like you got some other updates in your build that haven't been pushed through to MPDN yet, had to pick the playlist files out independently.

Found a couple of bugs,

1) With two files in the playlist, have play next file in folder ticked, upon reaching the end of the last file in the playlist the next file starts playback but it is not added to the playlist until the next file is loaded.

2) Loading more than one file in the playlist, closing MPDN and reloading it only shows the first item that was in the playlist on close.

Here's something () I chucked together that you might wish to use for MPDN's Playlist icon (saved as a .ico file)

Picture for the curious.
http://s10.postimg.org/69jkl3ef9/bigplaylist.jpg (http://postimg.org/image/69jkl3ef9/)

If you have "Automatically play file on startup" checked, it also plays the file. Do we want the default behavior to automatically play the file that gets dropped into the player?

Ahh. This has a different function than I was expecting. My thought was that being able to add additional files to the playlist without having the playlist open would be handy, perhaps that can be added also.

Are you referring to the directory it starts in?

Everything's working fine with your latest changes.
Would anyone want an option to prevent the playlist from becoming transparent when the mouse isn't over it?

Zach, can we get a clean cut when stopping the video or closing the player after pausing? Doing either causes an additional frame or two to be displayed before stopping/shutting down.
Any plans on having a built in nrmap cleaner? Perhaps anything not created on the same day as the current version's could be deleted? That way testers could still retain useful nrmaps..
or if it's trivial to recreate them just delete everything but the current version.

thogil

23rd February 2015, 10:28

I am having some issues with subtitles:

1) Play->Subtitle is always greyed out in all videos.
2) Some videos play with subtitles, others do not (most don't). I need to do more investigation into what may be different about the two types of videos, but does not appear to be caused by subtitle codec, default or forced, video container type, or the number of subtitle tracks available.
3) PlayerControl.SubtitleTracks does correctly list all subtitles.
4) PlayerControl.SelectSubtitleTrack does not appear to do anything.

The above happens with both DirectVobSub and XySubFilter. I have only tested on one machine, so I do not know if it could be an issue with my XySubFilter install or DS configuration.

Garteal

23rd February 2015, 13:46

With "Remember previously played file" active, load up two files in the playlist. Start playing one and then delete that file from the playlist. Close the player. On reopening the player, the last played file (which was deleted from the playlist) is queued up to play. The playlist, though, shows the other file of the two that were originally loaded.

This has been fixed and is done properly now.

Secondly, if the currently playing file is the only file in the playlist an "index is out of range" error is generated if you delete the file from the playlist. **edit** This also happens when the player is started and the last file played is "queued up" in the player. If you delete the file from the playlist the error is also generated and the player is again de-synced from the playlist. Maybe then, a better solution for both scenarios is to stop/de-queue the file from the player when it is deleted from the playlist?

Yep, it'd happen if there's only one file in the playlist and you try to delete it. It should be fixed now. Forget to specify one more condition.

Re-using the file dialog filter list for the playlist allowed files whitelist was pretty slick, BTW.
Thanks! And thank you for writing out detailed steps for reproduction!

Ahh my name in credits!
Well you do contribute. Plus that whitespace needed to be filled :P

Looks like you got some other updates in your build that haven't been pushed through to MPDN yet, had to pick the playlist files out independently.
Not yet no. Since you're both capable of grabbing them from my fork we can continue a bit longer here until it's a bit more stable then I'll do a PR. You don't need to independently pick out the playlist files btw (unless you've manually edited scripts) since I'm usually synchronized with the upstream. If you see "x commits behind zachsaw:master" then you do need to pick them out manually.

1) With two files in the playlist, have play next file in folder ticked, upon reaching the end of the last file in the playlist the next file starts playback but it is not added to the playlist until the next file is loaded.

Fixed.

2) Loading more than one file in the playlist, closing MPDN and reloading it only shows the first item that was in the playlist on close.

Yep, it only remembers the last played file, do we want it to remember multiple files? 10 max?

Ahh. This has a different function than I was expecting. My thought was that being able to add additional files to the playlist without having the playlist open would be handy, perhaps that can be added also.

Well since the quick open and open menus create a new playlist, you'll always start with an empty list, so that kind of renders this option useless unless it doesn't blank out the playlist. Dragging and dropping a file unto the playlist (or MPDN window) already puts it in there (same with multiple files). So right now the only way to have a file not be in the playlist on open is to have "On file open, add to playlist" disabled and opening a file via the MPDN menu.

Here's something () I chucked together that you might wish to use for MPDN's Playlist icon (saved as a .ico file)
Looks great. Though I think this should be done with a FileAssociation extension which I believe DeadlyEmbrace was eager about to work on.