BDSup2Sub - convert and tweak bitmap subtitle streams (VobSub,BD-SUP,BDN XML,HD-SUP)

[SassBot]

That will be OK, although IMO that flag is not necessary. If some settings are provided via the command line, I suppose that the program can assume that the user wants them by default. You can simply overwrite all defaults that have been specified with the CLI. (I've not verified, but according to the original doc, it's what the original version is supposed to do.)

I was talking about an internal flag so that the setting doesn't get overridden when the file is loaded via the GUI. When you use the CLI it doesn't set that language settings until right before it saves the file so in that case it isn't overridden by the language id read from the IFO or IDX file. It was just a simple oversight.


Thanks for the other info, and for the very informative link. I'm currently doing some tests with colour indexes different than the last one, but I can already confirm that the last colour was used, and was black. But if it's really a bug of the player, I don't understand why SubtitleCreator doesn't have the same issue. Will try to understand...

Maybe SubtitleCreator does something similar to what mjuhasz did with his WDTV branch of BDSup2Sub? I'd look to see if the output you get from that WDTV version gives you the desired output and then I'll integrate the changes in.

[r0lZ]

OK, understood.

For the outline problem, why not incorporate the fix anyway. Even if my problem is not that one, the fix may be useful to others. Just a suggestion.
BTW, sorry, I will need some time. I have to check all tries with my external LaCie, and copy the test MKV files with FTP. It's somewhat long...

[r0lZ]

Oh, and I have another (little) suggestion. Could you print the version number of the program to stdout when a conversion is made from the CLI? IMO, it's an important info to add to the log.

[r0lZ]

Goal! That was the problem!
Note that I have not used the mod. The original CLUT is almost entirely black, except colour 13 (light grey), assigned to e1. The black colours 12, 14 and 15 were used for b, p and e2. I've just reassigned them to colour 0, with DVDSubEdit. Then I've applied to all, and saved the subs in the original VOB. I did the whole process of demuxing and converting the SUP with your version, and muxed to MKV. Problem gone! :)
So, yes, the fix is needed! (I'm not sure the option to apply it is really necessary. Perhaps you can apply it anyway?)

[SassBot]

Goal! That was the problem!
Note that I have not used the mod. The original CLUT is almost entirely black, except colour 13 (light grey), assigned to e1. The black colours 12, 14 and 15 were used for b, p and e2. I've just reassigned them to colour 0, with DVDSubEdit. Then I've applied to all, and saved the subs in the original VOB. I did the whole process of demuxing and converting the SUP with your version, and muxed to MKV. Problem gone! :)

Ok, I'll look into taking in the changes.

So, yes, the fix is needed! (I'm not sure the option to apply it is really necessary. Perhaps you can apply it anyway?)

As long as it has no negative effects on anything that doesn't need the fix it can be the default behavior. At least until we can see that the change is totally benign, I'll just make it a selection option for when creating subs for hardware players.

[SassBot]

So that I can push out the 1.0.0 final, I will create a RC with the fix for the subtitle language not carrying over when specified via CLI later tonight. Unless there are any other showstoppers reported, I will push out the 1.0.0, tag that branch and then I will integrate the WDTV fixes in and do the mod 2 cropping change for the first iteration after that.

[r0lZ]

IMO, the change should not have any impact if you swap the transparent colour with colour #15. Even if the stream uses all available colours, it should always be safe to put the transparent background in the last "slot", as long as the original colour of that slot is swapped too.

Now, the question is: do you need to swap the colours and transparency individually for each subtitle, or can you assume that all subpics use the same colours? I'm sure it's extremely rare, but it is theoretically possible to use all colours of the clut with a single subpic stream, since the colours can change at each subpic. So, IMO, to be safe, the swap must be made for each subpic individually.

[SassBot]

IMO, the change should not have any impact if you swap the transparent colour with colour #15. Even if the stream uses all available colours, it should always be safe to put the transparent background in the last "slot", as long as the original colour of that slot is swapped too.

Okay, then I'll just integrate it.


Now, the question is: do you need to swap the colours and transparency individually for each subtitle, or can you assume that all subpics use the same colours? I'm sure it's extremely rare, but it is theoretically possible to use all colours of the clut with a single subpic stream, since the colours can change at each subpic. So, IMO, to be safe, the swap must be made for each subpic individually.

Yeah, subpic by subpic is the best way and also the way mjuhasz did it.

Also for the 1.1.0 release there's a comestic fix I'll implement for the IDX writing out. BDSup2Sub writes out the IDX in a different way than say VobSub or SubtitleCreator by leaving out some of the comment sections and using slightly different names for sections headers so I'm going to change mine to write out the file more the standard way.

For example from the IDX you sent me:


# VobSub index file, v7 (do not modify this line!)
# Created by SubtitleCreator v2.3rc1
#
# To repair desyncronization, you can insert gaps this way:
# (it usually happens after vob id changes)
#
# delay: [sign]hh:mm:ss:ms
#
# Where:
# [sign]: +, - (optional)
# hh: hours (0 <= hh)
# mm/ss: minutes/seconds (0 <= mm/ss <= 59)
# ms: milliseconds (0 <= ms <= 999)
#
# Note: You can't position a sub before the previous with a negative value.
#
# You can also modify timestamps or delete a few subs you don't like.
# Just make sure they stay in increasing order.


# Settings

# Original frame size
size: 720x576

# Origin, relative to the upper-left corner, can be overloaded by aligment
org: 0, 0

# Image scaling (hor,ver), origin is at the upper-left corner or at the alignment coord (x, y)
scale: 100%, 100%

# Alpha blending
alpha: 100%

# Smoothing for very blocky images (use OLD for no filtering)
smooth: OFF

# In millisecs
fadein/out: 0, 0

# Force subtitle placement relative to (org.x, org.y)
align: OFF at LEFT TOP

# For correcting non-progressive desync. (in millisecs or hh:mm:ss:ms)
# Note: Not effective in DirectVobSub, use "delay: ... " instead.
time offset: 0

# ON: displays only forced subtitles, OFF: shows everything
forced subs: OFF

# The palette of the generated file
palette: 000000, 000000, 000000, 000000, 000000, 000000, 000000, 000000, 000000, 000000, 000000, 000000, 000000, CCCCCC, 000000, 000000

# Custom colors (transp idxs and the four colors)
custom colors: OFF, tridx: 1000, colors: cbcbcb, cbcbcb, 000000, cbcbcb

# Language index in use
langidx: 0

# French
id: fr, index: 0
# Decomment next line to activate alternative name in DirectVobSub / Windows Media Player 6.x
# alt: French
# Vob/Cell ID: 1, 1 (PTS: 0)


Whereas BDSup2Sub writes it out like:


# VobSub index file, v7 (do not modify this line!)
# Created by BDSup2Sub++ 1.0.0b11

# Frame size
size: 720x576

# Origin - upper-left corner
org: 0, 0

# Scaling
scale: 100%, 100%

# Alpha blending
alpha: 100%

# Smoothing
smooth: OFF

# Fade in/out in milliseconds
fadein/out: 0, 0

# Force subtitle placement relative to (org.x, org.y)
align: OFF at LEFT TOP

# For correcting non-progressive desync. (in millisecs or hh:mm:ss:ms)
time offset: 0

# ON: displays only forced subtitles, OFF: shows everything
forced subs: OFF

# The palette of the generated file
palette: 000000, 000000, 000000, 000000, 000000, 000000, 000000, 000000, 000000, 000000, 000000, 000000, 000000, cccccc, 000000, 000000

# Custom colors (transp idxs and the four colors)
custom colors: OFF, tridx: 1000, colors: 000000, 444444, 888888, cccccc

# Language index in use
langidx: 0

# English
id: en, index: 0
# Decomment next line to activate alternative name in DirectVobSub / Windows Media Player 6.x
# alt: English
# Vob/Cell ID: 1, 1 (PTS: 0)

Not a major change most anyone will notice but will just make it look more like what other programs write out.

[SassBot]

Release candidate for 1.0.0 can be downloaded here (https://github.com/downloads/amichaelt/BDSup2SubPlusPlus/bdsup2sub++100rc.7z). Now all CLI arguments should be properly override all values when the GUI is launched. It also outputs the program name and version number to the CLI when conversion starts. If no one can find any more showstopper issues I will tag the 1.0.0 branch and move on with the further fixes and enhancements. Also, I will start getting this packaged up for inclusion in Debian Testing.

[r0lZ]

I haven't had much time to check all features and possibilities, and I did almost all my tests with the same DVD streams. I should still check the possibility to shift the subpics along the X axis, but that's for 3D BDs and I'm not working on that currently. I have also just downloaded the 1.0.0 RC, and it's already late here.
Anyway, the current version seems stable enough to release it.

Will you start a new thread for the final release? IMO, mixing the comments about the two versions in the same thread is confusing (and I need an URL for the Help menu of my GUIs!)

[SassBot]

Yeah, I'll start a new thread.

[SquallMX]

Release candidate for 1.0.0 can be downloaded here (https://github.com/downloads/amichaelt/BDSup2SubPlusPlus/bdsup2sub++100rc.7z). Now all CLI arguments should be properly override all values when the GUI is launched. It also outputs the program name and version number to the CLI when conversion starts. If no one can find any more showstopper issues I will tag the 1.0.0 branch and move on with the further fixes and enhancements. Also, I will start getting this packaged up for inclusion in Debian Testing.

:helpful: the program is consuming GBs of RAM after loading Blu-ray SUP files:

http://img502.imageshack.us/img502/3832/bdsup.png

[SassBot]

Ok... How many subpictures are in the SUP file you loaded? How does that compare to the Java version? I just loaded a BD SUP with 618 subpictures and BDSup2Sub++ uses 30 megs of RAM after loading it whereas the java version is ~220 megs. During writing back out to a BD SUP it peaked at about 130 megs. Can you post the SUP file you were using?

[SquallMX]

Ok... How many subpictures are in the SUP file you loaded? How does that compare to the Java version? I just loaded a BD SUP with 618 subpictures and BDSup2Sub++ uses 30 megs of RAM after loading it whereas the java version is ~220 megs. During writing back out to a BD SUP it peaked at about 130 megs. Can you post the SUP file you were using?

It happens with any SUP file as long as you move from one subpicture to the next, and to the next... each additional subpicture increases RAM consumption by 20 MBs approx. So, after ~800 subpictures a Windows Warning Message about low RAM pops ups recommending me to close BDSup2Sub.

[r0lZ]

SassBot, I have an important work for you! (Not to do immediately, of course, but later, if you have some time.)

As you know, I've asked an option to shift the subpics horizontally by a few pixels, as it's necessary to hardcode blu-ray 3D subtitles over the video with Avisynth. You have been very kind to implement it. However, as you can see here (http://forum.doom9.org/showthread.php?p=1581205#post1581205), there is also a need for 3D SUB/IDX files, as this will allow us to add as many 3D subtitles streams as we want, and avoid to have to hardcode only one of them on the video. As far as I know, BDSup2Sub has already almost everything needed to do it.

There are 2 common methods to encode a 3D BD to MKV: side-by-side (SBS) and top/bottom (TB). In SBS mode, the left and right images are scaled horizontally by 0.5, and placed side by side (left first). In TB mode, they are scaled vertically, and the right image is placed under the left one. In the two cases, the subtitle has to be scaled and copied twice, over the corresponding images.

For example, in SBS mode, the subtitle must be scaled by 0.5 horizontally, and placed in the left and right part of the image, taking into account the 3D offset (the displacement in X, already implemented). In SBS format, the scaled subpic of the left eye must therefore be shifted to the left by ((video_X_resolution/*0.25) + offset), and for the right eye, shifted to the right by ((video_X_resolution*0.25) - offset).

In TB mode, the subpic is scaled vertically by 0.5. The left eye subpic must be placed in Y at (original_Y_position / 2) and in X at (original_X_position + offset). The right eye sub must be placed in Y at ((video_Y_resolution / 2) + (original_Y_position / 2)), and in X at (original_X_position - offset).

Do you think it is easy enough to generate the output 3D-SUB by copying the original subpic bitmap twice in the output bitmap as explained above? (The IDX file doesn't need any change, except perhaps a comment with the 3D mode and the offset value.) That would be very great, as currently, as far as I know, there is no app that can do it.

If you can do it, I suggest these CLI options:
--3d-mode mode (sbs, tb or none. Default none)
--3d-depth N (where N is the X offset, in pixels. Default 0, ignored if 3d-mode is none)

Note that, although it's not really useful, it should be possible to specify a negative 3d-depth, to place the subtitle below the surface of the screen, instead of above.

[SassBot]

It happens with any SUP file as long as you move from one subpicture to the next, and to the next... each additional subpicture increases RAM consumption by 20 MBs approx. So, after ~800 subpictures a Windows Warning Message about low RAM pops ups recommending me to close BDSup2Sub.

So this is where the memory leaks I knew existed are finally manifesting. I'll get them under wraps before pushing 1.0.0. There's lots of heap allocation going on without proper cleanup mostly just because I was copying over the code from the Java and I was just trying to get it up and running.

r0lz, I'll definitely look into that but it won't be until after 1.0.0 release.

[r0lZ]

r0lz, I'll definitely look into that but it won't be until after 1.0.0 release.
Thanks! :)
Of course, I understand that finishing v1.0 is more urgent.

[SassBot]

RC2 is now uploaded here (https://github.com/downloads/amichaelt/BDSup2SubPlusPlus/bdsup2sub++100RC2.7z). This has fixes for the major memory leaks especially when switching between subpictures that SquallMX pointed out. I was switching between sub images in a BD SUP with about 600+ subpictures and it only grew from around 22 megs of RAM after subtitle file was loaded to about 30 megs after having scrolled through about 300 images. Also when writing out the converted SUP the RAM usage only grew by about 10 megs as well. There are probably a few small memory leaks left that I'll squash but the major problems seem plugged. It also has a fix for a bug where hitting cancel on the progress bar didn't actually cancel the writing out of the subtitle file.

[MaistroX]

Hi SassBot!

Trying to use the latest RC2. (great Work btw.)
Trying to have to set "Y Offset 20 Top" to get all subtiltes to be shown above/top on the movie, Reason, movie is hardoded with German subs, but trying to add a English one, there for I need ALL subs to be placed at the top.
How do I go about to do that, cant find a option in "Move All Captions" ?

Regards MaistroX

[SassBot]

Just select "move from original Y position" and specify the offset you want so that the subs are positioned where you want.

[r0lZ]

MaistroX, maybe, after the conversion, you can also edit the org and/or align parameters in the IDX file. But note that some players ignore these values.

[MaistroX]

Sry, but I dont seem to understand! :/
I want to use "move all" in Move All Captions, but I can only get them below, not at the top and "move all" in any way I tryed so far, please help!
I dont want to move them one by one.

Just select "move from original Y position" and specify the offset you want so that the subs are positioned where you want.

Tryed exactly what u said above with RC2, "move from original Y position", original placement is below, and want them to be at the top in center all subs.
Higherst Offset Y I can set is 341, and it does not get the subs on top , them stay the same.

[SassBot]

Hmm seems to be that the code limits how far you can move vertically to 1/3 the height of the subpicture within the defined aspect ratio area. I don't know why that limit was chosen, though.

[MaistroX]

Can u expand it to hole image? :)

[SassBot]

Can u expand it to hole image? :)

I first need to see if I can figure out why that was chosen. I assume there was a good reason and make sure the change doesn't break something else deeper in the code. But it won't be until probably after the 1.0.0 release.

I still have some memory leaks to iron out, some reorganization and some optimization I want to get in first.

[mood]

Hi, SassBot...

rc2 crash when import from BDN xml/png and export to idx/sub, if the subtitle is long more than 2000 lines or near.

"Edit DVD Frame Palette" not work, any changes in this return to default.

And for me at the moment this version have the same problem that the java version has.

some lines of subtitle "randomly" appears with black background in my TV.

should be a bug on color palette in java version and continues in this version.

But i don't have programming skills to say if is a bug, I just report my problem use this tool. ;)

[SassBot]

Hi, SassBot...

rc2 crash when import from BDN xml/png and export to idx/sub, if the subtitle is long more than 2000 lines or near.
"Edit DVD Frame Palette" not work, any changes in this return to default.

The first could be an issue with some of the memory leaks that were still preset in that version. So when I post a new RC check again. I see the palette issue and am looking into it.


And for me at the moment this version have the same problem that the java version has.

some lines of subtitle "randomly" appears with black background in my TV.

should be a bug on color palette in java version and continues in this version.

But i don't have programming skills to say if is a bug, I just report my problem use this tool. ;)

Can you post the subtitle file so I can look at it?

[SassBot]

So the frame palette editing issue was because I hadn't finished implementing the functionality after you make the changes. :o Somehow I missed it.

[mood]

Ok...

I have two problems with this 2 subtitles...

This sub restarts my TV: :eek:

http://www.mediafire.com/?ca3xegs8uxtxx1w



And this "randomly" appears with black background in my TV. :(

http://www.mediafire.com/?4r3a3j6zn356j01


Is the same problem with java version.

I take 2 cell phone pictures of my TV, look it.

http://img716.imageshack.us/img716/6051/p1107121538.jpg

http://img713.imageshack.us/img713/9770/p1107121539.jpg

Take a look on pictures...

--------------------------------------------------------------------------------------


I use AVIAddXSub to make idx/sub and i never have a problem.

The only problem is the low resolution of subtitles.

[SassBot]

Ok, can you post the idx/sub you get from AVIAddXSub as well, then, so I can see what is different?

Also, here (https://github.com/downloads/amichaelt/BDSup2SubPlusPlus/bdsup2sub++rctest.7z) is a testing version that you can use to see if the BDN+XML input causes a crash again.

Thanks.

[mood]

Ok...

here is the AVIAddXSub sub, and with this I don't have any black background or problem in my TV.

http://www.mediafire.com/?f5h6w747xl10fct

[SassBot]

Did you test if you can reproduce the crash with that test version?

[mood]

Did you test if you can reproduce the crash with that test version?

I test now and not crash :)

just need the fix on the color palette because the problem wih randomly black background persists.

Thanks for your work :thanks:

[SassBot]

Ok good. Also that contains a fix for the editing the dvd palette frame, too. I finishing up some more refactoring and then I should hopefully have the final 1.0.0 release early next week. The color palette issue will come also with the outline transparency fix r0lz reported in the next iteration after the 1.0.0 release.

[mood]

Ok good. Also that contains a fix for the editing the dvd palette frame, too. I finishing up some more refactoring and then I should hopefully have the final 1.0.0 release early next week. The color palette issue will come also with the outline transparency fix r0lz reported in the next iteration after the 1.0.0 release.

Ok...

take your time not worry...

and thanks ;)

[SassBot]

You're definitely welcome. Just trying to get to a nice stable base before making further fixing and enhancements since this was done as a very quick and dirty port.

[SassBot]

So what should hopefully be the last RC is here (https://github.com/downloads/amichaelt/BDSup2SubPlusPlus/bdsup2sub++rc3.7z). Please let me know if you see any issues and if not I'll push out and tag the 1.0.0 branch and start working on the latest enhancements and fixes.

[mood]

So what should hopefully be the last RC is here (https://github.com/downloads/amichaelt/BDSup2SubPlusPlus/bdsup2sub++rc3.7z). Please let me know if you see any issues and if not I'll push out and tag the 1.0.0 branch and start working on the latest enhancements and fixes.

Thanks SassBot, but I can't download the link is broken ;)

[SassBot]

Should work now. I seem to have accidently deleted the file after uploading it. :o

[mood]

Should work now. I seem to have accidently deleted the file after uploading it. :o

Oki, no problem...

Download now and I will test it.

Thanks...

[SassBot]

Yeah, let me know if you see any regressions.

There's a few GUI bugs fixed in that too. Also in the conversion dialog I've gotten rid of the accelerators on the store/restore/reset buttons. This way alt-o will work properly for the okay button on that dialog now.

[r0lZ]

CLI bug: This command doesn't work.

BDSup2Sub++.exe --language fr -o "11 Subtitle (PGS), French.sub" "11 Subtitle (PGS), French.sup"
BDSup2Sub++ 1.0.0 RC3
OPTION: Set language to French (fr)

Converting SUB/IDX

Loading C:/Users/rol/Desktop/BD3D2AVS_projects/My_BD/00485_m2ts/11 Subtitle (PGS), French.sup
Selected language 'French (fr)' by filename
ERROR: Cancelled by user!

I have NOT cancelled the process.
Note that the same bug occurs even without the --language option. But it works if the output file is not specified: the GUI opens and loads the input file.
It seems that the CLI code is broken when -o is specified.
Here is the SUP stream (http://download.videohelp.com/r0lZ/BD3D2AVS/11%20Subtitle%20%28PGS%29%2C%20French.7z) (but IMO, the same bug happens with any stream, although I have not verified).

Also, I wonder why the message "Selected language 'French (fr)' by filename" appears, since the language code has been passed via the CLI. (Not important if you can confirm that the CLI option takes precedence.)

[SassBot]

Ok, fixed version is here (https://github.com/downloads/amichaelt/BDSup2SubPlusPlus/bdsup2sub++100rc4.7z).

Also, I wonder why the message "Selected language 'French (fr)' by filename" appears, since the language code has been passed via the CLI. (Not important if you can confirm that the CLI option takes precedence.)


There was no flag to tell it not to try to do this. Now there is and it won't do that anymore. But, yes, it has no real effect since if you do specify the language Idx manually it is set immediately prior to writing out the subtitle file. That message gets printed as it is first reading the subtitle file.

Let me know if you see any other regressions.

[SassBot]

So I presume the silence means no more regressions found?

[r0lZ]

Not tested much. In particular, I have still not tested the option to move the subpics horizontally or vertically, but I should have some time to test it tomorrow. Also, I have not tested the GUI. But IMO, you can probably release 1.0 soon, or immediately if you wish.

[mood]

I have tested only GUI and RC4 work great, the problem with black background it seems that disappeared but i need test a little more.

Also sometimes I have crash with long subtitles, some memory leaks I suppose.

You need a little more optimize memory for BDN xml/png sometimes crash or consumes all my pc memory (4GB) and I can´t do anything on pc while process subtitles, if I do RC4 crash or freeze.

Sorry for my english, I hope you understand it. ;)

[SassBot]

Also sometimes I have crash with long subtitles, some memory leaks I suppose.

Can you post the subtitles that cause a crash? There should be no more memory leaks for loading or writing out subtitles. The few leaks left have are a few hundred K at best and not related to the subtitle load or writing code.

You need a little more optimize memory for BDN xml/png sometimes crash or consumes all my pc memory (4GB) and I can´t do anything on pc while process subtitles, if I do RC4 crash or freeze.

How many PNG files? I've loaded BDN+PNG with over 1500 subpictures and it doesn't do anything remotely like that. Can you possibly post the BDN+PNG files zipped up so I can see what is happening?

[SassBot]

Okay, so I just double checked and I loaded a XML+PNG with 1200 PNG files and the RAM usage went up to 18 megs and when rewriting it back out as a BDSUP it peaked at 22megs.

Edit to add: Can you tell me some more specifics of what you did exactly when it ate up all your RAM and crashed? And the exact file you can get it to reliably reproduce with is vital. Because I loaded the XML+PNG, scrolled through about a hundred subpictures than wrote it out as BDSUP and like I said, it barely went up in RAM usage from after being loaded.

[mood]

Okay, so I just double checked and I loaded a XML+PNG with 1200 PNG files and the RAM usage went up to 18 megs and when rewriting it back out as a BDSUP it peaked at 22megs.

Edit to add: Can you tell me some more specifics of what you did exactly when it ate up all your RAM and crashed? And the exact file you can get it to reliably reproduce with is vital. Because I loaded the XML+PNG, scrolled through about a hundred subpictures than wrote it out as BDSUP and like I said, it barely went up in RAM usage from after being loaded.

Sometimes I move all subtitles sometimes not.

Here is XML+PNG, this have more than 2500 png.

http://www.mediafire.com/?jzjji88404w96ki

Sometimes work without problem, sometimes crash or freeze.

[r0lZ]

Hum tested this:

bdsup2sub++.exe --move-x origin --move-x-offset 10 -o "11 Subtitle (PGS), French_left.sub" "11 Subtitle (PGS), French.sup"

and the program crashes at the end of the conversion.

Windows error info:

Problem signature:
Problem Event Name: APPCRASH
Application Name: bdsup2sub++.exe
Application Version: 0.0.0.0
Application Timestamp: 50002c55
Fault Module Name: bdsup2sub++.exe
Fault Module Version: 0.0.0.0
Fault Module Timestamp: 50002c55
Exception Code: c0000005
Exception Offset: 006ffc4c
OS Version: 6.1.7601.2.1.0.256.1
Locale ID: 1033
Additional Information 1: 0a9e
Additional Information 2: 0a9e372d3b4ad19135b953a78882e789
Additional Information 3: 0a9e
Additional Information 4: 0a9e372d3b4ad19135b953a78882e789


If I add the --language fr argument, it doesn't crash.