xy-VSFilter Project (High Performance VSFilter Compatible Subtitle Filters)

[pinterf]

New build, download v3.1.0.801 (https://github.com/pinterf/xy-VSFilter/releases/tag/3.1.0.801)

An issue with random x64 crashes was reported on git and it looked interesting enough :)

Then I have found some "new" commits in the original rc4 branch, including the fix for italics issue, so I included them also. I hope they work, there are quite a few branches there.

Note: as original authors have said, treat this version as a beta.
Note2: I'm just a re-builder and not developer of the product. Use my build as-is.

Warning: problems under xp reported, despite my v141_xp settings.

v3.1.0.801 (20180904)
- fix random crash in x64 build (address truncated to 32 bits, Rasterizer::Draw and Rasterizer::FillSolidRect were affected)
- XySubFilter.DLL now compiled with v141_xp toolset instead of v141 (like VSFilter.DLL)
- From upstream (madshi, Cyberbeing)
- Fix a possible infinite loop in the Real Text subtitle parser on 64-bit
- Fix external SRT subtitles with italic tag not being flagged as repositionable
- Disable repositioning for SSA/ASS subtitles with default position level
- Add setting to allow repositioning of SSA/ASS dialog

[FranceBB]

- XySubFilter.DLL now compiled with v141_xp toolset instead of v141 (like VSFilter.DLL)

Still, VSFilter 3.1.0.801 doesn't work on my XP Professional (with Microsoft Extended Support) with Avisynth+ r2728.
None of your modified version work on XP, even though you compiled with v141_xp.
I have all the C++ Redistributable installed, from 2005 to 2017, by the way.

I tried with a simple script, but AVSPmod didn't recognize the command "TextSub" in the first place.
https://i.imgur.com/alsUD2A.png

When I tried to run it:
https://i.imgur.com/Yt69Clk.png

So I tried to run AVSMeter and it reported "Invalid Access Memory Location (998)".
https://i.imgur.com/1Qvr59u.png

I decided to investigate why and it seems that two kernel calls are missing in Windows XP: InitializeProcThreadAttributeList and DeleteProcThreadAttributeList.
Unfortunately, these two functions have been introduced in Windows Vista.

InitializeProcThreadAttributeList is a bool.
It returns a zero value if it fails or a non-zero value if it succeeds.
It has lpAttributeList (which is the attribute list and it can be NULL to determine the buffer size required to support the specified number of attributes), dwAttributeCount (which is the count of attributes to be added to the list), dwFlags (which is a reserved parameter and it must be zero) and lpSize.

BOOL InitializeProcThreadAttributeList(
LPPROC_THREAD_ATTRIBUTE_LIST lpAttributeList,
DWORD dwAttributeCount,
DWORD dwFlags,
PSIZE_T lpSize
);

DeleteProcThreadAttributeList is a void and thus it does not return a value. It simply has lpAttributeList which is the attribute list created by the InitializeProcThreadAttributeList function.


void DeleteProcThreadAttributeList(
LPPROC_THREAD_ATTRIBUTE_LIST lpAttributeList
);



I took a look at Wine and it seems that they implemented the call, so I tried to take their implementation and use it as a wrapper to basically direct the call to it instead of to the kernel, but unfortunately it didn't work (I messed it up when I tried to adapt it, I'm 100% sure).
Any thoughts?

https://i.imgur.com/xhmv9CL.png

[nevcairiel]

Going multiple levels down in Dependency Walker is not meaningful, since you cannot control what other DLLs use. You can only check what your own DLL imports directly, and if those are fine then thats not it. From the error it sounds like the DLL crashes on load, not that it fails to load due to missing symbols.

[pinterf]

Don't know, what happens, all I have found is:
https://developercommunity.visualstudio.com/content/problem/257074/windows-xp-compilation-cause-error-998-on-target-s.html
And the DLLs were compiled with /MT instead of /MD, so no redistributables are needed.

[jpsdr]

Stupid question, you didn't forget the /Zc:threadSafeInit- option ?

[tonyxc600]

Trying to open external PGS subtitles (whether autoloading or manual) results in my player freezing for extended periods of time, and when it does finally load the text is either greatly out of sync or don't display at all.

Muxing the subs into the video allows it to load correctly. The issue is also consistently reproducible when I extract subs from any video and try to load them externally.

Is this a known issue with external PGS subs?

[pinterf]

Stupid question, you didn't forget the /Zc:threadSafeInit- option ?
No, it's there.

[Siso]

Do the subtitle output options in XYVsfilter - YCbCr level range "auto" and YCbCr matrix should always be on "auto"? In the OSD when they are on auto it says Colorspace: TV BT.601(auto), if I set the matrix to "guess" it says TV BT.709 (Guessed). I watch only BT.709 content. Which option is the right one?

[huhn]

leave it at the default settings because this topic is very simple and very complicated at the same time.

the issue comes from the software creating the ASS sub titles usual aegisub which doesn'T really care about color matrix in the past and was using BT 601.

the content you watch is not of important it is the ass sub colors relative to the video.
it get's really complicated on how they fixed this issue.

[Siso]

leave it at the default settings because this topic is very simple and very complicated at the same time.

the issue comes from the software creating the ASS sub titles usual aegisub which doesn'T really care about color matrix in the past and was using BT 601.

the content you watch is not of important it is the ass sub colors relative to the video.
it get's really complicated on how they fixed this issue.

My subtitles are in srt, but I guess the defaults will work, right huhn?

[huhn]

is there anything that matter in term of colors for SRT subs?

[Siso]

is there anything that matter in term of colors for SRT subs?

I don't know, I guess nothing.

[huhn]

it should be nothing so just keep the default settings and you should be fine.

[Siso]

it should be nothing so just keep the default settings and you should be fine.

Will do. :thanks:

[crmb]

Hello.

I am using this filter/renderer with MPC-HC/madVR because it give me the the ability to move BD subtitles into the movie area (Zoom control > cropping black bars in madVR) without squeezing the subtitles. (They are verticaly squeezed with MPC built-in filter.)

Is it actualy possible to do the same with MPC-HC built-in filter (without squeeze) ? Am i missing some option ?

If this filter is better than the one in MPC-HC, was it supposed to replace it at some point ?

[cyberbeing]

XySubFilter 3.1.0.751 has been released (https://github.com/Cyberbeing/xy-VSFilter/releases/tag/3.1.0.751)

XySubFilter .zip Archive (32-bit) (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.751/XySubFilter_3.1.0.751_x86.zip) | XySubFilter .zip Archive (64-bit) (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.751/XySubFilter_3.1.0.751_x64.zip)

Debug Symbols for XySubFilter 3.1.0.751 (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.751/XySubFilter_3.1.0.751_Debug_Symbols.7z)

Features & Changes

Add setting to allow repositioning of SSA/ASS dialog
Add BT.2020 Support


Bug Fix

Fix external SRT subtitles with italic tag not being flagged as repositionable
Fix potential crash on startup during external subtitle parsing


Note: XySubFilter is no longer being actively developed. The original developer stopped working on the project back in 2014, and ever since then it's been in limbo. The changes in this release were made possible by madshi the developer for madVR.

[madshi]

Thank you cyberbeing for working with me to get this release out - appreciated! :)

[sat4all]

Thank you both, it's working fine here with kodi dsplayer.

[Manni]

Thank you both, seems to be working fine with MPC-BE

[sneaker_ger]

Features & Changes

Add BT.2020 Support

What does this entail?

I remember the discussion on the libass tracker (https://github.com/libass/libass/issues/297) and it seemed like devs were at a loss on how to handle the issue of HDR.

[cyberbeing]

What does this entail?

I remember the discussion on the libass tracker (https://github.com/libass/libass/issues/297) and it seemed like devs were at a loss on how to handle the issue of HDR.

To be safe, I'd recommend thinking of the current support as BT.2020 SDR only. This release basically only adds support for the 'TV.2020' & 'PC.2020' 'YCbCr Matrix' tags. This was just something which was long overdue to be added to XySubFilter. Originally it was defined in v1.0.5 of SubRenderIntf.h released back in 2013(!), but nobody ever got around to adding support to XySubFilter. With this release, BT.601, BT.709, and BT.2020 are now supported.

Similar to the situation back when BT.709 support was added to xy-VSFilter, if you're authoring an ass script using the BT.2020 matrix, please tag 'YCbCr Matrix' of 'TV.2020' or 'PC.2020' appropriately so it will be handled correctly in the future. If you notice any bugs with BT.2020 authored scripts, please report them.

[Telion]

Cyberbeing and madshi, thanks for your efforts in keeping this project undead! :cool:

I also want to ask whether it would be possible to slightly improve the repositioning of ASS dialogs feature so that it'd evaluate the movableness of each ASS line individually? Currently it stops to reposition dialogs after the first encounter of any complex ASS tag, I guess. But that's not very convenient and consistent - usually simple dialog lines continue to occur after or even along with some complex scripting, so they should be repositioned as well. If each line was evaluated individually, it'd be very easy to always move what should be moved and to not move what shouldn't, regardless of the script's complexity as a whole. And it'd be even better if simple ASS tags like bold, italics, etc. won't trigger the unmovableness of a line. Can you please consider implementing this when you have a bit of spare time and a tad of inspiration?

[madshi]

Currently madVR doesn't handle separate ASS parts separately. I might implement support for that at one point in the future, but it's not very high priority right now. XySubFilter probably already reports movability separately for each subtitle part, so it's probably something that needs to be changed in madVR. However, do simple tags like bold, italics etc make ASS subtitles non-movable atm? I don't think they should!

[cyberbeing]

As madshi mentioned, currently madVR doesn't support moving multiple subtitle lines independently of each other. If one line gets flagged as unmovable on-screen, madVR won't move any lines until the unmovable line ends, and a new movable line starts. I noticed this behavior as well before releasing this update, but we figured it'd be better to release now for the SRT fix and have madshi fix the ASS quirk with mixed movable/unmovable lines at a later date.

XySubFilter is currently set rather conservatively, with both Soft & Hard Positioned tags flagged as unmovable to ensure typesetting doesn't break.

Movable tags:

1c
2c
3c
4c
1a
2a
3a
4a
alpha
an
a
blur
bord
be
b
c
fade
fe
fn
i
q
r
shad
s
t
u
xbord
xshad
ybord
yshad


Unmovable Tags [Soft]:

fax
fay
frx
fry
frz
fr
fscx
fscy
fsc
fsp
fs
kt
kf
K
ko
k


Unmovable Tags [Hard]:

clip
iclip
move
org
pbo
pos
p

[Telion]

However, do simple tags like bold, italics etc make ASS subtitles non-movable atm? I don't think they should!
I checked it and no, in b751 they don't (unlike the b746) - thanks again, that's a very nice improvement.
If one line gets flagged as unmovable on-screen, madVR won't move any lines until the unmovable line ends, and a new movable line starts.
That's not always the case. For example, when there appears a top dialog line positioned with {\an8} along with a regular bottom dialog, the latter moves back but indeed gets repositioned again when the former one ends. But when there are any signs positioned with {\pos}, the bottom dialog lines never get repositioned again even when all sign lines end and there is nothing on the screen except a regular dialog without any markup. I'm mostly concerned about this issue because currently I need to switch subtitle tracks back and forth after each sign as a workaround to restore the repositioning. Is this madVR's fault or XySubFilter's one related to the hard unmovable tags mentioned in your list (and what's the difference between soft and hard, btw)? Can something be done about this issue now, without the burden to implement an independent handling of ASS lines? I hope it should be quite simple to fix and it'd be a great improvement which would really make such support a low-priority cosmetic improvement.

[madshi]

If the behaviour is different depending on ASS tag then I don't know how to fix it. Probably something in XySubFilter then.

[ikarad]

XySubFilter 3.1.0.751 has been released (https://github.com/Cyberbeing/xy-VSFilter/releases/tag/3.1.0.751)

XySubFilter .zip Archive (32-bit) (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.751/XySubFilter_3.1.0.751_x86.zip) | XySubFilter .zip Archive (64-bit) (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.751/XySubFilter_3.1.0.751_x64.zip)

Debug Symbols for XySubFilter 3.1.0.751 (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.751/XySubFilter_3.1.0.751_Debug_Symbols.7z)

Features & Changes

Add setting to allow repositioning of SSA/ASS dialog
Add BT.2020 Support


Bug Fix

Fix external SRT subtitles with italic tag not being flagged as repositionable
Fix potential crash on startup during external subtitle parsing


Note: XySubFilter is no longer being actively developed. The original developer stopped working on the project back in 2014, and ever since then it's been in limbo. The changes in this release were made possible by madshi the developer for madVR.
Thanks but a bug is always present with this version.

subtitles in some dvds are not displayed with xysubfilter. With internal subrender of mpc-hc subs are displayed.
I have mpc-64 last clsid version + madvr + xysubfilter 64bits 3.1.0.751 (problem arrive with 3.1.0.746) and windows 7 64

I have tested with french dvd like love hina and kurumi.

edit: I just try with 32 bits version of xysubfilter 3.1.0.751 + mpc-hc 32 bits and it works. Bug come from 64 bits version.


https://preview.ibb.co/kPWh6z/Sans_titre.jpg (https://ibb.co/npOJeK)

[madshi]

So it's not a new bug in 3.1.0.751, but the same problem already existed in build 746?

Can you upload a small sample with which the problem can be reproduced?

[ikarad]

So it's not a new bug in 3.1.0.751, but the same problem already existed in build 746?

Can you upload a small sample with which the problem can be reproduced?
The same problem existed in build 746.

I can't upload a small sample because the problem arrives only when I open dvd with "open BR/dvd" option in mpc-hc. I must uplaod at least some files and a entire episode for that open dvd/BR function in mpc hc works. I can upload a 1gb file if you want.

If I open vob file, subs are displayed but color of subs are strange
https://preview.ibb.co/eaD76z/Sans_titre.jpg (https://ibb.co/hSh0Rz)

[cyberbeing]

I checked it and no, in b751 they don't (unlike the b746) - thanks again, that's a very nice improvement.

That's not always the case. For example, when there appears a top dialog line positioned with {\an8} along with a regular bottom dialog, the latter moves back but indeed gets repositioned again when the former one ends. But when there are any signs positioned with {\pos}, the bottom dialog lines never get repositioned again even when all sign lines end and there is nothing on the screen except a regular dialog without any markup. I'm mostly concerned about this issue because currently I need to switch subtitle tracks back and forth after each sign as a workaround to restore the repositioning. Is this madVR's fault or XySubFilter's one related to the hard unmovable tags mentioned in your list (and what's the difference between soft and hard, btw)? Can something be done about this issue now, without the burden to implement an independent handling of ASS lines? I hope it should be quite simple to fix and it'd be a great improvement which would really make such support a low-priority cosmetic improvement.

You seem to be correct. As soon as typesetting line appears, all dialog lines after that point are not moved by madVR.

After adding some logging, that particular problem does seem to be an XySubFilter bug. See if the following build fixes it for you:

https://www65.zippyshare.com/v/3kMnxuRc/file.html

If the behaviour is different depending on ASS tag then I don't know how to fix it. Probably something in XySubFilter then.

I'll send you the changes later, so you can look it over.


The same problem existed in build 746.

I can't upload a small sample because the problem arrives only when I open dvd with "open BR/dvd" option in mpc-hc. I must uplaod at least some files and a entire episode for that open dvd/BR function in mpc hc works. I can upload a 1gb file if you want.

If I open vob file, subs are displayed but color of subs are strange

Could you also test XySubFilter 3.1.0.705 BETA2 (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.705/XySubFilter_3.1.0.705_x64_BETA2.zip) & XySubFilter 3.1.0.744 BETA3 (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.744/XySubFilter_3.1.0.744_x64_BETA3.zip) to see if either of them work.

If it works in 3.1.0.705 but not in 3.1.0.744, then it's probably related to when Animated VobSub Support was merged in.

A small sample of the vob would still be useful, since the problem is likely related to those same subs going missing with "open BR/dvd".

[Telion]

After adding some logging, that particular problem does seem to be an XySubFilter bug. See if the following build fixes it for you:
Thanks a lot for your efforts! I really hope this bug is busted at last, but can you please upload an x86 build since I'm still using 32-bit OS.

[ikarad]

Could you also test XySubFilter 3.1.0.705 BETA2 (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.705/XySubFilter_3.1.0.705_x64_BETA2.zip) & XySubFilter 3.1.0.744 BETA3 (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.744/XySubFilter_3.1.0.744_x64_BETA3.zip) to see if either of them work.

If it works in 3.1.0.705 but not in 3.1.0.744, then it's probably related to when Animated VobSub Support was merged in.

A small sample of the vob would still be useful, since the problem is likely related to those same subs going missing with "open BR/dvd".
I have tried the two versions and it doesn't work.

I don't know how cut vob file.

edit: I have just tried any option. If I use enhanced video renderer in mpc-hc 64 with xysubfilter 3.1.0.751, subs are displayed. If I use madvr instead of enhanced video renderer with xysubfilter 3.1.0.751, subs are not displayed. I have tried madvr 0.91.4 and the last version 0.92.17. The problem seems to occur with a strange interaction between madvr, mpc-hc64 and xysubfilter 64bits

edit 2: with madvr 0.89.2 subs are displayed.

evr
https://preview.ibb.co/m0HnpK/evr.jpg (https://ibb.co/bMZYUK)

madvr0.89.2
https://preview.ibb.co/g2pNOe/madvr0_89_2.jpg (https://ibb.co/kPA7pK)

madvr 0.92.17 or 0.91.4
https://preview.ibb.co/cfiz3e/madvr0_92_17.jpg (https://ibb.co/g24iUK)

[madshi]

@ikarad, could it have to do with LAV Decoder filter and XySubFilter fighting over the subtitle connection to madVR? It's a known problem that madVR currently only accepts one subtitle connection. And if LAV has that connection, XySubFilter can lose out. Try using a different decoder, just to verify.

[austonrush]

[QUOTE=ikarad;1853344]I have tried the two versions and it doesn't work.

I don't know how cut vob file.

edit: I have just tried any option. If I use enhanced video renderer in mpc-hc 64 with xysubfilter 3.1.0.751, subs are displayed. If I use madvr instead of enhanced video renderer with xysubfilter 3.1.0.751, subs are not displayed. I have tried madvr 0.91.4 and the last version 0.92.17. The problem seems to occur with a strange interaction between madvr, mpc-hc64 and xysubfilter 64bits

edit 2: with madvr 0.89.2 subs are displayed.

I had the same issue, try disabling (not removing), lav splitter and lav splitter source under external filters in mpc-hc, subtitles are now displaying for me. forced subtitles are not loading automatically though :(.

[cyberbeing]

Try installing the latest LAVFilters-0.72.0-15.exe Nightly from https://files.1f0.de/lavf/nightly/ . It looks like nev actually changed the handling of DVD subtitles on that build compared LAVFilters-0.72.0-13.exe, maybe it is related? The commit message mentions "Disable the CC output pin for DVD playback".

If that doesn't work, ensure that you've run XySubFilter regsvr32 (as admin) and it actually succeeded, and also test MPC-BE to rule out it's not just a MPC-HC quirk. The last thing you could try is setting XySubFilter to "Always Load" under Properties->Main.


Personally I've been using MPC-HC 1.7.16, madVR 90.24, LAVFilters-0.72.0-15 on Win7 and and don't remember seeing anything like that.

Though thinking back, I don't think XySubFilter has ever supported rendering subtitles directly from a DVD disc(?). Isn't that usually handled by DVD Navigator and a DVD/MPEG2 decoder? Is the situation differ on OS newer than Win7? LAV Splitter never loads for DVD playback on my end, and XySubFilter never connects to the DVD subtitle pin, the subtitle pin is always taken and rendered by the video decoder.

If there is some kind of weird timing conflict going on, media players should probably consider blocking XySubFilter when a DVD disc is played. Yet it is curious if it doesn't occur with older madVR builds though, so maybe it's something madshi could fix on his end?

[nevcairiel]

If there is some kind of weird timing conflict going on, media players should probably consider blocking XySubFilter when a DVD disc is played. Yet it is curious if it doesn't occur with older madVR builds though, so maybe it's something madshi could fix on his end?

Don't think its much of a timing conflict.

With DVD playback, LAV Video uses the ISubRenderConsumer interface to render DVD menus and DVD subtitles. It'll connect that pretty late, when the DShow graphs enters "Pause" mode, so long after graph building. In what order would madVR act? If the consumer slot is already taken, does it let me kick out whats in there, or does it just block the slot for the first one to get in there?

The reason it doesn't happen with older madVR versions is that LAV Video checks the madVR version, and doesn't act unless its at least 0.89.10, because the interface was a bit crashy before that version.
It falls back to the inefficient manual blending onto the decoded picture.

But actual DVD disc playback is a bit complicated anyway. External subs would probably be hard to sync to the appropriate timing, so do people really do that?

[ikarad]

@ikarad, could it have to do with LAV Decoder filter and XySubFilter fighting over the subtitle connection to madVR? It's a known problem that madVR currently only accepts one subtitle connection. And if LAV has that connection, XySubFilter can lose out. Try using a different decoder, just to verify.

Thanks.
I have tried to turn off lav filter in mpc-hc. Now, Mpc use microsoft dtv-dvd video and audio decoder. Subs are not displayed.

With madvr and mpc-hc32 bits and xysubfilter 32 bits, subs are displayed. Only 64 bits version have a problem.

[madshi]

Do XySubFilter subs work *at all* in 64bit for you? Is the problem just with DVD, or with other videos, as well?

[ikarad]

Try installing the latest LAVFilters-0.72.0-15.exe Nightly from https://files.1f0.de/lavf/nightly/ . It looks like nev actually changed the handling of DVD subtitles on that build compared LAVFilters-0.72.0-13.exe, maybe it is related? The commit message mentions "Disable the CC output pin for DVD playback".

If that doesn't work, ensure that you've run XySubFilter regsvr32 (as admin) and it actually succeeded, and also test MPC-BE to rule out it's not just a MPC-HC quirk. The last thing you could try is setting XySubFilter to "Always Load" under Properties->Main.


Personally I've been using MPC-HC 1.7.16, madVR 90.24, LAVFilters-0.72.0-15 on Win7 and and don't remember seeing anything like that.

Though thinking back, I don't think XySubFilter has ever supported rendering subtitles directly from a DVD disc(?). Isn't that usually handled by DVD Navigator and a DVD/MPEG2 decoder? Is the situation differ on OS newer than Win7? LAV Splitter never loads for DVD playback on my end, and XySubFilter never connects to the DVD subtitle pin, the subtitle pin is always taken and rendered by the video decoder.

If there is some kind of weird timing conflict going on, media players should probably consider blocking XySubFilter when a DVD disc is played. Yet it is curious if it doesn't occur with older madVR builds though, so maybe it's something madshi could fix on his end?
I have tested mpc-be and LAVFilters-0.72.0-15.exe Nightly . There is the same problem.

[ikarad]

Do XySubFilter subs work *at all* in 64bit for you? Is the problem just with DVD, or with other videos, as well?
Problem only with dvd. With bluray or other mkv video, subs are displayed. If I use "open dvd/BD" function in mpc-hc with blu-ray subs are dislayed.

The problem arrive only with dvd when I use "open dvd/BD" function in mpc-hc with mad vr, mpc-hc 64bits and xysubfilter 64 bits. With 32 bits versions of mpc-hc and xysubfilter, subs are displayed

[ikarad]

Do XySubFilter subs work *at all* in 64bit for you? Is the problem just with DVD, or with other videos, as well?
I have tried many madvr version.
Until 0.89.09, subs are displayed
Since 0.89.11 subs are not displayed.

I can't test 0.89.10 because when I download 0.89.10.zip on videohelp https://www.videohelp.com/software/madVR/old-versions#download , it download 0.89.11.

[clsid]

madshi, this should fix the missing sub problem:
https://github.com/mpc-hc/mpc-hc/commit/42b596dee8980f0a95c8a4b2803478c9895adfe0

[cyberbeing]

clsid, I don't think that is related. XySubFilter doesn't have a BitBltFromRGBToRGBStretch function and we don't use VDPixmapStretchBltBilinear anywhere, that scaling code is MPC-HC specific.

[madshi]

@ikarad,

can you make a debug log with the missing subtitles? Please try to keep it as short as possible, which means: Start playback, when the subtitle should occur, and it doesn't, immediately stop the media player. If possible, no funny things like reloading the DVD multiple times, switching resolutions or zooming etc. Ideally, could you also add a debug log with the 32bit build, so I can compare both?

@clsid,

that change seems to be related to subtitle scaling quality (replacing bilinear with bicubic). How would that change help fixing missing subtitles?

[clsid]

MPC-HC used to have a bug too where certain subs weren't displayed in x64 builds. That change fixed it.

[madshi]

Not sure why it helped, but madVR doesn't use VDPixmapResample or VDPixmapStretchBltBilinear, so it's not a change I can do in madVR.

[cyberbeing]

Do you have a sample, and are you sure that wasn't only a VSFilter.dll issue? XySubFilter handles such thing differently than MPC-HC, so I don't think it would be affected by the same issue. Bitmaps subtitles such as VOBSUB are sent to madVR at original size, and madVR is responsible for scaling them as needed.

What ikarad & austonrush are reporting is a madVR/LavFilters specific issue related to DVD playback only, since they stated XySubFilter+EVR, XySubFilter+OldMadVR, and XySubFilter+CurrentMadVR+blockingLavSplitter were all working. It sounds like either a filter conflict, or a case of XySubFilter connecting to the madVR consumer before LAV Video (or the reverse, depending on which is actually rendering the DVD subs).

[cyberbeing]

Thanks a lot for your efforts! I really hope this bug is busted at last, but can you please upload an x86 build since I'm still using 32-bit OS.

https://www2.zippyshare.com/v/ZnTMPx2Q/file.html

[clsid]

Must be a different bug then. The fact that it happens with bitmaps and x64 only triggered my memory of that old MPC bug.

[ikarad]

@ikarad,

can you make a debug log with the missing subtitles? Please try to keep it as short as possible, which means: Start playback, when the subtitle should occur, and it doesn't, immediately stop the media player. If possible, no funny things like reloading the DVD multiple times, switching resolutions or zooming etc. Ideally, could you also add a debug log with the 32bit build, so I can compare both?


How make a debug log?