Log in

View Full Version : xy-VSFilter Project (High Performance VSFilter Compatible Subtitle Filters)


Pages : 1 2 3 4 5 6 7 8 9 10 [11] 12 13 14 15 16 17 18 19 20 21 22 23

madshi
30th April 2014, 08:21
Thanks, it's good to see minor stability updates... :)

kasper93
30th April 2014, 09:05
Why you don't want to enable SSE (1)?

Tapatalk 4 @ GT-I9300

Sarasa
30th April 2014, 10:00
XySubFilter 3.1.0.697 Beta2 has been released (https://github.com/Cyberbeing/xy-VSFilter/releases/tag/3.1.0.697)

XySubFilter Beta2 .7z Archive (32-bit) (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.697/XySubFilter_3.1.0.697_x86_BETA2.7z) | XySubFilter Beta2 .7z Archive (64-bit) (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.697/XySubFilter_3.1.0.697_x64_BETA2.7z)

...

Copy/paste gone bad ? ;)
your links have an 7z extension but the github one are zip

andyvt
30th April 2014, 11:30
XySubFilter 3.1.0.697 Beta2 has been released (https://github.com/Cyberbeing/xy-VSFilter/releases/tag/3.1.0.697)

XySubFilter Beta2 .7z Archive (32-bit) (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.697/XySubFilter_3.1.0.697_x86_BETA2.7z) | XySubFilter Beta2 .7z Archive (64-bit) (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.697/XySubFilter_3.1.0.697_x64_BETA2.7z)

Debug Symbols for XySubFilter 3.1.0.697 (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.697/XySubFilter_3.1.0.697_Debug_Symbols.7z)

Features & Changes

Update Cache defaults (LV1 256->2048, LV4 512->768)
Disable /arch:SSE2 in VS2012/VS2013 builds


Bug Fix

Unable to load subtitle files with uppercase file extension
Correct a parser check which broke loading of script embedded UUE fonts
Revert Insane Border Support (temporary crash fix)


This release is a minor update of XySubFilter 3.1.0.682 Beta2 (http://forum.doom9.org/showpost.php?p=1672047&postcount=324).

Does this include the patch to query the EVR presenter for ISubRenderConsumer?

clsid
30th April 2014, 17:56
Pull request looks good. NoExtensions is fine too is you prefer that.

Can you also commit your interlacing fix? Here is another patch for that by kasper93:
https://github.com/kasper93/mpc-hc/commit/d8ff6fac333b9602b6cc9865d4998f36cf479f2b

It would also be trivial to apply all the mpc-hc backports and fixes of Jeeb's clone to the vsfilter_rc branch.

cyberbeing
30th April 2014, 20:04
I've silently replaced the 3.1.0.697 VS2013 build links with VS2010 builds. I'd encourage everyone who downloaded prior to this post to re-download.

There seems to be a VS2012/VS2013 compiler related performance regression found, which hurts performance greatly on scripts which make heavy use of \clip.

For whatever reason, the code VS2010 generates is around 2x faster on such scripts.

Why you don't want to enable SSE (1)?
Since it doesn't result in a measurable improvement of performance for our filters. Visual Studio also seem to have a tendency to convert fast C code into slow SSE code in some cases.

I see no reason to break compatibility, unless doing so offered some benefit to our users.

Copy/paste gone bad ? ;)
your links have an 7z extension but the github one are zip
Yep, copy/paste gone bad. First post was correct, but I copied from that older Beta2 thread post which never got updated for that 7z to zip link change. Fixed now.

Does this include the patch to query the EVR presenter for ISubRenderConsumer?
No, not yet. I'm still waiting for our developer to look over and approve those changes. He seems to be busy, as I haven't been able to get in contact with him at all during the past month.

Can you also commit your interlacing fix?
Once I figure out what we are doing for our next xy-VSFilter release, that change will be committed.

I had my own version and a test build posted here (https://code.google.com/p/xy-vsfilter/issues/detail?id=179#c7) around a month ago. I've not had a chance to test kasper93's variation yet, and it seems it still hasn't been merged into MPC-HC master.

At this point, I was just awaiting JEEB to make a final decision about how this change should be implemented, and merge it into his CCCP branch.

kasper93
30th April 2014, 20:45
Since it doesn't result in a measurable improvement of performance for our filters. Visual Studio also seem to have a tendency to convert fast C code into slow SSE code in some cases.
Fair enough. It indeed depends on your code and what do you need.

I had my own version and a test build posted here (https://code.google.com/p/xy-vsfilter/issues/detail?id=179#c7) around a month ago. I've not had a chance to test kasper93's variation yet, and it seems it still hasn't been merged into MPC-HC master.

It will be merged soon, after next stable in fact which will be hotfix for PGS crash. We plan to release tomorrow or so. That's why this changes wait that long.

Aranzabal
3rd May 2014, 17:40
http://thumbnails112.imagebam.com/32441/ffdfe6324401301.jpg (http://www.imagebam.com/image/ffdfe6324401301)

When I dont use xysubfilter, I can see subtitles in the black bar, so is it about xysubfilter or madvr?

xysubfilter options don't have this "position subtitles relative to the video frame" option.

cyberbeing
3rd May 2014, 19:50
When I dont use xysubfilter, I can see subtitles in the black bar, so is it about xysubfilter or madvr?
It's about madVR. Supporting this is something madshi has stated is high priority on his to-do list. I'd hope that MPC-HC will eventually support this for their their EVR-CP/VMR9 subtitle consumer as well, but I haven't heard anything. XySubFilter itself added support for black bar rendering and subtitle repositioning (untested) almost 1 year ago now, so all we can do is wait patiently.

xysubfilter options don't have this "position subtitles relative to the video frame" option.
SubRenderIntf.h (http://madshi.net/SubRenderIntf.h) was implemented in such a way that the Subtitle Consumer is required to initiate the request for subtitle repositioning. Since there is no way for Subtitle Providers to force such a behavior, having an 'enable' option in XySubFilter would only be confusing to the user. Depending on how Subtitle Consumers choose to support this, its more likely that XySubFilter would gain an option like "never position subtitles outside the video frame" to disable automated black bar rendering.

clsid
12th May 2014, 16:33
@cyberbeing
In the build script of vsfilter_rc branch you should replace "3.0.0.4" with "3.0.0.211" (and +4 with +211 in the line below).

cyberbeing
12th May 2014, 22:52
@cyberbeing
In the build script of vsfilter_rc branch you should replace "3.0.0.4" with "3.0.0.211" (and +4 with +211 in the line below).

Any particular reason?

clsid
13th May 2014, 16:12
Otherwise it will result in an incorrect version calculation due to the non-existent tag 3.0.0.4 in that branch.

cyberbeing
13th May 2014, 23:08
The 3.0.0.4 tag should now exist once again. I accidentally removed it last week when I was pruning non-release tags, since I had forgotten it was used for this purpose.

mahoushounen
28th May 2014, 22:23
For some reason subtitle drag-n-drop doesn't work with latest XySubFilter. Am I doing something wrong or is this the filter's shortcoming?

cyberbeing
28th May 2014, 23:47
Only MPC-BE supports drag-n-drop functionality with XySubFilter currently.
[note: there seems to be a regression in the r4913 MPC-BE nightly, so grab the previous r4901 nightly or 1.4.2 stable]

For MPC-HC we have a ticket open here (https://trac.mpc-hc.org/ticket/4122) requesting they backport the behavior.

mahoushounen
29th May 2014, 17:15
Only MPC-BE supports drag-n-drop functionality with XySubFilter currently.
[note: there seems to be a regression in the r4913 MPC-BE nightly, so grab the previous r4901 nightly or 1.4.2 stable]


Will try it out, thanks.

cyberbeing
29th May 2014, 19:09
Just note that if your video does not have any auto-loaded embedded/external subtitles, you would need to configure XySubFilter settings to "Always Load" so it will be present in the graph before you drag-n-drop.

Skymil
30th May 2014, 22:38
Hello,

I'm not sure if it's the right place to ask this, please forgive me if it's not the case.

Before I was able to display two subtitles at the same time by using XySubFilter + the internal subtitles renderer of MPC-HC.
But now, it doesn't work anymore.
I've tried to change a lot of options from the LAV Splitter to MPC-HC.
If XySubFilter is loaded, the internal subtitles renderer displays nothing.
But if XySubFilter is not loaded, it's possible to use the internal renderer.
I have :
MPC-HC 1.7.5
madVR 0.87.10
XySubFilter 3.1.0.697
LAV Audio Decoder + Video Decoder + Splitter 0.61.2

Do you have any idea where this issue comes from?

cyberbeing
30th May 2014, 23:43
See: MPC-HC Ticket #4231 (https://trac.mpc-hc.org/ticket/4231) for details and the new solution.

Skymil
1st June 2014, 00:09
It works great now thank you (and sorry I checked the tickets but didn't found this one)!

GCRaistlin
2nd June 2014, 21:38
How do I make XySubFilter visible in system tray? I have added it to MPC-HC's External filters list, choose "Prefer" (as I did for VSFilter before) but XySubFilter icon doesn't appear in system tray when I open a video file.

vivan
2nd June 2014, 21:48
How do I make XySubFilter visible in system tray?Disable option "Hide Tray Icon" in the XySubFilter settings...

GCRaistlin
2nd June 2014, 21:51
Disable option "Hide Tray Icon" in the XySubFilter settings...

It isn't enabled.

Telion
2nd June 2014, 22:01
XySubFilter must be fully registered in the system to show its tray icon.

GCRaistlin
2nd June 2014, 23:55
XySubFilter must be fully registered in the system to show its tray icon.

This was a temporary ffdshow raw video filter problem. It prevented "lower" filters from loading for some unknown reason. Now all is OK.

GCRaistlin
3rd June 2014, 00:03
Hm. If XySubFilter is set to "Load when needed", the issue is here: not only XuSubFilter doesn't load but video isn't showed at all (the MPC-HC window looks like an audio file is played). If XySubFilter is set to "Always load", all works fine.

cyberbeing
3rd June 2014, 01:42
@GCRaistlin, from what you've said so far, I can't really say what is causing your issue.


First try uninstalling FFDShow entirely. Does the problem occur?



If not, install the latest ffdshow build (http://sourceforge.net/projects/ffdshow-tryout/files/SVN%20builds%20by%20clsid/generic%20builds/ffdshow_rev4530_20140209_clsid.exe/download) if you needed it, and disable all the checkboxes in the FFDSHow subtitle section for good measure.



Update MPC-HC to the latest nightly build (http://nightly.mpc-hc.org/). Reset to defaults. "'Miscellaneous" -> "Setting Management" -> "Reset". Ensure that "Playback" -> "Use built-in subtitle renderer" is disabled. Do not add any 'External Filters'.



Uninstall XySubFilter. Restore Defaults with the reg file found here (https://code.google.com/p/xy-vsfilter/issues/detail?id=26#c3).



Test to ensure you have no problems without XySubFilter installed.



Install XySubFilter r697 (https://github.com/Cyberbeing/xy-VSFilter/releases/download/3.1.0.697/XySubFilter_3.1.0.697_x86_BETA2.zip) with the bat file. (DLLRegisterServer in XySubFilter.dll succeeded)



If the problem still occurs, you'll need to provide some more details about the filters being used and how this can be reproduced.

GCRaistlin
4th June 2014, 08:30
cyberbeing, it seemed to be a local issue. First the video wasn't showed by XySubFilter's "Load when needed", then VSFilter was loading even not being present in External Filters list. Fixed by reboot.

Where do I read about features on More tab? I interest in settings that allows to show subtitles on the lower black bar while watching 2,35:1 movie on 16:9 monitor.

Update MPC-HC to the latest nightly build. Reset to defaults. "'Miscellaneous" -> "Setting Management" -> "Reset". Ensure that "Playback" -> "Use built-in subtitle renderer" is disabled.
We aren't really able to disable "Use built-in subtitle renderer" after resetting settings until we change video renderer from default VMR7 windowed to something else (like VMR9 renderless).

cyberbeing
4th June 2014, 18:08
Where do I read about features on More tab? I interest in settings that allows to show subtitles on the lower black bar while watching 2,35:1 movie on 16:9 monitor.

We seem to get asked about this frequently. XySubFilter already supports this, but the subtitle consumers (VMR9, EVR-CP, madVR) currently do not. It's on madshi's to-do list to add support for this in madVR. For VMR9/EVR-CP, someone would need to open a feature request with MPC-HC.


We aren't really able to disable "Use built-in subtitle renderer" after resetting settings until we change video renderer from default VMR7 windowed to something else (like VMR9 renderless).

If the default renderer is VMR7 windowed, then you must be running Windows XP? Then yes, you would need to change to a compatible renderer like VMR9, EVR-CP, or madVR for XySubFilter to be used. Disabling the "Use built-in subtitle renderer" checkbox should always be possible though, since it is a global setting.

GCRaistlin
4th June 2014, 19:50
Disabling the "Use built-in subtitle renderer" checkbox should always be possible though, since it is a global setting.

http://i59.tinypic.com/35li5jo.jpg

GCRaistlin
4th June 2014, 19:55
XySubFilter already supports this, but the subtitle consumers (VMR9, EVR-CP, madVR) currently do not.

OK, but nevertheless what about the guide for "More" tab? Is there any settings there that should be changed to get the maximum quality for 1920:1080 resolution?

cyberbeing
4th June 2014, 22:11
http://i59.tinypic.com/35li5jo.jpg
Hmm, well I guess I'll need to keep that in mind when giving step by steps for XP users. Though when that checkbox is grayed out, XySubFilter cannot be used either.

OK, but nevertheless what about the guide for "More" tab? Is there any settings there that should be changed to get the maximum quality for 1920:1080 resolution?

The defaults are already set for maximum quality.

Cache settings generally should not be touched. Setting them higher or lower can hurt performance and stability.

Subpixel Positioning option of "8x8 vsfilter 2.39 default" is the highest quality setting. "8x8 bilinear" has similar accuracy and may be slightly faster, but can introduce uneven blurring with multiple lines. Lower settings like 4x4, 2x2, None, will make animations severely stutter.

Render Layout Options:
Use Original Video Size = Scale to output resolution with appearance matching VSFilter.dll.

Use AR Adjusted Video Size = Scale to output resolution with appearance matching VSFilter.dll, but do not strech SSA/ASS subtitles on anamorphic video. (Use this setting if your anamorphic video subtitles were not compensated for VSFilter.dll behavior)

Customize... H: XXXX V: XXXX = Debugging only, not for general use.

Render to Original Video Size = Do not scale. Matches VSFilter.dll behavior of always rendering to video size. Render Layout drop-down box ignored if this option is enabled.

YCbCr Matrix
Auto, Auto = Use Script Value if present
Anything else = Debugging only, not for general use

RGB Level
Auto = Honor the "supportedLevels" value reported by the subtitle consumer
Anything else = Debugging only, not for general use

MasterMeNL
5th June 2014, 16:12
Could someone give me the default values for the cache options?

Soukyuu
5th June 2014, 19:17
LV4 768
LV3 512
LV2 256
LV1 2.048

Haven't changed them since install, so should be default.
Question: is there any explanation about levels and why the lv1 cache is the biggest and not the lv4 one? Does knowing that even help tweaking the performance on e.g. a weaker CPU?

cyberbeing
5th June 2014, 20:04
I recently came across a sample which had poor performance with the old LV1 cache default of 256. Raising the the LV1 cache size to 2048 improved performance by 50% or so. That was just a single sample though, and I haven't come across any others which see a significant benefit over the old defaults (LV1 256, LV2 256, LV3 512, LV4 512).

On systems with slower CPUs and RAM, setting the caches larger than necessary will hurt overall performance slightly, since hashing and cache queries are not free when you are not generating any cache hits. You can think of the various cache sizes as the number of duplicate/repetitive entries for various elements of a script. In the future we may add a lookahead to make what gets cached more intelligent, but the way they are currently implemented, its possible for the caches to be filled with 'useless' dynamic data. This is why a hard limit on the number of entries is currently necessary.

MasterMeNL
5th June 2014, 21:43
Thanks a lot for the default settings and info guys!

Sm3n
12th June 2014, 23:12
Hi,

I set up my Border width Style like this: 3.0000 because on 1080p video it was too thin.

Now I pretty happy if this result:
http://i.imgur.com/aMmWTqD.jpg

And if I play a 4:3 video, 3.0000 becomes too much:
http://i.imgur.com/X2m8nUR.jpg

Everytime I have to go back in settings and change 3 to 1. It's a bit boring. I tried to play with Renderer Layout Options but I can't do what I want, so...
Any advice to deal with this would be very much appreciated.

Cheers.

cyberbeing
13th June 2014, 04:13
In the current build there is no way to automatically deal with this. At one point we had an older commit which made an attempt at fixing this, but it didn't function correctly so I reverted it.

Just now, I took another look at it and I think I figured out what was wrong in the older commit. Try [Removed], along with the 'relative output height' setting under 'Styles' set to 1080p.

The removed build contains a major bug which causes display issues with styled ASS subtitles even without overriding styles, unless this feature is set to "original video" (disabled).

Sm3n
13th June 2014, 11:10
Thx you so much cyberbeing! You fixed it.
Looks the same on both 1080p and 4:3 now. And seems pretty stable.

Thx for your good work.

GCRaistlin
13th June 2014, 11:19
If XySubFilter is set to "Load when needed", the issue is here: not only XuSubFilter doesn't load but video isn't showed at all (the MPC-HC window looks like an audio file is played). If XySubFilter is set to "Always load", all works fine.

I have discovered that the issue appears when both VSFilter and XySubFilter are installed, no matter if they're added to MPC-HC's External Filters list or not. Also, VSFilter can be loaded by that even if it's not added to External Filters list.
If VSFilter will be deleted and then installed again the issue won't appear till next reboot. After reboot, the issue will be here again.

cyberbeing
13th June 2014, 13:43
Thx you so much cyberbeing! You fixed it.
Looks the same on both 1080p and 4:3 now. And seems pretty stable.

Good to hear.

I have discovered that the issue appears when both VSFilter and XySubFilter are installed, no matter if they're added to MPC-HC's External Filters list or not.
Is there some reason why you are adding anything to MPC-HC External Filters?

Also, VSFilter can be loaded by that even if it's not added to External Filters list.
VSFilter can be loaded by what? Nothing should be added to MPC-HC External Filters.

If VSFilter will be deleted and then installed again the issue won't appear till next reboot. After reboot, the issue will be here again.
Are you ensuring to always "uninstall" (regsvr32 /u VSFilter.dll) first before you delete? Though either way, this doesn't make any sense. Which version of VSFilter are you using?

It sounds like you may have a conflicting filter or otherwise partially broken playback setup. I no longer have a Windows XP box, so I cannot really troubleshoot this with you. Could you please try installing CCCP (http://www.cccp-project.net/download.php?type=cccp), running "Repair CCCP" under settings, and rebooting. If you still have issues when using CCCP with XySubFilter, they should be able to troubleshoot it with you on their forums (http://www.cccp-project.net/forums/index.php?board=1.0). At this point in time, I'm having a hard time believing that something other than XySubFilter isn't to blame for this failure.

GCRaistlin
13th June 2014, 22:48
Is there some reason why you are adding anything to MPC-HC External Filters?
I thought that it's necessary but now I see that XySubFilter loads without it.
Are you ensuring to always "uninstall" (regsvr32 /u VSFilter.dll) first before you delete? Though either way, this doesn't make any sense. Which version of VSFilter are you using?
I uninstall, not just delete. In External Filters list, "<not registered>" appears next to "VSFilter" after uninstalling.
I have been using VSFilter 2.41.322.

Could you please try installing CCCP (http://www.cccp-project.net/download.php?type=cccp), running "Repair CCCP" under settings, and rebooting. If you still have issues when using CCCP with XySubFilter, they should be able to troubleshoot it with you on their forums (http://www.cccp-project.net/forums/index.php?board=1.0). At this point in time, I'm having a hard time believing that something other than XySubFilter isn't to blame for this failure.

Actually, I reported this issue just to be on the safe side - there's no reason to have both VSFilter and XySubFilter installed so I just uninstalled VSFilter.

cyberbeing
14th June 2014, 03:07
I have been using VSFilter 2.41.322.
Does anything improve if you use xy-VSFilter 3.0.0.211 (http://xy-vsfilter.googlecode.com/files/xy-VSFilter_3.0.0.211.7z) or the slightly newer xy-VSFilter CCCP build (www.mediafire.com/?h1v2b9fia2ks1a9) instead? xy-VSFilter has much more robust connection logic than MPC-HC VSFilter, so it very well may resolve this strange failure.

Finnish Flash
14th June 2014, 16:23
I tried the new relative output height build and it's a feature that I've been waiting for, but something in this build broke Subtitle Workshop video output, which is weird because it shouldn't use XySubFilter in the first place. I tried uninstalling or disabling XySubFilter and everything went back to normal again. Also, a build from xy_sub_filter_rc3 branch is working well and it's not causing any problems. (3.1.0.696)

Could you push the commit to Github so that I could try to see what might be causing this regression?

GCRaistlin
14th June 2014, 19:48
Does anything improve if you use xy-VSFilter 3.0.0.211 (http://xy-vsfilter.googlecode.com/files/xy-VSFilter_3.0.0.211.7z) or the slightly newer xy-VSFilter CCCP build (www.mediafire.com/?h1v2b9fia2ks1a9) instead? xy-VSFilter has much more robust connection logic than MPC-HC VSFilter, so it very well may resolve this strange failure.
With xy-VSFilter, this issue can't be reproduced.

I have mkv file with subtitles that are displayed with MPC-HC ISR or with xy-VSFilter but not with XySubFilter (though they appear in the list that can be called by right click on the system tray icon). Ready to give any info for this bug to be resolved.

cyberbeing
15th June 2014, 12:16
@Finnish Flash

It seems Subtitle Workshop must catch all DirectShow filter exceptions during graph building. Should be fixed in this build (www.mediafire.com/?7bx4prrgxg5sgr7).


@GCRaistlin

Please provide either the script, or a small sample of the mkv which you are able to reproduce the issue with.

If this issue only occurs when using XySubFilter with madVR but not VMR9/EVR-CP, you are probably experiencing madVR issue #205 (http://bugs.madshi.net/view.php?id=205).

GCRaistlin
15th June 2014, 12:45
Please provide either the script, or a small sample of the mkv which you are able to reproduce the issue with.
With what tools do I get the script or extract this small sample?

If this issue only occurs when using XySubFilter with madVR but not VMR9/EVR-CP, you are probably experiencing madVR issue #205 (http://bugs.madshi.net/view.php?id=205).

You're right, it occurs only under circumstances described there.

Finnish Flash
15th June 2014, 13:01
@Finnish Flash

It seems Subtitle Workshop must catch all DirectShow filter exceptions during graph building. Should be fixed in this build (www.mediafire.com/?7bx4prrgxg5sgr7).



Just tried it and it's working fine now. Thank you very much!

cyberbeing
15th June 2014, 13:13
With what tools do I get the script or extract this small sample?

MKVToolNix (http://forum.doom9.org/showthread.php?t=155732) can do both.

For splitting:
Open mkvmerge GUI (mmg.exe)
Drag your mkv into into it
Global Tab
Split mode: split by parts based on timecodes
Parts: enter timecode range in format described by the tooltip

For extracting:
You could use mkvextract CLI directly, or a GUI like MKVclever (http://forum.doom9.org/showthread.php?t=152108) or gMKVExtractGUI (http://forum.doom9.org/showthread.php?t=170249).

Though if the issue is indeed identical to madVR Issue #205, then you probably don't need to extract the script. The particular issue seems to be triggered by the video resolution rather than the script when using madVR >=0.87.0 with certain older GPUs. Just split a small sample, upload it to a filehost of some kind (Mediafire, Mega, Dev-Host, AnonFiles, etc), and link it in the madVR issue.

Volfield
15th June 2014, 13:16
@Finnish Flash

It seems Subtitle Workshop must catch all DirectShow filter exceptions during graph building. Should be fixed in this build (www.mediafire.com/?7bx4prrgxg5sgr7).



Can you make x64 version?