L-SMASH Source

[Reel.Deel]

Originally Posted by HolyWu

L-SMASH-Works_20190903.7z

• Fix abnormal loading time.
• Improve progress printing.
• Use both file size and partial checksum (xxhash) for file signature comparison in index file.
• LWLibav: Fix inaccurate framerate in some files.
• VapourSynth: Replace configure with Meson build system.
• VapourSynth: Fix missing setError invocation when there is an error.
• Fix frame corruption in some VC-1 files by a workaround. Tested Atak_Snajpera's sample by seek-test.py and confirmed to be frame accurate.

The list here seem to suggest that MeteorRain's changes are also include. Yet the L-Smash GitHub repo says otherwise, am I missing something?

MeteorRain's L-Smash GitHub repo is up-to-date minus the your recent commits.

[Atak_Snajpera]

Two issues with latest version

1) Corrupted (grey frames) frames after seeking
Sample -> https://www.mediafire.com/file/ana6j...ample.mkv/file



2) webm with AV1 returns this error
Sample -> https://www.mediafire.com/file/lq3xm...mbps.webm/file

[Atak_Snajpera]

1. I got that sample from an ripbot user. I guess that this avc was originally muxed by makemkv. IT is odd that Simple remuxing (MKV to mkv)with latest mkvtoolnix did not fix that issue.
2.ok

[sneaker_ger]

The PPS changes mid-stream (pic_init_qp_minus26 changes). Mkvmerge seems to detect this when doing a "full" remux (1. demux to ES. 2. mux ES) and prepends the SPS/PPS to every keyframe. In the original sample it is only prepended on an actual change compared to the prior keyframe. Since both frame #97 and #104 use the same pic_init_qp_minus26 frame #104 does not have this prepended PPS. Then decoder tries to use first/global pic_init_qp_minus26 and breaks.

[Atak_Snajpera]

Crash after seeking
Sample -> https://www.mediafire.com/file/xhcyg...i_4-3.avi/file



FFVideoSource works fine.

[Atak_Snajpera]

Originally Posted by HolyWu

Cannot reproduce. I'm using seek-test.py for testing.

Because your tool does not check ALL frames.

Just try to open this script in MPC-HC.

LoadPlugin("LSMASHSource.dll")
LWLibavVideoSource("camcorder_25i_4-3.avi",cachefile="camcorder_25i_4-3.avi.lwi")
Trim(233,-1)

[poisondeathray]

Atak - can you share your Seek Tester tool ?

[videoh]

One way to test all frames is to put Reverse() at the end of your script and then play the video.

[ChaosKing]

Originally Posted by Atak_Snajpera

Because your tool does not check ALL frames.

The script does check all frames.

I tested it via lsmas.LWLibavSource() and avisource.AVISource("myscript.avs) in vapoursynth -> no seeking issues.

EDIT
Tried also Reverse() in my avs script, still frame accurate.

EDIT2
If I open the avs (with reverse) in vsedit i get an error

vapoursynth.Error: Avisynth read error:
CAVIStreamSynth: System exception - Access Violation at 0x00007FFB37302EB8

But there is no crash via vspipe...

EDIT3
Argh tested with the wrong script... so I tested it again ... VS is fine, but AVS crashes! But only with reverse.
Reverse in my avsisynth script -> instant crash System exception - Access Violation at 0x00007FFB37302EB8

LWLibavVideoSource("camcorder_25i_4-3.avi")
#Reverse()

std.Reverse() in VS is not frame accurate anymore.

avisource.AVISource(args.file).std.Reverse()

log files
- lsmash in VS https://pastebin.com/anyvB4pf
- avisyource + reverse in VS https://pastebin.com/XFkuT9JT (it aborts after 3 errors)

EDIT4
lsmas.LWLibavSource(args.file).std.Reverse() -> lsmas: failed to get video track. Now I'm confused.

EDIT5
ok ... final results
VS
lsmas.LWLibavSource(args.file) #ok
lsmas.LWLibavSource(args.file).std.Reverse() #ERR failed to get video track.

AVS via VS - script: LWLibavVideoSource("camcorder_25i_4-3.avi")
avisource.AVISource(args.file) # ok
avisource.AVISource(args.file).std.Reverse() # not frame accurate

AVS script with:

LWLibavVideoSource("camcorder_25i_4-3.avi")
reverse()

= instant crash: System exception - Access Violation at 0x00007FFB37302EB8

EDIT 6 - Bonus round
Remuxed it to mkv

VS
lsmas.LWLibavSource(args.file) # ok
lsmas.LWLibavSource(args.file).std.Reverse() # [importer: Error]: failed to find the matched importer.

AVS via VS
avisource.AVISource(args.file) # ok
avisource.AVISource(args.file).std.Reverse() #ok

avs+reverse via vdub still crashes.

[videoh]

Does anybody care?

[ChaosKing]

Originally Posted by HolyWu

https://github.com/HolyWu/L-SMASH-Wo...s/tag/20190910

• Update to FFmpeg 4.2.1.
• VideoSource: Add parameter prefer_hw to conveniently switch between software and hardware decoder. Consult README for details.
• Fix seeking issue in CUVID decoding.
• Fix hardware decoder outputting YUV420P8 by default on high bit depth clip.
• Optimize P010->YUV420P10 conversion for hardware decoder by SSE2.
• LWLibav: Fix access violation in avi file when seeking randomly.

Fixed all errors for me

[FranceBB]

Originally Posted by HolyWu

https://github.com/HolyWu/L-SMASH-Wo...s/tag/20190910

• Update to FFmpeg 4.2.1.
• VideoSource: Add parameter prefer_hw to conveniently switch between software and hardware decoder. Consult README for details.
• Fix seeking issue in CUVID decoding.
• Fix hardware decoder outputting YUV420P8 by default on high bit depth clip.
• Optimize P010->YUV420P10 conversion for hardware decoder by SSE2.
• LWLibav: Fix access violation in avi file when seeking randomly.

Once again, thank you!

[poisondeathray]

Fix seeking issue in CUVID decoding.

Thanks,

I can confirm this does fix issues on previous lsmash builds .

Very nice

[Reel.Deel]

Originally Posted by HolyWu

https://github.com/HolyWu/L-SMASH-Wo...s/tag/20190910

• Update to FFmpeg 4.2.1.
• VideoSource: Add parameter prefer_hw to conveniently switch between software and hardware decoder. Consult README for details.
• Fix seeking issue in CUVID decoding.
• Fix hardware decoder outputting YUV420P8 by default on high bit depth clip.
• Optimize P010->YUV420P10 conversion for hardware decoder by SSE2.
• LWLibav: Fix access violation in avi file when seeking randomly.

I cannot load the following apng image with LWLibavSource(). It gives the error LWLibavVideoSource: failed to get the video track. I only tried with latest avs+ (x64).
I tried with L-SMASH-Works_20190903 / 0906 / 0910 and even MeteorRain's LSMASHSource-r935+34 but all of them give the same error. Last version that works is L-SMASH-Works-r935+26-20190811. Gifs work fine though.

[poisondeathray]

"Regular" PNG isn't working either (images, or PNG in MOV) . There were a bunch of ffms2 versions like that earlier as well

[qyot27]

PNG support requires zlib.

[poisondeathray]

Is there an AVC in MXF parsing issue with L-SMASH-Works_20190910 ?

1a) 10bit422 AVC can be read in MP4 but not MXF "failed to get video track" . But "L-SMASH-Works-r935+3-win64-20190401" was able to read both
1b) But rewrapping that AVC stream into a TS makes it readable

2) 8bit422 MPEG2 in MXF can be read, so can't be a "global" MXF issue with this version

[poisondeathray]

Sorry false alarm . I can't reproduce the issue now. Maybe some windows weirdness (I rebooted somewhere in between) or something I mixed up

[Atak_Snajpera]

Another possible bug. L-SMASH does not return some frames.


Again FFVideoSource works fine.

LoadPlugin("LSMASHSource.dll")
LWLibavVideoSource("TEST.mkv")
Trim(1,-1)

Sample -> https://www.mediafire.com/file/4f7on.../TEST.mkv/file

[Atak_Snajpera]

L-Smash does not fallback to software decoders automatically like written in documentation.

+ prefer_hw (default : 0)
Whether to prefer hardware accelerated decoder to software decoder.
Have no effect if 'decoder' is specified.
- 0 : Use default software decoder.
- 1 : Use NVIDIA CUVID acceleration for supported codec, otherwise use default software decoder.
- 2 : Use Intel Quick Sync Video acceleration for supported codec, otherwise use default software decoder.

For example I have NVIDIA card and it works fine with prefer_hw=1 but my CPU does not support Intel Quick Sync Video so with prefer_hw=2 i get this


I would also suggest value -1 as AUTO

+ prefer_hw (default : 0)
Whether to prefer hardware accelerated decoder to software decoder.
Have no effect if 'decoder' is specified.
-1 : Use first available hardware decoder,otherwise use default software decoder.
0 : Use default software decoder.
1 : Use NVIDIA CUVID acceleration for supported codec, otherwise use default software decoder.
2 : Use Intel Quick Sync Video acceleration for supported codec, otherwise use default software decoder.