I have made and listed the changes required to signal the AR instead of resizing in AviSynth for it (discussed briefly in the MeGUI thread). They are quite long, listed here:
Firstly, there is a bugfix:
OneClickWindow crashed if using matroska but encoding audio. To fix, change else if (containerFormat.SelectedIndex == 2) // mp4 in OneClickWindow.projectCreationFinished to else if (containerFormat.SelectedIndex == 1 ||
containerFormat.SelectedIndex == 2) // mkv or mp4
Now the AR signalling:
To enable proper AR signalling in all cases I am aware of, it is done it two ways:
Signal via the codec if not Snow
Signal via the container if matroska
If the container is not matroska and the codec is snow, then signalling is not possible, and there is an error message.
changes:
VideoUtil.suggestResolution method is changed to
public static int suggestResolution(double readerHeight, double readerWidth, double customDAR, CropValues cropping, int horizontalResolution,
bool signalAR, out int SARX, out int SARY)
{
double sourceHorizontalResolution = readerHeight * customDAR - (double)cropping.left -(double)cropping.right;
double sourceVerticalResolution = readerHeight - (double)cropping.top - (double)cropping.bottom;
double realAspectRatio = sourceHorizontalResolution / sourceVerticalResolution; // the real aspect ratio of the video
realAspectRatio = getAspectRatio(realAspectRatio);
double resizedVerticalResolution = (double)horizontalResolution / realAspectRatio;
int scriptVerticalResolution = 0;
int temp = (int)(resizedVerticalResolution / (double)16);
int upper = (temp+1) * 16;
int lower = temp * 16;
if ((double)upper - resizedVerticalResolution > resizedVerticalResolution - (double)lower) // Which one is closer to the resolution we should have
scriptVerticalResolution = lower;
else
scriptVerticalResolution = upper;
if (signalAR)
{
int displayVerticalResolution = (int)Math.Round(resizedVerticalResolution);
sourceVerticalResolution = readerHeight - cropping.top - cropping.bottom;
temp = (int)(sourceVerticalResolution / (double)16);
upper = (temp+1) * 16;
lower = temp * 16;
if ((double)upper - resizedVerticalResolution > resizedVerticalResolution - (double)lower) // Which one is closer to the resolution we should have
scriptVerticalResolution = lower;
else
scriptVerticalResolution = upper;
SARX = horizontalResolution;
SARY = displayVerticalResolution;
return scriptVerticalResolution;
}
else
{
SARX = 1;
SARY = 1;
return scriptVerticalResolution;
}
}
OneClickWindow has a checkbox added (called signalAR). I put it next to the AR textbox, but that obviously is not important. It has a checkedChanged event as follows:
private void signalAR_CheckedChanged(object sender, System.EventArgs e)
{
if (signalAR.Checked && videoCodec.SelectedIndex == 2 && containerFormat.SelectedIndex != 1)
{
MessageBox.Show("Can't signal AR with Snow except with Matroska container", "AR signalling not possible", MessageBoxButtons.OK, MessageBoxIcon.Error);
signalAR.Checked = false;
}
}
OneClickWindow has the following new variables:
private int outputSARX;
private int outputSARY;
The suggestResolution call in OneClickWindow.openVideo needs to be changed to:
int scriptVerticalResolution = VideoUtil.suggestResolution(reader.Height, reader.Width, Double.Parse(customDAR.Text), AutoCropValues, (int)horizontalResolution.Value, signalAR.Checked, out outputSARX, out outputSARY);
The generateJobSeries call at the end of OneClickWindow.setUpJobs needs to be changed to vUtil.generateJobSeries(videoInput, videoOutput, muxedOutput, videoSettings,
aStreams, audio, subtitles, chapters, desiredSize, splitSize, containerOverhead,
type, outputSARX, outputSARY, signalAR.Checked);
VideoUtil.generateJobSeries gets three new variables passed to it, so the prototype becomes: public void generateJobSeries(string videoInput, string videoOutput, string muxedOutput, VideoCodecSettings videoSettings, AudioStream[] aStreams,
SubStream[] audio, SubStream[] subtitles, string chapters, long desiredSize, int splitSize, double containerOverhead, MUXTYPE muxtype,
int SARX, int SARY, bool signalAR)This code is added in the function just after the encoding mode (automated 2pass) is set: // Signal the AR
if (signalAR)
applyAspectRatio(SARX, SARY, videoSettings);(The function this references will be given later). The muxjob generation within this function (inside the if (doMux) block) is changed from mjob = jobUtil.generateMuxJob(vjobs[vjobs.Length - 1], audio, subtitles, chapters, muxtype,
muxedOutput);[code] to [code] mjob = jobUtil.generateMuxJob(vjobs[vjobs.Length - 1], audio, subtitles, chapters, muxtype,
SARX, SARY, muxedOutput);
VideoUtil gets another function (referenced in the above code): /// <summary>
/// applies the given fractional aspect ratio to the video settings if possible
/// </summary>
/// <param name="SARX">the x part of the AR</param>
/// <param name="SARY">the y part of the AR</param>
/// <param name="settings">the video settings to be modified</param>
/// <returns>true if succeeded, false if failed</returns>
public static void applyAspectRatio(int SARX, int SARY, VideoCodecSettings settings)
{
// Snow is ignored, because it does not support AR signalling
if (settings is lavcSettings)
{
lavcSettings temp = (lavcSettings) settings;
temp.SARX = SARX;
temp.SARY = SARY;
}
else if (settings is x264Settings)
{
x264Settings temp = (x264Settings) settings;
temp.SARX = SARX;
temp.SARY = SARY;
}
else if (settings is xvidSettings)
{
while (SARX > 255 || SARY > 255) // XviD needs SARX <= 255 and SARY <= 255
{
SARX = SARX / 2;
SARY = SARY / 2;
}
xvidSettings temp = (xvidSettings) settings;
temp.SARX = SARX;
temp.SARY = SARY;
temp.PAR = 5;
}
}
There need to be some changes made to add AR to the muxing info for matroska. MuxSettings gains two variables and two properties: private int sarX, sarY; and /// <summary>
/// SARX (only for Matroska)
/// </summary>
public int SARX
{
get {return sarX;}
set {sarX = value;}
}
/// <summary>
/// SARY (only for Matroska)
/// </summary>
public int SARY
{
get {return sarY;}
set {sarY = value;}
} and inside the constructor: sarX = -1;
sarY = -1;JobUtil.generateMuxJob gains two input variables, to get the following prototype: public MuxJob generateMuxJob(VideoJob vjob, SubStream[] audioStreams, SubStream[] subtitleStreams,
string chapterFile, MUXTYPE type, int SARX, int SARY, string output)It gains the following two lines of code: job.Settings.SARX = SARX;
job.Settings.SARY = SARY;They can basically go anywhere before the commandline is generated. The first line of CommandLineGenerator.generateMkvmergeCommandline becomes the following four lines: string retval = "\"" + mkvmergePath + "\" -o \"" + output + "\" ";
if (settings.SARX > 0 && settings.SARY > 0)
retval += "--aspect-ratio 0:" + settings.SARX + "/" + settings.SARY + " ";
retval += "-A -S \"" + input + "\" ";The call to generateJobSeries at the end of AutoEncodeWindow.queueButton_Click becomes vUtil.generateJobSeries(videoInput, videoOutput, muxedOutput.Text, this.videoSettings.clone(), aStreams, audio, subtitles, chapters, desiredSize, splitSize,
(double)containerOverhead.Value, type, -1, -1, false);AviSynthWindow.suggestResolution_CheckedChanged needs to have the call to suggestResolution replaced by the following three lines: int sarx, sary; // Not needed for AviSynthWindow resizing
int scriptVerticalResolution = VideoUtil.suggestResolution(reader.Height, reader.Width, Double.Parse(customDAR.Text),
cropping, (int)horizontalResolution.Value, false, out sarx, out sary);When attempting to compile, there should now be four (I think, maybe I miscounted) compile-time errors which are due to the changed JobUtil.generateMuxJob prototype. To fix these, add the parameters -1, -1 just before the muxed output (the last) parameter.
After all this work, there should now be working AR signalling. A lot of little changes, huh? Upon testing, this seems to work with each configuration except for:
-Snow not in Matroska (it doesn't have any way to signal AR)
-XviD not in Matroska (the mencoder XviD AR signaling seems to be broken for custom PARs)