MeGUI development

[berrinam]

Patch uploaded to sourceforge. Detailed description in the posted patch, but it has some reorganisation of the AutoEncode and OneClick GUIs and extends their operability to not needing a target filesize. The patch is based on 0.2.3.1029. Sorry Mutant_Fruit, I didn't integrate your changes.

EDIT: I accidentally submitted it twice. Both should be identical, so choose whichever you want ;)

[Mutant_Fruit]

Berri: You never included the cs file for the oneclickconfiguration window. Post that up whenever you can. Can't compile with your patch without it :p

[Sharktooth]

yup... it's not complete.

CVS Update: Context Help as been fixed and submitted.

[Mutant_Fruit]

Just uploaded the patch for the restructured x264 dialog. Let me know if anything needs to be moved around. I'm sure it ain't right yet, but hopefully its a bit better. (liink to source is in the patch details thingy in case i screwed up the patch)

I hope i created the patch right. Let me know if i havn't. I'm only getting the hang of it at the moment.

[max-holz]

Where could I find the source for 0.2.3.1029a .Net 2.0?

Ciao

[Sharktooth]

@mutant_fruit: With NET 1.1:
x264ConfigurationDialog.cs(521,13): error CS0117: 'System.Windows.Forms.TabPage'
does not contain a definition for 'UseVisualStyleBackColor'
x264ConfigurationDialog.cs(527,13): error CS0117: 'System.Windows.Forms.Label'
does not contain a definition for 'Padding'
x264ConfigurationDialog.cs(545,13): error CS0117: 'System.Windows.Forms.Label'
does not contain a definition for 'Padding'
x264ConfigurationDialog.cs(732,13): error CS0117: 'System.Windows.Forms.Label'
does not contain a definition for 'Margin'
x264ConfigurationDialog.cs(741,13): error CS0117: 'System.Windows.Forms.Label'
does not contain a definition for 'Margin'
x264ConfigurationDialog.cs(750,13): error CS0117: 'System.Windows.Forms.Label'
does not contain a definition for 'Margin'
x264ConfigurationDialog.cs(787,13): error CS0117:
'System.Windows.Forms.CheckBox' does not contain a definition for
'Padding'
x264ConfigurationDialog.cs(798,13): error CS0117: 'System.Windows.Forms.Label'
does not contain a definition for 'Padding'
x264ConfigurationDialog.cs(807,13): error CS0117:
'System.Windows.Forms.CheckBox' does not contain a definition for
'Padding'
x264ConfigurationDialog.cs(817,13): error CS0117:
'System.Windows.Forms.CheckBox' does not contain a definition for
'Padding'
x264ConfigurationDialog.cs(871,13): error CS0117: 'System.Windows.Forms.Label'
does not contain a definition for 'Padding'
x264ConfigurationDialog.cs(880,13): error CS0117: 'System.Windows.Forms.Label'
does not contain a definition for 'Padding'
x264ConfigurationDialog.cs(889,13): error CS0117: 'System.Windows.Forms.Label'
does not contain a definition for 'Padding'
x264ConfigurationDialog.cs(900,13): error CS0117:
'System.Windows.Forms.CheckBox' does not contain a definition for
'Padding'
x264ConfigurationDialog.cs(915,13): error CS0117: 'System.Windows.Forms.TabPage'
does not contain a definition for 'UseVisualStyleBackColor'
x264ConfigurationDialog.cs(1183,13): error CS0117:
'System.Windows.Forms.TabPage' does not contain a definition for
'UseVisualStyleBackColor'
x264ConfigurationDialog.cs(1530,13): error CS0117:
'System.Windows.Forms.TabPage' does not contain a definition for
'UseVisualStyleBackColor'
x264ConfigurationDialog.cs(2054,13): error CS0117:
'System.Windows.Forms.ToolTip' does not contain a definition for
'IsBalloon'

it compiles only with NET 2.0.

@All: Shall we drop NET 1.1?

[Sharktooth]

Where could I find the source for 0.2.3.1029a .Net 2.0?

Ciao
http://www.webalice.it/f.corriga/megui/MeGUI-src.CVS.0.2.3.1029a.7z

as usual the anonymous CVS takes a while to update...

[Mutant_Fruit]

@All: Shall we drop NET 1.1?
Whoops, i thought we had already moved to .NET2.0! I've been working with 2.0. Buggerit. I could rejig to work with .NET1.1 if ya want. But if development is moving to 2.0 i won't bother.

[Sharktooth]

The layout isnt bad but i suppose it's not finished at all.
However i would move the SAR option is Misc. Rename Alpha and Beta debloking to Strenght and Threshold respectively. Rename Profiles (the MeGUI profiles) to Presets. Move all the B-Frames option in one place.
However keep it NET 2.0, before making any NET version changes let's hear the other devs.

[Mutant_Fruit]

Patch2 up for the layout. Did all the changes listed above. If anyone thinks more changes are needed, just let me know. Might as well get this right.

[Sharktooth]

note: do not upload the patches to SF if they're not completed or i (or the other admins) have to reject them.
Just post screenshots or include/attach them here.
Also, is it incemetal (restuctured2 goes over restructure1) or is it from scratch (restructure2 goes over the megui sources)?

[Raithmir]

Feature request : Could you add a date/time stamp at the start and end of logging each job? Would be useful to see how long each bit takes as I usually just set my PC to shutdown when finished and then go back looking at the logs (which incidently it seems to sometimes write two identical logs a few seconds apart, I've not figured out what scenario's it does it yet).

[Sharktooth]

you mean in the logfiles?

[Mutant_Fruit]

note: do not upload the patches to SF if they're not completed or i (or the other admins) have to reject them.
Ah right. I won't do that in future then.


Also, is it incemetal (restuctured2 goes over restructure1) or is it from scratch (restructure2 goes over the megui sources)?
It is incremental, structured2 goes over structured1.

In future i'll just host temp builds until everyone's satisfied with the changes, then i'll post it on SF. I'll remove the two patches from SF regarding the layout changes, and i'll submit a final one later (that goes over the CVS source) when everything is double checked.

[Sharktooth]

i said that coz the Patch tracking is inteder for "working" or almost ready to be submitted patches

[Mutant_Fruit]

i said that coz the Patch tracking is inteder for "working" or almost ready to be submitted patches
No worries. I'm new to this, so please point out any mistakes i make. Also, am i creating the patches correctly, or is the way i'm creating the patch making it awkward for you to apply it? I'm using the commandline diff and patch utils for creating the patches.

[Sharktooth]

it's ok. it just creates some minor problems.

[Mutant_Fruit]

Heres a build if anyone wants to check out the new x264 configuration dialog layout.

Let me know of any problems.

http://www.fileshack.us/files/741/MeGUI-New-x264-Dialog.zip

[berrinam]

Ok, after having some problems with patching (TortoiseCVS patching requires CVS access, and with unreliable anonymous access, and disallowed developer access :devil: , this didn't eventuate), I ended up just copying the changed files into a separate folder. The changes are the same as last time, but this time, it includes the new files. Some files are no longer needed, ie both of the OneClickDefault window ones (cs and resx), and the OneClickDefaults.cs file. I've made no change to the version number as I don't know what numbering system we are following.

The changes are here on rapidshare. (http://rapidshare.de/files/10229683/oneclick_changes_net_2_0.zip.html) The code I have attached only works in .NET 2.0. If it is decided that we should stay in .NET 1.1 for the moment, then I will change the code, but for now it is too much work. The code should work if you simply copy and replace the files in my archive on top of the 1029a version Sharktooth posted. As to going with .NET 2.0, :stupid: I had somehow assumed that we were already using .NET 2.0

Yep, I'm evil and disabled CVS write privileges for everyone except admins so that we use the Patch Tracker, hehe. It's a training period so that admins get used to checking it as much as anything else.
As I said above: anonymous CVS is a pain, as is making patches. :devil: Can I have my developer access back, please, or can I be made an admin? This 'training period' excuse seems quite flimsy to me.

Changelog:
-Redesigned One Click mode to have a basic and advanced tab. Added oneclick profiles, and added support for avs profiles inside oneclick.
-Allowed user to select "Don't care" for the file target in both AutoEncode and OneClick, so that MeGUI will not adjust the bitrate to reach the target, but will instead use the profile's settings. This also allows the use of crf and qp in AutoEncode and OneClick.

[Sharktooth]

So the question rises again... Shall we move to .NET 2.0?

[Mutant_Fruit]

Well, there's no disadvantages to moving except that people will have to install the .NET2.0 package (but they'll either already have it thanks to windows update, or will have to install it soon enough anyway). Advantages include more controls and hopefully faster development due to VC# Express being a bit better, so i'd say go for it.

[Sharktooth]

I know what are the advantages... also the "x264 ppl" chosen .NET 2.0 too ( http://forum.doom9.org/showthread.php?t=104797 ), but the other devs should agree to move to .NET 2.0 (im all for it though).

[Sharktooth]

Heres a build if anyone wants to check out the new x264 configuration dialog layout.

Let me know of any problems.

http://www.fileshack.us/files/741/MeGUI-New-x264-Dialog.zip
It's Deblocking Strenght and Deblocking Threshold.

[Mutant_Fruit]

Whoops, my bad. I just renamed them, created a patch and uploaded to SF. I think its pretty much finished. I havn't spotted any cut-off text. Everything seems to be placed appropriately. All the controls are still linked to their correct events (as far as i can tell). So i think its good to go.

[Doom9]

Shall we move to .NET 2.0?Yes.. I've just installed VS2k5 on every machine I develop on.

[Sharktooth]

On my way... :)

[Sharktooth]

CVS Update: included berrinam patch. It now requires .NET 2.0 to compile.
0.2.3.1030 2 Jan 2005
Redesigned One Click mode to have a basic and advanced tab. Added oneclick profiles, and added support for avs profiles inside oneclick.
Allowed user to select "Don't care" for the file target in both AutoEncode and OneClick, so that MeGUI will not adjust the bitrate to reach the target, but will instead use the profile's settings. This also allows the use of crf and qp in AutoEncode and OneClick.


However snow and x264 conditional compiling is br0ken. Easy to fix but have no time to do it right now.

[max-holz]

CVS Update: included berrinam patch. It now requires .NET 2.0 to compile.
0.2.3.1030 2 Jan 2005
Redesigned One Click mode to have a basic and advanced tab. Added oneclick profiles, and added support for avs profiles inside oneclick.
Allowed user to select "Don't care" for the file target in both AutoEncode and OneClick, so that MeGUI will not adjust the bitrate to reach the target, but will instead use the profile's settings. This also allows the use of crf and qp in AutoEncode and OneClick.


However snow and x264 conditional compiling is br0ken. Easy to fix but have no time to do it right now.
Possible having source on webalice? ;)

Ciao

[Doom9]

Made my first changes. Is it possible to tell tortoise to store my password? It's not like anybody else could use this box.

Also, does anybody know how tortoise will act when I take those files to my notebook tomorrow, work in them on my way to work and back, then put them back on the PC where I have tortoise installed?

And does anybody know of a good diff that tortoise could use?

Last but not least, has anybody figured out how to make VS2k5 (or Express) stop complaining about GUI classes with conditional compilation statements? It's not like this warning has any useful meaning in the current context.

[Pasqui]

Using MeGUI 0.2.3.1029a for .NET2.0, I cannot set the avisynth plugins folder. The dialog box only shows the Program Files folder and its subfolders, but my Avisynth installation in another folder (F:\DVD\AviSynth2).

[Raithmir]

you mean in the logfiles?

Yes in the log files, I know that it has the time in the queue tab but I delete those entries when I've finished and have been going back looking through the log files.

...and yes lets move to .NET 2.0! :)

[bob0r]

compile x264-svn:

Microsoft (R) Visual C# 2005 Compiler version 8.00.50727.42
for Microsoft (R) Windows (R) 2005 Framework version 2.0.50727
Copyright (C) Microsoft Corporation 2001-2005. All rights reserved.

OneClickConfigurationDialog.cs(201,16): error CS0246: The type or namespace name 'OneClickSettings' could not be found (are you missing a using directive or an assembly reference?)
OneClickProfile.cs(9,11): error CS0246: The type or namespace name 'OneClickSettings' could not be found (are you missing a using directive or an assembly reference?)
OneClickProfile.cs(10,10): error CS0246: The type or namespace name 'OneClickSettings' could not be found (are you missing a using directive or an assembly reference?)
OneClickProfile.cs(22,39): error CS0246: The type or namespace name 'OneClickSettings' could not be found (are you missing a using directive or an assembly reference?)
OneClickWindow.cs(16,17): error CS0246: The type or namespace name 'lavcSettings' could not be found (are you missing a using directive or an assembly reference?)
OneClickWindow.cs(17,17): error CS0246: The type or namespace name 'snowSettings' could not be found (are you missing a using directive or an assembly reference?)
OneClickWindow.cs(18,17): error CS0246: The type or namespace name 'xvidSettings' could not be found (are you missing a using directive or an assembly reference?)
OneClickWindow.cs(29,17): error CS0246: The type or namespace name 'VideoUtil' could not be found (are you missing a using directive or an assembly reference?)
OneClickWindow.cs(377,37): error CS0246: The type or namespace name 'AspectRatio' could not be found (are you missing a using directive or an assembly reference?)

[berrinam]

The transition to .NET 2.0 means that compile.bat no longer works (it uses the .NET 1.1 compiler). Anyway, MeGUI 0.2.3.1030 adds no features that are relevant to x264-svn, so try compiling 1029a, as that should work with .NET 1.1

[LiFe]

Hmm dev has sorta exploded? I didn't get as much of the help file done as desired during the hols, and I'm back at work (and got 2 after work jobs to get done). Next update will be done on the weekend.

[bob0r]

@berrinam

I cant compile with 1.1 also anymore:

compile x264-svn:

Microsoft (R) Visual C# .NET Compiler version 7.10.6001.4
for Microsoft (R) .NET Framework version 1.1.4322
Copyright (C) Microsoft Corporation 2001-2002. All rights reserved.

OneClickConfigurationDialog.cs(13,12): error CS1518: Expected class, delegate, enum, interface, or struct
OneClickConfigurationDialog.Designer.cs(3,5): error CS0116: A namespace does not directly contain members such as fields or methods
OneClickConfigurationDialog.Designer.cs(3,19): error CS0101: The namespace 'MeGUI' already contains a definition for 'OneClickConfigurationDialog'
OneClickConfigurationDialog.cs(13,26): (Location of symbol related to previous error)
OneClickWindow.cs(13,12): error CS1518: Expected class, delegate, enum, interface, or struct
OneClickWindow.Designer.cs(3,5): error CS0116: A namespace does not directly contain members such as fields or methods
OneClickWindow.Designer.cs(3,19): error CS0101: The namespace 'MeGUI' already contains a definition for 'OneClickWindow'
OneClickWindow.cs(13,26): (Location of symbol related to previous error)

I already have a working version of megui.exe with older source, i was just pointing this out, so DEVs can fix it :sly:

[Mutant_Fruit]

bob0r: You need .NET2.0 to compile it from now on. It won't work against 1.1 or older.

[Doom9]

I'll see to it that compile.bat will work properly under .NET 2.0 but as already pointed out, the move has been done.. I've already made several changes towards that effect and I'm currently revamping the video encoder architecture.. as a sideffect getting rid of the last two remaining compiler warnings that affect .NET 2.0.

And as Sharktooth mentioned: conditional compilation is currently broken.. so you can't build any new svn builds.. but since there have been no changes for that particular version, it shouldn't be too problematic.

[Sharktooth]

@doom9: tortoise svn cant store the pass.

Microsoft.DirectX.AudioVideoPlayback is not necessary!!! :P

[Sharktooth]

CVS update:
Fixed x264 and Snow conditional compiling
Removed Microsoft.DirectX.AudioVideoPlayback from the references

Sources: http://www.webalice.it/f.corriga/megui/MeGUI-src.CVS.0.2.3.1030.7z
Bins on SF (http://www.sf.net/projects/megui).

[godhead]

Sorry, been away from computer access for the New year. I'll grab the latest CVS tonight and start looking at what I can fix now that we've moved to the 2.0 framework.

Are we going to start using the task and bug reporting features of SF so that we can coordinate changes more efficiently? I'd like to just look at my SF account to see what changes are needed rather than digging through this long thread.

[Raithmir]

AVISynth Script creator not working for me in 2.3.1030, clicking on the edit tab is just blank, 1029a works fine.

[Sharktooth]

ensure to load the default profile.

[Raithmir]

ah that worked :)

[Mutant_Fruit]

redo the whole x264 tri-state section to have one big method that handles activation/deactivation for each GUI element. That method will be called by showCommandline. In addition, make it so that showCommandline is only triggered once the GUI is fully created and the entire settings have been loaded.
Does this still have to be done, and what exactly do you mean by tri-state section.

Also I assume you mean enabling and disabling of controls when you see activation/deactivation.

[Sharktooth]

The TO DO list is not up to date :(
I think it has been already done (or at least partially done).
As soon as doom9 updates the TO DO list in the first post i'll add a TODO.txt to the CVS.

[fegul]

I dont speak programming, but I'd like to see MeGUI get better as it has a lot of potential. The main errors and bugs that I have encountered thus far; When I use the Avisynth creator and hit prevew after inputing the d2v file, I get a narrow black bar that has no video. Also, when I hit crop, I get this;
See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.ArgumentNullException: Value cannot be null.
Parameter name: image
at System.Drawing.Graphics.DrawImage(Image image, Int32 x, Int32 y, Int32 width, Int32 height)
at MeGUI.VideoPlayer.resizeBitmap(Bitmap b, Int32 nWidth, Int32 nHeight)
at MeGUI.VideoPlayer.positionSlider_Scroll(Object sender, EventArgs e)
at MeGUI.VideoPlayer.crop(Int32 left, Int32 top, Int32 right, Int32 bottom)
at MeGUI.AviSynthWindow.sendCropValues()
at MeGUI.AviSynthWindow.crop_CheckedChanged(Object sender, EventArgs e)
at System.Windows.Forms.CheckBox.OnCheckedChanged(EventArgs e)
at System.Windows.Forms.CheckBox.set_CheckState(CheckState value)
at System.Windows.Forms.CheckBox.OnClick(EventArgs e)
at System.Windows.Forms.CheckBox.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ButtonBase.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///E:/WINDOWS/Microsoft.NET/Framework/v2.0.50727/mscorlib.dll
----------------------------------------
megui
Assembly Version: 0.2.3.1030
Win32 Version: 0.2.3.1030
CodeBase: file:///F:/DVD%20Rips/bitcalc/MeGUI/megui.exe
----------------------------------------
System.Windows.Forms
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///E:/WINDOWS/assembly/GAC_MSIL/System.Windows.Forms/2.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///E:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///E:/WINDOWS/assembly/GAC_MSIL/System.Drawing/2.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
System.Xml
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///E:/WINDOWS/assembly/GAC_MSIL/System.Xml/2.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Configuration
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///E:/WINDOWS/assembly/GAC_MSIL/System.Configuration/2.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
bvd27uqz
Assembly Version: 0.2.3.1030
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///E:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
jq7878b1
Assembly Version: 0.2.3.1030
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///E:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
8yf-dzrk
Assembly Version: 0.2.3.1030
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///E:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
<system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

Does null mean that this has not been developed yet?

[Sharktooth]

No it means a value cannot be "null"... :)
Can you post your .avs and .d2v files too?

[fegul]

No it means a value cannot be "null"... :)
Can you post your .avs and .d2v files too?

I couldnt get an avs file made since the program crashed before it could make one

Heres the link to my d2v file; http://hailut.homedns.org/VTS_08_1.d2v

made it using DGindex 1.45

[godhead]

The TO DO list is not up to date :(
I think it has been already done (or at least partially done).
As soon as doom9 updates the TO DO list in the first post i'll add a TODO.txt to the CVS.

Shouldn't the TODO be moved to Source Forge tasks so that it's not required to get a CVS update just to see the TODO?

[berrinam]

@fegul: This sounds like it could be a problem with either DGDecode.dll in the wrong place (I'm no longer exactly sure where it should be, but charleski should know), or the Default Profile not selected in the avs profile window.

@devs: The problem with the default profile not selected by default should be solved by changing avsProfile = "default"; in MeGUISettings.<init> to avsProfile = "Default Profile";