MeGUI development

[Kurtnoise]

Sorry but...what is the relationship between MediaInfo(wrapper) and the avs preview ? because I'm pretty sure that the lib doesn't have an avs parser.

@nk : Vista 32 or 64 bits ?

[Sharktooth]

Hmm cool, maybe better to remove ANY spaces on SVN for any file or dir, for my auto scripts its very annoying :)
http://megui.svn.sourceforge.net/viewvc/megui/Installer/

[Sharktooth]

0.2.6.1013
- (Sharktooth) New MeGUI icons and installer fixes
- (Kurtnoise) [JobQueue] : scrollbar fix (#1793456)
- (Kurtnoise) [AudioEncoder] : fix mp2 bitrate command line for the new FFmpeg builds.
- (Kurtnoise) Better label names for some encoders.
- (Kurtnoise) Cosmetic : added m2ts extension.
- (Kurtnoise) Removed resize event.

[Kurtnoise]

you should wait before to submit new release dude...;)

coz, bugs tickets 1677527, 1749803, 1791912, 1793313 can be closed now.


btw, Vista issues suck...I need to reinstall this OS to debug the GUI. blahhhhh.

[Sharktooth]

get some virtualization software.
im also thinking to install vista to test megui issues... just for that...
however ill release a new build later...

[Sharktooth]

here we go:
0.2.6.1014
- (Kurtnoise) [MainForm] fixed minimize to tray (#1749803)
http://sourceforge.net/project/showfiles.php?group_id=156112&package_id=244469

[Kurtnoise]

I don't like very much virtualization tools to debug applications but this is an other story. :)

Questions for you:
About yadif : we should add it in the server and/or Update Window Form or not ?
If I add Aften, should I drop the FFmeg AC3 part/code or not ?

[Sharktooth]

yadif is already in the autoupdate and the updatewindow has an entry for it. are you having problems getting it from the autoupdate?
http://img265.imageshack.us/img265/8543/yadiflj2.th.png (http://img265.imageshack.us/my.php?image=yadiflj2.png)

I would keep both Aften and ffmpeg AC3. we have even 3 AAC encoders...

[Kurtnoise]

yadif is already in the autoupdate and the updatewindow has an entry for it. are you having problems getting it from the autoupdate?
well...it's not in the ListView for me. :confused:

http://img258.imageshack.us/img258/8492/meguiupdatewindow130920bd7.th.png (http://img258.imageshack.us/my.php?image=meguiupdatewindow130920bd7.png)


About Aften : it uses the same encoder engine. ;) That's why I ask...

[Sharktooth]

Its not in the listview coz its not in the avisynth filters section. since it's a C-Plugin its treated (and shown in the listview) as an external program.

about aften... i think ffmpeg is safer to "mantain"... i mean, aften is a small project and one day it may die, while ffmpeg is a solid project...

[Kurtnoise]

Its not in the listview coz its not in the avisynth filters section. since it's a C-Plugin its treated (and shown in the listview) as an external program.
well...the problem is outwhere I think. I can't see it when I select the 1st node in the TreeView (the complete list).

[Sharktooth]

uhm... try deleting the settings.xml file inside the megui installation folder
if it doesnt still show up delete also the autoupdate.xml file
or just reinstall megui in another dir

[Kurtnoise]

same problem...this link (http://mewiki.project357.com/auto/) is the correct one for the development ?

coz I can't select the web link...
http://img507.imageshack.us/img507/3312/meguiupdatewindow130920gj8.th.png (http://img507.imageshack.us/my.php?image=meguiupdatewindow130920gj8.png)

whereas they are listed in settings.xml. Weird...:s

next discussion about this issue here (http://forum.doom9.org/showthread.php?p=1044639#post1044639). :)

[Sharktooth]

no.. the autoupdate is located at http://megui.org/auto/ (dev) and http://megui.org/auto/stable/ (stable)
... however i cant see the servers too... but it updates regularly... damn bugs...

[saint-francis]

Yadif goes to the Avisynth plugin directory for me and then when there is a new update I get a message telling me that the path is incorrectly set for yadif.dll until I set it manually.

[Sharktooth]

yadif should not go to the avs plugin dir... nowhere in the code nor in the autoupdate there's something that tells megui to place it there...

[bob0r]

This is the dev server:
Trying server: http://mewiki.project357.com/auto/
Retrieving update file from server...

After restart:
Trying server: http://megui.org/auto/
Retrieving update file from server...

Nothing shows any update to yadif09.zip
Not even 0.2.6.1014

:)

[Sharktooth]

yeah... the mewiki is having troubles though...

[foxyshadis]

yadif should not go to the avs plugin dir...

Why not? It doesn't hurt anything, you just won't be able to autoload it. (Unless you also create an avsi to go alongside it that does nothing but load it.)

[saint-francis]

yadif should not go to the avs plugin dir... nowhere in the code nor in the autoupdate there's something that tells megui to place it there...

Then where should it go?

[Selur]

in a subfolder like e.g. avisynth/plugins/yadif

[Kurtnoise]

What about yadifmod instead ?

yadifmod v1.0 (http://bengal.missouri.edu/~kes25c/yadifmod_v1.zip). I've had this for a while, but never got it together for release. It is the same as Fizick's port, except that spatial predictions are taken from a user supplied clip. Also, it is not an Avisynth_C plugin. It works with YV12 and YUY2 input.

[Sharktooth]

yep, i think it will be much better just coz we can support it as an avs plugin instead of creating its own settings...

[Dark Shikari]

Just a reminder to the MeGUI devs that when my patches (http://forum.doom9.org/showthread.php?t=129842) are committed to the main x264 build, MeGUI will probably want to add options to support --me imh, --fpl-cmp satd, and --me-prepass (and tweak the more insane profiles to support them).

[Sharktooth]

np. post the request in the feature request tracker on SF along with both short and detailed descriptions of those options :)

[Kurtnoise]

well...the problem is outwhere I think. I can't see it when I select the 1st node in the TreeView (the complete list).
I think I found the problem...there is no yadif node in the upgrade.xml file. At least on this one (http://megui.org/auto/upgrade.xml)...:)

[Sharktooth]

??? what happened ???
i added it when berrinam added yadif to megui...

going to fix it...

EDIT: please check if it works now...

[Kurtnoise]

yes...works fine now.

10x

[Sharktooth]

i still cant understand why it wasnt there.
i clearly remember i've already added it...

[Kurtnoise]

@Sharktooth : about the #1797746 (http://sourceforge.net/tracker/index.php?func=detail&aid=1797746&group_id=156112&atid=798476):

Index: AviSynthAudioEncoder.cs
===================================================================
--- AviSynthAudioEncoder.cs (revision 215)
+++ AviSynthAudioEncoder.cs (working copy)
@@ -376,7 +376,58 @@
}
else
{
- _logBuilder.Append("Error:\n" + e.ToString());
+ // Better Errors Exception for Audio Encoders
+ int path_index = _encoderExecutablePath.LastIndexOf(@"\");
+ string audio_encoder = _encoderExecutablePath.Substring(path_index + 1).ToLower();
+
+ _logBuilder.Append("Error:\n");
+
+ if (audioJob.Settings is NeroAACSettings)
+ {
+ if ((audio_encoder != "neroaacenc.exe") || (audio_encoder != "neroaacencsse.exe"))
+ _logBuilder.Append(audio_encoder + " not found in the path...\n");
+ }
+
+ if (audioJob.Settings is OggVorbisSettings)
+ {
+ if (audio_encoder != "oggenc2.exe")
+ _logBuilder.Append(audio_encoder + " not found in the path...\n");
+ }
+
+ if ((audioJob.Settings is MP2Settings) || (audioJob.Settings is AC3Settings))
+ {
+ if (audio_encoder != "ffmpeg.exe")
+ _logBuilder.Append(audio_encoder + " not found in the path...\n");
+ }
+
+ if (audioJob.Settings is MP3Settings)
+ {
+ if (audio_encoder != "lame.exe")
+ _logBuilder.Append(audio_encoder + " not found in the path...\n");
+ }
+
+ if (audioJob.Settings is FaacSettings)
+ {
+ if (audio_encoder != "faac.exe")
+ _logBuilder.Append(audio_encoder + " not found in the path...\n");
+ }
+
+ if (audioJob.Settings is AudXSettings)
+ {
+ if (audio_encoder != "enc_audx_cli.exe.exe")
+ _logBuilder.Append(audio_encoder + " not found in the path...\n");
+ }
+
+ if (audioJob.Settings is WinAmpAACSettings)
+ {
+ if (audio_encoder != "encaacplus.exe")
+ _logBuilder.Append(audio_encoder + " not found in the path...\n");
+ if (File.Exists(encoder_path+"aac_encplus.dll") == false)
+ _logBuilder.Append("aac_encplus.dll not found in the path...\n");
+ if (File.Exists(Environment.SystemDirectory+@"\nscrt.dll") == false)
+ _logBuilder.Append("nscrt.dll must be in your Windows System directory...\n");
+ }
+
su.HasError = true;
raiseEvent();
}


ok to commit ?

[Sharktooth]

ok. keep in mind the audxsettings should be replaced by mp3surroundsettings once mp3surround gets fully integrated

[pimpMyHD]

Hi guys,

i use daily megui, and i must admit that if megui had been a commercial software, i 'd bought it.

As a .Net dev, i looked at the code. I can't help it ;-)
I must admit it is mostly well coded, but some .net/C# specifications or rules are not always respected.
for example, some abstract types have public constructors, raising some runtime reserved exceptions types , etc ... stuffs like that ...
There are no 'top of the todo list' stuff to change, but it could be fine to tweak some lines of code.

I know that managing a project do not make room to code quality, and time is mostly spend to optimizing features.



This is the only way i can help this incredible project, i do not have the video/audio processing knowledge to help more.

so ... if you agree ... if you are interested in it, i can correct what i think it should be.
I will post the sources if you will so.

regards.

[Sharktooth]

yes, any help is appreciated. if you have some experience with SVN, you can post unified diffs for latest code revision on the patches tracker (http://sourceforge.net/projects/megui) and we will gladly integrate them in the trunk. credits will be given in the megui changelog.

[pimpMyHD]

yes, any help is appreciated. if you have some experience with SVN, you can post unified diffs for latest code revision on the patches tracker (http://sourceforge.net/projects/megui) and we will gladly integrate them in the trunk. credits will be given in the megui changelog.
Ok, i will download the latest revision and start to look at the code. When i will ready to commit some code, i'll deal it with you ( just to be sure i'll commit the right way, in the right place).

[Sharktooth]

thanks

[pimpMyHD]

thanks
i tried to MP you, but it seems you need to make room in your mp mail box :D

[Sharktooth]

eh... my PM inbox is full on purpouse. however you can contact me by MSN email

[Fizick]

I do not like when my programs (Avisynth plugins) are distributed in stripped form (without documentation and source codes).

When you remove doc, you make user blind. He has no chance to learn how program work, what is additional options, who developed it, etc.

When you remove souce codes, you violate GPL license.


If you distribute GPL program binary, you must distribute its source too.

Here is part 3 of GPL license text:



3. You may copy and distribute the Program (or a work based on it,
under Section 2) in object code or executable form under the terms of
Sections 1 and 2 above provided that you also do one of the following:

a) Accompany it with the complete corresponding machine-readable
source code, which must be distributed under the terms of Sections
1 and 2 above on a medium customarily used for software interchange; or,

b) Accompany it with a written offer, valid for at least three
years, to give any third party, for a charge no more than your
cost of physically performing source distribution, a complete
machine-readable copy of the corresponding source code, to be
distributed under the terms of Sections 1 and 2 above on a medium
customarily used for software interchange; or,

c) Accompany it with the information you received as to the offer
to distribute corresponding source code. (This alternative is
allowed only for noncommercial distribution and only if you
received the program in object code or executable form with such
an offer, in accord with Subsection b above.)


Probably, if you downloaded some GPL binary WITHOUT source (for example Avisynth, which have separate source archive package), you may distribute it without a source too.

But if you downloaded some GPL binary WITH a source in one zip package, you must distribute whole package (with source),
or two packages (small without source codes and full with source code), from same place (server).

User must have info about license status of every "updated" programs and have option to get source codes for every distributed version of binary.

To be specific, I say here about Yadif.

[Sharktooth]

yeah, we know but we have limited traffic on our update server:(
however everything in the autoupdate is licensed under GPL.
since almost all the megui userbase is on this forum, they know yadif and other packages are somewhere here.
however the best thing we can do is to add a readme file with credits and links to the forum threads or websites containing the sources and docs, since distributing them would kill our traffic quota.

[Doom9]

But if you downloaded some GPL binary WITH a source in one zip package, you must distribute whole package (with source),Read the sections you have posted here again.. nowhere does it say that. As long as the offer or information on where to get the source code is there, it's perfectly okay.

Even as the author, you do not get to say which of the three mentioned methods is for you, and you cannot impose additional restrictions (such as which files must be kept from the archive).

While you are technically correct that there is a lack of license files for the individual applications that are being downloaded via autoupdate (plus the offer to get the source code or information on where to get the source code), I find it rather ridiculous to even suggest the authors of a software written from scratch and released under the GPL would not heed the obligations set forth by the license, when asked nicely. A "could it be that you forgot to include the license file and information on how to obtain the source code for software xy ;)", is imho a much more appropriate way to have this resolved - I consider throwing paragraphs around and trumped about GPL violations in public as a last resort and dare doubt that you had to go to such lengths.

[Fizick]

Sharktooth,
it will be first step in right direction.
Megui is quite mature project, and its distribution should be legal.
(And there are many users not from this forum.)

Doom9,
could it be that you forgot to include the license file and information on how to obtain the source code for software YADIF.
;)

(BTW, section C is not the case here.)

But what about removing docs?
It seems that I have got the most simple (stupid) questions from MeGUI users.
:)

[check]

The real problem with providing sources is keeping it up to date. Nobody will ever care about grabbing the files after this, and nobody will bother to update them. Better to simply link to the author's homepage on the MeWiki. I don't understand the GPL, is this an acceptable solution?

If not.... simple solution: provide a .zip file with all the sources and licences for all files in MeGUI. Then put it on all the update servers and put a link in the help menu to it (one that randomly selects an update server as per autoupdate). This is what the CCCP does after some similar drama to this.

[berrinam]

The problem with docs and extra files in general is that a lot of plugin writers name their doc/gpl files the same way: readme.txt and gpl.txt. This means that, since they all (except yadif, since it's an AviSynth_stdcall plugin) get extracted into the AVS plugins directory, they all overwrite each other and it's not clear what they refer to. Perhaps we should instead create a folder inside each zip and put the docs there, to avoid plugin "namespace" collisions.

I'm sorry about not including the license file and source code information in the autoupdate package. As Sharktooth said, we are trying not to make the downloads too big. Including the source code and license, the distribution is 6 times larger than with the plugin alone. However, I have now changed our distribution to include the following file, named "yadif_readme.txt":

The yadif.dll used in MeGUI is a port to AviSynth of MPlayer's YADIF (Yet
Another DeInterlacing Filter). The port is written by Fizick (Alexander
Balakhnin).

Yadif is licensed under GPL version 2; see
http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt for the license.

Source code, documentation, and the newest version of the plugin, can be
found at the plugin's homepage: http://avisynth.org.ru/yadif/yadif.html



-- berrinam

I hope that the URL of the GPL licence is acceptable; I didn't want to include the licence itself as it is actually larger than the plugin itself.

berrinam

[Fizick]

Please consider it is not as collision with Yadif or me.
I simply try understand base for commom practice (links only, as doom9 pointed).

When we discussed Avisynth legal base with IanB, he pointed, that many projects are at public sourceforge servers, and all may be considered as "same place":


If distribution of executable or object code is made by offering
access to copy from a designated place, then offering equivalent
access to copy the source code from the same place counts as
distribution of the source code, even though third parties are not
compelled to copy the source along with the object code.


berrinam, thanks, but you updated readme must aslo include Michael Niedermayer (http://www.mplayerhq.hu) in copyrigt notice

There are no need in 20 copies of GPL License file. :)

[Doom9]

@berrinam: I think we should have one readme file in the main directory, listing all software that can be downloaded, mentions their license (we already have the GPL text so it can just be referenced) and where to get the source code.

Also, technically, we ought to keep the source code of every revision that is put on the update server, for three years - but to do that, I think it would be appropriate to make use of the clause where a user can get the source code upon request for a fee - and that fee should be high enough to make people twice (after all.. the time is cost associated with distribution, too) - after all that's just what the fee clause is designed to - prevent you from becoming bogged down with people requesting the source just because they can, and especially for a volunteer GPL software making use of GPL tools only, it would be simply unreasonable if every user requested the source when clearly every project has a homepage where that source can be gotten without any hassle (especially if we provide links to each project's home).

[Kurtnoise]

@devs: about this issue (http://forum.doom9.org/showthread.php?t=126407)...

in debug mode, I get this:

http://img233.imageshack.us/img233/2572/meguidebug2409200718102ix0.th.png (http://img233.imageshack.us/my.php?image=meguidebug2409200718102ix0.png)

So, any idea about the last line error (unable to load DLL 'AvisynthWrapper' : the specified module could not be found) ?



These vista things annoys me frankly...

[Sharktooth]

there was a similar problem in the past. i think it was berrinam to discover the cause and fixed it updating avisynth wrapper.

[berrinam]

There was a problem with MediaInfoLib and Vista, and I uploaded a new library with a fix given to me by (from memory) moadib2k. But I don't think I've done anything with AvisynthWrapper, and I don't know what would be causing the problems. Dimzon wrote it; maybe he can give us some advice.

[Sharktooth]

you know, my memory is faulty...

[berrinam]

0.2.6.1015
- (berrinam) Nicer CQM selection for XviD and x264 (#1651251 and #1717536)

Odd choice, I know, but I felt like doing a bit of GUI details.