PgcEdit 0.5

[Guest]

DGIndex rejects that VOB because it does not have a sequence extension after the false sequence header, so it is seen as MPEG1, which is not yet supported.

Your version has older code that just skips over an emulated sequence header, instead of declaring MPEG1 and failing. But that code will skip only one false header!

It needs to be coded right, observing the system layer. I'll do that in a future release. For now, it is OK for you to restore the disabled code.

[jeanl]

Originally posted by neuron2
DGIndex rejects that VOB because it does not have a sequence extension after the false sequence header, so it is seen as MPEG1, which is not yet supported.

Your version has older code that just skips over an emulated sequence header, instead of declaring MPEG1 and failing. But that code will skip only one false header!

It needs to be coded right, observing the system layer. I'll do that in a future release. For now, it is OK for you to restore the disabled code.
OK I'll do that. Thanks! I'm afraid I won't be able to incorporate your fix unless your code is still close enough to the original that I can merge easily... Keep me posted if that's OK with you!
Thanks,
Jeanl

[2COOL]

@rolZ

When using the "go to calling command" feature, can you clarify the color coding of the found commands?

[blutach]

Originally posted by r0lZ
It's not related to the number of titles.

To be able to Clone the original PGC behaviour in the 'Import Title's Closing Clip' macro, the original commands are copied to a new PGC in the VMGM domain. Some commands (such as SetSTN, SetNVTMR) are illegal in the VMGM. Some commands (all Links, JumpVTS_PTT...) cannot be used from the VMGM to reach the target PGC.
If there are such commands in the original PGC, the Clone option is disabled, because it's impossible (or too difficult) to do. Aaah, yes I see that was the case withe my DVD. I simply took the SetSTN to before the jump to VMGM and all was fine.

Thanks for that :)

Regards

[blutach]

1. When I close PgcEdit with Alt-F4, it launches the tool defined by F4. In other words, the alt isn't being recognised. I confirmed this with alt-F1 etc.

2. When I select options - adjust command editor window screen, it changes the command editor to suit what can be changed. This is fine. But if I deselect it, I have to restart PgcEdit for the change to take effect.

Regards

[r0lZ]

Originally posted by blutach
1. When I close PgcEdit with Alt-F4, it launches the tool defined by F4. In other words, the alt isn't being recognised. I confirmed this with alt-F1 etc. Right. It's another Tcl/Tk problem/bug. I can't avoid it easily. Sorry.
[EDIT: Fixed. See my post below.]

2. When I select options - adjust command editor window screen, it changes the command editor to suit what can be changed. This is fine. But if I deselect it, I have to restart PgcEdit for the change to take effect. Strange. On my system, it works without restarting. Anyway, it's not verry important, as it's an option you will probably not change often.

[r0lZ]

Originally posted by 2COOL
@rolZ

When using the "go to calling command" feature, can you clarify the color coding of the found commands? ### Menu PGC command: Light green (RGB: 0xDDEEDD)
### Title PGC command: Light blue (RGB: 0xDDDDEE)
### Menu button command: Pink (RGB: 0xEEDDDD)
### BOV command: Light purple (RGB: 0xEEDDEE)
### Next/Prev/GoUpPGCN links: Light gray (RGB: 0xEEEEEE)

Following your request, I have also added a new "All" button in the search options to display all the matching commands in a window, in the same way. The colors will be the same, of course (minus the gray).
Note that this window will also display the commands found in menu buttons and BOVs. These commands are ignored if you use the << < > >> buttons. Furthermore, if you right-click the "All" button, the search is performed only in menu buttons and BOVs.

[r0lZ]

Originally posted by r0lZ
Right. It's another Tcl/Tk problem/bug. I can't avoid it easily. Sorry. Well, I've found a way to disable the tool associated with the F# key when using the Alt-F# key. So, the Windows system keys works now as expected.

[blutach]

Thanks r0lZ. Sorry to report such trivialities :)

Regards

[r0lZ]

Originally posted by blutach
Thanks r0lZ. Sorry to report such trivialities :) No, that's useful. I don't use the windows Alt-F keys myself, so I haven't discovered this problem. Thanks.

[2COOL]

Thanks r0lZ!

[doomer2]

I have found a dvd that has a menu with two programs in one pgc the VTSM domain. The menu buttons that are on the first program can be edited fine, but if the dvd is traced to where it would normally show the second program (with different buttons) the menu editor only shows the first program and buttons.

I can go into the pgc editor and look at the (video) contents of the second program, but I can't figure out how to make it let me view/edit the buttons in the second program of that pgc.

Using PgcEdit 0.5.5 (also tried with 0.5.1)

[jeanl]

Originally posted by doomer2
I have found a dvd that has a menu with two programs in one pgc the VTSM domain. The menu buttons that are on the first program can be edited fine, but if the dvd is traced to where it would normally show the second program (with different buttons) the menu editor only shows the first program and buttons.

I can go into the pgc editor and look at the (video) contents of the second program, but I can't figure out how to make it let me view/edit the buttons in the second program of that pgc.

Using PgcEdit 0.5.5 (also tried with 0.5.1)
At the top of the menu viewer, there's a drop down list that lets you access all the cells of the current PGC...
jeanl

[blutach]

In the menu edito, go up the top and click in the area that has the desciption (eg. VTSM 1, LU 1, PGC 3, PG 1, Cell 1, etc)

Regards

[jeanl]

Beat you to it blu!
J.:D

[blutach]

Yes, SNAP!

Regards

[doomer2]

Originally posted by jeanl
At the top of the menu viewer, there's a drop down list that lets you access all the cells of the current PGC...
jeanl

Aha, I missed that. Thanks!

[jeanl]

r0lZ,
I found a serious bug in jmp2pgc (0.5beta6) when you jump to a menu by bouncing off the root menu:

First play:

[00 B1 00 0B 00 00 00 03] 1 if ( gprm(11) != 0 ) then { Goto line 3 }
[30 06 00 01 04 83 00 00] 2 (JumpSS) Jump to VTSM 4, Root menu (TTN 1)
[00 00 00 00 00 00 00 00] 3 NOP
[71 00 00 07 00 00 00 00] 4 Set gprm(7) =(mov) 0
[30 06 00 02 00 C0 00 00] 5 (JumpSS) Jump to VMGM PGC 2

Root menu:

[20 A4 00 0F 00 00 00 06] 1 if ( gprm(15) == 0 ) then { LinkPGCN PGC 6 }
[71 00 00 00 00 01 00 00] 2 Set gprm(0) =(mov) 1
[71 A0 0E 0E 00 01 00 00] 3 if ( gprm(14) == 0 ) then { Set gprm(14) =(mov) 1 }
[71 B0 0F 0F 00 00 00 01] 4 if ( gprm(15) != 1 ) then { Set gprm(15) =(mov) 0 }
[20 A4 00 08 00 01 00 07] 5 if ( gprm(8) == 1 ) then { LinkPGCN PGC 7 }
....

Destination menu:

[00 B1 00 0B 00 00 00 0E] 1 if ( gprm(11) != 0 ) then { Goto line 14 }
[71 00 00 00 00 63 00 00] 2 Set gprm(0) =(mov) 99
[71 00 00 01 00 63 00 00] 3 Set gprm(1) =(mov) 99
[71 00 00 07 00 00 00 00] 4 Set gprm(7) =(mov) 0
....

Somehow, in the root menu code, you're using a different GPRM!!!! On the DVD I used it for, this yields a never-ending menu loop...
Jeanl

[r0lZ]

Oops! Will be fixed in final release! :o

[r0lZ]

PgcEdit 0.5.6 released.

A. = Added feature
F. = Fixed bug A. New semi-automatic macro "Jump to PGC upon DVD insert". It's a modified version of jeanl's "Jumping straight to the movie (or the menu) with PgcEdit" and 2COOL's "Jump2Pgc" guides.
A. Added "Swap or Copy Menu PGC" utility, to swap or copy the PGC parameters (cell table, color table, streams, VM commands, ...) from another PGC of the same menu domain with/to the current PGC. Useful to cleanup the menus.
A. Added the command "Delete All Commands in PGC" in the PGC Selector popup menu.
A. Added the utility "Delete All Commands in Domain", also available in the PGC Selector popup menu.
A. Added the function "Delete All Commands in DVD", available only by right-clicking on an empty line in the PGC Selector.
A. Added the utility "Blank out all Title PGCs in DVD", that calls the "Blank Out All PGCs in Domain" utility in sequence for all title domains.
A. Added an option to change the default colors of the GUI, requested by a Linux user.
A. Option "Skip Preview of short cells (< 1sec., without still time)?" in the preview configuration of the trace mode.
A. PGC Editor: Added an edit popup menu on the audio and subpic streams title label to copy and paste all audio or subpic streams assignments.
A. Added a button "All" in the search GUI, to display all occurences in a window. You may click on the buttons to jump to any occurence.
A. Added some icons for Linux users (included in the Zip archive), thanks to M7S.
F. PgcEdit_Preview 1.8 by jeanl. See history at the bottom of this file.
F. Fixed a little bug in Kill Playback macro that caused the display of an erroneous warning when killing the playback of a menu PGC with some cell commands (LinkTailPGC...)
F. A wrong path was used to store the configuration files on some Win XP foreign systems. Fixed.
F. Fixed a little problem when using an Alt-F# system key under windows: The tool associated with the F# key was launched instead.
F. Fixed a bug in the error message routine when a DVD cannot be opened successfully.
F. Fixed a rare bug in trace mode.
PgcEdit_Preview 1.8 by jeanl: Fixed a bug in original DVD2AVI code that caused the CELLID to be incorrectly read from the VOB file in some rare instances.
Enabled the original code to avoid an extremely rare problem where DVD2AVI finds a SEQUENCE_HEADER_CODE in the first navpack.Thanks to jeanl, 2COOL, blutach and Tobi for the beta testing of the difficult 'Jump to PGC' macro, and especially to jeanl and 2COOL for their guides.

Have a look at the PgcEdit's homepage. Some new or updated guides are there, too.

[blutach]

Many thanks r0lZ. I'm sure I speak for thousands.

Regards

[dirio49]

thanks r0lZ

[absinthe]

WOW! Very nice. I got the "Jump to PGC upon DVD insert" macro to work on the first try. It's a breeze.

Thanks r0lZ!

-abs

[2COOL]

Request:

In your next version, can you put a right-click in Watch dialog for a small menu consisting of the trace's clipboard macros and also unused GPRMs? I'd like to consolidate all these in one place for easy of clicking flow.

BTW, great work! :D

[r0lZ]

For Linux users!

mfc42.dll is missing from the binary distribution v0.5.6 for Linux. For this reason, the preview doesn't work.

You may either
1. Download the fixed pgcedit binary file v0.5.6.1 on my homepage (available for Linux only).
2. Download mfc42.dll here (http://www.dll-files.com/dllindex/dll-files.shtml?mfc42) and copy it manually in the bin subdirectory.

Sorry.

[r0lZ]

Originally posted by 2COOL
Request:

In your next version, can you put a right-click in Watch dialog for a small menu consisting of the trace's clipboard macros and also unused GPRMs? I'd like to consolidate all these in one place for easy of clicking flow.

BTW, great work! :D I'm not sure it's easy to do, because the Watch window is build dynamically (you may add or remove parts of the window). I can't promise it...

BTW, geeat work to you too! Your Jump2pgc guide and helper application were of great help when I wrote the macro. Special thanks for your idea of testing all registers when no unused register exists. (I will probably use it also in the Inport * Clip macros.)

[selyb]

Request: if i am in trace mode and i open a new dvd, i would like pgcedit to automatically exit trace mode

Request: not sure if you can do this but, when i paste an illegal command, could you try to convert it?

what i run into often is when in the VMGM, i replace a command 'Jump to Title X" with all the commands located in Title X and those commands have "Call VMGM PGC X" and i have to manually convert each one to "Link PGC X"

[selyb]

Request:
when i have modified the dvd and i hit close, could you make it ask if i want to save before quitting and use a yes\no\cancel box

[jeanl]

Originally posted by selyb
Request:
when i have modified the dvd and i hit close, could you make it ask if i want to save before quitting and use a yes\no\cancel box
This is the default behavior when not in "expert mode"... Disable expert mode if you want that...
Jean

[2COOL]

Maybe some people would like to have the option to not see the hex values in the command pane?

[r0lZ]

Originally posted by 2COOL
Maybe some people would like to have the option to not see the hex values in the command pane? This has been already asked. Unfortunately, I need the hex codes with the commands, because much of the edit buttons are working directly on the listbox contents. When another PGC is opened, the commands are saved back in memory, and I need the hex codes to retrieve them from the listbox.

[r0lZ]

Originally posted by selyb
Request: if i am in trace mode and i open a new dvd, i would like pgcedit to automatically exit trace mode It's really easy to close it yourself, no?

Request: not sure if you can do this but, when i paste an illegal command, could you try to convert it?

what i run into often is when in the VMGM, i replace a command 'Jump to Title X" with all the commands located in Title X and those commands have "Call VMGM PGC X" and i have to manually convert each one to "Link PGC X" That's not easy to do. However, I will try to verify the commands in a better way. Maybe I'll be able to add a conversion, too. But don't expect that soon. I have many other things on my TODO list.

[r0lZ]

Originally posted by selyb
Request:
when i have modified the dvd and i hit close, could you make it ask if i want to save before quitting and use a yes\no\cancel box Also easy to do manually. Just click Cancel, and hit the Save icon.
But, as it's easy to do for me, I may add it...

@jeanl: selyb wants a save option integrated in the warning dialog.

[selyb]

Originally posted by selyb
Request:
when i have modified the dvd and i hit close, could you make it ask if i want to save before quitting and use a yes\no\cancel box

in pgcedit.tcl i changed if {$::dvd_modified && $code == 0 && !$::config(expert_mode)} {
set r [tk_messageBox -message "The DVD has been modified.\n\nOK to quit?" \
-icon warning -title "PgcEdit" -type yesno -default no]
if {$r == "no"} return
}
to if {$::dvd_modified && $code == 0 && !$::config(expert_mode)} {
set r [tk_messageBox -message "The DVD has been modified.\n\nDo you want to save first?" \
-icon warning -title "PgcEdit" -type yesnocancel -default yes]
if {$r == "cancel"} return
if {$r == "yes"} {::main::Write_DVD false}
}

and in main.tcl and utils.tcl i changed if {$::dvd_modified && !$::config(expert_mode)} {
set r [tk_messageBox -message "The DVD has been modified.\n\nAre you sure?" \
-icon warning -title "PgcEdit" -type yesno -default no]
if {$r == "no"} {return 0}
}
to if {$::dvd_modified && !$::config(expert_mode)} {
set r [tk_messageBox -message "The DVD has been modified.\n\nDo you want to save first?" \
-icon warning -title "PgcEdit" -type yesnocancel -default yes]
if {$r == "cancel"} {return 0}
if {$r == "yes"} {::main::Write_DVD false}
}

[selyb]

Originally posted by selyb
Request: if i am in trace mode and i open a new dvd, i would like pgcedit to automatically exit trace mode



in main.tcl i added
if {$::tr::tracemode} ::tr::dvd_trace
immediately afterproc Read_New_DVD {args} {

if {$::dvd_modified && !$::config(expert_mode)} {
set r [tk_messageBox -message "The DVD has been modified.\n\nDo you want to save first?" \
-icon warning -title "PgcEdit" -type yesnocancel -default yes]
if {$r == "cancel"} {return 0}
if {$r == "yes"} {::main::Write_DVD false}
}

if {$args == ""} {
unset -nocomplain ::tr::breakpoints ;# reset breakpoints of Trace mode
set initialdir $::config(initialdir)
while true {
set dvddir [tk_chooseOldDirectory -initialdir $initialdir \
-parent . -title "PgcEdit: Open DVD folder"]
if {$dvddir == ""} return


and in trace.tcl i changed set ::tr::wm_main_window $w
if {[winfo exists $w] && [winfo ismapped $w]} {
cleanexit
return
}

to set ::tr::wm_main_window $w
if {[winfo exists $w] && [winfo ismapped $w]} {
cleanexit
return
} else {set ::tr::tracemode 1}

[jeanl]

selyb,
I think you're the first one to starting hacking into PgcEdit!
Amazing!
Jeanl

[r0lZ]

I have added some similar code in the new version, to save if needed before quitting/opening a new DVD. However, your method will ask to save the DVD if you reopen it. IMHO, it is not useful in this case.

Also, my method to open trace mode is identical to yours, except I have suggested to set the code in pgcedit.user.tcl (which is a post script opened automatically if it exists after the whole initialization was done) because it doesn't require to recreate the standalone exe.
Since this feature seems to be appreciated, I will add an option to automatically go to trace mode whan a DVD is opened, in the Options menu.

[selyb]

Originally posted by jeanl
selyb,
I think you're the first one to starting hacking into PgcEdit!
Amazing!
Jeanl i wouldnt call editing an open source script 'hacking', but thanks for the props anyway :)

Originally posted by r0lZ
I have added some similar code in the new version, to save if needed before quitting/opening a new DVD. However, your method will ask to save the DVD if you reopen it. IMHO, it is not useful in this case.

i noticed this, i was in the process of trying to figure out how to change that

Originally posted by r0lZ

Also, my method to open trace mode is identical to yours, except I have suggested to set the code in pgcedit.user.tcl (which is a post script opened automatically if it exists after the whole initialization was done) because it doesn't require to recreate the standalone exe.
Since this feature seems to be appreciated, I will add an option to automatically go to trace mode whan a DVD is opened, in the Options menu.

what i added was to quit trace mode when opening a dvd, i understand what youre saying though

[r0lZ]

Originally posted by selyb
i noticed this, i was in the process of trying to figure out how to change that In main.tcl, function ReRead_DVD, insert dvd_modified false false before the line set errcode [Read_New_DVD $::dvddir]or wait for the next version. ;)

[selyb]

btw, the reason i added set ::tr::wm_main_window $w
if {[winfo exists $w] && [winfo ismapped $w]} {
cleanexit
return
} else {set ::tr::tracemode 1} in trace.tcl is because of a small cosmetic bug
if you use ctrl+t to open trace mode, the tracemode variable does not get set and the checkmark on the menu is not present

i found this out because i use that variable as a check to see if i need to call dvd_trace

[r0lZ]

Right. I have also added this variable assignment in the final version.

[selyb]

Originally posted by r0lZ
In main.tcl, function ReRead_DVD, insert dvd_modified false false before the line set errcode [Read_New_DVD $::dvddir] this would omit a dvd modified message entirely if you hit the reopen button wouldnt it?
maybe you could also add a message to 'proc ReRead_DVD' to ask "Are you sure you want to Reopen the DVD and lose all changes?"

[r0lZ]

That's what I did. :)

[r0lZ]

PgcEdit 0.5.7 beta 1 available.

It's not an important release. I've just made some cosmetics changes, including an option to hide the hex codes in the main window. Since this option was not easy to implement, I may have broken something. So, use this beta with care, and, if you experience some problems, please report them here. Thanks.
A. Added an option to hide the [hex codes] in the main commands listbox.
A. Added an option to go automatically to Trace mode whan a DVD is opened.
E. The "DVD modified, are you sure?" warning now allow to save the DVD.
F. Fixed a typo: changed all occurences of sheme to scheme.
As usual, the beta is in the 'All Versions' folder of the PgcEdit homepage at VideoHelp only.

[zacoz]

Originally posted by r0lZ
... cosmetics changes, including an option to hide the hex codes in the main window. @r0lZ: You just can't resist a challenge can you.

I'd figured "Sheme/Scheme" had actually been shortened to fit on the button. While on the subject, the IFO File Association dialog box uses the word "overwrited". English grammar would dictate that "overwritten" would be correct.

[selyb]

Originally posted by r0lZ
PgcEdit 0.5.7 beta 1 available.

...
As usual, the beta is in the 'All Versions' folder of the PgcEdit homepage at VideoHelp only.

:( i dont see it

[r0lZ]

Right. My fault. I have moved the beta files in the right directory now.

@zacoz and everybody: BTW, if you find more english grammar/vocabulary errors in PgcEdit, please let me know.

[Surf]

One lil request r0lZ: implementing a BMP capture with choice of ntsc/pal, 4:3 or 16:9...TIA.

edit: ntsc/pal is irrelevant..is it?

[r0lZ]

The captured image is always in the original format of the VOB, without any modification or resizing. If your VOB is NTSC, you will capture a NTSC frame. Same for PAL.
Note that a 16:9 anamorphic image has exactly the same resolution as a 4:3 image. It is the responsability of the player to resize it. So, all images you will save with PgcEdit will be 4:3 images.

I will not change that. If you want to convert the image to another format, resize it with a paint program. You will be able to use the best antialiazing method for the current image.

[selyb]

Originally posted by r0lZ
@zacoz and everybody: BTW, if you find more english grammar/vocabulary errors in PgcEdit, please let me know. Current- Store PgcEdit_backup in the DVDs root folder instead of VIDEO_TS
Suggested- Store backup folder in parent of VIDEO_TS folder

Current- Adjust Command Editor window size
Suggested- Auto-adjust Command Editor window to contents

Current- Tearoff menus?
Suggested- Allow Menu Tearoffs.

Current- Highlight Errors and GOTO Targets? (Don't Detect All ERRORS!)
Suggested- Hi-lite Errors and GOTO Targets? (Doesn't Detect All ERRORS!)

Current- Popup menus on right mouse button released?
Suggested- Popup menu when right mouse button released?
or Popup menu on right mouse button release?

Current- Automatically renumber GOTOs upon cmds insert/delete?
Suggested- Auto renumber GOTOs when cmds added/removed?

Current- Save Setups
Suggested- Save Settings