PgcEdit 0.5

[r0lZ]

Originally posted by selyb
that delay works beautifully :) Thanks for the feedback!

BTW, I have verified the way I have implemented the Open DVD Folder function: I was unable to call the start function. For an unknown reason, it doesn't work from Tcl/Tk. So, I've made a direct call to explorer.exe. Sorry. As I said, use the Tools menu...

[blutach]

Right now, the Utility -- New dummy PGC doesn't work if there's only a FP PGC. So, I can't add VMGM 1 etc.

Is this intentional?

BTW: The remove commands and links works great!!!

Regards

[r0lZ]

No, it's not intentional. I've already noticed this problem, but since you will add some VTS anyway, I haven't fixed it.

[EDIT] Wrong! The new Dummy PGC can't work on the FP-PGC, but you may add a VMGM PGC 1 with the New Menu function.

[blutach]

I already have some VTSs - e.g your Test SPRM7 disk!

EDIT - OK on your edit.

Regards

[selyb]

Originally posted by r0lZ
I was unable to call the start function. For an unknown reason, it doesn't work from Tcl/Tk. So, I've made a direct call to explorer.exe that may be because 'start' is a command line option for cmd.exe
i have never seen 'start' used otherwise

[lark]

Originally posted by selyb
that may be because 'start' is a command line option for cmd.exe
i have never seen 'start' used otherwise

sorry, but i have to comment this:
i've seen 'start' used to shutdown windows :) :p :D

btw, r0lZ, thx a 1000000 for the new release w/ option to remove the VM commands of the unreferenced cells.

regards
t :)

[blutach]

@lark - very good! Maybe it's the Start of the finish!

Regards

[CoNS]

...Or the end of the beginning...?!! :D

[blutach]

Just thinking here:

If we find a menu that is unreffed and can take its VM commands out, why can't we make it a dummy at the same time (if it has video in it), letting the user know he has to do a menu strip. Once the menu buttons (if any) are out of the way, this could lead to more unreffed material being stripped clean.

I have actually been able to trim a 7 VTS disk down to 1 doing this (ultimately needing, of course to play with things like VMGM_MAT, VMG_PTT_SRPT and VMG_VTS_ATRT), but that is not hard.

There was a guy the other day who actually wanted to do this on his backups to keep things "neat" IIRC.

Regards

[r0lZ]

Good idea, blu.
I'll add it soon...

[blutach]

First good idea I've had for months! Or so my finacee tells me.

Morning r0lZ and thanks.

Regards

[r0lZ]

WARNING! I've found a bug in 0.5.2 (final release only) and 0.5.3 beta 1.

If you create a new button or BOV in a cell originally without buttons, the new button(s) will be saved only in the first nav pack of the cell, while it should be saved also in all subsequent nav packs. Your button will be shown only for a verry short time, and then disappear.

This bug is fixed now. I will release a nev version soon...

Thanks to Pil who submitted this bug via private email.

[lark]

would it be hard to detect PGCs that are only referenced by themselves (and delete commands from those as well)?

regards
t :)

[r0lZ]

It's already the case, no?
Normally, the commands jumping inside the same PGC are ignored (unless there is a bug somewhere).

[r0lZ]

PgcEdit 0.5.3 beta 2 is here. (Third release in two days! Sorry.)

It fixes the important bug with the new buttons on cells originally without buttons.
This bug was introduced because I wanted to keep the original highlight status whenever possible, so that animated highlights are not lost after a save cell with edited menu buttons.
But I kept the original status of 0 when a new button was created on a cell w/o buttons. In this case, the HL status is now 1 in the first nav pack of the cell, and 2 in all subsequent packs, as it should be.

I have also added the option to convert unreferenced menu PGCs to dummies when using the Info -> Calls Cross References function. Note that the GUI will be visible only if there are unreferenced menu PGCs with video, and if you accept the 'delete commands' option.
Take care: cells with menu buttons will be converted to dummies as well.

[lark]

Originally posted by r0lZ
It's already the case, no?
Normally, the commands jumping inside the same PGC are ignored (unless there is a bug somewhere).
i'm not 100% sure but i think i just had a dvd that had many PGCs (not marked as unreferenced) having only linktailpgc pointing to them. when i deleted that command, pgcedit deleted the rest ;-)
but obviously it was pinta to delete those commands from 50+ PGCs...

regards
t :)

[r0lZ]

I've just tried with a PGC with a LinkTailPGC in post commands, and another one as cell command 1. It is correctly marked as unreferenced.
Don't forget that a PGC may be referenced if there are Next/Prev/GoUpPGC links pointing to it in another PGC, or if it's a PGC callable with the remote (ie root, title, subpic menu entry...)

If you still encounter a bug, please send me the Call Cross Refeerences output.

[blutach]

Thanks for the fix r0lZ and the enhancement to the unreferenced material "wipe". One final thought about wiping unreffed material.

If a GPRM is used only once I think it can be safely deleted. Oftentimes, you see authoring remnants that say someting like If gprm(7) <> 0 then jump to a PGC which is otherwise unreferenced and usually has no commands in it. This command, of course, can never be executed as it is the only time gprm(7) is used.

So, can PgcEdit find GPRMs that are only used once and delete the commands, too?

Regards

[r0lZ]

That's a totally different method. I need to inspect every command in the DVD (including in menu buttons) before calling the actual Call Cross Refs function. It's a big work. Please remind me later...
For now, I want to implement the preview for Linux.

[blutach]

Final Q then off to bed:

If I have done an incremental backup, how does one restore from the old backup (the original one now marked with the date and time)? This is a manual job, yes?

Regards

[blutach]

Originally posted by r0lZ
That's a totally different method. I need to inspect every command in the DVD (including in menu buttons) before calling the actual Call Cross Refs function. It's a big work. Please remind me later...
For now, I want to implement the preview for Linux. OK, never mind - I would not want to slow down the calls cross refs function just for this. I suppose it is easy to delete manually anyway.

Regards

[r0lZ]

Originally posted by blutach
Final Q then off to bed:

If I have done an incremental backup, how does one restore from the old backup (the original one now marked with the date and time)? This is a manual job, yes?

Regards For now, yes. In fact, I assume that you do an incremental backup when you have successfully modified the DVD, but you want to do something more, potentially dangerous.

But I may implement a 'remove backup' option when the current backup is restored. In this case, the current backup will be restored, and deleted, and the last incremental backup will be renamed to be the current backup again. You will therefore be able to restore it from PgcEdit.

Note that the VOB files in the backup folders are never restored automatically. So, even with a single backup, you may have to restore it manually.

[lark]

Originally posted by r0lZ
I've just tried with a PGC with a LinkTailPGC in post commands, and another one as cell command 1. It is correctly marked as unreferenced.
Don't forget that a PGC may be referenced if there are Next/Prev/GoUpPGC links pointing to it in another PGC, or if it's a PGC callable with the remote (ie root, title, subpic menu entry...)

If you still encounter a bug, please send me the Call Cross Refeerences output.

in my case LinkTailPGC was a cell command.

i just sent you all the dvd commands as pm.

regards
t :)

[selyb]

Originally posted by lark
sorry, but i have to comment this:
i've seen 'start' used to shutdown windows :) :p :D
could you please explain in more detail?

[lark]

ever seen the small icon with text "start" in windows?
it's usually in the lower left corner.
when you click it, there's a menu and 1st item in the menu says 'Shut Down'. obviously these can be a bit different in some systems depending on language and other settings.... :D :D :D

regards
t :)

[lark]

coming back to the self-referenced PGCs...

in my case the pgc was part of TTN1 and there was really only LinkTailPGC cell command referencing it. as r0lZ pointed out (in PM) it could be callable even if there are no explicit jumps to the PGC.

now this is actually getting academic:
what i was wondering, why pgcedit doesn't consider it as unreferenced, when there's that LinkTailPGC? but as soon as that one is deleted, it will be suspect as unreferenced. so the logic is a bit weird ;-)

in my case the TTN1 contained a dozen PGCs and i knew they are not referenced since i had deleted the jump from vmgm. then i wanted to delete all vm commands from the vts so that it would be easier to find out, who (if any) are setting certain registers.

that actually takes me to another feature request:
it would be nice to have 'delete all vm commands' in the context manu, when a PGC is right-clicked.

regards
t :)

[r0lZ]

Originally posted by lark
ever seen the small icon with text "start" in windows?
it's usually in the lower left corner.
when you click it, there's a menu and 1st item in the menu says 'Shut Down'. obviously these can be a bit different in some systems depending on language and other settings.... :D :D :D

regards
t :) You're kidding, I suppose. The start DOS command has nothing to do with the start menu. ;)

BTW, to launch explorer from Tcl/Tk, I tried to 'exec' this line:
cmd /c start "foldername"
but it doesn't work.

[lark]

Originally posted by r0lZ
You're kidding, I suppose. The start DOS command has nothing to do with the start menu. ;)

sure i know, that's why the smilies where in the 1st post...
sorry, if i caused some confusion.

regards
t :)

[r0lZ]

Originally posted by lark
coming back to the self-referenced PGCs...

in my case the pgc was part of TTN1 and there was really only LinkTailPGC cell command referencing it. as r0lZ pointed out (in PM) it could be callable even if there are no explicit jumps to the PGC.

now this is actually getting academic:
what i was wondering, why pgcedit doesn't consider it as unreferenced, when there's that LinkTailPGC? but as soon as that one is deleted, it will be suspect as unreferenced. so the logic is a bit weird ;-)

in my case the TTN1 contained a dozen PGCs and i knew they are not referenced since i had deleted the jump from vmgm. then i wanted to delete all vm commands from the vts so that it would be easier to find out, who (if any) are setting certain registers.

that actually takes me to another feature request:
it would be nice to have 'delete all vm commands' in the context manu, when a PGC is right-clicked.

regards
t :) I'm not sure that a PGC belonging to a multi PGC TTN may be called without an explicit call. But I am sure that you cannot delete the PGC safely, because the chapter number(s) defined in the removed PGC will point to nowhere. So, for safety purposes, I don't want to delete the commands in these PGCs automatically.
Anyway, it is also possible that there is a bug in the Cross Refs function: maybe only the first PGC of the multi PGC TTN is considered to be unreferenced.

I will add a 'Delete commands' entry in the Edit (and therefore also popup) menu. It's easy!

[lark]

ok. thx.
t :)

[selyb]

Originally posted by lark
ever seen the small icon with text "start" in windows?
it's usually in the lower left ...
http://www.selyb.com/smile33.png

@rolz, when i get the chance, ill try to install tcl/tk on my machine and see if i cant help out maybe

[lark]

there seems to be a typo in the menu buttons warning dialog.
Don't thrust the button viewer in this case!
i guess it should be trust ;-)

regards
t :)

[lark]

i just used import title's closing title for the very 1st time and it didn't copy the cell commands. should it?

in my case there are 2 cells and the 1st has linktailpgc as cell command. obviously it works fine w/o, but makes me wonder, should those be copied as well? i know that in some cases they can make more harm than good...

regards
t :)

[blutach]

I have found that it is not necessary to have these copied. The closing clip plays and then goes back to VMGM then back eventually to the root menu.

Regards

[r0lZ]

Indeed, the commands are created by PgcEdit. None of them are retained from the original PGC.

BTW, typo corrected. (It was not a typo, but an error!)

[lark]

i know that the post command is generated by pgcedit,
but what i was talking about was the CELL command...

my original title had 2 cells and 1st of them had this cell cmd
[20 01 00 00 00 00 00 0D] 1 LinkTailPGC

title copied to be "title's closing clip" obviously had also 2 cells and 1st of them was configured to have cell command 1, but the actual PGC didn't have any cell command and thus the cell was referring to non-existing cell command!
well, it worked fine with SW player. haven't tested with HW.

regards
t :)

[r0lZ]

The last cell is probably a verry short one (a single black frame).
The LinkTailPGC is not needed, as it simply bypasses this last frame.

Leaving a cell command number pointing to nothing is normally harmless. Of course, you may delete it, or add the post command yourself.

[lark]

thx for quick reply.
that's what i was thinking as well (yes, 2nd cell is just to enable skipping to the end),

but the question is, should pgcedit already remove the 'link' to cell command (if it removes the actual command)?
or should it at least inform the user to check / manually correct the situation?

regards
t :)

[blutach]

@lark

Are you sayingthe macro killed the cell command/command number in the ORIGINAL TTN PGC or just did not reproduce it in the new title?

I would think that the cell command in the original PGC should have been retained.

Regards

[r0lZ]

I don't touch anything in the original cell: the IFO is not saved.

Indeed, in the imported title, either I have to keep the original command, or it should be better to remove the cell command number in the cell table. But, as I said, it is harmless.

Maybe I'll add this in the next version...

[r0lZ]

PgcEdit 0.5.3 released

It's principally a bugfix release. Please download it!
Added an option in Info -> Calls Cross References do delete the commands in the unreferenced PGCs, and to clear the Prev/Next/GoUpPGC links. May be used to find more unreferenced PGCs in subsequent calls to the Calls Cross References function. Also, another option allow to convert unreferenced menu PGCs to dummies, to easily blank them with VobBlanker.
Added "Delete All Commands" in the Edit (and popup) menu.
Important bug in v0.5.2 fixed: new buttons created in a cell originally without buttons/BOVs were saved only in the first nav pack of the cell.
PgcEdit was unable to parse the VTSM_C_ADT table if the table was present, but with no entries defined in the table. Fixed now.
Fixed a bug in the parsing of the VTS_C_ADT table, occuring in rare circumstances: a wrong Nav Pack number was read, causing the search for menu buttons or BOVs to fail.
Inport First-Play/Intro/Closing Clip: The cell commands numbers of the imported title are now forced to 0 in the cell playback table.
Added a little delay when the Open DVD/Save DVD file requester is closed, to avoid a little Tk bug.

[lark]

Originally posted by blutach
Are you saying the macro killed the cell command/command number in the ORIGINAL TTN PGC or just did not reproduce it in the new title?


i tried to say that the macro retained the cell command number in the cell playback table, but removed (didn't reproduce) the actual cell command. obviously the clip worked fine.

just looking at r0lZ's announcement, i think this should have been taken care of and the cell command number in the table will be 0 (haven't tried yet, but i'll t(h)rust my master's voice).
thx a 1M.

regards
t :)

[r0lZ]

Originally posted by lark
t(h)rust :angry:
my master's voice :) That's better! ;)

[CoNS]

Originally posted by r0lZ
Also, another option allow to convert unreferenced menu PGCs to dummies, to easily blank them with VobBlanker.Will the execution of this function resolve the reallocation error in Nero, in the cases where the error is caused by the presence of empty menu PGCs (no buttons, the playback time is shown as 0:00 and not marked as dummy PGCs)?

[r0lZ]

Originally posted by CoNS
Will the execution of this function resolve the reallocation error in Nero, in the cases where the error is caused by the presence of empty menu PGCs (no buttons, the playback time is shown as 0:00 and not marked as dummy PGCs)? I don't think so.

The Nero reallocation error occur when there is a VOB totally unreferenced in the IFOs. In this case, you may safely delete it. (But keep a backup!)
Also the error occur when the VOB size is 0 bytes. This problem is already identified by PgcEdit, and can be easily fixed.
The same error may occur if there are inconsistencies in the IFOs. In some cases, PgcEdit will fix them when savind the DVD. But in some cases it will not.

In the case of a non-dummy PGC with a 0:00 PB time, there muts be a cell referenced in the IFO. The cell is most of the fime a single, black frame (henced the timing displayed in the PGC selector). But that is perfectly normal, and, IMHO, doesn't produce the Nero error.

The problem with this nero error is that it is not verry descriptive. You cannot easily guess what caused it.

Anyway, since I burn my DVDs with PgcEdit, mkisofs and DVD Decrypter, I have never experienced that error, and all my burns are recognized by my players.

Of course, if you can, send me a small DVD which cause that nero error, and I will see what I can do...

[lark]

i'm afraid 0.5.3 broke the import closing clip.
at least i'm getting this error
syntax error in expression "$c < $::pgcs(numvts),1,numcells)": extra tokens at end of expression
syntax error in expression "$c < $::pgcs(numvts),1,numcells)": extra tokens at end of expression
("for" test expression)
while compiling
"for {set c 0} {$c < $::pgcs(numvts),1,numcells)} {incr c} {
set_int ::pgcs($::pgcs(numvts),1,cellpbtable) [expr {($c * 24) + 3}] 0 1
}"
(compiling body of proc "::macros::import_title_closing_clip", line 356)
invoked from within
"::macros::import_title_closing_clip"
(menu invoke)


it still worked with 0.5.2 b2.

<why does code show smilies?>

regards
t :)

[jeanl]

Originally posted by lark

<why does code show smilies?>

it's laughing at us:devil:! I hate that! :D
jeanl

[r0lZ]

Originally posted by lark
i'm afraid 0.5.3 broke the import closing clip.
at least i'm getting this error
syntax error in expression "$c < $::pgcs(numvts),1,numcells)": extra tokens at end of expression
syntax error in expression "$c < $::pgcs(numvts),1,numcells)": extra tokens at end of expression
("for" test expression)
while compiling
"for {set c 0} {$c < $::pgcs(numvts),1,numcells)} {incr c} {
set_int ::pgcs($::pgcs(numvts),1,cellpbtable) [expr {($c * 24) + 3}] 0 1
}"
(compiling body of proc "::macros::import_title_closing_clip", line 356)
invoked from within
"::macros::import_title_closing_clip"
(menu invoke)


it still worked with 0.5.2 b2.

<why does code show smilies?>

regards
t :) Right!
I will upload a bugfix immediately.

Smilies: When posting, enable the "Disable the smilies in this post" checkbox.
Of course, smilies should not appear in CODE sections. It's a Doom9 bug! ;)

[r0lZ]

PgcEdit 0.5.4 released.

Fixes the bug in Import Startup/Intro/Closing Clip macros, introduced in v0.5.3.

Also, there is a new PgcEdit_preview executable, by jeanl. Not a verry important improvment, but it's the first step to implement the preview under Linux (and maybe also under Mac OSX).

New PgcEdit_preview v0.7: with option to turn off the usage of DirectDraw overlays to show the preview, and an option to save the menu backgrounds as PPM instead of BMP (internal use only!)
Added "Preview -> Disable DirectDraw Overlays" (Windows only) option. On some systems, it may be faster to turn off the DirectDraw overlay display.
Shift-clicking on the "BMP" button in the preview window allow to save an image in PPM format.
Inport First-Play/Intro/Closing Clip macros were broken in 0.5.3. Fixed.

[blutach]

Man, I went to bed and missed a whole release!

Regards