AssFilterMod - DirectShow subtitle renderer (v0.4)

[CCat]

what do you mean with MPC-HE? BE or HC and more important is if the spacing is correct or not.
if this was the newest MPC-HC i will ask kasper about this if the bigger spacing is correct
Ah, so it's about the spacing. I meant to write MPC-HC (newest nightly), sorry.
I just tested XySubFilter as well and it also has the bigger spacing, so VSFilter/ISR seems to be the odd one out in that regard.

i've made more test than you can count lyrics but I can't reproduce the problem so if you went to be kind give ASS file not your suggestions
But it's right there, Jtacdf posted a link to a said problematic file (https://forum.doom9.org/showthread.php?p=1799274#post1799274) and that's what I've been using.
Or did you test that already when you say you cannot reproduce the problem?

The scene where the screenshots with spacing differences come from is at the 00:46.462 to 00:52.636 timemark, but you should see it everywhere.

Ok, the thing is that i used an experimental build of libass in thoses harfbuzz releases (...) [which] uses a new stroker that correct issues with some fonts but it seems to introduce unwanted artifacts.
Ah, that's good to hear, because that means it's not a direct issue with harfbuzz. Makes me wonder though if the problem is more of the side of the stroker or of the side of the fonts, maybe there's a reason that there are seemingly random points in those kanji glyphs, but to a layman's eye those look like errors.

[Jtacdf]

Here is another problematic file that does not play nice with AssFilterMod v0.1, 0.2, 0.3. Probably related to libass.
https://mega.nz/#!UsR1AIoC!jqweOJhzWdcfftb2uAxde-XI6og5V3zV3NjC7mv34Uc

With the default heavy Kfx ass file, the front/end of each karaoke sentence display as transparent and seems "chopped" off. There is also some misalignment of the white fill fx. Works fine with XySubFilter and MPC-HC/BE ISR.

[CCat]

Here is another problematic file that does not play nice with AssFilterMod v0.1, 0.2, 0.3. Probably related to libass.
That seems to be an issue with "@ fonts", the OP Romaji style uses "@A-OTF CapieN Std B" as a font.
From what I know, the "@" is supposed to flip (certain?) kanji on it's side, which has uses in vertical writing I believe, but in this case it seems to also shrink the size of the font, here's a comparison out of Aegisub (xy-VSFilter):
https://i.imgur.com/7niTEMQ.png
If you change the subtitle provider to libass, both fonts are of the larger size, which is the cause for what you're seeing.
The OP was designed with (xy-)VSFilter in mind, so the larger font gets cut off on the sides by \clips (which are used for colored stripes in the text) and because the white fx was generated to fit on the smaller font, it's misaligned.

[clsid]

A bug report:
https://trac.mpc-hc.org/ticket/6132

[Blitzker]

A bug report:
https://trac.mpc-hc.org/ticket/6132

Interesting bug. It seems that windows doesn't play nice with UTF-8 filenames. I've made a little hack in libass to support loading of UTF-16 filenames and it seems to work.

I'll release it when i've made more testing of different UTF-8 strings.

[nevcairiel]

Interesting bug. It seems that windows doesn't play nice with UTF-8 filenames. I've made a little hack in libass to support loading of UTF-16 filenames and it seems to work.


Thats how it is, Windows is internally all UTF-16 (ie. wchar_t), and file access should convert to that, the plain char APIs don't take UTF-8, only plain ASCII. MultiByteToWideChar is what you want to use to go from UTF-8 to UTF-16.

[Blitzker]

Thats how it is, Windows is internally all UTF-16 (ie. wchar_t), and file access should convert to that, the plain char APIs don't take UTF-8, only plain ASCII. MultiByteToWideChar is what you want to use to go from UTF-8 to UTF-16.

Yes, MultiByteToWideChar is what i use to convert UTF-8 to UTF-16. Still, i spent a bit of time wondering what was wrong till i decided to google for that info. At least its something i won't forget! :thanks:

[Blitzker]

Here is a new version of AssFilterMod that should fix the problem with unicode path names. The simple way to do it was to fix libass to support UTF-16 but i'm still not sure if i'll go with that or support it only in assfiltermod (more work).
Anyway, i decided to release a test build so users can test files with unicode paths.

x32: assfiltermod_utf-8_x32.zip (http://www.mediafire.com/file/13fy42qxh9trp6d/assfiltermod_utf-8_x32.zip)
x64: assfiltermod_utf-8_x64.zip (http://www.mediafire.com/file/w6axh9c6hc9joc9/assfiltermod_utf-8_x64.zip)

I also made a build with harfbuzz and a new version of the experimental stroker which fix the dots on some japanese fonts.

x32: assfiltermod_harfbuzz_x5_x32.zip (http://www.mediafire.com/file/d9mj52z3184nm1f/assfiltermod_harfbuzz_x5_x32.zip)
x64: assfiltermod_harfbuzz_x5_x64.zip (http://www.mediafire.com/file/uhx9j38tb7f53dc/assfiltermod_harfbuzz_x5_x64.zip)

[JayeDog]

I am trying to use assfiltermod with kodi dsplayer but it can only display embedded subs. It won't load external srt files. My files srt files are in the correct format ie same file name and 2 letter language code. It is working fine in mpc-hc. Any idea why the external srt files won't display in kodi displayer?

[ashlar42]

May I ask why the decision of starting almost from scratch instead of working on improving XySubFilter? Was it not open sourced?
Simple curiosity, not criticism of any kind, as devs are clearly free to do whatever the hell they want with their own time. :)

[clsid]

XySubFilter is based on VSFilter, while AssFilterMod uses libass, which is an entirely different rendering library.

[amayra]

May I ask why the decision of starting almost from scratch instead of working on improving XySubFilter? Was it not open sourced?
Simple curiosity, not criticism of any kind, as devs are clearly free to do whatever the hell they want with their own time. :)

1 XySubFilter is open source
2 AssFilterMod is a fork of AssFilter "ISubRenderProvider meets libass. Working prototype.
" by Alex Marsev
3 always check behind you before posing dude

[blaster00]

with some sub from http://www.zimuzu.tv/fsubtitle http://subhd.com/sub0
for ass
1. AssFilterMod crashes mpc-hc with madvr or evr-cp many times.
2. It takes a lot of times before play real start.
3. Border And Shadow behaves very differently with AssFilterMod other then mpc internal and xysubfilter.
for srt
both AssFilterMod and sub file is loaded, but nothing is showed. Not quite much, but happened.
Sorry for my English, and no snapshot.

Also don't know how to switch sub tracks.

[ashlar42]

1 XySubFilter is open source
2 AssFilterMod is a fork of AssFilter "ISubRenderProvider meets libass. Working prototype.
" by Alex Marsev
3 always check behind you before posing dudeIt's quite ironic that you spent the time to reply, suggesting me to "check behind" when you clearly did *not* answer my main question.

"May I ask why the decision of starting almost from scratch instead of working on improving XySubFilter?"

The fact that XySubFilter is open source only strenghtens my curiosity. Reading these nine pages it looks a lot like reinventing the wheel. *But* I'm not a developer, so I simply asked what was the reason for the decision taken by Blitzker. I *think* he might be the only one capable of providing an answer.

And I stress that it's his time, his project and he can do whatever the hell most pleases him. I'm just curious. Maybe I'll learn something in the process.

Cheers. :p

[clsid]

XySubFilter code is a giant complex mess which makes it unlikely to attract new developers.

AssFilterMod is open source as well. All the complex stuff is in an external library (libass) that he doesn't need to worry about. The AssFilterMod filter is just a wrapper for libass. So it is a relatively small amount of code to maintain.

[Shinobu]

Great job with this filter, got lots of ass fx witch just don't wokrs with vsfilter or xysubfilter.
Is there any way to autoswitch from your ass filter to vsfilter/xysubfilter for unsupported format (.sub,.pgs...)

Thanks a lot

[lion09503]

any news when this will be updated again?

[amayra]

any news when this will be updated again?

i did try to add support to pgs in my fork but no luck

[huhn]

did you try it with the vsfilter code or the ffmpeg code?

[amayra]

did you try it with the vsfilter code or the ffmpeg code?

i used MPC code and hoped to see some improvement with ISR code

[cyberscott]

I recently built a Windows 10 64 bit (all latest updates) PC with a Ryzen 1800x cpu and a Nvida 1080 GPU.

AssFilterMod with MPC CE 64 bit, LAV and Madvr, all latest builds. Render times jump all over the place, video stutters like crazy. Doesn't matter the resolution /upcale of the video or of the subtitles. I tried different native resolutions from 480p and 1080p and upscales to 4k, no difference.
Same thing happens with xysubfilters as well so maybe something common to the code? On my Intel based system, AssFilterMod plays perfectly fine and stable. Internal renderer on the new build is fine.

Can anyone with a Ryzen CPU try AssFilterMod to see if they have issues as well?

[lion09503]

I recently built a Windows 10 64 bit (all latest updates) PC with a Ryzen 1800x cpu and a Nvida 1080 GPU.

AssFilterMod with MPC CE 64 bit, LAV and Madvr, all latest builds. Render times jump all over the place, video stutters like crazy. Doesn't matter the resolution /upcale of the video or of the subtitles. I tried different native resolutions from 480p and 1080p and upscales to 4k, no difference.
Same thing happens with xysubfilters as well so maybe something common to the code? On my Intel based system, AssFilterMod plays perfectly fine and stable. Internal renderer on the new build is fine.

Can anyone with a Ryzen CPU try AssFilterMod to see if they have issues as well?

I'm using a 1700 together with a gtx1060 running on a 4k display. I'm using lav filters,madvr and potplayer together with assfiltermod and I'm having no problems during playback.

[huhn]

did you change the nvidia power setting to adaptive?

[cyberscott]

did you change the nvidia power setting to adaptive?

Most definitely. I always keep it on adaptive and insure it is on adaptive after each video card driver install. Also tried "prefer maximum performance" for the heck of it with no change.
I've tried adjusting the render queues in Madvr to their highest to lowest settings with a few random settings in between but no luck.
Went as far as disabling cores in the Ryzen processor but no change.
Both AssFilterMod and xysubfilter exhibit the exact same behavior.
The internal subtitle renderer works fine.

I hope others with a Ryzen processors can chime in to determine if it is actually the processor / platform causing the weirdness.

[huhn]

can you make a screen of the OSD in playback?

[cyberscott]

can you make a screen of the OSD in playback?

Here you go, though I don't know if it will help much. The render times jump all over the place when the subtitles are playing. I've seen it go over 2000!
I played the video at its' native resolution of 1080p but crazy jumping rendering times happen no matter the resolution or scaling setting if subtitles are being rendered. If no subtitles are being displayed, the video plays fine.
Absolutely no playback issues if the internal subtitle renderer is use.
I have no issue using the internal subtitle renderer but I want to see if the Ryzen platform is the problem and let the commuity/devs take a crack at solving this.

https://photos.google.com/photo/AF1QipO5KNxA019o2F1d9MiasPFw1CPP-FhACW_jcjpC

[amayra]

someone need to pick up this project

[huhn]

your screen is 404.

[cyberscott]

your screen is 404.

Try this one.
https://drive.google.com/file/d/1YNwOXrQpAru166BeHoNF4hryaCHlHaw8Vg/view?usp=drivesdk

[cyberscott]

I'm using a 1700 together with a gtx1060 running on a 4k display. I'm using lav filters,madvr and potplayer together with assfiltermod and I'm having no problems during playback.

Thanks for that info. I haven't tried another player outside of MPC-BE yet. I'll probably give potplayer a try this weekend to see if anything changes. :thanks:

[huhn]

the subtitle queue isn't full and the upload too check the PCIe speed.

[cyberscott]

the subtitle queue isn't full and the upload too check the PCIe speed.

PCIe speeds are fine, Gen2, 16x.

The screen shot does't show the full story, only what was happening at the time of the photo.
All the queues go up and down during the presence of any subtitles withAssFilterMod, always in a state of flux.

I did confirm same behavior within potplayer. This one is weird. Must be something specific to my system hardware and software as lion09503 reported no issues with his Nvidia 1060 / Ryzen system and he has a less powerful video card than I do.

It not the end of the world if I can't use the filter, just a little annoying that I haven't been able to pin down the cause yet.

[lion09503]

Thanks for that info. I haven't tried another player outside of MPC-CE yet. I'll probably give potplayer a try this weekend to see if anything changes. :thanks:

Great. I haven't heard of mpc-ce though. Is that a port of mpc-hc? Can you link it? I'm not finding anything on google.

[cyberscott]

Great. I haven't heard of mpc-ce though. Is that a port of mpc-hc? Can you link it? I'm not finding anything on google.

You'll never find MPC-CE, it doesn't exist. :D A typo on my part, should be MPC-BE. I've edit my original post to correct. Sorry for the confusion.

[cyberscott]

I'd though I'd post back that after I installed the Windows 10 Fall Creators update, my issues with both AssFilterMod and xysubfilter completely cleared up and both now work as they should. I though I'd never had to thank Micro$oft for anything, lol! :p

[Blitzker]

Hello!

Its been a while since the last release but i found time to release a new version.

AssFilterMod version 0.4 is out: https://github.com/Blitzker/assfiltermod/releases


v0.4
- add: System tray icon
- add: Selection of external subtitles in context menu of tray icon
- add: Open settings by left click on the tray icon
- add: Use of fonts in External Subs Fonts folder for SRT subtitles
- add: Libass is built with harfbuzz support
- add: Support of font ligatures
- add: Option to disable auto-load of external subtitles
- fix: Auto-load of subtitles with unicode characters
- fix: Auto-load of SRT subtitles on a different codepage than en_us
- Settings page is now split in two: General Settings and SRT Settings
- Add support for Visual Studio 2017
- Use my fork of libass
- Update libass asm building tools : Now use nasm instead of yasm


I highly recommend to delete the registry key HKEY_CURRENT_USER\Software\AssFilter or reset the settings in the configuration pages.

This release introduce a system tray icon with which you can access the configuration by a left-click. The support of external subtitles have been improved and now load all subtitles present in the media file folder (they must still match the media name) and the subfolders (all .ass and .srt are loaded) specified in the configuration dialog. You can switch between the external subtitles by using the context menu on the new tray icon (right-click).

The binaries are now built with Visual Studio 2017, so be sure to install the redistributables (urls on first post).

[huhn]

is it possible to make the custom resolution option to be AR aware?
and the tray icon doesn't work on my system.
i'm on an old windows 10 insaider build.

[Blitzker]

is it possible to make the custom resolution option to be AR aware?
and the tray icon doesn't work on my system.
i'm on an old windows 10 insaider build.

I'll see what i can do about the AR.

For the tray icon, its a stupid error on my part. Its disabled by default and i forgot to add a checkbox in the General Settings.
In the meantime, you can manually activate it by going in the registry "HKEY_CURRENT_USER\Software\AssFilter" and set "TrayIcon" to 1.

[Dulus_No]

Would be possible to add an option for enabling kerning for .srt? It's possible for .ass with the script property "Kerning: yes".
http://www.framecompare.com/screenshotcomparison/KZPNNN8X

[Blitzker]

Would be possible to add an option for enabling kerning for .srt? It's possible for .ass with the script property "Kerning: yes".
http://www.framecompare.com/screenshotcomparison/KZPNNN8X

Simple enough. I've added support for kerning in the next build.

[Blitzker]

New build of AssFilterMod available:

- Add the missing "Enable System Tray Icon" checkbox in General Settings
- Add "Enable Kerning" checkbox in SRT settings.

http://www.mediafire.com/file/1icansexy3ex6hv/assfiltermod_975459a_x32.zip
http://www.mediafire.com/file/kq25aij47a7a4zl/assfiltermod_975459a_x64.zip

[Dulus_No]

- Add "Enable Kerning" checkbox in SRT settings.


Thank you!

[Siso]

I tried the latest version and it seems it doesn't allow me to make the subtitle font to bold...It stays on normal.

[Dulus_No]

I tried the latest version and it seems it doesn't allow me to make the subtitle font to bold...It stays on normal.

Workaround is to add in "Custom Tags" this: {\b1}

[Siso]

Workaround is to add in "Custom Tags" this: {\b1}

Thank you.

[huhn]

i'm on fall creator update now and i can't install assfilter now.
and yes i'm installing it as an admin. madVR worked fine so i'm quite lost here...

[lvqcl]

Do you have Visual Studio 2015 redistributable or Visual Studio 2017 redistributable installed?

[huhn]

thanks.

[clsid]

A static build would be nice to have. It avoids this dependency problem and pretty much all other codecs do it for that reason.

[Blitzker]

Workaround is to add in "Custom Tags" this: {\b1}

Yes, this is the way to do it for now. Its on my to-do list to be able to select options on the font selection dialog box.

A static build would be nice to have. It avoids this dependency problem and pretty much all other codecs do it for that reason.

Indeed, like you said this would avoid problems. Will do that for the next build.