AssFilterMod - DirectShow subtitle renderer (v0.4) [Archive] - Page 2

ryrynz

17th August 2016, 23:35

My opinions and observations:
- AssFilterMod [harfbuzz] produces a little more sharper subtitles than AssFilterMod

This sharpness you're noticing looks to be the result of the text being slightly closer together in some areas, otherwise it's identical, is that change intended?

What changed exactly with those builds I see nothing mentioned in the GIT.

Siso

22nd August 2016, 19:40

I was trying to get assfiltermod to work, but no success at all, tried with mcp-be and potplayer, no luck. Any help will be appreciated.

ryrynz

23rd August 2016, 09:06

I was trying to get assfiltermod to work, but no success at all, tried with mcp-be and potplayer, no luck. Any help will be appreciated.

I couldn't get it working with BE, it's not supported anyway. I know it works in HC though.

Siso

23rd August 2016, 09:14

I couldn't get it working with BE, it's not supported anyway. I know it works in HC though.

Thank you, will try it.

amayra

23rd August 2016, 23:24

I couldn't get it working with BE, it's not supported anyway. I know it works in HC though.
is work fine in my MPC-BE
edit: sorry is moded Build

Siso

24th August 2016, 13:41

It looks like it work only with embedded subtitles, not with external srt files...

ryrynz

24th August 2016, 23:02

It looks like it work only with embedded subtitles, not with external srt files...

Yeah that's why MPC-BE hasn't added support for it yet. Most users are still better off with xy/vssubfilter for now.

Blitzker

2nd September 2016, 04:32

Thank you very much for the AssFilterMod ! :thanks:

I did some quality comparison for subtitle renderers.

My opinions and observations:
- xy-VSFilter isn't usable in this days, because of awful and terrible subtitle rendering quality
- XySubFilter produces a little more sharper subtitles than MPC-HC
- AssFilterMod produces sharpest subtitles, compared to XySubFilter, MPC-HC and xy-VSFilter
- AssFilterMod [harfbuzz] produces a little more sharper subtitles than AssFilterMod

Vertical subtitles are smaller in AssFilterMod (at least with this file), compared to XySubFilter, MPC-HC and xy-VSFilter. Is it a bug?

Thanks for testing! Indeed the vertical subtitles are smaller compared to XySubFilter. This is one of many differences between XySubFilter and libass (be it features or bugs :sly: )

This sharpness you're noticing looks to be the result of the text being slightly closer together in some areas, otherwise it's identical, is that change intended?

What changed exactly with those builds I see nothing mentioned in the GIT.

The harfbuzz builds are to test another way to compile libass with a new text shaper (harfbuzz instead of freetype). Since harfbuzz is still actively developed, i may switch to this if there is no glitches in the display of the subs.

It looks like it work only with embedded subtitles, not with external srt files...

Yes, it only work with embedded subtitles for now. I'll start to look into external subtitles when i get more time.

huhn

2nd September 2016, 17:27

i'm running the "harfbuzz" build for some time now and i haven't seen something that was definitely broken.

Blitzker

3rd September 2016, 01:06

i'm running the "harfbuzz" build for some time now and i haven't seen something that was definitely broken.

Same here, not a glitchy sub yet with the harfbuzz builds.

I've made a new build based on harfbuzz with a not yet released version of libass. This fixes a problem with the drawing of outlines with some fonts.

harfbuzz: http://imgur.com/20wSgYv
harfbuzz_x1: http://imgur.com/iQx9lvV

Works good for me but it needs more testing.

huhn

17th September 2016, 18:04

just a small update.

i haven't notice/seen any issues with the x1 build and i used it a lot.

amayra

30th September 2016, 09:46

i try to make AssFilterMod load the auto-load subs but i need some help any update about that ?

Blitzker

30th September 2016, 20:52

i try to make AssFilterMod load the auto-load subs but i need some help any update about that ?

If you're talking about auto-load of external subs, its not implemented yet.

lion09503

5th October 2016, 23:17

If you're talking about auto-load of external subs, its not implemented yet.

Any ETA on this feature?

Blitzker

6th October 2016, 23:53

Any ETA on this feature?

Sorry, no ETA.

amayra

7th October 2016, 11:16

Any ETA on this feature?
i'm trying add this feature but i need more time maybe more few week :confused:

amayra

7th October 2016, 11:17

If you're talking about auto-load of external subs, its not implemented yet.
i well try to help you with this one :goodpost:

Blitzker

8th October 2016, 00:26

i well try to help you with this one :goodpost:

Thanks, any help is welcome! :)

Blitzker

8th October 2016, 00:48

Hello!

I've done some optimizations in the rendering code and so far, it gives me good results. (assfiltermod_harfbuzz_x2)

On my couple years old CPU (i7 950 3.2G) and the following test subs (thanks huhn) at 1080p, the subtitles rendering queue in madvr stay mostly full with a little drop of 1-2 frames in the heaviest scenes.

If some of you want to do those tests, plz share your results and cpu model. And be sure to give a try to the most heavy subs you can get your hands on too! :devil:

Thanks!

http://www.mediafire.com/file/9o1cgh5xra1ybno/subtiles_test_files.7z

huhn

8th October 2016, 15:00

Blitzker

10th October 2016, 18:05

i3 4130 3.40 ghz, DDR3 1600 mhz ram
rendering resolution UHD.

ddy dimension w ed: fine the queue is nearly untouched

ddy dimension w op: fine the queue is nearly untouched

fff aldnoah zero ED 2: impossible to play smooth. XY vsfilter can't even play it at 1080p with my system.

GJM shirayuki OP 1: fine was a problem in the past.

fff aldnoah zero ED 2 is heavy with all the moving subs so i can see that the rendering can't keep up.

Since the rendering is now multithreaded, it would be nice if the tests could be done with a cpu with more cores.

Thanks for testing!

huhn

10th October 2016, 19:55

with a CPU queue of 128 it is playable at UHD. but the CPU never uses more than 70 % so i'm not sure if more cores are really doing a lot more.

i have an i7 3770k and i will do the test there some time in the future.

doing test on 1080p with that CPU is a waste of time it will work for sure.

Siso

11th October 2016, 21:36

huhn

11th October 2016, 21:55

to test if it works. and yes it was helping a lot in this case so buffers help.

it's not even remotely close to working with 16.

Siso

12th October 2016, 08:24

to test if it works. and yes it was helping a lot in this case so buffers help.

it's not even remotely close to working with 16.

So increasing the CPU queue for 1080p 23p playback to 128 is good? I'm with Xeon X5650 6 cores @ 3,6 ghz.

ryrynz

12th October 2016, 08:30

So increasing the CPU queue for 1080p 23p playback to 128 is good? I'm with Xeon X5650 6 cores @ 3,6 ghz.

Only it certain situations like rendering complicated subtitles. Otherwise leave it at defaults.

Siso

12th October 2016, 08:43

Only it certain situations like rendering complicated subtitles. Otherwise leave it at defaults.

Thank you, will do.

Plastic

3rd November 2016, 23:19

Hello, I having issues with overlapping subtitles. How do I set it to not use the subs from assfitlermod instead of the built in MPC-HC one.

Blitzker

4th November 2016, 04:59

Hello, I having issues with overlapping subtitles. How do I set it to not use the subs from assfitlermod instead of the built in MPC-HC one.

For now, the only way to not have overlapping subtitles when you use the built-in subtitle renderer in MPC-HC is to un-register assfiltermod. I will update my pull request
for MPC-HC soon to fix this.

Blitzker

4th November 2016, 05:51

Hello!

I finally found the time to implement the auto-loading of external subtitles. The feature still need some work but i think its ready to be tested.

There is a couple of things to look for:

Embedded subtitles have priority over the external subtitles.

Only one external subtitle can be loaded for now.

The external subtitle name must match the name of the media file. But also, the subtitle name can contain an ISO 639-1 2 characters language code before its extension (ie: mymovie.en.srt).

A subtitle name with an ISO 639 language code will have priority over a name without one.

An external ASS subtitle will have priority over an SRT one.

There is a new option in the filter settings to set a path to load external fonts. Only used for external ASS subtitles. By default, it is set to "{FILE_DIR}" (without the quotes) which mean the folder where the media file is located. So you can do "{FILE_DIR}fonts" to use the fonts folder inside the media file folder (no need to put a \ after the {FILE_DIR} tag).

Thats it on the feature for now. What i have planned to do next is of course the possibility to be able to switch between multiple external subs.

The test version is in mediafire as usual (assfiltermod_harfbuzz_x3_x32 or assfiltermod_harfbuzz_x3_x64).

Thanks for testing!

BTW, there is currently no error checking done on the external subtitles. So if you try to load a corrupted or invalid file, the behavior is undefined.

NOTE: You need to re-register assfiltermod to enable the auto-loading of external subs.

Plastic

4th November 2016, 17:44

For now, the only way to not have overlapping subtitles when you use the built-in subtitle renderer in MPC-HC is to un-register assfiltermod. I will update my pull request
for MPC-HC soon to fix this.

Thank You!:D

Blitzker

10th November 2016, 00:57

Hello!

I've made a custom build of MPC-HC that support AssFilterMod. Its based on the lastest git (develop branch)

x86: mpc-hc_8f7f1dc (assfilter).zip (http://www.mediafire.com/file/3g9jptl0jnf7fnl/mpc-hc_8f7f1dc_%28assfilter%29.zip)
x64: mpc-hc64_8f7f1dc (assfilter).zip (http://www.mediafire.com/file/qn854m4r4dk68az/mpc-hc64_8f7f1dc_%28assfilter%29.zip)

The zip files only contain the main EXE.

Thanks

rock

10th November 2016, 11:46

I can't play rmvb video with external srt when I set AssFilter as Subtitle Renderer, XySubFilter is fine. What could be the reason? Anyway I also found that AssFilter and AssFilterAutoLoad on filter list when playing video with embedded subtitle.

Edit:
Developer has investigated it that it was caused by the sub file, not the video. thanks to him :)

Blitzker

10th November 2016, 17:54

I can't play rmvb video with external srt when I set AssFilter as Subtitle Renderer, XySubFilter is fine. What could be the reason? Anyway I also found that AssFilter and AssFilterAutoLoad on filter list when playing video with embedded subtitle.

Works fine here, but i have an idea why it doesn't for you. Can you share the srt file plz?

As for the AssFilterAutoLoad duplicate in the filter list, i'm aware of this problem. I'll fix this soon.

Thanks for testing!

Plastic

11th November 2016, 07:40

The new player works great for me. Though my Initial D rip doesn't show any subs. Nvm, I'm an idiot.
Also, I'm trying to load external ass files for the rip and it just freezes when loading the MKV

Blitzker

11th November 2016, 08:22

The new player works great for me. Though my Initial D rip doesn't show any subs. Nvm, I'm an idiot.
Also, I'm trying to load external ass files for the rip and it just freezes when loading the MKV

Can you share an ass file that freeze (Don't rename the file before sharing)? I tested a lot of them here (Some out of Aegisub and some extracted from mkv's) and they all worked.

rock

12th November 2016, 14:08

Plastic

13th November 2016, 09:28

Can you share an ass file that freeze (Don't rename the file before sharing)? I tested a lot of them here (Some out of Aegisub and some extracted from mkv's) and they all worked.

https://plastic.s-ul.eu/xPzjyD2p

here's a link to said subtitle. Right click since it's hosted on my buddies dedi.

Blitzker

14th November 2016, 05:18

this (https://www.dropbox.com/s/h5x5s9f5rhbbxjm/%5BAnime%20Land%5D%20Detective%20Conan%20Movie%2020%20-%20The%20Darkest%20Nightmare%20%28BDRip%201080p%20Hi10P%20TrueHD%29%20RAW%20%5BF2938E75%5D.ass?dl=0) subtitle looks different with AssFilterMod compared to mpv, MPC-HC ISR, and XySubFilter

Nice find, fixed. This subtitle file have an embedded font and by default, libass don't load them.

https://plastic.s-ul.eu/xPzjyD2p

here's a link to said subtitle. Right click since it's hosted on my buddies dedi.

Thanks, will have a look at it.

Volfield

14th November 2016, 22:22

Blitzker when i play files with ordered chapters openings and endings dont have subtitles e.g. Coalgirs Nisekoi or Clannad releases.

Blitzker

15th November 2016, 05:49

Blitzker when i play files with ordered chapters openings and endings dont have subtitles e.g. Coalgirs Nisekoi or Clannad releases.

Nice problem... Let me explain:

When an ass subtitle file is muxed in a MKV file, each event is assigned an unique number to identify it (0, 1, 2, 3, etc...). That way, its easy to avoid duplicate events (Cause each time you seek backwards in a file, the subtitle data is read again and processed).
Now the problem is that an ordered chapter is basically another MKV file that is dynamically inserted into the file currently playing. That means, since its another file, its events are also numbered as 0, 1, 2, 3, etc.. So the duplicate system is kicking in and discard the new events with the same id's.

Gonna have to come up with a solution to this problem. :devil:

Andy2222

17th November 2016, 13:00

Blitzker

17th November 2016, 20:17

Is this the repo/tree for your compiled version and will you keep it updated/merged? https://github.com/Blitzker/mpc-hc/tree/assfilter

thx
Andy

Yes, i will keep it updated and build it when there is a change since i personally use it.

Blitzker

17th November 2016, 20:35

https://plastic.s-ul.eu/xPzjyD2p

here's a link to said subtitle. Right click since it's hosted on my buddies dedi.

I tried your subtitle file as external and as embedded and couldn't get it to crash. What are your specs? Player you use?

cyan

19th November 2016, 22:10

no option to pick which subtitle to display (for multi embedded) or am I missing something ?
thank you

Blitzker

20th November 2016, 04:47

no option to pick which subtitle to display (for multi embedded) or am I missing something ?
thank you

You can already select the subtitle in your player (in MPC-HC, its in Play->Subtitle track or Right-Click->Subtitle track) or even by Right-Click on the LAV Splitter if you use it. With so many ways to change the active subtitle, i don't feel its really needed.

Plastic

20th November 2016, 05:16

I tried your subtitle file as external and as embedded and couldn't get it to crash. What are your specs? Player you use?

I'm using your build of mpc-hc 64bit.

I don't think I should have any issues playing anything lol. Here are my specs. http://valid.x86.fr/5acuby

Blitzker

20th November 2016, 06:53

I'm using your build of mpc-hc 64bit.

I don't think I should have any issues playing anything lol. Here are my specs. http://valid.x86.fr/5acuby

Indeed, nice rig!

Do you have another external ass subtitle that you can test with the same MKV that freeze? Just to be sure that its not the MKV that is the problem.

lion09503

20th November 2016, 12:24

Nice work so far but can you also add support for PGS files? It's the format for bluray subtitle files.

Blitzker

20th November 2016, 21:25

Nice work so far but can you also add support for PGS files? It's the format for bluray subtitle files.

Adding support for bitmap subtitles like PGS and Vobsub would require an external library (like libass for ASS subtitles). I haven't yet found such a lightweight library and i don't want to use ffmpeg (too big).