x264 development

[Sirber]

my last test was with 292 IIRC.

[celtic_druid]

That would explain it.

[el divx]

very nice! Good job, celtic_druid.
Will it be good to change the *.ico (icon) as well?

Still, we need to get permission from bob0r. :P

I have changed the installer graphic and the icon. I hope you like it.

[leowai]

I have changed the installer graphic and the icon. I hope you like it.
:thanks: I'll try it later... Waiting now ;) ... => attachment is currently pending for approval. :o

If it looks better than current version, probably we should suggest the developers to committe these into the SVN. :devil:

[bob0r]

Question for the smart guys:

my x264.exe commandline:
x264 --progress --pass 1 --bframes 2 --me dia --ref 1 --subme 1 --analyse none --output NUL cap.avs
x264 --progress --pass 2 --bitrate 1000 --bframes 2 --b-pyramid --weightb --ref 3 --subme 6 --8x8dct --analyse all --output video.264 cap.avs

In VFW is there a way to "disable" bitrate for pass 1?
Or because i save cap_pass1.avi and cap_pass2.avi this is a stupid question, and VFW can't output to NUL?


As for the settings themself, profiles in VFW would be awesome, you could just save all your pass1/pass2 etc... settings, just the way you want them, good idea!

[Sharktooth]

Im already preparing a new installer script and all the stuff to commit to the SVN.
Please have some patience :)

[bob0r]

Maybe await el_divx's icon :)

[Sharktooth]

im awaiting... :P

[Antony]

Right, 8 tabs was a lot... Here is the same window with only 4 tabs :)
http://members.shaw.ca/antony.boucher/download/vfw_4_tabs.zip

[stephanV]

Looks good to me :)

[Sharktooth]

thanks. the next builds will feature the new vfw patch and some other changes in both full and lite packages.

[el divx]

All I've done is take bobor's logo(sorry for not asking you first, bobor) and use it on the default installer script as well as paste it over the old icon's logo to make it look better. You can find it all in the file I attached above.

[bob0r]

All I've done is take bobor's logo(sorry for not asking you first, bobor) and use it on the default installer script as well as paste it over the old icon's logo to make it look better. You can find it all in the file I attached above.

That's no problem, its only $500 per pixel.

Email me the file, and ill put in on http so we all can enjoy it.
Sent to el_divx [at] x264.nl (or any other random [at] x264.nl)
gmail to store all! :devil:

[Sharktooth]

New builds up. Installer script is still unchanged (had no time to update it).
Please test the VFW interface.

[foxyshadis]

Sharktooth, just curious, will your new installer script include a reg key with the last installed-to folder?

[bob0r]

I just updated my gpac (cvs up)
make clean
make

gpac\bin\gcc\libgpac_static.a copy to \MinGW\lib
gpac\include\gpac copy to \MinGW\include

svn co svn://svn.videolan.org/x264/trunk x264_test
cd x264_test
patch -p0 < x264_mp4_output_gpac_04x_update.0.diff
configure --enable-vfw --enable-avis-input --enable-mp4-output --enable-pthread

make clean
make

Error:
Creating library file: x264vfw.dll.a
make[1]: Leaving directory `/home/user/x264_test/vfw/build/cygwin'
gcc -Wall -I. -O4 -ffast-math -D__X264__ -DHAVE_MMXEXT -DHAVE_SSE2 -DARCH_X86 -DSYS_MINGW -DAVIS_INPUT -DMP4_OUTPUT -DHAVE_PTHREAD=1 -s -fomit-frame-pointer -DHAVE_GETOPT_LONG=1 -c -o x264.o x264.c
x264.c: In function `recompute_bitrate_mp4':
x264.c:1426: warning: dereferencing type-punned pointer will break strict-aliasing rules
x264.c:1426: warning: passing arg 1 of `gf_odf_desc_del' from incompatible pointer type
x264.c: In function `open_file_mp4':
x264.c:1471: error: too few arguments to function `gf_isom_open'
make: *** [x264.o] Error 1

Sharktooth? Superdump? Anyone else?

[SeeMoreDigital]

New builds up.... Please test the VFW interface.Just used the new VfW interface to generate two anamorphically signalled test encodes, one with 2 B-frames, one without B-frames.... Seems to work well ;)


Cheers

[celtic_druid]

@bob0r, from anyone else.

You neeed to add , NULL to the function.

p_mp4->p_file = gf_isom_open(psz_filename, GF_ISOM_OPEN_WRITE, NULL);

[leowai]

I just updated my gpac (cvs up)
:
:
Sharktooth? Superdump? Anyone else?
Me too. I believe it's because the changes in isomedia file open API in gpac on 20th Sep 2005:
Latest CVS Changes 20/09/05
- changed isomedia file open API for better support of temporary directories

It takes additional input for the mp4 creation, this need a newer patch for the mp4 support.

If you want a quick solution, back to gpac CVS on 19th Sep 2005.

@bob0r, from anyone else.

You neeed to add , NULL to the function.

p_mp4->p_file = gf_isom_open(psz_filename, GF_ISOM_OPEN_WRITE, NULL);

I'll try this first. :D Thanks.

[edit]: This works. Thanks celtic_druid. :)

[celtic_druid]

NULL sets it to the default temp dir.

[bob0r]

...
If you want a quick solution, back to gpac CVS on 19th Sep 2005.
...


Stupid question: How do i go "back to gpac CVS on 19th Sep 2005"?

And where do i find:
Latest CVS Changes 20/09/05
- changed isomedia file open API for better support of temporary directories

This changelog?

[celtic_druid]

Run cvs with -D date .

The changlog is in ./gpac/changelog

[leowai]

Stupid question: How do i go "back to gpac CVS on 19th Sep 2005"?

And where do i find:
Latest CVS Changes 20/09/05
- changed isomedia file open API for better support of temporary directories

This changelog?
Yes, changelog of gpac. Well, since you got the latest gpac, try celtic_druid's method. It works for me. :)
@bob0r, from anyone else.

You neeed to add , NULL to the function.

p_mp4->p_file = gf_isom_open(psz_filename, GF_ISOM_OPEN_WRITE, NULL);
Find the function in the patch file, add the NULL accordingly before apply the patch.

[el divx]

After applying the patch, here's what I get when the process starts building VFW:make -C vfw/build/cygwin
make[1]: Entering directory `/home/x264/vfw/build/cygwin'
D: /home/x264/vfw/build/cygwin/bin
C: ./codec.c
C:/msys/home/x264/vfw/build/cygwin/../../x264vfw.h:132: warning: 'tabs_enable_items' declared `static' but never defined
C:/msys/home/x264/vfw/build/cygwin/../../x264vfw.h:133: warning: 'tabs_update_items' declared `static' but never defined
C: ./config.c
C: ./driverproc.c
C:/msys/home/x264/vfw/build/cygwin/../../x264vfw.h:132: warning: 'tabs_enable_items' declared `static' but never defined
C:/msys/home/x264/vfw/build/cygwin/../../x264vfw.h:133: warning: 'tabs_update_items' declared `static' but never defined
W: ./resource.rc
C:/msys/home/x264/vfw/build/cygwin/../../resource.rc:10:20: afxres.h: No such file or directory
c:\mingw\bin\windres.exe: C:/msys/home/x264/vfw/build/cygwin/../../resource.rc:20: syntax error
make[1]: *** [resource.obj] Error 1
make[1]: Leaving directory `/home/x264/vfw/build/cygwin'
make: *** [x264vfw.dll] Error 2

[bob0r]

@celtic_druid
Thanks that worked

@leowai:
Thanks, what celtic_druid said indeed worked :P

@el divx
Yo, email me the installer.7z
( http://forum.doom9.org/showthread.php?p=714574#post714574 )

[Kurtnoise]

@Antony : Great stuff...:) Could you add zone options a_la_xvid ? Thanks...

[leowai]

After applying the patch, here's what I get when the process starts building VFW:
C:/msys/home/x264/vfw/build/cygwin/../../resource.rc:10:20: afxres.h: No such file or directory
Your compilation platform can't find the required file "afxres.h"! My MinGW just works out fine here. :)

Tried clean compilation?
make clean
make
If this fails, I suspect of faulty compilation platform. ;)

[el divx]

Your compilation platform can't find the required file "afxres.h"! My MinGW just works out fine here. :)

Tried clean compilation?

If this fails, I suspect of faulty compilation platform. ;)

Thanks leowai. I installed the latest version of MinGW and now it works.

[bob0r]

I have changed the installer graphic and the icon. I hope you like it.

the file: http://mirror05.x264.nl/el_divx/installer.7z

I must say, i have tried the same win.bmp as you did, i removed it, for 2 reasons, 1 its ugly when its not horizontal and 2 its adding to the filesize of the installer.

x264vfw.ico i will be using tho, thanks :)

[Sharktooth]

Sharktooth, just curious, will your new installer script include a reg key with the last installed-to folder?
Yes. It will also include the ability to choose what do you want to install (cli, vfw, megui etc.), an option to uninstall any previosly installed versions and will add a start menu link to a small app to check for new versions.

[Sharktooth]

@celtic_druid
Thanks that worked

You can find a working gpac 0.4.x patch in the x264 daily builds thread. It works with the latest gpac sources.

EDIT: Maybe some headaches could be avoided if i knew celtic druid posted the fix in the previous page... 't was my fault, though... :)

[Sirber]

rev 293 changes gives me ~10 FPS more in fast first pass and ~1.5 FPS more with all options. sweet :D

(AMD64 3000+, 1GB DDR400)

[bob0r]

@sharktooth:
Yup akupenguin/pengvado asked in the irc channel is the patch should be commited, but then i tested it, and it failed to compile :p
Now i just tried it again, and with your patch it indeed "still" works fine, so time to commit it, and start working on the --fps 29.97 .mp4 output bug :D

@el divx:
Can you please make a NSIS compatible icon for the installer(uninstaller) too?
I tried several bmp/gif to icon converters, but all failed, they remain 24 or 32bit according to windows properties.
http://www.nullsoft.com/free/nsis/makensis.htm >
Icon path_to_icon.ico "Sets the icon of the installer. The icon MUST contain a 32x32x16 color icon resource (it can also contain other icons, but they will be discarded)."
UninstallIcon path_to_icon.ico "Sets the icon of the uninstaller. Again, the icon MUST contain a 32x32x16 color icon resource (it can also contain other icons, but they will be discarded)."
Please look into it.

(Extra question, i added !define Icon "x264.ico" and !define UninstallIcon "x264.ico" to x264-conf.nsi, that should be correct right, sharktooth?)

Edit: No longer needed, thank you!

[Sharktooth]

It "should" be right. But some versions of NSIS had some bugs, so if it doesnt work check your NSIS version and eventually update it...

However the gpac patch works like a charme, it's time to submit it (and hope JLF doesnt make API changes any more...).
If you meet pengvado on irc tell him to get the patches directly from the daily builds thread. Also the VFW patch seems to work ok, so...

[bob0r]

It "should" be right. But some versions of NSIS had some bugs, so if it doesnt work check your NSIS version and eventually update it...

http://nsis.sourceforge.net/
NSIS 2.09 released - 26-08-05

It seems the icons in C:\Program Files\NSIS\Contrib\Graphics\Icons also show 32x32 with Bit Depth 32 (windows xp/properties/summary)
In fact, all is the same with my icons:
Width 32 pixels
Height 32 pixels
Horizontal Resolution 96 dpi
Vertical Resolution 96 dpi
Bit Dept 32
Frame count 1

I tried
!define ICON "C:\Program Files\NSIS\Contrib\Graphics\Icons\arrow2-install.ico"
and
!define ICON "arrow2-install.ico"

So guess what:
http://nsis.sourceforge.net/Docs/Modern%20UI/Readme.html >
"
Important: Because the Modern UI has its own macro system, its own default settings and a lot of new features, the interface configuration works differently. So you should not use commands like LicenseText, Icon, CheckBitmap, InstallColors etc.
"

MUI_ICON icon_file
The icon for the installer.
Default: ${NSISDIR}\Contrib\Graphics\Icons\modern-install.ico

MUI_UNICON icon_file
The icon for the uninstaller.
Default: ${NSISDIR}\Contrib\Graphics\Icons\modern-uninstall.ico

I forgot we used MUI again, problem solved! :D ;) :o

[Sharktooth]

MUI_ prefix should be used if you use the Modern UI. Some standard NSIS commands are replaced by MUI versions and won't work with MUI unless you use the specific MUI replacements.
However MUI should be integrated in the next major NSIS version.

[hpn]

Congratulations on rev. 300 :)

The 4 tabs are beautiful. And to make everything perfect I think the second and third tabs
("Rate Control" and "I/P/B/Frames") should switch places, cause the Rate control options
are less likely to be changed with each encode (I usually don't touch them) than some of the
options on the third tab.

http://img343.imageshack.us/img343/8701/x2643000rt.png

[virus]

"8x8 DCT" is hardly a feature belonging to the "I-frames" group ;)
(and I still prefer the term "integer transform" or simply "transform" instead of DCT. H.264 does not use the DCT at all)

Also, the name "Quality" for the quantization limits (min/max qp and max step) is highly misleading imho.

[akupenguin]

There aren't any options specific to I-frames (other than ratecontolr/scenecut). The "8x8 intra search" and "4x4 intra search" flags apply only to P & B-frames. I-frames always use all available MB types.

[Kostarum Rex Persia]

But why Sharktooth removed all patches from rev. 300??? I think that is bad idea,because some of the patch was worked very good job in increase of speed and quality of x264 codec.

Sharktooth,can you,please,put these patches in build 301 or 302.I mean mainly on Johannes Reinhardt patch for Intra prediction mode,and,of course,Christian Heine new MMXEXT SATD functions that are slightly
faster than the original ones on Athlon XP and another his patch.

I put these patches as attacments.It's shame if these very good patches won't be included in future builds.

So,I need opinion of you,guys.What do you think,is these patches deserve to find place in futute revisions of x264?

[Kostarum Rex Persia]

Another question,from where I can directly download pengvado builds of x264.I am subscribed to x264 development from http://developers.videolan.org/lists.html ,but in the emails,I never get the download link for the newest builds.

[berrinam]

But why Sharktooth removed all patches from rev. 300??? I think that is bad idea,because some of the patch was worked very good job in increase of speed and quality of x264 codec.Can you not read? From Sharktooth's sticky, the Build Changes section says quite clearly:
(r300) Removed all patches, they were all finalized and submitted to the SVN repository. Updated GPAC sources.
I think that clears it all up, doesn't it? There is a reason for forum rule 1.

Another question,from where I can directly download pengvado builds of x264.I am subscribed to x264 development from http://developers.videolan.org/lists.html ,but in the emails,I never get the download link for the newest builds.
What are you talking about? There are no 'pengvado builds'. The newest builds can be found on Sharktooth's sticky.

[omion]

Umm... The changelog indicates that the patches were removed because they were merged with the x264 code. There's no point in applying the patches since it's now in the trunk source.

[edit: Oops. berrinam beat me to it]

[Kostarum Rex Persia]

Omion,are you sure that that patches now in the trunk source? Can anyone confirm it?

[berrinam]

@Kostarum Rex Persia: I quoted Sharktooth's sticky, where he said that the patches are now committed. Do you really think he would lie about that? For further proof, see the changelog (https://trac.videolan.org/x264/log/trunk/), which is also linked to from Sharktooth's sticky. There is no need to fear that the progress on x264 would go backwards. The developers are not stupid.

[omion]

Omion,are you sure that that patches now in the trunk source?I don't know what those patches were, exactly, but if they looked anything like this (https://trac.videolan.org/x264/changeset/296), this (https://trac.videolan.org/x264/changeset/297), or this (https://trac.videolan.org/x264/changeset/298), then there's no need to worry. (I do notice that the first one is by Johannes Reinhardt and the other two by Christian Heine, just as the ones you described...)

Can anyone confirm it?Yes... YOU can! The source is free and open on the internet. It took me 2 clicks to get to the links above from the x264 sticky.

I think you're being a bit too paranoid about the whole thing... If patches work, then they get committed. If they break, then they don't. As berrinam says, there's no need for anybody to lie about it... :rolleyes:

[Sharktooth]

But why Sharktooth removed all patches from rev. 300??? I think that is bad idea,because some of the patch was worked very good job in increase of speed and quality of x264 codec.

Sharktooth,can you,please,put these patches in build 301 or 302.I mean mainly on Johannes Reinhardt patch for Intra prediction mode,and,of course,Christian Heine new MMXEXT SATD functions that are slightly
faster than the original ones on Athlon XP and another his patch.

I put these patches as attacments.It's shame if these very good patches won't be included in future builds.

So,I need opinion of you,guys.What do you think,is these patches deserve to find place in futute revisions of x264?
I hope that's a joke....
Another question,from where I can directly download pengvado builds of x264.I am subscribed to x264 development from http://developers.videolan.org/lists.html ,but in the emails,I never get the download link for the newest builds.
still joking?

[Kostarum Rex Persia]

I am sorry,Sharktooth,I didn't read carefuly your sticky.Can you forgive me?

[Sharktooth]

sure ;)

[Kostarum Rex Persia]

btw,I read on the x264 mailing lists that " In its current
state, x264 is already quite efficient. Don't expect outstanding quality
boost in the near future ( a fair boost would be 0.3 dB, which I think
can be reached, and which represents roughly a 6% bitrate saving with
the same quality ). Now it's up to you to see how much time you can wait.

Feature-wise, AlexI is working on adding interlacing support to x264,
so, of course, if your streams are interlacing, I'd advise to wait. In
any other case, I'd encode right away ( you can't wait indefinitely ),
but you might think otherwise." (quote from Mathieu Monnier)

That's sounds very promising,I hope that interlace support will be ready in the next 3-4 months.