VapourSynth Editor

[Boulder]

Hi is there any update on this problem (https://forum.doom9.org/showthread.php?p=1817822#post1817822)?

My editing requires me to reload the script and preview so often, and the program is not flushing memory, so after 10+ reloads the program piled up to 10+G of ram and ran out of memory.

I found out a similar memory leak in mvtools, it's probably required to simplify things until you find the filter or plugin which causes it.

[lansing]

Ok I think I found it.


def set_frame_number(n, f):
fout = f.copy()
fout.props.FrameNumber = n
return fout

def ShowFrameNumber(n,f,clip):
frame_num = f.props.FrameNumber
return core.sub.Subtitle(clip, text=str(frame_num))

ref_clip = core.std.ModifyFrame(clip=ref_clip, clips=ref_clip, selector=set_frame_number)
ref_clip = core.std.FrameEval(ref_clip, partial(ShowFrameNumber, clip=ref_clip), prop_src=ref_clip)

This code is in the middle of my script adding frame number to the frame. When I commented them out the last 2 lines the memory will always flushes to 40MB when I closed preview. If I left them there the memory will pile up and will not flush on preview close.

[lansing]

Reporting a bug, when I open a preview and start a new script, the preview window will still be running

[Mystery Keeper]

Reporting a bug, when I open a preview and start a new script, the preview window will still be runningNot a bug. Works as intended. Preview window is once initialized with the script in editor and then no longer bound to it.

[lansing]

Not a bug. Works as intended. Preview window is once initialized with the script in editor and then no longer bound to it.

I can hardly find a reason to keep the preview open if I'm starting a new script.

[Mystery Keeper]

I can hardly find a reason to keep the preview open if I'm starting a new script.It's the least intrusive way. You can just close it. If vsedit forced it close when people didn't want to close it - it would be worse. I might add an option to close preview window on new script. It won't be enabled by default.

[kriNon]

I am trying to use a 32-bit avisynth plugin that will not work with vapoursynth x64, I've got both vapoursynth 32-bit and 64-bit installed.
How would I go about making vsedit use 32-bit python, and 32-bit vapoursynth?

[poisondeathray]

I am trying to use a 32-bit avisynth plugin that will not work with vapoursynth x64, I've got both vapoursynth 32-bit and 64-bit installed.
How would I go about making vsedit use 32-bit python, and 32-bit vapoursynth?

Did you try 32bit python and 32bit vsedit ?

There doesn't seem to be 32bit R18 compiled , so try R17

https://bitbucket.org/mystery_keeper/vapoursynth-editor/downloads/

[kriNon]

Did you try 32bit python and 32bit vsedit ?

There doesn't seem to be 32bit R18 compiled , so try R17

https://bitbucket.org/mystery_keeper/vapoursynth-editor/downloads/

Thanks! That worked perfectly

[poisondeathray]

How do you comment out a whole section or bunch of lines ?

In avspmod, I could enclose the section with /* and */ , but it doesn't seem to work here

[Mystery Keeper]

How do you comment out a whole section or bunch of lines ?

In avspmod, I could enclose the section with /* and */ , but it doesn't seem to work hereVapourSynth uses Python language. You comment individual lines with # symbol. In the VS Editor you use hotkeys to:
-comment selected lines: Ctrl+Shift+C
-uncomment selected lines: Ctrl+Shift+X
-toggles selected lines comment: Ctrl+/
You can set your own hotkeys for these actions in settings.

[poisondeathray]

VapourSynth uses Python language. You comment individual lines with # symbol. In the VS Editor you use hotkeys to:
-comment selected lines: Ctrl+Shift+C
-uncomment selected lines: Ctrl+Shift+X
-toggles selected lines comment: Ctrl+/
You can set your own hotkeys for these actions in settings.


Yes, I knew about the "#" that's the same as avisynth.

But the CTRL+Shift+C / CTRL+Shift+X is awesome

In hindsight, sorry it's a dumb question because listed it's in the edit menu. DUH ....(13 strikes under the old regime :D)

There probably is a bunch of other useful stuff I haven't found yet

Thanks

[K3]

Hey, I wanted scene filtering in vapoursynth similar to avisynth (http://tp7.github.io/articles/scenefiltering/) where you can apply a filter to a section between two bookmarks with hotkeys.

The first step to this was finding a way to import scxvid keyframes into vsedit. After a bit of digging, I found that vsedit .bookmarks files were really just a plaintext file with nothing but frame numbers stored and separated by a space and a comma. I then looked into avspmod's source code to see how it preformed the action. After a couple hours of banging my head against the keyboard, I achieved importing scxvid keyframes into vsedit by getting the avspmod code that made the frame numbers then modifying it to print out a separate file.

A buddy of mine completely rewrote that code and turned it into a CLI script which you can find here. (https://hastebin.com/ewesocaput.py)

To use it, first make the scxvid keyframes and then just run the Python3 script using the given syntax when you run the script. After that, open up your video in vsedit, place any random bookmark in the video and it will create a .bookmarks file of the same name as your script and in the same directory, then open said file in notepad++ or similar and replace the contents with the contexts of the file created by the script above. Afterwards, close vsedit and reopen it and reload your video and you'll see your scxvid keyframes are loaded as bookmarks which you can skip between with ctrl+left/right arrow key.

The keyframes aren't entirely accurate and may insert false keyframes, but it's what people have done in avspmod for years and it's worked just fine.

The next course of action would be:

1. implement the option to import a .bookmarks file with vsedit's simple format of frame numbers separated by a comma and a space to make that step of the progress easier,
2. implementing/creating macros to apply your desired filter to the frame selection indicated by the bookmarks just like you can with avspmod.

Wobbly implements a way to do #2 but you can't view your filtering in real time with wobbly's preview window. The way wobbly does this is by making a python def in what it calls a "pattern" such as clip = taa.TAAmbk(clip, aatype='Nnedi3') with the def being def aa(clip):
clip = taa.TAAmbk(clip, aatype='Nnedi3')
return clip

A full script scene filtered with wobbly looks like this (https://hastebin.com/icusovapeh.py) (a couple things added by me by hand because there didn't seem to be a way to do dithering in wobby or apply a filter to the final output) Perhaps someone could make something from modified wobbly code?

Would making macros like we can with avspmod be doable? I don't have the programming knowledge to do this myself but I tried looking into everything to make it as easy and straight forward as I could for someone who does.

EDIT: here's a sample scxvid keyframes file https://pastebin.com/47GayXEZ save the paste as whatever .log or .txt.

[poisondeathray]

feature request: add x= , y= position readout for the eyedropper

[Mystery Keeper]

feature request: add x= , y= position readout for the eyedropperCan do.
Life's been hectic, but probably will have more free time soon.

[ChaosKing]

Is it possible to set the header type to y4m as default? When I open [Encode video] it's always set to "no header" and I need to reselect my preset or change it manually.
And yes the preset has header_type=1 in vsedit.config.

[fAy01]

Feature request: is it possible to have multiple tabs for comparing sources e.g. Tab1: Source Tab2: Filtered. Would you be able to implement that? Similar to avspmod.

[Mystery Keeper]

Feature request: is it possible to have multiple tabs for comparing sources e.g. Tab1: Source Tab2: Filtered. Would you be able to implement that? Similar to avspmod.Comparison of output clips in the same script is planned.

[kkka]

I am confused about it booting up with "Failed to load vapoursynth script library! Please set up the library search path in settings". This occurs for me from installing it from the ubuntu ppa's and when building both vapoursynth and vsedit from source. What settings should I have for the script library? Vapoursynth works fine outside of vsedit btw.
Ubuntu 16.04

[Mystery Keeper]

I am confused about it booting up with "Failed to load vapoursynth script library! Please set up the library search path in settings". This occurs for me from installing it from the ubuntu ppa's and when building both vapoursynth and vsedit from source. What settings should I have for the script library? Vapoursynth works fine outside of vsedit btw.
Ubuntu 16.04
Use this instruction (http://www.l33tmeatwad.com/vapoursynth101/software-setup).

[kkka]

Use this instruction (http://www.l33tmeatwad.com/vapoursynth101/software-setup).
Yup, the new instruction worked once I forced it to python 3.5 before compling vapoursynth & vsedit. on 3.6 I got a new error. Before I was going off the BUILD file. Thanks.

[l33tmeatwad]

Revisions 17 and 18 have be added to the OSX downloads page.

[fAy01]

Feature request: Could you have the timestamp of the current frame and frame number appear at the bottom of the preview screen in vsedit (that can be turned on or off accordingly)? In other words, make it possible for the user to customize the information displayed at the bottom of the preview window.

Example:
https://i.imgur.com/GqwNly0.png

[Mystery Keeper]

Feature request: Could you have the timestamp of the current frame and frame number appear at the bottom of the preview screen in vsedit (that can be turned on or off accordingly)? In other words, make it possible for the user to customize the information displayed at the bottom of the preview window.

Example:
https://i.imgur.com/GqwNly0.png
That's a good idea, thank you.
Sorry for lack of improvements.
My life has been hectic lately.

[fAy01]

That's a good idea, thank you.
Sorry for lack of improvements.
My life has been hectic lately.

could you also add a shortcut and feature 'copy current timestamp to clipboard' for creating chapters?

[DJATOM]

could you also add a shortcut and feature 'copy current timestamp to clipboard' for creating chapters?

I think it should be better to implement "Export bookmarks as chapters" :)

[fAy01]

I think it should be better to implement "Export bookmarks as chapters" :)

Automated chapters yay, but should offer different formats i.e. txt, xml, etc.

[Mystery Keeper]

Okay, before it gets out of hand. There are many improvements in VapourSynth Editor I hope to get around to implementing. Chapters is not among them. Bookmarks were never intended as a chaptering tool, neither was vsedit. If you absolutely must - you can convert bookmark files to whatever you need with Python scripts. I am intending to implement formatted frame properties pasting though.

[fAy01]

Okay, before it gets out of hand. There are many improvements in VapourSynth Editor I hope to get around to implementing. Chapters is not among them. Bookmarks were never intended as a chaptering tool, neither was vsedit. If you absolutely must - you can convert bookmark files to whatever you need with Python scripts. I am intending to implement formatted frame properties pasting though.

Right, you don't necessarily have to implement if you don't want to but it really is a useful feature to have. Using bookmarks in that way may not be the way you intended but don't the users have the freedom to use the tool you kindly provided for their own purposes?

[foxyshadis]

You might be better off posting a ticket to bitbucket as an enhancement, then if anyone feels like picking it up they can. Once in a very rare while someone else contributes. I think a decent chapter editor would be a better addition, but someone might be willing to make a quick hack of a chapter exporter from the current bookmarks, who knows.

[fAy01]

You might be better off posting a ticket to bitbucket as an enhancement, then if anyone feels like picking it up they can. Once in a very rare while someone else contributes. I think a decent chapter editor would be a better addition, but someone might be willing to make a quick hack of a chapter exporter from the current bookmarks, who knows.

Done.
https://bitbucket.org/mystery_keeper/vapoursynth-editor/issues/34/chapter-editor

[ChaosKing]

Is a true portable mode possible?
It seems that vs editor checks for installed VS installations via registry. https://bitbucket.org/mystery_keeper/vapoursynth-editor/src/6d2142eada5229df7ea766d33f923c7b555f01d7/common-src/vapoursynth/vs_script_library.cpp?at=master&fileviewer=file-view-default#vs_script_library.cpp-218

Is there a way to ignore a locally installad Vapoursynh installation in vseditor? With some batch script magic maybe?

Or can this VS check be ignored if the "portable mode" checkbox is set to true? (now it only saves the config in its own folder)
This way one can still use/test different VS version within this editor.

p.s. I tried to set plugin and lib search paths in the config file, but the editor uses always the installed VS version.

[Mystery Keeper]

Is a true portable mode possible?
It seems that vs editor checks for installed VS installations via registry. https://bitbucket.org/mystery_keeper/vapoursynth-editor/src/6d2142eada5229df7ea766d33f923c7b555f01d7/common-src/vapoursynth/vs_script_library.cpp?at=master&fileviewer=file-view-default#vs_script_library.cpp-218

Is there a way to ignore a locally installad Vapoursynh installation in vseditor? With some batch script magic maybe?

Or can this VS check be ignored if the "portable mode" checkbox is set to true? (now it only saves the config in its own folder)
This way one can still use/test different VS version within this editor.

p.s. I tried to set plugin and lib search paths in the config file, but the editor uses always the installed VS version.
Oh, right. It prefers the registry over provided paths.
If I manage to get my build environment up on Windows - I might add an option to give priority to the provided paths or the application directory. What you can do now is to rename the registry branch, so vsedit wouldn't find it.

[lansing]

I'm just installed Qt5 and downloaded the vs editor source, how do I load the entire project with Qt Creator so all the files are connected?

[Mystery Keeper]

I'm just installed Qt5 and downloaded the vs editor source, how do I load the entire project with Qt Creator so all the files are connected?

Load pro/pro.pro file.

[lansing]

Load pro/pro.pro file.

How do I add new file in the project tree in qt creator? For example, I want to add a new header file in the preview folder "pro\vsedit\Headers\my local preview folder\'vsedit\src'\preview". But after I added it, it was located under the pro folder instead, "pro\Headers\my local preview folder", and I got all the "file not found" errors by the program when I try to call any library in that header file.


#include <QtWidgets> 'QtWidgets' file not found

[Mystery Keeper]

How do I add new file in the project tree in qt creator? For example, I want to add a new header file in the preview folder "pro\vsedit\Headers\my local preview folder\'vsedit\src'\preview". But after I added it, it was located under the pro folder instead, "pro\Headers\my local preview folder", and I got all the "file not found" errors by the program when I try to call any library in that header file.


#include <QtWidgets> 'QtWidgets' file not found

Manually edit the .pro files of the projects you want to add it too.
Mind the directory variables.
Please keep consistency with the project files if you want to make your changes public.

[lansing]

Manually edit the .pro files of the projects you want to add it too.
Mind the directory variables.
Please keep consistency with the project files if you want to make your changes public.

I'm trying to submit changes, I cloned the repository to my sourcetree program, but when I tried to push it, it said I'm not authorized. I must be doing something wrong.

[Mystery Keeper]

I'm trying to submit changes, I cloned the repository to my sourcetree program, but when I tried to push it, it said I'm not authorized. I must be doing something wrong.Yup, you're not authorized. It's my repository you're trying to push to. Usually people go about it by forking the whole repository, pushing changes into their fork, then sending a pull request to me or submitting a patch.

[lansing]

Yup, you're not authorized. It's my repository you're trying to push to. Usually people go about it by forking the whole repository, pushing changes into their fork, then sending a pull request to me or submitting a patch.

Thanks I think I got it now. I sent pull request.

[lansing]

I found a display bug in the timeline slider with the latest committed version. When mouse click inside the slider and drag straight left or right, there will be a few flashes of a big black tooltip. If I click and do a quick drag to both side first, the bug will not trigger. The released version doesn't have this problem.

[Mystery Keeper]

I found a display bug in the timeline slider with the latest committed version. When mouse click inside the slider and drag straight left or right, there will be a few flashes of a big black tooltip. If I click and do a quick drag to both side first, the bug will not trigger. The released version doesn't have this problem.I've got no idea what you're talking about. Can't reproduce. Try to find vsedit config file and delete the [theme] section.

[lansing]

I've got no idea what you're talking about. Can't reproduce. Try to find vsedit config file and delete the [theme] section.

I deleted the whole config file at AppData\local\ but the problem is still there.

[Mystery Keeper]

Could you please record a video of your screen when you do that? Because I really don't know what you're talking about.

[lansing]

Could you please record a video of your screen when you do that? Because I really don't know what you're talking about.

Here (http://www.mediafire.com/file/n2xzt76zra9dpdt/tooltip_issue.mp4)

At the end I show where it wasn't trigger.

[Mystery Keeper]

Sorry, but nope. Can't reproduce.

[~ VEGETA ~]

Video is always detached in this editor, can't it be the other way around? like avspmod?

[lansing]

I'm going to tap into implementing the multi view comparison feature. I have studied the design of avspmod and avsedit plus and I think the multi tab preview of avspmod is definitely the most ideal design for video comparing . The split view of avsedit looks pretty cool when making snapshot, but it quickly became useless when comparing more than two videos.

What I'm thinking is to have a tab window for scripts and another tab window for the previews, each tab in the script window will tie to the corresponding tab in the preview window. Avspmod has this layout too but I doubt many people knew about it because it's not default. I didn't know it until today. The default combined layout of avspmod looks good until you maximize the window, where you have tons of white spaces wasted.

What are the other thought about this?

[Mystery Keeper]

I'm going to tap into implementing the multi view comparison feature. I have studied the design of avspmod and avsedit plus and I think the multi tab preview of avspmod is definitely the most ideal design for video comparing . The split view of avsedit looks pretty cool when making snapshot, but it quickly became useless when comparing more than two videos.

What I'm thinking is to have a tab window for scripts and another tab window for the previews, each tab in the script window will tie to the corresponding tab in the preview window. Avspmod has this layout too but I doubt many people knew about it because it's not default. I didn't know it until today. The default combined layout of avspmod looks good until you maximize the window, where you have tons of white spaces wasted.

What are the other thought about this?
I decided against allowing tabs for stability reasons. Don't want to lose all my work if previewing one script crashes the editor.

I am going to implement comparison eventually. But among several output nodes rather than several scripts.

[Mystery Keeper]

Video is always detached in this editor, can't it be the other way around? like avspmod?
If I try to make preview embedable - that would severely complicate the code and possibly introduce bugs. I personally find separately managing screen space of text and video preview more convenient.