bdsup2sub++ - convert and tweak bitmap subtitles.

[Selur]

there hasn't been an update for 7 month, see: https://github.com/amichaelt/BDSup2SubPlusPlus .
So yes, at least for the moment the project seems to have stopped. (latest version is still a lot newer than BDSup2Sub)
Sorry, never tried DVB-Sub subtitle which BDSub2Sup++.

[Music Fan]

Ok, so I guess he still hadn't added DVB-Sub support because he hadn't last time he answered me (on previous page).

[Selur]

yup, his replay was from may and since the last update was from "Apr 17, 2013" (see: https://github.com/amichaelt/BDSup2SubPlusPlus/commits/master) I think you are right. :)

[Music Fan]

Actually ProjectX can demux DVB subtitles ;
http://www.iphonelife.com/blog/87/how-you-can-convert-your-dvb-recordings-subtitles-idevice-friendly-mp4-subtitles

http://www.videohelp.com/tools/ProjectX

It seems to work but I get very special colors when I open the sup in SubtitleCreator, I still have to understand how to correct these subtitles.
ProjectX creates sup, sub, idx, ifo and txt.
SubtitleCreator can open sup, sub, idx and ifo, I don't know what is better.
And it seems to be converted in 720.576 while my TS is in 1920.1080.:confused:

[Selur]

ffmpeg might also able to extract them. I thought the main goal was to convert them,...

[Music Fan]

Yes, I wanna convert them to make an AVCHD with multiAVCHD (so actually not really an AVCHD but a bastard format between AVCHD and Blu-ray), and I need a sup file compatible with multiAVCHD (blu-ray type sup). I'd like also to change colors and position and I believe it can be done without OCR.
How does it work with ffmpeg ?

I'm talking about bit-map subtitles, not teletext sub.
I believe it's the norm ETSI EN 300 743.

[Selur]

probably something like: ffmpeg -i 00038.m2ts -c:s copy "track_05 - Subtitles.sub" could be used, never really played with DVB subtitles, so can't say for sure. :)

[Music Fan]

I tried but it didn't work, I got several error messages and a 0 KB file was created.
I also tried sup extension instead of sub, no file was created.

[Selur]

-> google a bit and maybe you can find a solution :)

[Music Fan]

I found several topics about DVB-sub muxing and de-muxing with ffmpeg but no one is clear, I still didn't find any command I could use.:o
I don't know ffmpeg, it doesn't look easy to use.

[Selur]

then you are lost -> best ask inside another thread and may be someone with ffmpeg and dvb-sub experience can help you further :D good luck!

[Music Fan]

Ok, I created a topic in the subtitle part of the forum ;
http://forum.doom9.org/showthread.php?t=169795

[Sparktank]

Ok, looking into it.

Anyone know what happened to paradoxical?

Looking at his GitHub profile, I can see a couple new forks he created but very little contribution for this year.

[Chetwood]

I'd also like to know that. I was wondering if he could shed some light on how to identify forced subs on BDs (http://forum.doom9.org/showthread.php?p=1659305#post1659305).

[stax76]

Does anybody know how to contact the author? I have a sample clip where sup to sub conversion fails.

[cdlvcdlv]

Does anyone how to compile the source code in Windows?
I have tried with qt-opensource-windows-x86-mingw492-5.5.0.exe (958 MB) and qt-opensource-windows-x86-mingw482-4.8.6-1.exe (328 MB) + i686-4.8.2-release-posix-dwarf-rt_v3-rev3.7z (44 MB) but I get the same error. (I would prefer not to download/install such huge compiler.)

> qmake "bdsup2sub++.pro"


This creates Makefile and another files. No errors.

> mingw32-make
g++ -c -pipe -fno-keep-inline-dllexport -std=c++11 -g -frtti -fexceptions -mthre
ads -Wall -Wextra -DUNICODE -DQT_DLL -DQT_XML_LIB -DQT_GUI_LIB -DQT_CORE_LIB -DQ
T_HAVE_MMX -DQT_HAVE_SSE -DQT_HAVE_MMXEXT -DQT_HAVE_SSE2 -DQT_THREAD_SUPPORT -I"
f:\Subtitulos\Qt\4.8.6\include\QtCore" -I"f:\Subtitulos\Qt\4.8.6\include\QtGui"
-I"f:\Subtitulos\Qt\4.8.6\include\QtXml" -I"f:\Subtitulos\Qt\4.8.6\include" -I"f
:\Subtitulos\Qt\4.8.6\include\ActiveQt" -I"debug" -I"." -I"f:\Subtitulos\Qt\4.8.
6\mkspecs\win32-g++-4.6" -o debug\bdsup2sub.o bdsup2sub.cpp
bdsup2sub.cpp:52:37: fatal error: QxtCore/QxtCommandOptions: No such file or dir
ectory
#include <QxtCore/QxtCommandOptions>
^
compilation terminated.


If this is not the place to ask this question, maybe someone might tell me where it would be.

[sl1pkn07]

is a Qt4 program. make sure you use qmake from qt4 instead of qt5

[cdlvcdlv]

make sure you use qmake from qt4 instead of qt5
If I understand the version numbers then the first attempt was doomed to failure. But maybe I had a chance in second one.
I have tried with qt-opensource-windows-x86-mingw492-5.5.0.exe (958 MB) and qt-opensource-windows-x86-mingw482-4.8.6-1.exe (328 MB) + i686-4.8.2-release-posix-dwarf-rt_v3-rev3.7z (44 MB) but I get the same error.The numbers in bold are the relevant ones, aren't they? Strangely enough, the two attempts stopped with the same error message:

#include <QxtCore/QxtCommandOptions>
^
compilation terminated.So I think there is something more I'm missing.

By the way. What would be the minimal environment needed to compile bdsup2sub++? This is around half a GiB to generate a 4 MB exe... And even so without success.

Is relevant the compiler? In qt4, three choices exist. Namely - qt-opensource-windows-x86-mingw482-4.8.6-1.exe, qt-opensource-windows-x86-vs2008-4.8.6.exe and qt-opensource-windows-x86-vs2010-4.8.6.exe.

Saludos, compañero espanishtaní. ;)

[sl1pkn07]

yes, Qt4 is a 4.8.X series, Qt5 is a 5.x.x series

ok, i see, you need install qxt https://bitbucket.org/libqxt/libqxt/wiki/Home

[cdlvcdlv]

Dl and installed libqxt-0.6.2.zip from the link you posted, unzipped, run configure.bat, make and make install. Lots of warnings about vars declared but not used, but it generated the files and copied them to their folders.

Then go to bdsup2sub++ source folder, run qmake && make... lots of warnings again and in the end...
windres -i bdsup2sub.rc -o debug\bdsup2sub_res.o --include-dir=. -DUNICODE -DQXT
_CORE_LIB -DQT_DLL -DQT_XML_LIB -DQT_GUI_LIB -DQT_CORE_LIB -DQT_HAVE_MMX -DQT_HA
VE_SSE -DQT_HAVE_MMXEXT -DQT_HAVE_SSE2 -DQT_THREAD_SUPPORT
g++ -Wl,-subsystem,console -mthreads -o debug\bdsup2sub++.exe object_script.bdsu
p2sub++.Debug -L"f:\Subtitulos\Qt\4.8.6\lib" debug\bdsup2sub_res.o -LC:/Qxt/lib
-lQxtCored -lQtXmld4 -lQtGuid4 -lQtCored4
F:/Subtitulos/mingw32/bin/../lib/gcc/i686-w64-mingw32/4.8.2/../../../../i686-w64
-mingw32/bin/ld.exe: cannot find -lQxtCored
collect2.exe: error: ld returned 1 exit status
Makefile.Debug:197: recipe for target 'debug\bdsup2sub++.exe' failed
mingw32-make[1]: *** [debug\bdsup2sub++.exe] Error 1
mingw32-make[1]: Leaving directory 'D:/Datos/Subtitulos/Programas/BDSUP2SUB/BDSu
p2SubPlusPlus-master/src'
Makefile:34: recipe for target 'debug' failed
mingw32-make: *** [debug] Error 2After some searching, I found out that I should have configured libqxt with -debug (configure -debug), what I did. Then, the "qmake && make" runs OK. It's a 14 MB debug exe, with dynamic linking, so it needs 231 additional MB to run (libgcc_s_dw2-1.dll, libstdc++-6.dll, libwinpthread-1.dll, QtCored4.dll, QtGuid4.dll, QtXmld4.dll, QxtCored.dll). But placing the dlls in the .exe folder it works. If I manage to do something useful, I would find out how to make static linking to create the neat 4 MB of the usual bdsup2sub++ releases. It would be useful to know what compiler was used (mingw, VS2008 or VS2010). There may be differences regarding to final size and performance.

The code is well-structured, but not much documented about how the conversions are done so that you can understand clearly why it does what it does.

@Chetwood: Some warnings in the code are related to forced subtitles. I hope they shed some light on the question.In file included from Subtitles\suphd.cpp:20:0:
Subtitles\suphd.h:55:10: warning: unused parameter 'index' [-Wunused-parameter]
bool isForced(int index) { return false; }
In file included from Subtitles\supbd.cpp:25:0:
Subtitles\subpicturebd.h:171:10: warning: unused parameter 'isForced' [-Wunused-
parameter]
void setForced(bool isForced)
In file included from Subtitles\subpicturebd.cpp:20:0:
Subtitles\subpicturebd.h:171:10: warning: unused parameter 'isForced' [-Wunused-
parameter]
void setForced(bool isForced)
In file included from debug\moc_suphd.cpp:9:0:
debug\../Subtitles/suphd.h:55:10: warning: unused parameter 'index' [-Wunused-pa
rameter]
bool isForced(int index) { return false; }

[asarian]

I simply got my Windows binary of BDSub2Sup++ from a STAXrip distro. No need to make life harder than it already is. :)

[outgoing]

New version released 1.0.3

https://github.com/amichaeltm/BDSup2SubPlusPlus/releases

[jpsdr]

Euh... New version ???
released this on 10 May 2018

[outgoing]

Euh... New version ???

yup but here the last version published was the previous one.

[jpsdr]

Ah... Yes, indeed.

[captainayy]

So I'm a long-time user of this software and recently decided to try to fix some of the bugs that I've run into while using the software over the years since the development seems to have otherwise stalled out.

I've made a forked branch here (https://github.com/captainayy/BDSup2SubPlusPlus) where I've been doing most of my work. I was also able to contact the original author and they gave me commit access to their branch as well.

So over the last couple of weeks I've been working on knocking out a number of bugs and I thought I'd make a test build for people to try. That can be grabbed here (https://github.com/captainayy/BDSup2SubPlusPlus/releases/tag/1.0.4). There's only a 64-bit build at the moment as I don't have a 32-bit build chain set up, but I will try to get a 32-bit build out in the next few days. Since this is using Qt 5.15.2 it should work on Windows 7, but as I only have a Windows 10 box I cannot confirm this. Please let me know if you have any issues running it on that version.

This build includes fixes for a number of issues that I've come across including:

1) This issue (https://github.com/amichaeltm/BDSup2SubPlusPlus/issues/22) where the output resolution of an IDX/SUB would get messed up like the following shot:

https://user-images.githubusercontent.com/56635/110207057-9e7ff900-7e81-11eb-95a2-291141295d34.png

2) There was an infinite loop when checking a forced picture flag when loading a BD SUP file.

3) Fixed an issue that happened when I loaded an IDX/SUB file and then set a number of subtitles to be forced then saving to BDSUP.

4) Fixed an issue where in certain BD SUPs that not all the subtitles that should have been merged together were being merged (in particular there was a SUP file from Avatar I used in testing this fix). This also had the side effect of, at least in my tests, fixing an issue reported in this post (https://forum.doom9.org/showpost.php?p=1630830&postcount=193) where if you output as XML/PNG you could get a black second image for some subtitle events.

5) If you would load a subtitle and resave it, the size of the output subtitle would increase upon each saving. This was due to a bug where the output image size and position were not staying the same as the input due to not clamping the width/height and x/y offsets. Those values are now being rounded down so that they will match the original size if the resolution and position are not otherwise changed. This now means that the files do not bloat each time you resave it with no edits.

I can also see there are a number of other outstanding issues on both the original repo and on that second forked repo that I've been given access to, but a lot of the files linked there are no longer accessible. So for anyone else who is still using this tool and would like to re-test with any files they've previously had issues with hopefully you can repost those files and open an issue on my issue tracker here:

https://github.com/captainayy/BDSup2SubPlusPlus/issues

I can't guarantee that I can implement all the requested extra features for the program (though I can certainly try) but I would at least like to get the current code to be a bit more stable and bug-free. I only have a few hours a week to work on this so development might be a bit slow but I will try to do my best. :)

[von Suppé]

So I'm a long-time user of this software and recently decided to try to fix some of the bugs that I've run into while using the software over the years since the development seems to have otherwise stalled out.
Nice to see someone taking this up. I'll test your fork later.

One of the issues that pops to mind is, BDSup2SUb would always recode images. When the images themselves need no editing (no scaling), it'd be nice if BDSup2Sub would leave them untouched. With "Output Format" set same as source (or, for instance BD SUP <--> XML/PNG) and "Palette" as "keep existing", think of only changing offsets and/or timing alterations.
Did you address this?

[Bandits]

So I'm a long-time user of this software and recently decided to try to fix some of the bugs that I've run into while using the software over the years since the development seems to have otherwise stalled out.

I've made a forked branch here (https://github.com/captainayy/BDSup2SubPlusPlus) where I've been doing most of my work. I was also able to contact the original author and they gave me commit access to their branch as well.

So over the last couple of weeks I've been working on knocking out a number of bugs and I thought I'd make a test build for people to try. That can be grabbed here (https://github.com/captainayy/BDSup2SubPlusPlus/releases/tag/1.0.4). There's only a 64-bit build at the moment as I don't have a 32-bit build chain set up, but I will try to get a 32-bit build out in the next few days. Since this is using Qt 5.15.2 it should work on Windows 7, but as I only have a Windows 10 box I cannot confirm this. Please let me know if you have any issues running it on that version.

This build includes fixes for a number of issues that I've come across including:

1) This issue (https://github.com/amichaeltm/BDSup2SubPlusPlus/issues/22) where the output resolution of an IDX/SUB would get messed up like the following shot:

2) There was an infinite loop when checking a forced picture flag when loading a BD SUP file.

3) Fixed an issue that happened when I loaded an IDX/SUB file and then set a number of subtitles to be forced then saving to BDSUP.

4) Fixed an issue where in certain BD SUPs that not all the subtitles that should have been merged together were being merged (in particular there was a SUP file from Avatar I used in testing this fix). This also had the side effect of, at least in my tests, fixing an issue reported in this post (https://forum.doom9.org/showpost.php?p=1630830&postcount=193) where if you output as XML/PNG you could get a black second image for some subtitle events.

5) If you would load a subtitle and resave it, the size of the output subtitle would increase upon each saving. This was due to a bug where the output image size and position were not staying the same as the input due to not clamping the width/height and x/y offsets. Those values are now being rounded down so that they will match the original size if the resolution and position are not otherwise changed. This now means that the files do not bloat each time you resave it with no edits.

I can also see there are a number of other outstanding issues on both the original repo and on that second forked repo that I've been given access to, but a lot of the files linked there are no longer accessible. So for anyone else who is still using this tool and would like to re-test with any files they've previously had issues with hopefully you can repost those files and open an issue on my issue tracker here:

https://github.com/captainayy/BDSup2SubPlusPlus/issues

I can't guarantee that I can implement all the requested extra features for the program (though I can certainly try) but I would at least like to get the current code to be a bit more stable and bug-free. I only have a few hours a week to work on this so development might be a bit slow but I will try to do my best. :)

Have you looked at this post?

https://forum.doom9.org/showthread.php?p=1828627#post1828627

[von Suppé]

Have you looked at this post?

https://forum.doom9.org/showthread.php?p=1828627#post1828627
Good link indeed, I know I've read it some time. r0lZ is very aware of the several bugs in various versions, as his BD3D2MK3D tool also uses BDSup2Sub.
As for point 6 in that post, I do have a comment/request.

Cropping the transparent rectangular around the text can cause a nasty effect. As for vertical positioning, when authoring image based subtitles, one has to take into account that the type of characters will determine the height of the image. Images of lines with "low" characters like "a c e r m n" will come out lower than those with characters like "A C E g y r ç". Properly authored SUBs and SUPs have a deliberately added transparent background in such a way, that it seems all lines were "written on the same line".
So, editing the transparent surrounds can have a "bobbing" effect on subtitles that are quickly consecutive. If possible, I'd like to see at least the possibility to leave the transparent borders untouched.

[captainayy]

Have you looked at this post?

https://forum.doom9.org/showthread.php?p=1828627#post1828627

Yes. If you read the list of items I fixed you should note that 6, 7, 9 and 10 should all be fixed in this test build. At least as far as I can tell with the files I could trigger the issues with. :)

But, I still need people to also test and verify if those things are completely fixed for the subtitle files that they have that trigger them as I only have so many examples to test with. Also, the file sample linked in that post is no longer accessible so hence the request that anyone file an issue and repost their files with issues if they can still reproduce them.

[captainayy]

One of the issues that pops to mind is, BDSup2SUb would always recode images. When the images themselves need no editing (no scaling), it'd be nice if BDSup2Sub would leave them untouched. With "Output Format" set same as source (or, for instance BD SUP <--> XML/PNG) and "Palette" as "keep existing", think of only changing offsets and/or timing alterations.
Did you address this?
No, but I did have the similar idea in mind allowing for a setting that prevents it from trying to optimize the images and leaves them untouched when saving. I'll add it to my TODO list. :goodpost:

I'm thinking that I'd probably leave the default behavior as is unless you specify either through a UI setting or a new CLI switch to not optimize the images.

[hubblec4]

thanks captainayy for your work on this project.
When I have time I will help to test some fixes.
I had also posted some issues to the old repo from amichaeltm. Should I renew this issues in your repo?

[captainayy]

thanks captainayy for your work on this project.
When I have time I will help to test some fixes.
I had also posted some issues to the old repo from amichaeltm. Should I renew this issues in your repo?

Yeah feel free. Also having any additional samples to test against for regressions, etc. would be great if anyone can provide them. :)

[r0lZ]

So I'm a long-time user of this software and recently decided to try to fix some of the bugs
Great news ! Thanks a lot.

You already know the posts where I tried to describe the bugs I discovered. I hope I can be helpful by giving some examples of problematic subtitle streams. I'm not sure I have the time and inclination to test myself if the bugs are really fixed, but I'll try to help as much as I can.

Avatar.sup (https://download.videohelp.com/r0lZ/ProblematicSubs/Avatar.sup)

full-width subtitles.sup (https://download.videohelp.com/r0lZ/ProblematicSubs/full-width%20subtitles.sup)

Bad Palette Sample.sup (https://download.videohelp.com/r0lZ/ProblematicSubs/Bad%20Palette%20Sample.sup)

Multiple_ODS_sample.sup (https://download.videohelp.com/r0lZ/ProblematicSubs/Multiple_ODS_sample.sup)

[captainayy]

Great news ! Thanks a lot.

You already know the posts where I tried to describe the bugs I discovered. I hope I can be helpful by giving some examples of problematic subtitle streams. I'm not sure I have the time and inclination to test myself if the bugs are really fixed, but I'll try to help as much as I can.

Avatar.sup (https://download.videohelp.com/r0lZ/ProblematicSubs/Avatar.sup)

full-width subtitles.sup (https://download.videohelp.com/r0lZ/ProblematicSubs/full-width%20subtitles.sup)

Bad Palette Sample.sup (https://download.videohelp.com/r0lZ/ProblematicSubs/Bad%20Palette%20Sample.sup)

Multiple_ODS_sample.sup (https://download.videohelp.com/r0lZ/ProblematicSubs/Multiple_ODS_sample.sup)

I will take a look at those samples. Thank you!

Edit:

I've only had a chance so far to open up the full-width subtitles.sup one but that one has an interesting thing where it looks like the x1 position value is overflowing a 32-bit signed integer value:

https://i.ibb.co/dg37KM9/image.png

As you can see in the next index the position values are correct again:

https://i.ibb.co/yFGJ06S/image.png

Interesting stuff...

[captainayy]

Well I was at least so far able to solve the issue with the full-width subtitles.sup file. It may be a few days before I can double check the others. The other benefit to the fix is that this can now extract one additional subpicture that SubtitleEdit cannot. Subtitle #30 gets mangled like this:

https://i.ibb.co/N6D2c8w/image.png

where as bdsup2sub++ can extract two subtitles. Though the first one obviously is a bit off because off what looks like missing data in the SUP file.

https://i.ibb.co/m5HtPtp/image.png

https://i.ibb.co/60kLW2z/image.png

I guess I should ask, how was this file made? There's a huge amount of data that is just zeros in the file. For that subtitle 30, there's a segment size defined for the ODS data that ends up pointing into the middle of that zero'd out data. This trips up the original BDSup2Sub and this version as well. So I had to add some code that basically searches the rest of the SUP file to try to find the next PGS segment or it hits the end of the file. That helped it find that subtitle #31 and allowed it to continue parsing the rest of the PGS blocks in the file.

[r0lZ]

I guess I should ask, how was this file made?
Honestly, I don't remember. I just kept it with the other "problematic subtitles" just to have them at my disposal for further analysis. I remember only that it was extracted from an oriental movie. AFAIK, all BDs with such full-width subtitles are coming from China, Hong Kong, Korea, India etc... Those BD are usually badly authored, especially the 3D-BD, where the subtitles are almost always flat, and often containing errors. Also, many times, but not always, they contain a fully invisible subtitle starting at 0:00:00, for an unknown reason.

IIRC, I have extracted the subtitle stream with TsMuxeR, but I don't think it is the culprit.

[captainayy]

Honestly, I don't remember. I just kept it with the other "problematic subtitles" just to have them at my disposal for further analysis. I remember only that it was extracted from an oriental movie. AFAIK, all BDs with such full-width subtitles are coming from China, Hong Kong, Korea, India etc... Those BD are usually badly authored, especially the 3D-BD, where the subtitles are almost always flat, and often containing errors. Also, many times, but not always, they contain a fully invisible subtitle starting at 0:00:00, for an unknown reason.

IIRC, I have extracted the subtitle stream with TsMuxeR, but I don't think it is the culprit.

Cool. Yeah I definitely appreciate the extra problematic samples to test against. It was just really weird seeing a whole section of the file that what was MBs and MBs of just zeros so was just curious if that was done intentionally to create a broken file or if someone actually really did author such a broken subtitle stream (yikes.... :scared:). :thanks:

I'll try to look at the other samples here this weekend, but I think I have something close enough to a fix at least for that sample. Just need to test that the fix doesn't cause issues for anything else that previously works.

[mood]

it's possible not open cmd line window on startup?

Save the language option "remember last language saved" so you don't have to change language every time you save a subtitle?

thanks ;)

[captainayy]

it's possible not open cmd line window on startup?

Unless something has changed this is a limitation of Qt applications on Windows that support running both via GUI and commandline. The issue only manifests on Windows and Linux or macOS has no such issue. If you can point me to a solution that would allow both console support and GUI support to continue working on Windows without also affecting console output and redirection when run via CLI, then I would happily merge it in.

Though I'm a few years behind on doing Qt application development so if there's a way to solve the issue I'm all ears.

[von Suppé]

I'm thinking that I'd probably leave the default behavior as is unless you specify either through a UI setting or a new CLI switch to not optimize the images.
As for GUI, it would be nice if that option would be present in the "Conversion Settings" window and its setting would be remembered.

[hubblec4]

Yes this seems to be a behaviour on Window. On Linux I have also no console at startup.
One solution I have found was to start such a program in minimized state and bring it to normal state.

[von Suppé]

The time-editor in the "Edit Frame" window behaves weird when trying to apply small increases or decreases for the "Start Time" and "End Time" values. The edited timecode jumps back to it's native value when saving changes, or Start and End Time end up showing same value.
I also wonder why the Duration value shows two decimals, where the unit is already milliseconds (ms).

[captainayy]

As for GUI, it would be nice if that option would be present in the "Conversion Settings" window and its setting would be remembered.

Yeah, that's what I was thinking as well. I'll make it unchecked by default to not break existing behavior, but will make it a setting in the INI that would be restored if you check it.

The time-editor in the "Edit Frame" window behaves weird when trying to apply small increases or decreases for the "Start Time" and "End Time" values. The edited timecode jumps back to it's native value when saving changes, or Start and End Time end up showing same value.

Ok, I will look into this.

I also wonder why the Duration value shows two decimals, where the unit is already milliseconds (ms).

No idea, but I agree. Should just be rounded to an integer value.

Yes this seems to be a behaviour on Window. On Linux I have also no console at startup.
One solution I have found was to start such a program in minimized state and bring it to normal state.

Appreciate the suggestion. I'll look into doing that.

[von Suppé]

I had a short play-around with your latest 1.0.4b. I noticed that in "Edit Frame" window, changing X and Y offsets don't work. After "Save Changes", offsets jump back to initial values. To be sure I also checked export result. Can you take a look? Also Center, Top and Bottom buttons seem to not respond.

With SUP, Y offset starts counting at the top pixel. Therefor, "top offset" value is pretty easy to visualize. What I'm missing in the "Frame Edit" window is the option to set a "bottom offset" value (in conjunction to the above-mentioned "Bottom" button). Of course one can back-calculate by "screensize minus Y offset minus image height", but it's too cumbersome. In the "move all captions" window this function is present. I think the option belongs in "single image edit" too.

[captainayy]

I had a short play-around with your latest 1.0.4b. I noticed that in "Edit Frame" window, changing X and Y offsets don't work. After "Save Changes", offsets jump back to initial values. To be sure I also checked export result. Can you take a look? Also Center, Top and Bottom buttons seem to not respond.

Yeah I figured it out. Seems to be the same issue I fixed here in this commit:

https://github.com/captainayy/BDSup2SubPlusPlus/commit/d28667cbd96b00d4745fe013da444fa3c9445ef7

Looks like the previous person working on this was trying to move some old-style for loops to the newer C++11 foreach loops but didn't do it properly so the loops only edit a copy of an object not the original objects itself when iterating over them. That seems to also be the issue you noticed in the Edit Frame dialog because as soon as I changed the loop to work on object references the values stuck around after you leave the text box. I'll have to go through the code and try to figure out where else this might have occurred.

With SUP, Y offset starts counting at the top pixel. Therefor, "top offset" value is pretty easy to visualize. What I'm missing in the "Frame Edit" window is the option to set a "bottom offset" value (in conjunction to the above-mentioned "Bottom" button). Of course one can back-calculate by "screensize minus Y offset minus image height", but it's too cumbersome. In the "move all captions" window this function is present. I think the option belongs in "single image edit" too.

I can look into this but no promises on changing things simply because I don't know the full scope and impact of such a change. It would require some exploration and probably feedback from other users as this would be a breaking change with old behavior. This will probably get pushed back a bit in lieu of fixing other bugs, but I've added it to my TODO list to look at.

[von Suppé]

Another option - if possible - I'd like to see is to be able to put in framenumber in the "Edit Frame" window, just like in the JAVA version.

https://i.ibb.co/CtgzG8N/framenumber.png (https://imgbb.com/)

[sfatula]

Can't seem to find any, in case it exists somewhere or easy to post, I need to make a build on arm64. Is there a place where the package requirements are documented?

[Stereodude]

I've only had a chance so far to open up the full-width subtitles.sup one but that one has an interesting thing where it looks like the x1 position value is overflowing a 32-bit signed integer value:

https://i.ibb.co/dg37KM9/image.png

As you can see in the next index the position values are correct again:

https://i.ibb.co/yFGJ06S/image.png

Interesting stuff...
FWIW, the forced subtitles in the English subtitle track from the 2D US Blu-ray of Avatar track do the same thing.

https://i.imgur.com/p4CilFa.png

The forced subtitles in the English subtitle track from the 3D US Blu-ray of Avatar does not.

BTW, thanks for your efforts! :thanks:

[r0lZ]

Avatar 3D is well known for the problem of their subtitles. In the BD3D, there are two subtitle streams with the same UIDs, one in the main AVC M2TS (the primary view, used when you watch the stream in 2D) and one in the AVC M2TS (dependent stream, used only for 3D). If you are using the 3D version of the BD, don't worry, as 2 streams with the same UID cannot be parsed correctly with most software demuxers !