AddGrainC (now with Chroma noise & YUY2, RGB)

[foxyshadis]

As an experiment I made a version of Tom Barry's AddGrain with chroma noise, no more need for scripting workarounds.

AddGrain(var,hcorr,vcorr,uvar,seed)
AddGrainC(var,uvar,hcorr,vcorr,seed)

var, uvar:
luma and chroma variance.
chroma does nothing in rgb mode.

hcorr,vcorr:
horizontal & veritcal correlation.

seed:
int, to keep the same grain on every frame.

Unlike the original, these are all named and optional and default to 0.0 except var, which is 1.0.

It may be faster, it may also be SSE2 only (haven't run it on the Athlon yet). Thought it might be useful to others, I'll finish up the readme if there's any demand.

Download v1.7.1 here.

One name is meant to be backward compatible, one is meant to make more sense, I don't know which I prefer so I just left both.

Changelist:
1.0	2003/06/18   Tom Barry    Initial Release
1.1	2006/06/01   Foxyshadis   Chroma grain + constant seed
1.2	2006/06/06   Foxyshadis   Supports YUY2, RGB. Fix cache mess.
1.3	2006/06/10   Foxyshadis   Crashfix, noisegen optimization
1.4	2006/08/11   Foxyshadis   Constant replaces seed, seed repeatable
1.5	2010/05/07   Foxyshadis   Limit the initial seed generation to fix memory issues.
1.5.1   2010/05/13   Firesledge   The source code compiles on Visual C++ versions older than 2008
1.5.2   2011/10/26   Firesledge   Removed the SSE2 requirement.
1.5.3   2011/10/26   Firesledge   Fixed coloring and bluring in RGB24 mode.
1.5.4   2011/10/27   Firesledge   Fixed bad pixels on the last line in YV12 mode when constant=true,
                                  fixed potential problems with frame width > 4096 pixels
                                  and fixed several other minor things.
1.6.0   2011/10/28   LaTo INV.    Added SSE2 code (50% faster than MMX).
1.6.1   2011/10/29   LaTo INV.    Automatic switch to MMX if SSE2 is not supported by the CPU.
1.7.0   2012/08/16   Firesledge   Supports Y8, YV16, YV24 and YV411 colorspaces.
1.7.1   2013/11/25   Firesledge   64-bit version.

[Backwoods]

404 on the link good buddy, over.

[Didée]

Ah, foxyshadis is entering plugin land ... /me rubs hands

Nice extension to AddGrain. Less juggling-around with separating & merging color planes.

BTW: It seems there's a long standing issue with AddGrain. Somehow, if during processing a AddGrain'ed clip is duplicated, used otherwise, and later on combined again with the original AddGrain'ed clip, then the noise pattern is no more the same. Seems like the filter starts with a different seed for processing the child frame, instead of using the seed from the mother frame.
At times, this is highly unpropitious. The usual workaround is to not apply AddGrain directly to a clip, but to apply it to a neutral grey clip instead, and subtracting this one from the clip you want to process. This way mother and child keep having the same pattern.
Sorry for I've no example at hand right now (and can't make one, since I'm already sleeping )

From the sourcecode I can tell nothing (no clue about how these things are handled). Perhaps someone in the knowings can see where it's going wrong.

[BigDid]

Originally Posted by Didée

...(and can't make one, since I'm already sleeping )...

You can type and sleep, wonderful

To stay on the subject: same 404 error when trying to download

Did

[foxyshadis]

Heh, I forgot that I always put stuff in the /random folder... ^^;; Sorry.

I've been doing plugins for a while, it's just that they usually don't pan out so there's no point in releasing.

What I suspect is happening there is the cache gets blown, so that even though both paths lead back to the same addgrain'd clip, it gets done twice - but I might be entirely wrong. I'll take a look.

[Backwoods]

http://foxyshadis.slightlydark.com/random/AddGrainC.zip

[Mug Funky]

hey, cool. i just made a scripty workaround the other day.

would it also be possible to keep the same seed for each frame? this could be useful for avoiding banding when using addgrain for dither (perhaps it could even be added into gradfun2db?)

[Chainmax]

Sounds like it would make a great addition to BlockTerminator . One thing though: I assume the chroma noise won't look like rainbows or color bands, what would it look like?

[foxyshadis]

It will look like chroma noise. The output should be identical to this:

function AddChromaGrain(clip c, int "grain") {
	grainu=c.utoy().addgrain(grain,0,0)
	grainv=c.vtoy().addgrain(grain,0,0)
	return ytouv(grainu,grainv).mergeluma(c)
}

I need to organize my invented script functions better, they're all over several hard drives...

Here, I'll put up a screenshot.

Go easy on chroma noise; heavy luma noise can look artsy, but heavy chroma noise just looks like a horrible capture. (That was uvariance 100, btw.)

I was thinking about having a single starting seed, but a constant seed actually sounds useful. Btw, I made modifications of blockbuster as well, so that its arguments are more useful. I have other ideas for it, when I remember to pick it back up.

Edit: Okay, I updated, fixing a bug with the luma/chroma noise interaction (maybe I only broke it today ), and adding a seed parameter for Mug. Use anything >= 0 to enable.

Actually it appears to be using std. dev., not variance, the variable names lied. =p So maybe I'll change var and uvar to dev and udev.

Edit 2 jun: updated readme in archive as well.

[Fizick]

Thanks for update!
IMHO, first parameter of AddGrain is variance, or squared deviation (sigma*sigma), and is not standard deviation.

[Fizick]

And feature request: YUY2 support.

[foxyshadis]

I'll look into it, I've only used YV12 before but I have a Plan that might let me use the existing mmx writeover code. I'm sure there's some function I could use in RemoveGrain, but ouch that code hurts my brain, or Tritical's filters; if I can't figure it out then Interleaved2Planar/Planar2Interleaved or straight C will work.

Didée, IanB explained the problem as coming from playing fast and loose with the cache, and offered a quick workaround I'll insert.

[Fizick]

Probaly it may be implemented as interleaved, not planar.
At last with equal luma and chroma noise it is trivial

[foxyshadis]

Originally Posted by Fizick

And feature request: YUY2 support.

Done.

RGB24/32 as well, but luma only. (How would you make gaussian noise across 3 color channels?)

Originally Posted by Didée

Somehow, if during processing a AddGrain'ed clip is duplicated, used otherwise, and later on combined again with the original AddGrain'ed clip, then the noise pattern is no more the same.

Fixed. Or at least covered up, I'm not quite sure which.

Enjoy. It was a lot of fun to do, really, even if I had to recode much of it. Hope it isn't horrifying to you real plugin devs. Threw comments and a new readme in. Now I just have to learn SSE and figure out how to parallelize the inner update loop. ;D

[Fizick]

thanks, i will try use it.
I often used AddGrain for denoise filter development.

[Fizick]

I tried it.
"Evaluate: System exception. Illegal instruction."

I have AthlonXP.
Need in SSE2?
But when I compile your source myself (VCToolkit2003), DLL works fine for me.
Wrong source?

[foxyshadis]

No, I just compiled it with SSE2 for testing and didn't turn it off. I uploaded the normal SSE one.

Maybe I'll do what Kassandro does. (But seriously, thanks for reminding me to turn that option off for a final release, it doesn't change the speed anyway.)

[edit] It seems to have some bug that causes crashes on reload with mid-to-large res. I'll fix soon.

[foxyshadis]

Originally Posted by foxyshadis

[edit] It seems to have some bug that causes crashes on reload with mid-to-large res. I'll fix soon.

Fixed. I also partly optimized the random generation, which you'd only notice if you use it many times in a script, like me. >.>

[Chainmax]

So, to use AddGrain(x,0,0) on luma and AddGrain(y,0,0) on chroma, what would be the corresponding AddGrainC call?

[foxyshadis]

AddGrainC(x,y)

That's it.