Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
20th November 2013, 22:31 | #41 | Link |
Avisynth language lover
Join Date: Dec 2007
Location: Spain
Posts: 3,433
|
Not really, I just assumed Groucho had copied the example from somewhere else.
The problem with the code is that those variables should just be local variables inside GetFrame, especially since nothing else uses them. Putting them at the class level means that two threads cannot call GetFrame at the same time (on a single instance of the filter) without interfering with each other. Last edited by Gavino; 20th November 2013 at 22:33. |
21st November 2013, 02:16 | #42 | Link |
HeartlessS Usurer
Join Date: Dec 2009
Location: Over the rainbow
Posts: 11,010
|
Apologies to the Grouchy man, Gavino, you seemed to me to be a Sort of teacher,
no longer. Why would you expect a newbie to consider multi threading, I dont understand that and I consider myself not a total newbie. Gavino, methinks you were not at your best there. Appologies to the Grouchy man (He He). Bit pissed at the moment, but, will, (god wiilling, [if there is such an object]) arise, again.
__________________
I sometimes post sober. StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace "Some infinities are bigger than other infinities", but how many of them are infinitely bigger ??? Last edited by Guest; 21st November 2013 at 03:50. Reason: 3 |
21st November 2013, 02:26 | #43 | Link |
Join Date: Mar 2006
Location: Barcelona
Posts: 5,034
|
Last edited by Groucho2004; 21st November 2013 at 10:23. |
21st November 2013, 11:45 | #44 | Link | |
Avisynth language lover
Join Date: Dec 2007
Location: Spain
Posts: 3,433
|
Quote:
At a simpler level, there was also the point that variables that were only required inside one function, and not needed to persist, were declared at the class level, which is bad practice regardless of the multithreading issue. |
|
Tags |
avisynth, c++, compile, dll |
Thread Tools | Search this Thread |
Display Modes | |
|
|