Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
22nd August 2013, 20:06 | #81 | Link |
Registered User
Join Date: Aug 2013
Posts: 5
|
I managed to compile d2vsource with ffmpeg 2.0.1.
Thanks, jackoneill. The problem with git version of ffmpeg was that my vapoursynth was built with ffmpeg 1.2.1. I didn't know that I must use the same ffmpeg for compile vapoursynth and d2vsource. Then I tried to build vapoursynth with ffmpeg git but I also received errors. And now I used ffmpeg 2.0.1 to compile vapoursynth and d2vsource and everything works fine. Last edited by opteronup; 22nd August 2013 at 20:15. |
17th November 2013, 15:40 | #82 | Link |
Beyond Kawaii
Join Date: Feb 2008
Location: Russia
Posts: 724
|
Please read several posts starting from this one:
http://forum.doom9.org/showthread.ph...50#post1653750 Not sure, but it seems that d2v.Source hangs if requested a frame with number beyond the real source length.
__________________
...desu! |
17th November 2013, 16:40 | #83 | Link |
Guest
Posts: n/a
|
Yeah, the filter simply doesn't handle such a case. It seems to just assume that any frame number it is given is in the valid range. I'll send them a pull request real fast with a fix.
If you want a compile a test version to try the fix I have it here. If it works, I'll do the pull request up. Fix in the getframe functions was to add: Code:
if (n >= d->d2v->frames.size()) { n = d->d2v->frames.size() - 1; } Last edited by handaimaoh; 17th November 2013 at 17:00. |
17th November 2013, 16:57 | #84 | Link | |
Avisynth language lover
Join Date: Dec 2007
Location: Spain
Posts: 3,433
|
Quote:
However, I guess that does not apply in Vapoursynth. (?) (and it's still bad practice anyway for a source filter) Last edited by Gavino; 17th November 2013 at 17:00. |
|
17th November 2013, 18:03 | #87 | Link |
HeartlessS Usurer
Join Date: Dec 2009
Location: Over the rainbow
Posts: 11,009
|
Code:
n = (n<0) ? 0 : (n>= vi.num_frames) ? vi.num_frames - 1 : n; // Range limit frame n
__________________
I sometimes post sober. StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace "Some infinities are bigger than other infinities", but how many of them are infinitely bigger ??? Last edited by StainlessS; 18th November 2013 at 02:57. Reason: added SPACE |
17th November 2013, 18:08 | #88 | Link | |
Guest
Posts: n/a
|
Quote:
Code:
// Range limit n n = (n < 0) ? 0 : (n >= d->vi.numFrames) ? d->vi.numFrames - 1 : n; Last edited by handaimaoh; 17th November 2013 at 18:22. |
|
17th November 2013, 21:39 | #91 | Link |
Beyond Kawaii
Join Date: Feb 2008
Location: Russia
Posts: 724
|
In my opinion it is not wise to omit a guard based on assumption that it won't be needed in the next release. It might be broken later. Or some other software might misuse the library interface. Since the check is only made once per frame - 'tis a quite welcome and non-hindering precaution.
__________________
...desu! |
17th November 2013, 21:55 | #92 | Link | |
Registered User
Join Date: Mar 2005
Posts: 129
|
Quote:
Maybe I should also add a check to make sure water is wet too. |
|
17th November 2013, 22:04 | #93 | Link | |
Professional Code Monkey
Join Date: Jun 2003
Location: Kinnarps Chair
Posts: 2,588
|
Quote:
On the subject of backseat coders (which we've been having quite a few of recently), the correct answer is: Code:
if (d->vi->numFrames && d->vi->numFrames <= n) n = d->vi->numFrames -1;
__________________
VapourSynth - proving that scripting languages and video processing isn't dead yet Last edited by Myrsloik; 17th November 2013 at 22:12. |
|
17th November 2013, 22:43 | #94 | Link |
HeartlessS Usurer
Join Date: Dec 2009
Location: Over the rainbow
Posts: 11,009
|
Best place for check on having video is in constructor, not getframe. Guess it means -ve n is ok then.
Maybe so.
__________________
I sometimes post sober. StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace "Some infinities are bigger than other infinities", but how many of them are infinitely bigger ??? |
19th November 2013, 19:53 | #97 | Link |
Beyond Kawaii
Join Date: Feb 2008
Location: Russia
Posts: 724
|
This video makes VapourSynth crash near the end when loaded with D2V Source. Other d2v projects don't, so the bug most likely is not in VS.
__________________
...desu! |
23rd November 2013, 22:58 | #98 | Link | |
Registered User
Join Date: Mar 2005
Posts: 129
|
Quote:
|
|
29th November 2013, 02:23 | #99 | Link |
Beyond Kawaii
Join Date: Feb 2008
Location: Russia
Posts: 724
|
Hope this crash report can help.
__________________
...desu! |
29th November 2013, 11:22 | #100 | Link | |
Registered User
Join Date: Mar 2005
Posts: 129
|
Quote:
|
|
Tags |
d2v, dgindex, vapoursynth |
Thread Tools | Search this Thread |
Display Modes | |
|
|