DeblockPP7

HolyWu · 23rd April 2018, 17:56

https://github.com/HomeOfVapourSynth...nth-DeblockPP7

HolyWu · 24th April 2018, 06:14

Update r2.

Add SSE2 code path.

ChaosKing · 24th April 2018, 07:17

I get white dots on black edges in many scenes:

clip = clip.pp7.DeblockPP7(qp=5)

Happens in r1 & r2.

And as always awesome work!

HolyWu · 24th April 2018, 09:38

Quote:

Originally Posted by ChaosKing

I get white dots on black edges in many scenes:

That's weird. I use your picture for testing but can't reproduce the same issue. Anyway, try DeblockPP7-test.7z and see what happens.

Besides, the source seems not blocky...or I'm blind.

ChaosKing · 24th April 2018, 10:22

Quote:

Originally Posted by HolyWu

That's weird. I use your picture for testing but can't reproduce the same issue. Anyway, try DeblockPP7-test.7z and see what happens.

No more white dots.

It's blocky in some other scenes, I just wanted to show the bug.

HolyWu · 24th April 2018, 12:05

Quote:

Originally Posted by ChaosKing

No more white dots.

Thanks for your report.

Update r3.

Fix pixel overflow.
Add SSE4.1 code path.

ChaosKing · 24th April 2018, 12:29

Quick bench on ryzen @3.7ghz DVD 720x480
Deblock-text: 750fps
r3: 860fps

This deblock filter is fast!

Selur · 25th April 2018, 17:39

Thanks

Boulder · 28th April 2018, 09:29

Is the filter more suitable for cartoon or real life sources? I've tried to find information over the internet but I didn't see any tests.

HolyWu · 28th April 2018, 10:02

Quote:

Originally Posted by Boulder

Is the filter more suitable for cartoon or real life sources? I've tried to find information over the internet but I didn't see any tests.

I can't say whether it's more suitable or not. If you have some blocky DVDs or videos at hand then you could just try it by yourself.

Boulder · 28th April 2018, 12:57

I tested it briefly on a MacGyver DVD that I had on my HDD. The filter is very strong and blurs the image noticably already at qp=2 so it seems that for real-life sources, I should still use SmoothD2 with the Avisynth proxy.

EDIT: Thanks anyway for a port, there are never too many of them

HolyWu · 28th April 2018, 13:45

Quote:

Originally Posted by Boulder

I tested it briefly on a MacGyver DVD that I had on my HDD. The filter is very strong and blurs the image noticably already at qp=2 so it seems that for real-life sources, I should still use SmoothD2 with the Avisynth proxy.

May I ask you to provide an unprocessed video of 5~10 seconds for me, also the arguments you used for SmoothD2, hence I can have proper materials for testing. Thanks.

Boulder · 28th April 2018, 15:45

Sure - here's one clip to test on: https://drive.google.com/open?id=1rs...MPloQrPfd-Mtzz .

I would probably use SmoothD2(quant=5, zw=3, num_shift=4) on the episodes at least based on this clip. It affects the noisiest areas, pressing them down slightly but doesn't oversmooth the few details that are left. Of course, some people prefer a smooth output but in my eyes, a slightly noisy video is better to watch.

HolyWu · 29th April 2018, 03:09

Update r4.

Change default qp value to 2.0. The type is float instead of int now.
Add mode parameter. Previous versions use mode=2 internally.

Boulder · 29th April 2018, 18:18

Thank you, it's very usable now with the fine-grained qp

EDIT: A nice speedup over SmoothD2 too, 450.99 fps vs. 25.54 fps

23rd April 2018, 17:56	#1 \| Link
HolyWu Registered User Join Date: Aug 2006 Location: Taiwan Posts: 392	DeblockPP7 https://github.com/HomeOfVapourSynth...nth-DeblockPP7

24th April 2018, 06:14	#2 \| Link
HolyWu Registered User Join Date: Aug 2006 Location: Taiwan Posts: 392	Update r2. Add SSE2 code path.

24th April 2018, 07:17	#3 \| Link
ChaosKing Registered User Join Date: Dec 2005 Location: Germany Posts: 1,795	I get white dots on black edges in many scenes: clip = clip.pp7.DeblockPP7(qp=5) Happens in r1 & r2. And as always awesome work! __________________ AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth VapourSynth Portable FATPACK \|\| VapourSynth Database

24th April 2018, 12:29	#7 \| Link
ChaosKing Registered User Join Date: Dec 2005 Location: Germany Posts: 1,795	Quick bench on ryzen @3.7ghz DVD 720x480 Deblock-text: 750fps r3: 860fps This deblock filter is fast! __________________ AVSRepoGUI // VSRepoGUI - Package Manager for AviSynth // VapourSynth VapourSynth Portable FATPACK \|\| VapourSynth Database Last edited by ChaosKing; 24th April 2018 at 12:32.

25th April 2018, 17:39	#8 \| Link
Selur Registered User Join Date: Oct 2001 Location: Germany Posts: 7,277	Thanks __________________ Hybrid here in the forum, homepage

28th April 2018, 09:29	#9 \| Link
Boulder Pig on the wing Join Date: Mar 2002 Location: Finland Posts: 5,733	Is the filter more suitable for cartoon or real life sources? I've tried to find information over the internet but I didn't see any tests. __________________ And if the band you're in starts playing different tunes I'll see you on the dark side of the Moon...

28th April 2018, 12:57	#11 \| Link
Boulder Pig on the wing Join Date: Mar 2002 Location: Finland Posts: 5,733	I tested it briefly on a MacGyver DVD that I had on my HDD. The filter is very strong and blurs the image noticably already at qp=2 so it seems that for real-life sources, I should still use SmoothD2 with the Avisynth proxy. EDIT: Thanks anyway for a port, there are never too many of them __________________ And if the band you're in starts playing different tunes I'll see you on the dark side of the Moon...

28th April 2018, 15:45	#13 \| Link
Boulder Pig on the wing Join Date: Mar 2002 Location: Finland Posts: 5,733	Sure - here's one clip to test on: https://drive.google.com/open?id=1rs...MPloQrPfd-Mtzz . I would probably use SmoothD2(quant=5, zw=3, num_shift=4) on the episodes at least based on this clip. It affects the noisiest areas, pressing them down slightly but doesn't oversmooth the few details that are left. Of course, some people prefer a smooth output but in my eyes, a slightly noisy video is better to watch. __________________ And if the band you're in starts playing different tunes I'll see you on the dark side of the Moon...

29th April 2018, 03:09	#14 \| Link
HolyWu Registered User Join Date: Aug 2006 Location: Taiwan Posts: 392	Update r4. Change default qp value to 2.0. The type is float instead of int now. Add mode parameter. Previous versions use mode=2 internally.

29th April 2018, 18:18	#15 \| Link
Boulder Pig on the wing Join Date: Mar 2002 Location: Finland Posts: 5,733	Thank you, it's very usable now with the fine-grained qp EDIT: A nice speedup over SmoothD2 too, 450.99 fps vs. 25.54 fps __________________ And if the band you're in starts playing different tunes I'll see you on the dark side of the Moon... Last edited by Boulder; 29th April 2018 at 18:25.