VapourSynth Editor 2

[ChaosKing]

Originally Posted by poisondeathray

Yes, no problem

But they share the same config file. If you edit the preferences on one, it affects the other

In Windows:

There is also a portable mode! You can find it in settings.

[lansing]

Originally Posted by lansing

In r9, RAM usage will only go double on playback and go back down when stopped. So this mechanism was broken somewhere in between the updates in the years. Right now the RAM will not go back down when stopped. Will fix.

More update on this, this looks to be a lot bigger issue than I thought. The RAM usage came from the frame cache. The program is caching two copies of a frame at a time. One copy would be convert to RGB for preview and the other copy for process like running benchmark and retrieving frame info. This led to unnecessary doubling of RAM usage during preview playback. As a result, a supposedly 600 MB of frame cache for a 1080 video was doubled to 1600 MB.

In comparison, the same 1080 video on Avspmod only uses 270 MB of RAM...there's a lot of improvement to be done...

[ChaosKing]

So that is why after a while + multiple previews vsedit just chrashed for me.

[lansing]

I put up a R3.1 test build for testing. This probably breaks benchmark and encoding.

This build I removed one of the frame copy in the frame cache, that only saved about 10% of memory usage. What really reduced the memory are changing the frame requesting queue from using max number of threads to 2 and setting frame cache from 100 to 1. The result is:

720 x 480:
before: 310 MB
after: 120 MB

1920 x 1080:
before: 1600 MB
after: 476 MB

From my observation I don't see any negative impact but I have a fast machine, so please test on your machine and give feedback on the change.

[poisondeathray]

R3.1 test seems ok so far. But you're right - benchmark crashes it

[lansing]

Originally Posted by poisondeathray

R3.1 test seems ok so far. But you're right - benchmark crashes it

What is your RAM usage on playback compare to R3?

[poisondeathray]

Originally Posted by lansing

What is your RAM usage on playback compare to R3?

1280x720p23.976

R3 634 MB

R3.1 149 MB

V1 R19 636 MB

[poisondeathray]

request:
1) ability to drag tabs to reorder them
2) can you add right click > copy to to new tab in the tab context menu ?

[shph]

request for mouse middle click to zoom (similar to "classic" vseditor preview window)

[lansing]

Does anyone know how to use the "preview advance setting"? I have no idea what it does, I changed the matrix coeff but nothing happen to my image?

[lansing]

Originally Posted by shph

request for mouse middle click to zoom (similar to "classic" vseditor preview window)

No that's not a good way to zoom. When zooming, you will want to go with something like 100%->150%->200%->250%, little by little, but this along will require 3 clicks if you're to do it with middle click. This should be handle by wheel scroll.

[l33tmeatwad]

Just tested out the latest from the repository. Everything seems to be working fine, however it always crashes when closing on macOS. Not sure what's going on, haven't had a chance to run a debug, but I figured I'd mention that in case I don't get around to it anytime soon.

[ChaosKing]

One thing that is a bit annoying in vseditor2 is when your script has an error. With vs1 the log windows was always visible and I could immediately spot the problem. In vs2 you always need to explicitly open the log window (on every program start) to see if there is an error.
Maybe the last status of the log window could also be saved (opened/closed)
OR
a small icon indicates if there an error is present
OR
the log opens automatically if the script contains an error (on F6 / F7 pressed)

[lansing]

Updating my status, I've been busy playing Xenoblade Chronicle for the past week, update on the project will continue after I finished it.

[Tohno_Neil]

I tried the R3 X64 version，popup a window and program closed.

Unable to locate the program input point _ZNSt3pmr20get_default_resourceEv in the dynamic link library Qt5Core.dll

Any debug mode?

[l00t]

Dear lansing, I really appreciete your work on improving VSEditor. I have a small question regarding when are you planning to put back the Crop Editor? Also Zoom functions bound to 1, 2, 3 was very useful.

[Tima]

I can't make VSEditor 2 to become default editor for vpy files on Windows:

- I can associate it, but when I click on the script, VSEditor opens with a blank tab instead of the target script.
(VSEditor doesn't even pick up script argument when called via CLI)

- In addidion, I get theme_presets.txt file created in the folder where my script is located.

Both items seem to be regressions compared to v1.

[poisondeathray]

R3.1 issue with the FI color picker - >8bit seem to read as 8bit values, and sometimes values are off

Works ok in R3.0 or R19 original

[sl1pkn07]

Hi

i have this when close the app

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Abortado (`core' generado)

builded with GCC 10.2.0 and QT 5.15.1

and also, anyone can review this?

is for add support for use XDG paths ('/home/$USER/.config' and '/home/$USER/.local/share' ) as directory path defaults for themes and bookmarks in linux

diff --git a/vsedit/src/main_window.cpp b/vsedit/src/main_window.cpp
index 5f068d1..3156207 100644
--- a/vsedit/src/main_window.cpp
+++ b/vsedit/src/main_window.cpp
@@ -2266,11 +2266,24 @@ void MainWindow::slotSaveBookmarksToFile()
     {
         QFileInfo fileInfo(scriptName);
         //get file path and fileName without extension
+#ifdef Q_OS_LINUX
+        QString xdgDataHome = QFile::decodeName(qgetenv("XDG_CONFIG_HOME"));
+        if (xdgDataHome.isEmpty())
+            xdgDataHome = QDir::homePath() + "/.local/share/vsedit";
+        QDir xdgDataHome_path;
+        if (!xdgDataHome_path.exists(xdgDataHome))
+            xdgDataHome_path.mkpath(xdgDataHome);
+#else
         QString filePath = fileInfo.absolutePath();
+#endif
         QString scriptFileName = fileInfo.baseName();

         QString fileName = QFileDialog::getSaveFileName(this,
+#ifdef Q_OS_LINUX
+                            tr("Save bookmark"), xdgDataHome + QDir::separator() + scriptFileName,
+#else
                             tr("Save bookmark"), filePath + QDir::separator() + scriptFileName,
+#endif
                             tr("Text file (*.txt)"));

         if (fileName.isEmpty())
diff --git a/vsedit/src/script_editor/script_editor.cpp b/vsedit/src/script_editor/script_editor.cpp
index 238b6e4..4af581b 100644
--- a/vsedit/src/script_editor/script_editor.cpp
+++ b/vsedit/src/script_editor/script_editor.cpp
@@ -941,7 +941,17 @@ void ScriptEditor::loadThemeSettings()
 {
     QString savedThemeName = m_pSettingsManager->getThemeName();

-    QFile file("theme_presets.txt");
+#ifdef Q_OS_LINUX
+    QString xdgConfigHome = QFile::decodeName(qgetenv("XDG_CONFIG_HOME"));
+    if (xdgConfigHome.isEmpty())
+        xdgConfigHome = QDir::homePath() + "/.config/vsedit";
+    QDir xdgConfigHome_path;
+    if (!xdgConfigHome_path.exists(xdgConfigHome))
+            xdgConfigHome_path.mkpath(xdgConfigHome);
+    QFile file(xdgConfigHome + "/theme_presets.txt");
+#else
+    QFile file("theme_presets.txt");
+#endif
     if (!file.open(QIODevice::ReadOnly | QIODevice::Text)){
         file.open(QIODevice::WriteOnly); // create file if it doesn't exist
         file.open(QIODevice::ReadOnly | QIODevice::Text);
diff --git a/vsedit/src/settings/settings_dialog.cpp b/vsedit/src/settings/settings_dialog.cpp
index e71b833..59c0c20 100644
--- a/vsedit/src/settings/settings_dialog.cpp
+++ b/vsedit/src/settings/settings_dialog.cpp
@@ -285,7 +285,17 @@ void SettingsDialog::loadThemePresets()
      * load from temp string and add preset names to theme list model
      * the list model will then update combobox automatically
     */
-    QFile file("theme_presets.txt");
+#ifdef Q_OS_LINUX
+    QString xdgConfigHome = QFile::decodeName(qgetenv("XDG_CONFIG_HOME"));
+    if (xdgConfigHome.isEmpty())
+        xdgConfigHome = QDir::homePath() + "/.config/vsedit";
+    QDir xdgConfigHome_path;
+    if (!xdgConfigHome_path.exists(xdgConfigHome))
+        xdgConfigHome_path.mkpath(xdgConfigHome);
+    QFile file(xdgConfigHome + "/theme_presets.txt");
+#else
+    QFile file("theme_presets.txt");
+#endif
     if (!file.open(QIODevice::ReadOnly | QIODevice::Text)){
         file.open(QIODevice::WriteOnly); // create file if it doesn't exist
         file.open(QIODevice::ReadOnly | QIODevice::Text);
@@ -375,7 +381,17 @@ void SettingsDialog::saveThemeSettings()
     m_pSettingsManager->setThemeName(
                 m_ui.themePresetSelectionComboBox->currentText());

-    QFile file("theme_presets.txt");
+#ifdef Q_OS_LINUX
+    QString xdgConfigHome = QFile::decodeName(qgetenv("XDG_CONFIG_HOME"));
+    if (xdgConfigHome.isEmpty())
+        xdgConfigHome = QDir::homePath() + "/.config/vsedit";
+    QDir xdgConfigHome_path;
+    if (!xdgConfigHome_path.exists(xdgConfigHome))
+        xdgConfigHome_path.mkpath(xdgConfigHome);
+    QFile file(xdgConfigHome + "/theme_presets.txt");
+#else
+    QFile file("theme_presets.txt");
+#endif
     if (!file.open(QFile::WriteOnly | QFile::Truncate | QIODevice::Text )) {
         QMessageBox::information(this, tr("Unable to write to file"),
                                  file.errorString());
@@ -933,9 +945,19 @@ void SettingsDialog::slotHandleThemeExport()

 void SettingsDialog::slotExportSelectedThemePresets(QStringList &a_selectedThemePresets)
 {
+    QString xdgConfigHome = QFile::decodeName(qgetenv("XDG_CONFIG_HOME"));
+    if (xdgConfigHome.isEmpty())
+        xdgConfigHome = QDir::homePath() + "/.config/vsedit";
+    QDir xdgConfigHome_path;
+    if (!xdgConfigHome_path.exists(xdgConfigHome))
+        xdgConfigHome_path.mkpath(xdgConfigHome);
     QString defaultDir = QStandardPaths::writableLocation(QStandardPaths::DesktopLocation);
     QString fileName = QFileDialog::getSaveFileName(this,
-                        tr("Export theme preset"), defaultDir + QDir::separator() + tr("theme"),
+#ifdef Q_OS_LINUX
+                        tr("Export theme preset"), xdgConfigHome + QDir::separator() + tr("theme"),
+#else
+                        tr("Export theme preset"), defaultDir + QDir::separator() + tr("theme"),
+#endif
                         tr("Theme file (*.txt)"));

     if (fileName.isEmpty())

greetings

[lansing]

Sorry for the late response, I have finished all my games now and will be back on the project tomorrow. Looks like VSAPI 4.0 is still not ready yet, so I guess I haven't miss anything much.