Updated aWarpSharp version, with some new features

[ryrynz]

Did anyone manage to get in touch with MarcFD for his original code if it's that much better? real.finder can you post screenshots for comparison?

[real.finder]

here we are

no filter


awarpsharp in awarpsharp2


awarpsharp in old awarpsharp


and according to SEt it should be same https://forum.doom9.org/showthread.p...95#post1687695

[ryrynz]

Thanks, I'm gonna have to go with awarp2 in this example, I can see the original awarp is a big sharper and thinner in some areas but awarp2 is sharper in some areas also.
The original awarp blows out the reds, Misato's shirt is worse (most noticeable around the arms) awarp2 is almost identical in appearance to the original frame as it should be.. you said chroma is better but that's simply not the case here.

[real.finder]

Originally Posted by ryrynz

I'm gonna have to go with awarp2 in this example, I can see the original awarp is a big sharper and thinner in some areas but awarp2 is sharper in some areas also.
The original awarp blows out the reds, Misato's shirt is worse, awarp2 is almost identical in appearance to the original frame as it should be.. you said chroma is better but that's simply not the case here.

the original awarp is more clean and accurate, it not blows out the reds, it's just did the job with warp chroma to luma (Default behavior)

and aside from all that, awarpsharp2 has awarpsharp() for compatibility with old awarpsharp, it should be same (or at least with unnoticeable difference) regardless of whether they are better or worse

[ryrynz]

How is it accurate when it differs so much from the original frame? The reds are brighter than in the original frame and they shouldn't be. There's no win here for the original awarp.

[real.finder]

Originally Posted by ryrynz

How is it accurate when it differs so much from the original frame? The reds are brighter than in the original frame and they shouldn't be. There's no win here for the original awarp.

not something unexpected here cuz it warp chroma with luma as I said

aside from chroma, you can see how it accurate without artifacts in the yellow text for example

[ryrynz]

The warping has stretched the very left side of the text but in other areas in the overlay it's more like the original frame, plus the overlay's appearance doesn't appear to match the effect on the lines in the actual
frame which is the more important part to be analyzing. I guess like anything awarpsharp2 could use a tweak or two but I'm still not seeing the original being more pleasing to me.

jpsdr, are you planning on tweaking this at all?

[real.finder]

so here another one that prove that old awarpsharp is better

https://s18.postimg.org/rucuq99uh/warp2.png

https://s18.postimg.org/u075k8xq1/old_warp.png (ignore the left line bug, it's know things since age and one reason that awarpsharp2 existing)

ColorBars(pixel_type="yv12")
info
aWarpSharp_aWarpSharp

[ryrynz]

Surely changing the depth parameter in awarp2 could provide a similar output?

[real.finder]

Originally Posted by ryrynz

Surely changing the depth parameter in awarp2 could provide a similar output?

don't think so, the warp depth is same in both, I highly suspect the blur, maybe something else like aSobel but not the warp depth

[real.finder]

well, the chorma seems to have some bug in awarpsharp() in awarpsharp2, it's like using depthc=0, it should be depthc=depth/2 for 420, so:-

aWarp(aSobel(128).aBlur(2,0), depth=16,chroma=4, depthc=8)

this is the most close to original awarpsharp

but this made me learn something new, and it's I can use depthc=0 for chroma guide by luma I was think that depth=0 result will be always like unprocessed clip

edit1: well, no, it's not the same in Pinterf and older ver., as they seems to unwarp chroma if it guide by luma and depthc=0, awarpsharpmt is just use depth/2 for the depthVC (8 in this case)
SEt ver. (2012) work fine with the awarpshrp() in the awarpsharp2 dll, so the bug happened in 2015 one

edit2: also this lead us to another bug in the awarpsharpmt, and it's that depthVC default is not depthC as it should

aside form all thing, there are still there are some difference in both luma and chroma... not big but it's there

[ryrynz]

jpsdr, I can't for the life of me get awarp4 to work. If I just call awarpsharp() by itself it works fine.
No problems with Pinterf's version. Tried all versions, just get it crashing, plugin pack also crashes.

Ryzen on W10CU.

input4x = last.Spline64Resize(width*4, height*4, src_left=0.375, src_top=0.375)
edgemask = last.aSobel.ablur
aWarp4(input4x,edgemask,depth=2)

[jpsdr]

Originally Posted by ryrynz

Did anyone manage to get in touch with MarcFD for his original code if it's that much better?

I've contacted him, and asked for the code, as i was asked to add the others blur modes.
I thought he would provide me the whole code, but he gave me only the blur part code. I've not asked him more, assuming he probably didn't want to give me the whole code...

[ryrynz]

Got nothing to lose, you might as well ask.

[jpsdr]

Originally Posted by real.finder

edit1: well, no, it's not the same in Pinterf and older ver., as they seems to unwarp chroma if it guide by luma and depthc=0, awarpsharpmt is just use depth/2 for the depthVC (8 in this case)
SEt ver. (2012) work fine with the awarpshrp() in the awarpsharp2 dll, so the bug happened in 2015 one

edit2: also this lead us to another bug in the awarpsharpmt, and it's that depthVC default is not depthC as it should

Oups... I thought i've fixed it, but depthCV is depthV as default instead of depth indeed... I'll fix it in a next release.
About edit1 : Do you meen the SEt version awarpsharp() is realy identical to original, but the versions afterward not anymore ?

[jpsdr]

Originally Posted by ryrynz

jpsdr, I can't for the life of me get awarp4 to work

This code works for me. Does it for you ?

SetMemoryMax(64)
a=AVISource("Test.avi",False,"YV12").SetPlanarLegacyAlignment(True)
d=aSobel(a)
aWarp4(a.Spline36Resize(4*a.width,4*a.height),d)

Edit
Just tested this :

SetMemoryMax(64)
AVISource("Test.avi",False,"YV12").SetPlanarLegacyAlignment(True)
input4x = last.Spline64Resize(width*4, height*4, src_left=0.375, src_top=0.375)
edgemask = last.aSobel.ablur
aWarp4(input4x,edgemask,depth=2)

It works for me.

[ryrynz]

Tried the above but using ffdshow_source() and it crashes, it doesn't matter what MT mode I try whether I specify setmemorymax or not.
Tried W7 and XP releases for compatibility, I have the latest runtimes installed.

[jpsdr]

Ah... As i never use MT mode, i never thought of testing them... But strange, filters should report themselves as MT_MULTI_INSTANCE.
But if you use external multi-threading, in that case, maybe you should try adding threads=1 in the parameters.

[ryrynz]

Tried threads=1 on asobel, ablur and awarp4 with no success along with setting prefetch value accordingly.

[jpsdr]

Sorry... For now, no idea in that case. If you use AVISource and not ffdshow_source, does it crash ? Unfortunately, even if this is the issue, i would have no idea of the why...