Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Video Encoding > MPEG-4 AVC / H.264

Reply
 
Thread Tools Search this Thread Display Modes
Old 16th April 2021, 10:40   #41  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,542
Quote:
Originally Posted by StainlessS View Post
Yeh, I'll third and forth it.
Too slang for me. Please translate
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 16th April 2021, 11:36   #42  |  Link
StainlessS
HeartlessS Usurer
 
StainlessS's Avatar
 
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,980
Quote:
Originally Posted by jpsdr View Post
I'll go with MasterNobody's fix.
Quote:
Originally Posted by videoh View Post
I'll second that.
Quote:
Originally Posted by tormento View Post
Any update, guys?
Quote:
Originally Posted by StainlessS View Post
Yeh, I'll third and forth it.
Sorry T, not so amusing.
__________________
I sometimes post sober.
StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace

"Some infinities are bigger than other infinities", but how many of them are infinitely bigger ???
StainlessS is offline   Reply With Quote
Old 16th April 2021, 17:37   #43  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
I don't intend to make a new build for now, as it take a long time, and the last update has no effect on PC build. I'll make a new build only when there is a "significant" update => A fix, or a new feature.
But i've updated the github, so, feel free...
__________________
My github.
jpsdr is offline   Reply With Quote
Old 19th April 2021, 15:38   #44  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,542
Quote:
Originally Posted by jpsdr View Post
I'll make a new build only when there is a "significant" update => A fix, or a new feature.
Having x264 to accept 16 bit format is a great update.

Any chance to include the -dither part of x265 into x264?

I hope someone more skilled than me will compile that build.
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 28th April 2021, 17:42   #45  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
I forgot. I made a quick not frofiled t_mod test build for FranceBB to test his xavc patch, this build include the 16 bits avs fix, you can check/test it.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 29th April 2021, 09:07   #46  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,542
Quote:
Originally Posted by jpsdr View Post
I forgot. I made a quick not frofiled t_mod test build for FranceBB to test his xavc patch, this build include the 16 bits avs fix, you can check/test it.
Already testing.

Using internal dither is way faster than dithering with AVS+ scripts, we are talking about 15-20% when going from 16bit to 8/10 bit.
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 29th April 2021, 10:50   #47  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 2,883
feeding 16bit planar works like a charm!
XAVC Classes also work like a charm!

Quote:
So... I think the Changelog is something like:

- It's now possible to feed 16bit planar directly from Avisynth+
- It's now possible to encode in XAVC Intra Class 50, 100, 200, 300 and 480
Code:
x264.exe "AVS Script.avs" --avcintra 50 --avcintra-flavor sony
Code:
x264.exe "AVS Script.avs" --avcintra 100 --avcintra-flavor sony
Code:
x264.exe "AVS Script.avs" --avcintra 200 --avcintra-flavor sony
Code:
x264.exe "AVS Script.avs" --avcintra 300 --avcintra-flavor sony
Code:
x264.exe "AVS Script.avs" --avcintra 480 --avcintra-flavor sony
ColorBars in XAVC Intra Classes: https://we.tl/t-Sza28LpyXo

Now I'm finally happy here at work!

Once enough people have tested it, if you could make a final build with OpenCL enabled in x64 that would be great!

(and only if you have time and just for my old computer sitting at home, an x86 XP compatible build would be very sweet too for me and other xp die-hard)

Last edited by FranceBB; 29th April 2021 at 10:54.
FranceBB is offline   Reply With Quote
Old 29th April 2021, 17:31   #48  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
I don't do OpenCL, and post #43 still valid. Check on my standard realeases if x86 builds are XP compliant, the next ones will not be different.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 29th April 2021, 18:09   #49  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 2,883
Quote:
Originally Posted by jpsdr View Post
I don't do OpenCL
Oh, that's a shame...


Quote:
Originally Posted by jpsdr View Post
Check on my standard realeases if x86 builds are XP compliant
Nope, Bcrypt and AcquireSRWLockExclusive are missing... Well, it doesn't matter...

The important thing is that I've got the classes on Win10.
FranceBB is offline   Reply With Quote
Old 10th May 2021, 16:35   #50  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
New proper released build, not a quick version.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 12th May 2021, 12:44   #51  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 2,883
Great!
I tested the build, it works just fine as I've encoded an XAVC Intra Class 10bit planar feeding it with a 16bit 4:2:2 planar, but... here's the thing: my AppleProRes masterfile was 10bit planar 4:2:2, but after indexing it I had to go all the way up to 16 planar 4:2:2 and feed x264 which then used the Sierra 2-4A Error Diffusion Dithering to go back to 10bit planar, which is... well... alright, but I couldn't feed x264 with 10bit 4:2:2 planar directly as it was saying that it's not supported.

Maybe in the future it would be worth adding support for 10bit planar as well to avoid useless dithering if sources are 10bit planar in the first place.

This is just me thinking out loud, though.

Thanks for the build, Jean Philippe.

Last edited by FranceBB; 12th May 2021 at 12:50.
FranceBB is offline   Reply With Quote
Old 12th May 2021, 18:18   #52  |  Link
benwaggoner
Moderator
 
Join Date: Jan 2006
Location: Portland, OR
Posts: 4,752
Quote:
Originally Posted by FranceBB View Post
Great!
I tested the build, it works just fine as I've encoded an XAVC Intra Class 10bit planar feeding it with a 16bit 4:2:2 planar, but... here's the thing: my AppleProRes masterfile was 10bit planar 4:2:2, but after indexing it I had to go all the way up to 16 planar 4:2:2 and feed x264 which then used the Sierra 2-4A Error Diffusion Dithering to go back to 10bit planar, which is... well... alright, but I couldn't feed x264 with 10bit 4:2:2 planar directly as it was saying that it's not supported.

Maybe in the future it would be worth adding support for 10bit planar as well to avoid useless dithering if sources are 10bit planar in the first place.

This is just me thinking out loud, though.
You could use ffmpeg to do 10-bit 4:2:2 passthrough to see if there's a meaningful difference in the results between that and the 16-bit passthrough. Or dump the two outputs to .y4m and compare a diff of them.

In general, using error diffusion doesn't seem to be needed in doing 10-to-16-to-10. The intermediate 16 has enough precision that a straight truncated conversion will return the same values as long as you're not doing any filtering (including scaling).
__________________
Ben Waggoner
Principal Video Specialist, Amazon Prime Video

My Compression Book
benwaggoner is offline   Reply With Quote
Old 26th May 2021, 09:46   #53  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,542
Can we please make a point about direct HBD support in current x264 builds?

AFAIK JPSDR has implemented it, plus a Sierra dithering to output to lower bitplanes, but without OpenCL, DJATOM supports it but without dither.

The perfect build would be with dithering and OpenCL. Please
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 30th May 2021, 09:40   #54  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
In the dawn of time, during my first attempts to build x264, the build failed with an OpenCL related error. Adding --disable-opencl allowed the build to success, and as i'm not interested in OpenCL, i didn't want to spend time to search why the build failed and how fix this.
Out of curiosity, just now, i tested to make a build removing --disable-opencl, to see if by any chances, things changed since.
And the build worked. So, unless bad unexpected surprise, there is a big chance that the next release will have OpenCL, or at least, not build with --disable-opencl.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 30th May 2021, 10:46   #55  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 2,883
Quote:
Originally Posted by jpsdr View Post
So, unless bad unexpected surprise, there is a big chance that the next release will have OpenCL, or at least, not build with --disable-opencl.
Great news.
FranceBB is offline   Reply With Quote
Old 30th May 2021, 11:31   #56  |  Link
DJATOM
Registered User
 
DJATOM's Avatar
 
Join Date: Sep 2010
Location: Ukraine, Bohuslav
Posts: 377
OpenCL stuff in x264 is 8 bit only. Why do we need it nowadays, when CPUs yields much better performance? I have tested with rtx2070 and it's even slower than plain CPU encode
__________________
Me on GitHub
PC Specs: Ryzen 5950X, 64 GB RAM, RTX 2070
DJATOM is offline   Reply With Quote
Old 30th May 2021, 13:31   #57  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 2,883
Maybe for some scenarios, but in my case I've seen some improvement on a Quadro P4000 on my server. The reason is that such a server is almost always busy encoding Apple ProRes or whatever to XDCAM MPEG-2 or doing some linear transformation from AVC Intra Class log to BT709 whatever in the meantime, so if I can free up the CPU it's always a good thing. As a matter of fact I did in the past and I've seen some improvements for low bitrate (2.5 Mbit/s to 5 Mbit/s) FULL HD 8bit x264 preset medium High 4:2:0 --ref 4 encode from masterfiles that are supposed to go to the web (like Twitter, Facebook, Instagram etc).

I know that this is a bit different from the everyday folk usage, but professionally speaking you always wanna make the best out of your server and I can't of course use NVEnc for those kind of files so if one of the encoders like x264 can offload something to the GPU, why not...

Last edited by FranceBB; 30th May 2021 at 13:36.
FranceBB is offline   Reply With Quote
Old 31st May 2021, 18:00   #58  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
The reason i'm not interested in OpenCL, is that i have a very old blur memory of reading that it produced result less good than with pure CPU for of course the exact same encode.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 31st May 2021, 20:12   #59  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Royal Borough of Kensington & Chelsea, UK
Posts: 2,883
Quote:
Originally Posted by jpsdr View Post
The reason i'm not interested in OpenCL, is that i have a very old blur memory of reading that it produced result less good than with pure CPU for of course the exact same encode.
That's correct. Any kind of parallelization produces a slightly worse quality for the very same encode at the same bitrate, however if we compare it with something like Intel VA-API encoder or the NVIDIA NVEnc proprietary encoder, x264 still yields a significant advantage in terms of quality, so... some people think it's kinda worth it.

But again, it's a matter of taste.
For what is worth, thank you for integrating my patch for XAVC and also for allowing 16bit planar, those two things alone made my day.

What would make it perfect would be VideoLAN integrating it in the official repository, but... I don't think that's ever gonna happen...
FranceBB is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 06:02.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.