Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Hardware & Software > Software players

Reply
 
Thread Tools Search this Thread Display Modes
Old 14th September 2023, 22:16   #2061  |  Link
hubblec4
Matroska find' ich toll
 
Join Date: Apr 2008
Posts: 1,361
Hi clsid

Since when can MPC-HC process the ProjectionPoseRoll element and rotate the video?

My test file from the Matroska Playback repo is suddenly rotated correctly. The test version at the time was 1.8.6 and it didn't work there.
hubblec4 is offline   Reply With Quote
Old 15th September 2023, 08:42   #2062  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,329
Parsing of the element was added to LAV 0.75.1 (mid 2021), all you need after that is a video renderer that can perform rotations based on the metadata.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Old 15th September 2023, 12:32   #2063  |  Link
hubblec4
Matroska find' ich toll
 
Join Date: Apr 2008
Posts: 1,361
Cool, great news and thank you nevcairiel for improvements for Matroska playback.
hubblec4 is offline   Reply With Quote
Old 15th September 2023, 13:43   #2064  |  Link
hubblec4
Matroska find' ich toll
 
Join Date: Apr 2008
Posts: 1,361
One more question:

Is there also a support to rotate for the the x-axis and y-axis (ProjectionPoseYaw and ProjectionPosePitch)?
hubblec4 is offline   Reply With Quote
Old 15th September 2023, 14:06   #2065  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,329
A 2D image does not rotate around those axis.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Old 15th September 2023, 15:17   #2066  |  Link
hubblec4
Matroska find' ich toll
 
Join Date: Apr 2008
Posts: 1,361
OK, but why not?
It is technical not a problem, right?
hubblec4 is offline   Reply With Quote
Old 15th September 2023, 23:15   #2067  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,329
Its a 2D image, you want to rotate it into a third dimension, with a 2D video renderer. Why? Cameras don't record like this, displays dont show like this, renderers dont render like this.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Old 16th September 2023, 13:24   #2068  |  Link
huhn
Registered User
 
Join Date: Oct 2012
Posts: 7,773
to get the most inefficient way to create a letterbox?
huhn is offline   Reply With Quote
Old 17th September 2023, 18:43   #2069  |  Link
Cutterkin
Registered User
 
Join Date: Nov 2022
Posts: 9
MediaInfo.dll in MPC-HC.2.0.0.138.x64.zip

Just FYI, the MediaInfo.dll inside the MPC-HC.2.0.0.138.x64.zip development build is the 32 bit version. The one installed by MPC-HC.2.0.0.138.x64.exe is the proper 64 bit flavor.

And as always, thank you greatly for your continued work on this.

Edit - now fixed.

Last edited by Cutterkin; 17th September 2023 at 19:33.
Cutterkin is offline   Reply With Quote
Old 23rd September 2023, 12:46   #2070  |  Link
v0lt
Registered User
 
Join Date: Dec 2008
Posts: 1,907
Rotate a frame in MKV

I found a problem with rotation.
I used the following command.
Code:
ffmpeg -display_rotation 90 -i "movie.mp4" -y -c copy movie90.mp4
ffmpeg -display_rotation 90 -i "movie.mp4" -y -c copy movie90.mkv
ffplay.exe plays MP4 and MKV equally, rotates the frame 90 degrees counterclockwise.

MPC-HC and MPC-BE rotate the MP4 frame counterclockwise (same as ffplay.exe), but rotate the MKV frame clockwise.

Is there a bug in MPC-HC and MPC-BE or in FFmpeg?
v0lt is offline   Reply With Quote
Old 23rd September 2023, 15:13   #2071  |  Link
hubblec4
Matroska find' ich toll
 
Join Date: Apr 2008
Posts: 1,361
Matroska defines all positive values from 0 to 180 use the clockwise rotation, all negative values means counterclockwise rotation.
hubblec4 is offline   Reply With Quote
Old 23rd September 2023, 19:12   #2072  |  Link
v0lt
Registered User
 
Join Date: Dec 2008
Posts: 1,907
Quote:
Originally Posted by hubblec4 View Post
Matroska defines all positive values from 0 to 180 use the clockwise rotation, all negative values means counterclockwise rotation.
Hmm.
Element Specifications > ProjectionPoseRoll
Quote:
Specifies a roll rotation to the projection. Value represents a counter-clockwise rotation, in degrees, around the forward vector. ...
Here it is not clear where the “vector forward” is directed (from the viewer or from the display) and which side of the vector should be looked at to count the angle (usually from the side of the arrow, but I would like confirmation). You can find “heads” and “planes” on the Internet, which doesn’t help. In general, an illustration for the article or official samples could close the question.

Therefore, we read the notes.
Specification Notes > Rotation
Quote:
The ProjectionPoseRoll Element (see (#projectionposeroll-element)) can be used to indicate that the image from the associated video track SHOULD be rotated for presentation. For instance, the following representation of the Projection Element (#projection-element)) and the ProjectionPoseRoll Element represents a video track where the image SHOULD be presented with a 90 degree counter-clockwise rotation, with the EBML tree shown as XML :
Code:
<Projection>
  <ProjectionPoseRoll>90</ProjectionPoseRoll>
</Projection>
I don't remember seeing this before when I implemented frame rotation support for MKV in MPC-BE. This description is more understandable and it differs from what you write.

If I understood everything correctly, then support for frame rotation for MKV in MPC-BE and MPC-HC is done incorrectly.
v0lt is offline   Reply With Quote
Old 24th September 2023, 11:50   #2073  |  Link
hubblec4
Matroska find' ich toll
 
Join Date: Apr 2008
Posts: 1,361
Oh yes, you are right.

What a inaccurate description LOL.
You could ask Steve for better text there. I'm also confused now.

I can understand the counter-clockwise method but we have positive and negative values and this changes the direction too.

Negative value plus counter-clockwise = clockwise?

Before ProjectionPoseRoll element there was the Tags method and there was only positive values for a clockwise rotation.
90 means clockwise rotation and why should now value 90 with ProjectionPoseRoll a counter-clockwise and -90 is then the clockwise rotation?

really weird.
hubblec4 is offline   Reply With Quote
Old 24th September 2023, 12:22   #2074  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,329
I tried to look at the ffmpeg code, but its written very confusingly. One path negates the rotation, the other one doesn't, it doesn't use the defined helper functions to get the rotation but calculates it itself for some reason or another.

From my understanding of the wording of it, I would think that the ffmpeg code is at fault here, because the forward vector of an image should be coming out of the image towards the user? But its a very weird way to describe it without an example or reference file to confirm.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders

Last edited by nevcairiel; 24th September 2023 at 13:11.
nevcairiel is offline   Reply With Quote
Old 25th September 2023, 23:02   #2075  |  Link
Emulgator
Big Bit Savings Now !
 
Emulgator's Avatar
 
Join Date: Feb 2007
Location: close to the wall
Posts: 1,477
Coming from most physic rules, (and geometry does see ccw as positive too) the right-hand rule should imply that:
If thumb points to viewer (positive values assumed), then index finger would point ccw for positive Z-rotation values.
(hope I did not screw that one up ;-)
__________________
"To bypass shortcuts and find suffering...is called QUALity" (Die toten Augen von Friedrichshain)
"Data reduction ? Yep, Sir. We're that issue working on. Synce invntoin uf lingöage..."
Emulgator is offline   Reply With Quote
Old 5th October 2023, 20:31   #2076  |  Link
clsid
*****
 
Join Date: Feb 2005
Posts: 5,607
Update yt-dlp
__________________
MPC-HC 2.1.2
clsid is offline   Reply With Quote
Old 21st October 2023, 22:42   #2077  |  Link
hirahi
Registered User
 
Join Date: Apr 2022
Posts: 20
When playing a folder that has been ripped from a DVD using MPC-HC 2.0.0.162, the video becomes choppy and choppy.

MPC-BE and MPC=HC up to 2.0.0.138 can be played without problems
hirahi is offline   Reply With Quote
Old 22nd October 2023, 01:12   #2078  |  Link
clsid
*****
 
Join Date: Feb 2005
Posts: 5,607
Provide a sample.

Any other people with same problem?
__________________
MPC-HC 2.1.2
clsid is offline   Reply With Quote
Old 22nd October 2023, 06:09   #2079  |  Link
hirahi
Registered User
 
Join Date: Apr 2022
Posts: 20
I will upload a sample file cut to 10MB.

https://drive.google.com/drive/folde...2Y?usp=sharing
hirahi is offline   Reply With Quote
Old 22nd October 2023, 09:28   #2080  |  Link
huhn
Registered User
 
Join Date: Oct 2012
Posts: 7,773
works fine here what video renderer and decoder settings are you using?
huhn is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 17:18.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2023, vBulletin Solutions Inc.