nnedi3cl

[monohouse]

ok, on default setting it gives no errors, but I think the output is wrong:
http://manoa.flnet.org/logs/original.png
http://manoa.flnet.org/logs/post.png
or mybe because default setting quality is low ?
image size error happens when nsize=3 + nns>1 or when nsize=2 + nns>2 or when nsize=6 + nns>2

ok on higher setting (nsize=2, nns=2, qual=2, pscrn=1) the big artifact are removed, but some artifact still present and in addition there is many blur
http://manoa.flnet.org/logs/high.png

[HolyWu]

Originally Posted by monohouse

ok, on default setting it gives no errors, but I think the output is wrong:
http://manoa.flnet.org/logs/original.png
http://manoa.flnet.org/logs/post.png
or mybe because default setting quality is low ?
image size error happens when nsize=3 + nns>1 or when nsize=2 + nns>2 or when nsize=6 + nns>2

ok on higher setting (nsize=2, nns=2, qual=2, pscrn=1) the big artifact are removed, but some artifact still present and in addition there is many blur
http://manoa.flnet.org/logs/high.png

Sigh. I tested with your original.png using both default and higher settings, still couldn't produce any artifacts as yours. Can you try setting the core's threads to 1 and see if it still exists? Also post a screenshot of NNEDI3CL(info=True).

[monohouse]

core's threads to 1 ?
http://manoa.flnet.org/logs/info.png
waith I think I have problem with the hardware, ati tool artifact scaner show errors :x sorry, I will fix it first and then try again
that strange....he gived error after 1 minutes but now I run him for more than 5 minutes and there is no errors :x
I running now VMT to see if there is problem, he passed 15 tests and there is 0 errors :x
to be sure I slowed him down to less than original speed and run the encoder again, there were still artifacts :x
I am sure it is not the card that the problem

[HolyWu]

Originally Posted by monohouse

core's threads to 1 ?
http://manoa.flnet.org/logs/info.png
waith I think I have problem with the hardware, ati tool artifact scaner show errors :x sorry, I will fix it first and then try again
that strange....he gived error after 1 minutes but now I run him for more than 5 minutes and there is no errors :x
I running now VMT to see if there is problem, he passed 15 tests and there is 0 errors :x
to be sure I slowed him down to less than original speed and run the encoder again, there were still artifacts :x
I am sure it is not the card that the problem

core.num_threads = 1 sets the core's thread to 1.

Your card's 1D Image Max Buffer Size is 65536, though adheres to the OpenCL spec's minimum value, but is too small for some combination of nsize+nns. That's the reason why you got Invalid Image Size error. BTW that value of my old GTX 660 is 134217728 (2^27).

The cause of the artifacts you got is still uncertain. Try http://www.mediafire.com/file/dns5dt...CL-r7_test4.7z one more time. If the issue still exists then I can't help you. Just use znedi3 instead since it has good AVX/AVX2 optimizations.

[monohouse]

yes the output is artifacting with and without threads = 1.
ok thank

[HolyWu]

Update r7.

• Improve OpenCL code's compatibility.
• Add proper error message when buffer size exceeds device's limit.

[monohouse]

I have a fermi 2 card, it nvidea, you recommend nvidea card over AMD ? I thought that nvidea openCL is suckx

[HolyWu]

Originally Posted by monohouse

you recommend nvidea card over AMD ?

I never said that. How did you draw this conclusion? Also Fermi architecture is quite outdated and some of the models only support OpenCL 1.1.

[monohouse]

I was thinking that because you mentioned you have a nvidea card, so I blieved that you develop the plugin mostly on that card so I was thinking that the plugin mybe more compatible for nvidea card :x
it sutch a shame fermi old :x he is so fast card EVGA classified and only 1.1 :x. I should probable buy new AMD card then, it will have all the requirements.
about znedi, he is not bad but very very slow because my processor don't have AVX, it AMD phenom 2 :x
but I found eedi3 he is pretty good both clean output and fast (1.4 fps on this crap AMD video card), he use 50% of the card so I can run 2 at the same time to use maximum card speed
your was still faster (2 fps from 75% card used)
it no problem because 1.5 fps still gives me 30 times more speed compared to nnedi3 on CPU using AVS+, even if used with AVX
who could blieve it sutch a littel video card can do so mutch more fast than a haswell CPU

you know what I think ? if nvidea whant to do a good openCL, they can, they are more strong than AMD, they have bigger software department and more money than AMD, larger research. but they don't do it because they don't whant openCL - they whant the CUDA, they whant everyone to go to CUDA so that everyone depend on CUDA and in the end depend on nvidea because CUDA only work on nvidea.

[cwk]

What version of boost is required for make? Ubuntu 16.04 provides 1.58:

$ make
CXX NNEDI3CL/NNEDI3CL.lo
NNEDI3CL/NNEDI3CL.cpp:43:34: fatal error: boost/compute/core.hpp: No such file or directory
compilation terminated.
Makefile:476: recipe for target 'NNEDI3CL/NNEDI3CL.lo' failed
make: *** [NNEDI3CL/NNEDI3CL.lo] Error 1

$ apt list *boost*
Listing... Done
...
libboost1.58-all-dev/xenial-updates 1.58.0+dfsg-5ubuntu3.1 amd64
libboost1.58-dbg/xenial-updates 1.58.0+dfsg-5ubuntu3.1 amd64
libboost1.58-dev/xenial-updates 1.58.0+dfsg-5ubuntu3.1 amd64
libboost1.58-doc/xenial-updates,xenial-updates 1.58.0+dfsg-5ubuntu3.1 all
libboost1.58-tools-dev/xenial-updates 1.58.0+dfsg-5ubuntu3.1 amd64

[HolyWu]

Originally Posted by cwk

What version of boost is required for make? Ubuntu 16.04 provides 1.58:

At least 1.61, since the Compute library was added at that version.

[Selur]

On Windows 10 and a Geforce GTX 1070 Ti with the latest 419.81 drivers I get:

NNEDI3CL: device index out of range

GPU Caps Viewer indicates that OpenCL 1.2 is supported,..
anyone else having issues with these drivers or is this probably something totally different? (not totally sure it's the drivers and not something else,.. )

Cu Selur

[HolyWu]

Originally Posted by Selur

On Windows 10 and a Geforce GTX 1070 Ti with the latest 419.81 drivers I get:

NNEDI3CL: device index out of range

GPU Caps Viewer indicates that OpenCL 1.2 is supported,..
anyone else having issues with these drivers or is this probably something totally different? (not totally sure it's the drivers and not something else,.. )

Cu Selur

Did you manually specify device argument? What's the output of list_device=True?

[Selur]

Did you manually specify device argument?

No.

What's the output of list_device=True?

not sure I know how to to this properly, using:

# Imports
import os
import sys
import ctypes
# Loading Support Files
Dllref = ctypes.windll.LoadLibrary("I:/Hybrid/64bit/vsfilters/Support/OpenCL.dll")
import vapoursynth as vs
core = vs.get_core()
# Import scripts folder
scriptPath = 'I:/Hybrid/64bit/vsscripts'
sys.path.append(os.path.abspath(scriptPath))
# Loading Plugins
core.std.LoadPlugin(path="I:/Hybrid/64bit/vsfilters/ResizeFilter/nnedi3/NNEDI3CL.dll")
core.std.LoadPlugin(path="I:/Hybrid/64bit/vsfilters/SourceFilter/FFMS2/ffms2k.dll")
# Import scripts
import edi_rpow2
# Loading F:\TestClips&Co\files\test.avi using FFMS2K
clip = core.ffms2.Source(source="F:/TESTCL~1/files/test.avi",cachefile="E:/Temp/avi_078c37f69bb356e7b5fa040c71584c40_853323747.ffindex",format=vs.YUV420P8,alpha=False)
# using NNEDI3CL
clip = core.nnedi3cl.NNEDI3CL(clip, field=1, list_device=True, info=True)
# Output
clip.set_output()

I see no info whatsoever anywhere in the output.

[HolyWu]

Originally Posted by Selur

No.

not sure I know how to to this properly, using:

clip = core.nnedi3cl.NNEDI3CL(clip, field=1, list_device=True, info=True)

I see no info whatsoever anywhere in the output.

You gotta preview the script since the content is drawn on the frame. By the way list_device and info are mutually exclusive. Only activate either or another.

[Selur]

using:

# Imports
import os
import sys
import ctypes
# Loading Support Files
Dllref = ctypes.windll.LoadLibrary("I:/Hybrid/64bit/vsfilters/Support/OpenCL.dll")
import vapoursynth as vs
core = vs.get_core()
# Import scripts folder
scriptPath = 'I:/Hybrid/64bit/vsscripts'
sys.path.append(os.path.abspath(scriptPath))
# Loading Plugins
core.std.LoadPlugin(path="I:/Hybrid/64bit/vsfilters/ResizeFilter/nnedi3/NNEDI3CL.dll")
core.std.LoadPlugin(path="I:/Hybrid/64bit/vsfilters/SourceFilter/FFMS2/ffms2k.dll")
# Import scripts
import edi_rpow2
# Loading F:\TestClips&Co\files\test.avi using FFMS2K
clip = core.ffms2.Source(source="F:/TESTCL~1/files/test.avi",cachefile="E:/Temp/avi_078c37f69bb356e7b5fa040c71584c40_853323747.ffindex",format=vs.YUV420P8,alpha=False)
# using NNEDI3CL
clip = core.nnedi3cl.NNEDI3CL(clip, field=1, info=True)
# Output
clip.set_output()

I get, still get:

NNEDI3CL: No OpenCL device found

Sorry, I think that should have been the error message to begin with. :/

[Selur]

Argh,.. got it. It's a problem with the OpenCL.dll I loaded.
removing the

Dllref = ctypes.windll.LoadLibrary("I:/Hybrid/64bit/vsfilters/Support/OpenCL.dll")

line fixed the problem.
Thanks for bearing with me.

[Tima]

I'm using QTGMC with opencl=True and sometimes (like 1 out of 20 times) get this crash at the start:

>	ucrtbase.dll!abort()	Unknown
 	ucrtbase.dll!terminate()	Unknown
 	vcruntime140.dll!FindHandler<__FrameHandler3>(EHExceptionRecord * pExcept, unsigned __int64 * pRN, _CONTEXT * pContext, _xDISPATCHER_CONTEXT * pDC, const _s_FuncInfo * pFuncInfo, unsigned char recursive, int CatchDepth, unsigned __int64 * pMarkerRN) Line 538	C++
 	vcruntime140.dll!__InternalCxxFrameHandler<__FrameHandler3>(EHExceptionRecord * pExcept, unsigned __int64 * pRN, _CONTEXT * pContext, _xDISPATCHER_CONTEXT * pDC, const _s_FuncInfo * pFuncInfo, int CatchDepth, unsigned __int64 * pMarkerRN, unsigned char recursive) Line 387	C++
 	vcruntime140.dll!__CxxFrameHandler3(EHExceptionRecord * pExcept, unsigned __int64 RN, _CONTEXT * pContext, _xDISPATCHER_CONTEXT * pDC) Line 264	C++
 	ntdll.dll!RtlpExecuteHandlerForException()	Unknown
 	ntdll.dll!RtlDispatchException()	Unknown
 	ntdll.dll!RtlRaiseException()	Unknown
 	[External Code]	
 	msvcp140.dll!std::_Xout_of_range(const char * _Message) Line 24	C++
 	NNEDI3CL.dll!00007ffa7e122c26()	Unknown
 	NNEDI3CL.dll!00007ffa7e1181e3()	Unknown
 	vapoursynth.dll!VSNode::getFrameInternal(int n, int activationReason, VSFrameContext & frameCtx) Line 854	C++
 	vapoursynth.dll!VSThreadPool::runTasks(VSThreadPool * owner, std::atomic<bool> & stop) Line 214	C++
 	[External Code]

Windows 10 x64, GeForce 1080Ti, latest (436.30) driver.

[HolyWu]

Originally Posted by Tima

I'm using QTGMC with opencl=True and sometimes (like 1 out of 20 times) get this crash at the start:

Please test the two DLLs in https://www.mediafire.com/file/s3i2r...L_test.7z/file and see which one (or none) works.

[Tima]

Originally Posted by HolyWu

Please test the two DLLs in https://www.mediafire.com/file/s3i2r...L_test.7z/file and see which one (or none) works.

Checked both with BlankClip(keep=false) sample.

test1 crashes differently and much less frequently:

>	OpenCL.dll!00007ffa82ba17a9()	Unknown
 	NNEDI3CL.dll!00007ffa82b3d012()	Unknown
 	NNEDI3CL.dll!00007ffa82b3763c()	Unknown
 	NNEDI3CL.dll!00007ffa82b374d2()	Unknown
 	[Inline Frame] vapoursynth.dll!VSCore::destroyFilterInstance(VSNode *) Line 1223	C++
 	[Inline Frame] vapoursynth.dll!VSNode::{dtor}() Line 820	C++
 	vapoursynth.dll!VSNode::`scalar deleting destructor'(unsigned int)	C++
 	[Inline Frame] vapoursynth.dll!std::_Ref_count_base::_Decref() Line 770	C++
 	[Inline Frame] vapoursynth.dll!std::_Ptr_base<VSNode>::_Decref() Line 988	C++
 	[Inline Frame] vapoursynth.dll!std::shared_ptr<VSNode>::{dtor}() Line 1233	C++
 	vapoursynth.dll!freeNode(VSNodeRef * clip) Line 148	C++
 	[External Code]

test2 did never crash.