Dogway's Filters Packs

[Boulder]

Originally Posted by madey83

and one more question. Is there an option to specify stronger SMDgrain value between stecific frames, like 10000-20000 and for other would be weaker?

You can work with segments and join them later. For example:

a = Trim(0,9999).SMDegrain(...)
b = Trim(10000,19999).SMDegrain(...)
a+b

It will be much more memory hungry though.

Originally Posted by LeXXuz

To be honest, I don't get your problem! Since the last version was not broken or anything, you do NOT HAVE to update anything if your current scripts are working for you.

I am just puzzled why a filter option was completely replaced, instead of just adding another one. I'm sure I won't be the only user, impacted by the change.

And the changes and optimizations are a benefit for the script which IS a work in progress.

I realise it's a WIP, but same issue as above comment. There's no doubt the new addition is good, but it should be extra !!

Why don't you just set prefilters yourself, instead of relying on the ones included in SMDegrain? That's what I do, so I don't have to worry about switches or changes in prefilters anymore.

No too sure how this would be done (not as experienced as you, obviously) a sample maybe.

But if I want to use SMDegrain, don't I have to set it up as Dogway has written it ??

[LeXXuz]

Originally Posted by FTLOY

I realise it's a WIP, but same issue as above comment. There's no doubt the new addition is good, but it should be extra !!

My guess is it's probably not an addition but more of a replacement which makes the old prefilter obsolete for most cases.

Originally Posted by FTLOY

No too sure how this would be done (not as experienced as you, obviously) a sample maybe.
But if I want to use SMDegrain, don't I have to set it up as Dogway has written it ??

From my understanding the internal prefilters are for keeping things simple (which is the entire point of SMDegrain script) and to help inexperienced users with prebuild setups for most scenarios.

As you know prefiltering is very important for satisfying results. And the built in prefilters do a very good job for most cases.
But of course you can always optimize that to your needs by simply using your own prefilters. Or using the same prefilters already integrated but with different parameters. I'd consider the internal prefilters more of a starting point for personal tweaks, but certainly not the optimum. They can't be, because every source is different. So you would end up with dozens of prefilters which would not make much sense imho.

It's alright to call the same prefilter externally so you don't have to worry about numbers anymore.

Originally Posted by LeXXuz

My guess is it's probably not an addition but more of a replacement which makes the old prefilter obsolete for most cases.

Exactly !!!

From my understanding the internal prefilters are for keeping things simple (which is the entire point of SMDegrain script) and to help inexperienced users with prebuild setups for most scenarios.

As you know prefiltering is very important for satisfying results. And the built in prefilters do a very good job for most cases.
But of course you can always optimize that to your needs by simply using your own prefilters. Or using the same prefilters already integrated but with different parameters. I'd consider the internal prefilters more of a starting point for personal tweaks, but certainly not the optimum. They can't be, because every source is different. So you would end up with dozens of prefilters which would not make much sense imho.

It's alright to call the same prefilter externally so you don't have to worry about numbers anymore.

I think I understand what you're saying, I did change my scripts to "names" from "numbers" a couple of SMDegrain builds ago.

And I do mod the scripts a little to suit the footage, and I do end up with a LOT of different scripts, but I haven't got a problem with that.

Originally Posted by Boulder

You can work with segments and join them later. For example:

a = Trim(0,9999).SMDegrain(...)
b = Trim(10000,19999).SMDegrain(...)
a+b

It will be much more memory hungry though.

[Dogway]

@FTLOY: FYI I was never satisfied with FluxSmoothST. It was a recommendation by Didee from the old ages but produced visible ghosting and also not much denoising. IQMST stands better for the name "nifty spatio-temporal median/gauss blur", I will explain my rationale.

                                      -y
                              -2,-2    2,-2 
         *                       *     *            
   -2 -1 * 1 2                                        *            
-z   * * * * *     +    -x                     +    * * *     +   IQM   =    IQMST
         *                    -2,2     2,2            *
         *                       *     *     
  Temporal Stability          HD Denoising        Sharpness       Detail + Motion
                              + LF Denoise                        Protection

@madey83: I recommend you to use StainlessS ClipClop() as it will have less memory overhead.

Originally Posted by Dogway

@FTLOY: FYI I was never satisfied with FluxSmoothST. It was a recommendation by Didee from the old ages but produced visible ghosting and also not much denoising. IQMST stands better for the name "nifty spatio-temporal median/gauss blur", I will explain my rationale.

I just think it would be just as easy to leave "stuff" that has been part of SMDegrain for a long time, where it is in the "pecking order", and ADD (not replace) the new one's you want to.

And it's a lot easier now that pre-filters names are used, instead of numbers.

There might have been many users that used Flux, and now they can't

And as for your "rationale" info, that means absolutely nothing to me, it's just some random letters & numbers, etc, and some little coloured rectangles

I will definitely get the new "IQMST" to work, and see how it goes.

Don't get me wrong, I, and many others really appreciate what you're doing, but removing stuff is possibly a little counter productive.

Onward & upward !!

EDIT:-

Did some tests:-

This works for me, but it is very slow to start, and encoding is slower than below call :-

SMDegrain(tr=2,thSAD=200,thSADC=100,contrasharp=true,prefilter="IQMST",str=1.2,refinemotion=true)

This works a lot better:-

pre=ex_Median(mode="IQMST")
SMDegrain(tr=2,thSAD=200,thSADC=100,contrasharp=true,prefilter=pre,str=1.2,refinemotion=true)

On the 5 minute test 4K clip, the top call took 4 minutes longer, and I think the lower call looks a little better.

3 variants :-

pre=ex_Median(mode="IQM")
pre=ex_Median(mode="IQMV")
pre=ex_Median(mode="IQMST")

string "prefilter"="" (""/ "SBR"/ "MinBlur"/ "MinBlur2"/ "MinBlur3"/ "IQMST"/ "DFTTest"/ "KNLMeans"/ "DGDenoise"/ "BM3D")

Thoughts ??

[Dogway]

@FTLOY: It's the structuring element and why I chose that, maybe some users might find it useful/interesting, it's open source after all so you can fork it where you liked. I mean time is relative and FluxSmoothST was never in the pecking order as you could see with my numerous edits. What I don't want to do is to give the false sensation that prefilter="FluxSmoothST" is good, because it's not, and that's why I changed it. I only want things that make sense, are simple and work as you would expect, at any rate is not like I butchered the filter, it's still in ExTools and you can load as prefilter, but if you have followed my development you would have realized already that my scripts are finished after a last 2 weeks crunch and their versioning, and now I'm done unless something exceptional arises or time permits. I'm on other tasks now but still give support here and in Github if anyone asks like with LeXXuz.

@madey83: This is how you use DGHDRtoSDR. I also posted an example for ClipClop, you can add as many clips as you want, I'm using 15 on a personal project and it doesn't slow down. And also the new IQMST just after DGHDRtoSDR as prefilter.

ConvertBits(16)
deep_resize(1920,edge="Zopti1080")

# Remove big chroma "blocks"
CCD(15)

# Remove blocking and smooth out jagged edges (only applies where motion match fails)
mb=Deblock_QED(quant1=30, quant2=40, aOff1=1, aOff2=1, bOff1=2, bOff2=2, uv=1)
mb=mb.ex_smooth(1, mode="SG", limit=true, sharp=true)

pre =DGHDRtoSDR(mode="pq",white=112)
pre2=pre.ex_Median(mode="IQMST", UV=3, thres=255)

r0=SMDegrain(prefilter=pre2, mfilter=mb, tr=3, thSAD=300, thSADC=150, thSCD1=400, thSCD2=120, LFR=false, plane=4, limits=false, DCTFlicker=false, refinemotion=true, search=5, subpixel=3)
r1=SMDegrain(prefilter=pre2, mfilter=mb, tr=4, thSAD=400, thSADC=200, thSCD1=400, thSCD2=120, LFR=false, plane=4, limits=false, DCTFlicker=false, refinemotion=true, search=5, subpixel=3)

ClipClop(r0,r1,SCmd="r0(0,2937);r1(2938,3854);...")

@LeXXuz: I'll make some room and let you know.


EDIT: By the way I found this infamous thread and checked the result and actually felt challenged ^^ The guy probably used Video Artifact which is an old payware solution based on AVS, it has good ideas like the motion compensated sharpening (more like deblur though), and the 420 to 444 chroma reconstruction. I was playing with the sharpening (just spatially) and reached to some point, still need to add some temporal as the example showed increased details not present spatially. One thing I could achieve was better high frequency sharpening leading to a much more HD feel. Still more experimentation is needed.

Orig

Mine

VA

@Dogway, could you please comment on my Edit, in my previous post, above ??

Difference in the speed.

[LeXXuz]

Originally Posted by FTLOY

EDIT:-

Did some tests:-

This works for me, but it is very slow to start, and encoding is slower than below call :-

SMDegrain(tr=2,thSAD=200,thSADC=100,contrasharp=true,prefilter="IQMST",str=1.2,refinemotion=true)

This works a lot better:-

pre=ex_Median(mode="IQMST")
SMDegrain(tr=2,thSAD=200,thSADC=100,contrasharp=true,prefilter=pre,str=1.2,refinemotion=true)

On the 5 minute test 4K clip, the top call took 4 minutes longer, and I think the lower call looks a little better.

3 variants :-

pre=ex_Median(mode="IQM")
pre=ex_Median(mode="IQMV")
pre=ex_Median(mode="IQMST")

string "prefilter"="" (""/ "SBR"/ "MinBlur"/ "MinBlur2"/ "MinBlur3"/ "IQMST"/ "DFTTest"/ "KNLMeans"/ "DGDenoise"/ "BM3D")
Thoughts ??

The speed difference and slightly visual difference is probably because SMDegrain uses ex_sbr() after ex_Median() when selecting prefilter=4 or mode "IQMST"

(prefilter== 4) ? pref.ex_Median(mode="IQMST", UV=Chr, thres=255).ex_sbr(3,UV=Chr)

Originally Posted by LeXXuz

The speed difference and slightly visual difference is probably because SMDegrain uses ex_sbr() after ex_Median() when selecting prefilter=4 or mode "IQMST"

Thnx LeXXuz,

I might change the scripts then..

Originally Posted by Dogway

@FTLOY: It's the structuring element and why I chose that, maybe some users might find it useful/interesting, it's open source after all so you can fork it where you liked. I mean time is relative and FluxSmoothST was never in the pecking order as you could see with my numerous edits. What I don't want to do is to give the false sensation that prefilter="FluxSmoothST" is good, because it's not, and that's why I changed it. I only want things that make sense, are simple and work as you would expect, at any rate is not like I butchered the filter, it's still in ExTools and you can load as prefilter, but if you have followed my development you would have realized already that my scripts are finished after a last 2 weeks crunch and their versioning, and now I'm done unless something exceptional arises or time permits. I'm on other tasks now but still give support here and in Github if anyone asks like with LeXXuz.

@madey83: This is how you use DGHDRtoSDR. I also posted an example for ClipClop, you can add as many clips as you want, I'm using 15 on a personal project and it doesn't slow down. And also the new IQMST just after DGHDRtoSDR as prefilter.

ConvertBits(16)
deep_resize(1920,edge="Zopti1080")

# Remove big chroma "blocks"
CCD(15)

# Remove blocking and smooth out jagged edges (only applies where motion match fails)
mb=Deblock_QED(quant1=30, quant2=40, aOff1=1, aOff2=1, bOff1=2, bOff2=2, uv=1)
mb=mb.ex_smooth(1, mode="SG", limit=true, sharp=true)

pre =DGHDRtoSDR(mode="pq",white=112)
pre2=pre.ex_Median(mode="IQMST", UV=3, thres=255)

r0=SMDegrain(prefilter=pre2, mfilter=mb, tr=3, thSAD=300, thSADC=150, thSCD1=400, thSCD2=120, LFR=false, plane=4, limits=false, DCTFlicker=false, refinemotion=true, search=5, subpixel=3)
r1=SMDegrain(prefilter=pre2, mfilter=mb, tr=4, thSAD=400, thSADC=200, thSCD1=400, thSCD2=120, LFR=false, plane=4, limits=false, DCTFlicker=false, refinemotion=true, search=5, subpixel=3)

ClipClop(r0,r1,SCmd="r0(0,2937);r1(2938,3854);...")

@LeXXuz: I'll make some room and let you know.


EDIT: By the way I found this infamous thread and checked the result and actually felt challenged ^^ The guy probably used Video Artifact which is an old payware solution based on AVS, it has good ideas like the motion compensated sharpening (more like deblur though), and the 420 to 444 chroma reconstruction. I was playing with the sharpening (just spatially) and reached to some point, still need to add some temporal as the example showed increased details not present spatially. One thing I could achieve was better high frequency sharpening leading to a much more HD feel. Still more experimentation is needed.

Orig

Mine

VA

@Dogway,

thank you so mutch for this... going to test this out.

@Dogway,

i have tested your proposition with below

# Remove blocking and smooth out jagged edges (only applies where motion match fails)
mb=Deblock_QED(quant1=30, quant2=40, aOff1=1, aOff2=1, bOff1=2, bOff2=2, uv=1)
mb=mb.ex_smooth(1, mode="SG", limit=true, sharp=true)

pre =DGHDRtoSDR(mode="pq",white=112)
pre2=pre.ex_Median(mode="IQMST", UV=3, thres=255)

r0=SMDegrain(prefilter=pre2, mfilter=mb, tr=3, thSAD=300, thSADC=150, thSCD1=400, thSCD2=120, LFR=false, plane=4, limits=false, DCTFlicker=false, refinemotion=true, search=5, subpixel=3)
r1=SMDegrain(prefilter=pre2, mfilter=mb, tr=4, thSAD=400, thSADC=200, thSCD1=400, thSCD2=120, LFR=false, plane=4, limits=false, DCTFlicker=false, refinemotion=true, search=5, subpixel=3)

ClipClop(r0,r1,SCmd="r0(0,2937);r1(2938,3854);...")

but unfortunatly convert HDR to SDR mess sothing up with the DV colors and picture is broken.

i have tried to replace
pre =DGHDRtoSDR(mode="pq",white=112)
pre2=pre.ex_Median(mode="IQMST", UV=3, thres=255)

by

pre=ex_BM3D(sigma=10,preset="normal",radius=1,UV=1,gpuid=0,tv_range=true)
pre2=ex_BM3D(sigma=10,preset="noisy",radius=3,UV=1,gpuid=0,tv_range=true)

r0=SMDegrain(prefilter=pre2, mfilter=mb, tr=3, thSAD=300, thSADC=150, thSCD1=400, thSCD2=120, LFR=false, plane=4, limits=false, DCTFlicker=false, refinemotion=true, search=5, subpixel=3)
r1=SMDegrain(prefilter=pre2, mfilter=mb, tr=6, thSAD=600, thSADC=200, thSCD1=400, thSCD2=120, LFR=false, plane=4, limits=false, DCTFlicker=false, refinemotion=true, search=5, subpixel=3)

ClipClop(r0,r1,SCmd="r0(0,2937);r1(2938,3854);...")

but i still have lots of gain. i can't force SMDegrain to remove more grain.

[anton_foy]

Regarding the topic of motion protecting temporal filtering, could this reasoning be of use/inspiration(?):

function mprotect(clip c, int "tr"){
q=temporalsoften(c,tr,255,255,255,2).repair(c,mode=16).neo_vd() #neo vd is fast
q.ex_blur3D(0,0,tr+1,"weighted",UV=3).ex_AddDiff(ex_MakeDiff(c,q,UV=3),UV=4) #parameters borrowed from Dideé, not sure uv=4 is working with ex_adddiff

return last
}​

Not tested yet. Maybe IQMT would replace temporalsoften+repair in this case?

[DTL]

"i can't force SMDegrain to remove more grain."

To remove more grain it is typically require higher tr and thSAD. tr may be 20 and more. Upper limit is 128. With thSAD user adjust beginning of denoising and amount of blurred details.

Also:
thSAD=600, thSADC=200, thSCD1=400,

thSCD1 must be > thSAD or it will limit degraining to nothing. If thSCD1 is comparable or below noise-SAD it cause to treat all frames as scenechange and no denoising applied at all with any tr.
It is better to set condition check and error-throwing in SMDegrain script if user set thSCD1 < thSAD.

To make adjustments easier you can set user equation like

my_thSAD = N
my_thSCD1 = my_thSAD + 100

thSAD=my_thSAD, thSADC=my_thSAD - 100, thSCD1=my_thSCD1,

[zorr]

Feature request: an optional argument to define prop name in similarity metric functions (GMSD, MDSI, SSIM & others).

Sometimes I need to measure similarity more than once in a Zopti script. For example you can optimize for two different similarities at the same time. Currently you need to rename the similarity metric props before you call the metric the second time. It would be easier (and faster) to be able to define the prop's name in the first place.

For example

GMSD(clip, ref, propName="_PlaneGMSD_first")
GMSD(clip2, ref2, propName="_PlaneGMSD_second")

Originally Posted by DTL

"i can't force SMDegrain to remove more grain."

To remove more grain it is typically require higher tr and thSAD. tr may be 20 and more. Upper limit is 128. With thSAD user adjust beginning of denoising and amount of blurred details.

Also:
thSAD=600, thSADC=200, thSCD1=400,

thSCD1 must be > thSAD or it will limit degraining to nothing. If thSCD1 is comparable or below noise-SAD it cause to treat all frames as scenechange and no denoising applied at all with any tr.
It is better to set condition check and error-throwing in SMDegrain script if user set thSCD1 < thSAD.

To make adjustments easier you can set user equation like

my_thSAD = N
my_thSCD1 = my_thSAD + 100

thSAD=my_thSAD, thSADC=my_thSAD - 100, thSCD1=my_thSCD1,

Thank you DTL, script has been adjusted to your guidence.

[Dogway]

@madey83: Then I need to have a look at the clip, a small sample is enough.

@FTLOY: Yes, internally IQMST also adds ex_sbr(3) so it might be slower, but in contrast it does so over the halved source clip, as by default UHD is using downscaled vectors. You can either set UHDhalf=false, or use another less aggressive prefilter preset.
The different IQMs fill different purposes, IQM is the canonical algo over a 3x3 kernel, IQM5 is the same over a 5x5 kernel, both spatial. IQMV is IQM + IQM5 thresholded by variance, so it's a very good spatial prefilter specially for anime where temporal (pre)filters causes more harm than good, it's similar to what ex_MinBlur(3) would look like but much faster. Then the new IQMST is a spatio-temporal custom kernel as explained above for very grainy live action HD sources, you can also use BM3D for this, but that's more kind of brute force and probably slower. If you want a lighter spatio-temporal prefilter maybe use prefilter=6 or set up a custom one using STTWM.

@anton_foy: I don't understand the script much, I rewrite it here:

function mprotect(clip a, int "tr") {

    tr = Default(tr,2)
    a
    TemporalSoften(tr,255,255,255,2)
    repair(a,mode=16)
    # or ex_median("IQMT")
    neo_vd()
    q=last
    ex_blur3D(0,0,tr+1,mode="weighted",UV=3)
    ex_MakeAddDiff(a,q,last,UV=6)           }

So you diff 'a' vs 'q' which is a lot of grain and add it back to ex_blur3D() ? What you get is exactly that, a TemporalGauss with some grain recovered. With 'IQMT' the difference is greater so it's mostly a noop. I still find 'IQMST' the better option, take a bunch of samples, spatial+temporal, remove 50% of the furthermost samples (outliers), make an average of the remaining. You can expand on this idea by using different spatial and temporal kernels depending on your needs like "not much blurring", or "more temporal weighting", etc. For example, an interesting one would be cross(4) + square(9) + cross(4) or dot(1) + cross(4) + square(25) + cross(4) + dot(1)

@zorr: Done, updating in a few moments


BTW I updated QTGMC+ with new EdiModes that preserve details better, so the presets have been changed with new EdiModes but now should look better overall, now speedwise it can't be compared to original QTGMC as it's not an apples to apples. I also fixed an issue on chroma, and a regression in the last version for sourcematch.

[Boulder]

Originally Posted by DTL

thSCD1 must be > thSAD or it will limit degraining to nothing. If thSCD1 is comparable or below noise-SAD it cause to treat all frames as scenechange and no denoising applied at all with any tr.
It is better to set condition check and error-throwing in SMDegrain script if user set thSCD1 < thSAD.

As far as I've understood, thSCD1 is the SAD threshold to mark a block as a valid scene change. thSCD2 is then the limit to determine if the frame contains enough of such blocks to mark it as a scene change. I suggest using MShow to see how it works and if the thresholds require tuning.

[QUOTE=Dogway;1984444]@madey83: Then I need to have a look at the clip, a small sample is enough.

sample: https://mega.nz/file/4RhxEZSL#CfNkhL...keKAVfwi58nZTg