[Neo] FFT3D / DFTTest

[pinterf]

Usually I'm using this comparison at the end of my scripts. It may show if difference has geometric pattern.

...
StackVertical(old, new, Diff(old, new))
return last

Function Diff(clip src1, clip src2)
{
  return Subtract(src1.ConvertBits(8),src2.ConvertBits(8)).Levels(120, 1, 255-120, 0, 255, coring=false)
}

[MeteorRain]

Thanks for reporting, there's an issue with degrid on. The issue was introduced in r3. I should change for all 3 SIMD files but ended up only changing 1 place, leaving 2 files with incorrect parameters.

I'm uploading r6.

[kedautinh12]

Originally Posted by real.finder

is [Neo] FFT3D / DFTTest stable yet? cuz I want to make scripts use them instead of non-neo one

also as I said in #22 more ports from VS will be nice since avs+ still need those updates for HBD, so I will make another wave of scripts updates

I think it's stable now, can you add your scripts??

[real.finder]

Originally Posted by kedautinh12

I think it's stable now, can you add your scripts??

I am already plan for this next update, but I was waiting for more plugins to did MCTD update first since it's not work with HBD at all (many plugins need updates)

[almosely]

I just found, that there's this NEO-version of FFT3DFilter - very nice! :-) Although a test is waiting ... Question: Is FFTW still needed for this NEO-version? I have FFTW 3.3.8 (AVX) (Wolfberry's compile from 29-01-2019) already installed and in use since then. I just realized that AvsPmod GPo has gotten very slow, since I have updated to the newest AviSynth+ Version 3.5.1 and also updated my Visual C++ Redists 2015-2019 to the latest. Now I am checking everything, I use in combination with AviSynth+ and update all of it - maybe, the slowdown is gone after that.

Ahm, I can vaguely remember, that there was a bug in pinterf's FFT3DFilter (maybe it has been there since the beginning, as there was this luma-bug too): I compared the outcome of RgTools's RemoveGrain vs. FFT3DFilter (with chroma filtering), both on and off, with Histogram("color"/"color2") and there were differences when FFT3DFilter was in the filter chain, although turned off. With RemoveGrain, there was no difference to the unfiltered source. But I noticed that a year ago and thought, that I just use RemoveGrain for chroma filtering and not to bother pinterf a second time ;-) Maybe someone else noticed that too and maybe that misbehaviour is resolved in the NEO-version?

[MeteorRain]

almosely:

I'm having difficulties reading your words. Let's split it into parts and you can clarify if I misunderstood.

> Is FFTW still needed for this NEO-version?

Yes. In fact, FFTW is required for all plugins that needs regular FFT transform. FFTW would be the fastest and easiest way to do it.

Of course if it's a GPU plugin than it'll need something else.

> when FFT3DFilter was in the filter chain, although turned off

What do you mean turned off? Does that mean you apply fft3dfilter on a clip but did not use the result? In which part did you notice differences?

[almosely]

Ok, then I leave FFTW where it is ;-) Thank you.

I made a new test regarding chroma filtering, although I realized that I had a thinking error (RemoveGrain cannot be turned off, of course). But I can put FFT3DFilter or neo_fft3d into the script and turn the sigma off (setting it to 0.1 = filter is off). When I do that with luma filtering only, then there is absolutely no difference between the original material and the one with either one of the two fft3d filters (in Histogram=luma), as it should be. But when I do that with UV-filtering turned on, then I can see a difference, although there should not be any difference. I made 3 screenshots.

This happens not, when I leave the chroma settings at 2 (y=3,u=2,v=2 neo) or 0 (plane, fft3dfilter). But it happens, when I only filter the chroma (y=2,u=3,v=3 neo / plane=3 fft3dfilter) or all of it (all=3 neo / plane=4 fft3dfilter).

And another question: What is the difference between 1 and 2 (y,u,v)?

And I also installed the newest version of AvsPmod GPo. The first thing, that came up, was an error-message, that Shibatch.dll is installed twice (but it's only within the plugins+ and plugins64+ folders once, each). That one is "btw". But the next one is regarding your neo_fft3d filter. AvsPmod GPo also spit out an error message, that "neo-fft3d" is containing irregular letters. I muted that message for the next times, sadly. But - IIRC - there was a third message, telling me, that the "-" is the villain and it should be a "_" or anything else to be correct. So I renamed your .dll to "neo_fft3d.dll".

My first benchmarks between neo_fft3d and FFT3DFilter resulted in a speed gain of about 9% (only luma filtering) and about 17% with all planes filtered (compression tests of 720p material with other filters turned on, as I usually do). Nice! :-)

And another thing I am wondering about. With opt=0 I got exactly the same results as with opt=2. But with opt=3 the x264 results were a bit different all over the place (bitrate, I-,P-,B-frame sizes and counts etc.). I have an Intel Core i7-3770 (with AVX). Shouldn't the results be all the same?

opt=0

[2020-05-03][02:20:13] y4m [info]: 1280x720p 1:1 @ 30/1 fps (cfr)
[2020-05-03][02:20:13] x264 [info]: using SAR=1/1
[2020-05-03][02:20:13] x264 [info]: using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX
[2020-05-03][02:20:13] x264 [info]: profile High, level 4.0, 4:2:0, 8-bit
[2020-05-03][02:22:13] x264 [info]: frame I:23 Avg QP:15.27 size: 60969
[2020-05-03][02:22:13] x264 [info]: frame P:372 Avg QP:19.54 size: 21633
[2020-05-03][02:22:13] x264 [info]: frame B:1125 Avg QP:23.53 size: 7449
[2020-05-03][02:22:13] x264 [info]: consecutive B-frames: 2.2% 2.5% 11.1% 48.9% 21.1% 14.2%
[2020-05-03][02:22:13] x264 [info]: mb I I16..4: 14.4% 69.4% 16.2%
[2020-05-03][02:22:13] x264 [info]: mb P I16..4: 4.9% 20.2% 2.0% P16..4: 33.5% 12.5% 7.4% 0.2% 0.0% skip:19.2%
[2020-05-03][02:22:13] x264 [info]: mb B I16..4: 0.6% 3.1% 0.2% B16..8: 29.6% 8.9% 2.3% direct: 3.8% skip:51.5% L0:45.4% L1:46.8% BI: 7.9%
[2020-05-03][02:22:13] x264 [info]: 8x8 transform intra:74.7% inter:72.8%
[2020-05-03][02:22:13] x264 [info]: direct mvs spatial:99.6% temporal:0.4%
[2020-05-03][02:22:13] x264 [info]: coded y,uvDC,uvAC intra: 66.7% 75.0% 44.9% inter: 11.0% 12.6% 1.9%
[2020-05-03][02:22:13] x264 [info]: i16 v,h,dc,p: 18% 12% 4% 67%
[2020-05-03][02:22:13] x264 [info]: i8 v,h,dc,ddl,ddr,vr,hd,vl,hu: 21% 15% 7% 7% 8% 11% 9% 11% 11%
[2020-05-03][02:22:13] x264 [info]: i4 v,h,dc,ddl,ddr,vr,hd,vl,hu: 18% 13% 3% 8% 14% 14% 13% 8% 8%
[2020-05-03][02:22:13] x264 [info]: i8c dc,h,v,p: 37% 21% 22% 20%
[2020-05-03][02:22:13] x264 [info]: Weighted P-Frames: Y:7.3% UV:5.1%
[2020-05-03][02:22:13] x264 [info]: ref P L0: 59.7% 6.0% 18.4% 7.7% 7.9% 0.2%
[2020-05-03][02:22:13] x264 [info]: ref B L0: 87.6% 8.4% 2.8% 1.2%
[2020-05-03][02:22:13] x264 [info]: ref B L1: 96.6% 3.4%
[2020-05-03][02:22:13] x264 [info]: kb/s:2815.29
[2020-05-03][02:22:13] encoded 1520 frames, 12.13 fps, 2815.42 kb/s

opt=2

[2020-05-03][02:22:20] y4m [info]: 1280x720p 1:1 @ 30/1 fps (cfr)
[2020-05-03][02:22:20] x264 [info]: using SAR=1/1
[2020-05-03][02:22:20] x264 [info]: using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX
[2020-05-03][02:22:20] x264 [info]: profile High, level 4.0, 4:2:0, 8-bit
[2020-05-03][02:24:21] x264 [info]: frame I:23 Avg QP:15.27 size: 60969
[2020-05-03][02:24:21] x264 [info]: frame P:372 Avg QP:19.54 size: 21633
[2020-05-03][02:24:21] x264 [info]: frame B:1125 Avg QP:23.53 size: 7449
[2020-05-03][02:24:21] x264 [info]: consecutive B-frames: 2.2% 2.5% 11.1% 48.9% 21.1% 14.2%
[2020-05-03][02:24:21] x264 [info]: mb I I16..4: 14.4% 69.4% 16.2%
[2020-05-03][02:24:21] x264 [info]: mb P I16..4: 4.9% 20.2% 2.0% P16..4: 33.5% 12.5% 7.4% 0.2% 0.0% skip:19.2%
[2020-05-03][02:24:21] x264 [info]: mb B I16..4: 0.6% 3.1% 0.2% B16..8: 29.6% 8.9% 2.3% direct: 3.8% skip:51.5% L0:45.4% L1:46.8% BI: 7.9%
[2020-05-03][02:24:21] x264 [info]: 8x8 transform intra:74.7% inter:72.8%
[2020-05-03][02:24:21] x264 [info]: direct mvs spatial:99.6% temporal:0.4%
[2020-05-03][02:24:21] x264 [info]: coded y,uvDC,uvAC intra: 66.7% 75.0% 44.9% inter: 11.0% 12.6% 1.9%
[2020-05-03][02:24:21] x264 [info]: i16 v,h,dc,p: 18% 12% 4% 67%
[2020-05-03][02:24:21] x264 [info]: i8 v,h,dc,ddl,ddr,vr,hd,vl,hu: 21% 15% 7% 7% 8% 11% 9% 11% 11%
[2020-05-03][02:24:21] x264 [info]: i4 v,h,dc,ddl,ddr,vr,hd,vl,hu: 18% 13% 3% 8% 14% 14% 13% 8% 8%
[2020-05-03][02:24:21] x264 [info]: i8c dc,h,v,p: 37% 21% 22% 20%
[2020-05-03][02:24:21] x264 [info]: Weighted P-Frames: Y:7.3% UV:5.1%
[2020-05-03][02:24:21] x264 [info]: ref P L0: 59.7% 6.0% 18.4% 7.7% 7.9% 0.2%
[2020-05-03][02:24:21] x264 [info]: ref B L0: 87.6% 8.4% 2.8% 1.2%
[2020-05-03][02:24:21] x264 [info]: ref B L1: 96.6% 3.4%
[2020-05-03][02:24:21] x264 [info]: kb/s:2815.29
[2020-05-03][02:24:21] encoded 1520 frames, 12.03 fps, 2815.42 kb/s

opt=3

[2020-05-03][02:24:27] y4m [info]: 1280x720p 1:1 @ 30/1 fps (cfr)
[2020-05-03][02:24:27] x264 [info]: using SAR=1/1
[2020-05-03][02:24:27] x264 [info]: using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX
[2020-05-03][02:24:27] x264 [info]: profile High, level 4.0, 4:2:0, 8-bit
[2020-05-03][02:26:28] x264 [info]: frame I:23 Avg QP:15.26 size: 60963
[2020-05-03][02:26:28] x264 [info]: frame P:372 Avg QP:19.56 size: 21631
[2020-05-03][02:26:28] x264 [info]: frame B:1125 Avg QP:23.52 size: 7453
[2020-05-03][02:26:28] x264 [info]: consecutive B-frames: 2.2% 2.5% 11.1% 48.9% 21.1% 14.2%
[2020-05-03][02:26:28] x264 [info]: mb I I16..4: 14.5% 69.3% 16.2%
[2020-05-03][02:26:28] x264 [info]: mb P I16..4: 5.0% 20.2% 2.0% P16..4: 33.6% 12.5% 7.4% 0.2% 0.0% skip:19.2%
[2020-05-03][02:26:28] x264 [info]: mb B I16..4: 0.6% 3.2% 0.2% B16..8: 29.6% 8.8% 2.3% direct: 3.8% skip:51.4% L0:45.5% L1:46.7% BI: 7.9%
[2020-05-03][02:26:28] x264 [info]: 8x8 transform intra:74.7% inter:72.7%
[2020-05-03][02:26:28] x264 [info]: direct mvs spatial:99.6% temporal:0.4%
[2020-05-03][02:26:28] x264 [info]: coded y,uvDC,uvAC intra: 66.7% 75.0% 44.8% inter: 11.0% 12.6% 1.9%
[2020-05-03][02:26:28] x264 [info]: i16 v,h,dc,p: 18% 12% 4% 67%
[2020-05-03][02:26:28] x264 [info]: i8 v,h,dc,ddl,ddr,vr,hd,vl,hu: 21% 15% 7% 7% 8% 11% 9% 11% 11%
[2020-05-03][02:26:28] x264 [info]: i4 v,h,dc,ddl,ddr,vr,hd,vl,hu: 18% 13% 3% 8% 14% 14% 13% 8% 8%
[2020-05-03][02:26:28] x264 [info]: i8c dc,h,v,p: 37% 21% 22% 20%
[2020-05-03][02:26:28] x264 [info]: Weighted P-Frames: Y:7.3% UV:5.1%
[2020-05-03][02:26:28] x264 [info]: ref P L0: 59.6% 6.0% 18.5% 7.7% 8.0% 0.2%
[2020-05-03][02:26:28] x264 [info]: ref B L0: 87.6% 8.4% 2.8% 1.2%
[2020-05-03][02:26:28] x264 [info]: ref B L1: 96.7% 3.3%
[2020-05-03][02:26:28] x264 [info]: kb/s:2815.81
[2020-05-03][02:26:28] encoded 1520 frames, 12.10 fps, 2815.93 kb/s

[MeteorRain]

> turn the sigma off (setting it to 0.1 = filter is off)

Bug confirmed. I'll investigate what happened.

> What is the difference between 1 and 2 (y,u,v)?

2 = copy, 1 = garbage data.

> But with opt=3 the x264 results were a bit different

Make sure you have r6 which should have fixed the issue.

[almosely]

Nice again! :-) It would be fine to use only one filter for luma and croma, I think (even so RemoveGrain is fast as hell).

I still don't get it. What means "garbage data" or "Do not touch, leaving garbage data". But, all I have to really know is: When I only want to filter luma, I use y=3, u=2, v=2 or shall I use y=3, u=1, v=1? I guess 3-2-2 is the way to go?

Hm, I do have r6 installed :-(

[real.finder]

Originally Posted by almosely

Nice again! :-) It would be fine to use only one filter for luma and croma, I think (even so RemoveGrain is fast as hell).

I still don't get it. What means "garbage data" or "Do not touch, leaving garbage data". But, all I have to really know is: When I only want to filter luma, I use y=3, u=2, v=2 or shall I use y=3, u=1, v=1? I guess 3-2-2 is the way to go?

Hm, I do have r6 installed :-(

"garbage data" or don't care (see mode=-1 in RemoveGrain or y,u,v =1 in masktools) is the fastest option useful for scripts maker/editer

[almosely]

A test with RemoveGrain -1,u,v translated the effects to my brain :-) -1 removes the channel completely from the further script progress. So 2 is the way to go for me, when I only want to filter luma (3-2-2).

But it seems since I have updated to the newest AviSynth+ and MSVC++ 15-19, something is not working right anymore. AvsPMod GPu is slow (the old was and the new version is too), even when I switch the values of RemoveGrain, when nothing else is within the script. And sometimes RemoveGrain mode -1 removed the luma channel, and sometimes not - like a bitchy programm. Weird. And I never noticed a red cross in the upper right corner of AvsPMod GPu before the update to the new AviSynth+ and MSVC++ - now I see it almost every time I change a filter value. I know, thats the wrong thread, but I can't help myself to mention that. Sadly I deleted the old avisinth.dlls and devil.dlls from version 3.4.0, which I had installed before.

- edit -

just downloaded the portable version of AviSynth+ 3.4.0 and will test with that.

[MeteorRain]

almosely:

Do not attach images like this. You can use a public image hosting service such as imgur. Upload your picture to imgur and paste the image link here.

If you have r6 and still have issues with opt=3 and opt=2 please give me a minimal sample script that you can reproduce the issue.

garbage data means it can return anything and you should not use the data from that plane. For (y=3, u=2, v=1), y plane is filtered, u plane is copied from source, v plane contains garbage and you should not consider v plane as a valid image.
Whether use 2 or 1 depends on your actual script.

[almosely]

Ok, now I got the meaning of "-1" - that explains the "bitchy" ;-)

I will use imgur.com the next times.

I made another test, with almost the same script (only the BlackmanResize has different values) and another clip. Now I got 3 different results ...

opt=0

[2020-05-03][05:26:36] y4m [info]: 1280x536p 1:1 @ 24000/1001 fps (cfr)
[2020-05-03][05:26:36] x264 [info]: using SAR=1/1
[2020-05-03][05:26:36] x264 [info]: using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX
[2020-05-03][05:26:36] x264 [info]: profile High, level 4.0, 4:2:0, 8-bit
[2020-05-03][05:28:30] x264 [info]: frame I:65 Avg QP:15.61 size:101225
[2020-05-03][05:28:30] x264 [info]: frame P:548 Avg QP:20.40 size: 26703
[2020-05-03][05:28:30] x264 [info]: frame B:1387 Avg QP:23.77 size: 8405
[2020-05-03][05:28:30] x264 [info]: consecutive B-frames: 5.5% 5.6% 14.1% 59.8% 7.2% 7.8%
[2020-05-03][05:28:30] x264 [info]: mb I I16..4: 4.0% 70.9% 25.1%
[2020-05-03][05:28:30] x264 [info]: mb P I16..4: 1.7% 17.6% 3.4% P16..4: 36.0% 16.7% 14.0% 1.0% 0.3% skip: 9.3%
[2020-05-03][05:28:30] x264 [info]: mb B I16..4: 0.3% 3.6% 0.7% B16..8: 36.3% 9.1% 2.5% direct: 3.9% skip:43.6% L0:38.6% L1:43.1% BI:18.3%
[2020-05-03][05:28:30] x264 [info]: 8x8 transform intra:76.4% inter:62.4%
[2020-05-03][05:28:30] x264 [info]: direct mvs spatial:99.6% temporal:0.4%
[2020-05-03][05:28:30] x264 [info]: coded y,uvDC,uvAC intra: 85.4% 86.9% 59.8% inter: 16.9% 17.8% 3.0%
[2020-05-03][05:28:30] x264 [info]: i16 v,h,dc,p: 22% 7% 6% 64%
[2020-05-03][05:28:30] x264 [info]: i8 v,h,dc,ddl,ddr,vr,hd,vl,hu: 25% 9% 7% 7% 9% 12% 9% 12% 11%
[2020-05-03][05:28:30] x264 [info]: i4 v,h,dc,ddl,ddr,vr,hd,vl,hu: 24% 5% 3% 8% 13% 16% 9% 12% 8%
[2020-05-03][05:28:30] x264 [info]: i8c dc,h,v,p: 36% 18% 27% 18%
[2020-05-03][05:28:30] x264 [info]: Weighted P-Frames: Y:9.1% UV:5.1%
[2020-05-03][05:28:30] x264 [info]: ref P L0: 62.4% 14.0% 15.2% 4.9% 3.2% 0.3% 0.0%
[2020-05-03][05:28:30] x264 [info]: ref B L0: 88.5% 8.3% 2.6% 0.6%
[2020-05-03][05:28:30] x264 [info]: ref B L1: 96.5% 3.5%
[2020-05-03][05:28:30] x264 [info]: kb/s:3152.49
[2020-05-03][05:28:30] encoded 2000 frames, 17.02 fps, 3152.57 kb/s

opt=2

[2020-05-03][05:28:35] y4m [info]: 1280x536p 1:1 @ 24000/1001 fps (cfr)
[2020-05-03][05:28:35] x264 [info]: using SAR=1/1
[2020-05-03][05:28:35] x264 [info]: using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX
[2020-05-03][05:28:35] x264 [info]: profile High, level 4.0, 4:2:0, 8-bit
[2020-05-03][05:30:29] x264 [info]: frame I:65 Avg QP:15.61 size:101210
[2020-05-03][05:30:29] x264 [info]: frame P:548 Avg QP:20.40 size: 26700
[2020-05-03][05:30:29] x264 [info]: frame B:1387 Avg QP:23.81 size: 8408
[2020-05-03][05:30:29] x264 [info]: consecutive B-frames: 5.5% 5.6% 14.2% 59.4% 7.5% 7.8%
[2020-05-03][05:30:29] x264 [info]: mb I I16..4: 4.0% 70.9% 25.1%
[2020-05-03][05:30:29] x264 [info]: mb P I16..4: 1.7% 17.6% 3.4% P16..4: 36.0% 16.7% 14.0% 1.0% 0.3% skip: 9.3%
[2020-05-03][05:30:29] x264 [info]: mb B I16..4: 0.2% 3.6% 0.7% B16..8: 36.4% 9.2% 2.5% direct: 3.9% skip:43.6% L0:38.6% L1:43.1% BI:18.3%
[2020-05-03][05:30:29] x264 [info]: 8x8 transform intra:76.4% inter:62.3%
[2020-05-03][05:30:29] x264 [info]: direct mvs spatial:99.6% temporal:0.4%
[2020-05-03][05:30:29] x264 [info]: coded y,uvDC,uvAC intra: 85.4% 86.9% 59.8% inter: 16.9% 17.8% 3.0%
[2020-05-03][05:30:29] x264 [info]: i16 v,h,dc,p: 22% 7% 7% 64%
[2020-05-03][05:30:29] x264 [info]: i8 v,h,dc,ddl,ddr,vr,hd,vl,hu: 25% 9% 7% 6% 9% 12% 9% 12% 11%
[2020-05-03][05:30:29] x264 [info]: i4 v,h,dc,ddl,ddr,vr,hd,vl,hu: 24% 5% 4% 8% 13% 16% 9% 12% 8%
[2020-05-03][05:30:29] x264 [info]: i8c dc,h,v,p: 37% 18% 27% 18%
[2020-05-03][05:30:29] x264 [info]: Weighted P-Frames: Y:9.1% UV:5.1%
[2020-05-03][05:30:29] x264 [info]: ref P L0: 62.4% 14.0% 15.3% 4.9% 3.2% 0.3% 0.0%
[2020-05-03][05:30:29] x264 [info]: ref B L0: 88.5% 8.2% 2.6% 0.6%
[2020-05-03][05:30:29] x264 [info]: ref B L1: 96.5% 3.5%
[2020-05-03][05:30:29] x264 [info]: kb/s:3152.61
[2020-05-03][05:30:29] encoded 2000 frames, 17.00 fps, 3152.69 kb/s

opt=3

[2020-05-03][05:30:35] y4m [info]: 1280x536p 1:1 @ 24000/1001 fps (cfr)
[2020-05-03][05:30:35] x264 [info]: using SAR=1/1
[2020-05-03][05:30:35] x264 [info]: using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX
[2020-05-03][05:30:35] x264 [info]: profile High, level 4.0, 4:2:0, 8-bit
[2020-05-03][05:32:28] x264 [info]: frame I:65 Avg QP:15.62 size:101210
[2020-05-03][05:32:28] x264 [info]: frame P:548 Avg QP:20.39 size: 26706
[2020-05-03][05:32:28] x264 [info]: frame B:1387 Avg QP:23.78 size: 8408
[2020-05-03][05:32:28] x264 [info]: consecutive B-frames: 5.5% 5.6% 14.1% 59.8% 7.2% 7.8%
[2020-05-03][05:32:28] x264 [info]: mb I I16..4: 4.1% 71.0% 25.0%
[2020-05-03][05:32:28] x264 [info]: mb P I16..4: 1.7% 17.6% 3.4% P16..4: 36.0% 16.7% 14.0% 1.0% 0.3% skip: 9.3%
[2020-05-03][05:32:28] x264 [info]: mb B I16..4: 0.2% 3.6% 0.7% B16..8: 36.3% 9.1% 2.5% direct: 4.0% skip:43.6% L0:38.6% L1:43.2% BI:18.3%
[2020-05-03][05:32:28] x264 [info]: 8x8 transform intra:76.4% inter:62.3%
[2020-05-03][05:32:28] x264 [info]: direct mvs spatial:99.6% temporal:0.4%
[2020-05-03][05:32:28] x264 [info]: coded y,uvDC,uvAC intra: 85.4% 86.8% 59.7% inter: 16.9% 17.9% 3.0%
[2020-05-03][05:32:28] x264 [info]: i16 v,h,dc,p: 22% 7% 7% 64%
[2020-05-03][05:32:28] x264 [info]: i8 v,h,dc,ddl,ddr,vr,hd,vl,hu: 25% 9% 7% 7% 9% 12% 9% 12% 11%
[2020-05-03][05:32:28] x264 [info]: i4 v,h,dc,ddl,ddr,vr,hd,vl,hu: 24% 5% 3% 8% 13% 16% 9% 12% 8%
[2020-05-03][05:32:28] x264 [info]: i8c dc,h,v,p: 36% 18% 27% 18%
[2020-05-03][05:32:28] x264 [info]: Weighted P-Frames: Y:9.1% UV:5.1%
[2020-05-03][05:32:28] x264 [info]: ref P L0: 62.4% 14.0% 15.2% 4.9% 3.2% 0.3% 0.0%
[2020-05-03][05:32:28] x264 [info]: ref B L0: 88.5% 8.3% 2.6% 0.6%
[2020-05-03][05:32:28] x264 [info]: ref B L1: 96.6% 3.4%
[2020-05-03][05:32:28] x264 [info]: kb/s:3152.91
[2020-05-03][05:32:28] encoded 2000 frames, 17.06 fps, 3152.98 kb/s

The script

DGSource("test v2.dgi", crop_l=0, crop_r=0, crop_t=0, crop_b=0, deinterlace=0, use_top_field=true, use_pf=true)

CompTest(5, 40)

RequestLinear(rlim=50, clim=50)

BlackmanResize(1280, 536, taps=9)

neo_fft3d(sigma=1.0, beta=1.0, bw=48, bh=48, sharpen=0.040, scutoff=0.01, y=3, u=2, v=2, bt=5, opt=0)

GradFun3(thr=0.35)

avstp_set_threads(1)

Prefetch(3)

return last

The CompTest-Script (.avsi)

function CompTest(clip c, float percent, float frames)
{
frange = floor((frames/1.)/(percent/100.))
return SelectRangeEvery(c, frange, int(frames))
}

- edit -

Ha! Could it be the mtmodes.avsi? I did not make any new entry for neo_fft3d ... Should be like ...

SetFilterMTMode("neo_fft3d", MT_MULTI_INSTANCE)

.. this could explain it, couldn't it?

[MeteorRain]

Don't do set filter mt mode.

Can you please give me a sample script like the one below?

some_source
some_preprocessing

v1 = neo_fft3d(some parameters, opt=1)
v2 = neo_fft3d(some parameters, opt=2)
compare(v1, v2)

Make sure you read non-identical result. Try to give me a minimal script so I can narrow down issue easily.

EDIT:

To narrow down further, please tell me whether you can reproduce it under non-MT mode. Is the problem specific to MT mode only?

[almosely]

Is this different (enough)?



DGSource("test v3.dgi", crop_l=0, crop_r=0, crop_t=0, crop_b=0, deinterlace=0, use_top_field=true, use_pf=true)

RequestLinear(rlim=50, clim=50)

BlackmanResize(640, 360, taps=16)

v1 = neo_fft3d(sigma=1.0, beta=1.0, bw=48, bh=48, sharpen=0.040, scutoff=0.01, y=3, u=2, v=2, bt=5, opt=1)
v2 = neo_fft3d(sigma=1.0, beta=1.0, bw=48, bh=48, sharpen=0.040, scutoff=0.01, y=3, u=2, v=2, bt=5, opt=2)
compare(v1, v2)

avstp_set_threads(1)

Prefetch(3)

return last

- edit -

There's no difference between ST and MT mode with this (I mean: There are still these differences like in the picture above).

# avstp_set_threads(1)

# Prefetch(3)

[MeteorRain]

Thanks.

3 issues were fixed.

1) When input is Y8, the engine was incorrectly skipped.

2) Chroma processing had incorrect negative value float to int rounding.
For positive values, the rounding was correct.
For example, x = 2.1, int(x + 0.5) = 2.
However for a negative value, x = -2.1, int(x + 0.5) -> int(-1.6) -> -1.
Since chroma is processed as signed integer, negative values were incorrectly rounded.

3) bt=5 had a rounding error between C and SIMD code.
Basically in SIMD I was doing result=(a+b)+(c+d)+e while in C code it's result=a+b+c+d+e, resulting a minor rounding error.
Now the C code is the same as SIMD code, and is different to fft3dfilter.

Please try r7.

[almosely]

Yeehaa! Thank you very much :-) I can't see any difference with the last script anymore.

... but there's still a minor difference regarding chroma:

[MeteorRain]

Try sigma=0.001.

[almosely]

What a magical mystery! ;-))) ... tried, worked ... set the value-range-change back to 0.1 after that test. Thank you again!

[StvG]

v1 = neo_fft3d(sigma=1.0, beta=1.0, bw=48, bh=48, sharpen=0.040, scutoff=0.01, y=3, u=2, v=2, bt=5, opt=4)
v2 = neo_fft3d(sigma=1.0, beta=1.0, bw=48, bh=48, sharpen=0.040, scutoff=0.01, y=3, u=2, v=2, bt=5, opt=2)
compare(v1, v2)

There is difference with r7.